Page MenuHomePhabricator

ArcsinX (Aleksandr Platonov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2019, 11:28 AM (133 w, 3 d)

Recent Activity

Apr 13 2022

ArcsinX committed rGb2c3ae0b6f05: [Sema] Don't check bounds for function pointer (authored by ArcsinX).
[Sema] Don't check bounds for function pointer
Apr 13 2022, 10:43 AM · Restricted Project, Restricted Project
ArcsinX closed D122748: [Sema] Don't check bounds for function pointer.
Apr 13 2022, 10:43 AM · Restricted Project, Restricted Project
ArcsinX added a comment to D122748: [Sema] Don't check bounds for function pointer.

Friendly ping

Apr 13 2022, 6:34 AM · Restricted Project, Restricted Project

Apr 6 2022

ArcsinX added a comment to D122748: [Sema] Don't check bounds for function pointer.

Friendly ping.

Apr 6 2022, 4:49 AM · Restricted Project, Restricted Project

Mar 30 2022

ArcsinX added a comment to D122748: [Sema] Don't check bounds for function pointer.

That said, we might not want to early-exist here, I think we can just skip the IsUnboundedArray branch?

It seems you are right, thanks, fixed.

Mar 30 2022, 12:20 PM · Restricted Project, Restricted Project
ArcsinX updated the diff for D122748: [Sema] Don't check bounds for function pointer.

Check for function type only if IsUnboundedArray is true

Mar 30 2022, 12:17 PM · Restricted Project, Restricted Project
ArcsinX requested review of D122748: [Sema] Don't check bounds for function pointer.
Mar 30 2022, 10:21 AM · Restricted Project, Restricted Project

Mar 15 2022

ArcsinX committed rG1bb13b3f4956: Fix sphinx build because of indentation (authored by ArcsinX).
Fix sphinx build because of indentation
Mar 15 2022, 2:12 PM · Restricted Project
ArcsinX committed rG8bd00557e3f4: [clang][parser] Allow GNU attributes before namespace identifier (authored by ArcsinX).
[clang][parser] Allow GNU attributes before namespace identifier
Mar 15 2022, 12:32 PM · Restricted Project
ArcsinX closed D121245: [clang][parser] Allow GNU attributes before namespace identifier.
Mar 15 2022, 12:31 PM · Restricted Project, Restricted Project
ArcsinX added a comment to D121245: [clang][parser] Allow GNU attributes before namespace identifier.

LGTM! Might be worth adding a release note for it (does this close any bugs in the bug database? If so, it'd be worth mentioning those in the commit message and release note).

Mar 15 2022, 9:31 AM · Restricted Project, Restricted Project
ArcsinX updated the diff for D121245: [clang][parser] Allow GNU attributes before namespace identifier.

Update release notes
Rebase

Mar 15 2022, 9:26 AM · Restricted Project, Restricted Project

Mar 12 2022

ArcsinX added inline comments to D121245: [clang][parser] Allow GNU attributes before namespace identifier.
Mar 12 2022, 12:13 PM · Restricted Project, Restricted Project
ArcsinX updated the diff for D121245: [clang][parser] Allow GNU attributes before namespace identifier.
  • get attributes location from ParsedAttributesWithRange object
  • parse subsequent attributes of different kinds in a loop
Mar 12 2022, 12:00 PM · Restricted Project, Restricted Project

Mar 8 2022

ArcsinX requested review of D121245: [clang][parser] Allow GNU attributes before namespace identifier.
Mar 8 2022, 12:37 PM · Restricted Project, Restricted Project

Jan 25 2022

ArcsinX committed rG491c154677bc: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins (authored by ArcsinX).
[analyzer] Don't specify PLUGIN_TOOL for analyzer plugins
Jan 25 2022, 12:06 PM
ArcsinX closed D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.
Jan 25 2022, 12:06 PM · Restricted Project

Jan 21 2022

ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

Have you looked at the impact on binary size? PLUGIN_TOOL _should_ cause the plugins to link against the copy of LLVM & Clang in the tool target binary which reduces the binary size of the plugin and avoids duplicate global initializations.

Jan 21 2022, 11:12 AM · Restricted Project
ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

However, the changes you've made don't look to be specific to building on Windows; this removes PLUGIN_TOOL for all targets. I presume it's still needed for non-Windows targets, isn't it?

As I can see, PLUGIN_TOOL is unused for non-Windows OS (at least for now): https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/AddLLVM.cmake#L648

Jan 21 2022, 5:33 AM · Restricted Project
ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

Friendly ping.

Jan 21 2022, 1:10 AM · Restricted Project

Jan 14 2022

ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

To be clear, I'm trying to figure out whether plugins are *actually* supported on Windows or whether they just so happen to work if the stars line up right for you. If they're supported, then awesome, let's go forward with this. If they're not supported, it's less clear whether we want to make it easier for the stars to line up or not.

Jan 14 2022, 5:53 AM · Restricted Project
ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

AFAIK, we don't support plugins on Windows. See: https://reviews.llvm.org/D16761#1441359 I don't think anything has changed in this regard.

Jan 14 2022, 5:04 AM · Restricted Project

Jan 13 2022

ArcsinX added a comment to D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.

This is only observable on Windows, right?

Jan 13 2022, 10:28 PM · Restricted Project

Jan 10 2022

ArcsinX requested review of D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins.
Jan 10 2022, 12:15 PM · Restricted Project

Dec 19 2021

ArcsinX committed rG555eacf75f21: [clangd] Fix undefined behavior when generating error message at rename with an… (authored by ArcsinX).
[clangd] Fix undefined behavior when generating error message at rename with an…
Dec 19 2021, 11:30 AM
ArcsinX closed D115959: [clangd] Fix undefined behavior when generating error message at rename with an invalid name.
Dec 19 2021, 11:30 AM · Restricted Project

Dec 17 2021

ArcsinX requested review of D115959: [clangd] Fix undefined behavior when generating error message at rename with an invalid name.
Dec 17 2021, 11:38 AM · Restricted Project

Aug 8 2021

ArcsinX abandoned D107304: [clangd][query-driver] Extract GCC version from the driver output.

As I can see, no chances for this to get approved. So. closing.

Aug 8 2021, 11:44 AM · Restricted Project

Aug 4 2021

ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

Clang's current answer is "yes we are GCC >=4, but no we are not GCC >=5".
This causes the codebase to reject the compiler, because it relies on features/absence of bugs from GCC 5. @ArcsinX any idea what these are, concretely?

The checks about GCC version that I saw were related with some features from C++ standard that GCC < 4.X.Y doesn't support and there was a try to implement these features for GCC < 4.X.Y, but clang (or system headers got from query driver?) has these features and some kind of conflict appears.

Aug 4 2021, 12:13 PM · Restricted Project
ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

Ok if you think that setting GCC version to higher values by default won't break anything,

I think that GCC version should be the same, which was used to build the project: it can be higher or lower than 4.2.1

Aug 4 2021, 10:34 AM · Restricted Project

Aug 3 2021

ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

But I am not convinced that changing the default behaviour here is going to be beneficial for majority of the users.

I think that majority of users doesn't use --query-driver at all.

Aug 3 2021, 9:53 PM · Restricted Project
ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

@kadircet Thanks for clarification. Now your position is clear for me.

Aug 3 2021, 9:51 AM · Restricted Project
ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

The most confusing thing for me that we already have this implicitly set -fgnuc-version=4.2.1. So, we already have implicitly set GNUC and other GCC macros as a default behavior.

It might be because clang actually supports all the GNU extensions up until 4.2.1, I don't know the history here, but if clang can compile with that GNUC macro by default, clangd should be good as well. But there are no promises for anything higher than that.

Aug 3 2021, 2:59 AM · Restricted Project
ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

I am not sure this is a good idea. Surely we can go with this approach and pretend to have the same GNUC version as the toolchain, but we are still using clang underneath as @joerg pointed out and we might not be able to parse language/compiler extensions supported by GNU compilers, which will lead to confusion.

Aug 3 2021, 1:56 AM · Restricted Project

Aug 2 2021

ArcsinX added a comment to D107304: [clangd][query-driver] Extract GCC version from the driver output.

What do you mean with "GCC macros are correct"?

Aug 2 2021, 2:55 PM · Restricted Project
ArcsinX updated the summary of D107304: [clangd][query-driver] Extract GCC version from the driver output.
Aug 2 2021, 1:02 PM · Restricted Project
ArcsinX requested review of D107304: [clangd][query-driver] Extract GCC version from the driver output.
Aug 2 2021, 12:53 PM · Restricted Project

Jun 30 2021

ArcsinX committed rGa62579fc008e: [clangd][nfc] Show more information in logs when compiler instance prepare fails (authored by ArcsinX).
[clangd][nfc] Show more information in logs when compiler instance prepare fails
Jun 30 2021, 1:59 PM
ArcsinX closed D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails.
Jun 30 2021, 1:59 PM · Restricted Project
ArcsinX updated the summary of D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails.
Jun 30 2021, 1:35 PM · Restricted Project

Jun 29 2021

ArcsinX updated the diff for D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails.

Check ASTDiags.take() for empty instead of ASTDiags.getNumErrors() value check

Jun 29 2021, 3:43 PM · Restricted Project

Jun 10 2021

ArcsinX requested review of D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails.
Jun 10 2021, 1:44 PM · Restricted Project

Mar 26 2021

ArcsinX committed rG203b072dd23b: [CMake][gRPC] Fix a typo in protobuf version variable name (authored by ArcsinX).
[CMake][gRPC] Fix a typo in protobuf version variable name
Mar 26 2021, 9:34 AM
ArcsinX closed D99405: [CMake][gRPC] Fix a typo in protobuf version variable name.
Mar 26 2021, 9:33 AM · Restricted Project
ArcsinX requested review of D99405: [CMake][gRPC] Fix a typo in protobuf version variable name.
Mar 26 2021, 3:00 AM · Restricted Project

Mar 5 2021

ArcsinX committed rGc4efd04f18c7: [clangd] Use URIs instead of paths in the index file list (authored by ArcsinX).
[clangd] Use URIs instead of paths in the index file list
Mar 5 2021, 11:48 PM
ArcsinX closed D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 5 2021, 11:48 PM · Restricted Project

Mar 4 2021

ArcsinX added a comment to D97535: [clangd] Use URIs instead of paths in the index file list.

Thank you for review!

Mar 4 2021, 10:23 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.

Call FileIndex::updateMain() with an absolute file path in tests to avoid test failures in debug mode.

Mar 4 2021, 10:03 AM · Restricted Project

Mar 3 2021

ArcsinX updated the summary of D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 3 2021, 10:56 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.
  • use URIs as keys
  • create the file list from the keys
Mar 3 2021, 10:51 AM · Restricted Project

Mar 2 2021

ArcsinX planned changes to D97535: [clangd] Use URIs instead of paths in the index file list.

But until that day, I suppose the best we can do is change the contract of FileSymbols to sey keys are always URIs representing the file producing associated slabs.

Agree. I will rework this patch.

Mar 2 2021, 7:46 AM · Restricted Project
ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 2 2021, 2:36 AM · Restricted Project

Mar 1 2021

ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 1 2021, 6:27 AM · Restricted Project

Feb 27 2021

ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Feb 27 2021, 7:04 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.
  • Do not insert the keys into the file list
  • Iterate through refs and symbols to create the file list after releasing the lock
Feb 27 2021, 7:02 AM · Restricted Project

Feb 26 2021

ArcsinX added reviewers for D97535: [clangd] Use URIs instead of paths in the index file list: sammccall, kadircet, hokein.

Initial discussion D94952#inline-892421

Feb 26 2021, 1:08 AM · Restricted Project
ArcsinX requested review of D97535: [clangd] Use URIs instead of paths in the index file list.
Feb 26 2021, 1:06 AM · Restricted Project

Feb 5 2021

ArcsinX committed rG91698fe45f60: [clangd] Take into account what is in the index (symbols, references, etc.) at… (authored by ArcsinX).
[clangd] Take into account what is in the index (symbols, references, etc.) at…
Feb 5 2021, 2:38 AM
ArcsinX closed D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 5 2021, 2:38 AM · Restricted Project
ArcsinX updated the summary of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 5 2021, 1:30 AM · Restricted Project

Feb 4 2021

ArcsinX added a comment to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.

Thank you for review.

Feb 4 2021, 8:20 AM · Restricted Project
ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
  • Remove default value of IdxContents in FileSymbols constructor.
  • Fix index contents for the preamble index (Symbols => Symbols|Relations).
  • Rebase
Feb 4 2021, 8:17 AM · Restricted Project
ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 4 2021, 2:59 AM · Restricted Project
ArcsinX updated the summary of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 4 2021, 2:51 AM · Restricted Project

Jan 27 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 27 2021, 9:36 AM · Restricted Project
ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
  • Set IdxContents at FileSymbols object breation instead of at FileSymbols::buildIndex() call.
  • Revert change of the preamble index key scheme
  • Add comment for IndexContents
  • IndexDataKind => IndexContents
Jan 27 2021, 9:25 AM · Restricted Project
ArcsinX added inline comments to D95349: [clangd] Allow diagnostics to be suppressed with configuration.
Jan 27 2021, 6:10 AM · Restricted Project

Jan 26 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 26 2021, 12:33 AM · Restricted Project

Jan 25 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 25 2021, 10:22 PM · Restricted Project
ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 25 2021, 10:30 AM · Restricted Project

Jan 22 2021

ArcsinX committed rG7388c3468595: [clangd][SwapIndex] ensure that the old index is alive while we are using it… (authored by ArcsinX).
[clangd][SwapIndex] ensure that the old index is alive while we are using it…
Jan 22 2021, 5:31 AM
ArcsinX closed D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.
Jan 22 2021, 5:31 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Fix format

Jan 22 2021, 2:48 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Call snapshot() only once to avoid possible race.

Jan 22 2021, 2:21 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Fix format

Jan 22 2021, 12:28 AM · Restricted Project

Jan 21 2021

ArcsinX requested review of D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.
Jan 21 2021, 11:20 PM · Restricted Project

Jan 19 2021

ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.

Prevent crash in debug mode.

Jan 19 2021, 4:19 AM · Restricted Project
ArcsinX added reviewers for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge: sammccall, kadircet.

Initial discussion https://reviews.llvm.org/D93683?id=313280#inline-875666

Jan 19 2021, 12:41 AM · Restricted Project
ArcsinX requested review of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 19 2021, 12:40 AM · Restricted Project

Jan 14 2021

ArcsinX committed rG2e25be0b6134: [clangd] Add main file macros into the main-file index. (authored by ArcsinX).
[clangd] Add main file macros into the main-file index.
Jan 14 2021, 4:11 AM
ArcsinX closed D94477: [clangd] Add main file macros into the main-file index..
Jan 14 2021, 4:11 AM · Restricted Project
ArcsinX added a comment to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.

It seems that this patch breaks clangd build with GCC 5.4 (reverting this patch fixes the build)

Jan 14 2021, 3:55 AM · Restricted Project

Jan 12 2021

ArcsinX updated the diff for D94477: [clangd] Add main file macros into the main-file index..
  • std::pair<Range, bool> => struct MacroOccurrence
  • remove addressed fixme comment
  • assert() => cantFail()
  • use toSourceCode() to get the macro name
Jan 12 2021, 11:49 PM · Restricted Project
ArcsinX added reviewers for D94477: [clangd] Add main file macros into the main-file index.: sammccall, kadircet.

I am not happy with my solution, hope to hear an advice.
Initial discussion about this problem: https://reviews.llvm.org/D93683#2468842

Jan 12 2021, 1:57 AM · Restricted Project
ArcsinX requested review of D94477: [clangd] Add main file macros into the main-file index..
Jan 12 2021, 1:53 AM · Restricted Project

Jan 6 2021

ArcsinX committed rG979228f120f4: [clangd][fuzzyFind] Do not show stale symbols in the result. (authored by ArcsinX).
[clangd][fuzzyFind] Do not show stale symbols in the result.
Jan 6 2021, 12:18 AM
ArcsinX closed D93796: [clangd][fuzzyFind] Do not show stale symbols in the result..
Jan 6 2021, 12:18 AM · Restricted Project

Dec 24 2020

ArcsinX requested review of D93796: [clangd][fuzzyFind] Do not show stale symbols in the result..
Dec 24 2020, 12:49 AM · Restricted Project

Dec 23 2020

ArcsinX committed rG2522fa053b62: [clangd] Do not take stale definition from the static index. (authored by ArcsinX).
[clangd] Do not take stale definition from the static index.
Dec 23 2020, 7:22 AM
ArcsinX closed D93683: [clangd] Do not take stale definition from the static index..
Dec 23 2020, 7:22 AM · Restricted Project
ArcsinX added a comment to D93683: [clangd] Do not take stale definition from the static index..

I'm not 100% sure this bug would block adding the equivalent change for fuzzyFind though - it'll affect documentSymbol but not code-completion IIUC (because of the workaround I mentioned above). And these symbols are pretty rare.

With the similar change for fuzzyFind(), WorkspaceSymbols.Macros test fails. But maybe I can create one more review for this and we will discuss it there.

Sorry, incomplete thought. I meant workspace/symbols would be broken for such macros, but maybe that was acceptable (it's not a terrible common feature nor symbol kind). Not great but we're trading one bug for another.
In particular, if we plan to fix both I don't think the *sequencing* matters.

Dec 23 2020, 1:31 AM · Restricted Project
ArcsinX updated the diff for D93683: [clangd] Do not take stale definition from the static index..

Add comment.
Fix possible MergeIndexTest.LookupRemovedDefinition test failure.

Dec 23 2020, 1:25 AM · Restricted Project

Dec 22 2020

ArcsinX added a comment to D93683: [clangd] Do not take stale definition from the static index..

I'm not 100% sure this bug would block adding the equivalent change for fuzzyFind though - it'll affect documentSymbol but not code-completion IIUC (because of the workaround I mentioned above). And these symbols are pretty rare.

With the similar change for fuzzyFind(), WorkspaceSymbols.Macros test fails. But maybe I can create one more review for this and we will discuss it there.

Dec 22 2020, 11:27 PM · Restricted Project
ArcsinX updated the diff for D93683: [clangd] Do not take stale definition from the static index..
  • Simplify test.
  • Revert PreambleSymbols.update() first argument change.
Dec 22 2020, 6:31 AM · Restricted Project
ArcsinX added reviewers for D93683: [clangd] Do not take stale definition from the static index.: sammccall, kadircet.

I also want to propose the similar patch for fuzzyFind() (as a part of this patch or a separate one), but I faced the following problem:

Dec 22 2020, 3:30 AM · Restricted Project
ArcsinX requested review of D93683: [clangd] Do not take stale definition from the static index..
Dec 22 2020, 3:22 AM · Restricted Project

Dec 18 2020

ArcsinX committed rGe35f9229dcb2: [clangd] Ignore the static index refs from the dynamic index files. (authored by ArcsinX).
[clangd] Ignore the static index refs from the dynamic index files.
Dec 18 2020, 4:37 AM
ArcsinX closed D93393: [clangd] Ignore the static index refs from the dynamic index files..
Dec 18 2020, 4:37 AM · Restricted Project
ArcsinX updated the summary of D93393: [clangd] Ignore the static index refs from the dynamic index files..
Dec 18 2020, 3:20 AM · Restricted Project