Page MenuHomePhabricator

ArcsinX (Aleksandr Platonov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2019, 11:28 AM (78 w, 2 d)

Recent Activity

Thu, Jun 10

ArcsinX requested review of D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails.
Thu, Jun 10, 1:44 PM · Restricted Project

Mar 26 2021

ArcsinX committed rG203b072dd23b: [CMake][gRPC] Fix a typo in protobuf version variable name (authored by ArcsinX).
[CMake][gRPC] Fix a typo in protobuf version variable name
Mar 26 2021, 9:34 AM
ArcsinX closed D99405: [CMake][gRPC] Fix a typo in protobuf version variable name.
Mar 26 2021, 9:33 AM · Restricted Project
ArcsinX requested review of D99405: [CMake][gRPC] Fix a typo in protobuf version variable name.
Mar 26 2021, 3:00 AM · Restricted Project

Mar 5 2021

ArcsinX committed rGc4efd04f18c7: [clangd] Use URIs instead of paths in the index file list (authored by ArcsinX).
[clangd] Use URIs instead of paths in the index file list
Mar 5 2021, 11:48 PM
ArcsinX closed D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 5 2021, 11:48 PM · Restricted Project

Mar 4 2021

ArcsinX added a comment to D97535: [clangd] Use URIs instead of paths in the index file list.

Thank you for review!

Mar 4 2021, 10:23 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.

Call FileIndex::updateMain() with an absolute file path in tests to avoid test failures in debug mode.

Mar 4 2021, 10:03 AM · Restricted Project

Mar 3 2021

ArcsinX updated the summary of D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 3 2021, 10:56 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.
  • use URIs as keys
  • create the file list from the keys
Mar 3 2021, 10:51 AM · Restricted Project

Mar 2 2021

ArcsinX planned changes to D97535: [clangd] Use URIs instead of paths in the index file list.

But until that day, I suppose the best we can do is change the contract of FileSymbols to sey keys are always URIs representing the file producing associated slabs.

Agree. I will rework this patch.

Mar 2 2021, 7:46 AM · Restricted Project
ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 2 2021, 2:36 AM · Restricted Project

Mar 1 2021

ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Mar 1 2021, 6:27 AM · Restricted Project

Feb 27 2021

ArcsinX added inline comments to D97535: [clangd] Use URIs instead of paths in the index file list.
Feb 27 2021, 7:04 AM · Restricted Project
ArcsinX updated the diff for D97535: [clangd] Use URIs instead of paths in the index file list.
  • Do not insert the keys into the file list
  • Iterate through refs and symbols to create the file list after releasing the lock
Feb 27 2021, 7:02 AM · Restricted Project

Feb 26 2021

ArcsinX added reviewers for D97535: [clangd] Use URIs instead of paths in the index file list: sammccall, kadircet, hokein.

Initial discussion D94952#inline-892421

Feb 26 2021, 1:08 AM · Restricted Project
ArcsinX requested review of D97535: [clangd] Use URIs instead of paths in the index file list.
Feb 26 2021, 1:06 AM · Restricted Project

Feb 5 2021

ArcsinX committed rG91698fe45f60: [clangd] Take into account what is in the index (symbols, references, etc.) at… (authored by ArcsinX).
[clangd] Take into account what is in the index (symbols, references, etc.) at…
Feb 5 2021, 2:38 AM
ArcsinX closed D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 5 2021, 2:38 AM · Restricted Project
ArcsinX updated the summary of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 5 2021, 1:30 AM · Restricted Project

Feb 4 2021

ArcsinX added a comment to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.

Thank you for review.

Feb 4 2021, 8:20 AM · Restricted Project
ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
  • Remove default value of IdxContents in FileSymbols constructor.
  • Fix index contents for the preamble index (Symbols => Symbols|Relations).
  • Rebase
Feb 4 2021, 8:17 AM · Restricted Project
ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 4 2021, 2:59 AM · Restricted Project
ArcsinX updated the summary of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Feb 4 2021, 2:51 AM · Restricted Project

Jan 27 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 27 2021, 9:36 AM · Restricted Project
ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
  • Set IdxContents at FileSymbols object breation instead of at FileSymbols::buildIndex() call.
  • Revert change of the preamble index key scheme
  • Add comment for IndexContents
  • IndexDataKind => IndexContents
Jan 27 2021, 9:25 AM · Restricted Project
ArcsinX added inline comments to D95349: [clangd] Allow diagnostics to be suppressed with configuration.
Jan 27 2021, 6:10 AM · Restricted Project

Jan 26 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 26 2021, 12:33 AM · Restricted Project

Jan 25 2021

ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 25 2021, 10:22 PM · Restricted Project
ArcsinX added inline comments to D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 25 2021, 10:30 AM · Restricted Project

Jan 22 2021

ArcsinX committed rG7388c3468595: [clangd][SwapIndex] ensure that the old index is alive while we are using it… (authored by ArcsinX).
[clangd][SwapIndex] ensure that the old index is alive while we are using it…
Jan 22 2021, 5:31 AM
ArcsinX closed D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.
Jan 22 2021, 5:31 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Fix format

Jan 22 2021, 2:48 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Call snapshot() only once to avoid possible race.

Jan 22 2021, 2:21 AM · Restricted Project
ArcsinX updated the diff for D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.

Fix format

Jan 22 2021, 12:28 AM · Restricted Project

Jan 21 2021

ArcsinX requested review of D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.
Jan 21 2021, 11:20 PM · Restricted Project

Jan 19 2021

ArcsinX updated the diff for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.

Prevent crash in debug mode.

Jan 19 2021, 4:19 AM · Restricted Project
ArcsinX added reviewers for D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge: sammccall, kadircet.

Initial discussion https://reviews.llvm.org/D93683?id=313280#inline-875666

Jan 19 2021, 12:41 AM · Restricted Project
ArcsinX requested review of D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge.
Jan 19 2021, 12:40 AM · Restricted Project

Jan 14 2021

ArcsinX committed rG2e25be0b6134: [clangd] Add main file macros into the main-file index. (authored by ArcsinX).
[clangd] Add main file macros into the main-file index.
Jan 14 2021, 4:11 AM
ArcsinX closed D94477: [clangd] Add main file macros into the main-file index..
Jan 14 2021, 4:11 AM · Restricted Project
ArcsinX added a comment to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.

It seems that this patch breaks clangd build with GCC 5.4 (reverting this patch fixes the build)

Jan 14 2021, 3:55 AM · Restricted Project

Jan 12 2021

ArcsinX updated the diff for D94477: [clangd] Add main file macros into the main-file index..
  • std::pair<Range, bool> => struct MacroOccurrence
  • remove addressed fixme comment
  • assert() => cantFail()
  • use toSourceCode() to get the macro name
Jan 12 2021, 11:49 PM · Restricted Project
ArcsinX added reviewers for D94477: [clangd] Add main file macros into the main-file index.: sammccall, kadircet.

I am not happy with my solution, hope to hear an advice.
Initial discussion about this problem: https://reviews.llvm.org/D93683#2468842

Jan 12 2021, 1:57 AM · Restricted Project
ArcsinX requested review of D94477: [clangd] Add main file macros into the main-file index..
Jan 12 2021, 1:53 AM · Restricted Project

Jan 6 2021

ArcsinX committed rG979228f120f4: [clangd][fuzzyFind] Do not show stale symbols in the result. (authored by ArcsinX).
[clangd][fuzzyFind] Do not show stale symbols in the result.
Jan 6 2021, 12:18 AM
ArcsinX closed D93796: [clangd][fuzzyFind] Do not show stale symbols in the result..
Jan 6 2021, 12:18 AM · Restricted Project

Dec 24 2020

ArcsinX requested review of D93796: [clangd][fuzzyFind] Do not show stale symbols in the result..
Dec 24 2020, 12:49 AM · Restricted Project

Dec 23 2020

ArcsinX committed rG2522fa053b62: [clangd] Do not take stale definition from the static index. (authored by ArcsinX).
[clangd] Do not take stale definition from the static index.
Dec 23 2020, 7:22 AM
ArcsinX closed D93683: [clangd] Do not take stale definition from the static index..
Dec 23 2020, 7:22 AM · Restricted Project
ArcsinX added a comment to D93683: [clangd] Do not take stale definition from the static index..

I'm not 100% sure this bug would block adding the equivalent change for fuzzyFind though - it'll affect documentSymbol but not code-completion IIUC (because of the workaround I mentioned above). And these symbols are pretty rare.

With the similar change for fuzzyFind(), WorkspaceSymbols.Macros test fails. But maybe I can create one more review for this and we will discuss it there.

Sorry, incomplete thought. I meant workspace/symbols would be broken for such macros, but maybe that was acceptable (it's not a terrible common feature nor symbol kind). Not great but we're trading one bug for another.
In particular, if we plan to fix both I don't think the *sequencing* matters.

Dec 23 2020, 1:31 AM · Restricted Project
ArcsinX updated the diff for D93683: [clangd] Do not take stale definition from the static index..

Add comment.
Fix possible MergeIndexTest.LookupRemovedDefinition test failure.

Dec 23 2020, 1:25 AM · Restricted Project

Dec 22 2020

ArcsinX added a comment to D93683: [clangd] Do not take stale definition from the static index..

I'm not 100% sure this bug would block adding the equivalent change for fuzzyFind though - it'll affect documentSymbol but not code-completion IIUC (because of the workaround I mentioned above). And these symbols are pretty rare.

With the similar change for fuzzyFind(), WorkspaceSymbols.Macros test fails. But maybe I can create one more review for this and we will discuss it there.

Dec 22 2020, 11:27 PM · Restricted Project
ArcsinX updated the diff for D93683: [clangd] Do not take stale definition from the static index..
  • Simplify test.
  • Revert PreambleSymbols.update() first argument change.
Dec 22 2020, 6:31 AM · Restricted Project
ArcsinX added reviewers for D93683: [clangd] Do not take stale definition from the static index.: sammccall, kadircet.

I also want to propose the similar patch for fuzzyFind() (as a part of this patch or a separate one), but I faced the following problem:

Dec 22 2020, 3:30 AM · Restricted Project
ArcsinX requested review of D93683: [clangd] Do not take stale definition from the static index..
Dec 22 2020, 3:22 AM · Restricted Project

Dec 18 2020

ArcsinX committed rGe35f9229dcb2: [clangd] Ignore the static index refs from the dynamic index files. (authored by ArcsinX).
[clangd] Ignore the static index refs from the dynamic index files.
Dec 18 2020, 4:37 AM
ArcsinX closed D93393: [clangd] Ignore the static index refs from the dynamic index files..
Dec 18 2020, 4:37 AM · Restricted Project
ArcsinX updated the summary of D93393: [clangd] Ignore the static index refs from the dynamic index files..
Dec 18 2020, 3:20 AM · Restricted Project
ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

Fix format
Rebase

Dec 18 2020, 3:19 AM · Restricted Project

Dec 17 2020

ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

StringRef => llvm::StringRef in one more place.

Dec 17 2020, 9:37 AM · Restricted Project
ArcsinX added a comment to D93393: [clangd] Ignore the static index refs from the dynamic index files..

Thank you for review!

Dec 17 2020, 9:13 AM · Restricted Project
ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

unique_function<bool(StringRef)> indexedFiles() const => unique_function<bool(StringRef) const> indexedFiles() const
StringRef => llvm::StringRef for consistency

Dec 17 2020, 9:11 AM · Restricted Project
ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

Fix comment inside IndexClient::indexedFiles()

Dec 17 2020, 8:14 AM · Restricted Project
ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

Make indexedFiles() to return [](StringRef){return false;} instead of nullptr.
Add comments.
Do not call indexedFiles() at every file check for MergeIndex.
Consume error if URI::resolve() fails.

Dec 17 2020, 7:34 AM · Restricted Project
ArcsinX added a comment to D93393: [clangd] Ignore the static index refs from the dynamic index files..

Thanks for your reply. I have updated the patch (changed signature of hasFile), but remote-index scenario is not clear for me yet.

Dec 17 2020, 4:06 AM · Restricted Project
ArcsinX updated the diff for D93393: [clangd] Ignore the static index refs from the dynamic index files..

bool SymbolIndex::hasFile(llvm::StringRef) => llvm::unique_function<bool(llvm::StringRef)> SymbolIndex::indexedFiles()

Dec 17 2020, 3:54 AM · Restricted Project

Dec 16 2020

ArcsinX added reviewers for D93393: [clangd] Ignore the static index refs from the dynamic index files.: sammccall, kadircet.
Dec 16 2020, 5:51 AM · Restricted Project
ArcsinX requested review of D93393: [clangd] Ignore the static index refs from the dynamic index files..
Dec 16 2020, 5:49 AM · Restricted Project

Nov 26 2020

ArcsinX committed rG1ca174b6420a: [clangd][query-driver] Extract target (authored by ArcsinX).
[clangd][query-driver] Extract target
Nov 26 2020, 4:09 AM
ArcsinX closed D92012: [clangd][query-driver] Extract target.
Nov 26 2020, 4:09 AM · Restricted Project
ArcsinX added a comment to D92012: [clangd][query-driver] Extract target.

Thanks for review!

Nov 26 2020, 4:02 AM · Restricted Project
ArcsinX updated the summary of D92012: [clangd][query-driver] Extract target.
Nov 26 2020, 3:57 AM · Restricted Project
ArcsinX added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 26 2020, 12:38 AM · Restricted Project
ArcsinX updated the diff for D92012: [clangd][query-driver] Extract target.

Do not override existing target.
Fix clang-tidy warning.
Address review comments.

Nov 26 2020, 12:30 AM · Restricted Project

Nov 25 2020

ArcsinX added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 25 2020, 4:56 AM · Restricted Project
ArcsinX updated the diff for D92012: [clangd][query-driver] Extract target.

Add structure to hold system includes and target.
Use state machine to go though lines of the driver output.
Handle invalid target
Use '--target=X' instead of '-target X'

Nov 25 2020, 4:49 AM · Restricted Project

Nov 24 2020

ArcsinX added reviewers for D92012: [clangd][query-driver] Extract target: sammccall, kadircet.

I'm not sure if this solution is elegant enough. I will be happy to hear advices.

Nov 24 2020, 1:30 AM · Restricted Project
ArcsinX requested review of D92012: [clangd][query-driver] Extract target.
Nov 24 2020, 1:27 AM · Restricted Project

Nov 11 2020

ArcsinX committed rGdad804a193ed: [clangd] Improve clangd-indexer performance (authored by ArcsinX).
[clangd] Improve clangd-indexer performance
Nov 11 2020, 3:39 AM
ArcsinX closed D91051: [clangd] Improve clangd-indexer performance.
Nov 11 2020, 3:39 AM · Restricted Project

Nov 10 2020

ArcsinX updated the diff for D91051: [clangd] Improve clangd-indexer performance.

Don't check that AbsPath is not in Files twice.

Nov 10 2020, 11:00 AM · Restricted Project

Nov 9 2020

ArcsinX added a comment to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.
Nov 9 2020, 11:37 PM · Restricted Project, Restricted Project
ArcsinX committed rG1bbf87e22a73: [clangd][remote] Check an index file correctly (authored by ArcsinX).
[clangd][remote] Check an index file correctly
Nov 9 2020, 10:43 AM
ArcsinX closed D91049: [clangd][remote] Check an index file correctly.
Nov 9 2020, 10:43 AM · Restricted Project
ArcsinX added a comment to D91051: [clangd] Improve clangd-indexer performance.

Thank you all for your comments.

Nov 9 2020, 4:57 AM · Restricted Project
ArcsinX updated the diff for D91049: [clangd][remote] Check an index file correctly.

Do not use unique pointer for Index

Nov 9 2020, 12:34 AM · Restricted Project
ArcsinX added reviewers for D91051: [clangd] Improve clangd-indexer performance: sammccall, kadircet, hokein.
Nov 9 2020, 12:16 AM · Restricted Project
ArcsinX requested review of D91051: [clangd] Improve clangd-indexer performance.
Nov 9 2020, 12:15 AM · Restricted Project
ArcsinX added reviewers for D91049: [clangd][remote] Check an index file correctly: kbobyrev, sammccall, kadircet.
Nov 9 2020, 12:01 AM · Restricted Project

Nov 8 2020

ArcsinX requested review of D91049: [clangd][remote] Check an index file correctly.
Nov 8 2020, 11:59 PM · Restricted Project
ArcsinX added inline comments to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.
Nov 8 2020, 11:26 PM · Restricted Project, Restricted Project

Nov 3 2020

ArcsinX added inline comments to D90654: [clangd] Add index server request logging.
Nov 3 2020, 3:22 AM · Restricted Project

Nov 2 2020

ArcsinX added a comment to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.

Hmm, I see. From the looks of it, the solution for several projects would be

add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>")
add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")

But I'm not sure if it makes sense in our case and I don't see many add_compile_options in LLVM. Also, I don't have a way to test it out.

Nov 2 2020, 5:12 AM · Restricted Project, Restricted Project

Oct 29 2020

ArcsinX added inline comments to D90291: [clangd] Add lit tests for remote index.
Oct 29 2020, 7:51 AM · Restricted Project
ArcsinX added inline comments to D90291: [clangd] Add lit tests for remote index.
Oct 29 2020, 4:12 AM · Restricted Project

Oct 25 2020

ArcsinX added a comment to D90116: [llvm] CMake: Force MSVC to read code as UTF-8.

I have face this problem long time ago.
This happens only:

  • on non-English Windows (and could be fixed via system settings: Control Panel -> Clock,Language,and Region -> Region and Language -> Administrative ->Language for non-Unicode programs -> Change system locale -> English).
  • with Visual Studio Compiler
Oct 25 2020, 10:49 AM · Restricted Project, Restricted Project

Oct 23 2020

ArcsinX added a comment to D90016: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path.

The ones you proposed would not work without using llvm::sys::path::* which I avoid :( They have to have an argument from llvm::sys::path:: in order for the lookup to be performed correctly.

Oct 23 2020, 3:05 AM · Restricted Project
ArcsinX added inline comments to D90016: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path.
Oct 23 2020, 2:54 AM · Restricted Project
ArcsinX added inline comments to D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC.
Oct 23 2020, 2:27 AM · Restricted Project