- User Since
- Dec 18 2015, 3:05 AM (271 w, 5 d)
Dec 12 2016
Scanning over what is being proposed here and in D27514, I have just a couple of comments.
Apr 5 2016
Apr 4 2016
Apr 3 2016
Ok, I've removed support for nested parentheses. Can this go through now?
Apr 1 2016
Feb 26 2016
Feb 25 2016
Updated patch according to the comments made. Also spotted a corner-case where a double-diagnostic was produced, for example in the following where one string has too few arguments and the other string too many:
Second bump :o)
Feb 22 2016
Patch additionally re-based off r261522.
Revised patch coming shortly...
I've removed CheckFormatString from Sema.h and make it a static function inside SemaChecking.cpp in r261522. I'll submit a new diff here with the remaining requested changes for this patch when I have a moment.
Feb 18 2016
Feb 15 2016
Richard, are you happy with this latest version? Can I proceed to commit it?
Feb 11 2016
To be honest, the simple answer is because it was just as easy to do with nesting as without (the code would still need to track the appearance of left and right parentheses in order to correctly parse to the closing right-parenthesis of the macro invocation in any case).
Test comment -- just to see whether email notifications are sending properly (it seems, for example, that cfe-commits wasn't notified of this patch...)
Feb 10 2016
All strings matching the highest uncovered argument are now highlighted in the diagnostic.
Feb 3 2016
In your case, the first string would be highlighted only. Yes, I see what you mean. Is it possible to have multiple ranges for the diagnostic? By which I mean, to produce the following:
Thoughts? Am I good to go?
Jan 28 2016
Yes, but only for the "data argument not used" warning. All other warnings are unaffected by the change, for example:
Jan 26 2016
Jan 25 2016
Richard, you have been recommended to me as a suitable reviewer by David. If that's not ok with you, please could you recommend another! Thanks, Andy.
Jan 12 2016
Dec 21 2015
Sorry, I've added you as reviewers by proximity to recent relevant changes in SemaChecking.cpp. Hope you don't mind. Please tell me who to redirect to, if there are more applicable reviewers.