Page MenuHomePhabricator

AndyG (Andy Gibbs)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 18 2015, 3:05 AM (271 w, 5 d)

Recent Activity

Dec 12 2016

AndyG added a comment to D27512: Move clang's ParseHelper into Support (llvm part).

Scanning over what is being proposed here and in D27514, I have just a couple of comments.

Dec 12 2016, 9:23 AM

Apr 5 2016

AndyG committed rL265381: Consolidate and improve the handling of built-in feature-like macros.
Consolidate and improve the handling of built-in feature-like macros
Apr 5 2016, 1:42 AM
AndyG closed D17149: Consolidate and improve the handling of built-in feature-like macros by committing rL265381: Consolidate and improve the handling of built-in feature-like macros.
Apr 5 2016, 1:42 AM

Apr 4 2016

AndyG added inline comments to D17149: Consolidate and improve the handling of built-in feature-like macros.
Apr 4 2016, 2:05 AM
AndyG updated the diff for D17149: Consolidate and improve the handling of built-in feature-like macros.

Implemented comments.

Apr 4 2016, 2:05 AM

Apr 3 2016

AndyG updated the diff for D17149: Consolidate and improve the handling of built-in feature-like macros.

Ok, I've removed support for nested parentheses. Can this go through now?

Apr 3 2016, 2:07 PM

Apr 1 2016

AndyG committed rL265177: Diagnose missing macro argument following charize operator..
Diagnose missing macro argument following charize operator.
Apr 1 2016, 12:07 PM

Feb 26 2016

AndyG committed rL262025: Reduce false positives in printf/scanf format checker.
Reduce false positives in printf/scanf format checker
Feb 26 2016, 7:40 AM
AndyG closed D15636: Reduce false positives in printf/scanf format checker.
Feb 26 2016, 7:39 AM

Feb 25 2016

AndyG added inline comments to D15636: Reduce false positives in printf/scanf format checker.
Feb 25 2016, 7:30 AM
AndyG updated the diff for D15636: Reduce false positives in printf/scanf format checker.

Updated patch according to the comments made. Also spotted a corner-case where a double-diagnostic was produced, for example in the following where one string has too few arguments and the other string too many:

Feb 25 2016, 7:25 AM
AndyG added a comment to D17149: Consolidate and improve the handling of built-in feature-like macros.

Second bump :o)

Feb 25 2016, 6:37 AM

Feb 22 2016

AndyG added inline comments to D15636: Reduce false positives in printf/scanf format checker.
Feb 22 2016, 8:55 AM
AndyG updated the diff for D15636: Reduce false positives in printf/scanf format checker.

Patch additionally re-based off r261522.

Feb 22 2016, 7:47 AM
AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Revised patch coming shortly...

Feb 22 2016, 7:44 AM
AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

I've removed CheckFormatString from Sema.h and make it a static function inside SemaChecking.cpp in r261522. I'll submit a new diff here with the remaining requested changes for this patch when I have a moment.

Feb 22 2016, 5:15 AM
AndyG committed rL261522: Make Sema::CheckFormatString a static function inside SemaChecking.cpp.
Make Sema::CheckFormatString a static function inside SemaChecking.cpp
Feb 22 2016, 5:05 AM

Feb 18 2016

AndyG added a comment to D17149: Consolidate and improve the handling of built-in feature-like macros.

Bump :o)

Feb 18 2016, 1:43 AM

Feb 15 2016

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Richard, are you happy with this latest version? Can I proceed to commit it?

Feb 15 2016, 1:51 AM

Feb 11 2016

AndyG added a comment to D17149: Consolidate and improve the handling of built-in feature-like macros.

To be honest, the simple answer is because it was just as easy to do with nesting as without (the code would still need to track the appearance of left and right parentheses in order to correctly parse to the closing right-parenthesis of the macro invocation in any case).

Feb 11 2016, 11:44 PM
AndyG added a comment to D17149: Consolidate and improve the handling of built-in feature-like macros.

Test comment -- just to see whether email notifications are sending properly (it seems, for example, that cfe-commits wasn't notified of this patch...)

Feb 11 2016, 11:01 AM
AndyG updated D17149: Consolidate and improve the handling of built-in feature-like macros.
Feb 11 2016, 9:19 AM
AndyG retitled D17149: Consolidate and improve the handling of built-in feature-like macros from to Consolidate and improve the handling of built-in feature-like macros.
Feb 11 2016, 9:13 AM

Feb 10 2016

AndyG updated the diff for D15636: Reduce false positives in printf/scanf format checker.

All strings matching the highest uncovered argument are now highlighted in the diagnostic.

Feb 10 2016, 1:14 AM

Feb 3 2016

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

In your case, the first string would be highlighted only. Yes, I see what you mean. Is it possible to have multiple ranges for the diagnostic? By which I mean, to produce the following:

Feb 3 2016, 11:49 PM
AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Thoughts? Am I good to go?

Feb 3 2016, 2:30 PM

Jan 28 2016

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Yes, but only for the "data argument not used" warning. All other warnings are unaffected by the change, for example:

Jan 28 2016, 6:25 AM

Jan 26 2016

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Hi Richard,

Jan 26 2016, 12:06 AM

Jan 25 2016

AndyG added a reviewer for D15636: Reduce false positives in printf/scanf format checker: rtrieu.

Richard, you have been recommended to me as a suitable reviewer by David. If that's not ok with you, please could you recommend another! Thanks, Andy.

Jan 25 2016, 9:27 AM

Jan 12 2016

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Bump! :o)

Jan 12 2016, 1:01 PM

Dec 21 2015

AndyG added a comment to D15636: Reduce false positives in printf/scanf format checker.

Sorry, I've added you as reviewers by proximity to recent relevant changes in SemaChecking.cpp. Hope you don't mind. Please tell me who to redirect to, if there are more applicable reviewers.

Dec 21 2015, 1:39 AM
AndyG edited reviewers for D15636: Reduce false positives in printf/scanf format checker, added: rsmith, dblaikie; removed: cfe-commits.
Dec 21 2015, 1:38 AM

Dec 18 2015

AndyG retitled D15636: Reduce false positives in printf/scanf format checker from to Reduce false positives in printf/scanf format checker.
Dec 18 2015, 3:36 AM