Page MenuHomePhabricator

AndrewScheidecker (Andrew Scheidecker)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 5 2017, 7:15 AM (237 w, 6 d)

Recent Activity

Feb 19 2019

AndrewScheidecker committed rG8ca3f3863ed0: [ConstantFold] Fix misfolding fcmp of a ConstantExpr NaN with itself. (authored by AndrewScheidecker).
[ConstantFold] Fix misfolding fcmp of a ConstantExpr NaN with itself.
Feb 19 2019, 1:24 PM
AndrewScheidecker committed rL354381: [ConstantFold] Fix misfolding fcmp of a ConstantExpr NaN with itself..
[ConstantFold] Fix misfolding fcmp of a ConstantExpr NaN with itself.
Feb 19 2019, 1:21 PM
AndrewScheidecker closed D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.
Feb 19 2019, 1:21 PM · Restricted Project
AndrewScheidecker committed rGbddf892a6d3a: [ConstantFold] Fix misfolding of icmp with a bitcast FP second operand. (authored by AndrewScheidecker).
[ConstantFold] Fix misfolding of icmp with a bitcast FP second operand.
Feb 19 2019, 1:04 PM
AndrewScheidecker committed rL354380: [ConstantFold] Fix misfolding of icmp with a bitcast FP second operand..
[ConstantFold] Fix misfolding of icmp with a bitcast FP second operand.
Feb 19 2019, 1:02 PM
AndrewScheidecker closed D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).
Feb 19 2019, 1:02 PM · Restricted Project
AndrewScheidecker committed rG069af04a4a38: Testing commit access (authored by AndrewScheidecker).
Testing commit access
Feb 19 2019, 12:39 PM
AndrewScheidecker committed rL354378: Testing commit access.
Testing commit access
Feb 19 2019, 12:38 PM

Feb 14 2019

AndrewScheidecker added a comment to D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

LGTM - have you requested commit access?

Feb 14 2019, 10:20 AM · Restricted Project
AndrewScheidecker updated the diff for D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

Added comment, updated the new bitcast.ll tests to reflect the fix, and removed the superfluous IRBuilder tests.

Feb 14 2019, 4:25 AM · Restricted Project

Feb 13 2019

AndrewScheidecker updated the diff for D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).

Rebased, removed the superfluous IRBuilder test, updated the new IR test to reflect the fix, and added an IR test of the equivalent fcmp misfolding.

Feb 13 2019, 5:44 AM · Restricted Project
AndrewScheidecker added a comment to D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).

This took some work, but I have an IR test case that should show the bug:
rL353883

Feb 13 2019, 4:05 AM · Restricted Project

Feb 11 2019

AndrewScheidecker added reviewers for D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty): lebedev.ri, spatel, craig.topper.
Feb 11 2019, 11:52 AM · Restricted Project
AndrewScheidecker added reviewers for D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding: lebedev.ri, spatel, craig.topper.
Feb 11 2019, 11:52 AM · Restricted Project
AndrewScheidecker added a comment to D58049: [InstCombine] Fix matchRotate bug when one operand is a ConstantExpr shift.

LGTM - let me know if I should commit on your behalf.

Feb 11 2019, 9:07 AM · Restricted Project
AndrewScheidecker updated the diff for D58049: [InstCombine] Fix matchRotate bug when one operand is a ConstantExpr shift.

Good point that we can discard the ConstantExpr case entirely.

Feb 11 2019, 8:42 AM · Restricted Project
AndrewScheidecker created D58049: [InstCombine] Fix matchRotate bug when one operand is a ConstantExpr shift.
Feb 11 2019, 4:58 AM · Restricted Project

Feb 7 2019

AndrewScheidecker added a comment to D57871: Fix some cases where icmp (bitcast ([su]itofp X)), Y is misfolded.

No problem.

Feb 7 2019, 11:31 AM · Restricted Project
AndrewScheidecker updated the diff for D57871: Fix some cases where icmp (bitcast ([su]itofp X)), Y is misfolded.

Incorporated @spatel's proposed changes

Feb 7 2019, 11:04 AM · Restricted Project
AndrewScheidecker updated the diff for D57871: Fix some cases where icmp (bitcast ([su]itofp X)), Y is misfolded.

Addressed comments

Feb 7 2019, 3:58 AM · Restricted Project

Feb 6 2019

AndrewScheidecker created D57871: Fix some cases where icmp (bitcast ([su]itofp X)), Y is misfolded.
Feb 6 2019, 6:19 PM · Restricted Project

Oct 22 2018

AndrewScheidecker added a comment to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

This looks good to me, and thanks very much for taking the time to write a test case and fix the infrastructure!

Oct 22 2018, 5:36 AM

Oct 1 2018

AndrewScheidecker added a comment to D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

Ping.

Oct 1 2018, 7:16 AM · Restricted Project
AndrewScheidecker added a comment to D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).

Ping.

Oct 1 2018, 7:16 AM · Restricted Project

Sep 26 2018

AndrewScheidecker updated the diff for D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

I started to write a test, but it turns out that COFF_x86_64_IMGREL.s actually triggers this problem, since it has empty data sections that aren't loaded. It seems to be an accident that the test passes right now: it expects the F@IMGREL operand to be relocated to section_addr(.text)+0, but that should only be true if the image base is 0. I think for that test to be meaningful, it needs to pass an explicit target-addr-start to llvm-rtdyld, and subtract that address from the section_addr it compares against.

Sep 26 2018, 3:59 PM

Sep 19 2018

AndrewScheidecker added a comment to D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

Hm, can we use fast-math flags here? Namely, nnan.

Sep 19 2018, 3:38 PM · Restricted Project
AndrewScheidecker updated the diff for D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).

I made the test a little simpler by bitcasting a GlobalVariable pointer to a float to get a FP typed ConstantExpr, instead of using a bitcast vector.

Sep 19 2018, 1:29 PM · Restricted Project
AndrewScheidecker updated the diff for D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

I made the test a little simpler by bitcasting a GlobalVariable pointer to a float to get a FP typed ConstantExpr, instead of using a bitcast vector.

Sep 19 2018, 1:20 PM · Restricted Project
AndrewScheidecker added inline comments to D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).
Sep 19 2018, 12:51 PM · Restricted Project
AndrewScheidecker added a comment to D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

Clearly, since this patch is here, the previous choice was wrong (i guess?).
So some more blurb with explanation as to why it is so would be good.
(i'm guessing nan / inf etc?)

Sep 19 2018, 8:36 AM · Restricted Project
AndrewScheidecker added a comment to D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).

Ping.

Sep 19 2018, 4:01 AM · Restricted Project
AndrewScheidecker added a comment to D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.

Ping.

Sep 19 2018, 4:01 AM · Restricted Project
AndrewScheidecker added a comment to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Ping.

Sep 19 2018, 3:41 AM

Sep 10 2018

AndrewScheidecker added a comment to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

I don't have commit access; can you commit it?

Sep 10 2018, 10:52 AM

Sep 9 2018

AndrewScheidecker updated the diff for D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Added a comment

Sep 9 2018, 12:21 PM

Aug 28 2018

AndrewScheidecker added a reviewer for D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty): nlewycky.
Aug 28 2018, 4:29 AM · Restricted Project
AndrewScheidecker created D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.
Aug 28 2018, 4:26 AM

Aug 24 2018

AndrewScheidecker created D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding.
Aug 24 2018, 7:03 AM · Restricted Project
AndrewScheidecker created D51215: Fix misfolding of IRBuilder.CreateICmp(int_ty X, bitcast (float_ty Y) to int_ty).
Aug 24 2018, 6:59 AM · Restricted Project

Jan 10 2018

AndrewScheidecker accepted D41893: [WebAssembly] Create synthetic __wasm_call_ctors function.
Jan 10 2018, 4:21 PM

Jan 9 2018

AndrewScheidecker requested changes to D41893: [WebAssembly] Create synthetic __wasm_call_ctors function.
Jan 9 2018, 6:00 PM

Jan 8 2018

AndrewScheidecker added a comment to D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

I don't have commit access. Can somebody please commit this for me?

Jan 8 2018, 10:07 AM

Jan 2 2018

AndrewScheidecker updated the diff for D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

I added parameters to the InitializeUniqueCases function to control the early-outs, so it could theoretically be called by another transform that can support more complex switch statements.

Jan 2 2018, 5:40 AM

Dec 8 2017

AndrewScheidecker added a reviewer for D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion: marcello.maggioni.
Dec 8 2017, 4:53 AM
AndrewScheidecker added a comment to D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

I don't have commit access; can somebody please commit this?

Dec 8 2017, 4:49 AM
AndrewScheidecker updated the diff for D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

Simplified test, and changed iterator variable names to SI/SE.

Dec 8 2017, 4:33 AM

Dec 7 2017

AndrewScheidecker updated the diff for D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

Added a test that produces different results with and without this fix

Dec 7 2017, 3:54 PM

Dec 6 2017

AndrewScheidecker added a comment to D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

I ran the patch through clang-format. But looking at the code again, I see that calling the getEdgeProbability overload with a successor index or iterator instead of the destination basic block actually does something different from the original code: passing a successor index/iterator gets the probability for a single edge, while passing a basic block sums the probability for all edges between the two blocks.

Dec 6 2017, 3:19 PM
AndrewScheidecker updated the diff for D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

Ran the patch through clang-format

Dec 6 2017, 3:17 PM
AndrewScheidecker updated the diff for D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.

Include full context in diff, as suggested on IRC

Dec 6 2017, 5:23 AM
AndrewScheidecker updated the diff for D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.

Include full context in diff, as suggested on IRC

Dec 6 2017, 5:22 AM
AndrewScheidecker created D40892: Add early out to O(n^2) switch analysis in switch-to-select conversion.
Dec 6 2017, 5:05 AM
AndrewScheidecker created D40891: Revert a change in propagateMassToSuccessors that summed redundant edges n^2 times.
Dec 6 2017, 5:03 AM
AndrewScheidecker abandoned D40889: Fix accidentally quadratic time in BlockFrequencyInfoImpl::propagateMassToSuccessors.

Abandoning so I can resubmit with llvm-commits as a subscriber

Dec 6 2017, 5:01 AM
AndrewScheidecker abandoned D40887: Add early out to O(n^2) switch analysis in switch-to-select conversion.

Abandoning so I can resubmit with llvm-commits as a subscriber

Dec 6 2017, 5:01 AM
AndrewScheidecker created D40889: Fix accidentally quadratic time in BlockFrequencyInfoImpl::propagateMassToSuccessors.
Dec 6 2017, 4:55 AM
AndrewScheidecker created D40887: Add early out to O(n^2) switch analysis in switch-to-select conversion.
Dec 6 2017, 4:36 AM