Page MenuHomePhabricator

Ali-Sed (Ali Sedaghati)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2021, 11:13 PM (12 w, 6 d)

Recent Activity

Aug 18 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] Fixing dependency to C++17

Aug 18 2021, 11:57 AM · Restricted Project
Ali-Sed reopened D106001: [NFC] factor out unrolling decision logic.
Aug 18 2021, 11:56 AM · Restricted Project
Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] fixing merge conflicts

Aug 18 2021, 11:08 AM · Restricted Project

Aug 17 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] Fixing conflict issue

Aug 17 2021, 11:24 PM · Restricted Project
Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] mergin temp branch and main

Aug 17 2021, 7:48 PM · Restricted Project
Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] fixing NITs

Aug 17 2021, 7:16 PM · Restricted Project
Ali-Sed retitled D106001: [NFC] factor out unrolling decision logic from [WIP][NFC] factor out unrolling decision logic to [NFC] factor out unrolling decision logic.
Aug 17 2021, 2:37 PM · Restricted Project

Aug 16 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] Decoupling the unrolling logic
Decoupling the unrolling logic into three different functions. The shouldPragmaUnroll() covers the 1st and 2nd priorities of the previous code, the shouldFullUnroll() covers the 3rd, and the shouldPartialUnroll() covers the 5th. The output of each function, Optional<unsigned>, could be a value for UP.Count, which means unrolling factor has been set, or None, which means decision hasn't been made yet and should try the next priority.

Aug 16 2021, 6:01 PM · Restricted Project

Jul 27 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[NFC] Decoupling the unrolling logic into three different functions. The shouldPragmaUnroll() covers the 1st and 2nd priorities of the previous code, the shouldFullUnroll() covers the 3rd, and the shouldPartialUnroll() covers the 5th. The output of each function, Optional<unsigned>, could be a value for UP.Count, which means unrolling factor has been set, or None, which means decision hasn't been made yet and should try the next priority.

Jul 27 2021, 11:40 AM · Restricted Project
Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[WIP][NFC] Changing bool, as the return arg of unrolling logics, to optional<unsigned>

Jul 27 2021, 10:33 AM · Restricted Project

Jul 21 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[WIP][NFC] Cleaning the params of functions --draft

Jul 21 2021, 12:19 PM · Restricted Project
Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[WIP][NFC]Seperating setting UP.count from other side parameters

Jul 21 2021, 8:45 AM · Restricted Project

Jul 14 2021

Ali-Sed updated the diff for D106001: [NFC] factor out unrolling decision logic.

[WIP][NFC] factor out unrolling decision logic

Jul 14 2021, 10:35 AM · Restricted Project
Ali-Sed added reviewers for D106001: [NFC] factor out unrolling decision logic: mtrofin, jdoerfert.
Jul 14 2021, 10:17 AM · Restricted Project
Ali-Sed requested review of D106001: [NFC] factor out unrolling decision logic.
Jul 14 2021, 10:12 AM · Restricted Project

Jul 13 2021

Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

"Adding ShouldContinue as the return value of unrolling logic"

Jul 13 2021, 4:50 PM · Restricted Project
Ali-Sed added a comment to D105173: [WIP][NFC] factor out unrolling decision logic.

The latest revision appears to be missing most of the changes. You may want to squash several commits together in git, and make sure the commit message properly explains the reasoning behind the patch.

Do you intend this to go into LLVM, or are you still experimenting at this point? It may be best to make sure what you come up with will have practical use before making a lot of changes in llvm itself. My understanding is that this code is (overly) complex but it is the order it is for deliberate reasons. All the existing tests have to keep passing, if they are not already.

I would consider runtime unrolling to be the most interesting part of machine learning loop unroll factors, at least on many cpu's.

Jul 13 2021, 12:53 PM · Restricted Project
Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

[WIP][NFC] Adding enum for unrolling option and adding MyDebug for priting

Jul 13 2021, 12:44 PM · Restricted Project

Jul 6 2021

Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

Solving the problems mentioned in the review

Jul 6 2021, 11:53 PM · Restricted Project

Jul 5 2021

Ali-Sed retitled D105173: [WIP][NFC] factor out unrolling decision logic from Initial refactoring to [WIP][NFC] factor out unrolling decision logic.
Jul 5 2021, 6:47 PM · Restricted Project
Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

Adding NFC tag

Jul 5 2021, 6:45 PM · Restricted Project

Jul 2 2021

Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

Squashing all commits

Jul 2 2021, 9:59 AM · Restricted Project
Ali-Sed added reviewers for D105173: [WIP][NFC] factor out unrolling decision logic: mtrofin, jdoerfert.
Jul 2 2021, 9:39 AM · Restricted Project
Ali-Sed updated the diff for D105173: [WIP][NFC] factor out unrolling decision logic.

[WIP] Reformatting using clang-reformat

Jul 2 2021, 9:31 AM · Restricted Project

Jun 30 2021

Ali-Sed requested review of D105173: [WIP][NFC] factor out unrolling decision logic.
Jun 30 2021, 12:04 AM · Restricted Project