Page MenuHomePhabricator

Alexander_Droste (Alexander Droste)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 10 2015, 2:24 AM (192 w, 5 d)

Recent Activity

Dec 15 2016

Alexander_Droste added a comment to D27813: [clang-tidy] fix missing anchor for MPI Module.

Thanks for adding!

Dec 15 2016, 10:42 AM

Aug 12 2016

Alexander_Droste committed rL278553: [clang-tidy] MPIBufferDerefCheck .
[clang-tidy] MPIBufferDerefCheck
Aug 12 2016, 12:38 PM
Alexander_Droste closed D22729: MPIBufferDerefCheck for Clang-Tidy by committing rL278553: [clang-tidy] MPIBufferDerefCheck .
Aug 12 2016, 12:38 PM
Alexander_Droste committed rL278534: Revert test commit.
Revert test commit
Aug 12 2016, 10:54 AM
Alexander_Droste committed rL278533: Test commit - first LLVM repo commit.
Test commit - first LLVM repo commit
Aug 12 2016, 10:51 AM

Aug 10 2016

Alexander_Droste added a comment to D22729: MPIBufferDerefCheck for Clang-Tidy.

No but I guess it would be a good idea to ask for commit access.
I'll proceed like suggested here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.

Aug 10 2016, 2:17 AM

Aug 8 2016

Alexander_Droste added a comment to D22729: MPIBufferDerefCheck for Clang-Tidy.

Great; thanks again for the review!

Aug 8 2016, 10:39 AM

Aug 7 2016

Alexander_Droste updated subscribers of D15332: new clang-tidy checker readability-non-const-parameter.
Aug 7 2016, 10:02 AM

Aug 5 2016

Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • check for nullptr in addBuffer
Aug 5 2016, 9:37 AM
Alexander_Droste added inline comments to D22729: MPIBufferDerefCheck for Clang-Tidy.
Aug 5 2016, 9:31 AM
Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • add release docs
  • simplify reverse for loop -> rbegin, rend
Aug 5 2016, 6:28 AM
Alexander_Droste added inline comments to D22729: MPIBufferDerefCheck for Clang-Tidy.
Aug 5 2016, 6:27 AM

Aug 3 2016

Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • add needed extra line for docs
Aug 3 2016, 11:14 PM
Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • clarify lambda argument with comment
  • explicit cast to int for the number of indirections in for loop
Aug 3 2016, 11:12 PM
Alexander_Droste added a comment to D22729: MPIBufferDerefCheck for Clang-Tidy.
Aug 3 2016, 11:10 PM

Aug 2 2016

Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.

Thanks for re-committing this patch!

Aug 2 2016, 11:36 PM · Restricted Project

Aug 1 2016

Alexander_Droste reopened D21962: MPITypeMismatchCheck for Clang-Tidy.
Aug 1 2016, 5:20 AM · Restricted Project
Alexander_Droste added a comment to D22729: MPIBufferDerefCheck for Clang-Tidy.

Looks like the dependency of this patch D21962 got reverted by some reasons.

I know, I updated the patch after that, in order to fix the problem.

Aug 1 2016, 5:20 AM
Alexander_Droste added a comment to D22729: MPIBufferDerefCheck for Clang-Tidy.

Hi, thanks for having a look!

Aug 1 2016, 5:03 AM

Jul 30 2016

Alexander_Droste added a comment to D20811: [analyzer] Model some library functions.

It has been originally written as a large set of files. If you feel strongly about it, we could merge it into a single file. That makes sense to me. @Alexander_Droste, what do you think?

Jul 30 2016, 12:19 PM

Jul 25 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.

Hi, thanks for the notification! Obviously, on some systems char is unsigned by default
which is why the check now tolerates distinct signedness for char pairs.
http://blog.cdleary.com/2012/11/arm-chars-are-unsigned-by-default/
In addition, I removed the trailing white space from the test file.

Jul 25 2016, 12:50 PM · Restricted Project
Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • remove trailing whitespace
Jul 25 2016, 9:29 AM

Jul 23 2016

Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • fix two MPIdatatype tags
Jul 23 2016, 9:45 AM
Alexander_Droste updated the diff for D22729: MPIBufferDerefCheck for Clang-Tidy.
  • make = count accurate for mpi-buffer-deref.rst
Jul 23 2016, 7:23 AM
Alexander_Droste updated D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 23 2016, 7:05 AM · Restricted Project
Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.

Do you have commit access?

No, I don't have commit access.

Jul 23 2016, 7:03 AM · Restricted Project
Alexander_Droste added a child revision for D21962: MPITypeMismatchCheck for Clang-Tidy: D22729: MPIBufferDerefCheck for Clang-Tidy.
Jul 23 2016, 7:02 AM · Restricted Project
Alexander_Droste added a parent revision for D22729: MPIBufferDerefCheck for Clang-Tidy: D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 23 2016, 7:02 AM
Alexander_Droste retitled D22729: MPIBufferDerefCheck for Clang-Tidy from to MPIBufferDerefCheck for Clang-Tidy.
Jul 23 2016, 7:02 AM
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • use parentheses instead of braces
Jul 23 2016, 3:40 AM · Restricted Project

Jul 22 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • fix typo
Jul 22 2016, 7:18 AM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.

This update addresses all requested changes. All integration tests are still passing.

Jul 22 2016, 7:10 AM · Restricted Project
Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.

You need to add this to ClangTidyMain.cpp:

Thanks for pointing this out and reviewing the code once more!

Jul 22 2016, 7:07 AM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • use new MPIFunctionClassifier.h path
  • change getAsCXXRecordDecl()->getNameAsString() -> getAsCXXRecordDecl()->getName()
  • add comment to addPair lambda
  • rename ArgumentExpression to BufferExprs
  • remove superfluous empty lines
Jul 22 2016, 4:31 AM · Restricted Project
Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 22 2016, 4:21 AM · Restricted Project
Alexander_Droste added a child revision for D22671: MPI-Checker: move MPIFunctionClassifier.h: D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 22 2016, 4:05 AM
Alexander_Droste added a parent revision for D21962: MPITypeMismatchCheck for Clang-Tidy: D22671: MPI-Checker: move MPIFunctionClassifier.h.
Jul 22 2016, 4:05 AM · Restricted Project
Alexander_Droste retitled D22671: MPI-Checker: move MPIFunctionClassifier.h from to MPI-Checker: move MPIFunctionClassifier.h.
Jul 22 2016, 4:02 AM
Alexander_Droste retitled D22670: MPI-Checker fix two comments from to MPI-Checker fix two comments.
Jul 22 2016, 3:39 AM

Jul 21 2016

Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 21 2016, 4:10 PM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • use llvm::StringMap instead of std::map
  • getQualifiedNameAsString -> getName
  • remove redundant map lookup
  • create MPIi module
  • replace misc with mpi within the check
Jul 21 2016, 4:08 PM · Restricted Project

Jul 19 2016

Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.

Thanks for looking over this once more. I'll set up an extra MPI folder and rename the check.

Jul 19 2016, 10:54 AM · Restricted Project

Jul 10 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • simplify argumentType() function
Jul 10 2016, 6:06 AM · Restricted Project

Jul 7 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • fix typo
Jul 7 2016, 2:46 PM · Restricted Project
Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 7 2016, 2:28 PM · Restricted Project
Alexander_Droste added inline comments to D21962: MPITypeMismatchCheck for Clang-Tidy.
Jul 7 2016, 10:47 AM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • make static functions free functions
  • make static containers local to their corresponding functions
  • only assign the buffer type name in case of an error
  • fix capitalization and punctuation in error diagnostic
  • usage of formatting placeholders instead of concatenation
  • move buffer type name variable out of the loop
Jul 7 2016, 10:39 AM · Restricted Project

Jul 4 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • remove TODO
Jul 4 2016, 9:37 AM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.

Thanks for the review!

Jul 4 2016, 9:21 AM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • remove superflous clang::
Jul 4 2016, 1:36 AM · Restricted Project

Jul 3 2016

Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • fix comments
Jul 3 2016, 2:57 PM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • fix some comments
Jul 3 2016, 2:54 PM · Restricted Project
Alexander_Droste updated the diff for D21962: MPITypeMismatchCheck for Clang-Tidy.
  • change comment style to LLVM style
  • remove 'misc-m-p-i-type-mismatch' entry from list.rst (misc-mpi-type-mismatch is the correct one)
Jul 3 2016, 2:36 PM · Restricted Project
Alexander_Droste added a comment to D21962: MPITypeMismatchCheck for Clang-Tidy.

Hi Alexander,

Jul 3 2016, 2:07 PM · Restricted Project
Alexander_Droste retitled D21962: MPITypeMismatchCheck for Clang-Tidy from to MPITypeMismatchCheck for Clang-Tidy.
Jul 3 2016, 1:55 PM · Restricted Project

Jun 13 2016

Alexander_Droste closed D18120: Message Passing Interface mock header.

This was committed, as part of http://reviews.llvm.org/rL272529.

Jun 13 2016, 1:05 AM
Alexander_Droste accepted D18120: Message Passing Interface mock header.
Jun 13 2016, 1:05 AM
Alexander_Droste closed D18309: sourceRange function for MemRegion.

This was committed, as part of http://reviews.llvm.org/rL272529.

Jun 13 2016, 1:02 AM

Jun 12 2016

Alexander_Droste added a comment to D21081: MPI-Checker patch for Clang Static Analyzer.

Hi Devin,

Jun 12 2016, 2:31 PM
Alexander_Droste added a comment to D21081: MPI-Checker patch for Clang Static Analyzer.

I now solved this, by using a small_vector of MPIBugReporters (MPIChecker.h line: 101).
So each time a report is generated, a new MPIBugReporter is added to that vector,
in order to refer to the correct ExprEngine and keep them available for the report flush.
I attached the updated patch, as part of this comment.

Jun 12 2016, 5:15 AM

Jun 8 2016

Alexander_Droste added a comment to D21081: MPI-Checker patch for Clang Static Analyzer.

Hi Devin,
thanks for fixing the GCC build errors and setting up the commit!

Jun 8 2016, 4:38 AM

Apr 17 2016

Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • lower case letters for test filenames
Apr 17 2016, 3:13 AM

Apr 16 2016

Alexander_Droste added a comment to D12761: MPI-Checker patch for Clang Static Analyzer.
Apr 16 2016, 4:12 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.
Apr 16 2016, 4:10 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

The memory region for the va_list that was obtained from the analyzer in same case was indeed an element region in the va_list checker. I fixed this issue, and now it works properly.

Then this patch might be ready to commit. :)

Apr 16 2016, 3:51 AM
Alexander_Droste updated the diff for D18309: sourceRange function for MemRegion.
  • remove superflous '\param' from header comment
Apr 16 2016, 3:35 AM
Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • added test file to test for note diagnostics
  • changed BugReportVisitor to detect request usage purely based on state and existence of a request
  • added test that showcases a triple nonblocking usage of a request
Apr 16 2016, 3:31 AM

Apr 15 2016

Alexander_Droste added inline comments to D12761: MPI-Checker patch for Clang Static Analyzer.
Apr 15 2016, 11:13 AM
Alexander_Droste added inline comments to D12761: MPI-Checker patch for Clang Static Analyzer.
Apr 15 2016, 11:02 AM

Apr 14 2016

Alexander_Droste added a comment to D12761: MPI-Checker patch for Clang Static Analyzer.

Hi Anna,

Apr 14 2016, 8:24 AM
Alexander_Droste abandoned D18595: MPI-Checker test helper.
Apr 14 2016, 7:53 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

Might the problem be in the va_list checker?
Obviously the va_list variable is identified as an ElementRegion what seems not to be correct.
Only if the passed region is an ElementRegion indices get appended.

Apr 14 2016, 7:33 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

Looking at the code it seems that this data structure:
typedef SmallVector<const MemRegion *, 2> RegionVector;
tricks the function into rating the MemRegion as an ElementRegion.

That's not the problem. I'm using the same data structure in the MPI-Checker patch.

Apr 14 2016, 7:19 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

Looking at the code it seems that this data structure:
typedef SmallVector<const MemRegion *, 2> RegionVector;
tricks the function into rating the MemRegion as an ElementRegion.

Apr 14 2016, 6:50 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

I tested this patch using http://reviews.llvm.org/D15227
Unfortunately for non-array variables the getDescriptiveName returned var_name[0]. Note the spurious [0] part.
Could you look into that?

Could you provide a code example where this effect turns up?

Apr 14 2016, 6:45 AM

Apr 12 2016

Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

What is the status of this?
As far as I understand it is blocked on that there is no checker that we could use to test this function with unknown variables as indexes?

Apr 12 2016, 7:48 AM

Apr 2 2016

Alexander_Droste updated D18120: Message Passing Interface mock header.
Apr 2 2016, 3:27 AM

Mar 30 2016

Alexander_Droste added inline comments to D16044: getDescriptiveName() for MemRegion.
Mar 30 2016, 5:01 PM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

It's a bug in the checker. dyn_cast should not be called on a null pointer. You could either check for nun or call dyn_cast_or_null.

Thanks for pointing this out! Adding guards that check for nullptr fixed the problem.

Mar 30 2016, 4:30 PM
Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • check memory regions for nullptr in checkDoubleNonblocking and checkUnmatchedWaits before they get passed to dyn_cast<ElementRegion>
Mar 30 2016, 4:28 PM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

Here's the crash report that appears in case of the unknown function body:

Mar 30 2016, 11:57 AM
Alexander_Droste added inline comments to D16044: getDescriptiveName() for MemRegion.
Mar 30 2016, 11:36 AM
Alexander_Droste added inline comments to D16044: getDescriptiveName() for MemRegion.
Mar 30 2016, 10:54 AM
Alexander_Droste updated D18595: MPI-Checker test helper.
Mar 30 2016, 10:05 AM
Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • fix typo
Mar 30 2016, 7:46 AM
Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • added test that uses wrapper functions around MPI functions
  • added test to check behavior in case MPI functions are used in other translation units
  • added more MPI_Waitall tests -> missingNonBlockingWaitall*
Mar 30 2016, 7:40 AM
Alexander_Droste added a child revision for D18595: MPI-Checker test helper: D12761: MPI-Checker patch for Clang Static Analyzer.
Mar 30 2016, 7:01 AM
Alexander_Droste added a parent revision for D12761: MPI-Checker patch for Clang Static Analyzer: D18595: MPI-Checker test helper.
Mar 30 2016, 7:01 AM
Alexander_Droste added a child revision for D18120: Message Passing Interface mock header: D18595: MPI-Checker test helper.
Mar 30 2016, 7:00 AM
Alexander_Droste added a parent revision for D18595: MPI-Checker test helper: D18120: Message Passing Interface mock header.
Mar 30 2016, 7:00 AM
Alexander_Droste retitled D18595: MPI-Checker test helper from to MPI-Checker test helper.
Mar 30 2016, 6:59 AM
Alexander_Droste added inline comments to D12761: MPI-Checker patch for Clang Static Analyzer.
Mar 30 2016, 3:02 AM

Mar 21 2016

Alexander_Droste added inline comments to D12761: MPI-Checker patch for Clang Static Analyzer.
Mar 21 2016, 9:43 AM
Alexander_Droste updated the diff for D12761: MPI-Checker patch for Clang Static Analyzer.
  • remove checkMissingWaitsGlobals to prevent potential false positives
Mar 21 2016, 9:37 AM
Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

I submitted the sourceRange patch here: http://reviews.llvm.org/D18309
If also this patch would get committed as part of the package, there would be no need for an incremental commit procedure.

Mar 21 2016, 4:42 AM
Alexander_Droste added a parent revision for D12761: MPI-Checker patch for Clang Static Analyzer: D18309: sourceRange function for MemRegion.
Mar 21 2016, 3:18 AM
Alexander_Droste retitled D18309: sourceRange function for MemRegion from to sourceRange function for MemRegion.
Mar 21 2016, 3:15 AM

Mar 13 2016

Alexander_Droste added a comment to D16044: getDescriptiveName() for MemRegion.

I'd be fine if we test this function with the usual regression tests by observing the output of the MPI checker. We could update that test with more checks once the function is updated.
With that approach, you'd be committing both patches at the same time.

Mar 13 2016, 10:34 AM
Alexander_Droste added inline comments to D12761: MPI-Checker patch for Clang Static Analyzer.
Mar 13 2016, 10:27 AM
Alexander_Droste added inline comments to D16044: getDescriptiveName() for MemRegion.
Mar 13 2016, 7:30 AM