Yes, of course. Thanks!

Okay thanks. If the + options works let's go with
alexanderhederstaf+llvm@gmail.com

In D144709#4193603, @MyDeveloperDay wrote:

In D144709#4188921, @AlexanderHederstaf wrote:

What is the next step in the process? Anything I should do?

If you have commit access you can go ahead and commit, if not and you want one of us to do it, we need your name and email address

What is the next step in the process? Anything I should do?

In D144709#4171029, @MyDeveloperDay wrote:

I might have been tempted to handle the comments in a separate commit, I don't like to do too much in one go or the review gets hard to manage.

Handle /*c*/ comments inside types.
Add >> test to right->left.

Missed right->left in the fix. Also looking a bit at comments, e.g.

Add extra tests based on https://github.com/llvm/llvm-project/issues/56111

Thanks for the comments and help on this review. There are a lot of special cases I had not considered before, and while it works on the clang/ and llvm/ subfolders as well as tests and the other repository I tested on, I suppose there could still be some hidden issues. Allowing any identifier without the requirement that it is a pointer type adds a lot of complexity.

I used clang-format on all files in clang/ and llvm/, where I had added QualifierAlignment: Right to any .clang-format. I built with

cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang"
cmake --build build

Is that sufficient or did you imagine some other build?

Change order for typename and :: as
const typename ::Bar b; is valid code.

In D144709#4160820, @MyDeveloperDay wrote:

As tests currently fail can you set it to "planned changes" until they pass

[  FAILED  ] 5 tests, listed below:
[  FAILED  ] QualifierFixerTest.RightQualifier
[  FAILED  ] QualifierFixerTest.LeftQualifier
[  FAILED  ] QualifierFixerTest.ConstVolatileQualifiersOrder
[  FAILED  ] QualifierFixerTest.MoveConstBeyondType
[  FAILED  ] QualifierFixerTest.TemplatesRight

This code from llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp failed with Right but without a full list of specifiers. As static was not configured, the } was not discovered by IsRightQualifier. Changed some of the qualifier tests to check against the full list instead.

Distinguish configured qualifiers from other qualifiers.

Discovered incorrect code generation for llvm/include/llvm/ADT/StringMap.h.

Simplify insertQualifierAfter.
Ignore decltype, typeof, and _Atomic.
Set length of TT_TemplateCloser to 1.

Update commit message

There are a lot of complicated cases when trying to extend this functionality. I addressed a few more and thought that it might be acceptable to avoid adjusting the qualifiers for variable declared as

Update right to left analyzer
Add support for requires clauses
Ignore usages of struct/class keyword

Fix simple types not moving all the way right.

Fixed comments and rebased. Tested right to left on the output of left to right and discovered two cases where the output code would not compile. Added new tests for those cases and I am working on improvements for right to left.

Rebase after change to pointer to member was merged.
Add case for typename used for nested dependent names.
Add assertions for template closers/openers.

Thanks for the review so far!

Add comments for different cases.
Add more tests.
Fix whitespace issue.

Highlight by me. That is not acceptable, running the output of clang-format through clang-format shall not result in any change. In that case it's better to not touch it in any way.

Add test with advanced type that would not work before.
Add pointer to member.

Fixed the const/volatile placement. Added a few tests.

I will add new tests / examples as well as look into the volatile/const ordering.

I tried to refactor QualifierAlignmentFixer to handle more types, notably removing the *,&,&& requirement as e.g. const Foo did not work. To avoid moving qualifiers too far, a test for "already east const" is introduced. However, to get the correct order for the east qualifiers Clang-Format must be used twice. I assume it's related to how fixes/replacements are handled. Would you like to have a look and perhaps suggest any improvements?