Page MenuHomePhabricator

AlexVlx (Alex Voicu)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 9 2017, 10:58 AM (88 w, 1 d)

Recent Activity

Dec 2 2018

AlexVlx added inline comments to D54882: [AMDGPU] Add sdwa support for ADD|SUB U64 decomposed Pseudos.
Dec 2 2018, 5:10 PM
AlexVlx added inline comments to D54882: [AMDGPU] Add sdwa support for ADD|SUB U64 decomposed Pseudos.
Dec 2 2018, 4:19 PM

May 15 2018

AlexVlx accepted D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode.
May 15 2018, 3:10 PM · Unknown Object (Project)
AlexVlx added a comment to D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode.

LGTM - thank you!

May 15 2018, 3:03 PM · Unknown Object (Project)
AlexVlx added a comment to D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode.

I believe that we need to behave as is LegalAddressingMode is supposed to behave in general(see 469 in TargetTransformInfo.h):

/// Return true if the addressing mode represented by AM is legal for
/// this target, for a load/store of the specified type.
/// The type may be VoidTy, in which case only return true if the addressing
/// mode is legal for a load/store of any legal type.
/// If target returns true in LSRWithInstrQueries(), I may be valid.

When I looked at it, it was the case that VoidTy is essentially a tag type in this case. Other targets such as AArch64 also acknowledge that an unsized type may be passed through all the way to isLegalAddressingMode.

May 15 2018, 2:37 PM · Unknown Object (Project)

Dec 4 2017

AlexVlx added inline comments to D39739: [HCC] Add flag to Import Weak Functions in Function Importer.
Dec 4 2017, 8:16 AM

Nov 23 2017

AlexVlx created D40405: [AMDGPU] Fix handling of void types in isLegalAddressingMode.
Nov 23 2017, 3:23 PM · Unknown Object (Project)

Nov 20 2017

AlexVlx updated the diff for D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.

Apologies for the delayed update. The new version tries to deal with two issues:

  1. the non-compliant style identified by Aaron in various spots, hopefully this is correct now;
  2. there was an issue with the existing logic, which only came up with additional testing:
    • for AMDGPUFlatWorkGroupSizeAttr and AMDGPUWavesPerEU, it is valid for the user to have passed an integer literal for the minimum and a dependent expression for the maximum;
    • in this case, iff the expression for the maximum could not be evaluated in Sema, then a spurious error case would obtain in which the minimum would signalled as greater than the maximum, which would have been pegged at 0;
    • this is fixed by having the maximum be at least equal to the minimum before any attempt of evaluating it is made - iff the actual user passed arguments to the attribute violate its invariants the error is signalled.
    • the relevant changes are on lines 5495 and 5529 in SemaDeclAttr.cpp.
Nov 20 2017, 6:34 AM · Restricted Project

Nov 9 2017

AlexVlx updated the diff for D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 1:49 PM · Restricted Project
AlexVlx added a comment to D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.

Hi Alex, can you rebase on top of trunk (I think you brought in some extra changes from hcc branch) and upload a full diff?

Nov 9 2017, 1:36 PM · Restricted Project
AlexVlx added inline comments to D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 1:36 PM · Restricted Project
AlexVlx updated the diff for D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 1:28 PM · Restricted Project
AlexVlx updated the diff for D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 1:11 PM · Restricted Project
AlexVlx retitled D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes from Late parsed / dependent arguments for AMDGPU kernel attributes to [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 11:38 AM · Restricted Project
AlexVlx added a reviewer for D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes: whchung.
Nov 9 2017, 11:36 AM · Restricted Project
AlexVlx added a project to D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes: Restricted Project.
Nov 9 2017, 11:34 AM · Restricted Project
AlexVlx created D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes.
Nov 9 2017, 11:31 AM · Restricted Project