Page MenuHomePhabricator

AbbasSabra (Abbas Sabra)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2020, 11:32 AM (57 w, 1 d)

Recent Activity

Fri, Jun 18

AbbasSabra added a comment to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

ping

Fri, Jun 18, 1:44 AM · Restricted Project

Fri, Jun 4

AbbasSabra added a comment to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

ping

Fri, Jun 4, 1:21 AM · Restricted Project

Mon, May 31

AbbasSabra requested review of D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
Mon, May 31, 8:31 AM · Restricted Project
AbbasSabra added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150

Mon, May 31, 8:25 AM · Restricted Project
AbbasSabra updated the diff for D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Updating D102517: [clang]Fix use-of-uninitialized-value detected by the sanitizer

Mon, May 31, 8:18 AM · Restricted Project
AbbasSabra reopened D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
Mon, May 31, 8:17 AM · Restricted Project

Fri, May 28

AbbasSabra added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Thanks for the review! Can you take care of merging the patch? I don't have access.

Fri, May 28, 1:06 AM · Restricted Project

Wed, May 26

AbbasSabra updated the diff for D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Updating D102517: [clang] Apply code review: while loop instead of for loop

Wed, May 26, 7:13 AM · Restricted Project

May 21 2021

AbbasSabra added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Does MS use this in any library headers or such

I didn't check if they do. But if any codebase does use "abstract" and they are trying to use clang-cl they would face a parsing error.
My use case was running static analysis on code that uses this feature. Such an error had a great impact on the quality of the analysis.

May 21 2021, 7:05 AM · Restricted Project
AbbasSabra updated the diff for D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Updating D102517: [clang]Apply code review

May 21 2021, 7:01 AM · Restricted Project

May 20 2021

AbbasSabra added a comment to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

Note: I don't have the right to re-run the failed build/test. I assume that it is not related to my change since the test compile and runs omp code(Static analyzer doesn't run on that test)

May 20 2021, 4:35 AM · Restricted Project
AbbasSabra added a comment to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

I've just been patching up clang-tidy's infinite loop checker and the problem sounds soooo similar. Maybe we should move clang-tidy's alias analysis into libAnalysis and re-use it?

May 20 2021, 3:11 AM · Restricted Project
AbbasSabra added reviewers for D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr: NoQ, steakhal, vsavchenko.
May 20 2021, 3:03 AM · Restricted Project

May 17 2021

AbbasSabra added a comment to D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

I think it's good to go. Thank you!

May 17 2021, 3:12 AM · Restricted Project
AbbasSabra updated the summary of D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
May 17 2021, 1:00 AM · Restricted Project

May 14 2021

AbbasSabra added a comment to D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

Well, and how can I build them on Linux xD

Ah, I don't think they are meant to be built on Linux :D Especially if they rely on Window specific features like SEH. If they do they will disable these features on Linux build.

How do you use clang exactly?

May 14 2021, 11:49 AM · Restricted Project
AbbasSabra requested review of D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
May 14 2021, 10:58 AM · Restricted Project
AbbasSabra updated the diff for D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

Updating D102273: [analyzer] Update comments + fix typos

May 14 2021, 10:11 AM · Restricted Project
AbbasSabra added inline comments to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.
May 14 2021, 10:07 AM · Restricted Project
AbbasSabra updated the diff for D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

Updating D102273: [analyzer] Apply code review part 2

May 14 2021, 9:47 AM · Restricted Project
AbbasSabra added inline comments to D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.
May 14 2021, 7:31 AM · Restricted Project
AbbasSabra updated the diff for D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.

Updating D102273: [analyzer] Apply code review

May 14 2021, 7:30 AM · Restricted Project
AbbasSabra added a comment to D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

Do you have any good (mature, big enough) open-source projects for these msvc constructs?

May 14 2021, 6:05 AM · Restricted Project
AbbasSabra updated the diff for D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

Updating D102280: [analyzer] rename test file + make sure that statements after "__leave" are not reached

May 14 2021, 6:02 AM · Restricted Project
AbbasSabra added a comment to D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

Please, add these reviewers for your upcoming [analyzer] patches.

Thanks, I was planning to add reviewers after making sure that the pre-checks are green.

May 14 2021, 2:54 AM · Restricted Project
AbbasSabra updated the diff for D102280: [analyzer] Engine: fix crash with SEH __leave keyword.

Updating D102280: [analyzer] Apply code review

May 14 2021, 2:50 AM · Restricted Project

May 11 2021

AbbasSabra updated the summary of D102280: [analyzer] Engine: fix crash with SEH __leave keyword.
May 11 2021, 2:49 PM · Restricted Project
AbbasSabra requested review of D102280: [analyzer] Engine: fix crash with SEH __leave keyword.
May 11 2021, 2:48 PM · Restricted Project
AbbasSabra requested review of D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference.
May 11 2021, 12:46 PM · Restricted Project

Jun 9 2020

AbbasSabra added a comment to D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.

Gentle reminder

Jun 9 2020, 1:03 AM · Restricted Project

May 28 2020

AbbasSabra added a comment to D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
In D80669#2058824, @NoQ wrote:

Fair!

May 28 2020, 7:02 AM · Restricted Project

May 27 2020

AbbasSabra updated the diff for D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.

clang-format

May 27 2020, 4:23 PM · Restricted Project
AbbasSabra abandoned D80671: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
May 27 2020, 4:23 PM · Restricted Project
AbbasSabra created D80671: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
May 27 2020, 4:23 PM · Restricted Project
AbbasSabra retitled D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation from [analyzer] LoopWidening: fix crash by avoiding aliased references invalidationSummary: LoopWidening is invalidating references comming from type aliases which lead to a crashReviewers: xazax.hun vsavchenko NoQSubscribers: to [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
May 27 2020, 3:49 PM · Restricted Project
AbbasSabra updated the summary of D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
May 27 2020, 3:49 PM · Restricted Project
AbbasSabra created D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation.
May 27 2020, 3:49 PM · Restricted Project

May 21 2020

AbbasSabra added a comment to D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

Great! Can someone take care of merging it? I believe I don't have access.

May 21 2020, 9:08 AM · Restricted Project

May 20 2020

AbbasSabra added inline comments to D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.
May 20 2020, 8:10 AM · Restricted Project
AbbasSabra updated the diff for D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

Fix code review 2

May 20 2020, 8:10 AM · Restricted Project

May 19 2020

AbbasSabra removed a reviewer for D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter: AbbasSabra.
May 19 2020, 5:39 PM · Restricted Project
AbbasSabra requested review of D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

What you both said makes sense. Now, reference parameters are escaped and value parameters are treated as the local variables.
Thanks!

May 19 2020, 5:39 PM · Restricted Project
AbbasSabra accepted D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.
May 19 2020, 5:39 PM · Restricted Project
AbbasSabra updated the diff for D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

update

May 19 2020, 5:39 PM · Restricted Project
AbbasSabra updated the diff for D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

Fix code review

May 19 2020, 5:06 PM · Restricted Project

May 18 2020

AbbasSabra created D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.
May 18 2020, 4:50 PM · Restricted Project