Page MenuHomePhabricator

Aaron1011 (Aaron Hill)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 29 2018, 11:46 PM (155 w, 6 d)

Recent Activity

Oct 1 2020

Aaron1011 added a comment to D88529: [DAE] MarkLive in MarkValue(MaybeLive) if any use is live.

This looks good to me, but someone who's more familiar with this code should also take a look.

Oct 1 2020, 3:51 PM · Restricted Project

Sep 22 2020

Aaron1011 added a reviewer for D87474: Ensure that we don't update Uses after MarkLive: rnk.
Sep 22 2020, 2:36 PM · Restricted Project

Sep 10 2020

Aaron1011 added a comment to D87474: Ensure that we don't update Uses after MarkLive.

The pre-merge check seems to want markValues instead of MarkValues, even though the method is curretly 'MarkValue'. Should I change this?

Sep 10 2020, 12:55 PM · Restricted Project
Aaron1011 requested review of D87474: Ensure that we don't update Uses after MarkLive.
Sep 10 2020, 11:36 AM · Restricted Project

Dec 13 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

We need to resolve this point of disagreement. IMO that optimization is only invalid in regular compilation. I think that for LTO this is a valid optimization. LTO has optimizations that would normally be invalid - for example the Internalize pass.

Dec 13 2018, 5:24 PM

Nov 27 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

The point of comdat groups is that only one of the groups of sections from each duplicate comdat set is in linked in from the input files. There are no comdat groups in the output of a normal link (excluding -r links).

Nov 27 2018, 11:58 AM

Nov 16 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

so yes the system linker is perfectly legal to remove some parts of a COMDAT group from the final output.

Nov 16 2018, 3:07 PM

Nov 14 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

Intuitively, we would not expect comdats in LTO object files as they are not required.

Nov 14 2018, 5:39 PM

Oct 20 2018

Aaron1011 added a comment to D53241: [GlobalOpt] Never remove global values from non-discardable COMDATs.

Ping

Oct 20 2018, 1:36 PM
Aaron1011 added a comment to D53242: [Inliner] Only remove functions with a COMDAT when it's safe to do so.

Ping

Oct 20 2018, 1:35 PM
Aaron1011 added a comment to D53243: [DeadArgElim][ArgumentPromotion] Preserve MD_Associated metadata when re-creating function.

Ping

Oct 20 2018, 1:34 PM

Oct 16 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

So perhaps this code needs to handle comdat containing an object with associated metadata specially (e.g. could just include in the ExternalComdats set)?

Oct 16 2018, 7:15 AM

Oct 15 2018

Aaron1011 added a comment to D53234: Don't remove COMDATs when internalizing global objects.

Normally once they are both internalized and removed from the comdat, it shouldn't matter if only one is kept by GlobalDCE. The other is simply an internal function and no longer part of a comdat (so it's not like the comdat is incomplete).

Oct 15 2018, 2:23 PM
Aaron1011 updated the diff for D53234: Don't remove COMDATs when internalizing global objects.

My reading of that commit (D10679), and looking at the code, is that GlobalDCE would be able to remove these members because they should *all* be removed from the comdat by internalization. The change appears to make it such that internalization cannot proceed if any member of the comdat is externally visible and therefore cannot be internalized. If all members of the comdat can be internalized (i.e. not in the ExternalComdats set), then they can all be internalized and the comdat removed from all members.

Oct 15 2018, 12:07 PM

Oct 13 2018

Aaron1011 updated the diff for D53243: [DeadArgElim][ArgumentPromotion] Preserve MD_Associated metadata when re-creating function.

I accidentally excluded my test cases from the first patch

Oct 13 2018, 12:49 AM
Aaron1011 created D53243: [DeadArgElim][ArgumentPromotion] Preserve MD_Associated metadata when re-creating function.
Oct 13 2018, 12:43 AM

Oct 12 2018

Aaron1011 created D53242: [Inliner] Only remove functions with a COMDAT when it's safe to do so.
Oct 12 2018, 10:10 PM
Aaron1011 created D53241: [GlobalOpt] Never remove global values from non-discardable COMDATs.
Oct 12 2018, 8:33 PM
Aaron1011 created D53234: Don't remove COMDATs when internalizing global objects.
Oct 12 2018, 6:19 PM