Page MenuHomePhabricator
People 1lyasm

1lyasm (Ilyas Mustafazade)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2023, 1:42 PM (16 w, 2 d)

Recent Activity
View All

Mar 21 2023

1lyasm added a comment to D146422: [NFC] Fix typo in comment.
In D146422#4209249, @zero9178 wrote:

LGTM. The Windows CI failure you can probably ignore, seems to be just a flaky test or maybe some other recent change that caused it. Do you need me to commit this for you?

Mar 21 2023, 5:18 AM · Restricted Project, Restricted Project

Mar 20 2023

1lyasm retitled D146422: [NFC] Fix typo in comment from Fix typo to [NFC] Fix typo in comment.
Mar 20 2023, 2:35 PM · Restricted Project, Restricted Project
1lyasm retitled D146382: [NFC] Change strcpy to std::copy from Change strcpy to std::copy to [NFC] Change strcpy to std::copy.
Mar 20 2023, 2:35 PM · Restricted Project, Restricted Project
1lyasm added a comment to D146394: [NFC] Replace strlen with StringRef::size.

Thank you.

Mar 20 2023, 2:26 PM · Restricted Project, Restricted Project
1lyasm added a comment to D146394: [NFC] Replace strlen with StringRef::size.

I do not have commit access, can you commit this for me?
(Ilyas Mustafazade <il.mystafa@gmail.com>)

Mar 20 2023, 2:13 PM · Restricted Project, Restricted Project
1lyasm added a comment to D146422: [NFC] Fix typo in comment.

I do not know why builds fail, only comment is changed.

Mar 20 2023, 1:40 PM · Restricted Project, Restricted Project
1lyasm added a comment to D146382: [NFC] Change strcpy to std::copy.

Ilyas Mustafazade <il.mystafa@gmail.com>
Thank you.

Mar 20 2023, 11:05 AM · Restricted Project, Restricted Project
1lyasm requested review of D146422: [NFC] Fix typo in comment.
Mar 20 2023, 7:29 AM · Restricted Project, Restricted Project

Mar 19 2023

1lyasm added a comment to D146394: [NFC] Replace strlen with StringRef::size.

Renamed ArgSize to SpellingSize, because both ArgSize and ArgStringSize would be confusing

Mar 19 2023, 2:09 PM · Restricted Project, Restricted Project
1lyasm requested review of D146394: [NFC] Replace strlen with StringRef::size.
Mar 19 2023, 2:07 PM · Restricted Project, Restricted Project
1lyasm added a comment to D146382: [NFC] Change strcpy to std::copy.

Generated assembly for strcpy is smaller than that for std::copy, but there is 2 calls in std::copy and 3 calls in strcpy. Could not evaluate performance by just looking at assemblies.

Mar 19 2023, 11:21 AM · Restricted Project, Restricted Project
1lyasm updated the diff for D146382: [NFC] Change strcpy to std::copy.

Remove strncpy and add std::copy

Mar 19 2023, 11:19 AM · Restricted Project, Restricted Project
1lyasm requested review of D146382: [NFC] Change strcpy to std::copy.
Mar 19 2023, 7:52 AM · Restricted Project, Restricted Project