Page MenuHomePhabricator

10ne1 (Adrian Ratiu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2022, 9:50 AM (10 w, 4 d)

Recent Activity

Oct 6 2022

10ne1 abandoned D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Oct 6 2022, 1:24 AM · Restricted Project, Restricted Project

Oct 3 2022

10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

@MaskRay and @nickdesaulniers Can you please work together to reach a consensus on what is the best path forward? I am ok either way, just need to know what the next steps are. :) Thank you.

Oct 3 2022, 2:20 AM · Restricted Project, Restricted Project

Sep 30 2022

10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in linux-cross.cpp).
I'll add the test, though, and submit this for you.

Request changes for now.

Ok. Thanks, please ping if you need any action on my side.

My latest thought is that this patch is going toward a wrong direction: https://reviews.llvm.org/D134454#3824630

Sep 30 2022, 6:03 AM · Restricted Project, Restricted Project

Sep 29 2022

10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting.
This adds new functionality for non-MIPS and we need some fake file hierarchies (like those used in linux-cross.cpp).
I'll add the test, though, and submit this for you.

Request changes for now.

Sep 29 2022, 11:37 PM · Restricted Project, Restricted Project
10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Looks great! Nice job @10ne1 . Need me to commit this for you?

Sep 29 2022, 10:19 AM · Restricted Project, Restricted Project
10ne1 updated the diff for D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Updated based on feedback from Nick.

Sep 29 2022, 6:17 AM · Restricted Project, Restricted Project
10ne1 added inline comments to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 29 2022, 6:16 AM · Restricted Project, Restricted Project

Sep 28 2022

10ne1 updated the diff for D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 28 2022, 2:17 AM · Restricted Project, Restricted Project
10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

FYI: @MaskRay I think you will be very happy that after the simplifications Nick suggested the Distro::* additions are not necessary anymore.

Sep 28 2022, 2:15 AM · Restricted Project, Restricted Project

Sep 27 2022

10ne1 updated the diff for D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Fixed some clang-format problems.

Sep 27 2022, 5:00 AM · Restricted Project, Restricted Project
10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

@nickdesaulniers @MaskRay I've updated the diff & summary based on the review comments which I've marked as done. Please tell me what you think. Thank you!

Sep 27 2022, 3:42 AM · Restricted Project, Restricted Project
10ne1 updated the diff for D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 27 2022, 3:38 AM · Restricted Project, Restricted Project
10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

I am nervous as well as Arch Linux has many derivatives. They likely don't use ID=arch in /etc/os-release. The patch won't work for them.
In general, I don't think our current approach adding new Distro::* flavors scale or really meet the needs of numerous less-popular distributions.

The last few comments of https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 discuss a generic mechanism solving the distribution difference problem with configuration files.
Also, the new driver option --gcc-install-dir (https://discourse.llvm.org/t/add-gcc-install-dir-deprecate-gcc-toolchain-and-remove-gcc-install-prefix/65091 ; milestone: 16.0.0) can be useful for some tasks.

Sep 27 2022, 2:12 AM · Restricted Project, Restricted Project
10ne1 added inline comments to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 27 2022, 2:00 AM · Restricted Project, Restricted Project

Sep 26 2022

10ne1 added inline comments to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 26 2022, 2:57 AM · Restricted Project, Restricted Project
10ne1 added inline comments to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 26 2022, 2:46 AM · Restricted Project, Restricted Project
10ne1 added a comment to D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Is it worth contacting the package maintainer for LLVM+clang for Arch-Linux in regards to this patch?

Sep 26 2022, 1:44 AM · Restricted Project, Restricted Project

Sep 23 2022

10ne1 updated the diff for D134454: [Driver][Distro] Fix ArchLinux sysroot detection.

Regenerated diff with git diff HEAD~1 -U999999

Sep 23 2022, 2:06 AM · Restricted Project, Restricted Project

Sep 22 2022

10ne1 requested review of D134454: [Driver][Distro] Fix ArchLinux sysroot detection.
Sep 22 2022, 10:05 AM · Restricted Project, Restricted Project