Home

With the above changes to the test case (and the corresponding changes to the reference output), the problem would have been blatantly obvious from the start and we wouldn't have to jump through hoops to ensure opt isn't just giving us the right answer.

Will land it in a 24-hours if there is no objections from others.

Handle shared symbols in the gnu hash construction.

I have no idea how to CC those mailing lists (Change Subscribers doesn't seem to allow those) in this tool (or shall I just mail them normally)?
As for tests, the ones I have for GCC are:

Fixed most of notes spotted by @kcc.

In D38971#900315, @kcc wrote:

Please use the arc tool to submit the patch or otherwise paste the patch with full context.
Please always CC llvm-commits for changes in compiler-rt (phabricator doesn't do it automatically)

In D38971#900253, @kcc wrote:
In D38971#899407, @marxin wrote:

Thanks, I'll add some tests. May I please ask you how to run a single test-case (I guess using llvm-lit) ?

Frankly, dunno. The entire ninja check-llvm takes 40 seconds for me
Doesn't this work?
llvm-lit <test path>

In D38030#892957, @skatkov wrote:

LGTM.

Could you please land this patch?

How is this even reviewed?

Fix the incorrect detection of ICONV_LIBRARY_PATH

There are some test crashes with this and I think I made the wrong guess for dmask behavior

In D38988#899532, @nemanjai wrote:

And FWIW, I still don't like the names of these helper functions. There isn't really much indication in the name what it is sign/zero extending from/to. Presume I want to do add/remove an instruction depending on whether the input is known to be sign-extended from a halfword to a doubleword, but not if it is only known to be sign-extended from a word to a doubleword, it isn't clear how I would use these functions to determine that.

update_mir_test_checks: Support '-' in function names

update_mir_test_checks: Fix a typo I made while preparing for commit

@davide, This is why I didn't silently commit such a trivial change. I am happy if it could be reproduced easily.

I really don't like this solution, in particular as a global one. Can we try to reproduce the tests that are failing?

[CMake] Use #cmakedefine01 for CLANG_ENABLE_…

Trying to fix issue with coverage stats being duplicated if fork() is used

Prune trailing linefeed.

Statically link llvm-cfi-verify's libraries.

@frutiger you have commit rights now right?

Please land it asap.

Confirm, the patch fixes my issue.

Active Repositories

Recent Activity

Today

Yesterday