Today

danalbert created D53344: [Driver] Use --warn-shared-textrel for Android..
Tue, Oct 16, 3:32 PM
ctopper committed rL344649: [X86] Match (cmp (and (shr X, C), mask), 0) to BEXTR+TEST..
[X86] Match (cmp (and (shr X, C), mask), 0) to BEXTR+TEST.
Tue, Oct 16, 3:31 PM
Diffusion closed D53310: [X86] Match (cmp (and (shr X, C), mask), 0) to BEXTR+TEST..
Tue, Oct 16, 3:31 PM
NoQ added inline comments to D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag.
Tue, Oct 16, 3:28 PM
xbolva00 added a comment to D52750: [Diagnostics] Check for integer overflow in array size expressions .

Reping :)

Tue, Oct 16, 3:23 PM
efriedma updated the diff for D53184: [LangRef] Clarify semantics of volatile operations..

Took another shot at the wording. This should be a bit more explicit about what we're assuming, and what transforms are allowed.

Tue, Oct 16, 3:20 PM
danalbert created D53343: [Driver] Default Android toolchains to noexecstack..
Tue, Oct 16, 3:19 PM
arsenm accepted D53318: AMDGPU: Remove dead TableGen code.

LGTM

Tue, Oct 16, 3:11 PM
adrian committed rL344648: Delete commented-out code..
Delete commented-out code.
Tue, Oct 16, 3:04 PM
adrian committed rLLDB344648: Delete commented-out code..
Delete commented-out code.
Tue, Oct 16, 3:04 PM
xbolva00 added a comment to D50039: [FunctionAttrs] Added nonnull atribute to libc function args.

What I would like to do as follow up is to turn FunctionAttrs to use dominators info.

Tue, Oct 16, 3:04 PM
vlad.tsyrklevich accepted D53336: Stack Safety Analysis documentation.
Tue, Oct 16, 3:03 PM
jingham committed rL344647: Return a named error in the result object of an expression with no result.
Return a named error in the result object of an expression with no result
Tue, Oct 16, 3:01 PM
jingham committed rLLDB344647: Return a named error in the result object of an expression with no result.
Return a named error in the result object of an expression with no result
Tue, Oct 16, 3:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Tue, Oct 16, 3:00 PM
fhahn added a comment to D51629: [Local] Keep K's range if K does not move when combining metadata..

ping

Tue, Oct 16, 3:00 PM
fhahn added a comment to D51431: [WIP][IPSCCP] Add lattice value for != constant and propagate nonnull..

You're making the lattice really confusing. Essentially, there are now two different merging rules: one is used if the caller calls mergeInValue, and a different one is used if the caller calls markNotConstant etc. So it's not obvious what the lattice actually represents.


And actually, thinking about it a bit more, there's a more fundamental problem with proving a value is non-null. Given that a value is possibly-undef, it could be null even for code dominated by a null-check. So the entire proposed transform is unsound unless you freeze the pointer.

Tue, Oct 16, 2:59 PM
yonghong-song added inline comments to D53261: [BPF] Add BTF generation for BPF target.
Tue, Oct 16, 2:58 PM · debug-info
JDevlieghere added a comment to D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls.

The patch looks fine but since I don't know much about opencl I'll leave the LGTM to someone that actually knows this code.

Tue, Oct 16, 2:55 PM
vitalybuka updated the diff for D53336: Stack Safety Analysis documentation.

apply edits of @vlad.tsyrklevich

Tue, Oct 16, 2:54 PM
vitalybuka added a comment to D53336: Stack Safety Analysis documentation.

I sent you my StackSafetyAnalysis.rst edits over e-mail because the s/// format got tricky.

Tue, Oct 16, 2:54 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls][WIP] Mark known arguments with nonnull.
Tue, Oct 16, 2:52 PM
jmolenda committed rL344646: Fixed an issue that a bot found with my changes.
Fixed an issue that a bot found with my changes
Tue, Oct 16, 2:51 PM
jmolenda committed rLLDB344646: Fixed an issue that a bot found with my changes.
Fixed an issue that a bot found with my changes
Tue, Oct 16, 2:51 PM
morehouse accepted D53211: [SanitizerCoverage] Don't duplicate code to get section pointers.

LGTM

Tue, Oct 16, 2:44 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls][WIP] Mark known arguments with nonnull.

And I expect this will be noisy in tests

Tue, Oct 16, 2:43 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls][WIP] Mark known arguments with nonnull.

The patch shows the current idea so we can consult the design first, and then do boring marking work.

Tue, Oct 16, 2:41 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls][WIP] Mark known arguments with nonnull.
Tue, Oct 16, 2:40 PM
efriedma added inline comments to D53184: [LangRef] Clarify semantics of volatile operations..
Tue, Oct 16, 2:39 PM
xbolva00 created D53342: [SimplifyLibCalls][WIP] Mark known arguments with nonnull.
Tue, Oct 16, 2:39 PM
arsenm accepted D53316: StructurizeCFG: Simplify inserted PHI nodes.

LGTM

Tue, Oct 16, 2:34 PM
yaxunl added a comment to D52320: AMDGPU: add __builtin_amdgcn_update_dpp.

Brian checked the extra argument for dpp mov should be the first one. so mov_dpp(x,...) --> update_dpp(undef, x, ...). I will fix that when committing.

Tue, Oct 16, 2:32 PM
efriedma added a comment to D50039: [FunctionAttrs] Added nonnull atribute to libc function args.

I think we still need the clang patch to preemptively strip nonnull annotations from C library functions before we turn on EnableNonnullArgPropagation by default, to be safe. But yes, the right approach is to add the correct nonnull attributes, then enable nonnull propagation.

Tue, Oct 16, 2:28 PM
arsenm accepted D53160: AMDGPU: Avoid selecting ds_{read,write}2_b32 on SI.

LGTM. Is this only actually a problem with the UB because we don't bother trying to set m0 to the allocated size?

Tue, Oct 16, 2:24 PM
leonardchan added a dependency for D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Tue, Oct 16, 2:21 PM · Restricted Project
leonardchan added a dependent revision for D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types: D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast.
Tue, Oct 16, 2:21 PM · Restricted Project
xbolva00 committed rL344645: [InstCombine] Cleanup libfunc attribute inferring.
[InstCombine] Cleanup libfunc attribute inferring
Tue, Oct 16, 2:20 PM
xbolva00 closed D53338: [InstCombine] Cleanup libfunc attribute inferring.
Tue, Oct 16, 2:20 PM
arsenm accepted D52320: AMDGPU: add __builtin_amdgcn_update_dpp.

LGTM

Tue, Oct 16, 2:18 PM
erichkeane abandoned D52000: Feedback/direction Review for cpu-dispatch emit stage into GlobalDecl.

Superseding with a version that seems to work

Tue, Oct 16, 2:15 PM