Today

JonasToth added inline comments to D38396: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'.
Wed, Oct 18, 12:34 AM
nemanjai requested changes to D38962: [test-suite] Update bitreverse benchmark..

With the above changes to the test case (and the corresponding changes to the reference output), the problem would have been blatantly obvious from the start and we wouldn't have to jump through hoops to ensure opt isn't just giving us the right answer.

Wed, Oct 18, 12:13 AM

Yesterday

yrouban updated subscribers of D38030: Fix APFloat from string conversion for Inf.
Tue, Oct 17, 11:52 PM
skatkov added a comment to D38030: Fix APFloat from string conversion for Inf.

Will land it in a 24-hours if there is no objections from others.

Tue, Oct 17, 11:52 PM
rafael committed rL316065: Handle shared symbols in the gnu hash construction..
Handle shared symbols in the gnu hash construction.
Tue, Oct 17, 11:50 PM
jakubjelinek added a comment to D39018: -fsanitize=noreturn sanitization.

I have no idea how to CC those mailing lists (Change Subscribers doesn't seem to allow those) in this tool (or shall I just mail them normally)?
As for tests, the ones I have for GCC are:

Tue, Oct 17, 11:47 PM
marxin updated the diff for D38971: Enhance libsanitizer support for invalid-pointer-pair..

Fixed most of notes spotted by @kcc.

Tue, Oct 17, 11:44 PM
marxin added a comment to D38971: Enhance libsanitizer support for invalid-pointer-pair..
In D38971#900315, @kcc wrote:

Please use the arc tool to submit the patch or otherwise paste the patch with full context.
Please always CC llvm-commits for changes in compiler-rt (phabricator doesn't do it automatically)

Tue, Oct 17, 11:42 PM
marxin added a comment to D38971: Enhance libsanitizer support for invalid-pointer-pair..
In D38971#900253, @kcc wrote:

Thanks, I'll add some tests. May I please ask you how to run a single test-case (I guess using llvm-lit) ?

Frankly, dunno. The entire ninja check-llvm takes 40 seconds for me
Doesn't this work?

llvm-lit <test path>
Tue, Oct 17, 11:41 PM
yrouban added a comment to D38030: Fix APFloat from string conversion for Inf.

LGTM.

Could you please land this patch?

Tue, Oct 17, 11:40 PM
junryoungju added a comment to D37660: [ScalarEvolution] Handling Conditional Instruction in SCEV chain..
Tue, Oct 17, 11:37 PM
krasimir added a comment to D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER).

How is this even reviewed?

Tue, Oct 17, 11:36 PM
skatkov committed rL316064: Fix the incorrect detection of ICONV_LIBRARY_PATH.
Fix the incorrect detection of ICONV_LIBRARY_PATH
Tue, Oct 17, 11:26 PM
skatkov closed D38875: Fix the incorrect detection of ICONV_LIBRARY_PATH by committing rL316064: Fix the incorrect detection of ICONV_LIBRARY_PATH.
Tue, Oct 17, 11:26 PM
arsenm added a comment to D39040: AMDGPU: Fix creating invalid copy when adjusting dmask.

There are some test crashes with this and I think I made the wrong guess for dmask behavior

Tue, Oct 17, 11:14 PM
inouehrs added a comment to D38988: [PowerPC] Use helper functions to check sign-/zero-extended value.

And FWIW, I still don't like the names of these helper functions. There isn't really much indication in the name what it is sign/zero extending from/to. Presume I want to do add/remove an instruction depending on whether the input is known to be sign-extended from a halfword to a doubleword, but not if it is only known to be sign-extended from a word to a doubleword, it isn't clear how I would use these functions to determine that.

Tue, Oct 17, 10:53 PM
bogner committed rL316063: update_mir_test_checks: Support '-' in function names.
update_mir_test_checks: Support '-' in function names
Tue, Oct 17, 10:53 PM
inouehrs updated the diff for D38988: [PowerPC] Use helper functions to check sign-/zero-extended value.
  • a test case added
Tue, Oct 17, 10:50 PM
arsenm created D39040: AMDGPU: Fix creating invalid copy when adjusting dmask.
Tue, Oct 17, 10:44 PM
bogner committed rL316062: update_mir_test_checks: Fix a typo I made while preparing for commit.
update_mir_test_checks: Fix a typo I made while preparing for commit
Tue, Oct 17, 10:39 PM
chapuni added a comment to D39038: Mark lld/test/ELF as flaky..

@davide, This is why I didn't silently commit such a trivial change. I am happy if it could be reproduced easily.

Tue, Oct 17, 10:39 PM
davide requested changes to D39038: Mark lld/test/ELF as flaky..

I really don't like this solution, in particular as a global one. Can we try to reproduce the tests that are failing?

Tue, Oct 17, 10:35 PM
chapuni committed rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
[CMake] Use #cmakedefine01 for CLANG_ENABLE_…
Tue, Oct 17, 10:21 PM
chapuni closed D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) by committing rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_….
Tue, Oct 17, 10:21 PM
jlebar added inline comments to D39026: [NVPTX] allow address space inference for volatile loads/stores..
Tue, Oct 17, 10:18 PM
jlebar updated subscribers of D39026: [NVPTX] allow address space inference for volatile loads/stores..
Tue, Oct 17, 10:18 PM
chapuni created D39039: Lit: Implement RWLock to serialize retrying flaky test..
Tue, Oct 17, 10:15 PM
Dor1s updated the diff for D38905: WIP: [profile] Playing with multi-process profiling and coverage generation..

Trying to fix issue with coverage stats being duplicated if fork() is used

Tue, Oct 17, 10:10 PM
chapuni created D39038: Mark lld/test/ELF as flaky..
Tue, Oct 17, 10:07 PM
chapuni committed rL316060: Prune trailing linefeed..
Prune trailing linefeed.
Tue, Oct 17, 9:45 PM
t-tye added inline comments to D39036: AMDGPU: Fix default range in non-kernel functions.
Tue, Oct 17, 9:29 PM
vlad.tsyrklevich committed rL316059: Statically link llvm-cfi-verify's libraries..
Statically link llvm-cfi-verify's libraries.
Tue, Oct 17, 9:28 PM
vlad.tsyrklevich closed D39020: Statically link llvm-cfi-verify's libraries. by committing rL316059: Statically link llvm-cfi-verify's libraries..
Tue, Oct 17, 9:28 PM
chapuni created D39037: check-libcxx: Introduce config.test_retry_attempts for std/thread..
Tue, Oct 17, 9:25 PM
compnerd accepted D37905: [libclang, bindings]: add spelling location.

@frutiger you have commit rights now right?

Tue, Oct 17, 9:25 PM
arsenm created D39036: AMDGPU: Fix default range in non-kernel functions.
Tue, Oct 17, 9:23 PM
eugene accepted D38938: Logging: provide a way to safely disable logging in a forked process.
Tue, Oct 17, 9:21 PM
eugene accepted D39010: lldb-server tests: Propagate environment variables (pr34192).
Tue, Oct 17, 9:20 PM
skatkov added a comment to D39020: Statically link llvm-cfi-verify's libraries..

Please land it asap.

Tue, Oct 17, 9:18 PM
skatkov accepted D39020: Statically link llvm-cfi-verify's libraries..

Confirm, the patch fixes my issue.

Tue, Oct 17, 9:17 PM