Page MenuHomePhabricator

Today

compnerd accepted D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them..

Actually, I'm not sure if that is a bug in libstackunwind, but rather in LLVM. I think that this is the behaviour that GCC has specifically for the eh_frame section. This constraint is not part of the DWARF spec, but eh_frame even though it is similar to debug_frame, is not part of the DWARF spec, it just uses a similar encoding. The change itself looks good, but, please wait for the discussion to complete before committing this.

Tue, Feb 19, 8:47 AM · Restricted Project
aprantl added inline comments to D56587: Introduce DW_OP_LLVM_convert.
Tue, Feb 19, 8:45 AM · debug-info
aprantl added a reviewer for D56587: Introduce DW_OP_LLVM_convert: dblaikie.
Tue, Feb 19, 8:45 AM · debug-info
BrandonTJones added a comment to D57375: X86AsmParser AVX-512: Return error instead of hitting assert.

I will need someone to commit this change for me. I do not have permission to commit to the svn repo.

Tue, Feb 19, 8:44 AM · Restricted Project
arsenm committed rG4d88427a58dd: GlobalISel: Implement moreElementsVector for G_EXTRACT source (authored by arsenm).
GlobalISel: Implement moreElementsVector for G_EXTRACT source
Tue, Feb 19, 8:44 AM
craig.topper added a comment to D58343: Enablement for AMD znver2 architecture - skeleton patch.

I think you uploaded the clang patch into the llvm review?

Tue, Feb 19, 8:44 AM · Restricted Project, Restricted Project
arsenm closed D58124: GlobalISel: Implement moreElementsVector for G_EXTRACT source.

r354348

Tue, Feb 19, 8:44 AM
arsenm committed rL354348: GlobalISel: Implement moreElementsVector for G_EXTRACT source.
GlobalISel: Implement moreElementsVector for G_EXTRACT source
Tue, Feb 19, 8:43 AM
compnerd accepted D58298: [libObject][NFC] Use sys::path::convert_to_slash..

Thanks!

Tue, Feb 19, 8:43 AM · Restricted Project
craig.topper accepted D57375: X86AsmParser AVX-512: Return error instead of hitting assert.

LGTM

Tue, Feb 19, 8:43 AM · Restricted Project
Meinersbur committed rG4304e9d14399: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier. (authored by Meinersbur).
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 19, 8:40 AM
Meinersbur committed rC354347: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 19, 8:40 AM
aprantl added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

Looking good, thanks!

Tue, Feb 19, 8:39 AM · debug-info
Meinersbur committed rL354347: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 19, 8:39 AM
samparker created D58389: [NFC][LSR] Cleanup Cost API.
Tue, Feb 19, 8:39 AM
Meinersbur closed D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Tue, Feb 19, 8:39 AM · Restricted Project, Restricted Project, Restricted Project
AlexeySotkin created D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks.
Tue, Feb 19, 8:35 AM · Restricted Project
RKSimon committed rG9d575db85ed5: [X86][AVX] Update VBROADCAST folds to always use v2i64 X86vzload (authored by RKSimon).
[X86][AVX] Update VBROADCAST folds to always use v2i64 X86vzload
Tue, Feb 19, 8:33 AM
evgeny777 added a comment to D58384: [ThinLTO] Fix test with reverse-iteration.

Summary clusters, nodes and edges are retrieved from DenseMap with arbitrary order, which doesn't make result DOT file invalid.
Reverse iteration just exposes test issues.

Tue, Feb 19, 8:33 AM · Restricted Project
RKSimon committed rL354346: [X86][AVX] Update VBROADCAST folds to always use v2i64 X86vzload.
[X86][AVX] Update VBROADCAST folds to always use v2i64 X86vzload
Tue, Feb 19, 8:32 AM
qcolombet accepted D58376: [RegAllocGreedy] Take last chance recoloring into account in split and assign.
Tue, Feb 19, 8:32 AM · Restricted Project
arsenm committed rG26b7e859efb0: GlobalISel: Implement moreElementsVector for bit ops (authored by arsenm).
GlobalISel: Implement moreElementsVector for bit ops
Tue, Feb 19, 8:30 AM
arsenm committed rL354345: GlobalISel: Implement moreElementsVector for bit ops.
GlobalISel: Implement moreElementsVector for bit ops
Tue, Feb 19, 8:30 AM
arsenm closed D58123: GlobalISel: Implement moreElementsVector for bit ops.

r354345

Tue, Feb 19, 8:29 AM
riccibruno planned changes to D57660: [Sema] SequenceChecker: Handle references and members.

This needs more work.

Tue, Feb 19, 8:28 AM · Restricted Project
lebedev.ri updated the diff for D58355: [llvm-exegesis] Opcode stabilization / reclusterization (PR40715).

Address @courbet's review notes.

Tue, Feb 19, 8:23 AM · Restricted Project
lebedev.ri added inline comments to D58355: [llvm-exegesis] Opcode stabilization / reclusterization (PR40715).
Tue, Feb 19, 8:23 AM · Restricted Project
mehdi_amini added a comment to D58384: [ThinLTO] Fix test with reverse-iteration.

Is it expected that the test output is sensitive to reverse iteration?
It sounds to me more like an issue with the code than with how the test is expressed.

Tue, Feb 19, 8:23 AM · Restricted Project
jhenderson committed rGd82914c8d271: [yaml2obj][obj2yaml] Remove section type range markers from allowed mappings… (authored by jhenderson).
[yaml2obj][obj2yaml] Remove section type range markers from allowed mappings…
Tue, Feb 19, 8:22 AM
jhenderson committed rL354344: [yaml2obj][obj2yaml] Remove section type range markers from allowed mappings….
[yaml2obj][obj2yaml] Remove section type range markers from allowed mappings…
Tue, Feb 19, 8:22 AM
jhenderson closed D58383: [yaml2obj][obj2yaml] Remove section type range markers from allowed mappings and support hex values.
Tue, Feb 19, 8:22 AM · Restricted Project
RKSimon committed rGd6add7491564: Cast from SDValue directly instead of superfluous getNode(). NFCI. (authored by RKSimon).
Cast from SDValue directly instead of superfluous getNode(). NFCI.
Tue, Feb 19, 8:21 AM
RKSimon committed rL354343: Cast from SDValue directly instead of superfluous getNode(). NFCI..
Cast from SDValue directly instead of superfluous getNode(). NFCI.
Tue, Feb 19, 8:19 AM
Anastasia added inline comments to D58346: [Sema] Change addr space diagnostics in casts to follow C++ style.
Tue, Feb 19, 8:19 AM
sammccall accepted D58387: [clangd] Add an option in the code to not display number of fixes.
Tue, Feb 19, 8:19 AM · Restricted Project
ilya-biryukov created D58387: [clangd] Add an option in the code to not display number of fixes.
Tue, Feb 19, 8:13 AM · Restricted Project
fedor.sergeev added a comment to D58231: [LICM] Support of widenable condition guards in LICM.

The main motivation is unification - I don't want to leave a single thing that is supported for intrinsic guards and not supported for control flow guards. Unswitching has known problems related to exponential code size growth, so I don't want our ability to eliminate guards in loops to depend on its cost model.

Trivial unswitch does not have a problem of exponential code growth.
Basically, what you do here does match what trivial unswitch does.
So in order to rely on unswitch we just need to ensure that this widenable branch thing does fall into a trivial unswitch category.

Tue, Feb 19, 8:10 AM · Restricted Project
arsenm committed rG267601455eca: GlobalISel: Verify g_insert (authored by arsenm).
GlobalISel: Verify g_insert
Tue, Feb 19, 8:10 AM
arsenm closed D58262: GlobalISel: Verify g_insert.

r354342

Tue, Feb 19, 8:10 AM
arsenm committed rL354342: GlobalISel: Verify g_insert.
GlobalISel: Verify g_insert
Tue, Feb 19, 8:09 AM