Today

spatel committed rL330547: [InstCombine] add vector test with undef elts; NFC.
[InstCombine] add vector test with undef elts; NFC
Sun, Apr 22, 9:02 AM
JDevlieghere created D45930: [Support] Upstream anonymization and manipulating of BCSymbolMaps.
Sun, Apr 22, 8:56 AM
RKSimon committed rL330546: [X86] Fix (completely overridden) WriteFHAdd/WritePHAdd classes to allow us to….
[X86] Fix (completely overridden) WriteFHAdd/WritePHAdd classes to allow us to…
Sun, Apr 22, 8:30 AM
rengolin added a comment to D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree.

Side effect of that is D45552 will have to land in Transform first and then move to Analysis when the descriptors move.

Sun, Apr 22, 8:30 AM
rengolin accepted D45684: [AArch64][SVE] Asm: Support for contiguous, non-faulting LDNF1 (scalar+imm) load instructions.
Sun, Apr 22, 8:23 AM
rengolin accepted D45681: [AArch64][SVE] Asm: Support for structured ST2, ST3 and ST4 (scalar+imm) store instructions..
Sun, Apr 22, 8:23 AM
RKSimon committed rL330545: [X86][MMX][SSE] Tag missed PHADD/PHSUB instructions with WritePHAdd .
[X86][MMX][SSE] Tag missed PHADD/PHSUB instructions with WritePHAdd
Sun, Apr 22, 8:05 AM
erik.pilkington added inline comments to D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table.
Sun, Apr 22, 8:04 AM
erik.pilkington updated the diff for D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table.

Add a comment.

Sun, Apr 22, 8:04 AM
whitequark accepted D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.

LGTM

Sun, Apr 22, 8:00 AM
RKSimon committed rL330544: [X86] Remove unnecessary WriteFVarBlend/WriteVarBlend InstRW overrides..
[X86] Remove unnecessary WriteFVarBlend/WriteVarBlend InstRW overrides.
Sun, Apr 22, 7:46 AM
george.karpenkov accepted D45682: [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to `BugReporterVisitors.h`..

can add extra notes like

Sun, Apr 22, 7:44 AM
spatel committed rL330543: [InstSimplify, InstCombine] add vector tests with undef elts; NFC.
[InstSimplify, InstCombine] add vector tests with undef elts; NFC
Sun, Apr 22, 7:22 AM
MTC added a comment to D45682: [analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to `BugReporterVisitors.h`..

I'm new to the taint visitor, but I am quite confused by your change description.

and many checkers rely on it

How can other checkers rely on it if it's private to the taint checker?

Thanks for your review, george! TaintBugVisitor is an utility to add extra information to illustrate where the taint information originated from. There are several checkers use taint information, e.g. ArrayBoundCheckerV2.cpp, in some cases it will report a warning, like warning: Out of bound memory access (index is tainted). If TaintBugVisitor moves to BugReporterVisitors.h, ArrayBoundCheckerV2 can add extra notes like Taint originated here to the report by adding TaintBugVisitor.

Sun, Apr 22, 6:55 AM
george.karpenkov added a comment to D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call.

antipatterns or security could be another potential category name.

Sun, Apr 22, 6:28 AM
george.karpenkov accepted D45177: CStringChecker, check strlcpy/strlcat.
Sun, Apr 22, 6:23 AM
dtemirbulatov added inline comments to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..
Sun, Apr 22, 6:21 AM
george.karpenkov added a comment to D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call.

The code looks good apart from a few minor nits. I think I would prefer a new category created for this checker instead of using alpha; let's see what @NoQ has to say.

Sun, Apr 22, 6:02 AM
RKSimon created D45929: [X86] Add vector element insertion/extraction scheduler classes.
Sun, Apr 22, 5:51 AM
george.karpenkov requested changes to D45718: [analyzer] Allow registering custom statically-linked analyzer checkers.

Actually, we do have unittests in tools/clang/unittest/Analysis.
@alexfh would you be able to write a unittest in there? It should be fairly easy following the structure of e.g. tools/clang/Analysis/CloneDetectionTest.cpp.
This would also help to ensure this entry point does not bit rot.

Sun, Apr 22, 5:29 AM
CodaFi created D45928: [LLVM-C] Add DIBuilder Bindings For Variable Creation.
Sun, Apr 22, 5:29 AM
george.karpenkov retitled D45718: [analyzer] Allow registering custom statically-linked analyzer checkers from Allow registering custom statically-linked analyzer checkers to [analyzer] Allow registering custom statically-linked analyzer checkers.
Sun, Apr 22, 5:10 AM
RKSimon committed rL330542: [X86] Fix WriteMPSAD/WritePSADBW values to allow us to remove unnecessary….
[X86] Fix WriteMPSAD/WritePSADBW values to allow us to remove unnecessary…
Sun, Apr 22, 3:44 AM
lsaba added a comment to D45823: [X86] Fix Update Kill Register in Avoid SFB Pass - Bug 37153.

ping

Sun, Apr 22, 3:39 AM
RKSimon committed rL330541: [X86][SandyBridge] Remove unnecessary WritePOPCNTLd overrides by fixing load….
[X86][SandyBridge] Remove unnecessary WritePOPCNTLd overrides by fixing load…
Sun, Apr 22, 3:07 AM
RKSimon committed rL330540: [llvm-mca][X86] Add POPCNT resource test.
[llvm-mca][X86] Add POPCNT resource test
Sun, Apr 22, 3:04 AM
JDevlieghere committed rL330539: [test] Fix MC/ELF/nocompression.s.
[test] Fix MC/ELF/nocompression.s
Sun, Apr 22, 1:49 AM
JDevlieghere committed rL330538: [lli] Fix syntax error: missing ';'.
[lli] Fix syntax error: missing ';'
Sun, Apr 22, 1:39 AM
JDevlieghere added a comment to D41979: [bcanalyzer] Recognize more stream types.

Thanks, @JDevlieghere! I added two tests like the ones you described. Thankfully it doesn't crash because llvm-bcanalyzer verifies the bitcode invariant that input sizes be a multiple of 4.

Sun, Apr 22, 1:16 AM
JDevlieghere committed rL330537: [lli] Make error handling more consistent..
[lli] Make error handling more consistent.
Sun, Apr 22, 1:08 AM
JDevlieghere committed rL330536: [llvm-mc] Make error handling more consistent..
[llvm-mc] Make error handling more consistent.
Sun, Apr 22, 1:05 AM
JDevlieghere committed rL330535: [Support] Fix prefix logic in WithColor..
[Support] Fix prefix logic in WithColor.
Sun, Apr 22, 1:04 AM
Hahnfeld added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

Do we really want to call this tool Archer? I understand that it was written for that purpose but IMO this can serve a much more general purpose, even without the Archer "framework" around it.

Sun, Apr 22, 12:53 AM
zinovy.nis updated subscribers of D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

I think spaces that will be removed should be counted - long long is 9.

Sun, Apr 22, 12:32 AM · Restricted Project
malcolm.parsons added a comment to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

I think spaces that will be removed should be counted - long long is 9.

Sun, Apr 22, 12:11 AM · Restricted Project

Yesterday

zinovy.nis created D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.
Sat, Apr 21, 11:47 PM · Restricted Project
ctopper committed rL330534: [X86] Remove an unnecessary HANDLE_OPTIONAL line from the disassembler operand….
[X86] Remove an unnecessary HANDLE_OPTIONAL line from the disassembler operand…
Sat, Apr 21, 11:43 PM
ctopper committed rL330533: [X86] Change TB to PS on LFENCE instruction..
[X86] Change TB to PS on LFENCE instruction.
Sat, Apr 21, 8:18 PM
ctopper committed rL330532: [X86] Remove OpSizeIgnore, it's not implemented any differently than….
[X86] Remove OpSizeIgnore, it's not implemented any differently than…
Sat, Apr 21, 6:28 PM
ctopper committed rL330531: [X86] Remove DATA32_PREFIX. Hack the printing for DATA16_PREFIX to print….
[X86] Remove DATA32_PREFIX. Hack the printing for DATA16_PREFIX to print…
Sat, Apr 21, 5:55 PM