Page MenuHomePhabricator

Today

nikic added a comment to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

I've committed the baseline sub.ll tests in rL358808. Could you please rebase over them and rerun update_test_checks.py?

Sat, Apr 20, 12:59 AM · Restricted Project
GitHub <noreply@github.com> committed rG07144fd4c42c: Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into… (authored by ocochard).
Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into…
Sat, Apr 20, 12:58 AM
MaskRay committed rGb48e41be9625: [llvm-objdump] Fix End in disassemblyObject after rL358806 (authored by MaskRay).
[llvm-objdump] Fix End in disassemblyObject after rL358806
Sat, Apr 20, 12:49 AM
MaskRay committed rL358809: [llvm-objdump] Fix End in disassemblyObject after rL358806.
[llvm-objdump] Fix End in disassemblyObject after rL358806
Sat, Apr 20, 12:49 AM
nikic committed rG2e33f8de5774: [CVP] Add tests for sub nowrap inference; NFC (authored by nikic).
[CVP] Add tests for sub nowrap inference; NFC
Sat, Apr 20, 12:43 AM
nikic committed rL358808: [CVP] Add tests for sub nowrap inference; NFC.
[CVP] Add tests for sub nowrap inference; NFC
Sat, Apr 20, 12:42 AM
GitHub <noreply@github.com> committed rG4fba41602a45: Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into… (authored by ocochard).
Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into…
Sat, Apr 20, 12:35 AM
Hahnfeld added a comment to D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading.

So the scheme is: pow is defined in __clang_openmp_math.h to call __kmpc_pow. This lives in libomptarget-nvptx (both bc and static lib) and just calls pow which works because nvcc and Clang in CUDA mode make sure that the call gets routed into libdevice?

Sat, Apr 20, 12:31 AM · Restricted Project
nikic committed rGb75c8fc6fbac: [X86] Fix stack probing on x32 (PR41477) (authored by nikic).
[X86] Fix stack probing on x32 (PR41477)
Sat, Apr 20, 12:28 AM
nikic committed rL358807: [X86] Fix stack probing on x32 (PR41477).
[X86] Fix stack probing on x32 (PR41477)
Sat, Apr 20, 12:27 AM
nikic added a reviewer for D60846: [ValueTracking] Improve isKnowNonZero for Ints: spatel.
Sat, Apr 20, 12:27 AM · Restricted Project
MaskRay committed rGce12ea8dfc37: [llvm-objdump] Don't disassemble symbols before SectionAddr (authored by MaskRay).
[llvm-objdump] Don't disassemble symbols before SectionAddr
Sat, Apr 20, 12:20 AM
MaskRay committed rL358806: [llvm-objdump] Don't disassemble symbols before SectionAddr.
[llvm-objdump] Don't disassemble symbols before SectionAddr
Sat, Apr 20, 12:20 AM
Hahnfeld added a comment to D60918: [OPENMP][NVPTX]Correctly handle L2 parallelism in SPMD mode..

Why is it enough to have one counter per warp, what happens if threads within a warp diverge? Before D55773 we had a counter per thread...

Sat, Apr 20, 12:20 AM · Restricted Project

Yesterday

luqmana added a comment to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

We should probably give reenabling the option by default another try (in a separate revision), at least I can't seem to reproduce the issue in PR31181 anymore.

Fri, Apr 19, 11:18 PM · Restricted Project
luqmana updated the diff for D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..

Rename option and method to be more general.

Fri, Apr 19, 11:12 PM · Restricted Project
luqmana added inline comments to D60036: [CorrelatedValuePropagation] Mark subs that we know not to wrap with nuw/nsw..
Fri, Apr 19, 11:12 PM · Restricted Project
lebedev.ri added a comment to D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types.

The APSInt.h itself looks good to me.

Fri, Apr 19, 11:05 PM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rGd77c681a8c36: Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into… (authored by ocochard).
Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into…
Fri, Apr 19, 10:36 PM
lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Now that the unit and regression test infrastructure is in place I think it's time to move development of this to trunk. I'm going to commit tomorrow morning when I can keep an eye on the bots.

Fri, Apr 19, 10:35 PM · Restricted Project
lhames updated the diff for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

More updates:

Fri, Apr 19, 10:33 PM · Restricted Project
craig.topper committed rG4d4b5d952e45: [X86] Don't turn (and (shl X, C1), C2) into (shl (and X, (C1 >> C2), C2) if the… (authored by craig.topper).
[X86] Don't turn (and (shl X, C1), C2) into (shl (and X, (C1 >> C2), C2) if the…
Fri, Apr 19, 9:39 PM
craig.topper committed rG8b8264828cbc: [X86] Turn (and (anyextend (shl X, C1), C2)) into (shl (and (anyextend X), (C1… (authored by craig.topper).
[X86] Turn (and (anyextend (shl X, C1), C2)) into (shl (and (anyextend X), (C1…
Fri, Apr 19, 9:38 PM
ctopper committed rL358805: [X86] Don't turn (and (shl X, C1), C2) into (shl (and X, (C1 >> C2), C2) if the….
[X86] Don't turn (and (shl X, C1), C2) into (shl (and X, (C1 >> C2), C2) if the…
Fri, Apr 19, 9:38 PM
ctopper committed rL358804: [X86] Turn (and (anyextend (shl X, C1), C2)) into (shl (and (anyextend X), (C1….
[X86] Turn (and (anyextend (shl X, C1), C2)) into (shl (and (anyextend X), (C1…
Fri, Apr 19, 9:38 PM
MaskRay created D60933: [CommandLine] Provide parser<unsigned long> instantiation to allow cl::opt<uint64_t> on LP64 platforms.
Fri, Apr 19, 9:10 PM · Restricted Project
zturner added a comment to rG41fe3a54c261: Ensure that ManagedStatic is constant initialized in MSVC 2017 & 2019.

I just built against trunk with VS 2019 and ran into this exact issue. llvm-tblgen had no command line options. Are more fixes still in the pipeline or was this thought to be sufficient?

Fri, Apr 19, 9:07 PM
hubert.reinterpretcast accepted D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..

LGTM with minor changes (no need to post a new revision).

Fri, Apr 19, 8:22 PM · Restricted Project
liutianle added a comment to D60779: [ADT] llvm::bsearch, binary search for mere mortals.

hi sammccall, when I run "check-all", some waring/error print out in STLExtrasTest.cpp as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you please fix it or guide me how to fix it?

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:475:58: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

EXPECT_EQ(5u, bsearch(5, 10, [](unsigned X) { return X >= 0; }));
                                                       ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                 ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'

EXPECT_PRED_FORMAT2(::testing::internal:: \
^

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:475:3: note: in expansion of macro 'EXPECT_EQ'

EXPECT_EQ(5u, bsearch(5, 10, [](unsigned X) { return X >= 0; }));
^

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:483:67: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

bsearch(V.begin(), V.end(), [](unsigned X) { return X >= 0; }));
                                                      ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                    ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'

EXPECT_PRED_FORMAT2(::testing::internal:: \
^

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:482:3: note: in expansion of macro 'EXPECT_EQ'

EXPECT_EQ(V.begin(),
^

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp: In lambda function:
myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:489:61: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

EXPECT_EQ(V.begin(), bsearch(V, [](unsigned X) { return X >= 0; }));
                                                          ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:77:52: note: in definition of macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                 ^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest_pred_impl.h:162:3: note: in expansion of macro 'GTEST_PRED_FORMAT2_'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
^

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1923:3: note: in expansion of macro 'EXPECT_PRED_FORMAT2'

EXPECT_PRED_FORMAT2(::testing::internal:: \
^

myLLVM/llvm/unittests/ADT/STLExtrasTest.cpp:489:3: note: in expansion of macro 'EXPECT_EQ'

EXPECT_EQ(V.begin(), bsearch(V, [](unsigned X) { return X >= 0; }));
^

Fri, Apr 19, 8:18 PM · Restricted Project
liutianle added a comment to D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes..

hi ymandel,

When I run "check-all", there are some warning/error in TransformerTest.cpp as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you please have a fix or guild me how to fix it?

In file included from myLLVM/llvm/utils/unittest/googlemock/include/gmock/internal/gmock-internal-utils.h:47:0,

from myLLVM/llvm/utils/unittest/googlemock/include/gmock/gmock-actions.h:46,
from myLLVM/llvm/utils/unittest/googlemock/include/gmock/gmock.h:58,
from myLLVM/llvm/tools/clang/unittests/Tooling/TransformerTest.cpp:13:

myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int]':
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1421:23: required from 'static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int; bool lhs_is_null_literal = false]'
myLLVM/llvm/tools/clang/unittests/Tooling/TransformerTest.cpp:372:3: required from here
myLLVM/llvm/utils/unittest/googletest/include/gtest/gtest.h:1392:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

if (lhs == rhs) {
        ^

Fri, Apr 19, 8:12 PM · Restricted Project, Restricted Project
GitHub <noreply@github.com> committed rG986490f88b25: Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into… (authored by ocochard).
Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into…
Fri, Apr 19, 7:36 PM
dlrobertson updated the diff for D60846: [ValueTracking] Improve isKnowNonZero for Ints.
Fri, Apr 19, 7:35 PM · Restricted Project
dlrobertson updated the diff for D60846: [ValueTracking] Improve isKnowNonZero for Ints.

Update after added tests

Fri, Apr 19, 7:31 PM · Restricted Project
dlrobertson added a parent revision for D60846: [ValueTracking] Improve isKnowNonZero for Ints: D60932: [NFC] Add baseline tests for int isKnownNonZero.
Fri, Apr 19, 7:30 PM · Restricted Project
dlrobertson added a child revision for D60932: [NFC] Add baseline tests for int isKnownNonZero: D60846: [ValueTracking] Improve isKnowNonZero for Ints.
Fri, Apr 19, 7:30 PM · Restricted Project
dlrobertson created D60932: [NFC] Add baseline tests for int isKnownNonZero.
Fri, Apr 19, 7:29 PM · Restricted Project
jyknight added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

There shouldn't be an empty string ("") in the asm output -- that should be a reference to the "l_yes" label, not the empty string. That seems very weird...

Fri, Apr 19, 7:21 PM
MaskRay committed rG8f28f7a48815: [llvm-objdump] Simplify --{start,stop}-address (authored by MaskRay).
[llvm-objdump] Simplify --{start,stop}-address
Fri, Apr 19, 7:13 PM
GitHub <noreply@github.com> committed rG93ec2827f599: Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into… (authored by ocochard).
Merge cd10fbd7897fe5bc00055b9d835c374549f8f4a9 into…
Fri, Apr 19, 7:13 PM
steven_wu updated the diff for D60924: [ThinLTO] Adding architecture name into saved object filename.

Add tests for the change. There is acutally an easy to test with llvm-lto

Fri, Apr 19, 7:12 PM · Restricted Project