Page MenuHomePhabricator

Today

vsk added inline comments to D34499: Expose __gcov_flush for parity with libgcov in the gcc project.
Wed, Feb 20, 11:14 AM · Restricted Project, Restricted Project
vitalybuka added inline comments to D58432: SanitizerCommon: 64-bit SPARC/Linux port.
Wed, Feb 20, 11:14 AM · Restricted Project, Restricted Project
pcc added inline comments to D58188: CodeGen: Explicitly initialize structure padding in the -ftrivial-auto-var-init mode.
Wed, Feb 20, 11:14 AM
rtereshin added inline comments to D58098: [IR] Add Use::moveToFrontOfUseList() method.
Wed, Feb 20, 11:14 AM · Restricted Project
hokein added inline comments to D58345: [clangd] Using symbol name to map includes for STL symbols..
Wed, Feb 20, 11:10 AM · Restricted Project
ilya-biryukov committed rG2754942cbaef: [clangd] Store index in '.clangd/index' instead of '.clangd-index' (authored by ilya-biryukov).
[clangd] Store index in '.clangd/index' instead of '.clangd-index'
Wed, Feb 20, 11:08 AM
niravd committed rG1ce977f94676: Add test case. (authored by niravd).
Add test case.
Wed, Feb 20, 11:08 AM
martong committed rG2ac9ee3e1383: Fix remaining semicolon pedantic errors for intel (authored by martong).
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:08 AM
ibiryukov committed rL354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
[clangd] Store index in '.clangd/index' instead of '.clangd-index'
Wed, Feb 20, 11:08 AM
ibiryukov committed rCTE354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
[clangd] Store index in '.clangd/index' instead of '.clangd-index'
Wed, Feb 20, 11:08 AM
Diffusion closed D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
Wed, Feb 20, 11:08 AM · Restricted Project, Restricted Project
niravd committed rL354504: Add test case..
Add test case.
Wed, Feb 20, 11:08 AM
sivachandra committed rG3988d5c8fae0: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. (authored by sivachandra).
[Clang Driver] Add support for "-static-pie" argument to the Clang driver.
Wed, Feb 20, 11:08 AM
martong committed rC354503: Fix remaining semicolon pedantic errors for intel.
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:07 AM
martong committed rL354503: Fix remaining semicolon pedantic errors for intel.
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:07 AM
sivachandra committed rC354502: [Clang Driver] Add support for "-static-pie" argument to the Clang driver..
[Clang Driver] Add support for "-static-pie" argument to the Clang driver.
Wed, Feb 20, 11:07 AM
sivachandra committed rL354502: [Clang Driver] Add support for "-static-pie" argument to the Clang driver..
[Clang Driver] Add support for "-static-pie" argument to the Clang driver.
Wed, Feb 20, 11:07 AM
sivachandra closed D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver..
Wed, Feb 20, 11:07 AM · Restricted Project, Restricted Project
jankratochvil created D58465: testsuite: Fix TestCompDirSymLink on Linux with symlinked build dir.
Wed, Feb 20, 11:07 AM · Restricted Project
jonpa updated the diff for D58270: [SystemZ] Load all vector and FP constants in Select() .

Added handling for fp128 on z14, with some new tests that checks that this is working in fp-const-11.ll. NFC on spec on z14.

Wed, Feb 20, 11:05 AM
craig.topper created D58464: [SelectionDAG] Teach GetDemandedBits to look at the known zeros of the LHS when handling ISD::AND.
Wed, Feb 20, 11:05 AM
ilya-biryukov updated the diff for D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
  • Update .gitignore
Wed, Feb 20, 11:04 AM · Restricted Project, Restricted Project
kuhar added a comment to D58170: [DTU] Refine the interface and logic of applyUpdates.

I think the default for applyUpdates should be the strict mode; any code that relies on imprecise information about updates should make it clear by using some longer name, like applyUpdatesRelaxed.

I'm fine with making applyUpdates default to strict mode to make it consistent to other parts of the codebase and encourage people to use the strict one which does not have extra overhead on scanning the CFG.

But if the user follows the rules on using applyUpdatesRelaxed/Checked, DTU is also guaranteed to have precise information on updates.

Wed, Feb 20, 11:03 AM · Restricted Project
craig.topper committed rGb1b2fa35ed7f: [X86] Add test case to show missed opportunity to remove an explicit AND on the… (authored by craig.topper).
[X86] Add test case to show missed opportunity to remove an explicit AND on the…
Wed, Feb 20, 11:02 AM
ctopper committed rL354501: [X86] Add test case to show missed opportunity to remove an explicit AND on the….
[X86] Add test case to show missed opportunity to remove an explicit AND on the…
Wed, Feb 20, 11:01 AM
vitalybuka added inline comments to D58433: AddressSanitizer: fix for SPARC with GCC.
Wed, Feb 20, 11:00 AM · Restricted Project, Restricted Project
jkorous updated the diff for D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

[DirectoryWatcher] Fix detection of FSEvents for iOS
[DirectoryWatcher][NFC] Doxygen

Wed, Feb 20, 11:00 AM · Restricted Project
ilya-biryukov added inline comments to D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
Wed, Feb 20, 10:59 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'.
  • Remove trailing slash from the path
Wed, Feb 20, 10:57 AM · Restricted Project, Restricted Project
vitalybuka committed rGe4a7a461514a: Fix license headers (authored by vitalybuka).
Fix license headers
Wed, Feb 20, 10:57 AM
vitalybuka committed rCRT354500: Fix license headers.
Fix license headers
Wed, Feb 20, 10:57 AM
vitalybuka committed rL354500: Fix license headers.
Fix license headers
Wed, Feb 20, 10:57 AM
MyDeveloperDay added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

This revision needs unit tests in clang/unittests/Format

Wed, Feb 20, 10:56 AM · Restricted Project, Restricted Project
mgorny accepted D58411: Update `ld.lld --version` string for monorepo..

LGTM

Wed, Feb 20, 10:56 AM · Restricted Project
aganea added inline comments to D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option.
Wed, Feb 20, 10:56 AM · Restricted Project, lld
ABataev created D58463: [CUDA]Delayed diagnostics for the asm instructions..
Wed, Feb 20, 10:54 AM · Restricted Project
vitalybuka accepted D58434: AddressSanitizer: 64-bit SPARC/Linux port.

LGTM with "git clang-format -f --style=file --extensions=inc,cc,h,c,cpp HEAD^"

Wed, Feb 20, 10:52 AM · Restricted Project, Restricted Project
vitalybuka requested changes to D58434: AddressSanitizer: 64-bit SPARC/Linux port.
Wed, Feb 20, 10:52 AM · Restricted Project, Restricted Project
NutshellySima added a comment to D58170: [DTU] Refine the interface and logic of applyUpdates.

I think the default for applyUpdates should be the strict mode; any code that relies on imprecise information about updates should make it clear by using some longer name, like applyUpdatesRelaxed.

Wed, Feb 20, 10:49 AM · Restricted Project
ruiu added inline comments to D58411: Update `ld.lld --version` string for monorepo..
Wed, Feb 20, 10:47 AM · Restricted Project