Page MenuHomePhabricator

Today

void added a comment to D55616: Emit ASM input in a constant context.

Looks like it's broken by this patch

clang: /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm/tools/clang/lib/AST/ExprConstant.cpp:11055: llvm::APSInt clang::Expr::EvaluateKnownConstInt(const clang::ASTContext &, SmallVectorImpl<clang::PartialDiagnosticAt> *) const: Assertion `Result && "Could not evaluate expression"' failed.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/9281/steps/check-clang%20msan/logs/stdio

Tue, Dec 18, 9:02 PM
void committed rL349604: Use "EvaluateAsRValue" instead of as a known int, because if it's not a known.
Use "EvaluateAsRValue" instead of as a known int, because if it's not a known
Tue, Dec 18, 8:59 PM
void committed rC349604: Use "EvaluateAsRValue" instead of as a known int, because if it's not a known.
Use "EvaluateAsRValue" instead of as a known int, because if it's not a known
Tue, Dec 18, 8:59 PM
dschuff added a comment to D52634: [WebAssembly] Add DBG_VALUE with local operands location in WebAssemblyExplicitLocals pass.

@aprantl Is the advantage of your suggested approach just that we don't have to define a new expression type? Obviously the interpretation is not the same as DW_OP_breg on other targets so as you say, either way there would have to be special logic in all the tools that consume it. Is this kind of repurposing of builtin primitives common?

Tue, Dec 18, 8:43 PM · debug-info
void committed rL349603: Revert accidentally included code..
Revert accidentally included code.
Tue, Dec 18, 8:40 PM
void committed rC349603: Revert accidentally included code..
Revert accidentally included code.
Tue, Dec 18, 8:40 PM
dcoughlin added a comment to D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types..

These seems reasonable, although it does also seem like there could be quite a few unintended consequences that we haven't discovered yet.

Tue, Dec 18, 8:38 PM
pcc added inline comments to D55874: [asan] Support running without /proc..
Tue, Dec 18, 8:29 PM
dcoughlin accepted D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered..

LGTM.

Tue, Dec 18, 8:18 PM
dcoughlin accepted D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame..

This seems reasonable to me, although I have a question inline about why you are using makeZeroElementRegion().

Tue, Dec 18, 8:13 PM
yhs committed rL349602: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.
[DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected
Tue, Dec 18, 8:11 PM
Diffusion closed D55756: [DebugInfo] Make AsmPrinter struct HandlerInfo and Handlers protected.
Tue, Dec 18, 8:11 PM · debug-info
pcc accepted D55801: [sanitizer] Support running without fd 0,1,2..

LGTM

Tue, Dec 18, 7:58 PM
ayonam added a comment to D52002: Switch optimization for known maximum switch values.

If you can provide more details about what didn't work, maybe I can help investigate. (Though I'm about to go on holiday soon, so probably not until January.)

There are three files that when compiled with this patch, generate wrong code, viz., AArch64LoadStoreOptimizer.cpp, AArch64InstrInfo.cpp and AArch64ConditionalCompares.cpp. Out of these we tried to isolate the problem with the last one. I figured out that if the functions SSACCmpConv::findConvertibleCompare() and SSACCmpConv::convert() are compiled without this patch, the code works fine. So the problem surfaces with these two routines only. There are a few switch cases in those two routines but I couldn't see anything exceptional with those except for a call to builtin_unreachable() in the default case for two of the switches and a [[clang::fallthrough]] in another. In all these three cases, I was unable to figure out how they could possibly break our assumptions. Does the builtin_unreachable() have any special semantic that we are not handling?

Does the error show with the regular lit tests, or do you have some internal test that fails?

My first guess would be that one of the "unreachable" defaults aren't actually unreachable for some input. But then they should trap in an asserts-enabled build..

Tue, Dec 18, 7:49 PM
skatkov added a comment to D55867: [RegisterCoalescer] dst register's live interval needs to be updated when merging a src register in ToBeUpdated set.

I've verified that this patch fixes the original problem.

Tue, Dec 18, 7:48 PM
modocache committed rL349601: [bugpoint][PR29027] Reduce function attributes.
[bugpoint][PR29027] Reduce function attributes
Tue, Dec 18, 7:45 PM
modocache closed D55216: [bugpoint][PR29027] Reduce function attributes.
Tue, Dec 18, 7:45 PM
ayonam added a comment to D52002: Switch optimization for known maximum switch values.

Phabricator has an "upload file" function... or you can just send an email with an attachment to llvm-commits.

Tue, Dec 18, 7:34 PM
rsmith committed rL349600: Fix use-after-free with profile remapping..
Fix use-after-free with profile remapping.
Tue, Dec 18, 7:27 PM
tabloid.adroit added a comment to D55669: [LIR] Add CTTZ support.

Thank you! Splitted into two patches.

Tue, Dec 18, 7:25 PM
tabloid.adroit added a child revision for D55876: [LIR] Add CTTZ support: D55877: [LIR] Add CTTZ support part2.
Tue, Dec 18, 7:22 PM
tabloid.adroit added a parent revision for D55877: [LIR] Add CTTZ support part2: D55876: [LIR] Add CTTZ support.
Tue, Dec 18, 7:22 PM
tabloid.adroit updated the summary of D55877: [LIR] Add CTTZ support part2.
Tue, Dec 18, 7:21 PM
tabloid.adroit created D55877: [LIR] Add CTTZ support part2.
Tue, Dec 18, 7:21 PM
grokos added a comment to D55588: [OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu.

Since a similar solution was adopted for clang, I think we should let this one land. After all, it's a matter of consistency between the two projects.

Tue, Dec 18, 7:16 PM
tabloid.adroit updated the summary of D55876: [LIR] Add CTTZ support.
Tue, Dec 18, 7:13 PM
tabloid.adroit updated the summary of D55876: [LIR] Add CTTZ support.
Tue, Dec 18, 7:13 PM
jedilyn committed rL349599: [PowerPC]Exploit P9 vabsdu for unsigned vselect patterns.
[PowerPC]Exploit P9 vabsdu for unsigned vselect patterns
Tue, Dec 18, 7:07 PM
jedilyn closed D55812: [PowerPC]Exploit P9 vabsdu for some unsigned integer vselect patterns.
Tue, Dec 18, 7:07 PM
tabloid.adroit created D55876: [LIR] Add CTTZ support.
Tue, Dec 18, 7:05 PM
NoQ created D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types..
Tue, Dec 18, 6:56 PM
thakis added a comment to D55838: [gn build] Make `ninja check-lld` also run LLD's unit tests.

Thanks! Actually landing this is blocked on https://reviews.llvm.org/D55836 though.

Tue, Dec 18, 6:54 PM
thakis added a child revision for D55836: [gn build] Add check-lld target and make it work: D55838: [gn build] Make `ninja check-lld` also run LLD's unit tests.
Tue, Dec 18, 6:52 PM
thakis added a parent revision for D55838: [gn build] Make `ninja check-lld` also run LLD's unit tests: D55836: [gn build] Add check-lld target and make it work.
Tue, Dec 18, 6:52 PM
thakis added a parent revision for D55836: [gn build] Add check-lld target and make it work: D55831: [gn build] Add build file for llvm-objcopy.
Tue, Dec 18, 6:51 PM
thakis added a child revision for D55831: [gn build] Add build file for llvm-objcopy: D55836: [gn build] Add check-lld target and make it work.
Tue, Dec 18, 6:51 PM
nico committed rL349598: [gn build] Add build file for llvm-objcopy.
[gn build] Add build file for llvm-objcopy
Tue, Dec 18, 6:51 PM
Diffusion closed D55831: [gn build] Add build file for llvm-objcopy.
Tue, Dec 18, 6:51 PM
amakc11 added a comment to D55777: [libcxx] Portability fix: add missing includes and static_casts..

I don't use clang. The log of running tests including poisoned_hash_helper.hpp is attached.

Tue, Dec 18, 6:38 PM
ZhangKang added inline comments to D55754: [PowerPC] Implement the ”isSelectSupported()“ target hook.
Tue, Dec 18, 6:37 PM