Page MenuHomePhabricator

Today

aganea added a comment to D61946: [xray] Remove usage of procid_t.

Thank you! :)

Tue, Jun 25, 2:38 PM · Restricted Project
JDevlieghere committed rL364351: [dotest] Remove unused function.
[dotest] Remove unused function
Tue, Jun 25, 2:25 PM
teemperor added a comment to D62503: Add ReadCStringFromMemory for faster string reads.

@aadsm Is there any update on the regression fix? This patch also breaks the C++ module test suite, so i would prefer if we could revert it if the fix takes longer.

Tue, Jun 25, 2:25 PM · Restricted Project, Restricted Project
JDevlieghere committed rGc8e450a9179c: [dotest] Remove unused function (authored by JDevlieghere).
[dotest] Remove unused function
Tue, Jun 25, 2:23 PM
loladiro accepted D59730: [GVN] teach ConstantFolding correct handling of non-integral addrspace casts.

This looks fine to me now. @reames if you have a chance, I'd appreciate confirmation that your concerns are addressed as well.

Tue, Jun 25, 2:21 PM · Restricted Project
Bigcheese added inline comments to D63518: BitStream reader: propagate errors.
Tue, Jun 25, 2:21 PM · Restricted Project, Restricted Project
aprantl added a comment to D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations.

Ping: we should hammer out this review, seeing how the branch date for llvm-9 has been announced. Could I suggest that everyone is happy with the *implementation* of this patch, but that it's not yet agreed that it needs merging?

The patch effectively makes the codegen backend stricter about what DBG_VALUE insts it will accept, i.e. they have to refer to vregs that are alive. If it helps, this is already something that's enforced a few optimisation passes later in LiveDebugVariables [0], this patch just brings that check further forwards, due to the errors that can be introduced (described above). What's unfortunate is that this also prevents occasions where register coalescing re-enlivens DBG_VALUEs with a vreg that has the right value in it, occasions which can be generated due to limitations in SelectionDAG.

This then becomes a trade-off (see immediately preceeding comment) of whether the problem is so bad that we should trade some lost locations for getting rid of placeDbgValues. IMHO: yes, because we're trading definitely-incorrect locations for some more being optimized-out, a net reduction in error, to me. Other opinions most welcome.

[0] https://github.com/llvm/llvm-project/blob/b9f1e7b16ed2341e54b4e2033d111e7a2ca19b9a/llvm/lib/CodeGen/LiveDebugVariables.cpp#L624

Tue, Jun 25, 2:21 PM
thegameg added inline comments to D63518: BitStream reader: propagate errors.
Tue, Jun 25, 2:21 PM · Restricted Project, Restricted Project
efriedma added a comment to D63677: [ARM] Don't reserve R12 on Thumb1 as an emergency spill slot..

The third instruction in the function looks like it is using r6 as the base pointer to save one of the argument registers on the stack, but r6 isn't set until further down.

Tue, Jun 25, 2:21 PM · Restricted Project
aprantl added inline comments to D63104: Add GSYM utility files along with unit tests..
Tue, Jun 25, 1:59 PM · Restricted Project
sammccall updated the diff for D63760: [clangd] Address limitations in SelectionTree:.

Revert multi-range support. Add early hit detection (before children) instead.
Add more tests.

Tue, Jun 25, 1:59 PM · Restricted Project
jsji committed rGbc7fc3ecb676: [PowerPC][NFC]Add a test for MachinePipeliner bug (authored by jsji).
[PowerPC][NFC]Add a test for MachinePipeliner bug
Tue, Jun 25, 1:58 PM
jsji committed rL364350: [PowerPC][NFC]Add a test for MachinePipeliner bug.
[PowerPC][NFC]Add a test for MachinePipeliner bug
Tue, Jun 25, 1:57 PM
mgorny created D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
Tue, Jun 25, 1:57 PM
jfb updated the diff for D63518: BitStream reader: propagate errors.
  • clang-format all the code. If it's ugly, don't complain to me
Tue, Jun 25, 1:56 PM · Restricted Project, Restricted Project
arsenm committed rG8fcc70f14148: Don't look for the TargetFrameLowering in the implementation (authored by arsenm).
Don't look for the TargetFrameLowering in the implementation
Tue, Jun 25, 1:56 PM
arsenm committed rL364349: Don't look for the TargetFrameLowering in the implementation.
Don't look for the TargetFrameLowering in the implementation
Tue, Jun 25, 1:56 PM
mgorny created D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
Tue, Jun 25, 1:53 PM
huihuiz committed rL364348: [InstCombine] Simplify icmp ult/uge (shl %x, C2), C1 iff C1 is power of two ->….
[InstCombine] Simplify icmp ult/uge (shl %x, C2), C1 iff C1 is power of two ->…
Tue, Jun 25, 1:53 PM
lildmh updated the diff for D59474: [OpenMP 5.0] Codegen support for user-defined mappers.
Tue, Jun 25, 1:53 PM · Restricted Project, Restricted Project
huihuiz committed rGb90cb57b63ae: [InstCombine] Simplify icmp ult/uge (shl %x, C2), C1 iff C1 is power of two ->… (authored by huihuiz).
[InstCombine] Simplify icmp ult/uge (shl %x, C2), C1 iff C1 is power of two ->…
Tue, Jun 25, 1:49 PM
huihuiz closed D63675: [InstCombine] Simplify icmp ult/uge (shl %x, C2), C1 iff C1 is power of two -> icmp eq/ne (and %x, (lshr -C1, C2)), 0..
Tue, Jun 25, 1:49 PM · Restricted Project
rsmith committed rL364347: Remove redundant expression evaluation context when substituting into a.
Remove redundant expression evaluation context when substituting into a
Tue, Jun 25, 1:49 PM
Richard Smith <richard-llvm@metafoo.co.uk> committed rGdcd7eb710bc4: Remove redundant expression evaluation context when substituting into a… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Remove redundant expression evaluation context when substituting into a…
Tue, Jun 25, 1:49 PM
eugenis added inline comments to D63703: [stack-safety] Refactoring StackSafetyAnalysis to be accsessible from other passes.
Tue, Jun 25, 1:48 PM · Restricted Project
nikic added inline comments to rL364346: [LFTR] Adjust debug output to include extensions (if any).
Tue, Jun 25, 1:48 PM
JDevlieghere created D63790: [dotest] Add the ability to set environment variables for the inferior..
Tue, Jun 25, 1:48 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.

Tue, Jun 25, 1:44 PM · Restricted Project
eugenis accepted D63736: [GWP-ASan] Guard against recursive allocs. Pack TLS for perf..

LGTM

Tue, Jun 25, 1:44 PM · Restricted Project, Restricted Project
rnk accepted D61946: [xray] Remove usage of procid_t.

lgtm, the serialized types are uint32_t:

struct alignas(32) XRayRecord {
...
  // The thread ID for the currently running thread.
  uint32_t TId = 0;
Tue, Jun 25, 1:44 PM · Restricted Project
aemerson added a comment to D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

Hi Amara,

Is something like this OK for intrinsics: https://reviews.llvm.org/differential/diff/206394/ ? It has the disadvantage that if we have an intrinsic with 2 aggregate args, it will be hard to tell where one of them ends and the next one begins. OTOH, I'm having trouble finding intrinsics with even one aggregate parameter, and in fact just using getOrCreateVReg there doesn't cause check-all to crash (nor the test-suite, nor selfhost at -O0 on AArch64).

Alternatively, we could preserve the old interface here and try to move pack/unpackRegs to utils, where we can use them from both the IRTranslator and CallLowering.

Either way, it would be nice to be able to add a test-case before changing this interface, but like I said I don't really know my way around intrinsics that well. Any suggestions?

Tue, Jun 25, 1:44 PM · Restricted Project
dexonsmith updated subscribers of D60480: [libc++] Integrate the PSTL into libc++.
Tue, Jun 25, 1:44 PM · Restricted Project, Restricted Project
eugenis accepted D63761: [compiler-rt][test] Set shared_libasan_path in test/asan/lit.cfg on Solaris.

LGTM

Tue, Jun 25, 1:38 PM · Restricted Project, Restricted Project
vsapsai created D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Tue, Jun 25, 1:38 PM
ldionne added a comment to D61340: [pstl] Move the dummy standard library headers to extra/.

Louis,
thanks for the alternative proposal.

A couple of question:

  1. What's motivation to change "stdlib" to "extra"? To avoid some confusing? (because "stdlib" is not a part of the standard library here)
  2. Can we keep "pstl" name (instead of proposed "include")? The fact is many people have already use PSTL code (as "third party" headers) and a usage model is following:

    #include "pstl/execution" #include "pstl/algorithm" #include "pstl/numeric" #include "pstl/memory"

    We would not like to force them changing #include "pstl/execution" to #include "include/execution"
Tue, Jun 25, 1:36 PM · Restricted Project
andusy created D63788: llvm-c-test avoid calling malloc(0).
Tue, Jun 25, 1:36 PM · Restricted Project
tra accepted D62738: [HIP] Support attribute hip_pinned_shadow.

LGTM. Thank you!

Tue, Jun 25, 1:35 PM
ychen created D63787: [llvm-objdump] Update the doc for --disassemble-functions..
Tue, Jun 25, 1:35 PM · Restricted Project
andusy created D63786: Print NULL as "(null)" in diagnostic message.
Tue, Jun 25, 1:35 PM · Restricted Project
Eugene.Zelenko added reviewers for D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.: alexfh, hokein, aaron.ballman.
Tue, Jun 25, 1:35 PM · Restricted Project