In D147384#4238659, @mehdi_amini wrote:Is the cast still needed now? I would think that getOperation() returns directly the interface now
Active Repositories
Active Repositories
- rZORG LLVM Github Zorg
- Fri, Mar 31, 1:05 PM
- Git
Recent Activity
Recent Activity
Today
Today
Remove the cast because getOperation() already returns the Interface.
This change (according to bisect) seems to cause compiler-rt tests to start hanging on Gentoo.
Is the cast still needed now? I would think that getOperation() returns directly the interface now
RKSimon committed rGbf2ce6ba422b: [X86] combinePTESTCC - fold TESTC(X,~X) -> TESTC(X,-1) (authored by RKSimon).
[X86] combinePTESTCC - fold TESTC(X,~X) -> TESTC(X,-1)
RKSimon committed rGcf1bccf15c35: [X86] Add test showing failure to fold testc(X,~X) -> testc(X,-1) (authored by RKSimon).
[X86] Add test showing failure to fold testc(X,~X) -> testc(X,-1)
carlosgalvezp committed rG2469bd98a772: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous… (authored by carlosgalvezp).
[clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous…
All the new test cases are validated by Alive2.
In D147373#4238398, @RKSimon wrote:Why is the test file called reverse-loop.ll when it doesn't involve loops?
In D147373#4238404, @nikic wrote:As this is not a cost-model driven transform, it should be part of InstCombine, not VectorCombine.
Updated the patch according to comments
alvinhochun requested review of D147382: [asan][test][win] Make report_after_syminitialize test less brittle.
nextsilicon-itay-bookstein added a comment to D140722: [OpenMP] Prefix outlined and reduction func names with original func's name.
I don't have non-cumbersome access to GPU targets at the moment.
I have run the following locally with the patch, and it seems to pass:
> ninja check-libomptarget [0/1] Running libomptarget tests
carlosgalvezp added a comment to D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.
Would it make sense to add a scoped enum to the test, to ensure it doesn't warn/fix?
gilsaia retitled D147381: [MLIR][presburger] normalize divisionrepr from feat:normalize divisionrepr to [MLIR][presburger] normalize divisionrepr.
PiotrZSL added a comment to D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.
Well, description update didn't update, you can update it here in UI, just edit revision, if you use "arc", there is a switch to apply description update.
PiotrZSL accepted D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces.
LGTM
RKSimon committed rGc692e92dc5d6: [X86] combineSetCCMOVMSK - fold PTEST(XOR(X,Y),XOR(X,Y)) instead of PTEST(SUB(X… (authored by RKSimon).
[X86] combineSetCCMOVMSK - fold PTEST(XOR(X,Y),XOR(X,Y)) instead of PTEST(SUB(X…
JDevlieghere added a comment to D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div.
The change looks good: it matches what the DWARFv5 standard says:
sstwcw committed rGfeb585e7d62c: [clang-format] Handle Verilog struct literals (authored by sstwcw).
[clang-format] Handle Verilog struct literals
[clang-format] Handle enum in Verilog
alvinhochun committed rG5888a47914f4: [asan][test] Fix tests or mark XFAIL for MinGW target (authored by alvinhochun).
[asan][test] Fix tests or mark XFAIL for MinGW target
alvinhochun committed rG985580d7c03c: [asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows (authored by alvinhochun).
[asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows
alvinhochun committed rGbae2fbaebf25: [compiler-rt][asan][test] Fix lit test config on MinGW (authored by alvinhochun).
[compiler-rt][asan][test] Fix lit test config on MinGW
sstwcw updated the diff for D147327: [clang-format] Add option for having one port per line in Verilog.
- Use shorter conditions
Add strip_include_prefix to allow angled inclusion of zlib.h.
Switch to zip instead of tar.gz, as the latter seems to be broken.
HerrCai0907 updated the diff for D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.
update description
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected)..
Remove GCC XFAIL in transform/transform_error tests, because we have a workaround to avoid this issue.