Page MenuHomePhabricator

Today

aprantl added a comment to D73148: [lldb/Value] Report size of Value as size of underlying data buffer.

Yes you have. Sorry for the noise.

Fri, Jan 24, 2:29 PM
aheejin committed rG65eb11306e92: [WebAssembly] Update bleeding-edge CPU features (authored by aheejin).
[WebAssembly] Update bleeding-edge CPU features
Fri, Jan 24, 2:29 PM
aheejin closed D73322: [WebAssembly] Update bleeding-edge CPU features.
Fri, Jan 24, 2:29 PM · Restricted Project, Restricted Project
aprantl added a comment to D73148: [lldb/Value] Report size of Value as size of underlying data buffer.
In D73148#1834955, @vsk wrote:

Actually it would be nice to have a test that will trigger on at least one build bot that runs ASAN?

I'll add an end-to-end test for DW_OP_piece, though I worry it might be brittle.

I don't think that's a good way to write a test like this. I suggest checking out test/Shell/SymbolFile/DWARF/DW_OP_piece-struct.s for an dwarf expression test that does not rely on guessing the DW_OP opcodes used by the compiler. Maybe you can just take that test and tweak it to do what you need?

Fri, Jan 24, 2:29 PM
aheejin committed rG764f4089e89e: [WebAssembly] Add reference types target feature (authored by aheejin).
[WebAssembly] Add reference types target feature
Fri, Jan 24, 2:27 PM
aheejin closed D73320: [WebAssembly] Add reference types target feature.
Fri, Jan 24, 2:26 PM · Restricted Project, Restricted Project
eugenis committed rZORG9822b13842a6: Bump Android NDK version to r21. (authored by eugenis).
Bump Android NDK version to r21.
Fri, Jan 24, 2:26 PM
aprantl accepted D73004: llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate.

Nice.

Fri, Jan 24, 2:26 PM · Restricted Project, debug-info
aprantl accepted D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs.

Hmm.. it looks lika a bug.

@aprantl What do you think?

Fri, Jan 24, 2:26 PM · debug-info, Restricted Project
dblaikie added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Fri, Jan 24, 2:26 PM · Restricted Project
aartbik added a comment to D73295: [mlir] [VectorOps] Rewriting of vector.extract/insert_slices to other vector ops.

Hmm. I would argue that the tuple discussion makes less sense in the context of this particular rewriting (since it really deals with getting rid of extract_slices/insert_slices using other slice ops). Cleaning up tuple uses is a nice bonus, but not a requirement, since tuples are really a part of the vector dialect to start with, as the leaking example shows. If you want something that blocks any tuple uses, I would argue that we need another pattern population for that, and run that at places where we need to guarantee they are gone (such as the lowering to LLVM, although the "legality" part takes care of it there already).

Fri, Jan 24, 2:19 PM · Restricted Project
craig.topper committed rGd3bf06bc81e3: [DAGCombiner] Add combine for (not (strict_fsetcc)) to create a strict_fsetcc… (authored by craig.topper).
[DAGCombiner] Add combine for (not (strict_fsetcc)) to create a strict_fsetcc…
Fri, Jan 24, 2:18 PM
craig.topper closed D71816: [DAGCombiner] Add combine for (not (strict_fsetcc)) to create a strict_fsetcc with the opposite condition..
Fri, Jan 24, 2:18 PM · Restricted Project
sivachandra requested changes to D73337: Fix missing dependency in LibcUnitTest.

Sorry, I take my acceptance back. I do not think this is required. If you rebase to HEAD of master, it should work without this change. I think, when you reverted the changes to LLVMLibCRules.cmake, you removed LLVMSupport from the list of link libraries for add_libc_unittest targets.

Fri, Jan 24, 2:17 PM · Restricted Project
vsk added a comment to D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments.

Thanks @djtodoro for looking at this. Sorry for this really delayed response!

This was initially going to be a ping, but as a result of some light offline
discussion I have a few questions. For clarification an "overlap" here refers to
a partial overlap between fragments in DIExpressions.

Fri, Jan 24, 2:17 PM · Restricted Project, debug-info
andrew.w.kaylor added a comment to D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction.
  1. Should we enable FMA "by default" at (for example) '-O2'?
Fri, Jan 24, 2:11 PM · Restricted Project
MaskRay updated subscribers of D72357: Fix llvm-objcopy when directory contains "bar"..
Fri, Jan 24, 2:09 PM · Restricted Project
nicolasvasilache added a comment to D73295: [mlir] [VectorOps] Rewriting of vector.extract/insert_slices to other vector ops.

Well my point here is that if you added the patterns to fold the tuples, you would do as good a job as you could in the absence of region/function boundaries.
Here you created an example that leaks in an unfixable way (because we have conciously decided to no lower the tuple<vector> type to LLVMIR and take the strong position that it must canonicalize/fold/DCE away).

Fri, Jan 24, 2:09 PM · Restricted Project
sivachandra accepted D73337: Fix missing dependency in LibcUnitTest.

Thanks for the fix.

Fri, Jan 24, 2:09 PM · Restricted Project
gbencze added a comment to D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check.

ping

Fri, Jan 24, 2:09 PM · Restricted Project, Restricted Project
shafik committed rG118efa5cda86: [LLDB][NFC] Adding clarifying comment in SymbolFileDWARFDebugMap::DumpClangAST(. (authored by shafik).
[LLDB][NFC] Adding clarifying comment in SymbolFileDWARFDebugMap::DumpClangAST(.
Fri, Jan 24, 2:02 PM
evandro committed rG9fa0f236d501: [PATCH] [Target] Test commit (authored by evandro).
[PATCH] [Target] Test commit
Fri, Jan 24, 2:00 PM
Lubomir Litchev <Lubomir.Litchev@intel.com> committed rG293d644db920: Adding sqrt operation to Linalg and EDSC and standard dialect. (authored by Lubomir Litchev <Lubomir.Litchev@intel.com>).
Adding sqrt operation to Linalg and EDSC and standard dialect.
Fri, Jan 24, 1:59 PM
eugenis committed rG596d06145a2b: [GWP-ASan] enable/disable and fork support. (authored by eugenis).
[GWP-ASan] enable/disable and fork support.
Fri, Jan 24, 1:59 PM
flaub committed rGa919919fcc1b: Temporary patch for pxa (authored by flaub).
Temporary patch for pxa
Fri, Jan 24, 1:59 PM
eugenis closed D73294: [GWP-ASan] enable/disable and fork support..
Fri, Jan 24, 1:59 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Here is a proposal: we add two children to -Wrange-loop-analysis.

Fri, Jan 24, 1:59 PM · Restricted Project
serge-sans-paille added a comment to D71566: New checks for fortified sprintf.

Continues to LG, do you need me to commit on your behalf?

Fri, Jan 24, 1:59 PM · Restricted Project
merge_guards_bot added a comment to D73295: [mlir] [VectorOps] Rewriting of vector.extract/insert_slices to other vector ops.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 24, 1:59 PM · Restricted Project
steveire added a comment to D73028: Extract ExprTraversal class from Expr.

The follow-up is here: https://reviews.llvm.org/D73029 .

I have the need to change the ascending traversal implemented in ASTContext.cpp with a map (populated while descending) to make it skip nodes too during parent traversal.

I didn't want to have descending traversal in Expr.cpp and ascending traversal in ASTContext.cpp as they would be likely to go out of sync, so moving this implementation here allows extending the purpose in the follow-up.

The ascending traversal should not be in the AST library at all. If tooling or static analysis wants this, that's fine, but navigating upwards is not something the AST supports, and we do not want any part of clang proper developing a reliance on having a parent map, so we're working on moving the parent map out of ASTContext (with a plan to eventually move it out of the AST library). See D71313 for related work in this area.

Fri, Jan 24, 1:53 PM · Restricted Project
davidxl added a comment to D73381: [PGO][PGSO] Handle MBFIWrapper.

The MBFIWrapper change seems NFC, can it be extracted out first?

Fri, Jan 24, 1:53 PM · Restricted Project
rnk accepted D72665: [X86] Break the loop in LowerReturn into 2 loops..

lgtm

Fri, Jan 24, 1:51 PM · Restricted Project
dblaikie added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Fri, Jan 24, 1:51 PM · Restricted Project
lebedev.ri added a comment to D73380: [clang] Annotating C++'s `operator new` with more attributes.

LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or?

To be honest, i don't really believe it is LLVM place to deduce attributes on standard library functions like these, frontend should be doing that.
Because as noted in patch description, if noalias is blindly "deduced" by LLVM,
that is a miscompile if -fno-assume-sane-operator-new was specificed.

Fri, Jan 24, 1:51 PM · Restricted Project, Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rGda8bada93833: [gn build] Port 8a81daaa8b5 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port 8a81daaa8b5
Fri, Jan 24, 1:50 PM
Harbormaster failed remote builds in B44877: Diff 240281 for D73294: [GWP-ASan] enable/disable and fork support.!
Fri, Jan 24, 1:50 PM · Restricted Project, Restricted Project
craig.topper added a comment to D72665: [X86] Break the loop in LowerReturn into 2 loops..
In D72665#1839600, @rnk wrote:

From the commit message, this sounds like it is fixing a bug. Can it be tested? Did you have a test already, or did you forget to add it?

Otherwise, code looks good.

Fri, Jan 24, 1:50 PM · Restricted Project
yamauchi created D73381: [PGO][PGSO] Handle MBFIWrapper.
Fri, Jan 24, 1:50 PM · Restricted Project
craig.topper updated the summary of D72665: [X86] Break the loop in LowerReturn into 2 loops..
Fri, Jan 24, 1:50 PM · Restricted Project
nikic updated the diff for D73288: [InstCombine] Move negation handling into freelyNegateValue().

Also move the ashr/lshr and trunc patterns into freelyNegateValue() and keep existing handling regarding one-use checks.

Fri, Jan 24, 1:50 PM · Restricted Project