Page MenuHomePhabricator

Today

Harbormaster failed remote builds in B52393: Diff 256082 for D77749: [PowerPC][Future] Remove redundant r2 save and restore for indirect call !
Wed, Apr 8, 12:31 PM · Restricted Project, Restricted Project
Harbormaster failed remote builds in B52392: Diff 256085 for D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096!
Wed, Apr 8, 12:31 PM · Restricted Project
vsk committed rG0605f5fbe755: unittest: Disable MachineInstrClone.CopyCallSiteInfo entirely (authored by vsk).
unittest: Disable MachineInstrClone.CopyCallSiteInfo entirely
Wed, Apr 8, 12:31 PM
MaskRay committed rG969b91af732d: [Driver] Default arm-linux-androideabi to -z max-page-size=4096 (authored by MaskRay).
[Driver] Default arm-linux-androideabi to -z max-page-size=4096
Wed, Apr 8, 12:31 PM
ldionne committed rG82bec931814d: [libc++] Update the documentation for running Lit to reflect reality (authored by ldionne).
[libc++] Update the documentation for running Lit to reflect reality
Wed, Apr 8, 12:31 PM
vsk committed rG381bdd546cae: unittest: Disable MachineInstrClone.CopyCallSiteInfo on Windows (authored by vsk).
unittest: Disable MachineInstrClone.CopyCallSiteInfo on Windows
Wed, Apr 8, 12:30 PM
MaskRay closed D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096.
Wed, Apr 8, 12:30 PM · Restricted Project
ldionne closed D77673: [libc++] Update the documentation for running Lit to reflect reality.
Wed, Apr 8, 12:30 PM · Restricted Project
NeHuang created D77749: [PowerPC][Future] Remove redundant r2 save and restore for indirect call .
Wed, Apr 8, 12:30 PM · Restricted Project, Restricted Project
jdenny added a comment to D77741: [FileCheck] Better diagnostic for format conflict.

I like the idea of the change, but there are some parts I don't understand yet. I've added inline comments.

Wed, Apr 8, 12:30 PM · Restricted Project
delcypher added inline comments to D77696: [Darwin] Teach `AtosSymbolizerProcess` to work on a copy of the environment..
Wed, Apr 8, 12:30 PM · Restricted Project
vsk accepted D77747: Add pass to strip debug info from MIR.

Lgtm, thanks!

Wed, Apr 8, 12:30 PM · Restricted Project
jasonliu added inline comments to D77424: [XCOFF][AIX] Relocation support for SymB.
Wed, Apr 8, 12:30 PM · Restricted Project
alexbdv added inline comments to D74813: [RFC] Add hash of block contents to function block names.
Wed, Apr 8, 12:30 PM · Restricted Project
yaxunl added a comment to D77743: [HIP] Emit symbols with kernel name in host binary.
In D77743#1970035, @tra wrote:

Would not this scheme create a conflict between the device-side mangled kernel name and the handle which we emit with the same name? I recall that the distinct stub name was introduced specifically to avoid confusion between device-side kernel and the host-side stub that were visible at the same time (to debugger only?). Now we seen to re-introduce the same name only for the host-side handle instead of the host-side stub.

Wed, Apr 8, 12:30 PM
vsk added a comment to D77685: MachineFunction: Copy call site info when duplicating insts.

Somehow, details about the host architecture are creeping into the bogus target set up in MFCommon.inc. I've deleted the unit test to unblock the bots, until I can figure this out.

Wed, Apr 8, 12:30 PM · Restricted Project
nicolasvasilache accepted D77710: [MLIR] ShapedType accessor minor fixes + add isDynamicDim accessor.
Wed, Apr 8, 12:30 PM · Restricted Project
vsk added a comment to D77685: MachineFunction: Copy call site info when duplicating insts.

I disabled the unit test on Windows in 381bdd54.

Wed, Apr 8, 12:30 PM · Restricted Project
nicolasvasilache added a comment to D77710: [MLIR] ShapedType accessor minor fixes + add isDynamicDim accessor.

Can we initialize it to kDynamicSize instead of hardcoded -1?

Wed, Apr 8, 12:30 PM · Restricted Project
jasonliu updated the diff for D77580: [llvm-objdump] Fix incomplete relocation output for -D -r mode .

Added test case for Macho. Adjusted comments as suggested.

Wed, Apr 8, 12:30 PM · Restricted Project
vsk added a comment to D77685: MachineFunction: Copy call site info when duplicating insts.

I see 'unknown file: error: SEH exception with code 0x3221225477 thrown in the test body', but don't know what causes this. It looks like this has come up before (https://reviews.llvm.org/rL329195, and http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180910/587425.html). I'll try testing locally with UBSan to see if that uncovers anything. If not I'll disable the test.

Wed, Apr 8, 12:30 PM · Restricted Project
ldionne accepted D77673: [libc++] Update the documentation for running Lit to reflect reality.
Wed, Apr 8, 12:30 PM · Restricted Project
MaskRay updated the diff for D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096.

Clarify a comment

Wed, Apr 8, 12:30 PM · Restricted Project
nicolasvasilache added a comment to D73656: [mlir][Linalg] Add a Linalg DRR test to go from matmul to vectors.

@mehdi_amini had forgotten to update the test, fixed.

Wed, Apr 8, 12:30 PM · Restricted Project
yaxunl accepted D59321: AMDGPU: Teach toolchain to link rocm device libs.

LGTM. Thanks!

Wed, Apr 8, 12:30 PM
hubert.reinterpretcast added inline comments to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.
Wed, Apr 8, 12:30 PM · Restricted Project
smeenai added inline comments to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.
Wed, Apr 8, 12:30 PM · Restricted Project
smeenai added inline comments to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.
Wed, Apr 8, 12:30 PM · Restricted Project
smeenai added reviewers for D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4: phosek, beanz, compnerd, tstellar.

Adding more CMake people, but I'm all for this.

Wed, Apr 8, 12:30 PM · Restricted Project
smeenai added a comment to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.

I don't think there's any point in delaying until after the 11 release. We just branched LLVM 10. I believe we should make the change between now and the September LLVM 11 release, rather than afterwards.

I'd propose instead:

  1. Add a warning like this -- but saying the minimum will be upgraded SOON, not in 11.0.0.
  2. Keep the warning for a month -- meanwhile work on getting all buildbots upgraded
  3. Promote the warning to an error, make sure buildbots are still working. Potentially revert and re-apply later, if there are issues.
  4. Start cleaning up cruft for compat with old versions, yay!
Wed, Apr 8, 12:30 PM · Restricted Project
mwyman committed rG3d4d25fb4d60: First test commit - empty (authored by mwyman).
First test commit - empty
Wed, Apr 8, 11:57 AM
arsenm committed rGc42cc7fd2426: CodeGen: Use Register in MachineSSAUpdater (authored by arsenm).
CodeGen: Use Register in MachineSSAUpdater
Wed, Apr 8, 11:57 AM
Harbormaster failed remote builds in B52388: Diff 256071 for D77655: [VPlan] Add & use VPValue operands for VPWidenCallRecipe (NFC).!
Wed, Apr 8, 11:57 AM · Restricted Project
hoyFB updated the summary of D77748: [CodeGen] Allow partial tail duplication in Machine Block Placement..
Wed, Apr 8, 11:57 AM · Restricted Project
nicolasvasilache updated the diff for D73656: [mlir][Linalg] Add a Linalg DRR test to go from matmul to vectors.

Update the test to use the fused pass.

Wed, Apr 8, 11:57 AM · Restricted Project
thieta accepted D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096.

Thanks for handling this!

Wed, Apr 8, 11:57 AM · Restricted Project
ldionne added a comment to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.

I don't think there's any point in delaying until after the 11 release. We just branched LLVM 10. I believe we should make the change between now and the September LLVM 11 release, rather than afterwards.

Wed, Apr 8, 11:57 AM · Restricted Project
hoyFB created D77748: [CodeGen] Allow partial tail duplication in Machine Block Placement..
Wed, Apr 8, 11:57 AM · Restricted Project
bcain accepted D77684: [Hexagon] Remove testcases that check for default linker..

LGTM

Wed, Apr 8, 11:57 AM · Restricted Project
compnerd added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

Ok, let's go step by step to make sure we don't talk past each other. Here's some facts (feel free to correct me if you see a mistake):

  1. CMake builds shared libraries with POSITION_INDEPENDENT_CODE=ON by default.
  2. CMake builds static libraries with POSITION_INDEPENDENT_CODE=OFF by default.
  3. Setting CMAKE_POSITION_INDEPENDENT_CODE=ON on the command-line or in a cache will cause CMake to build both shared libraries and static libraries with POSITION_INDEPENDENT_CODE=ON.
Wed, Apr 8, 11:57 AM · Restricted Project, Restricted Project