Page MenuHomePhabricator

Recent Activity

Today

ubfx added a comment to D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Is the cast still needed now? I would think that getOperation() returns directly the interface now

Sat, Apr 1, 1:14 PM · Restricted Project, Restricted Project
ubfx updated the diff for D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Remove the cast because getOperation() already returns the Interface.

Sat, Apr 1, 1:14 PM · Restricted Project, Restricted Project
mgorny raised a concern with rG27c4777f41d2: [symbolizer] Treat invalid address as addr2line does.

This change (according to bisect) seems to cause compiler-rt tests to start hanging on Gentoo.

Sat, Apr 1, 1:00 PM · Restricted Project, Restricted Project
mehdi_amini accepted D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.

Is the cast still needed now? I would think that getOperation() returns directly the interface now

Sat, Apr 1, 12:58 PM · Restricted Project, Restricted Project
ubfx requested review of D147384: [mlir] [Linalg] Limit Detensorize pass to FunctionOpInterface.
Sat, Apr 1, 12:39 PM · Restricted Project, Restricted Project
RKSimon committed rGbf2ce6ba422b: [X86] combinePTESTCC - fold TESTC(X,~X) -> TESTC(X,-1) (authored by RKSimon).
[X86] combinePTESTCC - fold TESTC(X,~X) -> TESTC(X,-1)
Sat, Apr 1, 12:29 PM · Restricted Project, Restricted Project
RKSimon committed rGcf1bccf15c35: [X86] Add test showing failure to fold testc(X,~X) -> testc(X,-1) (authored by RKSimon).
[X86] Add test showing failure to fold testc(X,~X) -> testc(X,-1)
Sat, Apr 1, 12:29 PM · Restricted Project, Restricted Project
carlosgalvezp committed rG2469bd98a772: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous… (authored by carlosgalvezp).
[clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous…
Sat, Apr 1, 12:19 PM · Restricted Project, Restricted Project
carlosgalvezp closed D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces.
Sat, Apr 1, 12:19 PM · Restricted Project, Restricted Project
AMS21 requested review of D147383: [clang-tidy] Allow bugprone-unchecked-optional-access to handle calls to `std::forward`.
Sat, Apr 1, 12:14 PM · Restricted Project, Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.

All the new test cases are validated by Alive2.

Sat, Apr 1, 11:43 AM · Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.

Why is the test file called reverse-loop.ll when it doesn't involve loops?

Sat, Apr 1, 11:42 AM · Restricted Project, Restricted Project
liuz added inline comments to D147373: [InstCombine] fold double reverses.
Sat, Apr 1, 11:39 AM · Restricted Project, Restricted Project
liuz added a comment to D147373: [InstCombine] fold double reverses.

As this is not a cost-model driven transform, it should be part of InstCombine, not VectorCombine.

Sat, Apr 1, 11:32 AM · Restricted Project, Restricted Project
liuz updated the diff for D147373: [InstCombine] fold double reverses.

Updated the patch according to comments

Sat, Apr 1, 11:30 AM · Restricted Project, Restricted Project
alvinhochun requested review of D147382: [asan][test][win] Make report_after_syminitialize test less brittle.
Sat, Apr 1, 11:21 AM · Restricted Project, Restricted Project
arcbbb added inline comments to D146747: [RISCV] Model select and insertsubvector shuffle kinds.
Sat, Apr 1, 11:06 AM · Restricted Project, Restricted Project
nextsilicon-itay-bookstein added a comment to D140722: [OpenMP] Prefix outlined and reduction func names with original func's name.

I don't have non-cumbersome access to GPU targets at the moment.
I have run the following locally with the patch, and it seems to pass:

> ninja check-libomptarget
[0/1] Running libomptarget tests
Sat, Apr 1, 11:01 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.

Would it make sense to add a scoped enum to the test, to ensure it doesn't warn/fix?

Sat, Apr 1, 10:59 AM · Restricted Project, Restricted Project
gilsaia retitled D147381: [MLIR][presburger] normalize divisionrepr from feat:normalize divisionrepr to [MLIR][presburger] normalize divisionrepr.
Sat, Apr 1, 10:53 AM · Restricted Project, Restricted Project
PiotrZSL added a comment to D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.

Well, description update didn't update, you can update it here in UI, just edit revision, if you use "arc", there is a switch to apply description update.

Sat, Apr 1, 10:52 AM · Restricted Project, Restricted Project
PiotrZSL accepted D147379: [clang-tidy] Disable misc-definitions-in-headers for declarations in anonymous namespaces.

LGTM

Sat, Apr 1, 10:50 AM · Restricted Project, Restricted Project
RKSimon committed rGc692e92dc5d6: [X86] combineSetCCMOVMSK - fold PTEST(XOR(X,Y),XOR(X,Y)) instead of PTEST(SUB(X… (authored by RKSimon).
[X86] combineSetCCMOVMSK - fold PTEST(XOR(X,Y),XOR(X,Y)) instead of PTEST(SUB(X…
Sat, Apr 1, 10:46 AM · Restricted Project, Restricted Project
gilsaia requested review of D147381: [MLIR][presburger] normalize divisionrepr.
Sat, Apr 1, 10:46 AM · Restricted Project, Restricted Project
JDevlieghere added a comment to D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div.

The change looks good: it matches what the DWARFv5 standard says:

Sat, Apr 1, 10:28 AM · Restricted Project, Restricted Project
sstwcw committed rGfeb585e7d62c: [clang-format] Handle Verilog struct literals (authored by sstwcw).
[clang-format] Handle Verilog struct literals
Sat, Apr 1, 10:15 AM · Restricted Project, Restricted Project
sstwcw committed rG92b2be39656b: [clang-format] Handle enum in Verilog (authored by sstwcw).
[clang-format] Handle enum in Verilog
Sat, Apr 1, 10:15 AM · Restricted Project, Restricted Project
sstwcw closed D147329: [clang-format] Handle Verilog struct literals.
Sat, Apr 1, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw closed D147328: [clang-format] Handle enum in Verilog.
Sat, Apr 1, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun committed rG5888a47914f4: [asan][test] Fix tests or mark XFAIL for MinGW target (authored by alvinhochun).
[asan][test] Fix tests or mark XFAIL for MinGW target
Sat, Apr 1, 10:07 AM · Restricted Project, Restricted Project
alvinhochun committed rG985580d7c03c: [asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows (authored by alvinhochun).
[asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows
Sat, Apr 1, 10:07 AM · Restricted Project, Restricted Project
alvinhochun committed rGbae2fbaebf25: [compiler-rt][asan][test] Fix lit test config on MinGW (authored by alvinhochun).
[compiler-rt][asan][test] Fix lit test config on MinGW
Sat, Apr 1, 10:07 AM · Restricted Project, Restricted Project
alvinhochun closed D147059: [asan][test] Fix tests or mark XFAIL for MinGW target.
Sat, Apr 1, 10:07 AM · Restricted Project, Restricted Project
alvinhochun closed D147232: [asan][test] Fix `TestCases/alloca_*` ptr-to-long cast on Windows.
Sat, Apr 1, 10:06 AM · Restricted Project, Restricted Project
alvinhochun closed D147057: [compiler-rt][asan][test] Fix lit test config on MinGW.
Sat, Apr 1, 10:06 AM · Restricted Project, Restricted Project
sstwcw updated the diff for D147327: [clang-format] Add option for having one port per line in Verilog.
  • Use shorter conditions
Sat, Apr 1, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
aaronmondal updated the diff for D143320: [bazel] Rework zlib dependency.

Add strip_include_prefix to allow angled inclusion of zlib.h.

Sat, Apr 1, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
aaronmondal updated the diff for D143320: [bazel] Rework zlib dependency.

Switch to zip instead of tar.gz, as the latter seems to be broken.

Sat, Apr 1, 9:51 AM · Restricted Project, Restricted Project, Restricted Project
HerrCai0907 updated the diff for D147315: [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance.

update description

Sat, Apr 1, 9:48 AM · Restricted Project, Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected)..

Remove GCC XFAIL in transform/transform_error tests, because we have a workaround to avoid this issue.

Sat, Apr 1, 9:40 AM · Restricted Project, Restricted Project