Page MenuHomePhabricator

Recent Activity
View All

Today

junparser updated the diff for D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant..

update clang test.

Thu, Jun 24, 8:57 PM · Restricted Project, Restricted Project
ikudrin added a comment to D104701: [ARMInstPrinter] Print the target address of a branch instruction.

Ping. Note that the aforementioned issues are not required to be fixed for this patch. Moreover, I guess it will be more convenient if this patch is landed first.

Thu, Jun 24, 8:39 PM · Restricted Project
saghir added a comment to D103408: Teach peephole optimizer to not emit sub-register defs.
In D103408#2789491, @lebedev.ri wrote:

Does it trigger on any of the existing tests in Codegen/PowerPC/?

Thu, Jun 24, 8:04 PM · Restricted Project
Meinersbur added a comment to D104601: [Preprocessor] Implement -fnormalize-whitespace..

During a trial phase while compiling everything twice with ccache I got the following results.

Thu, Jun 24, 8:03 PM · Restricted Project
saghir added inline comments to D103408: Teach peephole optimizer to not emit sub-register defs.
Thu, Jun 24, 8:00 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix issues involving usage of uadd_ov and family of functions

Thu, Jun 24, 7:54 PM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Added test case description.

Thu, Jun 24, 7:51 PM · Restricted Project
saghir added inline comments to D103408: Teach peephole optimizer to not emit sub-register defs.
Thu, Jun 24, 7:51 PM · Restricted Project
JDevlieghere accepted D104893: Add data formatter support for a missing NSDictionary variant.

LGTM

Thu, Jun 24, 7:44 PM · Restricted Project
skan accepted D104861: [llvm-objdump] Print memory operand addresses as regular comments.
Thu, Jun 24, 7:42 PM · Restricted Project
ikudrin accepted D104894: [ELF] --sysroot: change sysrooted script to not fall back for an absolute path.

LGTM

Thu, Jun 24, 7:41 PM · Restricted Project
stefanp updated the summary of D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel..
Thu, Jun 24, 7:39 PM · Restricted Project
stefanp retitled D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel. from [Clang] Add option for vector compare compatibility. to [Clang] Add option to handle behaviour of vector bool/vector pixel..
Thu, Jun 24, 7:39 PM · Restricted Project
stefanp updated the diff for D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel..

Updated the name of the option to cover all of the inconsistencies for vector
pixel/bool. Future patches will continue to use this option to define the
behaviour of these two types.

Thu, Jun 24, 7:36 PM · Restricted Project
MaskRay requested changes to D103212: [WIP] Changing CG Profile to relocations based..

This can be abandoned now.

Thu, Jun 24, 7:33 PM · Restricted Project
mizvekov added a comment to D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes.

First part of the split implemented at: https://reviews.llvm.org/D104892
I will reuse this DR for the second part.

Thu, Jun 24, 7:32 PM · Restricted Project, Restricted Project
MaskRay retitled D104894: [ELF] --sysroot: change sysrooted script to not fall back for an absolute path from [ELF] --sysroot: change sysrooted file to not find an outside-sysroot file to [ELF] --sysroot: change sysrooted script to not fall back for an absolute path.
Thu, Jun 24, 7:31 PM · Restricted Project
MaskRay requested review of D104894: [ELF] --sysroot: change sysrooted script to not fall back for an absolute path.
Thu, Jun 24, 7:27 PM · Restricted Project
saghir updated the diff for D103408: Teach peephole optimizer to not emit sub-register defs.

Simplified test case and removed the code that introduces subreg def.

Thu, Jun 24, 7:26 PM · Restricted Project
aeubanks added a comment to D103992: [InstCombine / BuildLibCalls] Add parameter attributes from the prototype..

This is somehow adding the returned attribute to a memcpy intrinsic on mac: https://crbug.com/1223647.
I'll dig deeper tomorrow into what's going wrong

Thu, Jun 24, 7:26 PM · Restricted Project
aeubanks added a reverting change for rG1eda5453f2dc: [BuildLibCalls/SimplifyLibCalls] Fix attributes on created CallInst…: rG1aa02b37e7dc: Revert "[BuildLibCalls/SimplifyLibCalls] Fix attributes on created CallInst….
Thu, Jun 24, 7:25 PM
aeubanks committed rG1aa02b37e7dc: Revert "[BuildLibCalls/SimplifyLibCalls] Fix attributes on created CallInst… (authored by aeubanks).
Revert "[BuildLibCalls/SimplifyLibCalls] Fix attributes on created CallInst…
Thu, Jun 24, 7:25 PM
aeubanks added a reverting change for D103992: [InstCombine / BuildLibCalls] Add parameter attributes from the prototype.: rG1aa02b37e7dc: Revert "[BuildLibCalls/SimplifyLibCalls] Fix attributes on created CallInst….
Thu, Jun 24, 7:25 PM · Restricted Project
int3 committed rG8aa17d1eaeb4: [lld-macho] Move ICF members from InputSection to ConcatInputSection (authored by int3).
[lld-macho] Move ICF members from InputSection to ConcatInputSection
Thu, Jun 24, 7:23 PM
int3 closed D104670: [lld-macho] Move ICF members from InputSection to ConcatInputSection.
Thu, Jun 24, 7:23 PM · Restricted Project, Restricted Project
int3 added inline comments to D104671: [lld-macho] Extend ICF to literal sections.
Thu, Jun 24, 7:14 PM · Restricted Project, Restricted Project
jingham updated the diff for D104893: Add data formatter support for a missing NSDictionary variant.

Formatting

Thu, Jun 24, 7:09 PM · Restricted Project
jingham requested review of D104893: Add data formatter support for a missing NSDictionary variant.
Thu, Jun 24, 7:05 PM · Restricted Project
lkail committed rGb904574b3dbd: [PowerPC] Move PPCBranchSelector as close to asm printer as possible (authored by lkail).
[PowerPC] Move PPCBranchSelector as close to asm printer as possible
Thu, Jun 24, 7:05 PM
lkail closed D104762: [PowerPC] Move PPCBranchSelector as close to asm printer as possible.
Thu, Jun 24, 7:05 PM · Restricted Project
int3 updated the diff for D104670: [lld-macho] Move ICF members from InputSection to ConcatInputSection.

address comments

Thu, Jun 24, 7:02 PM · Restricted Project, Restricted Project
shchenz added inline comments to D104855: [PowerPC] Change VSRpRC allocation order.
Thu, Jun 24, 7:02 PM · Restricted Project
ikudrin added inline comments to D104699: [llvm-objdump] Print comments for the disassembled code.
Thu, Jun 24, 7:00 PM · Restricted Project
mizvekov updated the summary of D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons.
Thu, Jun 24, 6:58 PM · Restricted Project, Restricted Project
mizvekov added a reviewer for D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons: rsmith.
Thu, Jun 24, 6:54 PM · Restricted Project, Restricted Project
mizvekov requested review of D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons.
Thu, Jun 24, 6:53 PM · Restricted Project, Restricted Project
MaskRay accepted D104699: [llvm-objdump] Print comments for the disassembled code.

Looks great!

Thu, Jun 24, 6:51 PM · Restricted Project
ikudrin updated the diff for D104699: [llvm-objdump] Print comments for the disassembled code.
  • Updated tests
Thu, Jun 24, 6:37 PM · Restricted Project
ikudrin added inline comments to D104699: [llvm-objdump] Print comments for the disassembled code.
Thu, Jun 24, 6:36 PM · Restricted Project
jsji committed rGf3ef4f5bff26: [PowerPC] Add XL compat __compare_and_swap builtins (authored by jsji).
[PowerPC] Add XL compat __compare_and_swap builtins
Thu, Jun 24, 6:32 PM