Page MenuHomePhabricator

Recent Activity

Today

rikigigi updated the diff for D88279: SAVE statement should not apply to nested scoping units.
Fri, Sep 25, 12:34 AM · Restricted Project, Restricted Project
nikic requested changes to D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.
Fri, Sep 25, 12:30 AM · Restricted Project
rikigigi updated the diff for D88279: SAVE statement should not apply to nested scoping units.
Fri, Sep 25, 12:25 AM · Restricted Project, Restricted Project
abialas committed rG396e7f454893: [mlir][SCFToGPU] LaunchOp propagate optional attributes (authored by abialas).
[mlir][SCFToGPU] LaunchOp propagate optional attributes
Fri, Sep 25, 12:22 AM
abialas closed D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Fri, Sep 25, 12:22 AM · Restricted Project
zixuan-wu updated the diff for D86269: [RFC][Target] Add a new backend target called CSKY.

Address comments.

Fri, Sep 25, 12:22 AM · Restricted Project
rikigigi requested review of D88279: SAVE statement should not apply to nested scoping units.
Fri, Sep 25, 12:21 AM · Restricted Project, Restricted Project
aqjune accepted D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.

LGTM

Fri, Sep 25, 12:09 AM · Restricted Project
mstorsjo added a comment to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..

LGTM overall, one change that seems superfluous though.

Fri, Sep 25, 12:05 AM · Restricted Project

Yesterday

david-arm added inline comments to D88098: [SVE] Add new isKnownXX comparison functions to TypeSize.
Thu, Sep 24, 11:58 PM · Restricted Project
quic_aankit updated the diff for D88138: [NPM] Add target specific hook to add passes for New Pass Manager.
Thu, Sep 24, 11:49 PM · Restricted Project
baloghadamsoftware added a comment to D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.

Oh, I think now what do you mean: iterators stored in containers, thus iterators iterating over iterators. Yes, the current working of the checker does not support it because it stores iterator positions for both the prvalues and the glvalues. This is so from the beginning and this patch does not change anything about this behavior. Of course, this design concept is questionable, we can change it in the future. But not in this patch, this one is purely an NFC: it has exactly the same functionality as the previous versions, the only difference is that it does not hamper anymore with LazyCompoundVals but reaches the real region of the objects (and only in case of objects by value, I check the AST type for paramters), exactly as you requested.

Thu, Sep 24, 11:43 PM · Restricted Project
quic_aankit added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

I think I'm still missing how exactly this will fit into the pipeline. As in where is registerPassBuilderCallbacks() going to be called?

And a test like llvm/test/CodeGen/AMDGPU/opt-pipeline.ll for the new pass manager route would be nice to make sure this actually works.
something like RUN: opt -passes='default<O0>' -mtriple=... -disable-output -disable-verify -debug-pass-manager. Maybe checking all the normal passes isn't necessary like in the existing opt-pipeline.ll isn't necessary, just need to check that the custom passes (e.g. HexagonVectorLoopCarriedReusePass) are actually added.

Thu, Sep 24, 11:42 PM · Restricted Project
MaskRay updated the diff for D87737: Add -fprofile-update={atomic,prefer-atomic,single}.

Thanks for review! I will wait until next week.

Thu, Sep 24, 11:33 PM · Restricted Project
aeubanks added inline comments to D86988: [Inliner] Run always-inliner in inliner-wrapper.
Thu, Sep 24, 11:31 PM · Restricted Project
baloghadamsoftware retitled D77229: [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling from [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling to [Analyzer][NFC] Avoid handling of LazyCompundVals in IteratorModeling.
Thu, Sep 24, 11:29 PM · Restricted Project
davidxl accepted D87737: Add -fprofile-update={atomic,prefer-atomic,single}.

Looks good. Makes the tsan and instrumentation interaction also cleaner.

Thu, Sep 24, 11:28 PM · Restricted Project
davidxl added inline comments to D86988: [Inliner] Run always-inliner in inliner-wrapper.
Thu, Sep 24, 11:19 PM · Restricted Project
MaskRay updated the diff for D87272: [lld] Buffer writes when composing a single diagnostic.

Fix lock

Thu, Sep 24, 11:18 PM · Restricted Project
lebedev.ri added a comment to D88178: [ConstantRange] Make binaryNot() more precise.

Guess i'll just have to do it myself then.

I feel like I'm missing context here. Did I overlook review feedback somewhere?

Thu, Sep 24, 11:18 PM · Restricted Project
venkataramanan.kumar.llvm added a reviewer for D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).: rengolin.
Thu, Sep 24, 11:17 PM · Restricted Project, Restricted Project
gkm added a comment to D88054: [lld-macho] handle options -search_paths_first, -search_dylibs_first.

All devs do incremental builds. Of course incremental builds should work.

I went ahead and fixed this in https://github.com/llvm/llvm-project/commit/0389eff4047a74bb1ba6c0603c9002b5c73b203e

Going forward, please don't leave stuff broken overnight.

Thu, Sep 24, 11:08 PM · Restricted Project
steven.zhang added inline comments to D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Thu, Sep 24, 11:06 PM · Restricted Project, Restricted Project
gkm accepted D87199: [lld-macho] Implement support for PIC.

Feel free to land when you have the -pie + compact unwind testcase.

Thu, Sep 24, 11:04 PM · Restricted Project
sepavloff added inline comments to D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Thu, Sep 24, 10:42 PM · Restricted Project
Esme added a reviewer for D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp).: Restricted Project.
Thu, Sep 24, 10:42 PM · Restricted Project, Restricted Project
Esme requested review of D88278: [PowerPC] Add builtins for xvtdiv(dp|sp) and xvtsqrt(dp|sp)..
Thu, Sep 24, 10:41 PM · Restricted Project, Restricted Project
sepavloff updated the diff for D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.

Added diagnostic message

Thu, Sep 24, 10:41 PM · Restricted Project
mkazantsev planned changes to D88208: [SCEV] Prove implicaitons via AddRec start.
Thu, Sep 24, 10:33 PM · Restricted Project
aeubanks added a comment to D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

I think I'm still missing how exactly this will fit into the pipeline. As in where is registerPassBuilderCallbacks() going to be called?

Thu, Sep 24, 10:33 PM · Restricted Project
plotfi updated the diff for D88180: [RFC] HashTree and MachineOutliner HashTree Serialization for cross module data sharing. .

comments added

Thu, Sep 24, 10:28 PM · Restricted Project
quic_aankit updated the diff for D88138: [NPM] Add target specific hook to add passes for New Pass Manager.

Add HexagonVectorLoopCarriedReusePass using registerPassBuilderCallbacks

Thu, Sep 24, 10:18 PM · Restricted Project
plotfi updated the diff for D88180: [RFC] HashTree and MachineOutliner HashTree Serialization for cross module data sharing. .

clang-tidy

Thu, Sep 24, 10:15 PM · Restricted Project
achieveartificialintelligence added a comment to D88141: Update Kaleidoscope tutorial and remove useless header.

I don't have commit access. What should I do?

Thu, Sep 24, 10:08 PM · Restricted Project
asteinhauser committed rGef36e8380a91: [libc] Using llvm_libc memcpy in mem* benchmarks. (authored by asteinhauser).
[libc] Using llvm_libc memcpy in mem* benchmarks.
Thu, Sep 24, 10:04 PM
asteinhauser closed D88271: [libc] Using llvm_libc memcpy in mem* benchmarks..
Thu, Sep 24, 10:04 PM · Restricted Project
lxfind added a comment to D87817: [LICM][Coroutine] Don't sink stores to coroutine suspend point..

We try to find an general solution to handle some conservative & mismatch analysis in transformations caused by the change of cfg with coro.suspend intrinsic. However afaik, it seems quiet difficult to deal this without change framework fo coroutine.
This patch just fixes the known issue, it may happens in other passes, FYI.

one of the idea is that we do not generate default case for switch instruction of coro.suspend intrinsic. Instead, we find fall through coro.end for coro.suspend directly in corosplit pass. The only uncertain thing is whether fall through coro.end is moved by passes which may change the semantic.

@lxfind, what do you think about this idea?

Are you suggesting to not have an edge from the coro.suspend switch to the coro.end block? Would that make the coro.end BB a dead BB and could potentially get removed?

No, There is always path from entry to coro.end BB.

This is likely the right solution, but we do need to make it more general. In order for this to always work, I wonder if the proper place to insert this transformation is in LoopSimplify, which is a pass always executed before any Loop pass. That might guarantee that any loop pass will be able to handle this properly. I am not too familiar with loop passes, but maybe someone else could comment on that.

Loop exit-block insertion in LoopSimplify pass guarantees that all exit blocks from the loop only have predecessors from inside of the loop. It will break the dedicated form of exit blocks when we consider ignore coro.suspend path. Maybe there is other idea i haven't thought about.

Thu, Sep 24, 10:02 PM · Restricted Project
ychen added a comment to D88062: [ARM] add .f16 -> .16 token alias.

This patch caused some failures (fullfp16-neg.s etc.) and seems changed the behavior of parsing "vmov.f16 s1,r2" for -fp16 from fail to pass. With this patch and -fp16, "vmov.f16 s1,r2" would be parsed to "vmov.16 s1,r2" which is defined to alias "vmov s1,r2".

Thu, Sep 24, 9:48 PM · Restricted Project
andreil99 requested review of D88277: Add openmp docs to SphinxDocsBuilder..
Thu, Sep 24, 9:31 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D88251: [MLIR] Move TestDialect to ::test namespace.
Thu, Sep 24, 9:24 PM · Restricted Project