Page MenuHomePhabricator

Today

samtebbs committed rGf312c1ecf4bc: [ARM] Add support for MVE vaddv (authored by samtebbs).
[ARM] Add support for MVE vaddv
Mon, Aug 19, 2:39 AM
samtebbs committed rL369245: [ARM] Add support for MVE vaddv.
[ARM] Add support for MVE vaddv
Mon, Aug 19, 2:39 AM
samtebbs closed D66085: [ARM] Add support for MVE vaddv.
Mon, Aug 19, 2:39 AM · Restricted Project
ruiu added a comment to D66274: [ELF][Hexagon] Replace R_HEXAGON_GOT with R_GOTPLT.

Nice! Thank you for doing this.

The remaining bits of RelExpr are a scarce recourse now... R_RISCV_PC_INDIRECT == 61. @sidneym Do you need more than 3 bits?

It shouldn't be too hard to extend oneOf so that the function uses two words instead of one word as a bitmap, but yeah, we should first try to reduce the number of relocation types if possible.

I had to do this for the CHERI fork of LLD since we added a few new entries. We currently always use a 128-bit mask (https://github.com/CTSRD-CHERI/llvm-project/blob/master/lld/ELF/Relocations.cpp#L139) but I guess we could reorder the enum to have a fast path for commonly checked values and do the second compare only for less common entries. I can submit a patch if you would like to use the 128-bit variant.

Mon, Aug 19, 2:39 AM · Restricted Project
MaskRay added a comment to rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".

Actually it is not fixed. Bug is related to "-O2" linker optimizations. More precisely to stringpool optimization of merge-able sections. I've located bug in the linker but I didn't have time to get into the details. Here you can find binaries https://sourceware.org/bugzilla/show_bug.cgi?id=16794.

Mon, Aug 19, 2:33 AM
jhenderson added inline comments to D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Mon, Aug 19, 2:31 AM · Restricted Project
peterwaller-arm added a comment to D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Updated for code review comment.

Mon, Aug 19, 2:31 AM · Restricted Project
peterwaller-arm updated the diff for D66077: [GlobalISel] Handle multiple registers in dbg.value intrinsic.

Add target triple to test.

Mon, Aug 19, 2:30 AM · Restricted Project
jvikstrom added a comment to D64741: [clangd] Added highlighting for tokens that are macro arguments..

@ilya-biryukov @hokein ping

Mon, Aug 19, 2:29 AM · Restricted Project
sdesmalen added a comment to D66339: [SVE] Fixed-length vector MVT ranges.

I like your suggestion of using concat_iterator(_range), but I think grouping all fixed-width types together is sufficient for now. If there is ever a good reason to iterate through (all combined scalable and fixed-width fp vector types)or (all combined scalable and fixed-width integer vector types), we can always introduce the extra concat_iterators then.

I'm not sure what you're suggesting here. Are you asking Graham to keep all the fixed-width types contiguous (i.e. int and fp)? This patch does not do that. I don't have a strong preference either way. Given that the existing state is non-contiguous I see no compelling reason to change it.

Mon, Aug 19, 2:29 AM · Restricted Project
jhenderson added a comment to D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.

Thanks for doing this. This was something on my radar too as an odd inconsistency.

Mon, Aug 19, 2:21 AM · Restricted Project
arichardson added a comment to D66274: [ELF][Hexagon] Replace R_HEXAGON_GOT with R_GOTPLT.

Nice! Thank you for doing this.

The remaining bits of RelExpr are a scarce recourse now... R_RISCV_PC_INDIRECT == 61. @sidneym Do you need more than 3 bits?

It shouldn't be too hard to extend oneOf so that the function uses two words instead of one word as a bitmap, but yeah, we should first try to reduce the number of relocation types if possible.

Mon, Aug 19, 2:17 AM · Restricted Project
svenvh accepted D66137: [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays.

LGTM, but please clang-format your patch before committing (esp. spacing around binary operators).

Mon, Aug 19, 2:17 AM
dmgreen committed rG2bfc13fde129: [ARM] MVE sext costs (authored by dmgreen).
[ARM] MVE sext costs
Mon, Aug 19, 2:15 AM
dmgreen committed rL369244: [ARM] MVE sext costs.
[ARM] MVE sext costs
Mon, Aug 19, 2:12 AM
dmgreen closed D66010: [ARM] MVE sext costs.
Mon, Aug 19, 2:12 AM · Restricted Project
NikolaPrica added a comment to rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".

Actually it is not fixed. Bug is related to "-O2" linker optimizations. More precisely to stringpool optimization of merge-able sections. I've located bug in the linker but I didn't have time to get into the details. Here you can find binaries https://sourceware.org/bugzilla/show_bug.cgi?id=16794.

Mon, Aug 19, 2:12 AM
jmorse committed rGb58ba8aae710: [DebugInfo] Test for variable range un-coalescing (authored by jmorse).
[DebugInfo] Test for variable range un-coalescing
Mon, Aug 19, 2:07 AM
jmorse committed rL369243: [DebugInfo] Test for variable range un-coalescing.
[DebugInfo] Test for variable range un-coalescing
Mon, Aug 19, 2:06 AM
jmorse closed D66347: [DebugInfo] Test that LiveDebugVariables un-coalesces ranges over block boundaries.
Mon, Aug 19, 2:06 AM · Restricted Project
ebevhan added inline comments to D66334: [LoopUnroll] Handle certain PHIs in full unrolling properly..
Mon, Aug 19, 2:06 AM · Restricted Project
jhenderson added inline comments to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Mon, Aug 19, 2:06 AM · Restricted Project
seiya added a parent revision for D66409: [llvm-objcopy][MachO] Implement -Obinary: D66408: [llvm-objcopy][MachO] Implement --dump-section.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66407: [llvm-objcopy][MachO] Implement -Ibinary: D66408: [llvm-objcopy][MachO] Implement --dump-section.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66408: [llvm-objcopy][MachO] Implement --dump-section: D66409: [llvm-objcopy][MachO] Implement -Obinary.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a parent revision for D66408: [llvm-objcopy][MachO] Implement --dump-section: D66407: [llvm-objcopy][MachO] Implement -Ibinary.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66283: [llvm-objcopy][MachO] Implement --add-section: D66407: [llvm-objcopy][MachO] Implement -Ibinary.
Mon, Aug 19, 1:57 AM · Restricted Project
seiya added a parent revision for D66407: [llvm-objcopy][MachO] Implement -Ibinary: D66283: [llvm-objcopy][MachO] Implement --add-section.
Mon, Aug 19, 1:57 AM · Restricted Project
jhenderson accepted D66291: [test/Object] - Move/rewrite 2 more test cases..

LGTM.

Mon, Aug 19, 1:57 AM
Herald added a reviewer for D66409: [llvm-objcopy][MachO] Implement -Obinary: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
Herald added a reviewer for D66408: [llvm-objcopy][MachO] Implement --dump-section: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
jhenderson added a comment to D66063: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 5].

I'm concerned with the getHeader() call changes in ELFObjectFile, mostly because again it's introducing a very obvious point of failure. What if somebody added a new piece of functionality to the base class to get another piece of data from the header? There's a good change they'll call EF.getHeader(). Say the new function is called getFoo(): if another user then decides they want to call getFoo() on a MutableELFObject, then they'll end up using the unmodified header rather than the modified one, which could cause surprising bugs. I don't have an obvious answer to this, but I'm beginning to wonder if we should be using a different style of inheritance, one that only makes the functions available that we know to be safe from a MutableELFObject's point of view. This might be something like private inheritance. I'm not sure though, as it would mean providing shim functions to re-publicise the "safe" functions we care about. What are your thoughts?

Mon, Aug 19, 1:57 AM · Restricted Project
jhenderson accepted D66062: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 4].

LGTM, though @rupprecht should confirm too.

Mon, Aug 19, 1:57 AM · Restricted Project
Herald added a reviewer for D66407: [llvm-objcopy][MachO] Implement -Ibinary: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
hokein added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Mon, Aug 19, 1:48 AM · Restricted Project
seiya added inline comments to D66281: [llvm-objcopy][MachO] Implement --strip-all.
Mon, Aug 19, 1:47 AM · Restricted Project
seiya updated the diff for D66281: [llvm-objcopy][MachO] Implement --strip-all.

Addressed review comments.

Mon, Aug 19, 1:47 AM · Restricted Project
ilya-biryukov added inline comments to D66349: [clangd] Fix one testcase in XRefsTests..
Mon, Aug 19, 1:44 AM · Restricted Project
ruiu added a comment to D66306: Fix lld on GCC 5.1 after the C++14 move.

LGTM

Mon, Aug 19, 1:44 AM · Restricted Project
dmgreen added inline comments to D66297: [ARM] Select vmla.
Mon, Aug 19, 1:37 AM · Restricted Project