Page MenuHomePhabricator

Today

hokein accepted D69266: [clangd] Define out-of-line availability checks.
Wed, Oct 23, 5:30 AM · Restricted Project
kadircet updated the diff for D69328: [clangd] Propogate context in TUScheduler::run.
  • Address comments
Wed, Oct 23, 5:30 AM · Restricted Project
vhscampos added inline comments to D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE.
Wed, Oct 23, 5:30 AM · Restricted Project, Restricted Project
hokein added inline comments to D69298: [clangd] Define out-of-line initial apply logic.
Wed, Oct 23, 5:28 AM · Restricted Project
lebedev.ri added inline comments to D69336: [Support] Make BitVector::BitWord size_t.
Wed, Oct 23, 5:28 AM · Restricted Project
ekatz created D69337: [PhiValues] Remove redundant searches in DenseMap.
Wed, Oct 23, 5:28 AM · Restricted Project
ekatz created D69336: [Support] Make BitVector::BitWord size_t.
Wed, Oct 23, 5:19 AM · Restricted Project
ekatz created D69335: [Support] Replace StringRef hashing algorithm with DJB.
Wed, Oct 23, 5:03 AM · Restricted Project
ekatz created D69334: [MathExtras] Add intrinsic for the PopulationCounter in Visual Studio.
Wed, Oct 23, 4:51 AM · Restricted Project
steven.zhang added inline comments to D62993: [PowerPC] Emit scalar min/max instructions with unsafe fp math.
Wed, Oct 23, 4:51 AM · Restricted Project
Petar.Avramovic created D69333: [MIPS GlobalISel] MSA vector generic and builtin sdiv, srem, udiv, urem.
Wed, Oct 23, 4:51 AM · Restricted Project
ekatz added a reviewer for D69332: Implement the Waymarking as an independent utility: chandlerc.
Wed, Oct 23, 4:41 AM · Restricted Project
ekatz created D69332: Implement the Waymarking as an independent utility.
Wed, Oct 23, 4:41 AM · Restricted Project
dmgreen accepted D67161: [clang,ARM] Initial ACLE intrinsics for MVE..

I've read this through again and it looks good. If no one else has any issues, then LGTM.

Wed, Oct 23, 4:41 AM · Restricted Project
ilya-biryukov added inline comments to D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl().
Wed, Oct 23, 4:32 AM · Restricted Project
djtodoro added inline comments to D68209: [LiveDebugValues] Introduce entry values of unmodified params.
Wed, Oct 23, 4:13 AM · Restricted Project, debug-info
djtodoro added a comment to D68209: [LiveDebugValues] Introduce entry values of unmodified params.

@jmorse Thanks for the comments!

Wed, Oct 23, 4:13 AM · Restricted Project, debug-info
sammccall committed rG40668abca4d3: [Support] Add a way to run a function on a detached thread (authored by sammccall).
[Support] Add a way to run a function on a detached thread
Wed, Oct 23, 3:54 AM
sammccall closed D51103: [Support] Add a way to run a function on a detached thread.
Wed, Oct 23, 3:54 AM · Restricted Project
Harbormaster failed remote builds in B39939: Diff 226106 for D65591: [AST] Add a flag indicating if any subexpression had errors!
Wed, Oct 23, 3:31 AM · Restricted Project
merge_guards_bot added a comment to D65591: [AST] Add a flag indicating if any subexpression had errors.

Build result: fail - 59344 tests passed, 2 failed and 812 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test
failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

Wed, Oct 23, 3:31 AM · Restricted Project
mbrkusanin committed rG4b63ca1379a8: [Mips] Use appropriate private label prefix based on Mips ABI (authored by mbrkusanin).
[Mips] Use appropriate private label prefix based on Mips ABI
Wed, Oct 23, 3:26 AM
mbrkusanin closed D66795: [Mips] Use appropriate private label prefix based on Mips ABI.
Wed, Oct 23, 3:26 AM · Restricted Project, Restricted Project, Restricted Project
Harbormaster failed remote builds in B39937: Diff 226104 for D69328: [clangd] Propogate context in TUScheduler::run!
Wed, Oct 23, 3:26 AM · Restricted Project
merge_guards_bot added a comment to D69328: [clangd] Propogate context in TUScheduler::run.

Build result: fail - 59544 tests passed, 1 failed and 805 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

Wed, Oct 23, 3:26 AM · Restricted Project
sammccall added a comment to D69328: [clangd] Propogate context in TUScheduler::run.

Oops, this doesn't actually work - you're not setting the cloned context anywhere...

I am moving it into the lambda, which should extend the lifespan of context until destruction of it. Why would I need to set it in addition to that?

Wed, Oct 23, 3:22 AM · Restricted Project
dmgreen updated the diff for D69252: [InstCombine] Canonicalize sadd.with.overflow to sadd.sat.

Just a rebase.

Wed, Oct 23, 3:17 AM · Restricted Project
dmgreen updated the diff for D69245: [InstCombine] Canonicalize uadd.with.overflow to uadd.sat.

Update to m_WithOverflowInst for now

Wed, Oct 23, 3:07 AM · Restricted Project
serge-sans-paille updated the diff for D68720: Support -fstack-clash-protection for x86.

Temporarily comment out call support as free probe, everything else passes validation but a call may have some stack effect I don't handle (yet).

Wed, Oct 23, 3:07 AM · Restricted Project, Restricted Project
dmgreen added inline comments to D69245: [InstCombine] Canonicalize uadd.with.overflow to uadd.sat.
Wed, Oct 23, 3:04 AM · Restricted Project
evgeny777 created D69331: [LegacyPM] Port CGProfile pass.
Wed, Oct 23, 3:04 AM
grimar added a comment to D69304: [llvm-objcopy] - Do not crash on object that has relocations but no symbol table..

An alternative approach is to generalize else if (EnsureSymtab) for non --add-symbol= operations as well.

Wed, Oct 23, 3:04 AM
dstenb committed rG74a72e684849: [DebugInfo] Stop describing imms in TargetInstrInfo's describeLoadedValue() impl (authored by dstenb).
[DebugInfo] Stop describing imms in TargetInstrInfo's describeLoadedValue() impl
Wed, Oct 23, 2:58 AM
dstenb closed D69109: [DebugInfo] Stop describing imms in TargetInstrInfo's describeLoadedValue() impl.
Wed, Oct 23, 2:58 AM · Restricted Project, debug-info
dmgreen planned changes to D68717: [Codegen] More add_sat and sub_sat promotion.

Yeah, sorry. I've also been adding selection from arm's qadd/qsub, but I think that will be OK to standard types. Let me try and update a few things and then rebase this to see how it still does. Like you said, unsigned might still look OK.

Wed, Oct 23, 2:58 AM · Restricted Project
Harbormaster failed remote builds in B39938: Diff 226105 for D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors!
Wed, Oct 23, 2:54 AM · Restricted Project
Harbormaster failed remote builds in B39936: Diff 226100 for D69329: [clangd] abort if shutdown takes more than a minute.!
Wed, Oct 23, 2:54 AM · Restricted Project
ilya-biryukov added inline comments to D69328: [clangd] Propogate context in TUScheduler::run.
Wed, Oct 23, 2:54 AM · Restricted Project
ilya-biryukov added a child revision for D65591: [AST] Add a flag indicating if any subexpression had errors: D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors.
Wed, Oct 23, 2:54 AM · Restricted Project
ilya-biryukov added a parent revision for D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors: D65591: [AST] Add a flag indicating if any subexpression had errors.
Wed, Oct 23, 2:54 AM · Restricted Project