Page MenuHomePhabricator

Today

aaron.ballman committed rG91f7265759cf: Dump the value calculated by a constant expression when dumping the AST to JSON. (authored by aaron.ballman).
Dump the value calculated by a constant expression when dumping the AST to JSON.
Wed, Jun 19, 12:12 PM
dmgreen created D63567: [ARM] Mve vector shuffles.
Wed, Jun 19, 12:12 PM · Restricted Project
llunak added a comment to D63508: make -frewrite-includes handle __has_include wrapped in a macro.

Perhaps we should rewrite all #if-like directives to #if 0 or #if 1?

Wed, Jun 19, 12:12 PM · Restricted Project
craig.topper added a comment to D59744: Fix i386 ABI "__m64" type bug.

-O0 always inline isn't working because the frontend is emitting a store of vector type to memory then a load of x86_mmx to do the type coercion. The caller does the opposite to coerce back from mmx. This -O0 pipeline isn't capable of getting rid of these redundant store/load pairs. We might have a better chance if we just emitted bitcasts.

Wed, Jun 19, 12:12 PM · Restricted Project, Restricted Project
pcc committed rG9f42845187cd: gn build: Merge r363757. (authored by pcc).
gn build: Merge r363757.
Wed, Jun 19, 12:09 PM
pcc committed rG7a84c5adcd44: gn build: Merge r363848. (authored by pcc).
gn build: Merge r363848.
Wed, Jun 19, 12:09 PM
pcc committed rGcf2406cd607a: gn build: Merge r363846. (authored by pcc).
gn build: Merge r363846.
Wed, Jun 19, 12:09 PM
aaronballman committed rL363866: Dump the value calculated by a constant expression when dumping the AST to JSON..
Dump the value calculated by a constant expression when dumping the AST to JSON.
Wed, Jun 19, 12:09 PM
pcc committed rGe99d33885e3e: gn build: Merge r363794. (authored by pcc).
gn build: Merge r363794.
Wed, Jun 19, 12:09 PM
pcc committed rGdd3df8ed34ed: gn build: Merge r363680. (authored by pcc).
gn build: Merge r363680.
Wed, Jun 19, 12:09 PM
pcc committed rGf91d8ba0bef3: gn build: Merge r363712. (authored by pcc).
gn build: Merge r363712.
Wed, Jun 19, 12:09 PM
pcc committed rL363865: gn build: Merge r363757..
gn build: Merge r363757.
Wed, Jun 19, 12:09 PM
pcc committed rL363864: gn build: Merge r363848..
gn build: Merge r363848.
Wed, Jun 19, 12:09 PM
pcc committed rL363863: gn build: Merge r363846..
gn build: Merge r363846.
Wed, Jun 19, 12:07 PM
pcc committed rL363862: gn build: Merge r363794..
gn build: Merge r363794.
Wed, Jun 19, 12:07 PM
pcc committed rL363861: gn build: Merge r363680..
gn build: Merge r363680.
Wed, Jun 19, 12:07 PM
pcc committed rL363860: gn build: Merge r363712..
gn build: Merge r363712.
Wed, Jun 19, 12:07 PM
aaron.ballman committed rG5f84ebe8dec2: Switching this test to use output generated by script; NFC. (authored by aaron.ballman).
Switching this test to use output generated by script; NFC.
Wed, Jun 19, 12:07 PM
tpr added a comment to D63510: [LiveInterval] Removed bogus empty subrange assert.

For this bug, whatever we do with a mir test, it is not going to be reliable in failing if the bug is present. Maybe there is a unit testing framework for LiveRangeCalc tests that I could add a test to.

Wed, Jun 19, 12:04 PM · Restricted Project
aaronballman committed rL363859: Switching this test to use output generated by script; NFC..
Switching this test to use output generated by script; NFC.
Wed, Jun 19, 12:04 PM
Carrot added a comment to D43256: [MBP] Move a latch block with conditional exit and multi predecessors to top of loop.

Do you have any benchmark numbers to show that this is generally profitable? From our downstream testing, it is not clear that this change is beneficial.

Wed, Jun 19, 12:03 PM · Restricted Project
bruno added a comment to D63518: WIP BitStream reader: propagate errors.

Hi JF. Thanks for working on this, nice improvement to error handling!

Wed, Jun 19, 12:01 PM · Restricted Project, Restricted Project
tpr added inline comments to D63510: [LiveInterval] Removed bogus empty subrange assert.
Wed, Jun 19, 12:01 PM · Restricted Project
xbolva00 added a comment to D63423: [Diagnostics] Diagnose misused xor as pow.

David Malcon - GCC: “I think we'd want to *not* warn if either of the operands are from a macro expansion.“

Wed, Jun 19, 11:58 AM · Restricted Project
arsenm added inline comments to D63510: [LiveInterval] Removed bogus empty subrange assert.
Wed, Jun 19, 11:57 AM · Restricted Project
ABataev added inline comments to D59474: [OpenMP 5.0] Codegen support for user-defined mappers.
Wed, Jun 19, 11:56 AM · Restricted Project, Restricted Project
rnk added a comment to D63361: Pretend NRVO variables are references so they can be found by debug info.

I see we don't have any tests for inalloca to model this on, so I think we should skip that for this change. I'll add one later that handles arguments as well, since those are interesting.

Wed, Jun 19, 11:56 AM · debug-info, Restricted Project, Restricted Project
davide added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

I see the point; certainly when someone emails a patch, the first response is almost always "can you put this on Phab."

There was talk at some point about connecting Phab with github authentication, somehow? If people can use an existing account then the you-need-to-register-first objection goes away.

Wed, Jun 19, 11:52 AM · Restricted Project
arsenm added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Wed, Jun 19, 11:52 AM · Restricted Project
arsenm added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Wed, Jun 19, 11:52 AM · Restricted Project
arsenm updated the diff for D63566: AMDGPU: Fix folding immediate into readfirstlane through reg_sequence .

std::next

Wed, Jun 19, 11:46 AM
ychen committed rGfee7365b078e: [llvm-objdump] Remove unnecessary indentation when dumping ELF data. (authored by ychen).
[llvm-objdump] Remove unnecessary indentation when dumping ELF data.
Wed, Jun 19, 11:42 AM
plotfi added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 11:41 AM · Restricted Project
yuanfang committed rL363858: [llvm-objdump] Remove unnecessary indentation when dumping ELF data..
[llvm-objdump] Remove unnecessary indentation when dumping ELF data.
Wed, Jun 19, 11:41 AM
Diffusion closed D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data..
Wed, Jun 19, 11:41 AM · Restricted Project
aaron.ballman accepted D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..

LGTM with a few nits.

Wed, Jun 19, 11:37 AM · Restricted Project
efriedma added a comment to D62653: [Mips][DSP] Fix physregs incorrectly marked as dead..

So we would need to mark every instruction that uses any part of DSPControl as having an post-isel hook and there are more than 100 instructions

Wed, Jun 19, 11:37 AM
Nathan-Huckleberry committed rG321f902a0122: [AST] Fixed extraneous warnings for binary conditional operator (authored by Nathan-Huckleberry).
[AST] Fixed extraneous warnings for binary conditional operator
Wed, Jun 19, 11:34 AM
Nathan-Huckleberry committed rL363857: [AST] Fixed extraneous warnings for binary conditional operator.
[AST] Fixed extraneous warnings for binary conditional operator
Wed, Jun 19, 11:34 AM
Nathan-Huckleberry closed D63369: [AST] Fixed extraneous warnings for binary conditional operator.
Wed, Jun 19, 11:34 AM · Restricted Project, Restricted Project