Address Jinsong's comments
- rL LLVM
- Sun, Sep 22, 1:08 PM
- Subversion
- rC Clang
- 79,314 Commits
- ·
- Restricted Project
- Restricted Project
- Sun, Sep 22, 10:33 AM
- Subversion
- rLLD LLVM Linker
- Sun, Sep 22, 9:26 AM
- Subversion
Today
Today
andreadb added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 1:36 PM · Restricted Project
Sun, Sep 22, 1:31 PM · Restricted Project
lebedev.ri updated the diff for D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 1:27 PM · Restricted Project
Sun, Sep 22, 1:22 PM · Restricted Project
lebedev.ri added a comment to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
In D67875#1678334, @craig.topper wrote:What if we just do the larger than 32-bit mask? Its not clear that making BZHI just to fold a load is an improvement. You have to materialize an immediate instead so the total uops increased.
Sun, Sep 22, 1:19 PM · Restricted Project
craig.topper committed rGc4802de31b1a: [X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm' (authored by craig.topper).
[X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'
ctopper committed rL372526: [X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'.
[X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'
craig.topper added a comment to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
What if we just do the larger than 32-bit mask? Its not clear that making BZHI just to fold a load is an improvement. You have to materialize an immediate instead so the total uops increased.
Sun, Sep 22, 1:07 PM · Restricted Project
lebedev.ri updated the diff for D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Scaling down ambigiousness of the patch: if not using BEXTR, only use BZHI if either the mask is larger than 32-bit, or the load folding will happen.
Sun, Sep 22, 12:54 PM · Restricted Project
craig.topper committed rG80fda375b225: [X86][TableGen] Allow timm to appear in output patterns. Use it to remove… (authored by craig.topper).
[X86][TableGen] Allow timm to appear in output patterns. Use it to remove…
This patch has now been run through update_llc_test_checks.
Sun, Sep 22, 12:48 PM · Restricted Project
ctopper committed rL372525: [X86][TableGen] Allow timm to appear in output patterns. Use it to remove….
[X86][TableGen] Allow timm to appear in output patterns. Use it to remove…
lebedev.ri committed rG24159592cac9: [NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875) (authored by lebedev.ri).
[NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875)
lebedevri committed rL372524: [NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875).
[NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875)
asmith added inline comments to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Sun, Sep 22, 12:37 PM · Restricted Project
Sun, Sep 22, 12:33 PM · Restricted Project
Add new options to objcopy documentation
Sun, Sep 22, 12:33 PM · Restricted Project
Sun, Sep 22, 12:24 PM · Restricted Project
Address reviewers comments about auto
Sun, Sep 22, 12:24 PM · Restricted Project
craig.topper added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 12:20 PM · Restricted Project
Sun, Sep 22, 12:19 PM · Restricted Project
Sun, Sep 22, 12:16 PM · Restricted Project
mstorsjo created D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general.
Sun, Sep 22, 12:14 PM · Restricted Project
craig.topper committed rGa1d86857fff2: [X86] Update commutable EVEX vcmp patterns to use timm instead of imm. (authored by craig.topper).
[X86] Update commutable EVEX vcmp patterns to use timm instead of imm.
Sun, Sep 22, 12:07 PM · Restricted Project
craig.topper committed rGac8477126178: [X86] Add more tests for commuting evex vcmp instructions during isel to fold a… (authored by craig.topper).
[X86] Add more tests for commuting evex vcmp instructions during isel to fold a…
[X86] Update commutable EVEX vcmp patterns to use timm instead of imm.
ctopper committed rL372522: [X86] Add more tests for commuting evex vcmp instructions during isel to fold a….
[X86] Add more tests for commuting evex vcmp instructions during isel to fold a…
I wrote a patch for the shared_ptr approach. It's simple, but it touches a lot of lines.
Sun, Sep 22, 12:05 PM · Restricted Project
davezarzycki added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 12:05 PM · Restricted Project
craig.topper updated subscribers of D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 11:51 AM · Restricted Project
RKSimon committed rGc8a9ae4ce2c7: [SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown… (authored by RKSimon).
[SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown…
RKSimon committed rG2c558bd84540: [XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning. (authored by RKSimon).
[XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning.
Sun, Sep 22, 11:47 AM · Restricted Project
RKSimon committed rL372521: [SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown….
[SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown…
RKSimon committed rL372520: [XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning..
[XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning.
@hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found.
Sun, Sep 22, 11:35 AM · Restricted Project
aaronballman committed rL372519: Request commit access for myself..
Request commit access for myself.
Sun, Sep 22, 11:26 AM · Restricted Project
lebedev.ri added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 11:17 AM · Restricted Project