Page MenuHomePhabricator

Today

andreadb added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 1:36 PM · Restricted Project
Yi-Hong.Lyu updated the diff for D66991: [PowerPC] Fix SH field overflow issue.

Address Jinsong's comments

Sun, Sep 22, 1:31 PM · Restricted Project
lebedev.ri updated the diff for D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 1:27 PM · Restricted Project
Yi-Hong.Lyu added inline comments to D66991: [PowerPC] Fix SH field overflow issue.
Sun, Sep 22, 1:22 PM · Restricted Project
lebedev.ri added a comment to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).

What if we just do the larger than 32-bit mask? Its not clear that making BZHI just to fold a load is an improvement. You have to materialize an immediate instead so the total uops increased.

Sun, Sep 22, 1:19 PM · Restricted Project
craig.topper committed rGc4802de31b1a: [X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm' (authored by craig.topper).
[X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'
Sun, Sep 22, 1:10 PM
ctopper committed rL372526: [X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'.
[X86] Fix some VCVTPS2PH isel patterns where 'i32' was used instead of 'timm'
Sun, Sep 22, 1:07 PM
craig.topper added a comment to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).

What if we just do the larger than 32-bit mask? Its not clear that making BZHI just to fold a load is an improvement. You have to materialize an immediate instead so the total uops increased.

Sun, Sep 22, 1:07 PM · Restricted Project
lebedev.ri updated the diff for D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).

Scaling down ambigiousness of the patch: if not using BEXTR, only use BZHI if either the mask is larger than 32-bit, or the load folding will happen.

Sun, Sep 22, 12:54 PM · Restricted Project
craig.topper committed rG80fda375b225: [X86][TableGen] Allow timm to appear in output patterns. Use it to remove… (authored by craig.topper).
[X86][TableGen] Allow timm to appear in output patterns. Use it to remove…
Sun, Sep 22, 12:49 PM
davezarzycki updated the diff for D67874: Prefer AVX512 memcpy when applicable.

This patch has now been run through update_llc_test_checks.

Sun, Sep 22, 12:48 PM · Restricted Project
ctopper committed rL372525: [X86][TableGen] Allow timm to appear in output patterns. Use it to remove….
[X86][TableGen] Allow timm to appear in output patterns. Use it to remove…
Sun, Sep 22, 12:48 PM
lebedev.ri committed rG24159592cac9: [NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875) (authored by lebedev.ri).
[NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875)
Sun, Sep 22, 12:38 PM
lebedevri committed rL372524: [NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875).
[NFC][X86] Add BEXTR test with load and 33-bit mask (PR43381 / D67875)
Sun, Sep 22, 12:38 PM
asmith added inline comments to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Sun, Sep 22, 12:37 PM · Restricted Project
RKSimon added a reviewer for D67874: Prefer AVX512 memcpy when applicable: RKSimon.
Sun, Sep 22, 12:33 PM · Restricted Project
asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Add new options to objcopy documentation

Sun, Sep 22, 12:33 PM · Restricted Project
mstorsjo created D67896: [LLDB] Add a void* cast when passing object pointers to printf %p.
Sun, Sep 22, 12:24 PM · Restricted Project
asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Address reviewers comments about auto

Sun, Sep 22, 12:24 PM · Restricted Project
craig.topper added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 12:20 PM · Restricted Project
mstorsjo created D67895: [LLDB] Avoid a warning about an unused static variable.
Sun, Sep 22, 12:19 PM · Restricted Project
mstorsjo created D67894: [LLDB] Rework a MinGW build fix from D65691.
Sun, Sep 22, 12:16 PM · Restricted Project
mstorsjo created D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general.
Sun, Sep 22, 12:14 PM · Restricted Project
craig.topper committed rGa1d86857fff2: [X86] Update commutable EVEX vcmp patterns to use timm instead of imm. (authored by craig.topper).
[X86] Update commutable EVEX vcmp patterns to use timm instead of imm.
Sun, Sep 22, 12:07 PM
mstorsjo created D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64.
Sun, Sep 22, 12:07 PM · Restricted Project
craig.topper committed rGac8477126178: [X86] Add more tests for commuting evex vcmp instructions during isel to fold a… (authored by craig.topper).
[X86] Add more tests for commuting evex vcmp instructions during isel to fold a…
Sun, Sep 22, 12:07 PM
ctopper committed rL372523: [X86] Update commutable EVEX vcmp patterns to use timm instead of imm..
[X86] Update commutable EVEX vcmp patterns to use timm instead of imm.
Sun, Sep 22, 12:05 PM
ctopper committed rL372522: [X86] Add more tests for commuting evex vcmp instructions during isel to fold a….
[X86] Add more tests for commuting evex vcmp instructions during isel to fold a…
Sun, Sep 22, 12:05 PM
lawrence_danna added a comment to D67793: new api class: SBFile.

I wrote a patch for the shared_ptr approach. It's simple, but it touches a lot of lines.

Sun, Sep 22, 12:05 PM · Restricted Project
davezarzycki added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 12:05 PM · Restricted Project
craig.topper updated subscribers of D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 11:51 AM · Restricted Project
RKSimon committed rGc8a9ae4ce2c7: [SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown… (authored by RKSimon).
[SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown…
Sun, Sep 22, 11:47 AM
RKSimon committed rG2c558bd84540: [XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning. (authored by RKSimon).
[XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning.
Sun, Sep 22, 11:47 AM
craig.topper added inline comments to D67874: Prefer AVX512 memcpy when applicable.
Sun, Sep 22, 11:47 AM · Restricted Project
RKSimon committed rL372521: [SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown….
[SelectionDAG] computeKnownBits/ComputeNumSignBits - cleanup demanded/unknown…
Sun, Sep 22, 11:45 AM
RKSimon committed rL372520: [XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning..
[XRay] Silence static analyzer dyn_cast<BufferExtents> null dereference warning.
Sun, Sep 22, 11:45 AM
mstorsjo added a comment to D67885: [LLDB] Add a missing specification of linking against dbghelp.

@hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found.

Sun, Sep 22, 11:35 AM · Restricted Project
aaronballman committed rL372519: Request commit access for myself..
Request commit access for myself.
Sun, Sep 22, 11:26 AM
davezarzycki added inline comments to D67874: Prefer AVX512 memcpy when applicable.
Sun, Sep 22, 11:26 AM · Restricted Project
lebedev.ri added inline comments to D67875: [X86] X86DAGToDAGISel::matchBEXTRFromAndImm(): if can't use BEXTR, fallback to BZHI (PR43381).
Sun, Sep 22, 11:17 AM · Restricted Project