Address Eric's review comments.
This is the order of options observed when the candidates are randomly shuffled:
The FDR mode calls to clock_gettime needs a bit more attention, let me try and isolate those before attempting to land again.
Hi! I got a bit further in my experiment in integrating this in Clangd. I put some comments (in the first more complete revision). But since the scope of this patch changed, if you feel like we should take the discussions elsewhere, please let me know! Thanks!
Remove some uses of clock_gettime from XRay naive mode logging and some support libraries.
Address most of Matt's comments. Thank you.
Initially this LGTM. I'll take another pass in the morning.
- Only pass linker flags when not CMAKE_CROSSCOMPLING.
Now implements P0653R2 which was accepted in Albuquerque.
With this patch i am seeing failures in test/CodeGen/AMDGPU/indirect-addressing-si.ll . This test include extractelement instructions with undef indices, which is what this patch targets. I would appreciate your help with advice on how we can modify these tests so that they can be used safely. Please bear in mind that i have no knowledge of the AMDGPU backend.
Addressed Ayal's comments.
Have yet to address Silviu's comments.
- Fix argument initialization.
- Make constexpr.
Can we just not use clock_gettime on Darwin and instead use mach_absolute_time?