Today

madsravn added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

This continues to LGTM; do you need someone to land the patch for you?

Sun, Apr 23, 12:34 PM
vmiklos created D32403: clang-rename: add new -force option.
Sun, Apr 23, 12:33 PM
halyavin retitled D32349: Summary: Fix race condition in std::atomic_store for std::shared_ptr. from Summary: Fix race condition is std::atomic_store for std::shared_ptr. to Summary: Fix race condition in std::atomic_store for std::shared_ptr..
Sun, Apr 23, 11:35 AM
trentxintong added a comment to D32400: [JumpThread] We want to fold (not thread) when all predecessor go to single BB's successor..

@sanjoy Appreciate it if you can take a quick look :).

Sun, Apr 23, 10:52 AM
trentxintong committed rL301135: Correct grammar. NFC.
Correct grammar. NFC
Sun, Apr 23, 10:49 AM
jlebar added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.

Since this patch was sent without sufficient context, I cannot really tell what it is dong. See http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. I'm also not comfortable reviewing Polly code, which I am unfamiliar with.

Sun, Apr 23, 10:40 AM · Restricted Project
RKSimon retitled D32391: [SelectionDAG] Improve support for promotion of <1 x fX> floating point argument types (PR31008) from [SelectionDAG] Improve support for promotion of <1 x fX> floating point argument types (PR31008 to [SelectionDAG] Improve support for promotion of <1 x fX> floating point argument types (PR31008).
Sun, Apr 23, 10:38 AM
PhilippSchaad added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.
Am I wrong on this?

No, it looks like I was wrong and you are correct.

Sorry about that.

Sun, Apr 23, 10:36 AM · Restricted Project
ctopper committed rL301134: [APInt] Make clearUnusedBits branch free..
[APInt] Make clearUnusedBits branch free.
Sun, Apr 23, 10:29 AM
ctopper committed rL301133: [APInt] In sext single word case, use SignExtend64 and let the APInt….
[APInt] In sext single word case, use SignExtend64 and let the APInt…
Sun, Apr 23, 10:29 AM
kubamracek added a comment to D32402: Add missing acquire_load to call_once overload..

Thanks for catching this!

Sun, Apr 23, 10:12 AM
jlebar committed rL301132: Add missing acquire_load to call_once overload..
Add missing acquire_load to call_once overload.
Sun, Apr 23, 10:11 AM
jlebar closed D32402: Add missing acquire_load to call_once overload. by committing rL301132: Add missing acquire_load to call_once overload..
Sun, Apr 23, 10:11 AM
jlebar added a comment to D32402: Add missing acquire_load to call_once overload..

Thank you for the review, Dmitry.

Sun, Apr 23, 10:10 AM
dvyukov accepted D32402: Add missing acquire_load to call_once overload..
Sun, Apr 23, 10:06 AM
jlebar updated the summary of D32402: Add missing acquire_load to call_once overload..
Sun, Apr 23, 10:03 AM
jlebar added a comment to D24028: [libcxx] Fix a data race in call_once.

I've sent D32402 to add the missing acquire_load.

Sun, Apr 23, 10:02 AM
jlebar created D32402: Add missing acquire_load to call_once overload..
Sun, Apr 23, 10:02 AM
Prazek created D32401: [Devirtualization] insert placement new barrier with -O0.
Sun, Apr 23, 10:00 AM
aaron.ballman added a comment to D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle..

This continues to LGTM; do you need someone to land the patch for you?

Sun, Apr 23, 9:58 AM
aaron.ballman added a comment to D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects.

Are there any further changes I should make, or is this good to submit now?

Thanks!

Sun, Apr 23, 9:56 AM · Unknown Object (Project)
aaron.ballman added inline comments to D31871: [X86] Support of no_caller_saved_registers attribute (Clang part) - restart.
Sun, Apr 23, 9:54 AM
Prazek added a comment to D32378: Insert invariant.group.barrier for pointers comparisons.

This is actually good catch, we also need to do it when inserting barrier in placement new.
I think that for the ctors and dtors we can do it only with optimizations enabled, because if optimizations are not enabled then ctors and dtors won't have the invariant.group in stores.

Sun, Apr 23, 9:52 AM
spatel committed rL301131: [InstCombine] add tests for or-to-xor; NFC.
[InstCombine] add tests for or-to-xor; NFC
Sun, Apr 23, 9:50 AM
aaron.ballman added a comment to D32181: Remove use of coverage-file flag.

Ping. (If I don't hear back, I will assume this is noncontroversial and go ahead and commit sometime next week.)

Sun, Apr 23, 9:47 AM
lhames accepted rL299203: Do not pollute the namespace in a header file..

LGTM (along with https://reviews.llvm.org/D30107).

Sun, Apr 23, 9:43 AM
Prazek updated the diff for D31830: Emit invariant.group.barrier when using union field.
  • Inserting barrier with -O0
Sun, Apr 23, 9:43 AM
Prazek updated the diff for D32378: Insert invariant.group.barrier for pointers comparisons.

Addressing Richard's comment

Sun, Apr 23, 9:40 AM
Prazek added inline comments to D32378: Insert invariant.group.barrier for pointers comparisons.
Sun, Apr 23, 9:40 AM
trentxintong updated the summary of D32400: [JumpThread] We want to fold (not thread) when all predecessor go to single BB's successor..
Sun, Apr 23, 9:29 AM
jlebar added a comment to D32215: Updated PPCG Code Generation for OpenCL compatibility.
Am I wrong on this?
Sun, Apr 23, 9:28 AM · Restricted Project
trentxintong created D32400: [JumpThread] We want to fold (not thread) when all predecessor go to single BB's successor..
Sun, Apr 23, 9:28 AM
singam-sanjay updated the diff for D31859: Initializing NVPTX backend within Polly.

Latest working patch with latest working patch of D32003

Sun, Apr 23, 9:28 AM · Restricted Project
vmiklos committed rL301130: clang-rename: fix formatting.
clang-rename: fix formatting
Sun, Apr 23, 9:19 AM
spatel committed rL301129: [InstCombine] add pattern matches for commuted variants of xor-to-xor.
[InstCombine] add pattern matches for commuted variants of xor-to-xor
Sun, Apr 23, 9:16 AM
singam-sanjay updated the diff for D32003: Linking NVPTX backend for Polly-ACC.

Latest working patch to include NVPTX libraries for Polly-ACC. Commented code is a proposed extension to the current patch, and will include or exclude it after discussion.

Sun, Apr 23, 9:10 AM · Restricted Project
kettenis created D32399: [LLD] Order writable executable sections before writable ones.
Sun, Apr 23, 8:17 AM
spatel committed rL301128: [InstCombine] add tests for xor-to-xor; NFC.
[InstCombine] add tests for xor-to-xor; NFC
Sun, Apr 23, 8:04 AM
RKSimon committed rL301127: [X86][SSE] Add scheduling latency/throughput tests for SSSE3 instructions.
[X86][SSE] Add scheduling latency/throughput tests for SSSE3 instructions
Sun, Apr 23, 7:20 AM
djasper committed rL301123: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 7:15 AM