Today

RKSimon committed rL298803: Regenerate test.
Regenerate test
Sun, Mar 26, 3:45 AM
RKSimon committed rL298802: Regenerate test.
Regenerate test
Sun, Mar 26, 3:44 AM
RKSimon committed rL298801: Regenerate tests to remove duplicated checks.
Regenerate tests to remove duplicated checks
Sun, Mar 26, 3:41 AM
javed.absar updated the diff for D30744: Improve machine schedulers for in-order processors.

Thanks Andrew. OK, I have added back 'SingleIssue' as syntactic sugar, but not in model, as recommended (if I got you right).
Best Regards, Javed.

Sun, Mar 26, 2:51 AM
dvyukov accepted D31355: [tsan] Only Acquire/Release GCD queues if they're not NULL.
Sun, Mar 26, 2:09 AM
dvyukov added a comment to D31354: [tsan] Assert to make sure we don't try to Acquire() or Release() a NULL pointer.

What was the bug? How did it manifest?
I somewhat afraid of breaking some existing code. Currently we consider memory around 0 to be "user memory". And in fact it's possible to mmap the first page at least on some linuxes, not sure about other OSes. And there is some effort to port sanitizers to mmu-less environment (https://reviews.llvm.org/D30583). Another possible use if you have N virtual entities and use N as address passed to acquire/release annotations (not perfect, but currently valid).
If we are excluding NULL from user memory, then I think we need to change IsAppMem to return false for NULL. That will make behavior consistent across all functions. Acquire/Release already check IsAppMem for the passed address (at least in debug build). It will also make simpler to undo this decision in some particular contexts.

Sun, Mar 26, 2:05 AM
igorb added a comment to D30979: [GlobalISel][X86] G_LOAD/G_STORE, add alternative RegisterBank mapping..

ping

Sun, Mar 26, 1:46 AM
igorb closed D30980: [GlobalISel][X86] support G_FRAME_INDEX instruction selection..

Thanks for the review!
Closed by commit rL298800

Sun, Mar 26, 1:42 AM
igorb removed a dependency for D30980: [GlobalISel][X86] support G_FRAME_INDEX instruction selection.: D30979: [GlobalISel][X86] G_LOAD/G_STORE, add alternative RegisterBank mapping..
Sun, Mar 26, 1:30 AM
igorb removed a dependent revision for D30979: [GlobalISel][X86] G_LOAD/G_STORE, add alternative RegisterBank mapping.: D30980: [GlobalISel][X86] support G_FRAME_INDEX instruction selection..
Sun, Mar 26, 1:30 AM
ibreger committed rL298800: [GlobalISel][X86] support G_FRAME_INDEX instruction selection..
[GlobalISel][X86] support G_FRAME_INDEX instruction selection.
Sun, Mar 26, 1:23 AM
delena added inline comments to D30397: [X86][AVX2] bugzilla bug 21281 Performance regression in vector interleave in AVX2.
Sun, Mar 26, 12:51 AM
delena added a comment to D30968: [AVX-512] Fix accidental uses of AH/BH/CH/DH after copies to/from mask registers.

I assume it's ok meanwhile.

Sun, Mar 26, 12:16 AM
craig.topper added inline comments to D30968: [AVX-512] Fix accidental uses of AH/BH/CH/DH after copies to/from mask registers.
Sun, Mar 26, 12:08 AM

Yesterday

zvi added a comment to D30968: [AVX-512] Fix accidental uses of AH/BH/CH/DH after copies to/from mask registers.

LGTM. I think it would be best if Elena or Guy took a look too.

Sat, Mar 25, 11:59 PM
joerg committed rL298799: Split the SimplifyCFG pass into two variants..
Split the SimplifyCFG pass into two variants.
Sat, Mar 25, 11:56 PM
joerg closed D30333: Split SimplifyCFG to run obscuring switch transforms only during last phase by committing rL298799: Split the SimplifyCFG pass into two variants..
Sat, Mar 25, 11:56 PM
igorb added a comment to D31359: [GlobalISel]: Allow backends to custom legalize Intrinsics.

Hello,
I think this case relevant not only for intrinsic instruction.
Any instruction can be successfully lowered/legalized but the additional instructions that were created can't be legalized and finally when we try to reportGISelFailure, we might be dealing with a erased instruction.

Sat, Mar 25, 11:40 PM
hughbe created D31372: Support Microsoft mangling of swift calling convention methods.
Sat, Mar 25, 11:15 PM
axw added a comment to D28215: Add check for BSD when setting LIB_NAMES for GNU ld.

Thanks for taking a look at this, @axw. Is there anything else that needs to happen before this can be merged?

Sat, Mar 25, 11:11 PM
axw committed rL298798: Add check for BSD when setting LIB_NAMES for GNU ld.
Add check for BSD when setting LIB_NAMES for GNU ld
Sat, Mar 25, 11:11 PM
axw closed D28215: Add check for BSD when setting LIB_NAMES for GNU ld by committing rL298798: Add check for BSD when setting LIB_NAMES for GNU ld.
Sat, Mar 25, 11:11 PM
eladcohen added a reviewer for D29599: Clang Changes for alloc_align: aaron.ballman.
Sat, Mar 25, 10:58 PM
ararslan added a comment to D28215: Add check for BSD when setting LIB_NAMES for GNU ld.

Thanks for taking a look at this, @axw. Is there anything else that needs to happen before this can be merged?

Sat, Mar 25, 10:55 PM
sanjoy added a comment to D30350: [LSR] Add a cap for reassociation of AllFixupsOutsideLoop type LSRUse to protect compile time.

Hi Wei,

Sat, Mar 25, 10:36 PM
Prazek updated the diff for D31180: [LangRef] Introduce noreplace function attribute.
  • Fixes by Hal
Sat, Mar 25, 10:08 PM
brenoguim updated the diff for D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros.
  • Removed the "#include <assert.h>" which caused problems in environments without that header
  • Included a directory with -isystem to simulate system headers
  • Added a "macro.h" header with definitions of types, functions and macros to simulate the assert.h header and others.
  • Added checks for behavior in some situations
Sat, Mar 25, 9:26 PM
ruiu committed rL298797: Sort. NFC..
Sort. NFC.
Sat, Mar 25, 9:23 PM
craig.topper added a comment to D30968: [AVX-512] Fix accidental uses of AH/BH/CH/DH after copies to/from mask registers.

Ping

Sat, Mar 25, 9:11 PM
craig.topper accepted D31200: [X86][AVX512F] Fix reg class for VMOVSSZrr/VMOVSSZrrk and VMOVSDZrr/VMOVSDZrrk.

LGTM

Sat, Mar 25, 9:11 PM
craig.topper abandoned D31348: [ValueTracking] Compute known bits for add/sub with less temporary APInts.
Sat, Mar 25, 9:09 PM
craig.topper abandoned D31115: [InstCombine] Provide a way to calculate KnownZero/One for Add/Sub in SimplifyDemandedUseBits without recursing into ComputeKnownBits.
Sat, Mar 25, 9:09 PM
ruiu committed rL298796: Remove a redundant local variable..
Remove a redundant local variable.
Sat, Mar 25, 8:54 PM
ruiu committed rL298795: Add a comment..
Add a comment.
Sat, Mar 25, 8:54 PM
qcolombet added a comment to D30350: [LSR] Add a cap for reassociation of AllFixupsOutsideLoop type LSRUse to protect compile time.

It would be even better if we had a fix to the SCEVExpander's pathological behavior.

Sat, Mar 25, 8:41 PM
ruiu committed rL298794: Inline a function that is used only once..
Inline a function that is used only once.
Sat, Mar 25, 8:33 PM
ruiu committed rL298793: De-template a few functions in which ELFT is not needed..
De-template a few functions in which ELFT is not needed.
Sat, Mar 25, 8:33 PM
ruiu committed rL298792: Add comments and return early..
Add comments and return early.
Sat, Mar 25, 8:32 PM
chandlerc committed rL298791: [IR] Make SwitchInst::CaseIt almost a normal iterator..
[IR] Make SwitchInst::CaseIt almost a normal iterator.
Sat, Mar 25, 8:01 PM
ruiu committed rL298790: Remove unused parameter..
Remove unused parameter.
Sat, Mar 25, 7:40 PM