Today

rnk added a comment to D35810: Add an empty shell of llvm-rc..

Minor comment, looks good otherwise.

Mon, Jul 24, 3:32 PM
mnbvmar updated the diff for D35810: Add an empty shell of llvm-rc..

Typos fixed.

Mon, Jul 24, 3:31 PM
ruiu added a comment to D35793: [ELF] - Change way how we handle --noinhibit-exec.

I think preventing almost all errors is too much. Most errors are still checked even if --noinhibit-exec is specified. For example, if you give nonexistent file to the linker, it is still an error.

Mon, Jul 24, 3:28 PM
zvi updated the summary of D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Mon, Jul 24, 3:26 PM
rnk added a comment to D35774: [x86][inline-asm]Extend support for memory reference expression.

I would really prefer to see fewer rewrites and more pass through of inline assembly to MC. The way we parse inline asm in two phases is a confusing source of bugs. It also makes it harder to test the Intel asm parser, since the more rewrites we do the more cross-repository tests we have to add.

Mon, Jul 24, 3:26 PM
szepet updated the diff for D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .

Accidentally left typo removed.
OK so I am not sure but am I allowed to commit it again? I mean I made some notable changes. Not on the functionality of the feature but the stored data.
So should i wait for a quick review or could I commit it right now? (It is something that would be useful to know for future commits too.)

Mon, Jul 24, 3:21 PM
zvi added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Mon, Jul 24, 3:19 PM
rcraik committed rL308932: Remove addtional parameters in function std::next() and std::prev().
Remove addtional parameters in function std::next() and std::prev()
Mon, Jul 24, 3:17 PM
rcraik closed D34649: Remove addtional parameters in function std::next() and std::prev() by committing rL308932: Remove addtional parameters in function std::next() and std::prev().
Mon, Jul 24, 3:17 PM
ruiu accepted D35767: [COFF] Correctly set the thumb bit in DLL export addresses.

LGTM

Mon, Jul 24, 3:08 PM
ruiu added inline comments to D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces..
Mon, Jul 24, 3:06 PM
cryptoad created D35818: [scudo] Check for pvalloc overflow.
Mon, Jul 24, 3:04 PM
tstellar added a comment to D35703: [GPGPU] Add support for NVIDIA libdevice.

How is this different from passing libdevice to either of the -mlink-cuda-bitcode or -mlink-bticode-file options ?

Mon, Jul 24, 3:00 PM · Restricted Project
ruiu added inline comments to D35792: [lld] [COFF, ARM64] Handle ADRP immediate offsets in relocations.
Mon, Jul 24, 2:58 PM
zvi added inline comments to D35700: DAGCombiner: Extend reduceBuildVecToTrunc to handle non-zero offset.
Mon, Jul 24, 2:58 PM
ecbeckmann added reviewers for D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces.: ruiu, rnk.
Mon, Jul 24, 2:56 PM
ecbeckmann updated the diff for D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces..

Format.

Mon, Jul 24, 2:55 PM
clayborg accepted D35607: Extend 'target symbols add' to set symbol file for a given module.
Mon, Jul 24, 2:52 PM · Restricted Project
george.karpenkov committed rL308931: Add .pyc files to .gitignore to compiler-rt.
Add .pyc files to .gitignore to compiler-rt
Mon, Jul 24, 2:51 PM
george.karpenkov closed D35815: Add .pyc files to .gitignore to compiler-rt by committing rL308931: Add .pyc files to .gitignore to compiler-rt.
Mon, Jul 24, 2:51 PM
clayborg added a comment to D35607: Extend 'target symbols add' to set symbol file for a given module.

Greg, are you with me checking this in?

Mon, Jul 24, 2:51 PM · Restricted Project
grosser added a comment to D35703: [GPGPU] Add support for NVIDIA libdevice.

Thank you for all the good reviews. I tried to address all of them.

Mon, Jul 24, 2:49 PM · Restricted Project
pcc added inline comments to D35704: added reset feature to dfsan.
Mon, Jul 24, 2:49 PM
grosser updated the diff for D35703: [GPGPU] Add support for NVIDIA libdevice.

Address review comments

Mon, Jul 24, 2:48 PM · Restricted Project
eugene added a comment to D35607: Extend 'target symbols add' to set symbol file for a given module.

Greg, are you with me checking this in?

Mon, Jul 24, 2:42 PM · Restricted Project
t.p.northover updated the diff for D35817: Ban implicit _Complex to scalar conversions in C++.

Sorry, uploaded version with slightly wrong tests.

Mon, Jul 24, 2:42 PM
t.p.northover created D35817: Ban implicit _Complex to scalar conversions in C++.
Mon, Jul 24, 2:42 PM
ruiu accepted D35814: [lld] [COFF] Add a test for producing DLLs and import libraries for ARM64.

LGTM

Mon, Jul 24, 2:40 PM
ruiu accepted D35766: [COFF] ARM64 support for COFFImportFile.

LGTM

Mon, Jul 24, 2:40 PM
kcc accepted D35815: Add .pyc files to .gitignore to compiler-rt.

LGTM

Mon, Jul 24, 2:39 PM
wdng updated the diff for D35146: AMDGPU : Widen extending scalar loads to 32-bits.

Fixed a mistake for align2_i8 lit test.

Mon, Jul 24, 2:38 PM
v.g.vassilev added a comment to D35274: [ExternalASTMerger] Import Objective-C classes.

LGTM.

Mon, Jul 24, 2:35 PM
ecbeckmann added inline comments to D35810: Add an empty shell of llvm-rc..
Mon, Jul 24, 2:35 PM
ecbeckmann updated the diff for D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces..

added additional test.

Mon, Jul 24, 2:29 PM
dmikulin committed rL308930: If user requested section alignment is greater than MaxPageSize, propagate it….
If user requested section alignment is greater than MaxPageSize, propagate it…
Mon, Jul 24, 2:29 PM
dmikulin closed D35813: Propagate section alignment to segment headers by committing rL308930: If user requested section alignment is greater than MaxPageSize, propagate it….
Mon, Jul 24, 2:28 PM
alekseyshl committed rL308929: [Sanitizers] TSan allocator set errno on failure..
[Sanitizers] TSan allocator set errno on failure.
Mon, Jul 24, 2:24 PM
alekseyshl closed D35690: [Sanitizers] TSan allocator set errno on failure. by committing rL308929: [Sanitizers] TSan allocator set errno on failure..
Mon, Jul 24, 2:24 PM
jakehehrlich added a comment to D34480: [llvm][llvm-objcopy] Added support for outputting to binary in llvm-objcopy.

It looks like you've accidentally lost program-headers.test again and regained hello-world.test.

I'm not familiar with the binary output format, and the objcopy documentation isn't exactly clear on the matter. Would you mind giving a quick overview, please?

Mon, Jul 24, 2:20 PM
rsmith added inline comments to D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor.
Mon, Jul 24, 2:09 PM