Page MenuHomePhabricator

Recent Activity

Today

LukeZhuang added a comment to D131287: Fix branch weight in FoldCondBranchOnValueKnownInPredecessor pass in SimplifyCFG.

Hello guys, sorry for bothering again. May I ask could anyone help me look at this change or give suggestions to my previous question?
Because fixing this issue is important to us. Thank you very much!

Sun, Aug 14, 4:32 PM · Restricted Project, Restricted Project
craig.topper committed rGb8c5420d74cb: [X86][RISCV] Pre-commit tests for D130862. NFC (authored by craig.topper).
[X86][RISCV] Pre-commit tests for D130862. NFC
Sun, Aug 14, 4:31 PM · Restricted Project, Restricted Project
craig.topper closed D131442: [X86][RISCV] Pre-commit tests for D130862. NFC.
Sun, Aug 14, 4:31 PM · Restricted Project, Restricted Project
kazu committed rGf5a68feab30a: Use llvm::none_of (NFC) (authored by kazu).
Use llvm::none_of (NFC)
Sun, Aug 14, 4:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kazu committed rG55f0a87ea46e: [clangd] Use llvm::any_of (NFC) (authored by kazu).
[clangd] Use llvm::any_of (NFC)
Sun, Aug 14, 4:26 PM · Restricted Project, Restricted Project
kazu committed rG6d9cd9199a6f: Use llvm::all_of (NFC) (authored by kazu).
Use llvm::all_of (NFC)
Sun, Aug 14, 4:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
philnik requested review of D131868: [libc++][NFC] Refactor enable_ifs in vector.
Sun, Aug 14, 4:22 PM · Restricted Project, Restricted Project
mumbleskates committed rGc4566cac490c: [libc++][spaceship] Implement std::variant::operator<=> (authored by mumbleskates).
[libc++][spaceship] Implement std::variant::operator<=>
Sun, Aug 14, 4:17 PM · Restricted Project, Restricted Project
mumbleskates closed D131372: [libc++][spaceship] Implement std::variant::operator<=>.
Sun, Aug 14, 4:17 PM · Restricted Project, Restricted Project
dmgreen committed rGb2ac153ba4a1: [Support] Fix no-stat build. NFC (authored by dmgreen).
[Support] Fix no-stat build. NFC
Sun, Aug 14, 3:55 PM · Restricted Project, Restricted Project
mizvekov added inline comments to D131866: [clang] fix frontend crash in auto type templates.
Sun, Aug 14, 3:37 PM · Restricted Project, Restricted Project
mizvekov added inline comments to D131858: [clang] Track the templated entity in type substitution..
Sun, Aug 14, 3:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D131858: [clang] Track the templated entity in type substitution..
Sun, Aug 14, 3:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
aykevl updated the diff for D131867: [AVR] Do not emit instructions invalid for attiny10.
Sun, Aug 14, 3:18 PM · Restricted Project, Restricted Project
inclyc updated the diff for D131866: [clang] fix frontend crash in auto type templates.

.

Sun, Aug 14, 3:09 PM · Restricted Project, Restricted Project
aykevl requested review of D131867: [AVR] Do not emit instructions invalid for attiny10.
Sun, Aug 14, 3:01 PM · Restricted Project, Restricted Project
inclyc updated the diff for D131866: [clang] fix frontend crash in auto type templates.

rebase

Sun, Aug 14, 3:01 PM · Restricted Project, Restricted Project
inclyc updated the diff for D131866: [clang] fix frontend crash in auto type templates.

update comments

Sun, Aug 14, 2:59 PM · Restricted Project, Restricted Project
inclyc updated the diff for D131866: [clang] fix frontend crash in auto type templates.

rename

Sun, Aug 14, 2:49 PM · Restricted Project, Restricted Project
inclyc updated the diff for D131866: [clang] fix frontend crash in auto type templates.

.

Sun, Aug 14, 2:48 PM · Restricted Project, Restricted Project
inclyc updated the summary of D131866: [clang] fix frontend crash in auto type templates.
Sun, Aug 14, 2:43 PM · Restricted Project, Restricted Project
inclyc published D131866: [clang] fix frontend crash in auto type templates for review.
Sun, Aug 14, 2:42 PM · Restricted Project, Restricted Project
ychen committed rG6afcc4a459ea: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering… (authored by ychen).
[c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering…
Sun, Aug 14, 2:39 PM · Restricted Project, Restricted Project
ychen closed D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template.
Sun, Aug 14, 2:38 PM · Restricted Project, Restricted Project
ychen updated the diff for D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template.
  • rebase
Sun, Aug 14, 2:36 PM · Restricted Project, Restricted Project
dblaikie added a comment to D131082: [libcxx] Add _LIBCPP_NODEBUG to std::conditional related typedfs.

I don't think we should strip debug information in the public API. Instead, we should try to remove as much implementation-detail debug-info as possible.

Sun, Aug 14, 2:31 PM · Restricted Project, Restricted Project
kparzysz committed rG40ba78679dc0: [Hexagon] Distribute disjoint intervals at the end of expand-condsets (authored by kparzysz).
[Hexagon] Distribute disjoint intervals at the end of expand-condsets
Sun, Aug 14, 2:16 PM · Restricted Project, Restricted Project
kparzysz committed rG98bd2524322e: [Hexagon] Make some loops in HexagonExpandCondsets.cpp range-based, NFC (authored by kparzysz).
[Hexagon] Make some loops in HexagonExpandCondsets.cpp range-based, NFC
Sun, Aug 14, 2:16 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D130741: [MLIR][OpenMP] tile Construct Operation.

I think we should discuss this operation a bit more before proceeding. If the loop and its control are not part of the tile OpenMP dialect operation then there is no guarantee that the tiling transformation will happen. The loop can be modified or converted by other transformations or conversions.

Sun, Aug 14, 2:15 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D130851: [MLIR][OpenMP] Unroll Construct operation.

I think we should discuss this operation a bit more before proceeding. If the loop and its control are not part of the unroll OpenMP dialect operation then there is no guarantee that the unroll operation will happen. The loop can be modified or converted by other transformations or conversions.

Sun, Aug 14, 2:13 PM · Restricted Project, Restricted Project
mizvekov updated the diff for D131858: [clang] Track the templated entity in type substitution..
Sun, Aug 14, 2:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
davrec added a comment to D131858: [clang] Track the templated entity in type substitution..

It was very good to separate this out, thanks. Can you can do some TMP performance testing, to verify the impacts are negligible before taking resugaring into consideration, to allay potential concerns?

Sun, Aug 14, 2:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
glandium added a comment to D130479: [ORC_RT][COFF] Initial platform support for COFF/x86_64..

For what it's worth, this break building compiler-rt with clang-cl:

In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp:16:
In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.h:17:
In file included from /builds/worker/fetches/llvm-project/compiler-rt/lib/orc/executor_address.h:20:
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/simple_packed_serialization.h(403,58): error: no member named 'string_view' 
in namespace 'std'
template <> class SPSSerializationTraits<SPSString, std::string_view> {
                                                    ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(109,21): error: no type named 'string_view' in namespace '
std'
  void *dlopen(std::string_view Name, int Mode);
               ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(111,34): error: no type named 'string_view' in namespace '
std'
  void *dlsym(void *Header, std::string_view Symbol);
                            ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(118,34): error: no member named 'string_view' in namespace
 'std'
      std::vector<std::pair<std::string_view, ExecutorAddrRange>> Secs,
                            ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(122,34): error: no member named 'string_view' in namespace
 'std'
      std::vector<std::pair<std::string_view, ExecutorAddrRange>> Secs);
                            ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(135,36): error: no type named 'string_view' in namespace '
std'
  Expected<void *> dlopenImpl(std::string_view Path, int Mode);
                              ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(143,46): error: no type named 'string_view' in namespace '
std'
  JITDylibState *getJITDylibStateByName(std::string_view Path);
                                        ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(145,54): error: no type named 'string_view' in namespace '
std'
                                                std::string_view Symbol);
                                                ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(156,27): error: no member named 'string_view' in namespace
 'std'
  std::unordered_map<std::string_view, void *> JDNameToHeader;
                     ~~~~~^
/builds/worker/fetches/llvm-project/compiler-rt/lib/orc/coff_platform.cpp(173,55): error: no type named 'string_view' in namespace '
std'

etc.

Sun, Aug 14, 2:08 PM · Restricted Project, Restricted Project, Restricted Project
ychen added a comment to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.

Some documentation/test nits, and one question, but otherwise LGTM.
Could you fix the merge conflict? It would be nice to see pre-commit CI results.

Given the complexity of the technical details here, as long as it doesn't unreasonably delay this, please wait for other people to also review it.

Sun, Aug 14, 2:04 PM · Restricted Project, Restricted Project
ychen added inline comments to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
Sun, Aug 14, 2:02 PM · Restricted Project, Restricted Project
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
  • address Roy's comments.
Sun, Aug 14, 2:02 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D131674: [Flang][OpenMP] Add test case for simd collapse clause.

As far as possible we should try to have Flang and MLIR OpenMP dialect changes in separate patches.

Sun, Aug 14, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
dblaikie accepted D131848: [DebugInfo] -fdebug-prefix-map: handle '#line "file"' for asm source.

SGTM

Sun, Aug 14, 1:50 PM · Restricted Project, Restricted Project
rtenneti updated the diff for D130405: Implement TZ Variable Parsing Function..

Fixed errors to handle cpp::optional and cpp:nullopt.

Sun, Aug 14, 1:49 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D131840: [analyzer] Handling non-POD multidimensional arrays in ArrayInitLoopExpr.
Sun, Aug 14, 1:45 PM · Restricted Project