Today

skatkov committed rL318638: [CGP] Fix the crash caused by enable of complex addr mode.
[CGP] Fix the crash caused by enable of complex addr mode
Sun, Nov 19, 9:43 PM
skatkov closed D40166: [CGP] Fix the crash caused by enable of complex addr mode by committing rL318638: [CGP] Fix the crash caused by enable of complex addr mode.
Sun, Nov 19, 9:43 PM
pcc committed rL318637: COFF: Fix invalid comdat sections in test cases..
COFF: Fix invalid comdat sections in test cases.
Sun, Nov 19, 9:31 PM
pcc committed rL318636: COFF: Change SparseChunks to be of type std::vector<SectionChunk *>. NFC..
COFF: Change SparseChunks to be of type std::vector<SectionChunk *>. NFC.
Sun, Nov 19, 9:31 PM
glenjofe updated the diff for D35470: [libcxx] Implement std::to_address for C++20.

Address Eric's review comments.

Sun, Nov 19, 9:31 PM
pcc committed rL318635: COFF: Remove unused fields. NFC..
COFF: Remove unused fields. NFC.
Sun, Nov 19, 9:31 PM
yamaguchi accepted D40234: [AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering.

LGTM, thanks!

Sun, Nov 19, 9:22 PM · Restricted Project
mgrang added a comment to D40234: [AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering.

This is the order of options observed when the candidates are randomly shuffled:

Sun, Nov 19, 9:13 PM · Restricted Project
mgrang created D40234: [AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering.
Sun, Nov 19, 9:10 PM · Restricted Project
dberris planned changes to D39114: [XRay][darwin] Initial XRay in Darwin Support.

The FDR mode calls to clock_gettime needs a bit more attention, let me try and isolate those before attempting to land again.

Sun, Nov 19, 8:24 PM
martell added inline comments to D39673: Toolchain: Normalize dwarf, sjlj and seh eh.
Sun, Nov 19, 8:18 PM
malaperle added a comment to D39050: Add index-while-building support to Clang.

Hi! I got a bit further in my experiment in integrating this in Clangd. I put some comments (in the first more complete revision). But since the scope of this patch changed, if you feel like we should take the discussions elsewhere, please let me know! Thanks!

Sun, Nov 19, 7:56 PM
dberris updated the diff for D39114: [XRay][darwin] Initial XRay in Darwin Support.

Remove some uses of clock_gettime from XRay naive mode logging and some support libraries.

Sun, Nov 19, 7:33 PM
phosek created D40233: [CMake][runtimes] Support monorepo layout with runtimes build.
Sun, Nov 19, 7:06 PM
phosek created D40232: [CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add.
Sun, Nov 19, 7:03 PM
haicheng added inline comments to D39556: [ConstantFold] Support vector index when factoring out GEP index into preceding dimensions.
Sun, Nov 19, 6:32 PM
haicheng updated the diff for D39556: [ConstantFold] Support vector index when factoring out GEP index into preceding dimensions.

Address most of Matt's comments. Thank you.

Sun, Nov 19, 6:24 PM
EricWF added a comment to D35470: [libcxx] Implement std::to_address for C++20.

Initially this LGTM. I'll take another pass in the morning.

Sun, Nov 19, 5:59 PM
hintonda updated the diff for D39734: [cmake] Pass LLVM_USE_LINKER flag to CrossCompile toolchain if set.
  • Only pass linker flags when not CMAKE_CROSSCOMPLING.
Sun, Nov 19, 5:35 PM
shiva0217 added inline comments to D38894: [RFC][Tablegen] Add CCIfSplitFrom and CCPassIndirectBySamePointer Calling Convention Interfaces.
Sun, Nov 19, 5:33 PM
shiva0217 updated the diff for D38894: [RFC][Tablegen] Add CCIfSplitFrom and CCPassIndirectBySamePointer Calling Convention Interfaces.
Sun, Nov 19, 5:30 PM
shiva0217 updated the diff for D38894: [RFC][Tablegen] Add CCIfSplitFrom and CCPassIndirectBySamePointer Calling Convention Interfaces.
Sun, Nov 19, 5:24 PM
glenjofe updated the diff for D35470: [libcxx] Implement std::to_address for C++20.

Now implements P0653R2 which was accepted in Albuquerque.

Sun, Nov 19, 4:48 PM
glenjofe retitled D35470: [libcxx] Implement std::to_address for C++20 from [libcxx] Implement pointer_traits::to_address as in P0653R0 to [libcxx] Implement std::to_address for C++20.
Sun, Nov 19, 4:45 PM
ctopper committed rL318634: [X86] clzero check in getHostCPUFeatures should use getX86CpuIDAndInfo not….
[X86] clzero check in getHostCPUFeatures should use getX86CpuIDAndInfo not…
Sun, Nov 19, 3:49 PM
ctopper committed rL318633: [X86] Reorder and reformat the feature bit checks in getHostCPUFeatues to keep….
[X86] Reorder and reformat the feature bit checks in getHostCPUFeatues to keep…
Sun, Nov 19, 3:30 PM
craig.topper added inline comments to D40223: [X86] Control-Flow Enforcement Technology - Shadow Stack support (LLVM side).
Sun, Nov 19, 3:07 PM
zvi added a comment to D40231: InstructionSimplify: 'extractelement' with an undef index is undef.

With this patch i am seeing failures in test/CodeGen/AMDGPU/indirect-addressing-si.ll . This test include extractelement instructions with undef indices, which is what this patch targets. I would appreciate your help with advice on how we can modify these tests so that they can be used safely. Please bear in mind that i have no knowledge of the AMDGPU backend.

Sun, Nov 19, 3:07 PM
zvi created D40231: InstructionSimplify: 'extractelement' with an undef index is undef.
Sun, Nov 19, 3:01 PM
craig.topper updated the summary of D40230: Add -mprefer-vector-width driver option and attribute during CodeGen..
Sun, Nov 19, 2:54 PM
craig.topper created D40230: Add -mprefer-vector-width driver option and attribute during CodeGen..
Sun, Nov 19, 2:53 PM
dorit updated the diff for D38948: [LV] Support efficient vectorization of an induction with redundant casts.

Addressed Ayal's comments.
Have yet to address Silviu's comments.

Sun, Nov 19, 2:49 PM
EricWF updated the diff for D40218: [Clang] Add __builtin_launder.
  • Fix argument initialization.
  • Make constexpr.
Sun, Nov 19, 2:24 PM
hintonda updated the summary of D40229: [cmake] Remove redundant call to cmake when building host tools..
Sun, Nov 19, 2:23 PM
philip.pfaffe added inline comments to D39971: Port ScopInfo to the isl cpp bindings.
Sun, Nov 19, 2:16 PM
pfaffe committed rL318632: Port ScopInfo to the isl cpp bindings.
Port ScopInfo to the isl cpp bindings
Sun, Nov 19, 2:14 PM
Diffusion closed D39971: Port ScopInfo to the isl cpp bindings by committing rL318632: Port ScopInfo to the isl cpp bindings.
Sun, Nov 19, 2:13 PM
jroelofs added inline comments to D40218: [Clang] Add __builtin_launder.
Sun, Nov 19, 2:13 PM
dberris planned changes to D39114: [XRay][darwin] Initial XRay in Darwin Support.

Can we just not use clock_gettime on Darwin and instead use mach_absolute_time?

Sun, Nov 19, 2:12 PM
EricWF added inline comments to D40218: [Clang] Add __builtin_launder.
Sun, Nov 19, 2:12 PM