Today

EricWF committed rCXX322810: Fix most GCC test failures..
Fix most GCC test failures.
Wed, Jan 17, 7:42 PM
EricWF committed rL322810: Fix most GCC test failures..
Fix most GCC test failures.
Wed, Jan 17, 7:42 PM
espindola updated the diff for D41318: Start setting dso_local in clang.

All tests have been updated.

Wed, Jan 17, 7:24 PM
george.karpenkov committed rL322809: [analyzer] a few helper methods for getting and comparing symbolic values.
[analyzer] a few helper methods for getting and comparing symbolic values
Wed, Jan 17, 7:20 PM
george.karpenkov committed rC322809: [analyzer] a few helper methods for getting and comparing symbolic values.
[analyzer] a few helper methods for getting and comparing symbolic values
Wed, Jan 17, 7:20 PM
espindola commandeered D41318: Start setting dso_local in clang.
Wed, Jan 17, 7:20 PM
george.karpenkov closed D42218: [analyzer] a few helper methods for getting and comparing symbolic values.
Wed, Jan 17, 7:20 PM
aemerson added a comment to D42175: [AArch64][GlobalISel] Add isel support for global values in the large code model.

@kristof.beyls @rogfer01 Could someone from ARM do a quick test of this? I don't have an ELF target handy to test it myself and I'd like to get this fixed in the release branch.

Wed, Jan 17, 7:20 PM
sbc100 added reviewers for D42226: [WebAssembly] Add test expectations for gcc C++ tests (gcc/testsuite/g++.dg): dschuff, jgravelle-google.
Wed, Jan 17, 7:17 PM
sbc100 created D42226: [WebAssembly] Add test expectations for gcc C++ tests (gcc/testsuite/g++.dg).
Wed, Jan 17, 7:17 PM
espindola closed D42122: Make GlobalValues with non-default visibilility dso_local.

322808,322807,322806

Wed, Jan 17, 7:14 PM
george.karpenkov added a dependency for D41848: [analyzer] mark returns of functions where the region passed as parameter was not initialized: D42218: [analyzer] a few helper methods for getting and comparing symbolic values.
Wed, Jan 17, 7:12 PM
george.karpenkov added a dependent revision for D42218: [analyzer] a few helper methods for getting and comparing symbolic values: D41848: [analyzer] mark returns of functions where the region passed as parameter was not initialized.
Wed, Jan 17, 7:12 PM
espindola closed D42208: Use an enum value instead of an string.
Wed, Jan 17, 7:12 PM
george.karpenkov updated the diff for D41848: [analyzer] mark returns of functions where the region passed as parameter was not initialized.

Now with support for constructors.

Wed, Jan 17, 7:12 PM
pcc created D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows..
Wed, Jan 17, 7:02 PM
reames requested changes to D41903: [ValueLattice] Use union to shave off ptr size bytes from elements..

Bunch of minor comments, but once those addressed, likely good to go.

Wed, Jan 17, 6:55 PM
reames requested changes to D39743: [ValueLattice] Add CompactValueLatticeElement..

Marking to get off my queue.

Wed, Jan 17, 6:55 PM
espindola created D42224: Don't assume a null GV is local for ELF and MachO.
Wed, Jan 17, 6:55 PM
wolfgangp added inline comments to D42021: [DWARF] v5 implementation of string offsets tables - producer side.
Wed, Jan 17, 6:42 PM
wolfgangp updated the diff for D42021: [DWARF] v5 implementation of string offsets tables - producer side.

Addressed most of David's review comments and commented on the ones I didn't address.

Wed, Jan 17, 6:42 PM
pcc retitled D42220: libcxx: Use vcruntime declarations for typeinfo on Windows. from libcxx: Move bad_cast and bad_typeid member functions inline on Windows. to libcxx: Use vcruntime declarations for typeinfo on Windows..
Wed, Jan 17, 6:37 PM
MTC abandoned D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true..
Wed, Jan 17, 6:36 PM
pcc updated the diff for D42220: libcxx: Use vcruntime declarations for typeinfo on Windows..
  • Use typeinfo declarations from vcruntime
Wed, Jan 17, 6:36 PM
jckarter created D42223: X86MachObjectWriter: Allow subtractors with undefined targets..
Wed, Jan 17, 6:36 PM
sfertile added a comment to D41463: [CodeGen] Add a new pass to sink Copy instructions after RA.

I've tested this out on Power with spec2006 and several open-source applications. With spec I saw a pretty similar increase in shrink wrapping opportunities (~11% with -O3 pgo+thinlto, ~7% with just -O3). I've noticed in some instances we do a lot of sinking without enabling new shrink-wrap opportunities though. For example with xalan stats showed we sunk about 4000 copies with this pass, but only enabled 5 new shrink-wrap opportunities and I see a consistent ~2% degradation with ref data. My understanding was enabling more shrink-wrap candidates was the original motivation. Have you considered breaking this up into an analysis that collects what copies are sinkable, and then only sink if doing so is likely to make the block viable for shrink-wrapping?

Wed, Jan 17, 6:32 PM
reames accepted D41675: Remove alignment argument from memcpy/memmove/memset in favour of alignment attributes (Step 1).

LGTM w/minor comment applied.

Wed, Jan 17, 6:32 PM
NoQ added a comment to D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true..

That's the "Add Action..." list-box above the comment box.

Wed, Jan 17, 6:26 PM
MTC added a comment to D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true..
In D37189#979795, @NoQ wrote:

Oh well, i guess i covered this in my recent patches anyway (esp. r322787/D41406). Sorry, i just fixed everything differently and it became unclear how to integrate your patch into the whole thing.

Wed, Jan 17, 6:22 PM
efriedma added inline comments to D42087: [DSE] Improve handling of noop stores exposed after dead interfering stores are removed.
Wed, Jan 17, 6:17 PM
rafael committed rC322808: Update for llvm change..
Update for llvm change.
Wed, Jan 17, 6:12 PM
rafael committed rL322806: Make GlobalValues with non-default visibilility dso_local..
Make GlobalValues with non-default visibilility dso_local.
Wed, Jan 17, 6:12 PM
rafael committed rL322808: Update for llvm change..
Update for llvm change.
Wed, Jan 17, 6:12 PM
rafael committed rLLD322807: Update for llvm change..
Update for llvm change.
Wed, Jan 17, 6:12 PM
apazos abandoned D41722: [RISCV WIP] Fixed InstAlias to handle tied operands..

This is one of the design options we considered for compression.
But MCPat solution is favored over this one.

Wed, Jan 17, 6:12 PM
rafael committed rL322807: Update for llvm change..
Update for llvm change.
Wed, Jan 17, 6:12 PM
apazos abandoned D41530: [WIP] Tablegen driven compress instruction emitter.

This is one design option we considered for Compression but decided not to go with this one.
It only addresses printing instruction, for encoding more code has to be added.
Either InstAlias combo solution or MCPat solution are favored.

Wed, Jan 17, 6:12 PM
bogner added a comment to D42159: [GlobalISel] Making MachineCSE runnable in the middle of the GlobalISel.

Roman asked me to commit this for him off-thread. It's r322805.

Wed, Jan 17, 6:12 PM
bogner committed rL322805: GlobalISel: Make MachineCSE runnable in the middle of the GlobalISel.
GlobalISel: Make MachineCSE runnable in the middle of the GlobalISel
Wed, Jan 17, 6:08 PM
apazos updated the diff for D41932: [RISCV WIP] Hooks for compressing instructions from MCPat.
Wed, Jan 17, 6:07 PM