Today

smeenai updated the diff for D38112: [ELF] Fix edge condition in thunk offset calculation.

Fold inputs into test case

Wed, Sep 20, 6:28 PM
dlj committed rL313854: [lit/Win] Check if a path was found before attempting to use it..
[lit/Win] Check if a path was found before attempting to use it.
Wed, Sep 20, 6:28 PM
dlj closed D38115: [lit/Win] Check if a path was found before attempting to use it. by committing rL313854: [lit/Win] Check if a path was found before attempting to use it..
Wed, Sep 20, 6:27 PM
dlj created D38115: [lit/Win] Check if a path was found before attempting to use it..
Wed, Sep 20, 6:26 PM
dberris added a comment to D38073: [XRay][compiler-rt] Use pthread for initializing thread-local data.

Thanks for the review!

Wed, Sep 20, 6:15 PM
dberris updated the diff for D38073: [XRay][compiler-rt] Use pthread for initializing thread-local data.
  • fixup: address comments
Wed, Sep 20, 6:14 PM
vedantk committed rL313853: [llvm-cov] Improve error messaging for function mismatches.
[llvm-cov] Improve error messaging for function mismatches
Wed, Sep 20, 6:13 PM
vsapsai created D38114: [Sema] Emit an error for using tags with flexible array member as ObjC class ivar..
Wed, Sep 20, 6:12 PM
vsk accepted D37924: Add section headers to SpecialCaseLists.

Thanks

Wed, Sep 20, 6:06 PM
eugenis accepted D37924: Add section headers to SpecialCaseLists.
Wed, Sep 20, 6:05 PM
eugenis updated subscribers of D37925: Allow specifying sanitizers in blacklists.
Wed, Sep 20, 6:05 PM
arsenm committed rL313852: AMDGPU: Fix crash on immediate operand.
AMDGPU: Fix crash on immediate operand
Wed, Sep 20, 5:47 PM
arsenm closed D38103: AMDGPU: Fix crash on immediate operand.

r313852

Wed, Sep 20, 5:47 PM
MatzeB added a comment to D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR.

Was the code not using emmintrin.h and instead copied code from it that used the builtins?

Wed, Sep 20, 5:42 PM
craig.topper added a comment to D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR.

Was the code not using emmintrin.h and instead copied code from it that used the builtins?

Wed, Sep 20, 5:40 PM
MatzeB added a comment to D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR.

Actually, looking at the change it seems like it is and we better try to update emmintrin.h...

Wed, Sep 20, 5:38 PM
arsenm updated the diff for D38113: OpenCL: Assume functions are convergent.

Missed test update

Wed, Sep 20, 5:37 PM
vitalybuka committed rL313851: [ubsan] Split ubsan_init_standalone.
[ubsan] Split ubsan_init_standalone
Wed, Sep 20, 5:37 PM
vitalybuka closed D38013: [ubsan] Split ubsan_init_standalone by committing rL313851: [ubsan] Split ubsan_init_standalone.
Wed, Sep 20, 5:36 PM
jlebar added a comment to D38113: OpenCL: Assume functions are convergent.

LGTM for the changes other than the test (I don't read opencl).

Wed, Sep 20, 5:36 PM
MatzeB added a comment to D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR.

With this commit some (old) code stops to compile as it seems to remove some builtins, was that intentional?

Wed, Sep 20, 5:36 PM
kcc added a comment to D38107: [Coverage] Add an option to emit limited coverage info.

naming is hard. Maybe something like

-mllvm -clang-coverage-experimental-ignore-headers=1 ?

(anyway, bike-shedding...)

Wed, Sep 20, 5:34 PM
mnbvmar updated the diff for D37283: [llvm-rc] Serialize HTML resources to .res files (serialization, pt 1)..

Style fixes suggested in the comments. Integrated llvm-readobj into test invocation.

Wed, Sep 20, 5:33 PM
arsenm created D38113: OpenCL: Assume functions are convergent.
Wed, Sep 20, 5:32 PM
vsk added a comment to D38107: [Coverage] Add an option to emit limited coverage info.

Thanks for taking a look. I'd like to give Alex and others a chance to read over this (different timezones), and am happy to change the name of the cl::opt.

Wed, Sep 20, 5:31 PM
davide committed rL313850: [AArch64] Properly check alignment for AARCH64_LD_PREL_LO19..
[AArch64] Properly check alignment for AARCH64_LD_PREL_LO19.
Wed, Sep 20, 5:28 PM
zturner committed rL313849: [lit] Make lit support config files with .py extension..
[lit] Make lit support config files with .py extension.
Wed, Sep 20, 5:26 PM
zturner closed D37838: [lit] Allow lit config files to have a .py extension by committing rL313849: [lit] Make lit support config files with .py extension..
Wed, Sep 20, 5:26 PM
vitalybuka updated the diff for D38013: [ubsan] Split ubsan_init_standalone.

Rebase

Wed, Sep 20, 5:24 PM
phosek added a comment to D37631: [libFuzzer] Support using libc++.

Yeah, that' what I was thinking. I can update the lit configuration to use -lc++ even on Linux if LLVM_ENABLE_LIBCXX is set so we get coverage on bots. Is that fine with you?

SGTM
but is any reason to use -lc++ instead of --stdlib=libc++ ?

Wed, Sep 20, 5:24 PM
ctopper committed rL313848: [X86] Replace a condition that can never be true with an assert..
[X86] Replace a condition that can never be true with an assert.
Wed, Sep 20, 5:20 PM
ctopper committed rL313847: [SelectionDAG] Replace a flag that can never be true with an assert..
[SelectionDAG] Replace a flag that can never be true with an assert.
Wed, Sep 20, 5:20 PM
davide committed rL313846: [AArch64] Include test for out of range LD_PREL_LO19..
[AArch64] Include test for out of range LD_PREL_LO19.
Wed, Sep 20, 5:18 PM
Dor1s accepted D38107: [Coverage] Add an option to emit limited coverage info.

Thanks Vedant!

Wed, Sep 20, 5:17 PM
smeenai created D38112: [ELF] Fix edge condition in thunk offset calculation.
Wed, Sep 20, 5:16 PM
vitalybuka committed rL313845: [asan] Remove trailing spaces.
[asan] Remove trailing spaces
Wed, Sep 20, 5:15 PM
vitalybuka committed rL313844: [asan] Remove "COLLISION" workaround for datarace in asan.
[asan] Remove "COLLISION" workaround for datarace in asan
Wed, Sep 20, 5:13 PM
vitalybuka committed rL313843: [asan] Remove "rm -f" in tests where it was needed only because of >>.
[asan] Remove "rm -f" in tests where it was needed only because of >>
Wed, Sep 20, 5:07 PM
dberris accepted D38102: [XRay] support conditional return on PPC..

LGTM for the instrumentation pass side (with a couple of suggestions).

Wed, Sep 20, 5:06 PM
dschuff added a comment to D38111: [WebAssembly] Weak symbols should be defined in SF_Global.

retro-LGTM

Wed, Sep 20, 4:55 PM