- All Stories
- Advanced Search
- Transaction Logs
Sun, Mar 19
Sat, Mar 18
Looks like you're just removing the output altogether, so that won't work.
Should anonymous records even be in the name based map? What would the impact be of storing them in a separate vector?
Ping: any updates on landing of this revision?
I'm not clear what problem we're trying to solve in practice. Many of the emitters do their own sort of the Records.
"subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject 'foo'", but that's just a suggestion and I'll wait for a native spearker to chime in on this.
Add some number from system_server
Updating D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64
Reformatted the file
Reformatted the CGOpenMPRuntime.cpp to conform to clang standards
Undo formatting changes and fix typo in test comment.
Uploaded wrong commit.
In D146251#4204317, @dim wrote:
Yes, <tgmath.h> is also available on macOS, but it is unnecessary, even on Linux. Using just <math.h> should be sufficient, because the only math function used is hypot(3) which works on doubles by default. There is really no need to pull in the tricky macro machinery from tgmath here.
In D146251#4201293, @brad wrote:
Looks like all three OS's have tgmath.h as well. Why not just make this#if defined(__MINGW32__) #include <complex.h> #elif defined(__APPLE__) #include <math.h> #else #include <tgmath.h> #endif
For now, unless you can also build test on macOS?
This is not generally legal for div/rem, see https://alive2.llvm.org/ce/z/2iiR26 using one of your tests. This is only legal if the operation is speculatable.
In D144912#4204088, @carlosgalvezp wrote:
Looks great, approved! Thanks for fixing :)
Do not calculate sizes in non-debug builds
It looks like this broke building libunwind. Building it now fails with (when building clang and lld and so on with this patch, and then building libunwind with just-built clang and lld and so on):
Fix a couple more incorrect XFAILs
Propegate nuw flag
Add flag propegation test
There are 2 issues found in llvm repository:
- llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:721:22: warning: reference variable 'S' extends the lifetime of a just-constructed temporary object 'const StringRef', consider changing reference to value [readability-reference-to-constructed-temporary]
- clang/lib/Sema/SemaChecking.cpp:10096:36: warning: reference variable 'AT2' extends the lifetime of a just-constructed temporary object 'const analyze_printf::ArgType', consider changing reference to value [readability-reference-to-constructed-temporary]
Put tests in canonical commuted form. Add multiuse tests
- Use diagnostics
- Add a test
In D146333#4204007, @awarzynski wrote:
We already have an error message, so print it as well.
I'm not sure I follow - can you elaborate? This patch is switching from an assertion to a diagnostic. The error message inside the assert will be printed regardless of whether a diagnostic is used or not.
Trigger CI with parent diff.
Re-upload with parent to trigger CI properly.
CI failures are unrelated.
CI failures are unrelated and we're on them, landing.