Page MenuHomePhabricator
Feed All Stories

Thu, Nov 25

jmorse committed rG3107081e9413: [DebugInfo][InstrRef] Avoid some quadratic behaviour in LiveDebugVariables (authored by jmorse).
[DebugInfo][InstrRef] Avoid some quadratic behaviour in LiveDebugVariables
Thu, Nov 25, 12:31 PM
jmorse closed D114587: [DebugInfo][InstrRef] Avoid some quadratic behaviour in LiveDebugVariables.
Thu, Nov 25, 12:31 PM · Restricted Project
ldionne abandoned D113280: [libc++] Remove UNSUPPORTEDs on 32 bit CI.

Abandoning since we're removing support for the 32 bit multilib build in favour of building for a real 32 bit triple. See D114473.

Thu, Nov 25, 12:29 PM · Restricted Project, Restricted Project
ldionne committed rGebfeeec4c4bc: [libunwind] Fix testing with sanitizers enabled (authored by ldionne).
[libunwind] Fix testing with sanitizers enabled
Thu, Nov 25, 12:28 PM
ldionne closed D114385: [libunwind] Fix testing with sanitizers enabled.
Thu, Nov 25, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
ldionne added a comment to D114385: [libunwind] Fix testing with sanitizers enabled.

I am going to make the 32 bit CI build a soft failure until we remove it entirely and ship this patch. See D114473 for removing the 32 bit multilib support.

Thu, Nov 25, 12:27 PM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D114557: [fir] Add base for runtime builder unittests.

ddress review comments

Thu, Nov 25, 12:27 PM · Restricted Project, Restricted Project
clementval added inline comments to D114557: [fir] Add base for runtime builder unittests.
Thu, Nov 25, 12:27 PM · Restricted Project, Restricted Project
jackoalan updated the diff for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.

Fix clang-format issue

Thu, Nov 25, 12:26 PM · Restricted Project
avl updated the diff for D114429: [objcopy][NFC] Add doc comments to the executeObjcopy* functions..

addressed comments.

Thu, Nov 25, 12:25 PM · Restricted Project
nicolasvasilache resigned from D110031: [mlir][Linalg] Add methods to charecterize the loops of a ConvolutionOpInterface..

vectorization works fine without any of this as I was hoping, declaring bankruptcy here, thanks!

Thu, Nov 25, 12:24 PM · Restricted Project
ldionne updated the diff for D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Update commit message and improve the release note.

Thu, Nov 25, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
nicolasvasilache accepted D114608: [mlir][linalg] Simplify the hoist padding tests..

Nice simplification, thanks!

Thu, Nov 25, 12:22 PM · Restricted Project
nicolasvasilache added inline comments to D114585: [mlir][linalg] Run CSE after every CodegenStrategy transformation..
Thu, Nov 25, 12:22 PM · Restricted Project
nicolasvasilache accepted D114238: [MLIR] Avoid creation of buggy affine maps when incorrect values of number of dimensions and number of symbols are provided..

thanks!

Thu, Nov 25, 12:20 PM · Restricted Project
quinnp accepted D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck.

LGTM

Thu, Nov 25, 12:20 PM · Restricted Project, Restricted Project
fhahn added a comment to D114183: [ThreadPool] Support returning futures with results..
Thu, Nov 25, 12:19 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D114550: [mlir][Vector] Support 0-D vectors in `BroadcastOp`.

This will prob. also need to be rebased since I couldn't land the parent.

Thu, Nov 25, 12:19 PM · Restricted Project
fhahn committed rGbc41653a1f28: [ThreadPool] Use auto again for future with ENABLE_THREADS=Off. (authored by fhahn).
[ThreadPool] Use auto again for future with ENABLE_THREADS=Off.
Thu, Nov 25, 12:19 PM
nicolasvasilache added a comment to D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.

I cannot seem to be able to arc patch this and submit it for you.

Thu, Nov 25, 12:18 PM · Restricted Project
ldionne added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

[runtimes] Remove support for building in 32 bits mode on a 64 bit target

I think this needs to be clarified. It is about the GCC multilib style -m32 (inherited to Clang), not about the general cross-compilation feature.

Thu, Nov 25, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
DanielMcIntosh-IBM added a comment to D114183: [ThreadPool] Support returning futures with results..

Your revert breaks normal building: http://45.33.8.238/linux/61593/step_4.txt

PTAL.

Thu, Nov 25, 12:17 PM · Restricted Project, Restricted Project
nicolasvasilache committed rGcc311a155aa9: [mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion` (authored by michalt).
[mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion`
Thu, Nov 25, 12:16 PM
nicolasvasilache closed D114549: [mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion`.
Thu, Nov 25, 12:16 PM · Restricted Project
jackoalan added a reviewer for D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies: t.p.northover.
Thu, Nov 25, 12:16 PM · Restricted Project
ldionne accepted D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

🚢 it!

Thu, Nov 25, 12:16 PM · Restricted Project
nicolasvasilache accepted D114598: [mlir][Standard] Support 0-D vectors in `SplatOp`.

Thanks for decomposing into an easy to review PR, LGTM!

Thu, Nov 25, 12:11 PM · Restricted Project
Jake-Egan committed rG0796869e4e1e: [AIX] Disable unsupported offloading gpu tests (authored by Jake-Egan).
[AIX] Disable unsupported offloading gpu tests
Thu, Nov 25, 12:11 PM
Jake-Egan closed D114381: [AIX] Disable unsupported offloading gpu tests.
Thu, Nov 25, 12:11 PM · Restricted Project
fhahn added a reverting change for rG71a7c55f0f02: Revert "[ThreadPool] Support returning futures with results.": rG8cb1af73c617: Recommit [ThreadPool] Support returning futures with results..
Thu, Nov 25, 12:10 PM
fhahn committed rG8cb1af73c617: Recommit [ThreadPool] Support returning futures with results. (authored by fhahn).
Recommit [ThreadPool] Support returning futures with results.
Thu, Nov 25, 12:10 PM
nicolasvasilache accepted D114549: [mlir][Vector] Support 0-D vectors in `VectorPrintOpConversion`.

Thanks!

Thu, Nov 25, 12:09 PM · Restricted Project
jackoalan requested review of D114610: [GlobalISel][Utils] Optionally accept alternate COPY opcodes in getDefSrcRegIgnoringCopies.
Thu, Nov 25, 12:07 PM · Restricted Project
jessesna added a comment to D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.

Thanks a lot for your time and help @MyDeveloperDay

Thu, Nov 25, 11:59 AM · Unknown Object (Project), Restricted Project
MyDeveloperDay committed rG813d486cbc99: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks (authored by jessesna).
[clang-format] Extend AllowShortBlocksOnASingleLine for else blocks
Thu, Nov 25, 11:45 AM
MyDeveloperDay closed D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks.
Thu, Nov 25, 11:45 AM · Unknown Object (Project), Restricted Project
ronlieb added a comment to D114183: [ThreadPool] Support returning futures with results..

Both of our amdgpu buildbots are broken by this commit, when I revert it locally my build will pass.
https://lab.llvm.org/buildbot/#/builders/193
https://lab.llvm.org/buildbot/#/builders/165

Thu, Nov 25, 11:45 AM · Restricted Project, Restricted Project
igor.kirillov updated the diff for D114577: [AArch64][SVEIntrinsicOpts] Fix: predicated SVE mul/fmul are not commutative.

Update comment

Thu, Nov 25, 11:42 AM · Restricted Project
vitalybuka accepted D114607: tsan: remember and print function that installed at_exit callbacks.
Thu, Nov 25, 11:40 AM · Restricted Project
quinnp committed rGa712b661eb94: [NFC][llvm] Inclusive language: replace master in llvm docs (authored by quinnp).
[NFC][llvm] Inclusive language: replace master in llvm docs
Thu, Nov 25, 11:37 AM
vitalybuka accepted D114606: tsan: add a test for on_exit.
Thu, Nov 25, 11:37 AM · Restricted Project
quinnp closed D114187: [NFC][llvm] Inclusive language: replace master in llvm docs.
Thu, Nov 25, 11:36 AM · Restricted Project
vitalybuka accepted D114604: tsan: check stack in atexit4.cpp test.
Thu, Nov 25, 11:36 AM · Restricted Project
vitalybuka accepted D114605: tsan: add test for __cxa_atexit.
Thu, Nov 25, 11:36 AM · Restricted Project
MyDeveloperDay committed rG3c8666ef9a21: [clang-format] NFC update LLVM overall clang-formatted status (authored by MyDeveloperDay).
[clang-format] NFC update LLVM overall clang-formatted status
Thu, Nov 25, 11:36 AM
Mordante added inline comments to D110499: [libc++][format][5/6] Improve format_to_n..
Thu, Nov 25, 11:36 AM · Restricted Project
quinnp committed rG5c162ec54520: [NFC][compiler-rt] Inclusive language: replace master/slave with… (authored by quinnp).
[NFC][compiler-rt] Inclusive language: replace master/slave with…
Thu, Nov 25, 11:31 AM
quinnp closed D114255: [NFC][compiler-rt] Inclusive language: replace master/slave with primary/secondary.
Thu, Nov 25, 11:31 AM · Restricted Project
Mordante added inline comments to D110498: [libc++][format][4/6] Improve formatted_size..
Thu, Nov 25, 11:30 AM · Restricted Project
int3 added a comment to D114397: [lld-macho] Mark dylib symbols coming from -weak_framework as weak-ref.

Can you explain why you think "the implementation did not do that"? Lines 12 and 13 in the old test (before your changes) cover that case...

Thu, Nov 25, 11:30 AM · Restricted Project, Restricted Project
danilaml added inline comments to D114337: Support Windows.
Thu, Nov 25, 11:28 AM · Restricted Project
kpdev42 committed rLNT2afddc424851: [LNT] Fixed JS error caused by selecting the function with missing counters on… (authored by kpdev42).
[LNT] Fixed JS error caused by selecting the function with missing counters on…
Thu, Nov 25, 11:27 AM
kpdev42 closed D114584: [LNT] Fixed JS error caused by selecting the function with missing counters on the profile page.
Thu, Nov 25, 11:27 AM · Restricted Project
Mordante added inline comments to D110495: [libc++][format][2/6] Adds a __output_iterator..
Thu, Nov 25, 11:25 AM · Restricted Project
bondhugula added a comment to D114240: [MLIR] Prevent creation of buggy affine map after linearizing collapsed dimensions of source map.

This revision isn't properly based -- please rebase on the current master tip and update.

Thu, Nov 25, 11:23 AM · Restricted Project
amyk added a comment to D107519: [AIX][test-suite] Update the telecomm-FFT benchmark to use saved sin/cos values for some inputs..

I thought about this again and just wanted to make sure that I did not misunderstand your previous comment.

So, if this also works for in another architecture (like x86_64 or Arm on Linux or Mac), then it should be fine to merge.

Do you mean that it would be preferable for other targets to test this patch as well to ensure it is a reasonable fix? Would this be necessary as I'm using a hard-coding a few of the Linux libm produced values (that produces what is already expected in MultiSource/Benchmarks/MiBench/telecomm-FFT/telecomm-fft.reference_output)?

Thu, Nov 25, 11:20 AM · Restricted Project
bondhugula accepted D114240: [MLIR] Prevent creation of buggy affine map after linearizing collapsed dimensions of source map.
Thu, Nov 25, 11:20 AM · Restricted Project
bondhugula committed rGc89fc1eec3fd: [MLIR] NFC. Rename MLIR CAPI ExecutionEngine target for consistency (authored by bondhugula).
[MLIR] NFC. Rename MLIR CAPI ExecutionEngine target for consistency
Thu, Nov 25, 11:19 AM
bondhugula closed D114596: [MLIR] NFC. Rename MLIR CAPI ExecutionEngine target for consistency.
Thu, Nov 25, 11:18 AM · Restricted Project
ZarkoCA accepted D114255: [NFC][compiler-rt] Inclusive language: replace master/slave with primary/secondary.

LGTM, thanks

Thu, Nov 25, 11:14 AM · Restricted Project
kadircet requested review of D114609: [clang] Fix crash on broken parameter declarators.
Thu, Nov 25, 11:12 AM · Restricted Project
ldionne requested changes to D108430: add tsan library.

Can you please provide an explanation of what this change does and why? It would be useful to reviewers that might not have all the context (like myself).

Thu, Nov 25, 11:11 AM · Restricted Project, Restricted Project
ZarkoCA accepted D114187: [NFC][llvm] Inclusive language: replace master in llvm docs.

Thanks.

Thu, Nov 25, 11:10 AM · Restricted Project
ldionne removed projects from D106339: Add support to generate Sphinx DOCX documentation: Restricted Project, Restricted Project.

Removing from the runtimes review queue -- please ping me directly if you need my attention on this.

Thu, Nov 25, 11:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne accepted D110501: [libc++][format] Adds formatting benchmarks..
Thu, Nov 25, 11:07 AM · Restricted Project
melver accepted D114607: tsan: remember and print function that installed at_exit callbacks.
Thu, Nov 25, 11:06 AM · Restricted Project
ljmf00 abandoned D113631: [docs] Fix trailing whitespaces.

Seem to be already fixed on the upstream default branch

Thu, Nov 25, 11:03 AM · Restricted Project
gysit requested review of D114608: [mlir][linalg] Simplify the hoist padding tests..
Thu, Nov 25, 11:02 AM · Restricted Project
Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Removed some tests already disabled by D114481.

Thu, Nov 25, 11:00 AM · Restricted Project, Restricted Project
melver accepted D114606: tsan: add a test for on_exit.
Thu, Nov 25, 10:58 AM · Restricted Project
vitalybuka updated the diff for D114488: [sanitizer] Switch StackStore to 8 MiB blocks.

restore release

Thu, Nov 25, 10:57 AM · Restricted Project
miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Added missing #include-s

Thu, Nov 25, 10:56 AM · Restricted Project
melver accepted D114605: tsan: add test for __cxa_atexit.
Thu, Nov 25, 10:55 AM · Restricted Project
Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Thu, Nov 25, 10:53 AM · Restricted Project, Restricted Project
ldionne added inline comments to D113161: [libc++] Implement P1989R2: range constructor for string_view.
Thu, Nov 25, 10:53 AM · Restricted Project
bondhugula updated the summary of D114596: [MLIR] NFC. Rename MLIR CAPI ExecutionEngine target for consistency.
Thu, Nov 25, 10:53 AM · Restricted Project
melver accepted D114604: tsan: check stack in atexit4.cpp test.
Thu, Nov 25, 10:52 AM · Restricted Project
dvyukov requested review of D114607: tsan: remember and print function that installed at_exit callbacks.
Thu, Nov 25, 10:49 AM · Restricted Project
dvyukov requested review of D114606: tsan: add a test for on_exit.
Thu, Nov 25, 10:49 AM · Restricted Project
dvyukov requested review of D114605: tsan: add test for __cxa_atexit.
Thu, Nov 25, 10:49 AM · Restricted Project
dvyukov requested review of D114604: tsan: check stack in atexit4.cpp test.
Thu, Nov 25, 10:49 AM · Restricted Project
paulwalker-arm added inline comments to D114542: [CodeGen][SVE] Use whilelo instruction when lowering @llvm.get.active.lane.mask.
Thu, Nov 25, 10:46 AM · Restricted Project
jmorse updated the diff for D114588: [DebugInfo][InstrRef] "Final" test cleanup switching x86 tests to instruction referencing.

Fold in a change to 2010-05-26-DotDebugLoc.ll -- I wasn't sure why it needed a change, however it turns out to be spurious too. In DBG_VALUE mode, a DBG_VALUE is issued after a copy of the argument $rdi to $rbx, but in instr-ref mode that copy is deferred until after an instruction that clobbers $rdi. Hence, we expect the location-list MCSymbol to come after one additional copy.

Thu, Nov 25, 10:42 AM · Restricted Project
MaskRay added inline comments to D113901: [lld] Add cet-report and bti-report flags.
Thu, Nov 25, 10:40 AM
amyk committed rG150681f2f322: [PowerPC] Prevent the optimizer from producing wide vector types in IR. (authored by amyk).
[PowerPC] Prevent the optimizer from producing wide vector types in IR.
Thu, Nov 25, 10:36 AM
amyk closed D113900: [PowerPC] Prevent the optimizer from producing wide vector types in IR..
Thu, Nov 25, 10:36 AM · Restricted Project, Restricted Project
StephenTozer added a comment to D114364: [DebugInfo][5/N] Recognise extra indirection in instruction-referencing for NRVO tests.

IMO these tests would benefit little as they're really targetted at LiveDebugValues, and shouldn't really be .ll tests. On the other hand, given that there isn't actually a test difference between the two implementations, it won't hurt to add some extra RUN lines, WDYT?

Thu, Nov 25, 10:35 AM · Restricted Project
quinnp committed rG34303d3db78f: [NFC][llvm] Inclusive language: replace master with main in dbg-call-site… (authored by quinnp).
[NFC][llvm] Inclusive language: replace master with main in dbg-call-site…
Thu, Nov 25, 10:34 AM
quinnp closed D114097: [NFC][llvm] Inclusive language: replace master with main in dbg-call-site-spilled-arg.mir.
Thu, Nov 25, 10:34 AM · Restricted Project
kpdev42 committed rG1aab5e653d2c: [LLDB] Provide target specific directories to libclang (authored by kpdev42).
[LLDB] Provide target specific directories to libclang
Thu, Nov 25, 10:27 AM
kpdev42 closed D110827: [LLDB] Provide target specific directories to libclang.
Thu, Nov 25, 10:27 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.

Clarify TracksDebugUserValues documenting comment.

Thu, Nov 25, 10:24 AM · Restricted Project
jmorse requested review of D114603: [DebugInfo][InstrRef] Terminate variable locations when overlapping fragments are assigned.
Thu, Nov 25, 10:23 AM · Restricted Project
jackoalan retitled D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues from [GlobalISel] Allow DBG_VALUE to use invalid vregs throughout pipeline to [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
Thu, Nov 25, 10:21 AM · Restricted Project
jackoalan updated the diff for D112852: [GlobalISel] Allow DBG_VALUE to use undefined vregs before LiveDebugValues.
  • Rename DebugValuesAllocated -> TracksDebugUserValues
  • MIR key for TracksDebugUserValues
  • TracksDebugUserValues tests for MachineVerifier
  • LiveDebugValues test to ensure undefined debug uses delete DBG_VALUE instructions
Thu, Nov 25, 10:20 AM · Restricted Project
ZarkoCA accepted D114097: [NFC][llvm] Inclusive language: replace master with main in dbg-call-site-spilled-arg.mir.

LGTM

Thu, Nov 25, 10:18 AM · Restricted Project
ljmf00 added a comment to D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

LGTM modulo the inline comment.

Thu, Nov 25, 10:14 AM · Restricted Project
ljmf00 updated the diff for D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Thu, Nov 25, 10:13 AM · Restricted Project
ldionne committed rG151a7dafd316: [libc++] Fix ssize test that made an assumption about ptrdiff_t being 'long' (authored by ldionne).
[libc++] Fix ssize test that made an assumption about ptrdiff_t being 'long'
Thu, Nov 25, 10:13 AM
gandhi21299 added a comment to D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

Passed internal CI

Thu, Nov 25, 10:13 AM · Restricted Project