Page MenuHomePhabricator
Feed All Stories

Today

usaxena95 committed rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95).
[clangd] Add Random Forest runtime for code completion.
Fri, Sep 18, 10:27 AM
usaxena95 closed D83814: [clangd] Add Random Forest runtime for code completion..
Fri, Sep 18, 10:27 AM · Restricted Project
MaskRay added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Pushed this one now.

Just FTR, keep in mind that if LLD is configured this way, most existing ELF tests will fail, as they don't pass any explicit -m parameter. Not sure if it's worth adding such an option to all of them, or just require building with the option in the default state if one wants to work on LLD and actually run tests.

Fri, Sep 18, 10:24 AM · Restricted Project, lld
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Fri, Sep 18, 10:23 AM · Restricted Project
silvas committed rG7c44651360dd: [mlir][shape] Extend shape.cstr_require with a message. (authored by silvas).
[mlir][shape] Extend shape.cstr_require with a message.
Fri, Sep 18, 10:22 AM
silvas closed D87875: [mlir][shape] Extend shape.cstr_require with a message..
Fri, Sep 18, 10:22 AM · Restricted Project
qcolombet accepted D86925: [MachineSink] add one more profitable pattern for sinking.

Weird, I added case test/CodeGen/PowerPC/sink-down-more-instructions-1.mir. Could you do another check?

Fri, Sep 18, 10:21 AM · Restricted Project
nickdesaulniers accepted D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..
Fri, Sep 18, 10:18 AM · Restricted Project
MyDeveloperDay committed rGa16e4a63ae7c: [clang-format] NFC ensure the clang-format tests remain clang-formatted (authored by MyDeveloperDay).
[clang-format] NFC ensure the clang-format tests remain clang-formatted
Fri, Sep 18, 10:17 AM
arsenm added inline comments to D86294: AMDGPU/GlobalISel: Add tablegen operator that looks through copies.
Fri, Sep 18, 10:15 AM · Restricted Project
arsenm added reviewers for D86294: AMDGPU/GlobalISel: Add tablegen operator that looks through copies: dsanders, paquette, aemerson, aditya_nandakumar.
Fri, Sep 18, 10:15 AM · Restricted Project
tambre added a comment to D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.

I'll go ahead and commit this, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules.

Fri, Sep 18, 10:14 AM · Restricted Project
arsenm added a comment to rGc3492a1aa1b9: [amdgpu] Lower SGPR-to-VGPR copy in the final phase of ISel..

Can you revert this? I think that this transform itself is a workaround, and even if it were a good idea, I think it doesn't belong in another loop over the function in finalizeLowering

Could you elaborate on why that would be a workaround? Basically, after instruction selection, the COPY from SGPR to VGPR should be lowered to a native instruction.

Because this should be done after register allocation like is already done. Replacing a copy with something else should only interfere with generic optimizations

That would be too late for MachineCSE and other optimization to remove the redundant COPYs and reduce the register usage. Moving that after RA won't reduce register pressure.

So you are working around something MahcineCSE isn't doing on copies. You could just have MachineCSE do this for these copies

MachineCSE and other optimizations are designed not to handle that target-independent COPY or like, which is added with the intention that, potentially, the source and destination operands are coalesced and that COPY is removed finally. As SGPR and VGPR are different register banks and won't be coalesced anyway, native instruction should be used instead.

This does not make sense, COPY is what generic optimizations do understand. If it's useful to CSE cross bank copies, MachineCSE should handle them. As a representational choice, not-copy is worse than copy

A target-independent cross-bank COPY is definitely useful but the current COPY should not be used for that purpose considering how it's used in RA-related passes, especially only architectural constraints are changed between the source and destination operands where the propagation should be stopped.

Fri, Sep 18, 10:13 AM
MyDeveloperDay committed rG2e7add812eb7: [clang-format] Add a option for the position of Java static import (authored by MyDeveloperDay).
[clang-format] Add a option for the position of Java static import
Fri, Sep 18, 10:13 AM
MyDeveloperDay closed D87201: [clang-format] Add a option for the position of Java static import.
Fri, Sep 18, 10:12 AM · Restricted Project, Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Reproducer:

struct objc_super {};
extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...);
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);

Result:

$ clang -c test.mm
test.mm:3:48: error: reference to 'objc_super' is ambiguous
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);
                                               ^
test.mm:1:8: note: candidate found by name lookup is 'objc_super'
struct objc_super {};
       ^
note: candidate found by name lookup is 'objc_super'
1 error generated.

Looking into this, got an idea what might be wrong. Gimme an hour or two. :)

Fri, Sep 18, 10:11 AM · Restricted Project
tambre requested review of D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.
Fri, Sep 18, 10:11 AM · Restricted Project
JonChesterfield committed rGa9be2b5cb2b3: [libomptarget] Disable build of amdgpu plugin as it doesn't build with rocm. (authored by JonChesterfield).
[libomptarget] Disable build of amdgpu plugin as it doesn't build with rocm.
Fri, Sep 18, 10:10 AM
lebedev.ri added a comment to D87149: [InstCombine] erase instructions leading up to unreachable.

Hi!

We've run into a case where instcombine crashes with this patch:

opt -o /dev/null bbi-47401.ll -instcombine

on

@c = external global i16*, align 1

define void @main() {
entry:
  br label %for.cond

for.cond:                                         ; preds = %g.exit, %entry
  %conv1 = phi double [ %conv, %g.exit ], [ undef, %entry ]
  br i1 undef, label %for.end, label %for.body

for.body:                                         ; preds = %for.cond
  %0 = load i16*, i16** @c, align 1
  %1 = load i16, i16* %0, align 1
  %conv = sitofp i16 %1 to double
  unreachable

g.exit:                                           ; No predecessors!
  br label %for.cond

for.end:                                          ; preds = %for.cond
  %conv1.lcssa = phi double [ %conv1, %for.cond ]
  store double %conv1.lcssa, double* undef, align 1
  ret void
}

results in

opt: ../lib/Transforms/InstCombine/InstCombineInternal.h:448: virtual llvm::Instruction *llvm::InstCombinerImpl::eraseInstFromFunction(llvm::Instruction &): Assertion `I.use_empty() && "Cannot erase instruction that is used!"' failed.

I suppose it's the dead block %g.exit that messes up things.

We had a use_empty() guard in an earlier draft of this patch and decided that could not happen. :)
https://reviews.llvm.org/D87149#2259207
Thanks for the test case!

Fri, Sep 18, 10:07 AM · Restricted Project
craig.topper accepted D87861: [instcombine][x86] Converted pdep/pext with shifted mask to simple arithmetic.

LGTM

Fri, Sep 18, 10:07 AM · Restricted Project
MaskRay added inline comments to D87824: [lld][ELF][test] Add additional LTO testing.
Fri, Sep 18, 10:00 AM · Restricted Project
tianshilei1992 updated the diff for D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen.

Fixed the test case target_parallel_codegen.cpp

Fri, Sep 18, 10:00 AM · Restricted Project
spatel added a comment to D87149: [InstCombine] erase instructions leading up to unreachable.

Hi!

We've run into a case where instcombine crashes with this patch:

opt -o /dev/null bbi-47401.ll -instcombine

on

@c = external global i16*, align 1

define void @main() {
entry:
  br label %for.cond

for.cond:                                         ; preds = %g.exit, %entry
  %conv1 = phi double [ %conv, %g.exit ], [ undef, %entry ]
  br i1 undef, label %for.end, label %for.body

for.body:                                         ; preds = %for.cond
  %0 = load i16*, i16** @c, align 1
  %1 = load i16, i16* %0, align 1
  %conv = sitofp i16 %1 to double
  unreachable

g.exit:                                           ; No predecessors!
  br label %for.cond

for.end:                                          ; preds = %for.cond
  %conv1.lcssa = phi double [ %conv1, %for.cond ]
  store double %conv1.lcssa, double* undef, align 1
  ret void
}

results in

opt: ../lib/Transforms/InstCombine/InstCombineInternal.h:448: virtual llvm::Instruction *llvm::InstCombinerImpl::eraseInstFromFunction(llvm::Instruction &): Assertion `I.use_empty() && "Cannot erase instruction that is used!"' failed.

I suppose it's the dead block %g.exit that messes up things.

Fri, Sep 18, 10:00 AM · Restricted Project
rnk added a comment to D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors.

@rsmith What's the deal with these anonymous structs/unions? Why do they have copy/move constructors (are those technically called from the enclosing class's copy/move constructors?) but no default constructor to be called from the other ctors of the enclosing class?

Fri, Sep 18, 9:59 AM · Restricted Project
MaskRay accepted D87824: [lld][ELF][test] Add additional LTO testing.

LGTM.

Fri, Sep 18, 9:58 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Reproducer:

struct objc_super {};
extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...);
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);

Result:

$ clang -c test.mm
test.mm:3:48: error: reference to 'objc_super' is ambiguous
extern "C" void objc_msgSendSuper_stret(struct objc_super *super, SEL op, ...);
                                               ^
test.mm:1:8: note: candidate found by name lookup is 'objc_super'
struct objc_super {};
       ^
note: candidate found by name lookup is 'objc_super'
1 error generated.
Fri, Sep 18, 9:57 AM · Restricted Project
jamieschmeiser updated the diff for D86360: Add new hidden option -print-changed which only reports changes to IR.

Respond to review comments: change comments, few code revisions, notably with
std::string. Tighten up test cases with more -NEXT checks of the IR.

Fri, Sep 18, 9:55 AM · Restricted Project
jyknight added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Fri, Sep 18, 9:55 AM · Restricted Project
jamieschmeiser added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

@ychen, Why are the regexs not sufficient for testing? I would rather not "check the common sub-string of GCC's and MSVC's output" because it has already been sufficiently demonstrated that this is fragile in the test. Referring to the code creating one of the banners:
SmallString<20> Banner = formatv("* IR Dump After {0} *", PassID);
We see that the test checks everything except the PassID (the name is added after) and the rest of the banner is distinct in all cases. I have changed the regexs to {{.+}} which will ensure that there is actually something there but checking anything else will make the test susceptible to failing based on the compiler. The important part of the test is captured in that the banner shows that the dump is either filtered, ignored, output, etc and that the portion of IR is correct. This is the intent of the tests, rather than testing how different compilers construct a PassID.
@MaskRay From earlier comments:
"The reason for the round-trip structure is that there are more instantiations of these templates that report changes in different forms still to come. I will be subsequently posting reviews for at least 2 different change reporters based on these base classes. By defining these templates in this fashion, the functionality of comparing different IR representations and determining when changes have occurred and should be filtered, reported or ignored is all in common in the base classes. The derived classes will be called when interesting events happen and only need to handle presenting the events without having to determine when the events occur."
There are 2 other derived change reporters currently up for review based on these base classes, although the PRs need updating based on changes made in this PR. This makes at least 3 derived classes. See https://reviews.llvm.org/D87000 and https://reviews.llvm.org/D87202

Fri, Sep 18, 9:53 AM · Restricted Project
jfb added a comment to D87858: [hip] Add HIP scope atomic ops..
In D87858#2280429, @jfb wrote:

Please provide documentation in this patch.

opencl atomic builtins are documented as notes to __c11_atomic builtins part of https://clang.llvm.org/docs/LanguageExtensions.html#builtin-functions. These new atomic builtins can be documented in a similar way after that.

Fri, Sep 18, 9:52 AM · Restricted Project
thegameg committed rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit (authored by thegameg).
[NFC][ScheduleDAG] Remove unused EntrySU SUnit
Fri, Sep 18, 9:52 AM
thegameg closed D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.
Fri, Sep 18, 9:52 AM · Restricted Project
eduucaldas updated the diff for D87895: [SyntaxTree] Test for '\' inside token..

Fix typo

Fri, Sep 18, 9:51 AM · Restricted Project
eduucaldas updated the diff for D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.

rebase

Fri, Sep 18, 9:47 AM · Restricted Project
jroelofs added inline comments to D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Fri, Sep 18, 9:47 AM · Restricted Project
amyk accepted D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.

Forgot to approve this patch.

Fri, Sep 18, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
amyk updated the diff for D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM.

Address clang-format concerns.

Fri, Sep 18, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D86905: Flush bitcode incrementally for LTO output.
Fri, Sep 18, 9:44 AM · Restricted Project
paulwalker-arm added inline comments to D87842: [SVE] Use NEON for extract_vector_elt when the index is in range..
Fri, Sep 18, 9:43 AM · Restricted Project
danielkiss added a comment to D85649: [AArch64] PAC/BTI code generation for LLVM generated functions.

I think error is fine because realistically linking modules with different BTI settings will result probably a binary that crash runtime anyway if BTI is on.
otherwise turning BTI on just of a subset of object is useless.

Fri, Sep 18, 9:43 AM · Restricted Project
Jianzhou Zhao <jianzhouzh@google.com> committed rGcab6f5b2ab81: Use one more byte to silence a warning from Vistual C++ (authored by Jianzhou Zhao <jianzhouzh@google.com>).
Use one more byte to silence a warning from Vistual C++
Fri, Sep 18, 9:43 AM
jyknight updated the diff for D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..

Comment nits.

Fri, Sep 18, 9:42 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87375: [compiler-rt] Support glibc's non-standard I printf flag character.
Fri, Sep 18, 9:42 AM · Restricted Project
klausler accepted D87892: [flang] Do not dereference an array out of bound just to take its address.

LGTM; thanks for fixing this.

Fri, Sep 18, 9:42 AM
dmajor added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Fri, Sep 18, 9:40 AM · Restricted Project
arsenm added inline comments to D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Fri, Sep 18, 9:40 AM · Restricted Project
klausler added a comment to D87859: [flang] Unnecessary call to CHECK() for call to NULL() as an actual argument.

NULL() isn't "undefined". It's a pointer (or in some other contexts, an unallocated allocatable), and the description of ASSOCIATED() in 16.9.16 just requires that its first (POINTER=) argument be a pointer.

(Even if NULL() were undefined, it would be okay -- see paragraph (2) of 16.1, which describes general rules for inquiry functions, of which ASSOCIATED is an example.) "Unless the description of an intrinsic inquiry function states otherwise, these arguments are permitted to be unallocated allocatable variables or pointers that are undefined or disassociated."

This all sounds reasonable to me. If what you say is all correct, I would expect the call to ALLOCATED() to return .FALSE.. But every compiler I've tried (IBM, Intel, PGI, and GNU) all produce compile-time errors.

@klausler, is it your guidance that we should compiler the expression ALLOCATED(NULL)) without error?

Fri, Sep 18, 9:39 AM · Restricted Project, Restricted Project
akhuang added a reviewer for D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors: rnk.
Fri, Sep 18, 9:39 AM · Restricted Project
JonChesterfield added a comment to D87841: [openmp][libomptarget] Include header from LLVM source tree.

I strongly dislike build scripts pulling files off the internet. It's bad for machines that aren't connected to the web and upsets people in security

Fri, Sep 18, 9:38 AM · Restricted Project, Restricted Project
stephan.yichao.zhao added inline comments to D86905: Flush bitcode incrementally for LTO output.
Fri, Sep 18, 9:38 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Fixed output_dir cmake variable. Clean build succeeds now.
Ready to land.

Fri, Sep 18, 9:36 AM · Restricted Project
jyknight added inline comments to D87865: PR47468: Fix findPHICopyInsertPoint, so that copies aren't incorrectly inserted after an INLINEASM_BR..
Fri, Sep 18, 9:33 AM · Restricted Project
jroelofs accepted D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..

LGTM

Fri, Sep 18, 9:33 AM · Restricted Project
yaxunl added a comment to D87858: [hip] Add HIP scope atomic ops..
In D87858#2280429, @jfb wrote:

Please provide documentation in this patch.

Fri, Sep 18, 9:32 AM · Restricted Project
burmako accepted D87767: [mlir][Linalg] Evolve named ops to use assembly form and support linalg on tensors..
Fri, Sep 18, 9:31 AM · Restricted Project
rnk updated subscribers of rGb959906cb9e7: [PGO] Use multiple comdat groups for COFF.

I'm aware the ELF supports comdat groups, but when I spoke to @xur back in 2019 we decided it was best not to use this feature. That resulted in D68041, which I see you reverted.

Fri, Sep 18, 9:31 AM
MaskRay added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Fri, Sep 18, 9:30 AM · Restricted Project
jroelofs accepted D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

LGTM

Fri, Sep 18, 9:29 AM · Restricted Project
paulwalker-arm updated the diff for D87842: [SVE] Use NEON for extract_vector_elt when the index is in range..

Replaced custom selection with isel patterns. Since we're going the isel route I figures I may was well add the missing patterns for unpacked floating point types.

Fri, Sep 18, 9:29 AM · Restricted Project
yaxunl added reviewers for D87858: [hip] Add HIP scope atomic ops.: tra, rjmccall.
Fri, Sep 18, 9:27 AM · Restricted Project
tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Fri, Sep 18, 9:25 AM · Restricted Project
stefanp added reviewers for D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits: sfertile, NeHuang, Restricted Project.
Fri, Sep 18, 9:24 AM · Restricted Project
stefanp requested review of D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Fri, Sep 18, 9:23 AM · Restricted Project
scui updated the diff for D87850: Fold the comparison of bitcasted global values .

Fix previous reverion of 2004-11-27-SetCCForCastLargerAndConstant.ll and PR17073.ll

Fri, Sep 18, 9:22 AM · Restricted Project
jroelofs accepted D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

LGTM

Fri, Sep 18, 9:22 AM · Restricted Project
jroelofs committed rG51c5add8547a: Extending Baremetal toolchain's support for the rtlib option. (authored by jroelofs).
Extending Baremetal toolchain's support for the rtlib option.
Fri, Sep 18, 9:20 AM
jroelofs closed D87164: Extending Baremetal toolchain's support for the rtlib option..
Fri, Sep 18, 9:19 AM · Restricted Project, Restricted Project
dantrushin updated the diff for D87154: [WIP][Statepoints] Change statepoint machine instr format to better suit VReg lowering..

Rebase on tip and use newly added API;
Slightly change GC pointer operand lowering;

Fri, Sep 18, 9:18 AM · Restricted Project
jroelofs accepted D86972: [IRSim] Adding a basic similarity identifier..

small nits, otherwise LGTM

Fri, Sep 18, 9:17 AM · Restricted Project
foad added inline comments to D87912: [X86] Use shuffle to widen truncate of 128-bit and smaller vectors.
Fri, Sep 18, 9:17 AM · Restricted Project
dantrushin requested review of D87915: [WIP][Statepoints] Unlimited tied operands..
Fri, Sep 18, 9:15 AM · Restricted Project
Andy Ly <lyandy@google.com> committed rG3c2e2df8d03e: [MLIR][ODS] Add constBuilderCall for TypeArrayAttr (authored by Andy Ly <lyandy@google.com>).
[MLIR][ODS] Add constBuilderCall for TypeArrayAttr
Fri, Sep 18, 9:15 AM
Andy Ly <lyandy@google.com> closed D87907: [MLIR][ODS] Add constBuilderCall for TypeArrayAttr.
Fri, Sep 18, 9:14 AM · Restricted Project
daltenty added reviewers for D87914: [AIX][Clang][Driver] Add handling of shared option: Xiangling_L, hubert.reinterpretcast, xingxue.
Fri, Sep 18, 9:14 AM · Restricted Project
tskeith requested changes to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Fri, Sep 18, 9:11 AM · Restricted Project
daltenty requested review of D87914: [AIX][Clang][Driver] Add handling of shared option.
Fri, Sep 18, 9:10 AM · Restricted Project
praveen added a reviewer for D87908: [flang] [OpenMP 4.5] Adding lit test cases for OMP Parallel and Loop Constructs.: richard.barton.arm.
Fri, Sep 18, 9:10 AM · Restricted Project
MaskRay updated subscribers of rGb959906cb9e7: [PGO] Use multiple comdat groups for COFF.

ELF uses the same comdat group for all the __profd_, __profc_ and __profvp_ symbols can decrease the object file size, but COFF comdat does not support such an operation? @rnk
The build bot link has been garbage collected.

Fri, Sep 18, 9:10 AM
kmclaughlin requested review of D87913: [SVE][CodeGen] Lower legal integer -> floating point conversions.
Fri, Sep 18, 9:10 AM · Restricted Project
spatel added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

I know this has already been reverted but just FYI that I've bisected a ~2% regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is due to the extra unrolling / cost modelling issue already mentioned?

Fri, Sep 18, 9:09 AM · Restricted Project, Restricted Project
sammccall added a comment to D87335: [json] Create some llvm::Expected-based accessors.

Argh, I hit enter too soon. One thing I'd planned to add was I'm sorry about the delay in reviewing this, too.

Fri, Sep 18, 9:08 AM · Restricted Project
foad added inline comments to D87502: [DAGCombiner] Use known bits to fold extract_vector_elt with const index.
Fri, Sep 18, 9:05 AM · Restricted Project
jroelofs added a comment to D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..

update LGTM too

Fri, Sep 18, 9:05 AM · Restricted Project
scui updated the diff for D87850: Fold the comparison of bitcasted global values .

Revert 2004-11-27-SetCCForCastLargerAndConstant.ll and PR17073.ll

Fri, Sep 18, 9:04 AM · Restricted Project
foad requested review of D87912: [X86] Use shuffle to widen truncate of 128-bit and smaller vectors.
Fri, Sep 18, 9:04 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Removed generated (for review) files.

Fri, Sep 18, 9:04 AM · Restricted Project
sammccall added a comment to D87335: [json] Create some llvm::Expected-based accessors.

This is a sensible thing to want and very nice code.
I'm not sure about putting it in JSON.h - there are a few unfortunate aspects that I just don't know how to fix, but limit the benefit which has to be measured against the cost of adding more complexity to the API.

Fri, Sep 18, 9:03 AM · Restricted Project
aaron.ballman accepted D87534: Sema: introduce `__attribute__((__swift_name__))`.

LGTM, though you may want to get a second set of eyes on the swift name validation bits for a more thorough review of that part.

Fri, Sep 18, 9:00 AM · Restricted Project
antiagainst added a reviewer for D87911: [spirv] Move device info from resource limit into target env: ThomasRaoux.
Fri, Sep 18, 9:00 AM · Restricted Project
RKSimon committed rGceadd98c2fd5: [X86][AVX] lowerBuildVectorAsBroadcast - improve i64 BROADCASTM lowering on 32… (authored by RKSimon).
[X86][AVX] lowerBuildVectorAsBroadcast - improve i64 BROADCASTM lowering on 32…
Fri, Sep 18, 9:00 AM
antiagainst requested review of D87911: [spirv] Move device info from resource limit into target env.
Fri, Sep 18, 9:00 AM · Restricted Project
ergawy updated the summary of D87206: [MLIR][SPIRV] Support identified and recursive structs..
Fri, Sep 18, 8:58 AM · Restricted Project
antiagainst accepted D87907: [MLIR][ODS] Add constBuilderCall for TypeArrayAttr.
Fri, Sep 18, 8:57 AM · Restricted Project
rampitec added a comment to D87864: AMDGPU: Check global FP atomics match default FP mode.

I think you need to drop denorm checks and move the check outside of the address space check.

But the DS atomics do respect the denormal mode

Fri, Sep 18, 8:56 AM · Restricted Project
arsenm added a comment to D87864: AMDGPU: Check global FP atomics match default FP mode.

I think you need to drop denorm checks and move the check outside of the address space check.

Fri, Sep 18, 8:55 AM · Restricted Project
morehouse committed rG23bab1eb43d3: [DFSan] Add strpbrk wrapper. (authored by morehouse).
[DFSan] Add strpbrk wrapper.
Fri, Sep 18, 8:54 AM
morehouse closed D87849: [DFSan] Add strpbrk wrapper..
Fri, Sep 18, 8:54 AM · Restricted Project
antiagainst committed rG7b61b1927533: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips. (authored by ergawy).
[MLIR][SPIRV] Create new ctx for deserialization in roundtrips.
Fri, Sep 18, 8:54 AM
antiagainst closed D87692: [MLIR][SPIRV] Create new ctx for deserialization in roundtrips..
Fri, Sep 18, 8:54 AM · Restricted Project
amyk requested review of D87910: [PowerPC] Implement the 128-bit vec_[all|any]_[eq | ne | lt | gt | le | ge] builtins in Clang/LLVM.
Fri, Sep 18, 8:53 AM · Restricted Project, Restricted Project, Restricted Project