Page MenuHomePhabricator
Feed All Stories

Today

arcbbb requested review of D95207: [RISCV] Fix RVV intrinsic CodeGen tests for vrgather.
Thu, Jan 21, 11:35 PM · Restricted Project
curdeius added a comment to D95168: Add InsertBraces option.

True, I was aware of the presence of some of these options, thank you for indicating others. I'm not yet entirely convinced, especially that clang-tidy behaviour would be possibly different.

Thu, Jan 21, 11:31 PM · Restricted Project
burnus added a comment to D94072: [MC][ELF] Fix accepting abbreviated form with sh_flags and sh_entsize.

PING**2

Thu, Jan 21, 11:28 PM · Restricted Project
aguinet added a comment to D89490: Introduce __attribute__((darwin_abi)).

I may be over-reacting to the way the patch seemed to be touching on the C++ ABI in multiple places. My understanding is that ms_abi is just a calling-convention attribute; it's basically "use the (default) calling convention that MSVC would use for this function". If that's all you want, then this is reasonable, although I am worried about creating a new attribute for every system that Wine chooses to target.

Thu, Jan 21, 11:27 PM · Restricted Project, Restricted Project
wenlei added a comment to D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.

With the latest, do you see similar speed up for probe profile and dwarf profile?

Thu, Jan 21, 11:25 PM · Restricted Project
wenlei added a comment to D94110: [CSSPGO][llvm-profgen] Aggregate samples on call frame trie to speed up profile generation.
In D94110#2489390, @wmi wrote:

This change speeds up this by grouping all the call frame within one LBR sample into a trie and aggregating the result(sample counter) on it.

5x speedup shows it is a really impressive improvement. I am wondering whether there is callstack overlap between different LBR samples so you can have further grouping of call frames -- by reusing unwindState. You may also save some cost by reusing the frame trie. IIUC although samples have been aggregated based on callstack, each LBR sample may have multiple callstacks inferred from unwindCall/unwindReturn. If there are callstack overlap between different LBR samples, you may be able to further group them.

Thu, Jan 21, 11:24 PM · Restricted Project
curdeius added a reviewer for D95168: Add InsertBraces option: klimek.
Thu, Jan 21, 11:21 PM · Restricted Project
ArcsinX requested review of D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call.
Thu, Jan 21, 11:20 PM · Restricted Project
kerbowa added inline comments to D85882: [AMDGPU] Update subtarget features for new target ID support.
Thu, Jan 21, 11:18 PM · Restricted Project
grimar added inline comments to D94907: [llvm-nm][ELF] - Make -D display symbol versions..
Thu, Jan 21, 11:13 PM · Restricted Project
xiangzhangllvm added inline comments to D95136: [X86] Fix tile config register spill issue..
Thu, Jan 21, 11:08 PM · Restricted Project
curdeius added inline comments to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Thu, Jan 21, 11:08 PM · Restricted Project
kerbowa updated the diff for D85882: [AMDGPU] Update subtarget features for new target ID support.

Rebase after 560d7e04113bf.

Thu, Jan 21, 11:07 PM · Restricted Project
aemerson committed rG541d98efa222: [AArch64][GlobalISel] Implement widenScalar for signed overflow (authored by porglezomp).
[AArch64][GlobalISel] Implement widenScalar for signed overflow
Thu, Jan 21, 11:06 PM
aemerson closed D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.
Thu, Jan 21, 11:06 PM · Restricted Project
phosek updated the diff for D95205: [CMake][libc] Support cross-compiling libc-hdrgen.
Thu, Jan 21, 11:02 PM · Restricted Project
phosek added a comment to D95205: [CMake][libc] Support cross-compiling libc-hdrgen.

Note that there's one additional issue right now. The TableGen cross-compilation sub-invokes CMake which fails with:

CMake Error at /src/clang-llvm/llvm-project/libc/CMakeLists.txt:49 (message):
Thu, Jan 21, 10:59 PM · Restricted Project
phosek requested review of D95205: [CMake][libc] Support cross-compiling libc-hdrgen.
Thu, Jan 21, 10:57 PM · Restricted Project
khchen added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Thu, Jan 21, 10:53 PM · Restricted Project, Restricted Project
arangasa updated the diff for D94215: [PostRASched] Breaking More CriticalAntiDeps.

Updated llvm/test/CodeGen/X86/critical-anti-dep-breaker.ll to show the whole test in https://reviews.llvm.org/D94215.

Thu, Jan 21, 10:53 PM · Restricted Project
gkm updated the summary of D95204: [lld-macho] switch default to new Darwin port.
Thu, Jan 21, 10:52 PM · Restricted Project, Restricted Project
gkm updated the summary of D95204: [lld-macho] switch default to new Darwin port.
Thu, Jan 21, 10:52 PM · Restricted Project, Restricted Project
hoy updated the diff for D95056: [CSSPGO] LTO option for pseudo probe.

Changing help message for the switch.

Thu, Jan 21, 10:46 PM · Restricted Project
gkm requested review of D95204: [lld-macho] switch default to new Darwin port.
Thu, Jan 21, 10:42 PM · Restricted Project, Restricted Project
khchen updated the diff for D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
  1. address @craig.topper's comment.
  2. rewrite script as python.
Thu, Jan 21, 10:41 PM · Restricted Project, Restricted Project
phosek requested review of D95203: [CMake][libc] Don't do CPU feature detection when cross-compiling.
Thu, Jan 21, 10:39 PM
wenlei accepted D95056: [CSSPGO] LTO option for pseudo probe.

lgtm with minor comment.

Thu, Jan 21, 10:33 PM · Restricted Project
nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Update

Thu, Jan 21, 10:29 PM · Restricted Project
hoy updated the diff for D95056: [CSSPGO] LTO option for pseudo probe.

Addressing Wenlei's feedback.

Thu, Jan 21, 10:27 PM · Restricted Project
hoy added inline comments to D95056: [CSSPGO] LTO option for pseudo probe.
Thu, Jan 21, 10:27 PM · Restricted Project
hanchung committed rG2cb130f76611: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V
Thu, Jan 21, 10:21 PM
hanchung closed D95120: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V.
Thu, Jan 21, 10:21 PM · Restricted Project
wenlei added inline comments to D95056: [CSSPGO] LTO option for pseudo probe.
Thu, Jan 21, 10:19 PM · Restricted Project
hanchung committed rG16d4bbef30a9: [mlir][Linalg] Introduce linalg.pad_tensor op. (authored by hanchung).
[mlir][Linalg] Introduce linalg.pad_tensor op.
Thu, Jan 21, 10:17 PM
hanchung closed D93704: [mlir][Linalg] Introduce linalg.pad_tensor op..
Thu, Jan 21, 10:16 PM · Restricted Project
hanchung updated the diff for D95120: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V.

do not use 'else' after 'return'

Thu, Jan 21, 10:00 PM · Restricted Project
xiangzhangllvm added inline comments to D95136: [X86] Fix tile config register spill issue..
Thu, Jan 21, 9:53 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

In fact, if https://reviews.llvm.org/D95198 is acceptable it is a separate justification for this change. In order to place program headers somewhere other than the lowest VMA in the program image something like this needs to happen.

Thu, Jan 21, 9:49 PM · Restricted Project
MaskRay updated subscribers of D94907: [llvm-nm][ELF] - Make -D display symbol versions..
Thu, Jan 21, 9:49 PM · Restricted Project
MaskRay added inline comments to D94907: [llvm-nm][ELF] - Make -D display symbol versions..
Thu, Jan 21, 9:48 PM · Restricted Project
aeubanks committed rGf374138058b6: [test] Make incorrect-exit-count.ll work under NPM (authored by aeubanks).
[test] Make incorrect-exit-count.ll work under NPM
Thu, Jan 21, 9:46 PM
hoy updated the diff for D95056: [CSSPGO] LTO option for pseudo probe.

Addressing Wei's feedback.

Thu, Jan 21, 9:42 PM · Restricted Project
hoy added inline comments to D95056: [CSSPGO] LTO option for pseudo probe.
Thu, Jan 21, 9:42 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

If the direction of the patch is acceptable I can provide a detailed analysis of each required testcase adjustment.

Thu, Jan 21, 9:39 PM · Restricted Project
jdoerfert added inline comments to D95155: [libomptarget] Build cuda plugin without cuda installed locally.
Thu, Jan 21, 9:36 PM · Restricted Project
pattop added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

For out-of-order-sections.s, you could just swap foo and bar.

Thu, Jan 21, 9:36 PM · Restricted Project
MaskRay updated the diff for D94888: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++.

Adopt rupprecht's suggestion

Thu, Jan 21, 9:26 PM · Restricted Project
dexonsmith requested review of D95202: ADT: Use 'using' to inherit assign and append in SmallString.
Thu, Jan 21, 9:17 PM · Restricted Project, Restricted Project
MaskRay added a comment to D95199: [ELF] Write output sections in PT_LOAD segment order.

For out-of-order-sections.s, you could just swap foo and bar. The few updated tests seem to have undesired sh_offset changes.

Thu, Jan 21, 9:16 PM · Restricted Project
mehdi_amini accepted D95201: Add more explicit assert for failures.

LGTM
(fix the description before pushing)

Thu, Jan 21, 9:15 PM · Restricted Project
aeubanks committed rG6699029b67bf: [NewPM][opt] Run the "default" AA pipeline by default (authored by aeubanks).
[NewPM][opt] Run the "default" AA pipeline by default
Thu, Jan 21, 9:09 PM
jpienaar requested review of D95201: Add more explicit assert for failures.
Thu, Jan 21, 9:09 PM · Restricted Project
vitalybuka added inline comments to D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Thu, Jan 21, 9:02 PM · Restricted Project
lhames committed rGf9b5f6937ebe: [JITLink][ELF/x86-64] Range check 32-bit relocs. (authored by lhames).
[JITLink][ELF/x86-64] Range check 32-bit relocs.
Thu, Jan 21, 9:00 PM
vitalybuka added inline comments to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Thu, Jan 21, 8:55 PM · Restricted Project
vitalybuka added inline comments to D95183: [LSan] Introduce a callback mechanism to allow adding data reachable from ThreadContexts to the frontier..
Thu, Jan 21, 8:53 PM · Restricted Project
akyrtzi committed rGb0e89906f5b7: [ASTReader] Allow controlling separately whether validation should be disabled… (authored by akyrtzi).
[ASTReader] Allow controlling separately whether validation should be disabled…
Thu, Jan 21, 8:46 PM
akyrtzi closed D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.
Thu, Jan 21, 8:46 PM · Restricted Project
MaskRay added a comment to D95163: [WebAssembly] Test that invalid symbol/relocation types generate errors.

In ELF, we usually use yaml2obj to generate invalid object files, instead of checking in precanned binaries. You can find lots of grimar's changes migrating away from binaries.

Thu, Jan 21, 8:44 PM · Restricted Project
hubert.reinterpretcast added inline comments to D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code.
Thu, Jan 21, 8:38 PM · Restricted Project
mtrofin committed rGc042aff8860d: [NFC] Disallow unused prefixes under llvm/test (authored by mtrofin).
[NFC] Disallow unused prefixes under llvm/test
Thu, Jan 21, 8:32 PM
mtrofin closed D95111: [NFC] Disallow unused prefixes under llvm/test.
Thu, Jan 21, 8:32 PM · Restricted Project
aeubanks committed rGa11bf9a7fbd3: [AMDGPU][Inliner] Remove amdgpu-inline and add a new TTI inline hook (authored by aeubanks).
[AMDGPU][Inliner] Remove amdgpu-inline and add a new TTI inline hook
Thu, Jan 21, 8:29 PM
aeubanks closed D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add a new TTI inline hook.
Thu, Jan 21, 8:29 PM · Restricted Project
critson updated the summary of D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
Thu, Jan 21, 8:23 PM · Restricted Project
MaskRay accepted D95111: [NFC] Disallow unused prefixes under llvm/test.

Thanks!

Thu, Jan 21, 8:21 PM · Restricted Project
JDevlieghere added a reviewer for D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem: nathawes.
Thu, Jan 21, 8:21 PM · Restricted Project
aeubanks added a reverting change for rGbe611431cd1f: [NewPM][opt] Run the "default" AA pipeline by default: rGba9b4ea4eeae: Revert "[NewPM][opt] Run the "default" AA pipeline by default".
Thu, Jan 21, 8:17 PM
aeubanks committed rGba9b4ea4eeae: Revert "[NewPM][opt] Run the "default" AA pipeline by default" (authored by aeubanks).
Revert "[NewPM][opt] Run the "default" AA pipeline by default"
Thu, Jan 21, 8:17 PM
aeubanks added a reverting change for D95117: [NewPM][opt] Run the "default" AA pipeline by default: rGba9b4ea4eeae: Revert "[NewPM][opt] Run the "default" AA pipeline by default".
Thu, Jan 21, 8:17 PM · Restricted Project
qcolombet added a comment to D86836: Support a list of CostPerUse values.

I'll try to take a look by end of next week.

Thu, Jan 21, 8:17 PM · Restricted Project
jpienaar committed rGaee622fa200d: [mlir] Enable passing crash reproducer stream factory method (authored by jpienaar).
[mlir] Enable passing crash reproducer stream factory method
Thu, Jan 21, 8:15 PM
jpienaar closed D94868: [mlir] Enable passing crash reproducer stream factory method.
Thu, Jan 21, 8:14 PM · Restricted Project, Restricted Project
ruiling accepted D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.

LGTM, Let's wait some time to see if anybody else has more comments. And make sure to update the commit message before push.

Fix this by moving lowering of llvm.amdgcn.init.exec post-RA

Thu, Jan 21, 8:11 PM · Restricted Project
kazu committed rG551aaa24afe6: [llvm] Use isDigit (NFC) (authored by kazu).
[llvm] Use isDigit (NFC)
Thu, Jan 21, 8:00 PM
kazu committed rGcfa241680fd6: [llvm] Don't include StringSwitch.h where unnecessary (NFC) (authored by kazu).
[llvm] Don't include StringSwitch.h where unnecessary (NFC)
Thu, Jan 21, 8:00 PM
kazu committed rGc5c4dbd27907: [CodeGen] Use llvm::append_range (NFC) (authored by kazu).
[CodeGen] Use llvm::append_range (NFC)
Thu, Jan 21, 8:00 PM
mtrofin added a comment to D95111: [NFC] Disallow unused prefixes under llvm/test.

gentle reminder - thanks!

Thu, Jan 21, 7:55 PM · Restricted Project
nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Add test

Thu, Jan 21, 7:51 PM · Restricted Project
nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

I notice a lack of any explicitly co_return-related tests and/or code in this patch. I'm just going to assume that is fine.

Thu, Jan 21, 7:48 PM · Restricted Project
JDevlieghere added inline comments to D95188: [VFS] Fix inconsistencies between relative paths and fallthrough in the RedirectingFileSystem.
Thu, Jan 21, 7:47 PM · Restricted Project
aeubanks committed rGbe611431cd1f: [NewPM][opt] Run the "default" AA pipeline by default (authored by aeubanks).
[NewPM][opt] Run the "default" AA pipeline by default
Thu, Jan 21, 7:47 PM
aeubanks closed D95117: [NewPM][opt] Run the "default" AA pipeline by default.
Thu, Jan 21, 7:47 PM · Restricted Project
HsiangKai committed rG5d354220d44f: [RISCV] Correct DWARF number for vector registers. (authored by HsiangKai).
[RISCV] Correct DWARF number for vector registers.
Thu, Jan 21, 7:46 PM
HsiangKai closed D94749: [RISCV] Correct DWARF number for vector registers..
Thu, Jan 21, 7:46 PM · Restricted Project
MaskRay updated the diff for D95200: [test] Add basic _Unwind_ForcedUnwind + exception tests.

simplify

Thu, Jan 21, 7:44 PM · Restricted Project
kito-cheng added a comment to D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..

@jrtc27 just let you know I have same concern too, that's one major reason why we don't upstream those extension on GNU toolchain... we are intend to introduce an internal revision number on ELF attribute in near future, e.g. v-ext 0.9.1 / v0p9p1 to prevent compatible issue here.

Thu, Jan 21, 7:43 PM · Restricted Project
critson updated the diff for D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
  • Update test to avoid GlobalISel issue on Windows
  • Tighten tests
Thu, Jan 21, 7:41 PM · Restricted Project
MaskRay requested review of D95200: [test] Add basic _Unwind_ForcedUnwind + exception tests.
Thu, Jan 21, 7:40 PM · Restricted Project
GMNGeoffrey added a comment to D94451: Proposal for adding Bazel build configuration in-tree with peripheral support.

Thanks for the updates. I think this proposal is ready to send to Chris (Step 4).

Thu, Jan 21, 7:39 PM
jrtc27 added a comment to D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..

(Their problem stems from having 1.0 drafts before they've resolved all the outstanding issues and frozen the instruction set; if they didn't jump the gun then things would be saner for people implementing it)

Thu, Jan 21, 7:31 PM · Restricted Project
HsiangKai updated the diff for D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
  • Address @craig.topper's comments.
  • Update the test cases to use v8-v23 as arguments.
Thu, Jan 21, 7:30 PM · Restricted Project
tianshilei1992 accepted D95093: [libomptarget][devicertl] Drop templated atomic functions.

LGTM with some nits. We might want to rewrite these atomics with LLVM intrinsics.

Thu, Jan 21, 7:30 PM · Restricted Project
craig.topper committed rGf8f1b20e6b30: [RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic… (authored by craig.topper).
[RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic…
Thu, Jan 21, 7:30 PM
craig.topper closed D95189: [RISCV] Don't create LMUL=8 pseudo instructions for ternary widening arithmetic instructions.
Thu, Jan 21, 7:30 PM · Restricted Project
wmi added inline comments to D95056: [CSSPGO] LTO option for pseudo probe.
Thu, Jan 21, 7:30 PM · Restricted Project
jrtc27 added a comment to D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..

There are a lot of "Resolve for v1.0" issues open against the spec still. Are we sure we want to brand this as 1.0? It will end up as such in the ELF attributes and thus be deemed compatible with future "real" 1.0 binaries.

We could keep the version number as v0.9 or do you think it is better to keep it as v1.020201218.

Thu, Jan 21, 7:29 PM · Restricted Project
tianshilei1992 updated the diff for D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW.

Droped the forward declaration and rewrote CUDA intrinsics with LLVM instrinsics

Thu, Jan 21, 7:29 PM · Restricted Project, Restricted Project
craig.topper accepted D94749: [RISCV] Correct DWARF number for vector registers..

LGTM

Thu, Jan 21, 7:29 PM · Restricted Project
HsiangKai added a comment to D95148: [RISCV] Spilling for RISC-V V extension. (2nd version).

Is this dependent on the frame lowering patch to emit the csrr vlenb?

Thu, Jan 21, 7:27 PM · Restricted Project