Page MenuHomePhabricator
Feed All Stories

Today

Harbormaster failed remote builds in B52261: Diff 255849 for D77272: Clean up usages of asserting vector getters in Type!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52267: Diff 255856 for D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.!
Tue, Apr 7, 5:28 PM · Restricted Project, Restricted Project
Harbormaster failed remote builds in B52271: Diff 255861 for D77695: [SVE] Remove isScalable from Bitcode!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52270: Diff 255860 for D77694: [WIP][RISCV][ELF] Linker relaxation support!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52266: Diff 255855 for D77690: [SVE] Remove VectorType::isScalable()!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52269: Diff 255858 for D77692: [SVE] Remove calls to VectorType::isScalable from analysis!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52264: Diff 255853 for D77689: Codegen for call setup!
Tue, Apr 7, 5:28 PM · Restricted Project
Harbormaster failed remote builds in B52268: Diff 255857 for D77691: [SVE] Remove calls to isScalable from IR!
Tue, Apr 7, 5:28 PM · Restricted Project
delcypher updated the diff for D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..

Tweak description.

Tue, Apr 7, 5:27 PM · Restricted Project
delcypher added a comment to D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..

@eugenis @vitalybuka @kcc Is it okay to land this?

Tue, Apr 7, 5:27 PM · Restricted Project
lattner added a comment to D77683: [Docs] Make code review policy clearer about requested pre-commit reviews.

I don't really understand what this is getting at, so I'd recommend rewording this a bit for clarity. Would something along the lines of this capture the intended meaning?:

Tue, Apr 7, 5:27 PM · Restricted Project
delcypher updated the diff for D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..

Remove unneeded macro undefinition.

Tue, Apr 7, 5:27 PM · Restricted Project
delcypher added a comment to D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..

@yln Is the comment I added clear enough?

Tue, Apr 7, 5:27 PM · Restricted Project
delcypher added inline comments to D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..
Tue, Apr 7, 5:27 PM · Restricted Project
delcypher created D77696: [Darwin] Teach `AtosSymbolizerProcess` to work on a copy of the environment..
Tue, Apr 7, 5:27 PM · Restricted Project
hubert.reinterpretcast added inline comments to D77683: [Docs] Make code review policy clearer about requested pre-commit reviews.
Tue, Apr 7, 5:27 PM · Restricted Project
delcypher updated the diff for D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..

Add comment explaining loading of dylib.

Tue, Apr 7, 5:27 PM · Restricted Project
rampitec added a comment to D77693: [AMDGPU] Expand vector trunc stores from i16 to i8.

Can merge with the existing store tests

Tue, Apr 7, 5:27 PM
hctim added inline comments to D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled..
Tue, Apr 7, 5:27 PM · Restricted Project
Harbormaster failed remote builds in B52265: Diff 255854 for D74651: Add IR constructs for inalloca replacement llvm.call.setup!
Tue, Apr 7, 4:56 PM · Restricted Project
danalbert committed rG0b43db5202ee: Reset more globalMemCounters. (authored by danalbert).
Reset more globalMemCounters.
Tue, Apr 7, 4:56 PM
efriedma committed rG565b56a72cff: [NFC] Clean up uses of LoadInst constructor. (authored by efriedma).
[NFC] Clean up uses of LoadInst constructor.
Tue, Apr 7, 4:55 PM
danalbert closed D77681: Reset more globalMemCounters..
Tue, Apr 7, 4:55 PM · Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rG6fa0d0ae11a2: [gn build] Port 1adeeabb79a (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port 1adeeabb79a
Tue, Apr 7, 4:55 PM
dsanders committed rG1adeeabb79af: Add MIR-level debugify with only locations support for now (authored by dsanders).
Add MIR-level debugify with only locations support for now
Tue, Apr 7, 4:55 PM
davide committed rGf30ebf437851: [ManualDWARFIndex] Remove dead code, in preparation for moving this function. (authored by davide).
[ManualDWARFIndex] Remove dead code, in preparation for moving this function.
Tue, Apr 7, 4:55 PM
dsanders closed D77446: Add MIR-level debugify with only locations support for now.
Tue, Apr 7, 4:55 PM · Restricted Project
Harbormaster failed remote builds in B52258: Diff 255845 for D77688: [CUDA] Improve testing of libdevice detection.!
Tue, Apr 7, 4:55 PM · Restricted Project
Harbormaster failed remote builds in B52248: Diff 255830 for D77683: [Docs] Make code review policy clearer about requested pre-commit reviews!
Tue, Apr 7, 4:55 PM · Restricted Project
ctetreau created D77695: [SVE] Remove isScalable from Bitcode.
Tue, Apr 7, 4:55 PM · Restricted Project
jrtc27 created D77694: [WIP][RISCV][ELF] Linker relaxation support.
Tue, Apr 7, 4:55 PM · Restricted Project
arsenm added a comment to D77693: [AMDGPU] Expand vector trunc stores from i16 to i8.

Can merge with the existing store tests

Tue, Apr 7, 4:55 PM
rampitec created D77693: [AMDGPU] Expand vector trunc stores from i16 to i8.
Tue, Apr 7, 4:54 PM
arsenm added inline comments to D77683: [Docs] Make code review policy clearer about requested pre-commit reviews.
Tue, Apr 7, 4:54 PM · Restricted Project
ctetreau created D77692: [SVE] Remove calls to VectorType::isScalable from analysis.
Tue, Apr 7, 4:54 PM · Restricted Project
aartbik accepted D77253: [MLIR][Vector] Update ShapeCastOp folder to use producer-consumer value forwarding..
Tue, Apr 7, 4:54 PM · Restricted Project
ctetreau created D77691: [SVE] Remove calls to isScalable from IR.
Tue, Apr 7, 4:54 PM · Restricted Project
browneee updated the diff for D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector..

Fix build errors. Missed -DLLVM_ENABLE_PROJECTS in previous local test builds.

Tue, Apr 7, 4:54 PM · Restricted Project, Restricted Project
ctetreau created D77690: [SVE] Remove VectorType::isScalable().
Tue, Apr 7, 4:54 PM · Restricted Project
aeubanks updated the summary of D77689: Codegen for call setup.
Tue, Apr 7, 4:54 PM · Restricted Project
aeubanks updated the diff for D74651: Add IR constructs for inalloca replacement llvm.call.setup.

Add extra verifier check

Tue, Apr 7, 4:54 PM · Restricted Project
aeubanks created D77689: Codegen for call setup.
Tue, Apr 7, 4:54 PM · Restricted Project
aeubanks added a child revision for D74651: Add IR constructs for inalloca replacement llvm.call.setup: D77689: Codegen for call setup.
Tue, Apr 7, 4:54 PM · Restricted Project
rahmanl added a comment to D76954: LLVM support for BB-cluster sections.

@efriedma Would you please take a look at this patch? Any feedback is appreciated.

Tue, Apr 7, 4:54 PM · Restricted Project
asbirlea updated the diff for D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff..

Name anonymous namespace.

Tue, Apr 7, 4:54 PM · Restricted Project
ctetreau added inline comments to D77587: [SVE] Add new VectorType subclasses.
Tue, Apr 7, 4:54 PM · Restricted Project
bmoody added a comment to D77027: Make BitVector::operator== return false for different-sized vectors.

Regarding PackedVector::operator==, this code is covered by the PackedVector unit test but not thoroughly enough to catch the bug.

Tue, Apr 7, 4:54 PM · Restricted Project
asbirlea added inline comments to D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff..
Tue, Apr 7, 4:54 PM · Restricted Project
dsanders added a comment to D77446: Add MIR-level debugify with only locations support for now.
In D77446#1967893, @vsk wrote:

Thanks, lgtm!

Later on, I think we'll want to insert DBG_VALUE insts as well, but this looks very useful as-is.

Tue, Apr 7, 4:54 PM · Restricted Project
Harbormaster failed remote builds in B52253: Diff 255840 for D77685: MachineFunction: Copy call site info when duplicating insts!
Tue, Apr 7, 4:24 PM · Restricted Project
Harbormaster failed remote builds in B52243: Diff 255824 for D77646: [PowerPC] Fold vector merges of swapped vectors to merge the opposite half!
Tue, Apr 7, 4:23 PM · Restricted Project
jdoerfert added inline comments to D77683: [Docs] Make code review policy clearer about requested pre-commit reviews.
Tue, Apr 7, 4:23 PM · Restricted Project
MaskRay committed rG624654fd6470: [VE] Migrate to the getMachineMemOperand overload using llvm::Align (authored by MaskRay).
[VE] Migrate to the getMachineMemOperand overload using llvm::Align
Tue, Apr 7, 4:23 PM
rriddle committed rG8b7e669e68f9: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes (authored by rriddle).
[mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes
Tue, Apr 7, 4:23 PM
arsenm committed rG6011627f5118: CodeGen: More conversions to use Register (authored by arsenm).
CodeGen: More conversions to use Register
Tue, Apr 7, 4:23 PM
rriddle closed D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Tue, Apr 7, 4:23 PM · Restricted Project
Harbormaster failed remote builds in B52246: Diff 255828 for D77683: [Docs] Make code review policy clearer about requested pre-commit reviews!
Tue, Apr 7, 4:23 PM · Restricted Project
Harbormaster failed remote builds in B52255: Diff 255839 for D77687: [SelectionDAG] Fix usage of Align constructing MachineMemOperands!
Tue, Apr 7, 4:23 PM · Restricted Project
jingham added a comment to D77444: [commands] Support autorepeat in SBCommands.

This looks good to me, except that instead of leaving all the other variants of AddCommand, they should funnel through the one that takes the most arguments. It was poor form to leave two around and more so now that there's three.

Tue, Apr 7, 4:22 PM · Restricted Project
wallace added a comment to D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request.

Ping ping. This will fix some existing issues reported by users :)

Tue, Apr 7, 4:22 PM · Restricted Project
ctetreau updated the diff for D77274: Clean up usages of asserting vector getters in Type.

rebase. Mention asmparser in commit message

Tue, Apr 7, 4:22 PM · Restricted Project
asaadaldien added inline comments to D77678: [mlir][Linalg] Add loop.parallel lowering for all Linalg Ops..
Tue, Apr 7, 4:22 PM · Restricted Project
efriedma updated subscribers of D77687: [SelectionDAG] Fix usage of Align constructing MachineMemOperands.
Tue, Apr 7, 4:22 PM · Restricted Project
bd1976llvm updated the diff for D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

Use IR rather than C for the clang test.
I was able to simplify the clang patch somewhat as a "lowering error" isn't any more revealing than just emitting a generic "backend error".

Tue, Apr 7, 4:22 PM · Restricted Project
EricWF accepted D77681: Reset more globalMemCounters..
Tue, Apr 7, 4:22 PM · Restricted Project
bd1976llvm added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

I am mostly fine with the LLVM CodeGen/MC side change, but the clang side change can probably be moved to a subsequent change. For the test/clang/CodeGen/ test, we may want to test .ll -> .s instead, not .c -> .s

Tue, Apr 7, 4:22 PM · Restricted Project
ctetreau updated the diff for D77272: Clean up usages of asserting vector getters in Type.

rebase, mention codegen in commit message

Tue, Apr 7, 4:22 PM · Restricted Project
efriedma added inline comments to D77276: Clean up usages of asserting vector getters in Type.
Tue, Apr 7, 4:22 PM · Restricted Project
nickdesaulniers added a comment to D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs.

Looks like GCC warns on everything but the last unused expression (the last one being the return statement) - only warning on that last one if it's ultimately unused by the statement expression function call, as it were (& is annotated warn_unused_result). Basically, it models it like a function in a way that Clang perhaps does not?

Tue, Apr 7, 4:22 PM · Restricted Project
efriedma accepted D77266: Clean up usages of asserting vector getters in Type.

LGTM

Tue, Apr 7, 4:22 PM · Restricted Project
tra created D77688: [CUDA] Improve testing of libdevice detection..
Tue, Apr 7, 4:22 PM · Restricted Project
ctetreau updated the diff for D77273: Clean up usages of asserting vector getters in Type.

fix permissions issue

Tue, Apr 7, 4:22 PM · Restricted Project
rsmith added inline comments to D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..
Tue, Apr 7, 4:22 PM · Restricted Project
dblaikie added a comment to D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs.

Looks like GCC warns on everything but the last unused expression (the last one being the return statement) - only warning on that last one if it's ultimately unused by the statement expression function call, as it were (& is annotated warn_unused_result). Basically, it models it like a function in a way that Clang perhaps does not?

Tue, Apr 7, 4:22 PM · Restricted Project
ctetreau updated the diff for D77271: Clean up usages of asserting vector getters in Type.

rebase, mention arm in commit message

Tue, Apr 7, 4:22 PM · Restricted Project
nathanchance added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

These are new tests how do you get the generic lld driver to work?

Tue, Apr 7, 4:22 PM · Restricted Project
efriedma added inline comments to D77587: [SVE] Add new VectorType subclasses.
Tue, Apr 7, 4:22 PM · Restricted Project
asaadaldien accepted D77676: [mlir][Linalg] Use subview instead of linalg.slice in Promotion.cpp.
Tue, Apr 7, 4:22 PM · Restricted Project
arsenm accepted D77268: Clean up usages of asserting vector getters in Type.
Tue, Apr 7, 4:22 PM · Restricted Project
MaskRay committed rGd2ef8c1f2ca3: [ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker() (authored by MaskRay).
[ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker()
Tue, Apr 7, 3:50 PM
danalbert committed rG50280c18958b: Revert "Don't expose unavailable cstdio functions." (authored by danalbert).
Revert "Don't expose unavailable cstdio functions."
Tue, Apr 7, 3:50 PM
MaskRay closed D74751: [ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker().
Tue, Apr 7, 3:50 PM · Restricted Project
MaskRay committed rG2f8fb4d1cde8: [VE] Adapt aa26dd985848364df01d3f8f0f3eaccfd5ee80dc and… (authored by MaskRay).
[VE] Adapt aa26dd985848364df01d3f8f0f3eaccfd5ee80dc and…
Tue, Apr 7, 3:50 PM
danalbert added a reverting change for rGff87813715ec: Don't expose unavailable cstdio functions.: rG50280c18958b: Revert "Don't expose unavailable cstdio functions.".
Tue, Apr 7, 3:50 PM
Harbormaster failed remote builds in B52247: Diff 255829 for D77266: Clean up usages of asserting vector getters in Type!
Tue, Apr 7, 3:50 PM · Restricted Project
Harbormaster failed remote builds in B52249: Diff 255831 for D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.!
Tue, Apr 7, 3:50 PM · Restricted Project, Restricted Project
Harbormaster failed remote builds in B52233: Diff 255813 for D77326: 1/2: [nfc] [lldb] Unindent code!
Tue, Apr 7, 3:49 PM · Restricted Project
Harbormaster failed remote builds in B52231: Diff 255811 for D77276: Clean up usages of asserting vector getters in Type!
Tue, Apr 7, 3:49 PM · Restricted Project
benvanik accepted D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Tue, Apr 7, 3:49 PM · Restricted Project
rsmith updated the diff for D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..

Remove separately-committed cleanup commits.

Tue, Apr 7, 3:49 PM · Restricted Project
ctetreau updated the diff for D77275: Clean up usages of asserting vector getters in Type.

update commit message to mention bitreader

Tue, Apr 7, 3:49 PM · Restricted Project
hubert.reinterpretcast added inline comments to D77683: [Docs] Make code review policy clearer about requested pre-commit reviews.
Tue, Apr 7, 3:49 PM · Restricted Project
mehdi_amini accepted D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Tue, Apr 7, 3:49 PM · Restricted Project
mravishankar added a comment to D77678: [mlir][Linalg] Add loop.parallel lowering for all Linalg Ops..

The utility function part looks like quite a massive change for just the purpose of getting the xxxForOp from their respective induction variables.
Why is this a good tradeoff (also, it is not tested FWICT)?

Tue, Apr 7, 3:49 PM · Restricted Project
rriddle created D77686: [mlir][AsmFormat] Avoid invalidating the iterator when verifying attributes.
Tue, Apr 7, 3:49 PM · Restricted Project
efriedma created D77687: [SelectionDAG] Fix usage of Align constructing MachineMemOperands.
Tue, Apr 7, 3:49 PM · Restricted Project
vsk created D77685: MachineFunction: Copy call site info when duplicating insts.
Tue, Apr 7, 3:49 PM · Restricted Project
rsmith added inline comments to D75726: [ConstExprPreter] Updated constant interpreter documentation.
Tue, Apr 7, 3:49 PM · Restricted Project
bcain added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

Since this isn't something that can be always known in advance I think the testcase should just be removed.

Tue, Apr 7, 3:49 PM · Restricted Project
MaskRay added a comment to D77672: Support a few more SPARCv9 relocations.

My immediate reaction is "isn't Sparc an abandoned architecture?" See https://en.wikipedia.org/wiki/SPARC and https://lists.freebsd.org/pipermail/freebsd-sparc64/2020-January/010192.html

Though, no objection. You may still need some basic tests, similar to test/ELF/ppc32-* I tried hard to keep the number of tests small yet complete. Does sparc64 use TLS variant 2?

For FreeBSD, yes, and mostly within LLVM (certainly nobody really uses LLD). The non-release Debian architecture is still going strong though. SPARC (32-bit and 64-bit) is basically the same as IA-32 (although not with the weird calling convention and triple leading underscores), and one of the architectures described in Drepper's original TLS white paper, so yes, variant II.

Tue, Apr 7, 3:49 PM · Restricted Project