Page MenuHomePhabricator
Feed All Stories

Today

mstorsjo added reviewers for D59694: [PPC64][libunwind] Fix r2 not properly restored: EricWF, mclow.lists, ldionne.
Sun, Mar 24, 4:32 AM · Restricted Project
RKSimon added reviewers for D59744: Fix i386 ABI "__m64" type bug: andreadb, gbedwell.
Sun, Mar 24, 3:41 AM · Restricted Project
nikic added a comment to D59716: [ConstantRange] Add full() + empty() named constructors (NFC).

@lebedev.ri Thanks for the suggestion, I agree that getFull() and getEmpty() make more sense given that APInt uses getXXX() constructors so extensively.

Sun, Mar 24, 2:38 AM · Restricted Project
nikic committed rG977934f00f7c: [ConstantRange] Add getFull() + getEmpty() named constructors; NFC (authored by nikic).
[ConstantRange] Add getFull() + getEmpty() named constructors; NFC
Sun, Mar 24, 2:35 AM
nikic committed rL356852: [ConstantRange] Add getFull() + getEmpty() named constructors; NFC.
[ConstantRange] Add getFull() + getEmpty() named constructors; NFC
Sun, Mar 24, 2:35 AM
nikic closed D59716: [ConstantRange] Add full() + empty() named constructors (NFC).
Sun, Mar 24, 2:35 AM · Restricted Project
hintonda added a comment to D59746: [LibTooling] Fix '-h' option.

A better alternative would have been to add a cl::aliasopt for '-h' in llvm's CommandLineParser when '-help' was first added. However, that's no longer possible since some llvm based tools already use '-h' for other purposes.

Sun, Mar 24, 1:31 AM · Restricted Project
wxiao3 updated the summary of D59744: Fix i386 ABI "__m64" type bug.
Sun, Mar 24, 1:10 AM · Restricted Project
hintonda created D59746: [LibTooling] Fix '-h' option.
Sun, Mar 24, 1:10 AM · Restricted Project
MaskRay committed rG54ce1b18c5f7: [pp-trace] Delete redundant clang:: (authored by MaskRay).
[pp-trace] Delete redundant clang::
Sun, Mar 24, 12:31 AM
MaskRay committed rL356851: [pp-trace] Delete redundant clang::.
[pp-trace] Delete redundant clang::
Sun, Mar 24, 12:30 AM
MaskRay committed rCTE356851: [pp-trace] Delete redundant clang::.
[pp-trace] Delete redundant clang::
Sun, Mar 24, 12:30 AM
MaskRay committed rGbe860a04b62a: [pp-trace] Wrap code in clang::pp_trace (authored by MaskRay).
[pp-trace] Wrap code in clang::pp_trace
Sun, Mar 24, 12:21 AM
MaskRay committed rL356850: [pp-trace] Wrap code in clang::pp_trace.
[pp-trace] Wrap code in clang::pp_trace
Sun, Mar 24, 12:20 AM
MaskRay committed rCTE356850: [pp-trace] Wrap code in clang::pp_trace.
[pp-trace] Wrap code in clang::pp_trace
Sun, Mar 24, 12:20 AM

Yesterday

MaskRay committed rCTE356849: [pp-trace] Modernize the code.
[pp-trace] Modernize the code
Sat, Mar 23, 11:57 PM
MaskRay committed rG10f69948fb9d: [pp-trace] Modernize the code (authored by MaskRay).
[pp-trace] Modernize the code
Sat, Mar 23, 11:55 PM
MaskRay committed rL356849: [pp-trace] Modernize the code.
[pp-trace] Modernize the code
Sat, Mar 23, 11:53 PM
plotfi created D59745: [NFC] Move writeFuncOrVarName out of class CodegenNameGenerator so that it can be reused more easily. .
Sat, Mar 23, 11:05 PM · Restricted Project
aqjune added a comment to D59349: Let CorrelatedValuePropagation preserve LazyValueInfo.

I couldn't find ready for review option from anywhere :( 'Add Action...' dropdown menu contains Plan Changes and Abandon Revision only.

Sat, Mar 23, 10:04 PM · Restricted Project
aqjune added inline comments to D59349: Let CorrelatedValuePropagation preserve LazyValueInfo.
Sat, Mar 23, 9:47 PM · Restricted Project
aqjune updated the diff for D59349: Let CorrelatedValuePropagation preserve LazyValueInfo.

Removes eraseValue() calls

Sat, Mar 23, 9:39 PM · Restricted Project
craig.topper added reviewers for D59744: Fix i386 ABI "__m64" type bug: RKSimon, rnk.
Sat, Mar 23, 9:14 PM · Restricted Project
wxiao3 created D59744: Fix i386 ABI "__m64" type bug.
Sat, Mar 23, 9:08 PM · Restricted Project
dlrobertson updated the diff for D59653: [NFC] Add tests for ssubo X, C -> saddo X, -C.

Added test cases

Sat, Mar 23, 8:11 PM · Restricted Project
tra added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

I am unsure whether the problem with the build system as referred to by the remark "switch to -pthread once the rest of the build system can deal with it" is now solved, though. @tra, any idea?

Sat, Mar 23, 8:05 PM · Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

return back memcpy, it is faster for long integers in about 10%

Sat, Mar 23, 7:47 PM · Restricted Project
sbc100 added reviewers for D59743: [WebAssembly] Don't use default GetLinkerPath: dschuff, phosek.
Sat, Mar 23, 6:30 PM · Restricted Project
sbc100 created D59743: [WebAssembly] Don't use default GetLinkerPath.
Sat, Mar 23, 6:29 PM · Restricted Project
sbc100 added a comment to D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory.

Fixed in rL356847.

Sat, Mar 23, 6:08 PM · Restricted Project, Restricted Project
craig.topper committed rG88f4054f48c5: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc. (authored by craig.topper).
[X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.
Sat, Mar 23, 5:57 PM
ctopper committed rL356848: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc..
[X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.
Sat, Mar 23, 5:56 PM
ctopper committed rC356848: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc..
[X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.
Sat, Mar 23, 5:56 PM
Diffusion closed D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc..
Sat, Mar 23, 5:56 PM · Restricted Project
sbc100 committed rG4b7bf6a02c97: [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of… (authored by sbc100).
[WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of…
Sat, Mar 23, 5:03 PM
sbc committed rC356847: [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of….
[WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of…
Sat, Mar 23, 5:03 PM
sbc committed rL356847: [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of….
[WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of…
Sat, Mar 23, 5:03 PM
thakis committed rGd48c8fdd30ac: gn build: Merge r356820 (authored by thakis).
gn build: Merge r356820
Sat, Mar 23, 4:24 PM
RKSimon accepted D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc..

LGTM - cheers

Sat, Mar 23, 4:24 PM · Restricted Project
nico committed rL356846: gn build: Merge r356820.
gn build: Merge r356820
Sat, Mar 23, 4:21 PM
Herald added a project to D53945: [TextAPI] TBD Reader/Writer: Restricted Project.

Out of interest, why aren't most of the tests for this lit tests? The usual llvm way of testing stuff is to write a small llvm tool using your library (which will be useful outside of a testing context too) and then use that to write lit tests.

Looks like this is now happening (rL350341). Are most of the unit tests going to move to lit tests now?

This is a different YAML format from r350341 but unittest is running as part of the lit as well, right?
A new tool can be created to read MachO YAML file but I want to understand your real concern here.

Sat, Mar 23, 4:19 PM · Restricted Project
hintonda added a comment to D17407: [Sema] PR25755 Handle out of order designated initializers .
Sat, Mar 23, 4:17 PM · Restricted Project
thakis committed rG3e016d48c41a: gn build: Add build files for modularize and pp-trace (authored by thakis).
gn build: Add build files for modularize and pp-trace
Sat, Mar 23, 4:16 PM
nico committed rL356845: gn build: Add build files for modularize and pp-trace.
gn build: Add build files for modularize and pp-trace
Sat, Mar 23, 4:15 PM
Diffusion closed D59701: gn build: Add build files for modularize and pp-trace.
Sat, Mar 23, 4:15 PM · Restricted Project
lebedev.ri added inline comments to D59467: [clang] Adding the Likely Attribute from C++2a to AST.
Sat, Mar 23, 2:48 PM · Restricted Project
dim updated subscribers of D59451: Fix gettid warnings and one test on FreeBSD.

Using CMake's own FindThreads package is obviously the correct solution for finding the right compiler and linker options for enabling threading.

Sat, Mar 23, 2:02 PM · Restricted Project
arsenm added inline comments to D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 2:02 PM · Restricted Project
arsenm added inline comments to D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Sat, Mar 23, 1:49 PM · Restricted Project
mstorsjo created D59742: [llvm-dlltool] Set a proper machine type for weak symbol object files.
Sat, Mar 23, 1:45 PM · Restricted Project
aheejin updated the summary of D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 1:00 PM · Restricted Project
hubert.reinterpretcast created D59741: [lit] Set shlibpath_var on AIX.
Sat, Mar 23, 12:59 PM · Restricted Project
aheejin added a parent revision for D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 12:59 PM · Restricted Project
aheejin added a child revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Sat, Mar 23, 12:59 PM · Restricted Project
aheejin added a child revision for D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 12:58 PM · Restricted Project
aheejin added parent revisions for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement, D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Sat, Mar 23, 12:58 PM · Restricted Project
aheejin added a child revision for D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 12:58 PM · Restricted Project
aheejin created D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Sat, Mar 23, 12:58 PM · Restricted Project
Tyker added a comment to D59467: [clang] Adding the Likely Attribute from C++2a to AST.

@riccibruno Done

Sat, Mar 23, 12:33 PM · Restricted Project
aheejin added inline comments to D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Sat, Mar 23, 12:31 PM · Restricted Project
Tyker updated the diff for D59467: [clang] Adding the Likely Attribute from C++2a to AST.
Sat, Mar 23, 12:31 PM · Restricted Project
aheejin updated the summary of D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Sat, Mar 23, 12:26 PM · Restricted Project
aheejin updated the summary of D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Sat, Mar 23, 12:26 PM · Restricted Project
aaronpuchert added a comment to D59523: Thread Safety: also look at ObjC methods.
In D59523#1440238, @jfb wrote:

This is very concrete: this specific code used to cause a crash. This test has exactly this purpose, nothing more. What I'm doing is extremely normal for LLVM.

Agreed, this is a normal practice for tests verifying that a crash no longer happens.

Sat, Mar 23, 12:26 PM · Restricted Project
aheejin created D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Sat, Mar 23, 12:26 PM · Restricted Project
craig.topper updated the diff for D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc..

Add doxygen comments. Check the zero_undef flag.

Sat, Mar 23, 12:21 PM · Restricted Project
keryell added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

Updated test to use root namespace (commented by Ronan).

Sat, Mar 23, 11:51 AM
riccibruno added a comment to D59467: [clang] Adding the Likely Attribute from C++2a to AST.

Before any further review, could you please run clang-format on your patch (but not necessarily on the tests and not on the *.td files), wrap lines to 80 cols, and in general use complete sentences in comments (that is with proper punctuation and capitalization) ? To run clang-format on your patch you can use clang-format-diff. This is the command I use :

Sat, Mar 23, 11:44 AM · Restricted Project
hubert.reinterpretcast committed rCRT356844: Fix typos in compiler-rt/lib/builtins/atomic.c.
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:41 AM
hubert.reinterpretcast committed rG4e7a218abf9b: Fix typos in compiler-rt/lib/builtins/atomic.c (authored by hubert.reinterpretcast).
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:39 AM
hubert.reinterpretcast committed rL356844: Fix typos in compiler-rt/lib/builtins/atomic.c.
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:39 AM
hubert.reinterpretcast closed D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.
Sat, Mar 23, 11:39 AM · Restricted Project, Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

Diff from the corrected clang version is uploaded

Sat, Mar 23, 11:26 AM · Restricted Project
RKSimon created D59738: [SLPVectorizer] reorderInputsAccordingToOpcode - remove non-Instruction canonicalization.
Sat, Mar 23, 11:26 AM · Restricted Project
Tyker updated the diff for D59467: [clang] Adding the Likely Attribute from C++2a to AST.

i implemented the semantic the changes for if for, while and do while statement and the AST change to if. can you review it and tell me if it is fine so i implement the rest. i didn't update the test so they will fail.

Sat, Mar 23, 11:26 AM · Restricted Project
ivafanas updated the diff for D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

to_string via to_chars implementation is ready.

Sat, Mar 23, 11:20 AM · Restricted Project
hubert.reinterpretcast committed rGa7510baf8477: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast).
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:10 AM
hubert.reinterpretcast committed rL356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:09 AM
hubert.reinterpretcast committed rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:09 AM
hubert.reinterpretcast closed D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
Sat, Mar 23, 11:09 AM · Restricted Project
sylvestre.ledru committed rGd53135767de5: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre.ledru).
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Sat, Mar 23, 10:59 AM
sylvestre.ledru added a reviewer for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: rnk.
Sat, Mar 23, 10:59 AM · Restricted Project
sylvestre.ledru updated the summary of D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Sat, Mar 23, 10:59 AM · Restricted Project
sylvestre committed rL356842: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format..
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Sat, Mar 23, 10:56 AM
sylvestre committed rC356842: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format..
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Sat, Mar 23, 10:56 AM
Diffusion closed D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.
Sat, Mar 23, 10:56 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Try again

Sat, Mar 23, 10:55 AM · Restricted Project
aheejin updated the summary of D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Sat, Mar 23, 10:53 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Remove unrelated changes

Sat, Mar 23, 10:52 AM · Restricted Project
aheejin created D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Sat, Mar 23, 10:50 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Svn version

Sat, Mar 23, 10:48 AM · Restricted Project
sylvestre.ledru updated the summary of D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.
Sat, Mar 23, 10:37 AM · Restricted Project
RKSimon committed rG1466e5c38360: Fix unused variable warning on non-asserts builds. NFCI. (authored by RKSimon).
Fix unused variable warning on non-asserts builds. NFCI.
Sat, Mar 23, 9:56 AM
RKSimon committed rL356841: Fix unused variable warning on non-asserts builds. NFCI..
Fix unused variable warning on non-asserts builds. NFCI.
Sat, Mar 23, 9:55 AM
lebedev.ri added inline comments to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.
Sat, Mar 23, 9:54 AM · Restricted Project
srhines added a comment to D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs.

This patch appears to generate non-reproducible builds in some cases. I can craft a more minimal test case, but the following link (https://godbolt.org/z/sWucUZ) is what I have been using. If I run Clang multiple times, the output eventually swaps the order of some undef DEBUG_VALUE's. I am just passing "-O1 -g" with that .ii file. It isn't obvious to me yet what is causing this to be unordered/non-deterministic.

Sat, Mar 23, 9:44 AM · Restricted Project
RKSimon committed rG64feec7977f8: Remove unused function argument. NFCI. (authored by RKSimon).
Remove unused function argument. NFCI.
Sat, Mar 23, 9:20 AM
RKSimon committed rL356840: Remove unused function argument. NFCI..
Remove unused function argument. NFCI.
Sat, Mar 23, 9:19 AM
RKSimon committed rG1ba406c9fcd2: Fix unused variable warning. NFCI. (authored by RKSimon).
Fix unused variable warning. NFCI.
Sat, Mar 23, 9:17 AM
RKSimon committed rL356839: Fix unused variable warning. NFCI..
Fix unused variable warning. NFCI.
Sat, Mar 23, 9:17 AM