Page MenuHomePhabricator
Feed All Stories

Today

ilya-biryukov added a comment to D146426: [Sema] Fix crash on __fp16 parameters in template instantiations.

This feels like it's heading in the wrong direction -- the AST should not have holes in it. An invalid type should be replaced by a valid type (after diagnosing the invalid type, of course) so that we can keep as much of the AST around as possible (for example, we typically stub in int and continue compilation, as in: https://godbolt.org/z/MvxjGovGh), which should then result in a non-null ParmVarDecl. This way, we don't need to sprinkle nullptr checks all over the compiler when inspecting a function's parameters.

Mon, Mar 20, 12:21 PM · Restricted Project, Restricted Project
mnadeem added inline comments to D146333: [Flang] Exit gracefully with a useful message when we fail to lookup a target.
Mon, Mar 20, 12:20 PM · Restricted Project, Restricted Project
yln added a reviewer for D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition.: thetruestblue.

Hi, thanks Vitaly!

Mon, Mar 20, 12:19 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D145881: [libc++][spaceship] Implement `operator<=>` for `duration`.

Thanks! LGTM! IIRC you have commit access right?

Mon, Mar 20, 12:19 PM · Restricted Project, Restricted Project
AdvenamTacet added inline comments to D132769: [2b/3][ASan][libcxx] std::basic_string annotations.
Mon, Mar 20, 12:19 PM · Restricted Project, Restricted Project, Restricted Project
erichkeane updated the diff for D146323: inline stmt attribute diagnosing in templates.

Changes aaron suggested. Chose zip_longest instead of enumerate.

Mon, Mar 20, 12:18 PM · Restricted Project
SjoerdMeijer added a comment to D109958: [LoopFlatten] Enable it by default.

FWIW, I am quite unhappy with the implementation quality of this pass, but I don't think I have the energy to deal with this. In the future, due diligence for pass enablement needs to include a review of the pass implementation by a domain expert, if this was not already done as part of the initial implementation. (Domain expert = SCEV reviewer in this context.)

Mon, Mar 20, 12:16 PM · Restricted Project, Restricted Project
AdvenamTacet updated the diff for D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

This update reverts part of a previous update and removes _LIBCPP_ASAN_ANNOTATE_ONLY_LONG.

Mon, Mar 20, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
EricWF added a comment to D146214: [ASan][libc++] Annotating std::basic_string with all allocators.

Has this patch been tested against Chromium? Has it been tested elsewhere?
The more testing it's undergone, the more confident I can be.

Mon, Mar 20, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D146355: [compiler-rt] Allow finding LLVMConfig if CMAKE_FIND_ROOT_PATH_MODE_PACKAGE is set to ONLY.

I still don't understand the motivation behind this change. You already explicitly set CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY for Android so why do we need to change the default?

Mon, Mar 20, 12:10 PM · Restricted Project
jsjodin added a comment to D144657: [mlir] Add alloca address space handling to the data layout subsystem.

Sorry for delay, already-approved patches don't show up in the review stream :(

Mon, Mar 20, 12:10 PM · Restricted Project, Restricted Project
scott.linder accepted D145558: [Assignment Tracking][NFC] Use BitVectors as masks for SmallVectors rather than using DenseMaps.

Thank you @scott.linder for taking a look at this.

It might be worth including the rationale in the description/commit message, like you've done in other similar changes. I assume it is a performance improvement?

Yep there's an average of around 0.25% reduction in instructions retired and a 1.1% max-rss for the CTMark suite in LTO-O3-g builds (I'll update the description).

I'm leaving a bunch of edit suggestions, but feel free to ignore them! I was just going through the exercise of writing one possible implementation to prove to myself it is an actual improvement, YMMV

I appreciate the in-depth review and the suggestions all look good to me!

The diff has become quite large now so I'll could look at trying to factor out some of the suggestions into NFC patches?

Mon, Mar 20, 12:10 PM · Restricted Project, Restricted Project, debug-info
mnadeem committed rGf67b481098cc: [Flang] Exit gracefully with a useful message when we fail to lookup a target (authored by mnadeem).
[Flang] Exit gracefully with a useful message when we fail to lookup a target
Mon, Mar 20, 12:09 PM · Restricted Project, Restricted Project
ABataev added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

a more succinct version: https://godbolt.org/z/7YTqP89Mv shows that slp-vectorizer introduces loads from poison

Mon, Mar 20, 12:09 PM · Restricted Project, Restricted Project
mnadeem closed D146333: [Flang] Exit gracefully with a useful message when we fail to lookup a target.
Mon, Mar 20, 12:09 PM · Restricted Project, Restricted Project
ABataev committed rG59ff9d377770: [SLP]Fix PR61554: use of missing vectorized value in buildvector nodes. (authored by ABataev).
[SLP]Fix PR61554: use of missing vectorized value in buildvector nodes.
Mon, Mar 20, 12:08 PM · Restricted Project, Restricted Project
reames added inline comments to D146429: [LSR] Fix wrapping bug in lsr-term-fold logic.
Mon, Mar 20, 12:07 PM · Restricted Project, Restricted Project
erichkeane added a comment to D146426: [Sema] Fix crash on __fp16 parameters in template instantiations.

This feels like it's heading in the wrong direction -- the AST should not have holes in it. An invalid type should be replaced by a valid type (after diagnosing the invalid type, of course) so that we can keep as much of the AST around as possible (for example, we typically stub in int and continue compilation, as in: https://godbolt.org/z/MvxjGovGh), which should then result in a non-null ParmVarDecl. This way, we don't need to sprinkle nullptr checks all over the compiler when inspecting a function's parameters.

Mon, Mar 20, 12:07 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D141497: [clang][Interp] Record initialization via conditional operator.
Mon, Mar 20, 12:07 PM · Restricted Project, Restricted Project
ruoso added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Mon, Mar 20, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
yota9 requested changes to D144653: [BOLT][AArch64] ST_Function symbols start a CODE interval.

Sorry @sebpop but I don't think it is part of ARM mapping symbols ABI standard. What type of compiler are you using when observing this? Is there any way to create test to reproduce it?

Mon, Mar 20, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
srhines accepted D146355: [compiler-rt] Allow finding LLVMConfig if CMAKE_FIND_ROOT_PATH_MODE_PACKAGE is set to ONLY.

LGTM, but @phosek should also be able to confirm this is ok.

Mon, Mar 20, 12:04 PM · Restricted Project
w2yehia added reviewers for D146431: [AIX][Driver] Implement -mxcoff-build-id option.: qiongsiwu, stephenpeckham.
Mon, Mar 20, 12:04 PM · Restricted Project
efriedma accepted D146339: [StackProtector] attribute __stack_chk_fail as NoReturn.

LGTM

Mon, Mar 20, 12:04 PM · Restricted Project, Restricted Project
w2yehia updated the diff for D146431: [AIX][Driver] Implement -mxcoff-build-id option..

add "<0xHEXSTRING>" to the option documentation.

Mon, Mar 20, 12:03 PM · Restricted Project
efriedma committed rG5452d8607185: [llvm-readobj] Pretty-print IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY. (authored by efriedma).
[llvm-readobj] Pretty-print IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY.
Mon, Mar 20, 12:00 PM · Restricted Project, Restricted Project
sebpop updated the diff for D144653: [BOLT][AArch64] ST_Function symbols start a CODE interval.

Updated patch to pass clang-format check.

Mon, Mar 20, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
mravishankar updated the diff for D146254: Changes to `SCFFuseProducerOfSliceResult` to also return the operations created during fusion..

Rebase

Mon, Mar 20, 11:59 AM · Restricted Project, Restricted Project
EricWF added a comment to D146228: [libc++] Granularize __mutex_base.

I agree with @Mordante

Mon, Mar 20, 11:59 AM · Restricted Project, Restricted Project
EricWF accepted D146228: [libc++] Granularize __mutex_base.
Mon, Mar 20, 11:58 AM · Restricted Project, Restricted Project
aaron.ballman added reviewers for D146426: [Sema] Fix crash on __fp16 parameters in template instantiations: erichkeane, aaron.ballman.

This feels like it's heading in the wrong direction -- the AST should not have holes in it. An invalid type should be replaced by a valid type (after diagnosing the invalid type, of course) so that we can keep as much of the AST around as possible (for example, we typically stub in int and continue compilation, as in: https://godbolt.org/z/MvxjGovGh), which should then result in a non-null ParmVarDecl. This way, we don't need to sprinkle nullptr checks all over the compiler when inspecting a function's parameters.

Mon, Mar 20, 11:55 AM · Restricted Project, Restricted Project
hanchung accepted D146439: [mlir][Tensor] Make `TilingInterface` implementation only return handle to the created `pad` operation..
Mon, Mar 20, 11:54 AM · Restricted Project, Restricted Project
nickdesaulniers added reviewers for D146339: [StackProtector] attribute __stack_chk_fail as NoReturn: void, nikic.
Mon, Mar 20, 11:53 AM · Restricted Project, Restricted Project
michaelrj added inline comments to D146001: [libc] enable printf using system FILE.
Mon, Mar 20, 11:53 AM · Restricted Project, Restricted Project
nridge committed rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc() (authored by nridge).
[clangd] Remove reundant use of getSpellingLoc()
Mon, Mar 20, 11:52 AM · Restricted Project, Restricted Project
michaelrj updated the diff for D146001: [libc] enable printf using system FILE.

move vfprintf_internal and file_writer to templates

Mon, Mar 20, 11:52 AM · Restricted Project, Restricted Project
nridge closed D146377: [clangd] Remove reundant use of getSpellingLoc().
Mon, Mar 20, 11:52 AM · Restricted Project, Restricted Project
hanchung accepted D146440: [mlir][Tensor] Avoid dropping attributes for `tensor.pad` operations during canonicalization..
Mon, Mar 20, 11:50 AM · Restricted Project, Restricted Project
nridge added a comment to D145843: [clangd] Add option to always insert headers with <> instead of "".

My understanding is that a more elaborate configuration scheme has been proposed in https://github.com/clangd/clangd/issues/1367, and the feedback there was (quoting Sam from this comment):

Mon, Mar 20, 11:49 AM · Restricted Project, Restricted Project
TIFitis committed rG2d373e4dc7e9: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives (authored by TIFitis).
[MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives
Mon, Mar 20, 11:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
TIFitis closed D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..
Mon, Mar 20, 11:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
EricWF accepted D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.
Mon, Mar 20, 11:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
craig.topper updated the diff for D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC.

More files

Mon, Mar 20, 11:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
EricWF requested changes to D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`.
Mon, Mar 20, 11:45 AM · Restricted Project, Restricted Project
ruoso added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Mon, Mar 20, 11:44 AM · Restricted Project, Restricted Project, Restricted Project
hanchung accepted D146254: Changes to `SCFFuseProducerOfSliceResult` to also return the operations created during fusion..
Mon, Mar 20, 11:44 AM · Restricted Project, Restricted Project
agozillon added a comment to D146063: [Flang][OpenMP][MLIR] Add lowering from parse tree to MLIR support for Declare Target for functions and subroutines.

I believe I understand your concerns.

Mon, Mar 20, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added inline comments to D146323: inline stmt attribute diagnosing in templates.
Mon, Mar 20, 11:39 AM · Restricted Project
craig.topper updated the diff for D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC.

Update a few more files.

Mon, Mar 20, 11:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tstellar committed rW7daf66fb04c7: Update for 16.0.0 release (authored by tstellar).
Update for 16.0.0 release
Mon, Mar 20, 11:38 AM · Restricted Project
jrtc27 added inline comments to D143708: [RISCV] Support emulated TLS.
Mon, Mar 20, 11:38 AM · Restricted Project, Restricted Project
craig.topper updated the diff for D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC.

Update RISCVISAInfo.* and RISCVTargetParser.*

Mon, Mar 20, 11:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kuhar committed rG92416b63a57b: [ADT] Work around `enumerate` compilation error with modules enabled (authored by kuhar).
[ADT] Work around `enumerate` compilation error with modules enabled
Mon, Mar 20, 11:36 AM · Restricted Project, Restricted Project
kuhar closed D146340: [ADT] Work around `enumerate` compilation error with modules enabled.
Mon, Mar 20, 11:35 AM · Restricted Project, Restricted Project
vit9696 added inline comments to D143708: [RISCV] Support emulated TLS.
Mon, Mar 20, 11:35 AM · Restricted Project, Restricted Project
craig.topper requested review of D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC.
Mon, Mar 20, 11:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jrtc27 added inline comments to D143708: [RISCV] Support emulated TLS.
Mon, Mar 20, 11:32 AM · Restricted Project, Restricted Project
jdoerfert added inline comments to D146081: [OpenMP][libomptarget] Init device when printing device info.
Mon, Mar 20, 11:32 AM · Restricted Project, Restricted Project
tschuett added a comment to D144994: [Draft][libc++][modules] Adds std module..

There was objection against using /usr/modules on discourse. I assumed that libc++ owns /usr/include/c++ and hides everything under there.

Mon, Mar 20, 11:31 AM · Restricted Project, Restricted Project, Restricted Project
mravishankar added a reviewer for D146440: [mlir][Tensor] Avoid dropping attributes for `tensor.pad` operations during canonicalization.: hanchung.
Mon, Mar 20, 11:31 AM · Restricted Project, Restricted Project
mravishankar added a reviewer for D146439: [mlir][Tensor] Make `TilingInterface` implementation only return handle to the created `pad` operation.: hanchung.
Mon, Mar 20, 11:30 AM · Restricted Project, Restricted Project
mravishankar added a reviewer for D146254: Changes to `SCFFuseProducerOfSliceResult` to also return the operations created during fusion.: hanchung.
Mon, Mar 20, 11:30 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D146371: [Clang][OpenMP]Solved the the always truth condition in Arm64.

Can you please upload a patch that does not reformat the entire file?
Also, add a commit message explaining what this does.

Mon, Mar 20, 11:30 AM · Restricted Project, Restricted Project
tra published D146448: [CUDA] Update cached kernel handle when the function instance changes. for review.
Mon, Mar 20, 11:29 AM · Restricted Project, Restricted Project
EricWF accepted D146395: [libc++] Move __errc to __system_error/errc.h.
Mon, Mar 20, 11:27 AM · Restricted Project, Restricted Project
aeubanks added reviewers for D146446: [AlwaysInliner] Make legacy pass like the new pass: asbirlea, mtrofin.
Mon, Mar 20, 11:25 AM · Restricted Project, Restricted Project
aeubanks updated the diff for D146446: [AlwaysInliner] Make legacy pass like the new pass.

update

Mon, Mar 20, 11:24 AM · Restricted Project, Restricted Project
clementval requested review of D146447: [flang] Handle polymorphic entities with rank > 0 in entry statement.
Mon, Mar 20, 11:24 AM · Restricted Project, Restricted Project
reames added inline comments to D146429: [LSR] Fix wrapping bug in lsr-term-fold logic.
Mon, Mar 20, 11:24 AM · Restricted Project, Restricted Project
reames committed rG272ebd6957ef: [LSR] Inline getAlternateIVEnd and simplify [nfc] (authored by reames).
[LSR] Inline getAlternateIVEnd and simplify [nfc]
Mon, Mar 20, 11:23 AM · Restricted Project, Restricted Project
hiraditya added a comment to D123515: [RISCV] Support '.option arch' directive.

ping @StephenFan

Mon, Mar 20, 11:22 AM · Restricted Project, Restricted Project
aeubanks requested review of D146446: [AlwaysInliner] Make legacy pass like the new pass.
Mon, Mar 20, 11:21 AM · Restricted Project, Restricted Project
jdoerfert added a comment to D140722: [OpenMP] Prefix outlined and reduction func names with original func's name.

can we update some tests to see the results?

Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project
aaronmondal added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
aprantl accepted D146340: [ADT] Work around `enumerate` compilation error with modules enabled.
Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project
aprantl added a comment to D146340: [ADT] Work around `enumerate` compilation error with modules enabled.

Oh wait, I didn't realize you haven't landed it yet :-)

Mon, Mar 20, 11:20 AM · Restricted Project, Restricted Project
aprantl added a comment to D146340: [ADT] Work around `enumerate` compilation error with modules enabled.

Thanks, but this does not seem to have worked: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52610/consoleText

Mon, Mar 20, 11:19 AM · Restricted Project, Restricted Project
hiraditya accepted D143708: [RISCV] Support emulated TLS.
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
peter.smith added inline comments to D140202: [lld][ARM][2/3]Big Endian support - Word invariant support.
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
aemerson committed rG41e9c4b88c28: [NFC][Outliner] Delete default ctors for Candidate & OutlinedFunction. (authored by aemerson).
[NFC][Outliner] Delete default ctors for Candidate & OutlinedFunction.
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
ldionne accepted D146088: [libc++] Qualifies size_t..

I just went through the patch and it LGTM. The table of contents was really useful here.

Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
jhuber6 committed rG6bd4d717d577: [libc] Add environment variables to GPU libc test for AMDGPU (authored by jhuber6).
[libc] Add environment variables to GPU libc test for AMDGPU
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
aemerson closed D146375: [NFC][Outliner] Delete default ctors for Candidate & OutlinedFunction..
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
jhuber6 closed D146322: [libc] Add environment variables to GPU libc test for AMDGPU.
Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
vdonaldson accepted D146445: [flang] Set proper source location for the main function..
Mon, Mar 20, 11:16 AM · Restricted Project, Restricted Project
sivachandra accepted D146322: [libc] Add environment variables to GPU libc test for AMDGPU.

This is essentially a GPU only change. Stamping anyway.

Mon, Mar 20, 11:15 AM · Restricted Project, Restricted Project
nikic added inline comments to D146429: [LSR] Fix wrapping bug in lsr-term-fold logic.
Mon, Mar 20, 11:13 AM · Restricted Project, Restricted Project
jansvoboda11 committed rGd1e00b6f136e: [clang][deps] Only cache files with specific extension (authored by jansvoboda11).
[clang][deps] Only cache files with specific extension
Mon, Mar 20, 11:13 AM · Restricted Project, Restricted Project
jrbyrnes added inline comments to D142782: [AMDGPU] Add basic support for extended i8 perm matching.
Mon, Mar 20, 11:13 AM · Restricted Project, Restricted Project
jansvoboda11 closed D146328: [clang][deps] Only cache files with specific extension.
Mon, Mar 20, 11:12 AM · Restricted Project, Restricted Project
jrbyrnes updated the diff for D142782: [AMDGPU] Add basic support for extended i8 perm matching.

Thanks @arsenm for taking another look.

Mon, Mar 20, 11:12 AM · Restricted Project, Restricted Project
peter.smith added a comment to D140202: [lld][ARM][2/3]Big Endian support - Word invariant support.

This looks correct, although I think there are a few places where we can simplify the code to remove the explicit endianness.

Mon, Mar 20, 11:10 AM · Restricted Project, Restricted Project
vzakhari requested review of D146445: [flang] Set proper source location for the main function..
Mon, Mar 20, 11:10 AM · Restricted Project, Restricted Project
vitalybuka accepted D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition..

I guess Android was that main reason was older API levels why don't use thread_local, probably our buildbot is still on them.
Wide use of thread_local may simplify sanitizers.

Mon, Mar 20, 11:10 AM · Restricted Project, Restricted Project
AdvenamTacet added a comment to D145482: [ASan] Remove sanity checks during annotation of contiguous container.

@vitalybuka could you land that revision as I don't have commiter rights?

Mon, Mar 20, 11:09 AM · Restricted Project, Restricted Project
craig.topper requested review of D146444: [IndVarSimplify] Remove duplicate call to getSCEV. NFC.
Mon, Mar 20, 11:09 AM · Restricted Project, Restricted Project
AdvenamTacet updated the summary of D145482: [ASan] Remove sanity checks during annotation of contiguous container.
Mon, Mar 20, 11:08 AM · Restricted Project, Restricted Project
michaelmaitland added a comment to D146198: [RISCV] Make ResourceCycles relevant to LMUL.

If there are some microarchitectures that can't be modeled, just add a new subroutine to upstream if approved.

Does this mean that subtarget routines must be added to the RISCVScheduleV file since the following function needs to know about the custom subroutine to do its isa checks:

// Helper class for generating a list of resource cycles of different LMULs.
class ResourceCycles<list<ResourceCycle> resourceCycles, string mx> {

I am concerned that the RISCVScheduleV file will take on bloat due to holding subtarget related routines if this is the case.

Yes. So I posted this patch here just to discuss how we should handle this.
For example, solutions may be:

  1. Add routines to RISCVScheduleV.td just as what I have done.
  2. Extend TableGen to support pass functions:
// Supposes that we have a Function class to present a function object that its parameters are function parameters.
class TargetSubroutine<int base, string mx> : Function;

// Then. Supposes that we have a new bang operator to apply this function to input parameters and the result is `ret`.
class ResourceCycles<list<TargetSubroutine> subroutines, int base, string mx> {
  list<int> value = !foreach(subroutine, subroutines,
                             !apply(subroutine, base, mx)
                            );
}

// In SchedXXX.td, we can define our own routines.
class Multiplier<int base, string mx>:TargetSubroutine {
 // We return an int value calculated from mx.
 int ret = !mul(base, multiplier<mx>.value);
}
  1. Some templates are flexible to specify cycles according to LMULs (I haven't figured out one...).
Mon, Mar 20, 11:08 AM · Restricted Project, Restricted Project
vitalybuka added reviewers for D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition.: yln, rsundahl, kubamracek.
Mon, Mar 20, 11:07 AM · Restricted Project, Restricted Project
1lyasm added a comment to D146382: Change strcpy to std::copy.

Ilyas Mustafazade <il.mystafa@gmail.com>
Thank you.

Mon, Mar 20, 11:05 AM · Restricted Project, Restricted Project