Page MenuHomePhabricator
Feed All Stories

Today

teemperor added a comment to D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333).

I plan to match this soon-ish as this is essentially just a revert.

Fri, Sep 20, 12:30 AM · Restricted Project
teemperor created D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333).
Fri, Sep 20, 12:30 AM · Restricted Project
teemperor added a reverting change for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src: D67803: [lldb] Fix that importing decls in a TagDecl end up in wrong declaration context (partly reverts D61333).
Fri, Sep 20, 12:30 AM · Restricted Project, Restricted Project, Restricted Project
craig.topper added reviewers for D67802: [SelectionDAG][Mips][Sparc] Don't allow SimplifyDemandedBits to constant fold TargetConstant nodes to a Constant.: venkatra, atanasyan.
Fri, Sep 20, 12:30 AM · Restricted Project
craig.topper created D67802: [SelectionDAG][Mips][Sparc] Don't allow SimplifyDemandedBits to constant fold TargetConstant nodes to a Constant..
Fri, Sep 20, 12:27 AM · Restricted Project
hans added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Fri, Sep 20, 12:12 AM · Restricted Project
craig.topper committed rG621c93ec1fd8: [X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument… (authored by craig.topper).
[X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument…
Fri, Sep 20, 12:04 AM
ctopper committed rL372373: [X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument….
[X86] Convert tbm_bextri_u32/tbm_bextri_u64 intrinsics TargetConstant argument…
Fri, Sep 20, 12:04 AM
seiya added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Commented regarding tests and nits. Could you update docs/CommandGuide/llvm-objcopy.rst as well?

Fri, Sep 20, 12:04 AM · Restricted Project
alex-t accepted D67596: AMDGPU/GlobalISel: Allow selection of scalar min/max.

LGTM but make sure it passes recently updated lit tests.

Fri, Sep 20, 12:04 AM
samparker created D67801: [ARM][LowOverheadLoops] Use subs during revert..
Fri, Sep 20, 12:04 AM
NikolaPrica added inline comments to D66955: [DebugInfo][If-Converter] Update call site info during the optimization.
Fri, Sep 20, 12:04 AM · debug-info

Yesterday

huihuiz added a parent revision for D67798: [NFC][InstCombine] Add tests for shifty implementation of image clamping.: D67800: [InstCombine] Fold a shifty implementation of clamp (e.g., clamp255)..
Thu, Sep 19, 11:40 PM · Restricted Project
huihuiz added a child revision for D67800: [InstCombine] Fold a shifty implementation of clamp (e.g., clamp255).: D67798: [NFC][InstCombine] Add tests for shifty implementation of image clamping..
Thu, Sep 19, 11:40 PM · Restricted Project
huihuiz added a comment to D67800: [InstCombine] Fold a shifty implementation of clamp (e.g., clamp255)..

E.g., vmin generation for ARM target

Thu, Sep 19, 11:40 PM · Restricted Project
huihuiz created D67800: [InstCombine] Fold a shifty implementation of clamp (e.g., clamp255)..
Thu, Sep 19, 11:37 PM · Restricted Project
MaskRay added inline comments to D67757: [yaml2obj/obj2yaml] - Add a support for .stack_sizes sections..
Thu, Sep 19, 11:37 PM
ychen committed rGe03663fbb846: [llvm-readobj] flush output before crash (authored by ychen).
[llvm-readobj] flush output before crash
Thu, Sep 19, 11:34 PM
yuanfang committed rL372372: [llvm-readobj] flush output before crash.
[llvm-readobj] flush output before crash
Thu, Sep 19, 11:34 PM
huihuiz added a parent revision for D67798: [NFC][InstCombine] Add tests for shifty implementation of image clamping.: D67799: [InstCombine] Fold a shifty implementation of clamp0..
Thu, Sep 19, 11:34 PM · Restricted Project
huihuiz added a child revision for D67799: [InstCombine] Fold a shifty implementation of clamp0.: D67798: [NFC][InstCombine] Add tests for shifty implementation of image clamping..
Thu, Sep 19, 11:34 PM · Restricted Project
huihuiz added a comment to D67799: [InstCombine] Fold a shifty implementation of clamp0..

E.g., vmax generation for ARM target

Thu, Sep 19, 11:34 PM · Restricted Project
huihuiz created D67799: [InstCombine] Fold a shifty implementation of clamp0..
Thu, Sep 19, 11:30 PM · Restricted Project
huihuiz created D67798: [NFC][InstCombine] Add tests for shifty implementation of image clamping..
Thu, Sep 19, 11:24 PM · Restricted Project
MaskRay created D67797: [Support] Add a DataExtractor constructor that takes ArrayRef<uint8_t>.
Thu, Sep 19, 11:24 PM · Restricted Project
seiya updated the diff for D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..
  • Addressed a review comment.
Thu, Sep 19, 11:23 PM · Restricted Project
craig.topper committed rGa34f13f2bab3: [X86] Use timm in MMX pinsrw/pextrw isel patterns. Add missing test cases. (authored by craig.topper).
[X86] Use timm in MMX pinsrw/pextrw isel patterns. Add missing test cases.
Thu, Sep 19, 11:00 PM
ctopper committed rL372371: [X86] Use timm in MMX pinsrw/pextrw isel patterns. Add missing test cases..
[X86] Use timm in MMX pinsrw/pextrw isel patterns. Add missing test cases.
Thu, Sep 19, 11:00 PM
samparker created D67796: [ARM][LowOverheadLoops] Use tBcc when reverting.
Thu, Sep 19, 11:00 PM
MaskRay accepted D67657: [yaml2obj/obj2yaml] - Do not trigger llvm_unreachable when dumping/parsing relocations and e_machine is unsupported..

Though this situation is valid.

Thu, Sep 19, 10:43 PM
MaskRay accepted D67795: [LNT] Python 3 support: Fix implicit package-relative imports.
Thu, Sep 19, 10:39 PM
lkail added a reviewer for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: craig.topper.
Thu, Sep 19, 10:39 PM · Restricted Project
asmith added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Any comments from the llvm-objcopy community?

Thu, Sep 19, 10:39 PM · Restricted Project
lkail added reviewers for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation: nemanjai, jsji.
Thu, Sep 19, 10:39 PM · Restricted Project
MaskRay updated the diff for D67665: [ADT] Add 2 DenseMap::insert_or_assign overloads.

unique_ptr<int> -> NonDefaultConstructible

Thu, Sep 19, 10:30 PM · Restricted Project
lkail edited reviewers for D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation, added: efriedma; removed: eli.friedman.
Thu, Sep 19, 10:30 PM · Restricted Project
hubert.reinterpretcast created D67795: [LNT] Python 3 support: Fix implicit package-relative imports.
Thu, Sep 19, 10:24 PM
lkail updated the summary of D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Thu, Sep 19, 10:24 PM · Restricted Project
lkail updated the summary of D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Thu, Sep 19, 10:23 PM · Restricted Project
lkail updated the summary of D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Thu, Sep 19, 10:23 PM · Restricted Project
lkail created D67794: [MachineCopyPropagation] Extend MCP to do trivial copy backward propagation.
Thu, Sep 19, 10:21 PM · Restricted Project
MaskRay added inline comments to D67780: Can't pass .dSYM directory to llvm-objdump -dsym= (and error message is wrong).
Thu, Sep 19, 10:21 PM · Restricted Project
MaskRay updated the diff for D67668: [ADT] Add StringMap::insert_or_assign.

You could use a noisy type here to test that only the appropriate operations were executed

Thu, Sep 19, 10:15 PM · Restricted Project
shiva0217 added a comment to D67698: [RISCV] Remove RA from reserved register to use as callee saved register.

We discussed this in the RISC-V meeting on 19 Sep 2019.

  • Pros: GCC for RISC-V and LLVM for ARM and AArch64 seem to do the same. It can help in situations with particularly bad register pressure requirements.
  • Cons: It can make debugging a lot harder, though this seems not to be an issue in GDB for RISC-V.

    I think we don't want to have yet another configuration flag to control this.

    It would be good to see some performance comparison, but I realise you may not be able to release internal benchmarks, and we have no public benchmarking system for RISC-V.
Thu, Sep 19, 10:13 PM · Restricted Project
sbc100 updated the diff for D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.
  • feedback
Thu, Sep 19, 9:41 PM · Restricted Project
MaskRay committed rGc768ad94b7f0: [llvm-ar] Removes repetition in the error message (authored by MaskRay).
[llvm-ar] Removes repetition in the error message
Thu, Sep 19, 9:40 PM
MaskRay committed rGa5db9ee71f81: [Object] Uncapitalize an error message (authored by MaskRay).
[Object] Uncapitalize an error message
Thu, Sep 19, 9:40 PM
MaskRay committed rL372370: [llvm-ar] Removes repetition in the error message.
[llvm-ar] Removes repetition in the error message
Thu, Sep 19, 9:40 PM
MaskRay closed D67038: [llvm-ar] Removes repetition in the error message.
Thu, Sep 19, 9:40 PM · Restricted Project
MaskRay committed rL372369: [Object] Uncapitalize an error message.
[Object] Uncapitalize an error message
Thu, Sep 19, 9:40 PM
MaskRay added a comment to D67038: [llvm-ar] Removes repetition in the error message.

I do not have commit access. Could someone please help me with the commit?

Thanks!

Thu, Sep 19, 9:40 PM · Restricted Project
lawrence_danna updated the summary of D67793: new api class: SBFile.
Thu, Sep 19, 9:30 PM · Restricted Project
lawrence_danna created D67793: new api class: SBFile.
Thu, Sep 19, 9:28 PM · Restricted Project
lawrence_danna created D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0.
Thu, Sep 19, 9:24 PM · Restricted Project
pete accepted D67780: Can't pass .dSYM directory to llvm-objdump -dsym= (and error message is wrong).

LGTM

Thu, Sep 19, 9:24 PM · Restricted Project
lawrence_danna created D67791: dotest.py: bugfix: test filters with -f do not work on Python3.
Thu, Sep 19, 9:21 PM · Restricted Project
lawrence_danna abandoned D38829: Python: SetOutputFileHandle doesn't work with IOBase.

I've reworked this -- finally -- as zturner suggested. I'll be posting it as a bunch of individual commits, so i'm abandoning this one.

Thu, Sep 19, 9:20 PM · Restricted Project
lawrence_danna created D67790: prepare_binding_Python: print readable errors if SWIG fails.
Thu, Sep 19, 9:16 PM · Restricted Project
lawrence_danna created D67789: bugfix: File::GetWaitableHandle() should call fileno().
Thu, Sep 19, 9:12 PM · Restricted Project
MaskRay added a comment to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

In the description of the git commit:

Thu, Sep 19, 9:11 PM · Restricted Project
lawrence_danna created D67788: StringLiteral: intellisense workaround.
Thu, Sep 19, 9:11 PM · Restricted Project
lawrence_danna updated the summary of D67788: StringLiteral: intellisense workaround.
Thu, Sep 19, 9:11 PM · Restricted Project
lawrence_danna abandoned D67786: support for arbitrary python file objects.

will re-submit as individual patches.

Thu, Sep 19, 8:36 PM · Restricted Project, Restricted Project
lawrence_danna updated the summary of D67786: support for arbitrary python file objects.
Thu, Sep 19, 8:36 PM · Restricted Project, Restricted Project
Richard Smith <richard-llvm@metafoo.co.uk> committed rG4aef105b4307: Finish building the full-expression for a static_assert expression before… (authored by Richard Smith <richard-llvm@metafoo.co.uk>).
Finish building the full-expression for a static_assert expression before…
Thu, Sep 19, 8:29 PM
rsmith committed rL372368: Finish building the full-expression for a static_assert expression.
Finish building the full-expression for a static_assert expression
Thu, Sep 19, 8:28 PM
jhibbits added a comment to D67787: Add 8548 CPU definition and attributes.

I made 8548 an alias in clang to e500, because e500 is recognized in llvm as a CPU, so gets us the feature list and, more importantly, the instruction scheduler.

Thu, Sep 19, 8:23 PM · Restricted Project
jhibbits created D67787: Add 8548 CPU definition and attributes.
Thu, Sep 19, 8:23 PM · Restricted Project
ZeGentzy added a comment to D67583: Fix swig python package path.
In D67583#1675714, @hhb wrote:

My theory now is that your python has a different implementation of get_python_lib(). After all we should not guess what python would do. I'm making a change.
If you still interested in testing that, you can fix the path in a.py...

Thu, Sep 19, 8:23 PM · Restricted Project, Restricted Project
lawrence_danna created D67786: support for arbitrary python file objects.
Thu, Sep 19, 8:23 PM · Restricted Project, Restricted Project
rsmith added a comment to D49091: Warn about usage of __has_include/__has_include_next in macro expansions.

Under http://eel.is/c++draft/cpp#cond-7.sentence-2, the identifier __has_include can't appear anywhere other than in the context of an #if, #elif, #iifdef, or #ifndef. That's what we should be checking for and diagnosing here (and we should produce an ExtWarn rather than a Warning for this case, because such code is ill-formed, and accepting it at all is a language extension compared to the C++ rules). We should apply the same behavior to __has_cpp_attribute, to which the same rule applies.

Thu, Sep 19, 8:19 PM · Restricted Project
thakis committed rG8c77674e0f4b: llvm-undname: Delete an empty, unused method. (authored by thakis).
llvm-undname: Delete an empty, unused method.
Thu, Sep 19, 8:15 PM
nico committed rL372367: llvm-undname: Delete an empty, unused method..
llvm-undname: Delete an empty, unused method.
Thu, Sep 19, 8:15 PM
wyjw added a comment to D67038: [llvm-ar] Removes repetition in the error message.

I do not have commit access. Could someone please help me with the commit?

Thu, Sep 19, 7:50 PM · Restricted Project
MaskRay added inline comments to D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.
Thu, Sep 19, 7:38 PM · Restricted Project
saugustine closed D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Thu, Sep 19, 7:38 PM · Restricted Project
saugustine committed rG52621307bcab: Use getTargetConstant for BLENDI, and add a test to catch it. (authored by saugustine).
Use getTargetConstant for BLENDI, and add a test to catch it.
Thu, Sep 19, 7:37 PM
saugustine committed rL372366: Use getTargetConstant for BLENDI, and add a test to catch it..
Use getTargetConstant for BLENDI, and add a test to catch it.
Thu, Sep 19, 7:35 PM
stephanemoore added inline comments to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Thu, Sep 19, 7:34 PM · Restricted Project
MaskRay accepted D67139: [llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC..
Thu, Sep 19, 7:32 PM · Restricted Project
saugustine added a comment to rL372338: Reapply r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics".

I fixed our problem with r372366.

Thu, Sep 19, 7:32 PM
echristo accepted D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

Sweet.

Thu, Sep 19, 7:32 PM · Restricted Project
saugustine added a comment to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

The x86isellowering change is great, see if you can't remove some of the branches before committing?

Thu, Sep 19, 7:32 PM · Restricted Project
saugustine added a comment to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

Committed as r372366.

Thu, Sep 19, 7:32 PM · Restricted Project
saugustine updated the diff for D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
  • Tighten up the test case.
Thu, Sep 19, 7:26 PM · Restricted Project
MaskRay retitled D67038: [llvm-ar] Removes repetition in the error message from Removes repetition in the error message. to [llvm-ar] Removes repetition in the error message.
Thu, Sep 19, 7:18 PM · Restricted Project
MaskRay accepted D67038: [llvm-ar] Removes repetition in the error message.
Thu, Sep 19, 7:17 PM · Restricted Project
MaskRay added inline comments to D67782: [ELF] accept thinlto options without --plugin-opt= prefix.
Thu, Sep 19, 7:12 PM · Restricted Project
MaskRay added a comment to D67693: [llvm-objcopy][test] Clean up -B tests.

To be clear though, we have a test ensuring that -B is ignored, correct?

Thu, Sep 19, 7:08 PM · Restricted Project
MaskRay added inline comments to D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Thu, Sep 19, 7:08 PM · Restricted Project
echristo accepted D67785: Use getTargetConstant for BLENDI, and add a test to catch it..

The x86isellowering change is great, see if you can't remove some of the branches before committing?

Thu, Sep 19, 7:04 PM · Restricted Project
saugustine created D67785: Use getTargetConstant for BLENDI, and add a test to catch it..
Thu, Sep 19, 6:59 PM · Restricted Project
zoecarver added inline comments to D67052: Add reference type transformation builtins.
Thu, Sep 19, 6:58 PM · Restricted Project, Restricted Project
craig.topper committed rG081cb7ef2370: [X86] Remove the special isBuildVectorOfConstantSDNodes handling from… (authored by craig.topper).
[X86] Remove the special isBuildVectorOfConstantSDNodes handling from…
Thu, Sep 19, 6:50 PM
ctopper committed rL372365: [X86] Remove the special isBuildVectorOfConstantSDNodes handling from….
[X86] Remove the special isBuildVectorOfConstantSDNodes handling from…
Thu, Sep 19, 6:49 PM
tlively created D67784: [WebAssembly] vNxM.load_splat instructions.
Thu, Sep 19, 6:49 PM · Restricted Project
tlively added a child revision for D67783: [WebAssembly] Remove unused memory instructions and patterns: D67784: [WebAssembly] vNxM.load_splat instructions.
Thu, Sep 19, 6:49 PM · Restricted Project
tlively added a comment to D67783: [WebAssembly] Remove unused memory instructions and patterns.

@sunfish I believe you originally added the GlobalAddress patterns so I wanted to check in with you before removing them. Do you know whether they can ever be used? If so I will add tests for them instead, but I'm not sure I've ever seen a GlobalAddress offset.

Thu, Sep 19, 6:26 PM · Restricted Project
tlively created D67783: [WebAssembly] Remove unused memory instructions and patterns.
Thu, Sep 19, 6:26 PM · Restricted Project
MaskRay accepted D67779: Support for 64-bit PC-relative relocations for X86_64.
Thu, Sep 19, 6:15 PM · Restricted Project