Page MenuHomePhabricator
Feed All Stories

Today

MaskRay committed rG5d4bc1293cc9: [ARM][test] Improve tests (authored by MaskRay).
[ARM][test] Improve tests
Mon, Jul 22, 4:41 AM
grimar added inline comments to D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
Mon, Jul 22, 4:40 AM
grimar updated the diff for D64987: [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()..
  • Addressed review comments.
Mon, Jul 22, 4:40 AM
MaskRay committed rL366676: [ARM][test] Improve tests.
[ARM][test] Improve tests
Mon, Jul 22, 4:37 AM
jhenderson accepted D64999: [yaml2obj] - Change how we handle implicit sections..

LGTM.

Mon, Jul 22, 4:36 AM
sammccall committed rG1df6be211e4c: [clangd] Set buffer name for main file. NFCI (authored by sammccall).
[clangd] Set buffer name for main file. NFCI
Mon, Jul 22, 4:15 AM
nhaehnle added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 4:14 AM
sammccall committed rL366675: [clangd] Set buffer name for main file. NFCI.
[clangd] Set buffer name for main file. NFCI
Mon, Jul 22, 4:11 AM
ilya-biryukov added inline comments to D64863: [clangd] Ignore diags from builtin files.
Mon, Jul 22, 4:11 AM · Restricted Project
MaskRay accepted D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 4:08 AM
samparker updated the diff for D64616: [ARM][LowOverheadLoops] Fix branch target codegen.
  • renamed the nodes and the search function.
  • added support for other setcc opcodes, other than EQ and NE.
Mon, Jul 22, 4:01 AM
grimar updated the diff for D64999: [yaml2obj] - Change how we handle implicit sections..
  • Addressed review comments.
Mon, Jul 22, 3:45 AM
rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Mon, Jul 22, 3:45 AM · Restricted Project
arsenm added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 3:45 AM
jhenderson added a comment to D64281: [Object] Create MutableObject class for doing Object Mutations [Part 1].

Don't forget to update the review summary, following your changes to this patch. It still refers to "UpdatableList" which is obviously out of date. Also don't forget to use the "Update related revisions" option to show the dependency this change has on other reviews.

Don't forget this bit.

Mon, Jul 22, 3:29 AM · Restricted Project
lewis-revill added inline comments to D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Mon, Jul 22, 3:28 AM · Restricted Project
peter.smith added a comment to D65000: [ARM] Set default alignment to 64bits.

Thanks for the update. Will be worth adding some reviewers from Apple to see if this change should be IsAAPCS only. I've no more further comments myself besides a small nit on style.

Mon, Jul 22, 3:26 AM · Restricted Project
ostannard committed rL366669: [IPRA][ARM] Make use of the "returned" parameter attribute.
[IPRA][ARM] Make use of the "returned" parameter attribute
Mon, Jul 22, 3:25 AM
SjoerdMeijer updated the diff for D64744: #pragma clang loop vectorize_predicate(enable|disable).
  • Moved the codegen test to a separate file
  • Added a langref description for this new metadata node.
Mon, Jul 22, 3:21 AM · Restricted Project
kren1 created D65071: [LLVM-C][Ocaml] Add MergeFunctions and DCE pass.
Mon, Jul 22, 3:18 AM · Restricted Project
timcorringham added a comment to D64557: Add llvm.loop.licm.disable metadata.

Some cases can be undone by rematerialization, but not all, and it can involve a lot of effort which increases compile time. The metadata is a pragmatic approach which helps in some cases.

Mon, Jul 22, 3:10 AM · Restricted Project
dnsampaio added a comment to D65000: [ARM] Set default alignment to 64bits.

Set android-abi default to 128. Added tests for android and not-android.

Mon, Jul 22, 3:10 AM · Restricted Project
ilya-biryukov committed rGaf5d3b02fbc6: [clangd] Log input code of failed highlighting tests. NFC (authored by ilya-biryukov).
[clangd] Log input code of failed highlighting tests. NFC
Mon, Jul 22, 3:07 AM
ibiryukov committed rL366674: [clangd] Log input code of failed highlighting tests. NFC.
[clangd] Log input code of failed highlighting tests. NFC
Mon, Jul 22, 3:07 AM
teemperor committed rGf94668e3360e: [lldb][NFC] Tablegenify breakpoint (authored by teemperor).
[lldb][NFC] Tablegenify breakpoint
Mon, Jul 22, 3:02 AM
grimar committed rL366668: [llvm-readobj] - Stop using precompiled objects in file-headers.test.
[llvm-readobj] - Stop using precompiled objects in file-headers.test
Mon, Jul 22, 3:02 AM
ilya-biryukov committed rG0a42fe70a566: [AST] Treat semantic form of InitListExpr as implicit code in traversals (authored by ilya-biryukov).
[AST] Treat semantic form of InitListExpr as implicit code in traversals
Mon, Jul 22, 3:02 AM
teemperor committed rL366673: [lldb][NFC] Tablegenify breakpoint.
[lldb][NFC] Tablegenify breakpoint
Mon, Jul 22, 3:02 AM
ibiryukov committed rL366672: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
[AST] Treat semantic form of InitListExpr as implicit code in traversals
Mon, Jul 22, 3:02 AM
Diffusion closed D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Mon, Jul 22, 3:02 AM · Restricted Project, Restricted Project
timcorringham updated the diff for D64557: Add llvm.loop.licm.disable metadata.

Changed the metadata name to llvm.licm.disable

Mon, Jul 22, 3:02 AM · Restricted Project
kren1 created D65070: [LLVM-C][OCaml] Add a fast linker binding.
Mon, Jul 22, 3:02 AM · Restricted Project
sgraenitz committed rG3a52e50d7379: Add location of SVN staging dir to git-llvm error output (authored by sgraenitz).
Add location of SVN staging dir to git-llvm error output
Mon, Jul 22, 2:50 AM
stefan.graenitz committed rL366671: Add location of SVN staging dir to git-llvm error output.
Add location of SVN staging dir to git-llvm error output
Mon, Jul 22, 2:50 AM
Diffusion closed D65038: Add location of SVN staging dir to git-llvm error output.
Mon, Jul 22, 2:50 AM · Restricted Project
mantognini closed D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Mon, Jul 22, 2:50 AM · Restricted Project, Restricted Project
samparker created D65069: [ARM][ParallelDSP] Improve smlad search.
Mon, Jul 22, 2:50 AM
ilya-biryukov added inline comments to D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project
ilya-biryukov updated the diff for D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals.
  • Rewrite code as suggested in the review
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project
martong added inline comments to D65064: [CrossTU] Add a function to retrieve original source location..
Mon, Jul 22, 2:45 AM · Restricted Project
dnsampaio updated the diff for D65000: [ARM] Set default alignment to 64bits.
  • Set androideabi alignment to 128 bits
Mon, Jul 22, 2:45 AM · Restricted Project
gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Enable asserts since we will now fix the code while introducing the
Mon, Jul 22, 2:45 AM · Restricted Project
mantognini added an edge to rL366670: [OpenCL] Improve destructor support in C++ for OpenCL: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Mon, Jul 22, 2:45 AM
mantognini added 3 commit(s) for D64569: [OpenCL] Improve destructor support in C++ for OpenCL: rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL, rC366670: [OpenCL] Improve destructor support in C++ for OpenCL, rL366670: [OpenCL] Improve destructor support in C++ for OpenCL.
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project
mantognini added an edge to rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Mon, Jul 22, 2:45 AM
mantognini committed rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL (authored by mantognini).
[OpenCL] Improve destructor support in C++ for OpenCL
Mon, Jul 22, 2:42 AM
mantognini committed rL366670: [OpenCL] Improve destructor support in C++ for OpenCL.
[OpenCL] Improve destructor support in C++ for OpenCL
Mon, Jul 22, 2:42 AM
grimar updated the summary of D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:41 AM
martong accepted D65064: [CrossTU] Add a function to retrieve original source location..

LGTM! Thanks!

Mon, Jul 22, 2:38 AM · Restricted Project
grimar updated the summary of D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:38 AM
grimar created D65068: [Object/llvm-readobj] - Cleanup testing of the dynamic objects..
Mon, Jul 22, 2:38 AM
lenary added inline comments to D54296: [RISCV] Lower inline asm constraint A for RISC-V.
Mon, Jul 22, 2:38 AM · Restricted Project
nhaehnle added inline comments to D64862: AMDGPU/GlobalISel: RegBankSelect interp intrinsics.
Mon, Jul 22, 2:38 AM
jhenderson added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 2:38 AM
jhenderson added a comment to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

Is there a danger that by moving in this direction we loose some test coverage since we are no longer verifying the libObject can read a know set of binaries, but only that libObject can read the output yaml2obj? i.e. we could evolve the object format in llvm such that these tests would continue pass but the objects would no longer be standards compliant?

I think the pre-canned binaries don't really help us any more than yaml2obj inputs - it would be just as straightforward to tune our object reading code to work with a very specific set of binaries (unintentionally or otherwise) as it would be to work with our yaml2obj output. It's worth noting that the yaml2obj writing code and llvm-readobj reading code are not the same set of code, so we are already testing two different implementations against each other. If we change one and not the other, a test should break, alerting us to a behaviour change. We would need a good reason to change both.

Mon, Jul 22, 2:38 AM
hokein created D65067: [clangd] Fix auto expand not work on "const au^to s = 123;".
Mon, Jul 22, 2:29 AM · Restricted Project
martong resigned from D65042: [Concept] Placeholder constraints and abbreviated templates.
Mon, Jul 22, 2:28 AM · Restricted Project
nhaehnle accepted D64901: [AMDGPU][NFC] Simplify test file for amdgcn intrinsics.

LGTM

Mon, Jul 22, 2:28 AM · Restricted Project
martong added a comment to D65042: [Concept] Placeholder constraints and abbreviated templates.

ASTImporter.cpp and ASTStructuralEquivalence.cpp looks good to me!

Mon, Jul 22, 2:26 AM · Restricted Project
nhaehnle accepted D64919: TableGen: Support physical register inputs > 255.

LGTM

Mon, Jul 22, 2:25 AM
jhenderson added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

@jhenderson, can you think of an input that would cause Symbolizer->symbolizeCode(*Obj, Address) to return an Error?

I went a few calls deep underneath Symbolizer->symbolizeCode(*Obj, Address) and it looks like LLVMSymbolizer and DWARFContext return a default-constructed DILineInfo when they fail to parse the debug info. Can we cause a failure that returns an Error instead? If so we can check whether the Error is actually an ErrorInfo subclass which is how custom errors are created according to error handling Detailed Description. A better implementation of SourcePrinter::printSourceLine() might call handleErrors() instead of consumeError(). Grepping the code for handleErrors and handleAllErrors provides some example uses. First I need some inputs to cause errors so I can see whether any ErrorInfo subclasses are returned and if they have useful context which we can incorporate into our warning. This is my first time wading into LLVM's error handling so please let me know if you have any reading suggestions. In addition to the doxygen docs for Error.h I also found a section on error handling in the programmer's manual.

Mon, Jul 22, 2:16 AM · Restricted Project
nhaehnle added a comment to D64726: AMDGPU/GlobalISel: Fix not constraining result reg of copies to VCC.

Okay, the possibility of an AssertZext is an interesting point. So let me try the other way around: What would the MIR at this stage look like to enforce an and?

Mon, Jul 22, 2:11 AM
peter.smith added reviewers for D65000: [ARM] Set default alignment to 64bits: srhines, danalbert.

I think that this may not apply for Android as AFAIK their ABI still requires 128-bit alignment in some cases. Adding some more reviewers from Android.

Mon, Jul 22, 2:08 AM · Restricted Project
skatkov updated the diff for D64983: [Loop Peeling] Introduce an option for full peeling disabling.

the variable and option name changed.

Mon, Jul 22, 2:04 AM · Restricted Project
skatkov updated the diff for D64972: [Loop Peeling] Do not close further unroll/peel if profile based peeling was not used.

Test is updated to show what this patch changes.

Mon, Jul 22, 2:03 AM · Restricted Project
skatkov added a comment to D64972: [Loop Peeling] Do not close further unroll/peel if profile based peeling was not used.

I'm not quite sure this is the right macro approach.

The comment near the code your modifying makes me thing the whole reasoning behind disabling future peeling and unrolling after the first peel may be flawed. It doesn't make sense to "use up" profiling information. Assuming we correctly updated our profiling when doing the transform, the resulting profile for the loop should indicate that it's cold and thus not profitable to further peel/unroll. If that's not happening, maybe there's another issue in play? (I wonder if your other profile bug fix may help here?)

p.s. I'm opened to being convinced that this is a practical answer, even if not an ideal one. Just make the argument. :)

Mon, Jul 22, 2:02 AM · Restricted Project
ostannard committed rG6771a89fa01f: [IPRA][ARM] Make use of the "returned" parameter attribute (authored by ostannard).
[IPRA][ARM] Make use of the "returned" parameter attribute
Mon, Jul 22, 1:58 AM
rampitec added a comment to D64946: [AMDGPU] Fix trivial PHI into SI_END_CF..

How about the following simpler logic:

  • if the PHI is used by any basic-block prologue instruction (except other PHIs), then insert the COPY at the top of the basic block
  • otherwise, insert the COPY after the basic-block prologue

In this case COPY in the prologue also shall be marked as prologue instruction somehow.

You're right, my idea doesn't work.

Mon, Jul 22, 1:57 AM · Restricted Project
ostannard closed D64986: [IPRA][ARM] Make use of the "returned" parameter attribute.
Mon, Jul 22, 1:51 AM · Restricted Project
jhenderson added a comment to D65040: [llvm-objcopy] Add support for --add-section for COFF.

Please make sure to update the documentation at llvm/docs/CommandGuide/llvm-objcopy.rst to move this switch out of the ELF-specific directory.

Mon, Jul 22, 1:51 AM · Restricted Project
grimar added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 1:51 AM
nhaehnle added a comment to D64935: [AMDGPU] Add llvm.amdgcn.softwqm intrinsic.

Okay thanks, I see the logic now.

Mon, Jul 22, 1:48 AM · Restricted Project
gchatelet added a comment to D64786: [Polly] Clang complains about missing virtual destructor.

A gentle ping. It's a one liner and should be reviewed easily :)

Mon, Jul 22, 1:48 AM · Restricted Project
ostannard added a comment to D63932: [GlobalDCE] Dead Virtual Function Elimination.

Ping.

Mon, Jul 22, 1:48 AM · Restricted Project, Restricted Project
nhaehnle added a comment to D64946: [AMDGPU] Fix trivial PHI into SI_END_CF..

How about the following simpler logic:

  • if the PHI is used by any basic-block prologue instruction (except other PHIs), then insert the COPY at the top of the basic block
  • otherwise, insert the COPY after the basic-block prologue

In this case COPY in the prologue also shall be marked as prologue instruction somehow.

Mon, Jul 22, 1:48 AM · Restricted Project
nhaehnle added a comment to D64508: AMDGPU: Force s_waitcnt after GWS instructions.

My understanding is that this is mostly related to CWSR. The trap handler has to be able to "replay" the GWS instruction.

Mon, Jul 22, 1:40 AM
jhenderson added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 1:39 AM
wuzish added a comment to D64195: [PowerPC] Replace float load/store pair with integer load/store pair when it's only used in load/store.

Gentle pin..

Mon, Jul 22, 1:39 AM · Restricted Project
nhaehnle added a comment to D63281: [TargetLowering] Add SimplifyMultipleUseDemandedBits.

The AMDGPU changes seem fine to me overall.

Mon, Jul 22, 1:39 AM · Restricted Project
avl added a comment to D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

Converting a dbg.value into a dbg.declare implicitly extends the duration ("lifetime" in the docs [0]) of the variable location from "until the next dbg.value" to "the entire scope". Consider what happens if we make the modifications here [1] to your test case. Imagine an IR producer that wants to temporarily bind some variable to a field of 'result' (the dbg.value added with DW_OP_deref), and later assigns '1' to the variable with the second dbg.value, to cover the rest of the function.

Mon, Jul 22, 1:32 AM · Restricted Project, debug-info
nhaehnle added a comment to D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Thanks! Could you please also add a test to Analysis/ValueTracking/memory-dereferenceable.ll?

Mon, Jul 22, 1:31 AM · Restricted Project
avl updated the diff for D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass..

added check for aggregate dbg.value.

Mon, Jul 22, 1:27 AM · Restricted Project, debug-info
ostannard accepted D64406: [ARM][AArch64] Cortex-A65AE, Neoverse E1 and Neoverse N1 support.

LGTM

Mon, Jul 22, 1:22 AM · Restricted Project
grimar committed rG6522a7df544e: [llvm-readobj] - Stop using precompiled objects in file-headers.test (authored by grimar).
[llvm-readobj] - Stop using precompiled objects in file-headers.test
Mon, Jul 22, 1:20 AM
dmgreen added a parent revision for D65066: [ARM] Disable MVE fptosi and friends: D65062: [ARM] More MVE compare vector splat combines for AND's.
Mon, Jul 22, 1:17 AM · Restricted Project
grimar closed D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

r366668

Mon, Jul 22, 1:17 AM
dmgreen added a child revision for D65062: [ARM] More MVE compare vector splat combines for AND's: D65066: [ARM] Disable MVE fptosi and friends.
Mon, Jul 22, 1:17 AM · Restricted Project
dmgreen created D65066: [ARM] Disable MVE fptosi and friends.
Mon, Jul 22, 1:17 AM · Restricted Project
grimar added a comment to D64800: [llvm-readobj] - Stop using precompiled objects in file-headers.test.

I am going to commit this to free road for another patches. If during futher discussion(s)
will be decided to keep these or other binaries checked in for something, we can do it
in a follow-up independent commit(s) with appropriate test case(s) and comment(s) about
how exactly binaries were produced and for what we keep them.

Mon, Jul 22, 1:17 AM
bruntib created D65065: [clang-tidy] Possibility of displaying duplicate warnings.
Mon, Jul 22, 1:08 AM · Restricted Project
SjoerdMeijer accepted D65062: [ARM] More MVE compare vector splat combines for AND's.

looks okay to me.

Mon, Jul 22, 1:04 AM · Restricted Project
SjoerdMeijer accepted D65061: [ARM] MVE compare vector splat combine.

LGTM

Mon, Jul 22, 1:04 AM · Restricted Project
SjoerdMeijer added inline comments to D65059: [ARM] Better OR's for MVE compares.
Mon, Jul 22, 12:58 AM · Restricted Project
sdesmalen added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Mon, Jul 22, 12:58 AM · Restricted Project
grimar added inline comments to D64999: [yaml2obj] - Change how we handle implicit sections..
Mon, Jul 22, 12:50 AM
SjoerdMeijer accepted D65058: [ARM] Better AND's for MVE compares.

Looks like a good optimisation to me.

Mon, Jul 22, 12:50 AM · Restricted Project
grimar updated the diff for D64999: [yaml2obj] - Change how we handle implicit sections..
  • Addressed review comments.
Mon, Jul 22, 12:50 AM
SjoerdMeijer accepted D65053: [ARM] Basic And/Or/Xor handling for MVE predicates.

looks reasonable

Mon, Jul 22, 12:50 AM · Restricted Project
balazske added a comment to D64554: [CrossTU] Add a function to retrieve original source location..

New patch:
https://reviews.llvm.org/D65064

Mon, Jul 22, 12:50 AM · Restricted Project, Restricted Project
balazske added a child revision for D65064: [CrossTU] Add a function to retrieve original source location.: D64638: [CrossTU] Fix plist macro expansion if macro in other file..
Mon, Jul 22, 12:44 AM · Restricted Project