Page MenuHomePhabricator
Feed All Stories

Today

RKSimon added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

@epastor This is causing build bots failures, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3121

Sat, Jan 18, 5:29 AM · Restricted Project
saar.raz committed rGbaa84d8cde94: Revert "[Concepts] Requires Expressions" (authored by saar.raz).
Revert "[Concepts] Requires Expressions"
Sat, Jan 18, 5:02 AM
saar.raz added a reverting change for rG027931899763: [Concepts] Requires Expressions: rGbaa84d8cde94: Revert "[Concepts] Requires Expressions".
Sat, Jan 18, 5:02 AM
RKSimon updated subscribers of rG932b5d6fcad1: [test] Fix tests after D52810.
Sat, Jan 18, 4:33 AM
bjope added inline comments to D72938: Fix an assertion failure in DwarfExpression's subregister composition.
Sat, Jan 18, 4:23 AM · Restricted Project, debug-info
nikic created D72976: [PatternMatch] Make m_c_ICmp swap the predicate (PR42801).
Sat, Jan 18, 4:14 AM · Restricted Project
thakis added a comment to D50360: [Concepts] Requires Expressions.

This breaks tests on non-Win, see e.g. http://45.33.8.238/linux/7846/step_7.txt http://45.33.8.238/mac/6120/step_7.txt

Sat, Jan 18, 3:57 AM · Restricted Project
xbolva00 added a comment to D72916: [IPO] Don't run jump threading at Oz.

I agree that adjusting BBDuplicateThreshold for code size is better choice than disabling the whole pass.

Sat, Jan 18, 3:39 AM · Restricted Project
RKSimon committed rG69bc450882fc: [X86] Rename lowerShuffleAsRotate -> lowerShuffleAsVALIGN (authored by RKSimon).
[X86] Rename lowerShuffleAsRotate -> lowerShuffleAsVALIGN
Sat, Jan 18, 3:32 AM
nikic created D72975: [PatternMatch] Add m_APInt/m_APFloat matchers accepting undef.
Sat, Jan 18, 3:30 AM · Restricted Project
RKSimon committed rG47c88bf709d4: [X86][SSE] Add some v16i8 reverse + endian swap style shuffle tests (authored by RKSimon).
[X86][SSE] Add some v16i8 reverse + endian swap style shuffle tests
Sat, Jan 18, 3:12 AM
samparker added a comment to D72916: [IPO] Don't run jump threading at Oz.

Thanks, you both are indeed right that it can reduce code size... I've now tried reducing BBDuplicateThreshold and it looks like halving this to 3 is the best option (for aarch64 at least). There's a couple of outliers, but most changes are -0.1%:
test-suite...otout/Shootout-nestedloop.test 484 468 -3.3%
test-suite...+/Shootout-C++-nestedloop.test 532 516 -3.0%
test-suite...Olden/perimeter/perimeter.test 2108 2148 1.9%
test-suite...urce/Applications/aha/aha.test 2964 2932 -1.1%
test-suite...ce/Benchmarks/PAQ8p/paq8p.test 53748 53964 0.4%
test-suite...ch/g721/g721encode/encode.test 5468 5452 -0.3%
test-suite...marks/Ptrdist/yacr2/yacr2.test 15204 15236 0.2%
test-suite...ications/JM/ldecod/ldecod.test 161116 160788 -0.2%
test-suite...marks/7zip/7zip-benchmark.test 469784 470728 0.2%
test-suite...chmarks/MallocBench/gs/gs.test 104228 104428 0.2%
test-suite...oxyApps-C/miniAMR/miniAMR.test 34260 34196 -0.2%
test-suite...ications/JM/lencod/lencod.test 380324 380996 0.2%
test-suite...plications/d/make_dparser.test 62816 62912 0.2%
test-suite...s-C/Pathfinder/PathFinder.test 15996 15972 -0.2%
test-suite...ks/Prolangs-C++/city/city.test 5428 5436 0.1%
test-suite.../Benchmarks/Ptrdist/bc/bc.test 27300 27260 -0.1%
test-suite...pplications/oggenc/oggenc.test 105776 105632 -0.1%
test-suite...-typeset/consumer-typeset.test 327944 327520 -0.1%
test-suite...lications/sqlite3/sqlite3.test 244704 244400 -0.1%
test-suite...tions/lambda-0.1.3/lambda.test 20092 20068 -0.1%
test-suite.../Prolangs-C/bison/mybison.test 35828 35788 -0.1%
test-suite...peg2/mpeg2dec/mpeg2decode.test 29916 29884 -0.1%
test-suite.../Applications/SPASS/SPASS.test 287832 288136 0.1%
test-suite...arching-flt/Searching-flt.test 8292 8284 -0.1%
test-suite...arching-dbl/Searching-dbl.test 8500 8492 -0.1%
test-suite...C/Packing-flt/Packing-flt.test 8548 8540 -0.1%
test-suite...ences-flt/Recurrences-flt.test 8644 8636 -0.1%
test-suite...t/StatementReordering-flt.test 8660 8652 -0.1%
test-suite...encode/alacconvert-encode.test 26044 26020 -0.1%
test-suite...decode/alacconvert-decode.test 26044 26020 -0.1%
test-suite...C/Packing-dbl/Packing-dbl.test 8756 8748 -0.1%
test-suite...lications/SIBsim4/SIBsim4.test 26476 26500 0.1%
test-suite...ences-dbl/Recurrences-dbl.test 8852 8844 -0.1%
test-suite...l/StatementReordering-dbl.test 8868 8860 -0.1%
test-suite...ing-flt/LoopRerolling-flt.test 9116 9108 -0.1%
test-suite...ing-flt/Equivalencing-flt.test 9268 9260 -0.1%
test-suite...ing-flt/NodeSplitting-flt.test 9276 9268 -0.1%
test-suite...ing-dbl/LoopRerolling-dbl.test 9340 9332 -0.1%
test-suite...mbolics-flt/Symbolics-flt.test 9364 9356 -0.1%
test-suite...ing-dbl/Equivalencing-dbl.test 9420 9412 -0.1%
test-suite...ing-dbl/NodeSplitting-dbl.test 9476 9468 -0.1%
test-suite...mbolics-dbl/Symbolics-dbl.test 9588 9580 -0.1%
test-suite...lt/IndirectAddressing-flt.test 9708 9700 -0.1%
test-suite...bl/IndirectAddressing-dbl.test 9924 9916 -0.1%
test-suite...lt/CrossingThresholds-flt.test 9940 9932 -0.1%
test-suite...cations/hexxagon/hexxagon.test 10124 10132 0.1%
test-suite...bl/CrossingThresholds-dbl.test 10148 10140 -0.1%
test-suite...flt/InductionVariable-flt.test 10204 10196 -0.1%
test-suite...flt/LoopRestructuring-flt.test 10436 10428 -0.1%
test-suite...ow-flt/GlobalDataFlow-flt.test 10452 10444 -0.1%
test-suite...dbl/InductionVariable-dbl.test 10468 10460 -0.1%
test-suite...oops-flt/ControlLoops-flt.test 10588 10580 -0.1%
test-suite...dbl/LoopRestructuring-dbl.test 10644 10636 -0.1%
test-suite...ow-dbl/GlobalDataFlow-dbl.test 10660 10652 -0.1%
test-suite...oops-dbl/ControlLoops-dbl.test 10780 10772 -0.1%
test-suite...pansion-flt/Expansion-flt.test 10996 10988 -0.1%
test-suite...-flt/LinearDependence-flt.test 11148 11140 -0.1%
test-suite...pansion-dbl/Expansion-dbl.test 11196 11188 -0.1%
test-suite...ctions-flt/Reductions-flt.test 11316 11308 -0.1%
test-suite...-dbl/LinearDependence-dbl.test 11364 11356 -0.1%
test-suite...ctions-dbl/Reductions-dbl.test 11524 11516 -0.1%
test-suite...sc-C++/stepanov_container.test 13132 13140 0.1%
test-suite...lFlow-flt/ControlFlow-flt.test 13764 13756 -0.1%
test-suite...lFlow-dbl/ControlFlow-dbl.test 13972 13964 -0.1%
Geomean difference -0.0%

default-results    threshold-3        diff

count 310.000000 310.000000 310.000000
mean 26375.587097 26377.445161 -0.000273
std 65478.305060 65501.068235 0.002870
min 460.000000 460.000000 -0.033058
25% 1286.000000 1286.000000 0.000000
50% 3128.000000 3128.000000 0.000000
75% 11262.000000 11260.000000 0.000000
max 469784.000000 470728.000000 0.018975

Sat, Jan 18, 2:46 AM · Restricted Project
dmgreen added inline comments to D72919: [AArch64] Add custom store lowering for 256 bit non-temporal stores..
Sat, Jan 18, 2:31 AM · Restricted Project
craig.topper added inline comments to D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together..
Sat, Jan 18, 1:02 AM · Restricted Project
craig.topper updated the diff for D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together..

Rebase. Regenerate with a hacked script to show the real stack offsets for reviewing. I'll regenerate before commiting so the next person who runs the script won't get a surprise.

Sat, Jan 18, 12:54 AM · Restricted Project

Yesterday

saar.raz committed rG027931899763: [Concepts] Requires Expressions (authored by saar.raz).
[Concepts] Requires Expressions
Fri, Jan 17, 11:21 PM
saar.raz closed D50360: [Concepts] Requires Expressions.
Fri, Jan 17, 11:21 PM · Restricted Project
hliao added a comment to D72709: [codegen,amdgpu] Enhance MIR DIE and re-arrange it for AMDGPU..

yeah, here one example

Fri, Jan 17, 11:02 PM · Restricted Project
hliao added a comment to D72941: Handle ptrtoint in InferAddressSpace.

inttoptr and ptrtoint should be treated as opaque ones. If needed, they should be handled with target-specific. This pass is definitely not the place to handle them.

Fri, Jan 17, 10:53 PM · Restricted Project
hliao committed rG6d0d86a64d30: [DAG] Add helper for creating constant vector index with correct type. NFC. (authored by hliao).
[DAG] Add helper for creating constant vector index with correct type. NFC.
Fri, Jan 17, 10:24 PM
mehdi_amini retitled D72933: Adds CastSliceOp to the vector ops dialect. from BEGIN_PUBLIC Adds CastSliceOp to the vector ops dialect. to Adds CastSliceOp to the vector ops dialect..
Fri, Jan 17, 10:15 PM · Restricted Project
annita.zhang added a comment to D72463: [Driver][X86] Add -malign-branch* and -mbranches-within-32B-boundaries.

@MaskRay Did you merge it to LLVM 10 branch?

It is included in the release branch.

git branch origin/release/10.x --contains 5ca24d09aefaedf8e4148c7fce4b4ab0c4ecc72a # suceeded

Fri, Jan 17, 9:34 PM · Restricted Project
friss committed rG546f8f426463: [lldb/testsuite] Modernize 2 test Makefiles (authored by friss).
[lldb/testsuite] Modernize 2 test Makefiles
Fri, Jan 17, 9:07 PM
friss committed rG509b78883d4f: [lldb/Makefile.rules] Force the default target to be 'all' (authored by friss).
[lldb/Makefile.rules] Force the default target to be 'all'
Fri, Jan 17, 9:07 PM
yonghong-song added a comment to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.

@tstellar Thanks for your comments. The MachineInstr SSA based optimization is really a ugly hack. Currently verifier is not able to verify the program correctly, i.e., rejects the program for certain patterns related subregister uses. The commit message provides more information. @ast suggested to look at whether we can improve kernel verifier and I will take a look there. If kernel can be enhanced, I will drop the second MachineInstr SSA pass.

Fri, Jan 17, 8:39 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:30 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:21 PM · Restricted Project
tstellar added a comment to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.

I may not quite understand what the verifier is looking for here, but rather than trying to undo the optimization in 2 different places, would it be possible to implement this by having the InstructionSelector emit some kind of Pseudo Instruction for inputs to the comparison? For example, what would normally be selected to:

Fri, Jan 17, 8:21 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:21 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Removing space

Fri, Jan 17, 8:12 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Thanks River for the review. Addressed your comments.

Fri, Jan 17, 8:12 PM · Restricted Project
merge_guards_bot added a comment to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 8:02 PM · Restricted Project
kariddi updated the diff for D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..

Testing the change by adapting existing test

Fri, Jan 17, 7:46 PM · Restricted Project
rriddle requested changes to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:44 PM · Restricted Project
rriddle added inline comments to D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:44 PM · Restricted Project
aemerson added a comment to D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..

My initial reaction was that the PHI was invalid, but according to @qcolombet it's ok to have different register banks on the operands

Okay... but the operand register class can't actually be *anything*, can it? We have restrictions on COPY instructions.

Those restrictions are target specific though aren’t they? I think it’s the responsibility of ISel to generate valid copies and similar should apply to PHIs.

Fri, Jan 17, 7:36 PM · Restricted Project
kariddi created D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types..
Fri, Jan 17, 7:35 PM · Restricted Project
yonghong-song added inline comments to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.
Fri, Jan 17, 7:35 PM · Restricted Project
ast added inline comments to D72787: [BPF] Adjust optimizations to generate kernel verifier friendly codes.
Fri, Jan 17, 7:25 PM · Restricted Project
DiggerLin created D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D.
Fri, Jan 17, 7:16 PM · Restricted Project
stella.stamenova added a comment to D72957: [mlir] Unbreak MSVC build with implicit constructor.

With the latest VS 2019, the error is still the same (MSVC 19.24).

Fri, Jan 17, 7:16 PM · Restricted Project
MaskRay committed rG9aacec8331d9: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol (authored by MaskRay).
[ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol
Fri, Jan 17, 6:58 PM
MaskRay added a reverting change for rGb841e119d77e: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC: rG9aacec8331d9: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol.
Fri, Jan 17, 6:58 PM
jasonmolenda accepted D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC).

Yep, looks good.

Fri, Jan 17, 6:58 PM · Restricted Project
Harbormaster failed remote builds in B44333: Diff 238937 for D72972: [WebAssembly] Add experimental multivalue calling ABI!
Fri, Jan 17, 6:50 PM · Restricted Project
merge_guards_bot added a comment to D72972: [WebAssembly] Add experimental multivalue calling ABI.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 6:49 PM · Restricted Project
tlively created D72972: [WebAssembly] Add experimental multivalue calling ABI.
Fri, Jan 17, 6:39 PM · Restricted Project
JDevlieghere added a comment to D72940: Add a support for clang tidy to import another configurations files from .clang-tidy.

Please upload the diff with full context. This would also need a test.

Fri, Jan 17, 6:21 PM · Restricted Project, Restricted Project
dblaikie committed rG58b10df54ffd: DebugInfo: Move SectionLabel tracking into CU's addRange (authored by dblaikie).
DebugInfo: Move SectionLabel tracking into CU's addRange
Fri, Jan 17, 6:20 PM
JDevlieghere created D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC).
Fri, Jan 17, 6:11 PM · Restricted Project
arsenm updated the diff for D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass.

Formatting

Fri, Jan 17, 6:01 PM · Restricted Project
arsenm added inline comments to D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass.
Fri, Jan 17, 6:01 PM · Restricted Project
rjmccall accepted D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c.

LGTM

Fri, Jan 17, 6:01 PM
MaskRay accepted D72517: [lld/ELF] PR44498: Support input filename in double quote.

LG. It may be worth waiting for other opinions.

Fri, Jan 17, 6:01 PM · Restricted Project
MaskRay added a comment to D72968: [lld][ELF] Don't apply --fix-cortex-a53-843419 to relocatable links..

Can you check with GNU ld, if --fix-cortex-a53-843419 is ignored when -r is specified?

Fri, Jan 17, 5:52 PM · Restricted Project
kkwli0 added a reviewer for D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]: dreachem.
Fri, Jan 17, 5:42 PM
dexonsmith created D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c.
Fri, Jan 17, 5:42 PM
dblaikie added inline comments to D72812: [IR] Module's NamedMD table needn't be 'void *'.
Fri, Jan 17, 5:42 PM · Restricted Project
dblaikie committed rG46ed93315fce: [IR] Remove some unnecessary cleanup in Module's dtor, and use a unique_ptr to… (authored by dblaikie).
[IR] Remove some unnecessary cleanup in Module's dtor, and use a unique_ptr to…
Fri, Jan 17, 5:34 PM
dschuff committed rGff171acf8420: [WebAssembly] Track frame registers through VReg and local allocation (authored by dschuff).
[WebAssembly] Track frame registers through VReg and local allocation
Fri, Jan 17, 5:33 PM
DieGoldeneEnte added a comment to D72903: [HIP] use GetProgramPath for executable discovery.

If @yaxunl has no objections, could someone merge this as I don't have commit access?
Also do we want to also apply this to older versions, since the change is trivial? I confirmed the same problem is in clang 8, 9 and 10 and am certain it is in clang 7, although I didn't test it, because I don't have appropriate device-libs at hand.

Fri, Jan 17, 5:33 PM · Restricted Project
anemet accepted D72280: [Matrix] Add IR MatrixBuilder..

LGTM, however it would better if this patch also converted existing code to use this new API.

Fri, Jan 17, 5:33 PM · Restricted Project
dschuff abandoned D72969: [WebAssembly] Track frame registers through VReg and local allocation.

This was (re)landed as rGff171acf8

Fri, Jan 17, 5:33 PM · Restricted Project
wristow updated the diff for D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction.

Updated patch to correct a comment and fix a typo.

Fri, Jan 17, 5:33 PM · Restricted Project
merge_guards_bot added a comment to D72969: [WebAssembly] Track frame registers through VReg and local allocation.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 5:24 PM · Restricted Project
Harbormaster failed remote builds in B44332: Diff 238931 for D72969: [WebAssembly] Track frame registers through VReg and local allocation!
Fri, Jan 17, 5:24 PM · Restricted Project
jpienaar accepted D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Looks good thanks

Fri, Jan 17, 5:23 PM · Restricted Project, Restricted Project
DieGoldeneEnte abandoned D72806: [HIP] fix paths for executables not in clang bin directory.

Adding the paths for llvm/lld is not needed, because GetProgramPath is actually also searching in $PATH. This means D72903 already is enough to fix my problem.

Fri, Jan 17, 5:23 PM · Restricted Project
flaub committed rGee2de95507a1: [MLIR] LLVM dialect: modernize and cleanups (authored by flaub).
[MLIR] LLVM dialect: modernize and cleanups
Fri, Jan 17, 5:15 PM
arsenm committed rGdf7900e21824: TableGen/GlobalISel: Don't check exact intrinsic opcode value (authored by arsenm).
TableGen/GlobalISel: Don't check exact intrinsic opcode value
Fri, Jan 17, 5:15 PM
arsenm committed rGa4451d88ee45: Consolidate internal denormal flushing controls (authored by arsenm).
Consolidate internal denormal flushing controls
Fri, Jan 17, 5:15 PM
flaub closed D72967: [MLIR] LLVM dialect: modernize and cleanups.
Fri, Jan 17, 5:15 PM · Restricted Project
arsenm committed rG592de0009f64: AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp (authored by arsenm).
AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp
Fri, Jan 17, 5:15 PM
arsenm committed rGec9628318d79: AMDGPU/GlobalISel: Select DS append/consume (authored by arsenm).
AMDGPU/GlobalISel: Select DS append/consume
Fri, Jan 17, 5:14 PM
arsenm closed D69878: Consoldiate internal denormal flushing controls.

a4451d88ee456304c26d552749aea6a7f5154bde

Fri, Jan 17, 5:14 PM · Restricted Project
dblaikie added a comment to D71932: [DWARF] Better detect errors in Address Range Tables..

Thanks for the review!

Looks good - future work done as separate patches for separable changes/diagnostics would probably be good (& if you've got some broader goals in terms of what functionality you need/would like in llvm-dwarfdump, an email to llvm-dev explaining the broader goals (do they overlap with James Henderson's goals, improving the line table error handling?) would probably be good - to link to in future reviews, etc)

My main intention is to add support for 64-bit DWARF.

Fri, Jan 17, 5:14 PM · Restricted Project, debug-info
arsenm closed D72918: AMDGPU/GlobalISel: Select DS append/consume.

ec9628318d797bfe036aca314d58665dd93b364f

Fri, Jan 17, 5:14 PM · Restricted Project
arsenm closed D72925: AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp.

592de0009f6482fbf033ef87d147aab13fcce78c

Fri, Jan 17, 5:14 PM · Restricted Project
dschuff updated subscribers of D72969: [WebAssembly] Track frame registers through VReg and local allocation.

Oops, this is just the diff from D71681 (which was committed as rG3a05c3969c18 and reverted), but not the whole patch.
I'll reland the whole thing together, but if @yurydelendik or @sunfish have comments I'm happy to hear them.

Fri, Jan 17, 5:14 PM · Restricted Project
dblaikie accepted D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing.
Fri, Jan 17, 5:14 PM · Restricted Project
efriedma added a comment to D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass..

My initial reaction was that the PHI was invalid, but according to @qcolombet it's ok to have different register banks on the operands

Fri, Jan 17, 5:05 PM · Restricted Project
phosek added inline comments to D72950: [CMake] compiler-rt: Add COMPILER_RT_BUILTINS_ENABLE_PIC.
Fri, Jan 17, 5:05 PM · Restricted Project, Restricted Project
merge_guards_bot added a comment to D72967: [MLIR] LLVM dialect: modernize and cleanups.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 5:05 PM · Restricted Project
ikudrin added a comment to D71932: [DWARF] Better detect errors in Address Range Tables..

Thanks for the review!

Fri, Jan 17, 5:05 PM · Restricted Project, debug-info
dschuff created D72969: [WebAssembly] Track frame registers through VReg and local allocation.
Fri, Jan 17, 5:05 PM · Restricted Project
dblaikie accepted D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal.

Out of curiosity: what's your broader goal with this work? (it'll help understand what's in-scope and out of scope, and better understand the framing when reviewing changes)

There's two parts to this:

  1. Making it easier for consumers to continue and try to do something with slightly bad output. One of the problems with using the unrecoverable errors is that it prevents people even trying to iterate over later tables.
  2. (this one's not specific to this patch, but some other patches in this area I've been doing are related): we have some local code that uses the DebugInfo library to read a line table. In order for this code to be sound, we need to make sure the line table makes sense. The parser in its current state doesn't pick up on a number of bad situations, so we added some local patches to detect these other errors (local because we didn't have time at that point to try to push them into the open source). We'd like to now get these into the opensource library, to avoid merge conflicts.
Fri, Jan 17, 5:05 PM · Restricted Project
arsenm added a comment to rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs.

Hello! Your test specifically looks for "248", which is failing with my downstream embedded ARM compiler (we produce "249"); other similar tests that I've looked at simply ignore this value. Is there a reason why you need to check it specifically?

No, that can be anything.

Fri, Jan 17, 4:55 PM
efriedma added a comment to D72646: [zorg] Pass "-DLLVM_POLLY_LINK_INTO_TOOLS=ON" in getPollyBuildFactory.

It looks like the build isn't passing the new flag to cmake. Does the buildbot need to be restarted?

Fri, Jan 17, 4:55 PM
shenhan added a comment to D68062: Propeller lld framework for basicblock sections.

Hello, over the past 2 months since our first draft of Propeller, we've made huge changes/improvements and this describes what happens -http://lists.llvm.org/pipermail/llvm-dev/2020-January/138426.html

Fri, Jan 17, 4:55 PM · Restricted Project
rnk committed rG423e3db6a820: Remove unneeded FoldingSet.h include from Attributes.h (authored by rnk).
Remove unneeded FoldingSet.h include from Attributes.h
Fri, Jan 17, 4:46 PM
Harbormaster failed remote builds in B44328: Diff 238924 for D72957: [mlir] Unbreak MSVC build with implicit constructor!
Fri, Jan 17, 4:46 PM · Restricted Project
alanphipps added a comment to rG03a592f18ba5: TableGen/GlobalISel: Fix srcvalue inputs.

Hello! Your test specifically looks for "248", which is failing with my downstream embedded ARM compiler (we produce "249"); other similar tests that I've looked at simply ignore this value. Is there a reason why you need to check it specifically?

Fri, Jan 17, 4:46 PM
Harbormaster failed remote builds in B44327: Diff 238923 for D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue!
Fri, Jan 17, 4:46 PM · Restricted Project
flaub updated the diff for D72967: [MLIR] LLVM dialect: modernize and cleanups.
  • clang-format
Fri, Jan 17, 4:46 PM · Restricted Project
efriedma created D72968: [lld][ELF] Don't apply --fix-cortex-a53-843419 to relocatable links..
Fri, Jan 17, 4:46 PM · Restricted Project
merge_guards_bot added a comment to D72957: [mlir] Unbreak MSVC build with implicit constructor.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 4:46 PM · Restricted Project
merge_guards_bot added a comment to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Fri, Jan 17, 4:46 PM · Restricted Project
sivachandra committed rGc7453fad0625: [libc] Replace the use of gtest with a new light weight unittest framework. (authored by sivachandra).
[libc] Replace the use of gtest with a new light weight unittest framework.
Fri, Jan 17, 4:37 PM
xazax.hun updated subscribers of D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

This patch breaks scan-build-py which parses the output of "-###" to get -cc1 command. There might be other tools with the same problems. Could we either remove (in-process) from CC1Command::Print or add a line break?

Fri, Jan 17, 4:37 PM · Restricted Project, Restricted Project
sivachandra closed D72743: [libc] Replace the use of gtest with a new light weight unittest framework..
Fri, Jan 17, 4:36 PM · Restricted Project