Page MenuHomePhabricator
Feed All Stories

Today

thakis committed rGa7b9e98fd8e2: gn build: Merge r361264 (authored by thakis).
gn build: Merge r361264
Tue, May 21, 7:40 AM
hintonda accepted D62174: [Analysis] Link library dependencies to Analysis plugins.

LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks!

Tue, May 21, 7:39 AM · Restricted Project, Restricted Project
atanasyan updated the diff for D62166: [mips] Always check that `shift and add` optimization is efficient.
  • Simplify the loop condition
Tue, May 21, 7:39 AM · Restricted Project
nico committed rL361267: gn build: Merge r361264.
gn build: Merge r361264
Tue, May 21, 7:39 AM
MaskRay committed rG5ea0d06e8168: [ELF] Deleted unused ComdatGroups member variable left by D61854 (authored by MaskRay).
[ELF] Deleted unused ComdatGroups member variable left by D61854
Tue, May 21, 7:38 AM
MaskRay committed rLLD361266: [ELF] Deleted unused ComdatGroups member variable left by D61854.
[ELF] Deleted unused ComdatGroups member variable left by D61854
Tue, May 21, 7:38 AM
MaskRay committed rL361266: [ELF] Deleted unused ComdatGroups member variable left by D61854.
[ELF] Deleted unused ComdatGroups member variable left by D61854
Tue, May 21, 7:38 AM
sheredom created D62198: StructurizeCFG: Relax uniformity checks..
Tue, May 21, 7:37 AM · Restricted Project
yaxunl updated the diff for D62197: [OpenCL] Fix file-scope const sampler variable for 2.0.

Add full diff.

Tue, May 21, 7:37 AM
ABataev accepted D60568: [OpenMP] Add support for registering requires directives with the runtime.

LG. Please, commit it only after the runtime part is committed.

Tue, May 21, 7:37 AM · Restricted Project
aaron.ballman committed rG86abee8185c1: Add support for dumping AST comment nodes to JSON. (authored by aaron.ballman).
Add support for dumping AST comment nodes to JSON.
Tue, May 21, 7:37 AM
ilya-biryukov committed rG6c0531222ad0: [Syntax] Rename TokensTest to SyntaxTests. NFC (authored by ilya-biryukov).
[Syntax] Rename TokensTest to SyntaxTests. NFC
Tue, May 21, 7:36 AM
aaronballman committed rC361265: Add support for dumping AST comment nodes to JSON..
Add support for dumping AST comment nodes to JSON.
Tue, May 21, 7:36 AM
aaronballman committed rL361265: Add support for dumping AST comment nodes to JSON..
Add support for dumping AST comment nodes to JSON.
Tue, May 21, 7:35 AM
ibiryukov committed rC361264: [Syntax] Rename TokensTest to SyntaxTests. NFC.
[Syntax] Rename TokensTest to SyntaxTests. NFC
Tue, May 21, 7:35 AM
ibiryukov committed rL361264: [Syntax] Rename TokensTest to SyntaxTests. NFC.
[Syntax] Rename TokensTest to SyntaxTests. NFC
Tue, May 21, 7:35 AM
yaxunl created D62197: [OpenCL] Fix file-scope const sampler variable for 2.0.
Tue, May 21, 7:34 AM
NikolaPrica updated the diff for D61600: [DebugInfo] More precise variable range for stack locations.

-Rebase
-Change referenced scope to function scope for variable "b" in fisson-ranges.ll

Tue, May 21, 7:34 AM · debug-info
NikolaPrica added a child revision for D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location: D61600: [DebugInfo] More precise variable range for stack locations.
Tue, May 21, 7:33 AM · debug-info
NikolaPrica added a parent revision for D61600: [DebugInfo] More precise variable range for stack locations: D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
Tue, May 21, 7:33 AM · debug-info
NikolaPrica removed a child revision for D61600: [DebugInfo] More precise variable range for stack locations: D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
Tue, May 21, 7:33 AM · debug-info
NikolaPrica added a parent revision for D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location: D61600: [DebugInfo] More precise variable range for stack locations.
Tue, May 21, 7:33 AM · debug-info
NikolaPrica removed a parent revision for D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location: D61600: [DebugInfo] More precise variable range for stack locations.
Tue, May 21, 7:33 AM · debug-info
NikolaPrica added a child revision for D61600: [DebugInfo] More precise variable range for stack locations: D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
Tue, May 21, 7:33 AM · debug-info
MaskRay updated the diff for D59649: [ELF] Improve error message for relocations to symbols defined in discarded sections.

Rebase after recent SymbolTable changes. Combined with D61583, we will give good warnings for PR41693

Tue, May 21, 7:33 AM · Restricted Project
NikolaPrica created D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
Tue, May 21, 7:30 AM · debug-info
ilya-biryukov added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests binary while this adds a new binary TokensTest. Can you say why?

(No change needed, just curious.)

Tue, May 21, 7:30 AM · Restricted Project
JonChesterfield added a comment to D62132: [RFC] Intrinsics for Hardware Loops.

I've implemented this out of tree (for Graphcore), based loosely on the PPC implementation. IR pass based on SCEV inserts intrinsics, SDag patches them up a little, MIR pass picks appropriate instructions or falls back to a decrement and branch loop.

Tue, May 21, 7:30 AM
umanwizard added a comment to D61865: [clangd] improve help message for limit-results.

@kadircet what are the next steps? This is my first diff in llvm. I'm not a project member so presumably someone else will have to land it for me.

Tue, May 21, 7:30 AM · Restricted Project
jdenny added inline comments to D61643: [PragmaHandler][NFC] Expose `#pragma` location.
Tue, May 21, 7:30 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Remove new option.
Tue, May 21, 7:26 AM · Restricted Project
pree-jackie added a comment to D62139: Ensuring unique names for JITDylib's.

Thanks :)
Then we can change parameter type of createJITDylib to StringRef instead of std::string.

Tue, May 21, 7:25 AM · Restricted Project
sammccall added a comment to D61637: [Syntax] Introduce syntax trees.

Definitely like the choice of CompositeNode owning the concrete storage!

Tue, May 21, 7:24 AM · Restricted Project
jdenny added inline comments to D61643: [PragmaHandler][NFC] Expose `#pragma` location.
Tue, May 21, 7:24 AM · Restricted Project
courbet committed rG8361a10493c5: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only." (authored by courbet).
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
courbet committed rL361263: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only.".
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
thakis committed rG440dd6df339a: gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format` (authored by thakis).
gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Tue, May 21, 7:23 AM
nico committed rL361262: gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`.
gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Tue, May 21, 7:23 AM
javed.absar committed rG603a2bac05a8: [ARM][CMSE] Add commandline option and feature macro (authored by javed.absar).
[ARM][CMSE] Add commandline option and feature macro
Tue, May 21, 7:23 AM
thakis committed rGe289e9883781: gn build: Merge r361252 (authored by thakis).
gn build: Merge r361252
Tue, May 21, 7:23 AM
javed.absar committed rL361261: [ARM][CMSE] Add commandline option and feature macro.
[ARM][CMSE] Add commandline option and feature macro
Tue, May 21, 7:23 AM
javed.absar committed rC361261: [ARM][CMSE] Add commandline option and feature macro.
[ARM][CMSE] Add commandline option and feature macro
Tue, May 21, 7:23 AM
javed.absar closed D59879: [ARM][CMSE] Add commandline option and feature macro.
Tue, May 21, 7:22 AM · Restricted Project
xbolva00 added inline comments to rG8fa970c2d871: [MergeICmps][NFC] Make BCEAtom move-only..
Tue, May 21, 7:22 AM
jasonliu updated the diff for D61948: Implement call lowering without parameters on AIX.
Tue, May 21, 7:22 AM · Restricted Project
john.brawn added a comment to D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation.

Please verify my understanding of the following is correct:

  1. getTypeUnadjustedAlign() is currently only used to compute calling convention alignment for ARM and AArch64.

Yes, the only places it's called are AArch64ABIInfo::classifyArgumentType and ARMABIInfo::classifyArgumentType.

Tue, May 21, 7:22 AM · Restricted Project
hintonda abandoned D62154: [cmake] Revert part of r360991 "[Analysis] Only run plugins tests if plugins are actually enabled" that unilaterally disabled plugins.

D62174 is a better solution.

Tue, May 21, 7:22 AM · Restricted Project
nico committed rL361260: gn build: Merge r361252.
gn build: Merge r361252
Tue, May 21, 7:18 AM
russell.gallop added a comment to D62063: CMake changes to get Windows self-host with PGO working.

2). Self hosting with -fprofile-generate hits a crash building CrashRecoveryContext.cpp. I'll try to report this.

Tue, May 21, 7:16 AM · Restricted Project
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

Following a remark from @jhenderson , and in order to make sure the options filtered out are not relevant, I've been running a clang-based script to compute the application callgraph, registering all calls to `llvm::cl` commands and their parent.

Tue, May 21, 7:12 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

@courbet Please can you ensure you have EXPENSIVE_CHECKS enabled in all your builds before going any further - you've been breaking the buildbots for well over a week now and you still haven't fixed the underlying issue.

Tue, May 21, 7:11 AM · Restricted Project
thakis committed rG8287b973f0b5: gn build: Merge r361233 (authored by thakis).
gn build: Merge r361233
Tue, May 21, 7:09 AM
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

For reference, toe output of -help with and without filtering:

Tue, May 21, 7:09 AM · Restricted Project
nico committed rL361259: gn build: Merge r361233.
gn build: Merge r361233
Tue, May 21, 7:08 AM
serge-sans-paille created D62195: Properly categorize llvm-objdump options.
Tue, May 21, 7:07 AM · Restricted Project
gchatelet accepted D62193: [MergeICmps] Make sorting strongly stable on the rhs..
Tue, May 21, 7:07 AM · Restricted Project
Pierre updated the diff for D60763: Prototype OpenCL BIFs using Tablegen.
Tue, May 21, 7:01 AM · Restricted Project
Pierre added a comment to D60763: Prototype OpenCL BIFs using Tablegen.

The wrong patch was uploaded. Sorry for this.

Tue, May 21, 7:01 AM · Restricted Project
shixiao added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

@JonasToth, does this look reasonable to you? Thanks!

Tue, May 21, 7:01 AM · Restricted Project
sberg updated the diff for D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO".

Of course, adding missing tests reveals shortcomings in the new code.

Tue, May 21, 7:01 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, May 21, 7:01 AM · Restricted Project
arsenm created D62194: AMDGPU: Fix not marking new gfx10 SGPRs as CSRs.
Tue, May 21, 6:52 AM
arsenm added reviewers for D62162: Fix register coalescer failure to prune value: MatzeB, qcolombet.
Tue, May 21, 6:50 AM
arsenm added a comment to D62162: Fix register coalescer failure to prune value.

I managed to reduce the test a bit more: https://ghostbin.com/paste/72n9f

Tue, May 21, 6:50 AM
djtodoro added inline comments to D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Tue, May 21, 6:49 AM
courbet created D62193: [MergeICmps] Make sorting strongly stable on the rhs..
Tue, May 21, 6:45 AM · Restricted Project
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Use map instead of vector for storing debug entry values
-TODO: Land a separate patch with renaming DMI-->DebugInstr

Tue, May 21, 6:44 AM · debug-info
lebedev.ri added inline comments to D62191: [SelectionDAG] define binops as a superset of commutative binops.
Tue, May 21, 6:44 AM · Restricted Project
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Improve the verifier for entry values
-Add test for the verifier

Tue, May 21, 6:40 AM · debug-info
sammccall committed rG0321b370f2db: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to… (authored by sammccall).
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
Tue, May 21, 6:39 AM
sammccall committed rCTE361258: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to….
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
Tue, May 21, 6:39 AM
sammccall committed rL361258: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to….
[clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to…
Tue, May 21, 6:39 AM
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Use SPCache instead of DeclCache
-Refactor the code by addressing suggestions

Tue, May 21, 6:39 AM · debug-info
sammccall closed D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it..
Tue, May 21, 6:38 AM · Restricted Project, Restricted Project
spatel added inline comments to D62191: [SelectionDAG] define binops as a superset of commutative binops.
Tue, May 21, 6:38 AM · Restricted Project
sammccall accepted D62137: [Frontend] Return an error on bad inputs to PrecompiledPreabmle.
Tue, May 21, 6:37 AM · Restricted Project
tpr added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

LGTM, but I don't think I know the legalization code well enough to approve this.

Tue, May 21, 6:35 AM · Restricted Project
courbet committed rG8fa970c2d871: [MergeICmps][NFC] Make BCEAtom move-only. (authored by courbet).
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:33 AM
kib added a comment to D42748: [ELF] Don't create a .dynamic section when linking with -Bstatic.

@arichardson
If the MIPS problem was similar to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236165 ,
moving away from &_DYNAMIC will be a more reliable approach.
To check if an executable is dynamically linked, inspecting PT_INTERP is a better choice.

Checking if a weak undefined symbol has zero address is unreliale.
Some compilers may produce a GOT-generating relocation, some may produce an absolute relocation.
After linking, you may see the relocation resolved to static 0, or see a dynamic relocation (if at runtime there is some module providing the dynamic symbol, the weak reference will resolve to non-zero)

Quoting http://www.sco.com/developers/gabi/latest/ch4.symtab.html

The behavior of weak symbols in areas not specified by this document is implementation defined. Weak symbols are intended primarily for use in system software. Applications using weak symbols are unreliable since changes in the runtime environment might cause the execution to fail.

Regarding this patch. Actually, -Bstatic (synonym of -static in ld.bfd and lld) just means: "don't look for libfoo.so when a -lfoo is seen, before next -Bdynamic". I think it is weird to use it to decide whether we should emit .dynamic . (In the compiler drivers (gcc/clang/etc), -static mean static linking, but that is different from -Bstatic/-static in ld.bfd/lld.)

This change neither improves similarity with ld.bfd nor makes behaviors reasonable that suits lld (the internals of lld are very different from ld.bfd, some behaviors of ld.bfd may not suit lld). The logic to emit .dynamic .dynsym .dynstr etc in the 3 linkers:

lld: has_dso || --shared || --pie || --export-dynamic
gold: has_dso || --shared || --pie
bfd: (--shared || --pie) || ((not -r) && info->nointerp && (info->export_dynamic || info->dynamic)) && some (almost always true) conditions

@ed I want to knore more about your motivation to add --export-dynamic to the condition in D29982. Why do you need .dynamic in a position dependent executable for CloudABI, which has no shared object dependency on the linker command line?

Tue, May 21, 6:33 AM · Restricted Project
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Set EnableDebugEntryValues only for a higher level of optimizations (-O1 and higher)

Tue, May 21, 6:33 AM · debug-info
dtemirbulatov added a comment to D57779: [SLP] Add support for throttling..

I think the first throttling patch should implement a very simple and fast algorithm for finding the cut:

  1. Add new fields to TreeEntry for Cost, ExtractCost and PredecessorsCost.
  2. During getTreeCost() set the TE.Cost and TE.ExtractCost (as you did in an earlier version of the patch if I am not mistaken)
  3. Do a single top-down traversal of the tree in reverse postorder and set the TE.PredecessorsCost equal to the cost of all the predecessor's costs until TE. While doing so, you can compare the cost of cutting just below TE by comparing the gather cost of TE versus the Cost + PredecessorsCost. This is very fast as you only need to visit each TreeEntry node once, so the complexity is linear to the size of the tree.

    For example, in slp-throttle.ll the bundle that needs to be scalarized [%add19, %sub22] has costs of Cost=1, ExtractCost = 0, PredecessorsCost=1 (because of bundle [%mul18, undef]). Cutting below the bundle has a cost of +1, while keeping it vectorized has a cost of +2 (Cost=1 + PredecessorsCost=1).

    This should be good-enough for most simple cases. We can improve it later, if needed, with follow-up patches. What do you think?

yes, Looks good.

Tue, May 21, 6:33 AM
courbet committed rL361257: [MergeICmps][NFC] Make BCEAtom move-only..
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:31 AM
ABataev added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, May 21, 6:29 AM · Restricted Project
kpn updated subscribers of D43515: More math intrinsics for conservative math handling.
Tue, May 21, 6:28 AM
probinson committed rG35a2196bd116: Fix typo in r361251. (authored by probinson).
Fix typo in r361251.
Tue, May 21, 6:24 AM
tatyana-krasnukha committed rGe0cc56e038df: [lldb-mi] Include full path in the -data-disassemble response (authored by tatyana-krasnukha).
[lldb-mi] Include full path in the -data-disassemble response
Tue, May 21, 6:24 AM
lebedev.ri added inline comments to D62191: [SelectionDAG] define binops as a superset of commutative binops.
Tue, May 21, 6:24 AM · Restricted Project
ymandel added a comment to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..

Ping. Is anyone willing to be the reviewer for this revision?

Tue, May 21, 6:24 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
Tue, May 21, 6:24 AM
ymandel abandoned D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings..

This ideas in this revisions are gradually being committed.

Tue, May 21, 6:24 AM · Restricted Project
zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

And this patch actually fixes the bug. Thanks.

Tue, May 21, 6:24 AM
probinson committed rL361256: Fix typo in r361251..
Fix typo in r361251.
Tue, May 21, 6:20 AM
tkrasnukha committed rLLDB361255: [lldb-mi] Include full path in the -data-disassemble response.
[lldb-mi] Include full path in the -data-disassemble response
Tue, May 21, 6:20 AM
tkrasnukha committed rL361255: [lldb-mi] Include full path in the -data-disassemble response.
[lldb-mi] Include full path in the -data-disassemble response
Tue, May 21, 6:20 AM
Diffusion closed D59015: [lldb-mi] Include full path in the -data-disassemble response.
Tue, May 21, 6:20 AM · Restricted Project, Restricted Project
ymandel abandoned D59329: [LibTooling] Add NodeId, a strong type for AST-matcher node identifiers..
Tue, May 21, 6:20 AM · Restricted Project
GitHub <noreply@github.com> committed rG7e3f23819272: Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into… (authored by Robert Andrzejuk <robert-andrzejuk@users.noreply.github.com>).
Merge c7fdfa0e73876f9d1381409f20503ee2425d3809 into…
Tue, May 21, 6:11 AM
E5ten added a comment to D61909: Add Clang shared library with C++ exports.

I might be doing something wrong but this seems to have broken BUILD_SHARED_LIBS for me in that even with that enabled clang is built as a bunch of static libraries linked into a shared one like this patch is supposed to make it do, while I thought that BUILD_SHARED_LIBS was supposed to make it create a bunch of shared libraries as it did before with libclang and still does with libLLVM.

Tue, May 21, 6:11 AM · Restricted Project
lebedev.ri accepted D62191: [SelectionDAG] define binops as a superset of commutative binops.

Looks good to me.

Tue, May 21, 6:11 AM · Restricted Project
MaskRay requested changes to D42748: [ELF] Don't create a .dynamic section when linking with -Bstatic.
Tue, May 21, 6:11 AM · Restricted Project