Page MenuHomePhabricator
Feed All Stories

Today

jhuber6 updated the diff for D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

Updating to use @MaskRay's suggestion.

Mon, May 23, 1:55 PM · Restricted Project, Restricted Project
MaskRay accepted D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

Perhaps wait a day or so in case others have opinions.

Mon, May 23, 1:49 PM · Restricted Project, Restricted Project
Meinersbur accepted D71989: [OpenMP][IRBuilder] `omp task` support.
Mon, May 23, 1:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header..

LGTM. Please wait for @fhahn LGTM as well.

Mon, May 23, 1:47 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D125649: [ARM SEH 7] [ARM] Adjust the frame pointer when it's needed for SEH unwinding.

Updated after rebasing and updating earlier patches, no functional change since last update.

Mon, May 23, 1:44 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering.

No longer need to disable PostRAScheduler, and fixed tail merging by setting the MachineInst::NoMerge flag.

Mon, May 23, 1:43 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D125647: [ARM SEH 5] [MC] [Win64EH] Check that the SEH unwind opcodes match the actual instructions.

Added checks to make sure that prologs and epilogs are properly terminated, and epilog start/end are paired correctly. This gives clearer indication if there were issues in code generation (like epilogs being mangled by tail merging).

Mon, May 23, 1:42 PM · Restricted Project, Restricted Project
florinpapa added a comment to D90006: Exposes interface to free up caching data structure in DWARFDebugLine and DWARFUnit for memory management.

Hello, this change was approved. Could one of the reviewers help commit this, since I don't have permissions? The failing tests look like unrelated flakes, as they are timeouts and seem to fail differently after each rebase.

Mon, May 23, 1:41 PM · Restricted Project, Restricted Project, debug-info
jpienaar requested review of D126238: [mlir][python] Move results types to keyword-only arg..
Mon, May 23, 1:41 PM · Restricted Project, Restricted Project
gkistanova accepted D126156: Added libc docs to SphinxDocsBuilder..

LGTM.

Mon, May 23, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
reames added a comment to D126236: [CaptureTracking] Increase limit but use it for all visited uses..

Basic idea makes a lot of sense. I'd be tempted to take some cost here, just for the robustness.

Mon, May 23, 1:36 PM · Restricted Project, Restricted Project
hctim committed rGcead4eceb01b: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals (authored by hctim).
[symbolizer] Parse DW_TAG_variable DIs to show line info for globals
Mon, May 23, 1:31 PM · Restricted Project, Restricted Project
hctim closed D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Mon, May 23, 1:30 PM · Restricted Project, Restricted Project, Restricted Project
aeubanks added a comment to D126236: [CaptureTracking] Increase limit but use it for all visited uses..

this makes sense

Mon, May 23, 1:30 PM · Restricted Project, Restricted Project
aeubanks added inline comments to D126089: [WPD] Make sure type test is eliminated.
Mon, May 23, 1:24 PM · Restricted Project, Restricted Project
Amir added inline comments to D126237: [BOLT][NFC] Print block instructions in dumpGraph as part of node label.
Mon, May 23, 1:23 PM · Restricted Project, Restricted Project
Amir published D126232: [BOLT][NFC] Customize endline character for printInstruction(s) for review.
Mon, May 23, 1:23 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Fix func.func

Mon, May 23, 1:22 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D125648: [ARM SEH 6] [ARM] Add SEH opcodes in frame lowering.

For scheduling, the AArch64 backend overrides "isSchedulingBoundary()" for SEH instructions.

Mon, May 23, 1:20 PM · Restricted Project, Restricted Project
Amir abandoned D125945: [BOLT][NFC] Dump function CFG into html, rendered in browser using d3-graphviz.

I thought about it and now I don't think embedding html and javascript code into BOLT binary is a good idea.
A better approach would be to embed dot file into html template using an external tool: D126218.

Mon, May 23, 1:17 PM · Restricted Project, Restricted Project
ayermolo updated the diff for D126087: [BOLT][DWARF] Fix TU Index handling for DWARF4/5..

missed llvm-dwp

Mon, May 23, 1:16 PM · Restricted Project, Restricted Project
Amir published D126237: [BOLT][NFC] Print block instructions in dumpGraph as part of node label for review.
Mon, May 23, 1:16 PM · Restricted Project, Restricted Project
Amir published D126218: [BOLT][UTILS] Add dot2html helper tool to embed dot into html for review.
Mon, May 23, 1:15 PM · Restricted Project, Restricted Project
sotiris <sotiris@sotiris-Intel-MacBook-Air.local> committed rG97c3ef5c8a28: [SelectOpti][2/5] Select-to-branch base transformation (authored by apostolakis).
[SelectOpti][2/5] Select-to-branch base transformation
Mon, May 23, 1:14 PM · Restricted Project, Restricted Project
sotiris <sotiris@sotiris-Intel-MacBook-Air.local> closed D122259: [SelectOpti][2/5] Select-to-branch base transformation.
Mon, May 23, 1:14 PM · Restricted Project, Restricted Project
clayborg accepted D122974: prevent ConstString from calling djbHash() more than once.
Mon, May 23, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
paulkirth added a comment to D126224: Add DWARF string debug to clang release notes..

I'm going to try to summarize an offline discussion w/ @mcgrathr about this here:

Mon, May 23, 1:12 PM · Restricted Project, Restricted Project
hgreving updated the diff for D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header..
Mon, May 23, 1:12 PM · Restricted Project, Restricted Project
MaskRay added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

IIRC there is no built-in way supporting multiple (but fixed number of) values for an option (e.g. -Xoffload-linker-<triple> <arg>). In D105330 (llvm-nm option refactoring) I used a hack to support -s __DATA __data.
The multiple-value support for OptTable does not allow positional arguments after the option.

Mon, May 23, 1:11 PM · Restricted Project, Restricted Project
clayborg accepted D124704: [lldb] save ConstString hash value to cache files too.

One small nit in the code you can choose to fix or not. LGTM. Thanks for the improvements!

Mon, May 23, 1:10 PM · Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

David's comments.

Mon, May 23, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
stella.stamenova committed rG12bae5f3e2d2: Remove duplicate fields in RAGreedy (authored by qunyanm).
Remove duplicate fields in RAGreedy
Mon, May 23, 1:09 PM · Restricted Project, Restricted Project
stella.stamenova closed D125926: Remove duplicate fields in RAGreedy.
Mon, May 23, 1:08 PM · Restricted Project, Restricted Project
fhahn updated the diff for D126236: [CaptureTracking] Increase limit but use it for all visited uses..

Update patch to actually use 100 as limit

Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
maksfb updated the diff for D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

Address feedback.

Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
fhahn requested review of D126236: [CaptureTracking] Increase limit but use it for all visited uses..
Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
maksfb added a comment to D126101: [MCDisassembler] Fix MCSymbolizer::tryAddingSymbolicOperand() interface.

Thank you for the review.

Mon, May 23, 1:04 PM · Restricted Project, Restricted Project
clayborg accepted D126225: Fix lldb-vscode frame test failure.

Since this "optimized" value isn't part of the actual JSON schema for the stack frames, and since we aren't using it in the IDE, best to remove this until it is either in the protocol definition or used by the IDE.

Mon, May 23, 1:03 PM · Restricted Project, Restricted Project
clayborg added a comment to D126059: [Debuginfo][DWARF][NFC] Add paired methods working with DWARFDebugInfoEntry..

A 1 to 2 percent improvement is probably going to go away if the asserts are enabled when it has to do the check each time. If would still hesitate to add this kind of API as it will encourage others to use the APIs. I would be ok with it if the methods are protected or private and if we can add the DWARFLinker as a friend class to allow access to these performant but dangerous APIs only in certain situations that really require it. I really want to avoid most people from being able to use these APIs if possible to make sure we don't end up with bugs. We had many many bugs that stemmed from mismatching DWARFUnit + DWARFDebugIntoEntry before the DWARFDie class was created, mostly when doing cross CU references or in Fission cases where you have the skeleton CU vs the actual DWO CU + a DWARFDebugInfoEntry that comes from the actual DWO file. So there is a real danger to the safety and correctness of the code here.

Mon, May 23, 1:00 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

It's better to avoid JoinedAndSeparate for new options. It is for --xxx val and --xxxval but not intended for the option this patch will add.

Mon, May 23, 12:56 PM · Restricted Project, Restricted Project
MaskRay requested changes to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

It's better to avoid JoinedAndSeparate for new options. It is for --xxx val and --xxxval but not intended for the option this patch will add.

Mon, May 23, 12:51 PM · Restricted Project, Restricted Project
sivachandra requested review of D126235: [libc] Add the pthread_mutex_t type..
Mon, May 23, 12:51 PM · Restricted Project, Restricted Project
probinson committed rG217531f12b4b: [PS5] Make driver's PIC behavior match PS4 (authored by probinson).
[PS5] Make driver's PIC behavior match PS4
Mon, May 23, 12:51 PM · Restricted Project, Restricted Project
florinpapa updated the diff for D90006: Exposes interface to free up caching data structure in DWARFDebugLine and DWARFUnit for memory management.

Perform rebase.

Mon, May 23, 12:49 PM · Restricted Project, Restricted Project, debug-info
ayermolo added a comment to D124892: [DWARF] Fix split dwarf debug inlining in mix mode situation..

With ThinLTO enabled we can have a function in a CU that doesn't have split dwarf inlining enabled that gets inlined into CU that has it enabled.
When we try to lookup Abstract Scope Die for the inlined scope in constructInlinedScopeDIE, it's not present and we assert.

So it seems there's probably some disconnect between the logic that adds abstract scope DIEs and the logic that looks them up? (one's using the source CU, one's using the destination CU?) - can you confirm that/which one's doing which?

& maybe them consistent would be good/suitable - I guess the right behavior is probably to treat the non-split-dwarf-inlining function as having no debug info for the purposes of the place it's inlined into?

Mon, May 23, 12:48 PM · Restricted Project, Restricted Project
ldionne committed rG6cb3fdc278b9: [libc++] Remove duplicate tests for callable concepts (authored by ldionne).
[libc++] Remove duplicate tests for callable concepts
Mon, May 23, 12:39 PM · Restricted Project, Restricted Project
stella.stamenova committed rGe7afa23366f5: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests (authored by stella.stamenova).
[mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests
Mon, May 23, 12:39 PM · Restricted Project, Restricted Project
stella.stamenova closed D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests.
Mon, May 23, 12:38 PM · Restricted Project, Restricted Project
jrbyrnes updated the diff for D125997: [AMDGPU] Instruction Type Pipeline.

Addressed review comments:

  1. Added options for sizing of specific instruction groups
  2. Renamed the DAG Mutation -- renaming suggests welcomed.
  3. Minor details
Mon, May 23, 12:36 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.

Maybe also worth to check gcc's issues with this transformation:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91734

Mon, May 23, 12:35 PM · Restricted Project, Restricted Project
fhahn requested review of D126234: [AArch64] Add support for FMA intrinsics to shouldSinkOperands..
Mon, May 23, 12:33 PM · Restricted Project, Restricted Project
reames added a comment to D125270: [riscv] Remove mutation of prior vsetvli from insertion dataflow.

ping

Mon, May 23, 12:30 PM · Restricted Project, Restricted Project
jhuber6 updated the summary of D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.
Mon, May 23, 12:30 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

Changing the -Xoffload-linker= to -Xoffload-linker-.

Mon, May 23, 12:30 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

You do not need to hardcode it. The idea of JoinedAndSeparate is that an option foo assepts two argumants, one glued to it and another following after a whitespace.
So, when you define an option -Xoffload-linker-, and then pass -Xoffload-linker-nvptx64=foo, you will get OPT_offload-linker__ with two arguments. As an example see implementation of plugin_arg which deals with the same kind of problem of passing arguments to an open-ended set of plugins.

Mon, May 23, 12:29 PM · Restricted Project, Restricted Project
fhahn committed rG86617256864e: [AArch64] Add tests with free shuffles for indexed fma variants. (authored by fhahn).
[AArch64] Add tests with free shuffles for indexed fma variants.
Mon, May 23, 12:28 PM · Restricted Project, Restricted Project
roberteg16 updated the diff for D126172: [clang] Fix comparison of TemplateArgument when they are of template kind.

Fix wrongly moved clang-format disabling comment when trying to fix clang-format

Mon, May 23, 12:27 PM · Restricted Project, Restricted Project
ABataev added a comment to D114171: [SLP]Improve reductions analysis and emission, part 1..

And finally a reduced test case:

$ cat q.cc
struct S {
  template<int N>
  bool f() const;
};
int f(const S& s) {
  int d = 0;
  if (s.f<1>()) ++d;
  // 4998 lines skipped
  if (s.f<5000>()) ++d;
  if (d == 0) {
    return s.f<-1>();
  }
  return 0;
}
$ ./clang-11004 --target=x86_64--linux-gnu -O1 -fslp-vectorize  -c -xc++
q.cc -o q.o -ftime-report
===-------------------------------------------------------------------------===
                      ... Pass execution timing report ...
===-------------------------------------------------------------------------===
  Total Execution Time: 8.7398 seconds (8.8367 wall clock)

   ---User Time---   --System Time--   --User+System--   ---Wall Time---
 --- Name ---
   7.9827 ( 91.6%)   0.0081 ( 29.3%)   7.9908 ( 91.4%)   8.0861 ( 91.5%)
 SLPVectorizerPass
   0.1950 (  2.2%)   0.0002 (  0.6%)   0.1952 (  2.2%)   0.1962 (  2.2%)
 InstCombinePass
...
Mon, May 23, 12:25 PM · Restricted Project, Restricted Project
paulwalker-arm committed rG84acdd32ca91: [SVEInstrFormats] Ensure scatter instructions are named consistently. (authored by paulwalker-arm).
[SVEInstrFormats] Ensure scatter instructions are named consistently.
Mon, May 23, 12:24 PM · Restricted Project, Restricted Project
tra added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

We already use this approach for the -Xopenmp-target=<triple> <arg> option that forwards arguments to the given toolchain, so that's what I was using as a basis.

Mon, May 23, 12:22 PM · Restricted Project, Restricted Project
ABataev committed rG319a722f6fca: [SLP][NFC]Improve compile time, NFC. (authored by ABataev).
[SLP][NFC]Improve compile time, NFC.
Mon, May 23, 12:19 PM · Restricted Project, Restricted Project
antiagainst updated the summary of D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Mon, May 23, 12:16 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Mon, May 23, 12:15 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Remove vector.fma generation

Mon, May 23, 12:15 PM · Restricted Project, Restricted Project
wrengr requested review of D126233: [mlir][sparse] Factoring out SparseTensorFile class for readSparseTensorShape.
Mon, May 23, 12:12 PM · Restricted Project, Restricted Project
jhuber6 updated the summary of D126231: [External][CUDA] Add option to test with the new driver.
Mon, May 23, 12:05 PM · Restricted Project
avl added a comment to D126059: [Debuginfo][DWARF][NFC] Add paired methods working with DWARFDebugInfoEntry..

You mention performance concerns - even in an optimized build?

Mon, May 23, 12:03 PM · Restricted Project, Restricted Project
antiagainst accepted D126120: [mlir][vector] Add new lowering mode to vector.contractionOp.

Nice, thanks for this, Thomas!

Mon, May 23, 12:00 PM · Restricted Project, Restricted Project
yln committed rG1962389979be: [Sanitizer][Darwin] Add explanation for Apple platform macros (authored by yln).
[Sanitizer][Darwin] Add explanation for Apple platform macros
Mon, May 23, 12:00 PM · Restricted Project, Restricted Project
yln closed D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.
Mon, May 23, 11:59 AM · Restricted Project, Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rG7ffc99bedcd2: [gn build] Port eebc1fb772c5 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port eebc1fb772c5
Mon, May 23, 11:56 AM · Restricted Project, Restricted Project
rsundahl accepted D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.
Mon, May 23, 11:55 AM · Restricted Project, Restricted Project
avl added a comment to D125979: [ADT] add LockFreeDataPool class..

(any chance we can avoid duplicating this, and instead refactor the lld one into LLVM and have lld use that one instead of using its own local copy?)

Mon, May 23, 11:55 AM · Restricted Project, Restricted Project
rsundahl added a comment to D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.

LGTM (I'd like to see SANTIZER_OSX become SANITIZER_MACOS at some point for consistency.)

Mon, May 23, 11:55 AM · Restricted Project, Restricted Project
jhuber6 requested review of D126231: [External][CUDA] Add option to test with the new driver.
Mon, May 23, 11:53 AM · Restricted Project
spatel added inline comments to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.
Mon, May 23, 11:52 AM · Restricted Project, Restricted Project
philnik committed rG40f7fca3d91f: [libc++] Add ranges::max_element to the synopsis and ADL-proof the… (authored by philnik).
[libc++] Add ranges::max_element to the synopsis and ADL-proof the…
Mon, May 23, 11:51 AM · Restricted Project, Restricted Project
philnik closed D126167: [libc++] Add ranges::max_element to the synopsis and ADL-proof the __min_element_impl calls.
Mon, May 23, 11:50 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

-Xoffload-linker=<triple> <arg>

The syntax is confusing. Normally only triple would be the argument for -Xoffload-linker option.
Having both -Xoffload-linker and -Xoffload-linker= variants also looks odd to me.

In effect you're making -Xoffload-linker=foo a full option (as opposed to it being an option -Xoffload-linker= + argument foo) with a separate argument that follows. I guess that might work, but it's a rather unconventional use of command line parser, IMO.

I think the main issue with this approach is that it makes the command line hard to understand. When one sees -Xsomething=a -b it's impossible to tell whether -b is a regular option or something to be passed to -Xsomething=a. My assumption would be the former as -Xsomething= already got its argument a and should have no business grabbing the next one.

I think it would work better if the option could use a - or`_` for the variant that passes the triple. E.g. -Xoffload-linker-nvptx64=-foo or -Xoffload-linker-nvptx64 -foo would be easily interpretable.

Mon, May 23, 11:50 AM · Restricted Project, Restricted Project
antiagainst abandoned D126004: [mlir][vector] Canonicalize contract to fma when possible.

Not needed anymore.

Mon, May 23, 11:50 AM · Restricted Project, Restricted Project
philnik committed rG19e21d91bc17: [libc++] Add auto to the list of required extensions in C++03 (authored by philnik).
[libc++] Add auto to the list of required extensions in C++03
Mon, May 23, 11:50 AM · Restricted Project, Restricted Project
philnik closed D126165: [libc++] Add auto to the list of required extensions in C++03.
Mon, May 23, 11:49 AM · Restricted Project, Restricted Project
philnik committed rG570390580567: [libc++] Assume that push_macro and pop_macro are available (authored by philnik).
[libc++] Assume that push_macro and pop_macro are available
Mon, May 23, 11:48 AM · Restricted Project, Restricted Project
philnik closed D126073: [libc++] Assume that push_macro and pop_macro are available.
Mon, May 23, 11:48 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D126230: [mlir] Add global_load and global_store ops to ml_program..

Note: design discussion continuing on discourse: https://discourse.llvm.org/t/rfc-introduce-ml-program-dialect-and-top-level-ops-proposal-v2/60907/51

Mon, May 23, 11:48 AM · Restricted Project, Restricted Project
philnik committed rGb177a90ce7b5: [libc++] Always enable the ranges concepts (authored by philnik).
[libc++] Always enable the ranges concepts
Mon, May 23, 11:45 AM · Restricted Project, Restricted Project
philnik closed D124011: [libc++] Always enable the ranges concepts.
Mon, May 23, 11:45 AM · Restricted Project, Restricted Project
tra requested changes to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.
Mon, May 23, 11:45 AM · Restricted Project, Restricted Project
tra added a comment to D126226: [OpenMP] Add `-Xoffload-linker` to forward input to the device linker.

The syntax is confusing. Normally only triple would be the argument for -Xoffload-linker option.
Having both -Xoffload-linker and -Xoffload-linker= variants also looks odd to me.

Mon, May 23, 11:44 AM · Restricted Project, Restricted Project
philnik committed rGeebc1fb772c5: [libc++] Granularize parts of <type_traits> (authored by philnik).
[libc++] Granularize parts of <type_traits>
Mon, May 23, 11:44 AM · Restricted Project, Restricted Project
philnik closed D124755: [libc++] Granularize parts of <type_traits>.
Mon, May 23, 11:44 AM · Restricted Project, Restricted Project
Carrot added a comment to D125588: [MachineCombiner] Improve MachineCombiner's cost model.

I tested SPEC2006 int on my skylake desktop.

Mon, May 23, 11:43 AM · Restricted Project, Restricted Project
stellaraccident requested review of D126230: [mlir] Add global_load and global_store ops to ml_program..
Mon, May 23, 11:42 AM · Restricted Project, Restricted Project
steakhal planned changes to D126215: [analyzer] Deprecate `-analyzer-store region` flag.

We should support deprecated analyzer flags for at least one release. In this case I'm planning to drop this flag in clang-17

Should we emit a warning for the user about the deprecation?

Mon, May 23, 11:35 AM · Restricted Project, Restricted Project
akyrtzi abandoned D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

This has been superseded by the above set of patches.

Mon, May 23, 11:35 AM · Restricted Project, Restricted Project
yln requested review of D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.
Mon, May 23, 11:34 AM · Restricted Project, Restricted Project
jgorbe committed rGf0a61c2ce2af: Remove `friend` classes from TypeCategoryMap (authored by jgorbe).
Remove `friend` classes from TypeCategoryMap
Mon, May 23, 11:33 AM · Restricted Project
jgorbe closed D126103: Remove `friend` classes from TypeCategoryMap.
Mon, May 23, 11:32 AM · Restricted Project, Restricted Project
avl added a comment to D125979: [ADT] add LockFreeDataPool class..

The name is not descriptive. It misses the important words about "hash map". ConcurrentHashMap may be a better name.

Mon, May 23, 11:31 AM · Restricted Project, Restricted Project
rsuderman committed rGbedd3ee88152: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse. (authored by NatashaKnk).
[mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse.
Mon, May 23, 11:30 AM · Restricted Project, Restricted Project