Page MenuHomePhabricator
Feed All Stories

Today

silvas committed rG853a61486475: [mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer. (authored by silvas).
[mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer.
Mon, Jun 14, 6:03 PM
silvas closed D104274: [mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer..
Mon, Jun 14, 6:03 PM · Restricted Project
rriddle accepted D104274: [mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer..
Mon, Jun 14, 6:00 PM · Restricted Project
jacobhegna updated the diff for D104251: Remove ML inlining model artifacts..

Update to use constant policy.

Mon, Jun 14, 5:48 PM · Restricted Project
srj added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.

Since there is a bug and a repro case, I'd like to ask if this change can be rolled back until a proper fix is in order.

Mon, Jun 14, 5:40 PM · Restricted Project
srj added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.

I've gotten a repro case. Created https://bugs.llvm.org/show_bug.cgi?id=50709 with details. Please let me know if I should replicate details here instead.

Mon, Jun 14, 5:37 PM · Restricted Project
mtrofin added a comment to D104028: [WIP] Use standard priority queue to order inlining.

With the introduction of the flag, there shouldn't be any more failing tests, right?

Yes, all tests pass.

Mon, Jun 14, 5:34 PM · Restricted Project
silvas requested review of D104274: [mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer..
Mon, Jun 14, 5:34 PM · Restricted Project
taolq added a comment to D104028: [WIP] Use standard priority queue to order inlining.

With the introduction of the flag, there shouldn't be any more failing tests, right?

Mon, Jun 14, 5:32 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

clang-format fix.

Mon, Jun 14, 5:24 PM · Restricted Project
lxfind added inline comments to D104184: [Coroutine] Properly deal with byval and noalias parameters.
Mon, Jun 14, 5:22 PM · Restricted Project
efriedma added a comment to D78586: [MachineVerifier] Add more checks for registers in live-in lists..

Updated list of failures; it's now going up...

Mon, Jun 14, 5:20 PM · Restricted Project
efriedma updated the summary of D78586: [MachineVerifier] Add more checks for registers in live-in lists..
Mon, Jun 14, 5:17 PM · Restricted Project
lattner added a comment to D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower.

I don't think this is general enough requirement to add a specialized method for it. Did you consider adding a consumes_front/back overload that takes a lambda?

Mon, Jun 14, 5:14 PM · Restricted Project
leonardchan committed rG312011899ac3: [compiler-rt][hwasan] Add newline between record_addr lines on frame record… (authored by leonardchan).
[compiler-rt][hwasan] Add newline between record_addr lines on frame record…
Mon, Jun 14, 5:14 PM
leonardchan closed D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps.
Mon, Jun 14, 5:14 PM · Restricted Project
davidxl added inline comments to D18490: [PGO] Comment how function pointers for indirect calls are mapped to function names.
Mon, Jun 14, 5:10 PM · Restricted Project
lxfind retitled D104184: [Coroutine] Properly deal with byval and noalias parameters from [Coroutine] Put byval params' value into frame, instead of just pointer to [Coroutine] Properly deal with byval and noalias parameters.
Mon, Jun 14, 5:04 PM · Restricted Project
MaskRay added a comment to D104060: Machine IR Profile.

Good summary.

For instance, the important Kirichoff's circult law (aka spanning tree)
optimization is not implemented. (I added the optimization to clang
-fprofile-generate).

You probably meant -fprofile-instr-generate :)

Mon, Jun 14, 5:00 PM · Restricted Project
jacobhegna committed rG6c848c28c2f4: Remove redundant environment variable XLA_FLAGS. (authored by jacobhegna).
Remove redundant environment variable XLA_FLAGS.
Mon, Jun 14, 4:58 PM
jacobhegna closed D103972: Remove redundant environment variable XLA_FLAGS..
Mon, Jun 14, 4:58 PM · Restricted Project
lxfind added a comment to D104007: [BasicAA] Properly mark that coroutine suspension may modify parameters.

However latter optimization passes could very well optimize out that copy because the copy would appear to be useless without considering what coro_suspend does, which is why we are changing BasicAA to prevent such elimination.

If an argument is just a pointer without any argument attributes, BasicAA will assume coro_suspend frees the underlying allocations. Not because it has any particular knowledge of how coro_suspend works, but because that's the default assumption for any function call with unknown semantics.

BasicAA treats arguments marked byval differently because it understands the semantics of byval: it uses escape analysis to prove an arbitrary function call can't modify the contents.


I guess in some sense, it's possible to specify a world where coro_suspend frees byval allocations. But such a world doesn't really make sense. And we'd need to audit every pass that knows anything about byval semantics, so I really don't want to go down that path.

Mon, Jun 14, 4:55 PM · Restricted Project
aprantl committed rG035217ff515b: Allow signposts to take advantage of deferred string substitution (authored by aprantl).
Allow signposts to take advantage of deferred string substitution
Mon, Jun 14, 4:54 PM
ahatanak added a comment to D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions.

C++ non-virtual thunks and global initialization functions (_GLOBAL__sub_I_*) have only linkage names.

Mon, Jun 14, 4:53 PM · Restricted Project
efriedma added inline comments to D104184: [Coroutine] Properly deal with byval and noalias parameters.
Mon, Jun 14, 4:50 PM · Restricted Project
davidxl added a comment to D104060: Machine IR Profile.

Good summary.

Mon, Jun 14, 4:48 PM · Restricted Project
sugak added a comment to D104168: CMake: allow overriding CMAKE_CXX_VISIBILITY_PRESET.

friendly ping

Mon, Jun 14, 4:46 PM · Restricted Project
huihuiz committed rG1c096bf09ffd: [SVE][LSR] Teach LSR to enable simple scaled-index addressing mode generation… (authored by huihuiz).
[SVE][LSR] Teach LSR to enable simple scaled-index addressing mode generation…
Mon, Jun 14, 4:43 PM
huihuiz closed D103939: [SVE][LSR] Teach LSR to enable simple scaled-index addressing mode generation for SVE..
Mon, Jun 14, 4:42 PM · Restricted Project
lxfind updated the diff for D104184: [Coroutine] Properly deal with byval and noalias parameters.

only check byval attribute

Mon, Jun 14, 4:37 PM · Restricted Project
MaskRay added a comment to D104060: Machine IR Profile.

I have played with the patch.

Mon, Jun 14, 4:33 PM · Restricted Project
scott.linder added a comment to D98477: [ADT] Add IntrusiveVariant, VariantTraits, and new STLForwardCompat.

I did try to write an offsetof-based version using inheritance instead of the "common initial sequence" rule, but I am not sure how to do the necessary checks statically. The best I can see to do would be to have some dynamic ASSERTs to confirm that casting the alternative type to the base type does not change the underlying representation (i.e. if both pointers are cast to uintptr_t they are equal).

Mon, Jun 14, 4:29 PM · Restricted Project
holland11 updated the diff for D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

Made some changes suggested by Andrea.

Mon, Jun 14, 4:28 PM · Restricted Project
leonardchan updated the diff for D104248: [compiler-rt][hwasan] Refactor Thread::Init.
Mon, Jun 14, 4:27 PM · Restricted Project
scott.linder added a comment to D100672: [ADT] Add new type traits for type pack indexes.

@stella.stamenova do you still think you'd be able to test this before it lands, to see if the current version of the patch works on the MSVC build bots?

Mon, Jun 14, 4:26 PM · Restricted Project
scott.linder added a comment to D100670: [ADT] Add makeVisitor to STLExtras.h.

Ping

Mon, Jun 14, 4:25 PM · Restricted Project
rupprecht added a comment to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

Thanks! I'll wait for another CI notification to post before landing.

Mon, Jun 14, 4:13 PM · Restricted Project
rupprecht updated the diff for D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
  • Add requires for clang to avoid unknown gcc flag errors
Mon, Jun 14, 4:13 PM · Restricted Project
MaskRay added inline comments to D18490: [PGO] Comment how function pointers for indirect calls are mapped to function names.
Mon, Jun 14, 4:11 PM · Restricted Project
aprantl added a reverting change for rG03841edde7ee: Allow signposts to take advantage of deferred string substitution: rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution".
Mon, Jun 14, 4:09 PM
aprantl committed rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution" (authored by aprantl).
Revert "Allow signposts to take advantage of deferred string substitution"
Mon, Jun 14, 4:09 PM
aprantl added a reverting change for D103575: Allow signposts to take advantage of deferred string substitution: rG7a7c00761f62: Revert "Allow signposts to take advantage of deferred string substitution".
Mon, Jun 14, 4:09 PM · Restricted Project, Restricted Project
Herald added a project to D18490: [PGO] Comment how function pointers for indirect calls are mapped to function names: Restricted Project.

Is

Mon, Jun 14, 4:09 PM · Restricted Project
aeubanks added a comment to D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

maybe we should make a quick post on llvm-dev about this to see what other people think, since this will be very user-visible

Mon, Jun 14, 4:09 PM · Restricted Project
mehdi_amini abandoned D104259: Enable JIT tests on Windows.
Mon, Jun 14, 4:04 PM · Restricted Project
mehdi_amini added a comment to D104259: Enable JIT tests on Windows.

Still broken...

Mon, Jun 14, 4:04 PM · Restricted Project
zequanwu updated the summary of D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.
Mon, Jun 14, 4:00 PM · Restricted Project
lebedev.ri updated subscribers of D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline.

Adding Wei to help measure performance impact on our internal workloads. Also add Wenlei to help measure impact with FB's workloads.

Measured perf using FB internal workload w/ and w/o this pass, result is neutral.

Mon, Jun 14, 3:59 PM · Restricted Project, Restricted Project
zequanwu updated the diff for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

Add a test case.

Mon, Jun 14, 3:59 PM · Restricted Project
aartbik added inline comments to D104109: [mlir][linalg] Add support for scalar input operands..
Mon, Jun 14, 3:51 PM · Restricted Project
andreadb added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

I just spoke with Quentin, and we both agree with you. If it's alright with @foad, we'd like to push the current patch with the AMDGPU example (after I finish making the modifications Andrea suggested in his first comment). Afterwards, I will submit a bug report regarding the relevant flags not being transferred from pseudo -> real instructions. This will allow me to clean up the cnt detection logic and make it a lot more similar to the logic found in the si-insert-waitcnts pass (which will make the s_waitcnt modelling more accurate).

I'm surprised by this. I don't see anything in the tablegen files to say that DS instructions write to M0.

This is interesting. The MCInst for DS_READ_U8_gfx10 definitely has a Def for M0.

		Opcode Name= DS_READ_U8_gfx10
		SchedClassID=4
		Resource Mask=0x00000000000004, Reserved=0, #Units=1, cy=1
		Resource Mask=0x00000000000008, Reserved=0, #Units=1, cy=1
		Buffer Mask=0x00000000000004
		Buffer Mask=0x00000000000008
		 Used Units=0x0000000000000c
		Used Groups=0x00000000000000
		[Def]    OpIdx=0, Latency=20, WriteResourceID=0
		[Def][V] OpIdx=4, Latency=20, WriteResourceID=0
		[Use]    OpIdx=1, UseIndex=0
		[Use][V] OpIdx=4, UseIndex=3
		MaxLatency=20

The M0 def corresponds to [Def][V] OpIdx=4, Latency=20, WriteResourceID=0 where the [V] signifies that it's a 'variadic' operand (I'm not entirely sure what this means).

I can submit a separate bug report for this if you'd like. It's not really related to the CustomBehaviour class or the s_waitcnt instruction.

Mon, Jun 14, 3:49 PM · Restricted Project
efriedma added a comment to D97982: [MC] Introduce NeverAlign fragment type.

Which disables NeverAlign padding (0 bytes)

When do we actually do this computation? At first glance, MCAssembler::layoutSectionOnce never actually goes back to recompute the size of the NeverAlign padding.

So it's the case that layoutSectionOnce/layoutOnce actually recomputes the size of the NeverAlign padding indirectly:

Inside layoutSectionOnce, when it relaxes the fragment (relaxFragment), if the fragment is FT_Relaxable, it calls relaxInstruction, which in turn checks fragmentNeedsRelaxation for the passed fragment F, which then goes over F->getFixups, calling evaluateFixup, and so on through Layout.getSymbolOffset(Sym) and Layout.getFragmentOffset, inside the ensureValid check, calls layoutFragment, which then computes fragment size (computeFragmentSize):

Mon, Jun 14, 3:48 PM · Restricted Project
srj added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.

Debugging into this a little further, it's unclear to me how EVT::changeVectorElementType() can be expected to work reliably: it assumes that if EltVT.isSimple() == true, then MVT::changeVectorElementType(EltVT) will be legal, but this is clearly not the case, since there aren't equivalent widths of MVTs for all element types. (In this case, v6i32 -> v6i16 isn't possible since v6i16 doesn't exist).

Mon, Jun 14, 3:46 PM · Restricted Project
rsmith accepted D98068: Do not merge LocalInstantiationScope for template specialization.
Mon, Jun 14, 3:45 PM
lebedev.ri added a comment to D104156: [DAGCombine][X86][ARM] EXTRACT_SUBVECTOR(VECTOR_SHUFFLE(?,?,Mask)) -> VECTOR_SHUFFLE(EXTRACT_SUBVECTOR(?, ?), EXTRACT_SUBVECTOR(?, ?), Mask').

Many remaining cases are rotates, with the pattern like:

Combining: t0: ch = EntryToken
Optimized vector-legalized selection DAG: %bb.0 'splatvar_funnnel_v8i32:'
SelectionDAG has 26 nodes:
  t0: ch = EntryToken
  t2: v8i32,ch = CopyFromReg t0, Register:v8i32 %0
          t25: v2i64 = zero_extend_vector_inreg t45
        t26: v4i32 = bitcast t25
      t27: v8i32 = X86ISD::VSHL t2, t26
              t40: v4i32 = BUILD_VECTOR Constant:i32<32>, Constant:i32<32>, Constant:i32<32>, Constant:i32<32>
            t38: v4i32 = sub t40, t45
          t30: v2i64 = zero_extend_vector_inreg t38
        t31: v4i32 = bitcast t30
      t32: v8i32 = X86ISD::VSRL t2, t31
    t21: v8i32 = or t27, t32
  t10: ch,glue = CopyToReg t0, Register:v8i32 $ymm0, t21
        t4: v8i32,ch = CopyFromReg t0, Register:v8i32 %1
      t6: v8i32 = vector_shuffle<0,0,0,0,0,0,0,0> t4, undef:v8i32
    t43: v4i32 = extract_subvector t6, Constant:i64<0>
    t47: v4i32 = BUILD_VECTOR Constant:i32<31>, Constant:i32<31>, Constant:i32<31>, Constant:i32<31>
  t45: v4i32 = and t43, t47
  t11: ch = X86ISD::RET_FLAG t10, TargetConstant:i32<0>, Register:v8i32 $ymm0, t10:1

Let's suppose we start at t27: v8i32 = X86ISD::VSHL t2, t26, and demand the 0'th element of shift amount t26.
I think the problem is that t45 has another use - t38,
for another shift. Likewise, if we start from the other shift.
I'm not sure if this can be solved within the existing demandedelts infra?

Mon, Jun 14, 3:44 PM · Restricted Project
Amir updated the summary of D97982: [MC] Introduce NeverAlign fragment type.
Mon, Jun 14, 3:44 PM · Restricted Project
hanchung added inline comments to D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..
Mon, Jun 14, 3:43 PM · Restricted Project
AndreyChurbanov reopened D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type.
Mon, Jun 14, 3:35 PM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type.

Fixed backwards compatibility problem introduced by previous version of the patch.
That is restored the size of task dependence flag to 8 bits in clang, and instead changed the size of the flag in the library from 32 to 8 bits.
Fixed two tests so that they set all 8 bits of the flag.

Mon, Jun 14, 3:35 PM · Restricted Project, Restricted Project
Amir added a comment to D97982: [MC] Introduce NeverAlign fragment type.

Which disables NeverAlign padding (0 bytes)

When do we actually do this computation? At first glance, MCAssembler::layoutSectionOnce never actually goes back to recompute the size of the NeverAlign padding.

Mon, Jun 14, 3:34 PM · Restricted Project
mravishankar added reviewers for D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations.: ftynse, herhut, hanchung.
Mon, Jun 14, 3:31 PM · Restricted Project
mravishankar requested review of D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..
Mon, Jun 14, 3:30 PM · Restricted Project
stephan.yichao.zhao updated subscribers of D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Mon, Jun 14, 3:29 PM · Restricted Project
jeroen.dobbelaere added a comment to D69542: Full Restrict Support - single patch.
NOTE: the latest update missed two mandatory changes: - in clang/include/clang/Driver/Options.td : the DefaultFalse should become a DefaultTrue in order to enable the full restrict by default. - in clang/lib/Driver/ToolChains/Clang.cpp, '"-use-noalias-intrinsic-during-inlining=0"' must become '"-use-noalias-intrinsic-during-inlining=scopes"'
Mon, Jun 14, 3:25 PM · Restricted Project
jeroen.dobbelaere added a comment to D68523: [PATCH 27/27] [noalias] Clang: enable full restrict by default..
NOTE: the latest update missed two mandatory changes: - in clang/include/clang/Driver/Options.td : the DefaultFalse should become a DefaultTrue in order to enable the full restrict by default. - in clang/lib/Driver/ToolChains/Clang.cpp, '"-use-noalias-intrinsic-during-inlining=0"' must become '"-use-noalias-intrinsic-during-inlining=scopes"'
Mon, Jun 14, 3:24 PM
ccross updated the diff for D104137: Optimize lld::elf::ScriptLexer::getLineNumber by avoiding repeated work.

Reorder variable definitions to reduce line count

Mon, Jun 14, 3:22 PM · Restricted Project
ellis updated the diff for D104090: Add MIP tests to compiler-rt.

Disable macos test

Mon, Jun 14, 3:21 PM · Restricted Project
ellis updated the diff for D104088: Add clang frontend flags for MIP.

MIP does not support windows

Mon, Jun 14, 3:20 PM · Restricted Project, Restricted Project
JonChesterfield added a comment to D102229: [libomptarget][nfc] Add hook to easily disable building amdgcn bclib.

That is interesting. The cmake does require opt (and llvm-link), and the only reason it does not specify a dependency on those is I do not know how to spell that in cmake.

Mon, Jun 14, 3:17 PM · Restricted Project
mizvekov added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

When __block variables get moved to the heap, they're supposed to be moved if possible, not copied. It looks like PerformMoveOrCopyInitialization requires NRVO info to be passed in to ever do a move. Maybe it's being passed in wrong when building __block copy expressions in some situation.

Found the culprit, that functionality was implemented in checkEscapingByref, and it was a bit of a shocker that such a thing was just hiding in a function with such an unassuming name :)
Also surprising to find here another user of the two-step overload resolution, that also escaped our radar.
There is a C++ proposal (P2266) to replace that mechanism with something much simpler.

Mon, Jun 14, 3:17 PM · Restricted Project
ellis updated the diff for D104060: Machine IR Profile.

Fix build failures when using -DDBUILD_SHARED_LIBS=On. Thanks @MaskRay

Mon, Jun 14, 3:17 PM · Restricted Project
kparzysz committed rG0577f4b1789e: [Hexagon] Add HVX and control register names to Hexagon target (authored by kparzysz).
[Hexagon] Add HVX and control register names to Hexagon target
Mon, Jun 14, 3:15 PM
aeubanks added a comment to D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

there needs to be tests, and the description should probably state what's going on

Mon, Jun 14, 3:14 PM · Restricted Project
aeubanks added a reviewer for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments: dblaikie.
Mon, Jun 14, 3:13 PM · Restricted Project
ldionne added inline comments to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
Mon, Jun 14, 3:13 PM · Restricted Project
ldionne accepted D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

Thanks a lot! Indeed, we don't have access to FileCheck in the libc++ tests. I had once looked into doing that but I ran into issues and we didn't have a clear use case so I decided not to spend more time on it. Looks like this will do for the time being.

Mon, Jun 14, 3:12 PM · Restricted Project
jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

I also plan to add patches for:

  • fixing the handling of load/store instructions in various places where a single (for load) or double operands (for store) are assumed.
  • introduction of an intrinsic that combines the pointer provenance with the pointer value (Corresponding to the llvm.noalias.arg.guard in D68487)
Mon, Jun 14, 3:10 PM · Restricted Project
zequanwu requested review of D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.
Mon, Jun 14, 3:05 PM · Restricted Project
jeroen.dobbelaere updated the summary of D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.
Mon, Jun 14, 3:04 PM · Restricted Project
srj added a comment to D103881: [ValueTypes] Define MVTs for v6i32, v6f32, v7i32, v7f32.

I'll be adding more details and adding a repro case as soon as I have a small one; posting this now to see if anyone else has noticed a regression/injection.

Mon, Jun 14, 3:04 PM · Restricted Project
jankratochvil requested review of D104271: llvm-dwarfdump: Print warnings on invalid DWARF.
Mon, Jun 14, 3:03 PM · Restricted Project
jeroen.dobbelaere requested review of D104270: [ptr_provenance] Bitcode reader/writer support for the optional ptr_provenance operand of load/store instructions.
Mon, Jun 14, 3:03 PM · Restricted Project
ldionne requested changes to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Mon, Jun 14, 3:00 PM · Restricted Project
ldionne accepted D104228: [libc++] [test] Fix some GCC 11 errors/warnings in these tests. NFCI..

Good catch on the end.cpp rename - we were not running that test.

Mon, Jun 14, 2:59 PM · Restricted Project
jeroen.dobbelaere requested review of D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.
Mon, Jun 14, 2:55 PM · Restricted Project
nickdesaulniers added a comment to D103539: RISCV: adjust handling of relocation emission for RISCV.

With Diff 351900 of this patch applied, a RISCV build of the mainline Linux kernel with LLVM=1 LLVM_IAS=1 builds and boots. This patch resolves https://github.com/ClangBuiltLinux/linux/issues/1023 for me.

Mon, Jun 14, 2:54 PM · Restricted Project
jeroen.dobbelaere requested review of D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.
Mon, Jun 14, 2:53 PM · Restricted Project
mati865 accepted D104214: [llvm-dlltool] [test] Remove superfluous --coff-exports option to llvm-readobj. NFC..

LGTM

Mon, Jun 14, 2:53 PM · Restricted Project
hoy added reviewers for D104267: [CSSPGO] Fix an invalid hash table reference issue in the CS preinliner.: wenlei, wlei, wmi.
Mon, Jun 14, 2:52 PM · Restricted Project
mati865 accepted D104215: [llvm-dlltool] [test] Add a testcase for all machine option types. NFC..

LGTM

Mon, Jun 14, 2:52 PM · Restricted Project
hoy requested review of D104267: [CSSPGO] Fix an invalid hash table reference issue in the CS preinliner..
Mon, Jun 14, 2:51 PM · Restricted Project
lebedev.ri added a comment to D104156: [DAGCombine][X86][ARM] EXTRACT_SUBVECTOR(VECTOR_SHUFFLE(?,?,Mask)) -> VECTOR_SHUFFLE(EXTRACT_SUBVECTOR(?, ?), EXTRACT_SUBVECTOR(?, ?), Mask').

Many remaining cases are rotates, with the pattern like:

Combining: t0: ch = EntryToken
Optimized vector-legalized selection DAG: %bb.0 'splatvar_funnnel_v8i32:'
SelectionDAG has 26 nodes:
  t0: ch = EntryToken
  t2: v8i32,ch = CopyFromReg t0, Register:v8i32 %0
          t25: v2i64 = zero_extend_vector_inreg t45
        t26: v4i32 = bitcast t25
      t27: v8i32 = X86ISD::VSHL t2, t26
              t40: v4i32 = BUILD_VECTOR Constant:i32<32>, Constant:i32<32>, Constant:i32<32>, Constant:i32<32>
            t38: v4i32 = sub t40, t45
          t30: v2i64 = zero_extend_vector_inreg t38
        t31: v4i32 = bitcast t30
      t32: v8i32 = X86ISD::VSRL t2, t31
    t21: v8i32 = or t27, t32
  t10: ch,glue = CopyToReg t0, Register:v8i32 $ymm0, t21
        t4: v8i32,ch = CopyFromReg t0, Register:v8i32 %1
      t6: v8i32 = vector_shuffle<0,0,0,0,0,0,0,0> t4, undef:v8i32
    t43: v4i32 = extract_subvector t6, Constant:i64<0>
    t47: v4i32 = BUILD_VECTOR Constant:i32<31>, Constant:i32<31>, Constant:i32<31>, Constant:i32<31>
  t45: v4i32 = and t43, t47
  t11: ch = X86ISD::RET_FLAG t10, TargetConstant:i32<0>, Register:v8i32 $ymm0, t10:1
Mon, Jun 14, 2:45 PM · Restricted Project
nadiasvertex added a comment to D99836: [pstl] Implement OpenMP backend.

Resolved all review comments.

Mon, Jun 14, 2:45 PM · Restricted Project
mati865 accepted D104213: [llvm-dlltool] [test] Test both short and long forms of options. NFC..

LGTM

Mon, Jun 14, 2:45 PM · Restricted Project
nadiasvertex updated the diff for D99836: [pstl] Implement OpenMP backend.

This corrects all known problems in the parallel partial sort implementation. The parallel merge algorithm still needs implementing.

Mon, Jun 14, 2:44 PM · Restricted Project
mati865 accepted D104212: [llvm-dlltool] Imply the target arch from a tool triple prefix.

Feels a bit like approving myself (which is only partially true) but I don't see any issues with the patch itself.

Mon, Jun 14, 2:43 PM · Restricted Project
mehdi_amini accepted D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..
Mon, Jun 14, 2:42 PM · Restricted Project
Herald added a reviewer for D70621: Add __default_init_tag to basic_string constructors: Restricted Project.

This change introduced an MSAN error https://bugs.llvm.org/show_bug.cgi?id=50112

Mon, Jun 14, 2:42 PM · Restricted Project
Carrot added a comment to D101970: [X86FixupLEAs] Transform the sequence LEA/SUB to SUB/SUB.

Thanks for the test case!
The problem is:

Mon, Jun 14, 2:40 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 14, 2:39 PM · Restricted Project