Address Craig's comments.
Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 12 2023
Aug 12 2023
LuoYuanke added inline comments to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles.
Herald added projects to D48154: [VirtRegRewriter] Avoid clobbering registers when expanding copy bundles: Restricted Project, Restricted Project.
Jul 31 2023
Jul 31 2023
LuoYuanke added a reviewer for D156610: [WIP][LSR] Transform div instruction to add in loop: craig.topper.
Jul 30 2023
Jul 30 2023
Check if div is legal for target. If it is legal, drop the transform.
Add nsw and nuw flags for add instruction.
Jun 19 2023
Jun 19 2023
LuoYuanke accepted D153002: [X86][AMX] set Stride to Tile's Col when doing combine amxcast and store into tilestore.
LGTM.
LuoYuanke added inline comments to D153002: [X86][AMX] set Stride to Tile's Col when doing combine amxcast and store into tilestore.
LGTM.
Jun 15 2023
Jun 15 2023
LuoYuanke added inline comments to D124378: [X86][AMX] combine tile cast and load/store instruction..
LuoYuanke added inline comments to D124378: [X86][AMX] combine tile cast and load/store instruction..
Jun 13 2023
Jun 13 2023
LuoYuanke added a comment to D152819: [X86][AMX] Let Store not be removed if combineCastStore failed.
Is there any test case for the patch?
Jun 8 2023
Jun 8 2023
LGTM
LuoYuanke committed rGb0bea80ab479: [X86] Prefer vmovmsk instead of vtest for alderlake. (authored by LuoYuanke).
[X86] Prefer vmovmsk instead of vtest for alderlake.
Jun 7 2023
Jun 7 2023
Hi,
Is there anything else that I need to update?
LGTM.
Jun 6 2023
Jun 6 2023
Address Simon's comments.
Address Phoebe's comments.
LuoYuanke added reviewers for D152227: [X86] Prefer vmovmsk instead of vtest for alderlake.: RKSimon, pengfei, goldstein.w.n.
Rebase and update test cases.
Jun 5 2023
Jun 5 2023
LuoYuanke committed rG787f3008be68: [X86] Pre-commit test case for D152227. (authored by LuoYuanke).
[X86] Pre-commit test case for D152227.
Rebase and update test case.
[X86] Add test cases for D152227.
LuoYuanke retitled D152227: [X86] Prefer vmovmsk instead of vtest for alderlake. from [X86] Prefer vtest to vmovmsk for alderlake. to [X86] Prefer vmovmsk instead of vtest for alderlake..
Jun 2 2023
Jun 2 2023
LGTM for AMXINT8 change. Thanks, @MatzeB.
Jun 2 2023, 5:28 PM · Restricted Project
May 31 2023
May 31 2023
May 31 2023, 3:57 PM · Restricted Project
May 30 2023
May 30 2023
LGMT. I think it's a good start to have SPR schdule model in LLVM.
In D151537#4380763, @erichkeane wrote:I don't really see the justification here? Why do this change? If the intent is to just test a newer architecture, we can add tests for that, not change existing ones.
May 29 2023
May 29 2023
[NFC][TableGen] Remove dead code.
LGTM
May 28 2023
May 28 2023
LuoYuanke added reviewers for D151635: [NFC][TableGen] Remove dead code.: dsanders, volkan, pengfei.
[NFC][DAGISel] Remove dead code.
May 26 2023
May 26 2023
LuoYuanke committed rG969c686e5450: [X86] fold select to mask instructions. (authored by LuoYuanke).
[X86] fold select to mask instructions.
Rebase and add code comments.
[NFC] refactor code
NFC. Address Simon's comments.
May 25 2023
May 25 2023
LuoYuanke added reviewers for D151535: [X86] fold select to mask instructions.: pengfei, RKSimon, craig.topper.
[X86] Add test for select folding.
May 23 2023
May 23 2023
LuoYuanke committed rG09011c4eb82d: [Coverity] Constant variable guards dead code. (authored by LuoYuanke).
[Coverity] Constant variable guards dead code.
May 19 2023
May 19 2023
LuoYuanke added a comment to D150526: [X86] Add X86FixupVectorConstantsPass to re-fold AVX512 vector load folds as broadcast folds.
In D150526#4356290, @RKSimon wrote:Thanks @LuoYuanke - any more comments?
LuoYuanke added a comment to D150526: [X86] Add X86FixupVectorConstantsPass to re-fold AVX512 vector load folds as broadcast folds.
LGTM.
May 18 2023
May 18 2023
May 14 2023
May 14 2023
[X86] Fix the bug of pr62625
Address Phoebe and Simon's comments.
May 12 2023
May 12 2023
It looks to me that initializing variable is a good practice to avoid security issue. If it doesn’t cause performance degradation, it should be better than uninitialized variable which may cause UB.
I once encountered issue that compiler behavior is not consistent when compiling several times, not sure it is related with uninitialized variable.
May 10 2023
May 10 2023
LuoYuanke updated subscribers of D143285: X86: completely refactor `X86FrameLowering::emitPrologue`.
LuoYuanke added inline comments to D150175: [X86] Fix instruction's ports info which is ported from SKL in AlderlakeP model.
May 8 2023
May 8 2023
In D141485#4326543, @HaohaiWen wrote:@LuoYuanke , could you please help to verify avxvnni-combine.ll?
May 4 2023
May 4 2023
LuoYuanke committed rGae1ca47bb445: [Coverity] Big parameter passed by value. (authored by LuoYuanke).
[Coverity] Big parameter passed by value.
LuoYuanke committed rGb0fb98227c90: [Coverity] Big parameter passed by value. (authored by LuoYuanke).
[Coverity] Big parameter passed by value.
LuoYuanke committed rGd9b92c4d5597: [Coverity] Improper use of negtive value. (authored by LuoYuanke).
[Coverity] Improper use of negtive value.
Apr 28 2023
Apr 28 2023
There is conflict when I try to revert the patch. I fixed the issue with rG40222ddcf8f5.
LuoYuanke committed rG40222ddcf8f5: [X86] Fix the vnni machine combine issue. (authored by LuoYuanke).
[X86] Fix the vnni machine combine issue.
In D148980#4305430, @RKSimon wrote:@LuoYuanke I'm seeing tests failures on my local machine with expensive checks enabled - one buildbot is reporting something similar: https://lab.llvm.org/buildbot/#/builders/16/builds/47297
LGTM.
Apr 27 2023
Apr 27 2023
The summary may need to describe the purpose or functionality for this patch.
In D149071#4303198, @RKSimon wrote:LGTM
@pengfei @LuoYuanke Are you happy with the performance vs code size trade off?
LuoYuanke committed rG8f7f9d86a755: [X86] Machine combine vnni instruction. (authored by LuoYuanke).
[X86] Machine combine vnni instruction.
Address Phoebe's comments.
Apr 26 2023
Apr 26 2023
ping
Apr 24 2023
Apr 24 2023
Rebase
Update description
Address Craig's comments.
Apr 23 2023
Apr 23 2023
Fix an opcode bug.
Update test case.
Add (avx512, 128, 256, 512) support.
[X86] Precommit test case for D148980.
Apr 22 2023
Apr 22 2023
Add test case that there isn't the cross-loop dependency.
[X86] Precommit test case for D148980.
Rebase
[X86] Precommit test case for D148980.