Page MenuHomePhabricator
Feed Advanced Search

Sat, Feb 27

LuoYuanke added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Sat, Feb 27, 5:40 AM · Restricted Project, Restricted Project
LuoYuanke added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Sat, Feb 27, 4:49 AM · Restricted Project, Restricted Project
LuoYuanke added inline comments to D97453: [X86] Allow PTILEZEROV and PTILELOADDV to be rematerializable.
Sat, Feb 27, 4:29 AM · Restricted Project
LuoYuanke added inline comments to D97453: [X86] Allow PTILEZEROV and PTILELOADDV to be rematerializable.
Sat, Feb 27, 3:04 AM · Restricted Project
LuoYuanke added inline comments to D97453: [X86] Allow PTILEZEROV and PTILELOADDV to be rematerializable.
Sat, Feb 27, 12:21 AM · Restricted Project

Fri, Feb 26

LuoYuanke accepted D97453: [X86] Allow PTILEZEROV and PTILELOADDV to be rematerializable.

LGTM. Thanks.

Fri, Feb 26, 4:57 AM · Restricted Project

Tue, Feb 23

LuoYuanke added inline comments to D97358: [X86] Support amx-bf16 intrinsic..
Tue, Feb 23, 11:32 PM · Restricted Project, Restricted Project

Mon, Feb 22

LuoYuanke committed rG8f48ddd19358: [X86][AMX] Lower tile copy instruction. (authored by LuoYuanke).
[X86][AMX] Lower tile copy instruction.
Mon, Feb 22, 3:50 PM
LuoYuanke closed D97112: [X86][AMX] Lower tile copy instruction..
Mon, Feb 22, 3:50 PM · Restricted Project

Sat, Feb 20

LuoYuanke added reviewers for D97112: [X86][AMX] Lower tile copy instruction.: craig.topper, LiuChen3.
Sat, Feb 20, 4:20 AM · Restricted Project
LuoYuanke added inline comments to D97112: [X86][AMX] Lower tile copy instruction..
Sat, Feb 20, 2:16 AM · Restricted Project
LuoYuanke updated the diff for D97112: [X86][AMX] Lower tile copy instruction..

Address Pengfei's comments.

Sat, Feb 20, 2:15 AM · Restricted Project
LuoYuanke added inline comments to D97112: [X86][AMX] Lower tile copy instruction..
Sat, Feb 20, 2:11 AM · Restricted Project
LuoYuanke added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Sat, Feb 20, 12:57 AM · Restricted Project, Restricted Project

Fri, Feb 19

LuoYuanke updated the diff for D97112: [X86][AMX] Lower tile copy instruction..

Remove useless code.

Fri, Feb 19, 11:12 PM · Restricted Project
LuoYuanke added reviewers for D97112: [X86][AMX] Lower tile copy instruction.: pengfei, xiangzhangllvm, yubing.
Fri, Feb 19, 11:07 PM · Restricted Project
LuoYuanke requested review of D97112: [X86][AMX] Lower tile copy instruction..
Fri, Feb 19, 11:05 PM · Restricted Project

Wed, Feb 17

LuoYuanke accepted D96927: [X86] Zero AMX config buffer for non AVX512 cases..

LGTM. Thanks.

Wed, Feb 17, 9:24 PM · Restricted Project
LuoYuanke added inline comments to D96927: [X86] Zero AMX config buffer for non AVX512 cases..
Wed, Feb 17, 7:53 PM · Restricted Project
LuoYuanke added inline comments to D96927: [X86] Zero AMX config buffer for non AVX512 cases..
Wed, Feb 17, 7:53 PM · Restricted Project

Tue, Feb 9

LuoYuanke added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Tue, Feb 9, 4:24 AM · Restricted Project, Restricted Project

Mon, Feb 8

LuoYuanke added inline comments to D96315: [X86][AMX] Assemble new AMX interface to an experiment header file..
Mon, Feb 8, 10:19 PM · Restricted Project
LuoYuanke updated the diff for D96315: [X86][AMX] Assemble new AMX interface to an experiment header file..

Address Pengfei's comments.

Mon, Feb 8, 10:18 PM · Restricted Project
LuoYuanke added reviewers for D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.: craig.topper, pengfei, xiangzhangllvm, annita.zhang.
Mon, Feb 8, 9:37 PM · Restricted Project
LuoYuanke requested review of D96315: [X86][AMX] Assemble new AMX interface to an experiment header file..
Mon, Feb 8, 9:36 PM · Restricted Project

Fri, Feb 5

LuoYuanke added a comment to D93594: [X86] Pass to transform amx intrinsics to scalar operation..

Would you rebase to see if the lit test failure is related to this patch?

Fri, Feb 5, 12:58 AM · Restricted Project, Restricted Project
LuoYuanke added a reviewer for D93594: [X86] Pass to transform amx intrinsics to scalar operation.: craig.topper.
Fri, Feb 5, 12:02 AM · Restricted Project, Restricted Project
LuoYuanke added a reviewer for D93594: [X86] Pass to transform amx intrinsics to scalar operation.: xiangzhangllvm.
Fri, Feb 5, 12:00 AM · Restricted Project, Restricted Project

Jan 29 2021

LuoYuanke accepted D95136: [X86] Fix tile config register spill issue..

LGTM. Thank you!

Jan 29 2021, 4:42 PM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 29 2021, 3:50 AM · Restricted Project

Jan 28 2021

LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 28 2021, 5:42 AM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 28 2021, 5:03 AM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 28 2021, 5:00 AM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 28 2021, 4:56 AM · Restricted Project
LuoYuanke committed rGbf649181504f: [X86][AMX] Prevent shape def being scheduled across ldtilecfg. (authored by LuoYuanke).
[X86][AMX] Prevent shape def being scheduled across ldtilecfg.
Jan 28 2021, 12:21 AM
LuoYuanke closed D95582: [X86][AMX] Prevent shape def being scheduled across ldtilecfg..
Jan 28 2021, 12:20 AM · Restricted Project

Jan 27 2021

LuoYuanke updated the diff for D95582: [X86][AMX] Prevent shape def being scheduled across ldtilecfg..

Address Pengfei's comments.

Jan 27 2021, 8:58 PM · Restricted Project
LuoYuanke added inline comments to D95582: [X86][AMX] Prevent shape def being scheduled across ldtilecfg..
Jan 27 2021, 8:56 PM · Restricted Project
LuoYuanke added reviewers for D95582: [X86][AMX] Prevent shape def being scheduled across ldtilecfg.: craig.topper, pengfei, xiangzhangllvm.
Jan 27 2021, 6:50 PM · Restricted Project
LuoYuanke requested review of D95582: [X86][AMX] Prevent shape def being scheduled across ldtilecfg..
Jan 27 2021, 6:48 PM · Restricted Project
LuoYuanke added inline comments to D91927: [X86] Add x86_amx type for intel AMX..
Jan 27 2021, 5:20 PM · Restricted Project, Restricted Project

Jan 24 2021

LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 24 2021, 8:21 PM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 24 2021, 4:02 AM · Restricted Project

Jan 23 2021

LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 23 2021, 8:55 PM · Restricted Project
LuoYuanke added reviewers for D95136: [X86] Fix tile config register spill issue.: craig.topper, qcolombet.
Jan 23 2021, 4:56 PM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 23 2021, 4:10 PM · Restricted Project

Jan 22 2021

LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 22 2021, 5:01 PM · Restricted Project
LuoYuanke added inline comments to D95136: [X86] Fix tile config register spill issue..
Jan 22 2021, 12:42 AM · Restricted Project

Jan 21 2021

LuoYuanke added reviewers for D95136: [X86] Fix tile config register spill issue.: wxiao3, xiangzhangllvm.
Jan 21 2021, 4:27 PM · Restricted Project
LuoYuanke added a reverting change for rG20013d02f335: [X86][AMX] Fix tile config register spill issue.: rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue.".
Jan 21 2021, 2:12 AM
LuoYuanke committed rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue." (authored by LuoYuanke).
Revert "[X86][AMX] Fix tile config register spill issue."
Jan 21 2021, 2:12 AM
LuoYuanke added a reverting change for D94155: [X86] Fix tile config register spill issue.: rG64132f541edd: Revert "[X86][AMX] Fix tile config register spill issue.".
Jan 21 2021, 2:12 AM · Restricted Project
LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..
Jan 21 2021, 2:11 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Jan 21 2021, 12:58 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Jan 21 2021, 12:38 AM · Restricted Project
LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..
Jan 21 2021, 12:26 AM · Restricted Project
LuoYuanke committed rG20013d02f335: [X86][AMX] Fix tile config register spill issue. (authored by LuoYuanke).
[X86][AMX] Fix tile config register spill issue.
Jan 21 2021, 12:02 AM
LuoYuanke closed D94155: [X86] Fix tile config register spill issue..
Jan 21 2021, 12:02 AM · Restricted Project

Jan 19 2021

LuoYuanke added a comment to D94155: [X86] Fix tile config register spill issue..

LGTM, but let's wait for one day or two to see others' opinions.

Jan 19 2021, 7:25 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Rebase.

Jan 19 2021, 5:01 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Pengfei's comments.

Jan 19 2021, 3:45 AM · Restricted Project
LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Jan 19 2021, 3:45 AM · Restricted Project
LuoYuanke committed rG7e1d2224b42b: [X86][AMX] Fix the typo. (authored by LuoYuanke).
[X86][AMX] Fix the typo.
Jan 19 2021, 12:58 AM
LuoYuanke closed D94943: [X86][AMX] Fix the typo..
Jan 19 2021, 12:58 AM · Restricted Project

Jan 18 2021

LuoYuanke added reviewers for D94943: [X86][AMX] Fix the typo.: pengfei, yubing, craig.topper.
Jan 18 2021, 9:07 PM · Restricted Project
LuoYuanke requested review of D94943: [X86][AMX] Fix the typo..
Jan 18 2021, 9:05 PM · Restricted Project
LuoYuanke committed rGe147eccafa15: [X86][AMX] Clear AMX lit test case. (authored by LuoYuanke).
[X86][AMX] Clear AMX lit test case.
Jan 18 2021, 7:26 PM
LuoYuanke closed D94910: [X86][AMX] Clear AMX lit test case..
Jan 18 2021, 7:26 PM · Restricted Project
LuoYuanke updated the diff for D94910: [X86][AMX] Clear AMX lit test case..

Address Pengfei's comments.

Jan 18 2021, 6:59 PM · Restricted Project
LuoYuanke committed rGc535a7fdadb4: [X86] Fix tile spill merge issue. (authored by LuoYuanke).
[X86] Fix tile spill merge issue.
Jan 18 2021, 6:52 PM
LuoYuanke closed D94772: [X86] Fix tile spill merge issue..
Jan 18 2021, 6:52 PM · Restricted Project
LuoYuanke added reviewers for D94910: [X86][AMX] Clear AMX lit test case.: pengfei, craig.topper.
Jan 18 2021, 5:27 AM · Restricted Project
LuoYuanke requested review of D94910: [X86][AMX] Clear AMX lit test case..
Jan 18 2021, 5:26 AM · Restricted Project
LuoYuanke updated the diff for D94772: [X86] Fix tile spill merge issue..

Address Pengfei's comments.

Jan 18 2021, 12:53 AM · Restricted Project
LuoYuanke added inline comments to D94772: [X86] Fix tile spill merge issue..
Jan 18 2021, 12:40 AM · Restricted Project

Jan 16 2021

LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Jan 16 2021, 6:05 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Xiang's comments.

Jan 16 2021, 6:02 PM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Make the logic more clean.

Jan 16 2021, 1:41 AM · Restricted Project

Jan 15 2021

LuoYuanke updated subscribers of D94772: [X86] Fix tile spill merge issue..
Jan 15 2021, 6:02 AM · Restricted Project
LuoYuanke added reviewers for D94772: [X86] Fix tile spill merge issue.: wxiao3, pengfei, qcolombet, craig.topper.
Jan 15 2021, 6:02 AM · Restricted Project
LuoYuanke requested review of D94772: [X86] Fix tile spill merge issue..
Jan 15 2021, 6:00 AM · Restricted Project

Jan 14 2021

LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Get tile register number from backend.

Jan 14 2021, 5:42 AM · Restricted Project
LuoYuanke updated the summary of D94155: [X86] Fix tile config register spill issue..
Jan 14 2021, 5:31 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

We also need check tile config register interference. Since we
don't model the config register we should check interference from the
ldtilecfg to each tile data register def.

      ldtilecfg
      /       \
    BB1      BB2
     /         \
    call       BB3
    /           \
%1=tileload   %2=tilezero

We can start from the instruction of each tile def, and backward to
ldtilecfg. If there is any call instruction, and tile data register is
not preserved, we should insert ldtilecfg after the call instruction.

Jan 14 2021, 5:30 AM · Restricted Project

Jan 13 2021

LuoYuanke added a reviewer for D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM: craig.topper.
Jan 13 2021, 5:02 AM · Restricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Address Pengfei's comments.

Jan 13 2021, 4:16 AM · Restricted Project

Jan 12 2021

LuoYuanke added inline comments to D94155: [X86] Fix tile config register spill issue..
Jan 12 2021, 11:40 PM · Restricted Project
LuoYuanke updated subscribers of D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Jan 12 2021, 10:01 PM · Restricted Project, Restricted Project
LuoYuanke updated the diff for D93594: [X86] Pass to transform amx intrinsics to scalar operation..

Support tile_zero and fix bugs for tile_load and tile_store.

Jan 12 2021, 9:44 PM · Restricted Project, Restricted Project
LuoYuanke committed rG055644cc459e: [X86][AMX] Prohibit pointer cast on load. (authored by LuoYuanke).
[X86][AMX] Prohibit pointer cast on load.
Jan 12 2021, 5:40 PM
LuoYuanke closed D94372: [X86][AMX] Prohibit pointer cast on load..
Jan 12 2021, 5:39 PM · Restricted Project
LuoYuanke added a comment to D94372: [X86][AMX] Prohibit pointer cast on load..

LGTM, but I'd like to see if @lebedev.ri has any objections.

Jan 12 2021, 12:30 AM · Restricted Project

Jan 11 2021

LuoYuanke updated the diff for D94372: [X86][AMX] Prohibit pointer cast on load..

Address Pengfei's comments.

Jan 11 2021, 7:43 PM · Restricted Project
LuoYuanke added a comment to D94415: Fix minor build issue (NFC).

Thank David!

Jan 11 2021, 3:56 PM · Restricted Project
LuoYuanke committed rGc5be0e0cc0e2: [X86] Fix tile register spill issue. (authored by LuoYuanke).
[X86] Fix tile register spill issue.
Jan 11 2021, 2:36 AM
LuoYuanke closed D93898: [X86] Fix tile register spill issue..
Jan 11 2021, 2:35 AM · Restricted Project

Jan 10 2021

LuoYuanke added inline comments to D94372: [X86][AMX] Prohibit pointer cast on load..
Jan 10 2021, 5:43 AM · Restricted Project
LuoYuanke added a comment to D94372: [X86][AMX] Prohibit pointer cast on load..

What specifically is having problems after that transformation?

Jan 10 2021, 5:09 AM · Restricted Project
LuoYuanke updated the diff for D94372: [X86][AMX] Prohibit pointer cast on load..

Address Pengfei's comments.

Jan 10 2021, 3:59 AM · Restricted Project
LuoYuanke added inline comments to D94372: [X86][AMX] Prohibit pointer cast on load..
Jan 10 2021, 3:51 AM · Restricted Project