Page MenuHomePhabricator
Feed Advanced Search

Apr 30 2020

DiggerLin committed rGa2c8cd18128d: [AIX] emit .extern and .weak directive linkage (authored by DiggerLin).
[AIX] emit .extern and .weak directive linkage
Apr 30 2020, 7:22 AM
DiggerLin closed D76932: [AIX] emit .extern and .weak directive linkage.
Apr 30 2020, 7:21 AM · Restricted Project, Restricted Project

Apr 29 2020

DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 29 2020, 1:27 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

take out the functionality of "remove -u from clang"

Apr 29 2020, 1:27 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

upload wrong diff . discard previous diff

Apr 29 2020, 9:06 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
Apr 29 2020, 8:33 AM · Restricted Project
DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment

Apr 29 2020, 8:33 AM · Restricted Project
Herald added a project to D76932: [AIX] emit .extern and .weak directive linkage: Restricted Project.
Apr 29 2020, 8:33 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 29 2020, 8:33 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 29 2020, 8:33 AM · Restricted Project
Herald added a reviewer for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description: MaskRay.

This behaviour seems significantly under-tested. Just looking at the new operator, there are three different comparisons, so I'd expect to see at least 4 test cases for that alone (one for each side of the branch point). Furthermore, there's a big new switch in the same file that isn't exercised in any depth.

Apr 29 2020, 8:00 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

using SmallPtrSet as comment

Apr 29 2020, 7:28 AM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 29 2020, 6:24 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

Apr 29 2020, 6:24 AM · Restricted Project

Apr 28 2020

DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

Apr 28 2020, 1:28 PM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 28 2020, 1:28 PM · Restricted Project

Apr 27 2020

DiggerLin updated the summary of D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 27 2020, 8:01 AM · Restricted Project
DiggerLin updated the summary of D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 27 2020, 8:01 AM · Restricted Project
DiggerLin created D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Apr 27 2020, 8:01 AM · Restricted Project

Apr 22 2020

DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
Apr 22 2020, 9:12 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
Apr 22 2020, 5:55 AM · Restricted Project

Apr 21 2020

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment

Apr 21 2020, 11:20 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 21 2020, 11:20 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment

Apr 21 2020, 9:41 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
Apr 21 2020, 9:41 AM · Restricted Project

Apr 20 2020

DiggerLin added inline comments to D78499: [llvm-objdump][XCOFF] Print more symbol info in relocation.
Apr 20 2020, 1:33 PM · Restricted Project
DiggerLin added inline comments to D78499: [llvm-objdump][XCOFF] Print more symbol info in relocation.
Apr 20 2020, 11:53 AM · Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.
Apr 20 2020, 7:31 AM · Restricted Project, Restricted Project

Apr 17 2020

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

I think I address all the comments. thanks hubert.

Apr 17 2020, 3:51 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

handle getSymbol returning a function descriptor symbol after rebase on the D78045

Apr 17 2020, 3:10 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

rebase the patch on the D78045 and address comment.

Apr 17 2020, 1:32 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 17 2020, 1:32 PM · Restricted Project, Restricted Project
DiggerLin created D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
Apr 17 2020, 10:47 AM · Restricted Project

Apr 16 2020

DiggerLin accepted D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.

LGTM

Apr 16 2020, 12:50 PM · Restricted Project
DiggerLin added inline comments to D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.
Apr 16 2020, 10:35 AM · Restricted Project
DiggerLin added inline comments to D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.
Apr 16 2020, 8:21 AM · Restricted Project
DiggerLin added inline comments to D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.
Apr 16 2020, 8:21 AM · Restricted Project
DiggerLin added inline comments to D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.
Apr 16 2020, 8:21 AM · Restricted Project

Apr 15 2020

DiggerLin updated the summary of D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Apr 15 2020, 1:46 PM · Restricted Project
DiggerLin updated the summary of D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Apr 15 2020, 1:46 PM · Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment

Apr 15 2020, 1:46 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 15 2020, 1:46 PM · Restricted Project, Restricted Project

Apr 14 2020

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment

Apr 14 2020, 1:31 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 14 2020, 1:30 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary.
Apr 14 2020, 10:13 AM · Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment and add a new test case

Apr 14 2020, 7:27 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 14 2020, 7:27 AM · Restricted Project, Restricted Project

Apr 9 2020

DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 9 2020, 7:01 AM · Restricted Project, Restricted Project

Apr 8 2020

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment and rebased the patch on D77080 [NFC][XCOFF][AIX] Refactor get/setContainingCsect

Apr 8 2020, 10:51 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 8 2020, 10:51 AM · Restricted Project, Restricted Project
DiggerLin added inline comments to D77424: [XCOFF][AIX] Relocation support for SymB.
Apr 8 2020, 5:55 AM · Restricted Project

Apr 7 2020

DiggerLin added inline comments to D77424: [XCOFF][AIX] Relocation support for SymB.
Apr 7 2020, 2:43 PM · Restricted Project
DiggerLin added inline comments to D77424: [XCOFF][AIX] Relocation support for SymB.
Apr 7 2020, 10:50 AM · Restricted Project
DiggerLin committed rG3aa084947e5f: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp (authored by DiggerLin).
[NFC][XCOFF] refactor readobj/XCOFFDumper.cpp
Apr 7 2020, 8:40 AM
DiggerLin closed D77562: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp .
Apr 7 2020, 8:40 AM · Restricted Project

Apr 6 2020

DiggerLin updated the diff for D77562: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp .

address comment

Apr 6 2020, 12:30 PM · Restricted Project
DiggerLin created D77562: [NFC][XCOFF] refactor readobj/XCOFFDumper.cpp .
Apr 6 2020, 9:11 AM · Restricted Project
DiggerLin committed rGa26a441b99ff: [llvm-objdump][XCOFF] Use symbol index+symbol name + storage mapping class as… (authored by DiggerLin).
[llvm-objdump][XCOFF] Use symbol index+symbol name + storage mapping class as…
Apr 6 2020, 7:34 AM
DiggerLin closed D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 6 2020, 7:33 AM · Restricted Project

Apr 3 2020

DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 3 2020, 1:03 PM · Restricted Project, Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Apr 3 2020, 10:47 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.
  1. address comment
  2. add two new test cases.
  3. split a bit test case into three small test case.
Apr 3 2020, 10:14 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 3 2020, 8:35 AM · Restricted Project, Restricted Project

Apr 2 2020

DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 2 2020, 1:00 PM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Apr 2 2020, 1:00 PM · Restricted Project, Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Apr 2 2020, 9:44 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 2 2020, 7:01 AM · Restricted Project

Apr 1 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 1 2020, 6:32 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 1 2020, 6:32 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 1 2020, 6:32 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

modified the test case based on the latest llvm code.

Apr 1 2020, 3:12 PM · Restricted Project
DiggerLin accepted D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.

LGTM

Apr 1 2020, 1:41 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 1 2020, 12:04 PM · Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

address comment

Apr 1 2020, 10:58 AM · Restricted Project, Restricted Project
DiggerLin committed rG65e0079f21ae: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h (authored by DiggerLin).
[NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h
Apr 1 2020, 6:35 AM
DiggerLin closed D77170: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h.
Apr 1 2020, 6:35 AM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Apr 1 2020, 6:35 AM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Apr 1 2020, 6:35 AM · Restricted Project

Mar 31 2020

DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

simplify some code.

Mar 31 2020, 4:33 PM · Restricted Project
DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mar 31 2020, 3:27 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mar 31 2020, 3:27 PM · Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Mar 31 2020, 2:52 PM · Restricted Project, Restricted Project
DiggerLin added reviewers for D77170: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h: jasonliu, hubert.reinterpretcast.
Mar 31 2020, 2:17 PM · Restricted Project
DiggerLin created D77170: [NFC] run clang format on the file llvm/include/llvm/MC/MCDirectives.h.
Mar 31 2020, 2:17 PM · Restricted Project
DiggerLin added inline comments to D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.
Mar 31 2020, 10:01 AM · Restricted Project
DiggerLin added inline comments to D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect.
Mar 31 2020, 10:00 AM · Restricted Project

Mar 30 2020

DiggerLin added inline comments to D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.
Mar 30 2020, 1:04 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mar 30 2020, 1:04 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment and rebased the code based on https://reviews.llvm.org/D75131 [llvm-objdump][XCOFF][AIX] Implement -r option

Mar 30 2020, 8:37 AM · Restricted Project
DiggerLin added inline comments to D76932: [AIX] emit .extern and .weak directive linkage.
Mar 30 2020, 7:00 AM · Restricted Project, Restricted Project
DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

delete -u from clang test case aix-as.c

Mar 30 2020, 6:28 AM · Restricted Project, Restricted Project

Mar 27 2020

DiggerLin updated the diff for D76932: [AIX] emit .extern and .weak directive linkage.

clang reformat

Mar 27 2020, 7:51 PM · Restricted Project, Restricted Project
DiggerLin committed rG9c20f09985db: [AIX] Address comment https://reviews.llvm.org/D76162#inline-701237 (authored by DiggerLin).
[AIX] Address comment https://reviews.llvm.org/D76162#inline-701237
Mar 27 2020, 1:43 PM
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Mar 27 2020, 9:05 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Mar 27 2020, 9:05 AM · Restricted Project, Restricted Project
DiggerLin updated the summary of D76932: [AIX] emit .extern and .weak directive linkage.
Mar 27 2020, 9:05 AM · Restricted Project, Restricted Project
DiggerLin created D76932: [AIX] emit .extern and .weak directive linkage.
Mar 27 2020, 9:05 AM · Restricted Project, Restricted Project

Mar 26 2020

DiggerLin committed rGfdfe411e7c9a: [AIX] discard the label in the csect of function description and use qualname… (authored by DiggerLin).
[AIX] discard the label in the csect of function description and use qualname…
Mar 26 2020, 1:03 PM
DiggerLin closed D76162: [AIX] discard the label in the csect of function description and use qualname for linkage .
Mar 26 2020, 1:03 PM · Restricted Project
DiggerLin updated the diff for D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D.

address comment

Mar 26 2020, 8:06 AM · Restricted Project