LGTM, please wait for 24 hours before commit . maybe other reviewer still have some comment.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
Sun, Apr 11
Wed, Mar 24
Tue, Mar 23
Mon, Mar 22
LGTM
and I am prefer to combine the two test files into one. because the only different is data-section is on or off. we can use different --check-prefix for them
I think we also need to use llvm-objdump to test the content of .tdata ?
we maybe also need to use llvm-objdump to test the data content of .tdata
Fri, Mar 19
Thu, Mar 18
Mar 15 2021
Mar 11 2021
address comment.
Mar 9 2021
address comment
slight change , move to
Mar 8 2021
Gentle ping . @jansvoboda11 . Do you have any comment on it the last update on "added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" ?
added extra comment back.
Mar 6 2021
added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility"
Mar 5 2021
- in your summary , it looks clang will emit "-fvisibility default" to cc1 even if there is no -fvisibility in the clang command ? I compiled the clang with your patch, it looks do not always emit "-fvisibility default" to cc1. I understand wrong on your summary ?
- If clang will emit "-fvisibility default" to cc1 when there is no -fvisibility in the clang command, it is a new functionality , there should be a test case for it?
rebase code
Mar 3 2021
modify a test case
rebased the patch
Mar 2 2021
Gentle ping @sfertile , any new comment on the patch ?
Feb 9 2021
Jan 21 2021
Jan 19 2021
Jan 18 2021
Jan 15 2021
Jan 11 2021
Jan 4 2021
Dec 22 2020
addressed comment and rebased the patch on the https://reviews.llvm.org/D93659 [AIX][XCOFF] emit vector info of traceback table.
Dec 21 2020
Dec 18 2020
Dec 16 2020
Dec 15 2020
rebased the patch based on the https://reviews.llvm.org/D92398.
for Jason is on vacation , I will take over the revision and rebase the patch based on the committed https://reviews.llvm.org/D92398
Dec 14 2020
Dec 11 2020
change function from setParameterType to appendParameterType
address comment including fixing a paramtype bug and adding a new content in test case.
Dec 10 2020
LGTM
address comment
no further comment on it . It just need to rebased after
Dec 9 2020
address comment
Dec 8 2020
address comment
Dec 7 2020
address comment
Dec 4 2020
address comment.
Dec 3 2020
Dec 2 2020
address comment
Dec 1 2020
Nov 27 2020
address comment
address comment
address comment