Page MenuHomePhabricator
Feed Advanced Search

Thu, Jul 2

DiggerLin updated the summary of D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jul 2, 7:57 PM · Restricted Project
DiggerLin updated the summary of D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jul 2, 7:57 PM · Restricted Project
DiggerLin accepted D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s).

LGTM ,but it need other person to approve it before landing.

Thu, Jul 2, 7:33 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jul 2, 7:31 AM · Restricted Project

Tue, Jun 30

DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Tue, Jun 30, 10:18 AM · Restricted Project
DiggerLin retitled D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d from [AIX][XCOFF][Patch1] Decode trace back table information for xcoff object file for llvm-objdump -d to [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Tue, Jun 30, 8:39 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment and delete the llvm-objdump related code from this patch.

Tue, Jun 30, 8:39 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Tue, Jun 30, 7:33 AM · Restricted Project

Mon, Jun 29

DiggerLin updated the summary of D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Mon, Jun 29, 6:58 AM · Restricted Project

Fri, Jun 26

DiggerLin added inline comments to D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s).
Fri, Jun 26, 10:55 AM · Restricted Project
DiggerLin added inline comments to D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s).
Fri, Jun 26, 8:10 AM · Restricted Project

Thu, Jun 25

DiggerLin updated the summary of D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jun 25, 8:00 AM · Restricted Project
DiggerLin updated the summary of D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jun 25, 8:00 AM · Restricted Project
DiggerLin retitled D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d from [AIX][XCOFF] Decode trace back table information for xcoff object file for llvm-objdump -d to [AIX][XCOFF][Patch1] Decode trace back table information for xcoff object file for llvm-objdump -d .
Thu, Jun 25, 8:00 AM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address unit test failure.

Thu, Jun 25, 8:00 AM · Restricted Project
DiggerLin created D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Thu, Jun 25, 7:26 AM · Restricted Project

Wed, Jun 24

DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Wed, Jun 24, 2:07 PM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
  1. Separate the patch into two patchs.
  2. This patch provided API for decoded the traceback table info and unit test for the these API.
  3. This patch also provided framework of how to print out the traceback table for the llvm-objdump. (it only print out boundary , Version and Language )
  4. The next patch will print out the remaining traceback table information for llvm-objdump.
Wed, Jun 24, 9:42 AM · Restricted Project

Thu, Jun 18

DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Thu, Jun 18, 8:07 AM · Restricted Project

Wed, Jun 17

DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

address comment and print the traceback table information in new format in something like

140: 00 00 00 00                 # Traceback table begin
144: 00 00 22 40                 # Version=0
                                           # Language = C
                                           # -GlobaLinkage, -Is_Eprol, +Has_CodeLen, -Int_Proc
                                            , -Has_Ctl, -TOCLess, +FP_Present, -Log_Abort
                                           # -Int_Handler, +Name_Present, -Used_Alloca, Cl_Dis_Inv=0
                                           , -Saves_CR, -Saves_LR
                      ....
Wed, Jun 17, 9:40 AM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Wed, Jun 17, 9:08 AM · Restricted Project

Thu, Jun 11

DiggerLin committed rGc6be3ea524c2: [NFC] clean up the AsmPrinter::emitLinkage for AIX part (authored by DiggerLin).
[NFC] clean up the AsmPrinter::emitLinkage for AIX part
Thu, Jun 11, 11:01 AM
DiggerLin closed D81613: [NFC] clean up the AsmPrinter::emitLinkage for AIX part.
Thu, Jun 11, 11:00 AM · Restricted Project
DiggerLin added a comment to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

Please run clang-format on all your new code. You're adding an awful lot in one go, and I can't believe that it's all got test cases. I think you'd be better to split it down into smaller pieces, perhaps only implementing a small part of the dumper functionality in each.

Is there an existing tool that the output format is supposed to match? I'm not particularly keen on the output as-is, so would like to suggest changes if you're not trying to match an existing style.

Thu, Jun 11, 9:19 AM · Restricted Project

Wed, Jun 10

DiggerLin created D81613: [NFC] clean up the AsmPrinter::emitLinkage for AIX part.
Wed, Jun 10, 2:28 PM · Restricted Project
DiggerLin updated the diff for D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Wed, Jun 10, 12:13 PM · Restricted Project
DiggerLin added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Wed, Jun 10, 12:13 PM · Restricted Project
DiggerLin created D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Wed, Jun 10, 9:56 AM · Restricted Project

Tue, Jun 9

DiggerLin committed rG2a3f5021f5db: Added test case for the patch D75866 "supporting the visibility attribute for… (authored by DiggerLin).
Added test case for the patch D75866 "supporting the visibility attribute for…
Tue, Jun 9, 1:49 PM
DiggerLin committed rGedd819c7576b: [AIX] supporting the visibility attribute for aix assembly (authored by DiggerLin).
[AIX] supporting the visibility attribute for aix assembly
Tue, Jun 9, 1:16 PM
DiggerLin closed D75866: [AIX] supporting the visibility attribute for aix assembly.
Tue, Jun 9, 1:15 PM · Restricted Project

Mon, Jun 8

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Mon, Jun 8, 1:18 PM · Restricted Project

Sat, Jun 6

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Sat, Jun 6, 2:25 PM · Restricted Project
DiggerLin added a comment to D75866: [AIX] supporting the visibility attribute for aix assembly.

in order not to let this patch too big, I will create NFC patch to clean up the AsmPrinter::emitLinkage.

Sat, Jun 6, 2:25 PM · Restricted Project

Fri, Jun 5

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

rebase the patch and address comment

Fri, Jun 5, 10:01 AM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Fri, Jun 5, 8:18 AM · Restricted Project

Jun 4 2020

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Jun 4 2020, 8:44 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

change test case based on comment

Jun 4 2020, 7:38 AM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jun 4 2020, 7:38 AM · Restricted Project

Jun 3 2020

DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jun 3 2020, 2:20 PM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jun 3 2020, 2:20 PM · Restricted Project
DiggerLin added a comment to D81104: [XCOFF][AIX] report_fatal_error when an overflow section is needed.

why the file llvm/test/CodeGen/PowerPC/aix-xcoff-reloc-overflow.ll so large ,it can not be loaded?

Jun 3 2020, 2:20 PM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Jun 3 2020, 2:20 PM · Restricted Project

Jun 2 2020

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

Jun 2 2020, 2:16 PM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Jun 2 2020, 1:43 PM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
Jun 2 2020, 1:43 PM · Restricted Project
DiggerLin updated the summary of D75866: [AIX] supporting the visibility attribute for aix assembly.
Jun 2 2020, 1:10 PM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

Jun 2 2020, 10:58 AM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jun 2 2020, 10:58 AM · Restricted Project

Jun 1 2020

DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
Jun 1 2020, 9:39 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

Jun 1 2020, 9:39 AM · Restricted Project

May 29 2020

DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

May 29 2020, 2:14 PM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
May 29 2020, 1:40 PM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
May 29 2020, 1:40 PM · Restricted Project
DiggerLin committed rG34cfed24ebd3: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description (authored by DiggerLin).
[AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description
May 29 2020, 8:41 AM
DiggerLin closed D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 29 2020, 8:40 AM · Restricted Project

May 28 2020

DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 28 2020, 8:06 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 28 2020, 8:06 AM · Restricted Project
DiggerLin added inline comments to D80642: [AIX] Emit AvailableExternally Linkage on AIX.
May 28 2020, 7:02 AM · Restricted Project

May 27 2020

DiggerLin added inline comments to D80642: [AIX] Emit AvailableExternally Linkage on AIX.
May 27 2020, 2:42 PM · Restricted Project
DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 27 2020, 12:29 PM · Restricted Project
DiggerLin added inline comments to D80642: [AIX] Emit AvailableExternally Linkage on AIX.
May 27 2020, 12:29 PM · Restricted Project
DiggerLin added inline comments to D80642: [AIX] Emit AvailableExternally Linkage on AIX.
May 27 2020, 12:29 PM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 27 2020, 9:11 AM · Restricted Project

May 26 2020

DiggerLin accepted D80402: [NFC][XCOFF][AIX] Return function entry point symbol with dedicate function.

LGTM

May 26 2020, 10:49 AM · Restricted Project
DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

address comment

May 26 2020, 8:06 AM · Restricted Project
DiggerLin added inline comments to D80402: [NFC][XCOFF][AIX] Return function entry point symbol with dedicate function.
May 26 2020, 7:34 AM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
May 26 2020, 7:34 AM · Restricted Project

May 25 2020

DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

May 25 2020, 2:28 PM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 25 2020, 2:28 PM · Restricted Project

May 21 2020

DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment

May 21 2020, 9:41 AM · Restricted Project

May 19 2020

DiggerLin abandoned D80011: [AIX][XCOFF] implement available externally linkage ..
May 19 2020, 8:07 AM · Restricted Project

May 15 2020

DiggerLin updated the summary of D80011: [AIX][XCOFF] implement available externally linkage ..
May 15 2020, 11:25 AM · Restricted Project
DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment

May 15 2020, 10:51 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 15 2020, 10:51 AM · Restricted Project
DiggerLin updated the diff for D80011: [AIX][XCOFF] implement available externally linkage ..
May 15 2020, 8:39 AM · Restricted Project
DiggerLin retitled D80011: [AIX][XCOFF] implement available externally linkage . from [AIX][XCOFF] implement a available externally linkage . to [AIX][XCOFF] implement available externally linkage ..
May 15 2020, 8:06 AM · Restricted Project
DiggerLin created D80011: [AIX][XCOFF] implement available externally linkage ..
May 15 2020, 8:06 AM · Restricted Project
DiggerLin updated the summary of D80011: [AIX][XCOFF] implement available externally linkage ..
May 15 2020, 8:06 AM · Restricted Project

May 13 2020

DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment

May 13 2020, 7:01 AM · Restricted Project
DiggerLin added inline comments to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.
May 13 2020, 7:00 AM · Restricted Project

May 11 2020

DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 11 2020, 8:34 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

May 11 2020, 8:34 AM · Restricted Project

May 8 2020

DiggerLin updated the diff for D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

address comment and added a new unit test case

May 8 2020, 1:59 PM · Restricted Project
DiggerLin added a comment to D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description.

There seems to be quite a lot of new code here, but only one minor test change. The MCDisassembler ordering stuff looks like a prime candidate for gtest unit-testing. You could probably fairly easily unit-test the SymbolInfoTy comparison method too.

May 8 2020, 7:28 AM · Restricted Project

May 7 2020

DiggerLin accepted D79127: [XCOFF][AIX] Emit correct alignment for csect.

LGTM

May 7 2020, 10:14 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

May 7 2020, 9:40 AM · Restricted Project

May 6 2020

DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 6 2020, 1:01 PM · Restricted Project
DiggerLin updated the diff for D75866: [AIX] supporting the visibility attribute for aix assembly.

change code based on the emit .extern and .weak patch

May 6 2020, 10:46 AM · Restricted Project
DiggerLin added inline comments to D75866: [AIX] supporting the visibility attribute for aix assembly.
May 6 2020, 9:40 AM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 6 2020, 8:02 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 6 2020, 8:02 AM · Restricted Project
DiggerLin updated the summary of D75866: [AIX] supporting the visibility attribute for aix assembly.
May 6 2020, 6:57 AM · Restricted Project

May 5 2020

DiggerLin accepted D79220: [XCOFF] XCOFF constants, MCObjectFileInfo placeholder code for DWARF; NFC.

LGTM

May 5 2020, 1:30 PM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

May 5 2020, 10:46 AM · Restricted Project
DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

address comment

May 5 2020, 6:58 AM · Restricted Project
DiggerLin added inline comments to D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.
May 5 2020, 6:57 AM · Restricted Project

May 4 2020

DiggerLin added inline comments to D79127: [XCOFF][AIX] Emit correct alignment for csect.
May 4 2020, 8:33 AM · Restricted Project
DiggerLin added inline comments to D79220: [XCOFF] XCOFF constants, MCObjectFileInfo placeholder code for DWARF; NFC.
May 4 2020, 6:54 AM · Restricted Project

May 3 2020

DiggerLin updated the diff for D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol.

store llvm intrinsic symbols in the PPCAIXAsmPrinter

May 3 2020, 4:59 PM · Restricted Project