LGTM ,but it need other person to approve it before landing.
Thu, Jul 2
Tue, Jun 30
address comment and delete the llvm-objdump related code from this patch.
Mon, Jun 29
Fri, Jun 26
Thu, Jun 25
address unit test failure.
Wed, Jun 24
- Separate the patch into two patchs.
- This patch provided API for decoded the traceback table info and unit test for the these API.
- This patch also provided framework of how to print out the traceback table for the llvm-objdump. (it only print out boundary , Version and Language )
- The next patch will print out the remaining traceback table information for llvm-objdump.
Thu, Jun 18
Wed, Jun 17
address comment and print the traceback table information in new format in something like
140: 00 00 00 00 # Traceback table begin 144: 00 00 22 40 # Version=0 # Language = C # -GlobaLinkage, -Is_Eprol, +Has_CodeLen, -Int_Proc , -Has_Ctl, -TOCLess, +FP_Present, -Log_Abort # -Int_Handler, +Name_Present, -Used_Alloca, Cl_Dis_Inv=0 , -Saves_CR, -Saves_LR ....
Thu, Jun 11
Please run clang-format on all your new code. You're adding an awful lot in one go, and I can't believe that it's all got test cases. I think you'd be better to split it down into smaller pieces, perhaps only implementing a small part of the dumper functionality in each.
Is there an existing tool that the output format is supposed to match? I'm not particularly keen on the output as-is, so would like to suggest changes if you're not trying to match an existing style.
Wed, Jun 10
Tue, Jun 9
Mon, Jun 8
Sat, Jun 6
in order not to let this patch too big, I will create NFC patch to clean up the AsmPrinter::emitLinkage.
Fri, Jun 5
rebase the patch and address comment
Jun 4 2020
change test case based on comment
Jun 3 2020
why the file llvm/test/CodeGen/PowerPC/aix-xcoff-reloc-overflow.ll so large ,it can not be loaded?
Jun 2 2020
Jun 1 2020
May 29 2020
May 28 2020
May 27 2020
May 26 2020
May 25 2020
May 21 2020
May 19 2020
May 15 2020
May 13 2020
May 11 2020
May 8 2020
address comment and added a new unit test case
There seems to be quite a lot of new code here, but only one minor test change. The MCDisassembler ordering stuff looks like a prime candidate for gtest unit-testing. You could probably fairly easily unit-test the SymbolInfoTy comparison method too.
May 7 2020
May 6 2020
change code based on the emit .extern and .weak patch
May 5 2020
May 4 2020
May 3 2020
store llvm intrinsic symbols in the PPCAIXAsmPrinter