Make the test case insensitive to compiler optimizations.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Fri, Jul 1
Mon, Jun 27
In D50304#3611390, @goncharov wrote:FYI this caused a test breakage at lldb-aarch64-ubuntu, https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c
Fri, Jun 24
Thank you.
Sorry for spamming. But I am not sure if you have received my previous messages.
Thu, Jun 23
Tue, Jun 21
Ping.
Mon, Jun 20
Fri, Jun 17
In D50304#3586710, @jingham wrote:For some reason I'm not getting mail notifications for review changes, sorry about that.
This is certainly better than the original implementation. Among other things, if we find an exact match, we really shouldn't be doing any more inexact matches, so after the first exact hit it should have switched exact to true.
But if you had line tables laid out like (this is in increasing order of address:
10
20
30
10
16and you did "thread until 15", this would find the inexact match at 20, switch to an exact match for line 20 and find no other matches. But the gap between 10 & 16 in the line table is maybe an even more plausible place to put the line 15 until breakpoint, so maybe we did want to throw a breakpoint there as well?
@jingham
Nope, with the current patch, we would find the inexact match at 16.
Tue, Jun 14
@jingham looks like you missed to notice this one as well.
Address feedback.
Ping.
Ping.
Mon, Jun 13
Sun, Jun 12
Removed llvm/IR/Metadata.h header inclusion.
Address feedback.
Thu, Jun 9
Ping.
Ping.
Wed, Jun 8
Thank you @aprantl.
Jun 7 2022
Address review feedback.
Jun 6 2022
Thank you very much @djtodoro.
Jun 5 2022
Ping.
Does this look good now to land?
Does this look good now to land?
Jun 2 2022
Went ahead and added the error capturing for setting incorrect thread id and also the fix.
Added the test coverage.
Jun 1 2022
May 28 2022
I have tried to add a test but it's becoming difficult for me to come-up with a failing test scenario. Is it okay to commit this without a test?
May 27 2022
May 18 2022
Ping
May 5 2022
Ping.
Apr 7 2022
Ping
Mar 22 2022
@djtodoro thanks for the quick response
Address feedback.
Could someone review/comment/approve this revision?
Rebase onto ToT.
Mar 8 2022
In D114652#3367310, @arsenm wrote:I'm not sure I understand why a separate isPhysRegUsed check is needed since ultimately that's what IPRA is doing, but I don't see how it could hurt
Address review feedback.
Mar 7 2022
Fixed the blender application failure seen in the downstream testing.
In D120922#3363739, @arsenm wrote:An artificial test with high pressure would be more reliable long term. Branches on constants could be fragile
Mar 3 2022
Feb 21 2022
Rebase and ping.
Jan 14 2022
Fixed an issue exposed by OpenMP LIT test failures.
Jan 13 2022
This test will be used to verify the fix that will be added to https://reviews.llvm.org/D114652 for resolving the OpenMP LIT failures.
In D117064#3236907, @Flakebi wrote:This looks like it was fixed by D114652, but that got reverted?
Dec 22 2021
Dec 20 2021
I think I have addressed all the outstanding feedback. Is this good to go now?
Rebase onto ToT and use copyImplicitOps.
Dec 15 2021
Rebase onto ToT and also made the following changes to address review feedback.
Dec 6 2021
Dec 2 2021
Dec 1 2021
Rebase and fix tests in llvm/test/CodeGen/AMDGPU/callee-frame-setup.ll.
Nov 26 2021
Re-use the existing constexpr option table.
Nov 25 2021
Remove the unnecessary if {} gaurding around range for loop.
Address review comments.
In D114448#3150900, @DavidSpickett wrote:Not sure if you're a regular contributor and already know this but in case not, I tend to use https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting for doing clang-format stuff. It'll format only the lines you've changed.
Thanks for the comments.