Page MenuHomePhabricator
Feed Advanced Search

Fri, Jul 1

RamNalamothu updated the diff for D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Make the test case insensitive to compiler optimizations.

Fri, Jul 1, 9:50 AM · Restricted Project, Restricted Project
RamNalamothu reopened D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.
Fri, Jul 1, 9:50 AM · Restricted Project, Restricted Project

Mon, Jun 27

RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

FYI this caused a test breakage at lldb-aarch64-ubuntu, https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c

Mon, Jun 27, 9:27 AM · Restricted Project, Restricted Project

Fri, Jun 24

RamNalamothu committed rGa57b62deef37: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers (authored by RamNalamothu).
[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers
Fri, Jun 24, 11:31 AM · Restricted Project
RamNalamothu closed D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.
Fri, Jun 24, 11:31 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Thank you.

Fri, Jun 24, 10:57 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Sorry for spamming. But I am not sure if you have received my previous messages.

Fri, Jun 24, 9:35 AM · Restricted Project, Restricted Project

Thu, Jun 23

RamNalamothu committed rG5d2cc4d838c1: [AMDGPU][NFC] Correct typo in DWARF Extensions For Heterogeneous Debugging (authored by RamNalamothu).
[AMDGPU][NFC] Correct typo in DWARF Extensions For Heterogeneous Debugging
Thu, Jun 23, 10:35 PM · Restricted Project, Restricted Project
RamNalamothu closed D128210: [AMDGPU][NFC] Correct typo in DWARF Extensions For Heterogeneous Debugging.
Thu, Jun 23, 10:35 PM · Restricted Project, Restricted Project

Tue, Jun 21

RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Ping.

Tue, Jun 21, 9:31 PM · Restricted Project, Restricted Project

Mon, Jun 20

RamNalamothu requested review of D128210: [AMDGPU][NFC] Correct typo in DWARF Extensions For Heterogeneous Debugging.
Mon, Jun 20, 8:22 AM · Restricted Project, Restricted Project

Fri, Jun 17

RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

For some reason I'm not getting mail notifications for review changes, sorry about that.

This is certainly better than the original implementation. Among other things, if we find an exact match, we really shouldn't be doing any more inexact matches, so after the first exact hit it should have switched exact to true.

But if you had line tables laid out like (this is in increasing order of address:

10
20
30
10
16

and you did "thread until 15", this would find the inexact match at 20, switch to an exact match for line 20 and find no other matches. But the gap between 10 & 16 in the line table is maybe an even more plausible place to put the line 15 until breakpoint, so maybe we did want to throw a breakpoint there as well?

@jingham
Nope, with the current patch, we would find the inexact match at 16.

Fri, Jun 17, 11:47 AM · Restricted Project, Restricted Project

Tue, Jun 14

RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

@jingham looks like you missed to notice this one as well.

Tue, Jun 14, 10:39 PM · Restricted Project, Restricted Project
RamNalamothu committed rGab7fcf24849d: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID (authored by RamNalamothu).
[LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID
Tue, Jun 14, 8:22 PM · Restricted Project
RamNalamothu closed D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.
Tue, Jun 14, 8:22 PM · Restricted Project, Restricted Project
RamNalamothu committed rG340b0ca90095: [llvm] Add DW_CC_nocall to function debug metadata when either return values or… (authored by RamNalamothu).
[llvm] Add DW_CC_nocall to function debug metadata when either return values or…
Tue, Jun 14, 3:00 PM · Restricted Project, Restricted Project
RamNalamothu closed D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Tue, Jun 14, 3:00 PM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Tue, Jun 14, 1:10 PM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.

Address feedback.

Tue, Jun 14, 1:06 PM · Restricted Project, Restricted Project
RamNalamothu added a comment to D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

Ping.

Tue, Jun 14, 11:55 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Ping.

Tue, Jun 14, 11:54 AM · Restricted Project, Restricted Project

Mon, Jun 13

RamNalamothu added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Mon, Jun 13, 9:30 PM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Mon, Jun 13, 6:52 PM · Restricted Project, Restricted Project

Sun, Jun 12

RamNalamothu updated the diff for D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.

Removed llvm/IR/Metadata.h header inclusion.

Sun, Jun 12, 1:34 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Sun, Jun 12, 12:40 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.

Address feedback.

Sun, Jun 12, 12:34 AM · Restricted Project, Restricted Project

Thu, Jun 9

RamNalamothu added a comment to D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

Ping.

Thu, Jun 9, 7:19 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Ping.

Thu, Jun 9, 7:19 AM · Restricted Project, Restricted Project

Wed, Jun 8

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Thank you @aprantl.

Wed, Jun 8, 9:41 PM · Restricted Project, debug-info, Restricted Project

Jun 7 2022

RamNalamothu added inline comments to D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Jun 7 2022, 1:16 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.

Address review feedback.

Jun 7 2022, 1:13 AM · Restricted Project, Restricted Project

Jun 6 2022

RamNalamothu requested review of D127134: [llvm] Add DW_CC_nocall to function debug metadata when either return values or arguments are removed.
Jun 6 2022, 10:59 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Thank you very much @djtodoro.

Jun 6 2022, 8:02 AM · Restricted Project, debug-info, Restricted Project

Jun 5 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping.

Jun 5 2022, 8:02 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu added a comment to D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

Does this look good now to land?

Jun 5 2022, 7:59 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Does this look good now to land?

Jun 5 2022, 7:59 AM · Restricted Project, Restricted Project

Jun 2 2022

RamNalamothu added reviewers for D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID: wallace, JDevlieghere, clayborg.
Jun 2 2022, 11:46 PM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

Went ahead and added the error capturing for setting incorrect thread id and also the fix.

Jun 2 2022, 11:44 PM · Restricted Project, Restricted Project
RamNalamothu added a reviewer for D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers: wallace.
Jun 2 2022, 11:17 PM · Restricted Project, Restricted Project
RamNalamothu added reviewers for D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers: labath, JDevlieghere.
Jun 2 2022, 10:08 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.

Added the test coverage.

Jun 2 2022, 10:04 AM · Restricted Project, Restricted Project
RamNalamothu committed rGc6ad6901734f: [lldb, test] Fix typos in the lldb tests (authored by RamNalamothu).
[lldb, test] Fix typos in the lldb tests
Jun 2 2022, 12:16 AM · Restricted Project
RamNalamothu closed D126596: [lldb, test] Fix typos in the lldb tests.
Jun 2 2022, 12:16 AM · Restricted Project, Restricted Project

Jun 1 2022

RamNalamothu added a reviewer for D126596: [lldb, test] Fix typos in the lldb tests: JDevlieghere.
Jun 1 2022, 10:36 AM · Restricted Project, Restricted Project

May 28 2022

RamNalamothu commandeered D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers.
May 28 2022, 8:03 PM · Restricted Project, Restricted Project
RamNalamothu requested review of D126596: [lldb, test] Fix typos in the lldb tests.
May 28 2022, 8:40 AM · Restricted Project, Restricted Project
RamNalamothu updated subscribers of D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.

I have tried to add a test but it's becoming difficult for me to come-up with a failing test scenario. Is it okay to commit this without a test?

May 28 2022, 6:58 AM · Restricted Project, Restricted Project

May 27 2022

RamNalamothu commandeered D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID.
May 27 2022, 7:38 AM · Restricted Project, Restricted Project

May 18 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping

May 18 2022, 7:12 AM · Restricted Project, debug-info, Restricted Project

May 5 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping.

May 5 2022, 2:39 AM · Restricted Project, debug-info, Restricted Project

Apr 7 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping

Apr 7 2022, 6:36 AM · Restricted Project, debug-info, Restricted Project

Mar 22 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

@djtodoro thanks for the quick response

Mar 22 2022, 7:13 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Address feedback.

Mar 22 2022, 6:49 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Could someone review/comment/approve this revision?

Mar 22 2022, 2:13 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the summary of D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.
Mar 22 2022, 2:05 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase onto ToT.

Mar 22 2022, 2:04 AM · Restricted Project, debug-info, Restricted Project

Mar 8 2022

RamNalamothu committed rG04fff547e281: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved… (authored by RamNalamothu).
[AMDGPU] Move call clobbered return address registers s[30:31] to callee saved…
Mar 8 2022, 10:48 PM · Restricted Project
RamNalamothu closed D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Mar 8 2022, 10:48 PM · Restricted Project, Restricted Project
RamNalamothu added a comment to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

I'm not sure I understand why a separate isPhysRegUsed check is needed since ultimately that's what IPRA is doing, but I don't see how it could hurt

Mar 8 2022, 8:43 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Mar 8 2022, 2:39 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Address review feedback.

Mar 8 2022, 2:35 AM · Restricted Project, Restricted Project

Mar 7 2022

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Fixed the blender application failure seen in the downstream testing.

Mar 7 2022, 4:48 PM · Restricted Project, Restricted Project
RamNalamothu committed rGe1069c1288d1: [AMDGPU] Ensure return address is save/restored if clobbered or when function… (authored by RamNalamothu).
[AMDGPU] Ensure return address is save/restored if clobbered or when function…
Mar 7 2022, 8:32 AM · Restricted Project
RamNalamothu closed D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.
Mar 7 2022, 8:31 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.

An artificial test with high pressure would be more reliable long term. Branches on constants could be fragile

Mar 7 2022, 7:07 AM · Restricted Project, Restricted Project

Mar 3 2022

RamNalamothu requested review of D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.
Mar 3 2022, 10:47 AM · Restricted Project, Restricted Project

Feb 21 2022

RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase and ping.

Feb 21 2022, 11:15 AM · Restricted Project, debug-info, Restricted Project

Jan 14 2022

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Fixed an issue exposed by OpenMP LIT test failures.

Jan 14 2022, 11:22 AM · Restricted Project, Restricted Project
RamNalamothu reopened D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Jan 14 2022, 11:21 AM · Restricted Project, Restricted Project
RamNalamothu closed D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 14 2022, 11:20 AM · Restricted Project
RamNalamothu reopened D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 14 2022, 11:17 AM · Restricted Project

Jan 13 2022

RamNalamothu committed rG0bcd9f60cd0d: [AMDGPU] Ensure return address is save/restored around the call with IPRA… (authored by RamNalamothu).
[AMDGPU] Ensure return address is save/restored around the call with IPRA…
Jan 13 2022, 1:39 PM
RamNalamothu closed D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 13 2022, 1:39 PM · Restricted Project
RamNalamothu added a comment to D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.

This test will be used to verify the fix that will be added to https://reviews.llvm.org/D114652 for resolving the OpenMP LIT failures.

Jan 13 2022, 12:43 PM · Restricted Project
RamNalamothu requested review of D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 13 2022, 12:38 PM · Restricted Project
RamNalamothu added a comment to D117064: AMDGPU/GlobalISel: Fix not adding return address use to tail calls.

This looks like it was fixed by D114652, but that got reverted?

Jan 13 2022, 7:07 AM · Restricted Project

Dec 22 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 22 2021, 7:24 AM · Restricted Project, Restricted Project
RamNalamothu committed rG9075009d1fd5: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved… (authored by RamNalamothu).
[AMDGPU] Move call clobbered return address registers s[30:31] to callee saved…
Dec 22 2021, 7:21 AM
RamNalamothu closed D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 22 2021, 7:21 AM · Restricted Project, Restricted Project

Dec 20 2021

RamNalamothu added a comment to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

I think I have addressed all the outstanding feedback. Is this good to go now?

Dec 20 2021, 5:58 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase onto ToT and use copyImplicitOps.

Dec 20 2021, 5:52 AM · Restricted Project, Restricted Project

Dec 15 2021

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase onto ToT and also made the following changes to address review feedback.

Dec 15 2021, 3:36 AM · Restricted Project, Restricted Project

Dec 6 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 6 2021, 6:20 AM · Restricted Project, Restricted Project

Dec 2 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 7:53 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 6:35 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 2:36 AM · Restricted Project, Restricted Project

Dec 1 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 9:19 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 8:41 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 6:23 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase and fix tests in llvm/test/CodeGen/AMDGPU/callee-frame-setup.ll.

Dec 1 2021, 6:05 AM · Restricted Project, Restricted Project

Nov 26 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Nov 26 2021, 8:42 PM · Restricted Project, Restricted Project
RamNalamothu requested review of D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Nov 26 2021, 10:37 AM · Restricted Project, Restricted Project
RamNalamothu committed rG7f05ff8be481: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command (authored by ramana-nvr).
[Bug 49018][lldb] Fix incorrect help text for 'memory write' command
Nov 26 2021, 5:45 AM
RamNalamothu closed D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 26 2021, 5:44 AM · Restricted Project
RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Re-use the existing constexpr option table.

Nov 26 2021, 5:05 AM · Restricted Project
RamNalamothu added inline comments to D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 26 2021, 4:58 AM · Restricted Project

Nov 25 2021

RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Remove the unnecessary if {} gaurding around range for loop.

Nov 25 2021, 11:42 PM · Restricted Project
RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Address review comments.

Nov 25 2021, 2:39 PM · Restricted Project
RamNalamothu added a comment to D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Not sure if you're a regular contributor and already know this but in case not, I tend to use https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting for doing clang-format stuff. It'll format only the lines you've changed.

Nov 25 2021, 12:55 PM · Restricted Project
RamNalamothu added a comment to D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents.

Thanks for the comments.

Nov 25 2021, 9:23 AM · Restricted Project