Page MenuHomePhabricator
Feed Advanced Search

May 27 2019

andrewrk accepted D62475: Change DIEnumerator payload type to APInt.

LGTM

May 27 2019, 7:52 AMRestricted Project

May 21 2019

andrewrk accepted D62185: [mach-o] Extend LC_DATA_IN_CODE support to x86_64.

LGTM

May 21 2019, 9:12 AMRestricted Project

Apr 16 2019

andrewrk added a comment to D60758: Add an assertion that parallelForEach doesn't nest..

That makes sense 馃憤

Apr 16 2019, 1:22 AMRestricted Project
andrewrk accepted D60758: Add an assertion that parallelForEach doesn't nest..

This will be nice to prevent bugs in the future. Should it be behind #ifndef NDEBUG though? Presumably if assertions are disabled then this bug would be expected to be undefined behavior and avoid the overhead of the thread local variable, is that right?

Apr 16 2019, 1:12 AMRestricted Project
andrewrk accepted D60757: Fix a crash bug caused by a nested call of parallelForEach..

I tested this and confirm that it solves the bug (which I reported).

Apr 16 2019, 1:02 AMRestricted Project

Feb 13 2019

andrewrk accepted D58204: CMake: Fix stand-alone clang builds since r353268.

I confirm this solves the issue.

Feb 13 2019, 1:25 PMRestricted Project, Restricted Project

Feb 1 2019

andrewrk added a comment to D57586: Release Notes: Add Zig to External Open Source Projects Using LLVM 8.

Thanks Hans. I'll need you to do it on my behalf as I do not have commit privileges.

Feb 1 2019, 7:10 AMRestricted Project
andrewrk created D57586: Release Notes: Add Zig to External Open Source Projects Using LLVM 8.
Feb 1 2019, 7:00 AMRestricted Project

Jan 4 2019

andrewrk added inline comments to D56297: [DWARFUnit] Don't assume basic types..
Jan 4 2019, 3:41 PM
andrewrk added inline comments to D56297: [DWARFUnit] Don't assume basic types..
Jan 4 2019, 1:00 PM
andrewrk added a comment to D56297: [DWARFUnit] Don't assume basic types..

Is the problem that it is a SubroutineType, but not a function *pointer*?
Generally, if the Verifier accepts it we ought to not crash, so this seems to be okay, but it might be worth asking whether this is really what you want your frontend to be creating since subroutinetypes don't have a size, etc.

Jan 4 2019, 12:56 PM

Dec 30 2018

andrewrk added a comment to D54667: [CodeView] Emit proper debug info for ref-qualified member functions.
In D54667#1341372, @rnk wrote:

In that case, you might want to add the DINode::FlagStaticMember flag to all your methods. If a DISubprogram lists a DICompositeType as its scope or is used as an element of the composite type, it gets treated as a C++-style method where the first argument is assumed to be 'this'. That's a very C++-centric way to do things, so it might be nicer if we explicitly marked C++ instance methods, but that's the way things are today and changing it would require thinking about backwards compatibility. >_>

The benefit of explicitly marking everything as a "static" method for zig is that if the first argument happens to be a pointer type it won't end up looking like an instance method.

Dec 30 2018, 10:27 AM

Dec 26 2018

andrewrk added a comment to D54667: [CodeView] Emit proper debug info for ref-qualified member functions.
In D54667#1340985, @rnk wrote:

We can change the code to avoid the crash, but what debug info did you want clang to emit? It seems like the best way to describe StructWithNoFields_add is as a static method of the class StructWithNoFields, since it doesn't appear to have a 'this' parameter.

Dec 26 2018, 5:55 PM

Dec 23 2018

andrewrk added a comment to D54667: [CodeView] Emit proper debug info for ref-qualified member functions.

I think this patch broke Zig's tests:

Dec 23 2018, 4:14 PM

Dec 4 2018

andrewrk updated the diff for D55276: ELF: allow non allocated sections to go into allocated sections.

Added Rui's test case. Thank you for helping me with that. Please note that I do not have commit privileges and so someone will have to merge this on my behalf.

Dec 4 2018, 10:42 AM
andrewrk updated the summary of D55276: ELF: allow non allocated sections to go into allocated sections.
Dec 4 2018, 10:41 AM
andrewrk created D55276: ELF: allow non allocated sections to go into allocated sections.
Dec 4 2018, 8:41 AM

Aug 27 2018

andrewrk added a comment to D51265: Headers: fix collisions with .h files of other projects.

What is this change actually solving? Even if the typedef is actually redundant, it shouldn't cause a compiler error: redundant typedefs are allowed in the latest versions of the C and C++ standards. (And even if you were targeting an earlier standard, we normally suppress warnings in system headers.)

Aug 27 2018, 8:50 PMRestricted Project

Aug 25 2018

andrewrk updated the diff for D51265: Headers: fix collisions with .h files of other projects.

Addressed review feedback

Aug 25 2018, 8:24 PMRestricted Project
andrewrk created D51265: Headers: fix collisions with .h files of other projects.
Aug 25 2018, 7:45 PMRestricted Project

Aug 22 2018

andrewrk created D51118: Release Notes: Add Zig to External Open Source Projects Using LLVM 7.
Aug 22 2018, 12:05 PM

Jul 26 2018

andrewrk added a comment to D49856: [COFF] clean up global resources after completion.

Thanks. Can you do the commit? I do not have commit access.

Jul 26 2018, 10:03 AM
andrewrk created D49856: [COFF] clean up global resources after completion.
Jul 26 2018, 8:15 AM

Jul 9 2018

andrewrk added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Ping

Jul 9 2018, 7:13 AM

Jun 15 2018

andrewrk added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Ping. Is it time yet? Looks like the stated blockers are resolved now.

Jun 15 2018, 10:45 AM

Apr 11 2018

andrewrk accepted D45536: Do not keep shared symbols to garbage-collected eliminated DSOs..

I confirm that this fixes https://bugs.llvm.org/show_bug.cgi?id=36991

Apr 11 2018, 3:00 PM

Mar 30 2018

andrewrk created D45106: [Build] Use LIBXML2_LIBRARIES from find_package.
Mar 30 2018, 1:28 PM

Mar 2 2018

andrewrk added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Would llvm interact with grow_memory or memory_size instructions? Seems like that would be the frontend or standard library's job. It's not in LLVM's business to interact with the "OS" by allocating memory.

Mar 2 2018, 9:55 AM
andrewrk added a comment to D40526: [WebAssembly] Change size_t to `unsigned long`.

Is there anything stopping this from landing in svn?

Mar 2 2018, 9:55 AM

Feb 19 2018

andrewrk abandoned D43368: add llvm.coro.sizeof intrinsic.

Never mind these changes. I've redesigned how coroutines will work in Zig and they no longer depend on these changes.

Feb 19 2018, 5:34 PM

Feb 15 2018

andrewrk updated the summary of D43368: add llvm.coro.sizeof intrinsic.
Feb 15 2018, 8:27 PM
andrewrk created D43368: add llvm.coro.sizeof intrinsic.
Feb 15 2018, 8:27 PM

Feb 12 2018

andrewrk added a reviewer for D43211: [WebAssembly] promote from experimental to normal target: sbc100.
Feb 12 2018, 2:40 PM
andrewrk retitled D43211: [WebAssembly] promote from experimental to normal target from promote WebAssembly from experimental to normal target to [WebAssembly] promote from experimental to normal target.
Feb 12 2018, 2:40 PM
andrewrk created D43211: [WebAssembly] promote from experimental to normal target.
Feb 12 2018, 2:37 PM

Jan 16 2018

andrewrk added a comment to D41875: docs: add Zig to External Open Source Projects.

Hans, thank you for reviewing. I do not have commit access; would you mind committing it for me, in whatever order you prefer?

Jan 16 2018, 7:17 AM

Jan 11 2018

andrewrk updated the diff for D41875: docs: add Zig to External Open Source Projects.

rebase

Jan 11 2018, 9:23 AM

Jan 9 2018

andrewrk created D41875: docs: add Zig to External Open Source Projects.
Jan 9 2018, 11:47 AM

Jan 8 2018

andrewrk added a comment to D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value.

I would have selected a repository but the instructions explicitly say not to:

Leave the Repository field blank.

Jan 8 2018, 7:30 AM

Jan 6 2018

andrewrk added a comment to D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value.

I'll be careful next time, thanks. I used the web interface. Arcanist seemed more involved, but if that is preferable I can do it next time.

Jan 6 2018, 9:18 PM
andrewrk added a comment to D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value.

Thank you, I will CC llvm-commits next time. I followed these instructions: https://llvm.org/docs/Phabricator.html

Jan 6 2018, 10:34 AM
andrewrk added a comment to D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value.

I would also like to request that this is backported to the release_60 branch.

Jan 6 2018, 10:08 AM
andrewrk created D41803: ldd::COFF: initalize ErrorHandler with CanExitEarly value.
Jan 6 2018, 10:07 AM

Nov 2 2017

andrewrk added a comment to D39514: Use allocate_file in FileOutputBuffer to avoid possible bus error..

Which we prefer, maximum IO performance or a reliable error handling?

Nov 2 2017, 6:48 AM

Oct 23 2017

andrewrk accepted D39202: lld::COFF: better behavior when using as a library.
Oct 23 2017, 12:56 PM
andrewrk awarded D39202: lld::COFF: better behavior when using as a library a Like token.
Oct 23 2017, 12:53 PM

Aug 18 2017

andrewrk added a comment to D35387: [MACH-O] Fix the ASM code generated for __stub_helpers section.
  • Can we have this even without tests?
    • Can we have this in 5.0.0?
Aug 18 2017, 6:17 PMlld