Page MenuHomePhabricator
Feed Advanced Search

Mar 11 2021

yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch is updated with a few more test cases with max/min etc in omp-reduction07.f90 and also TODO comments. Hope they are acceptable.

Thanks to @clementval and @kiranchandramohan for accepting this PR and for the review comments. Thanks to @praveen for the kind co operation.

Please go ahead and submit.
Thanks for your help and patience @yhegde, @praveen. Goes without saying, You are both welcome to make contributions to Flang and OpenMP in particular.
Best wishes for your future endeavours.

Mar 11 2021, 10:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2021

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch is updated with a few more test cases with max/min etc in omp-reduction07.f90 and also TODO comments. Hope they are acceptable.

Mar 10 2021, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Mar 10 2021, 10:09 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2021

yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

LGTM. Thanks for the patience.

Thank you for the review comments. Sure will update the diff with the suggestions.

Mar 8 2021, 5:43 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

LGTM. Yes, using the symbol is the right way here.
Thanks @yhegde for separating this out into a new patch. Thanks also for you patience and all your work for semantic checks for OpenMP.

Mar 8 2021, 5:40 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2021

yhegde updated the diff for D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

Patch updated and rebased to check Threadprivate variables in do loops , across the modules.

Mar 6 2021, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for the suggestion. This patch is rebased and updated with the popping of end_section and other end worksharing clauses fix.

Mar 6 2021, 5:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2021

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch is updated after addressing the review comments.

Mar 4 2021, 10:36 PM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2021

yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

There are a few comments not marked as done. Are these not done or have been just not marked done?

Mar 3 2021, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2021

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 27 2021, 11:13 PM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2021

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 24 2021, 12:12 PM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2021

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Patch updated and rebased after addressing the reviewer's comments.

Feb 23 2021, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 23 2021, 3:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2021

yhegde added a comment to D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

It works for the following case.

Feb 16 2021, 6:02 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

@kiranchandramohan , I was working with the following test case you have given ,

module md
integer :: i
!$omp threadprivate(i)
end module

program mn
use md
!$omp do
do i = 1, 10

do j = 1, 10
  print *, "Hello"
end do

end do
!$omp end do
end program
+++++++++++++++++++++++++++

The threadPrivateSymbol will get reset once the subroutine called up and it is set as OmpPredetermined and OmpPrivate and adjusted with in the DO loop region and it seems calling DeclareOrMarkOtherAccessEntity to set the Symbol flag to OmpThreadprivate and I think MakeAssocSymbol called with OmpPrivate to create HostAssocDetails. Then I am getting the symbol from HostAssocDtails and then checking whether it is OmpThreadprivate . Its working and throwing the following err.

./tpmodule.f90:9:4: error: Loop iteration variable i is not allowed in THREADPRIVATE.

do i = 1, 10 
   ^

if this is the case , I suppose no where I need to call ClearThreadPrivateSymbols() because all the symbols in the threadPrivateSymbols are reset and new symbols get generated ( local copies probably ). Do you think I am missing anything ? Is this ok ? Please let me know. Thank you.

Feb 16 2021, 4:25 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

@kiranchandramohan , I was working with the following test case you have given ,

Feb 16 2021, 4:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2021

yhegde requested review of D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.
Feb 14 2021, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 14 2021, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

LGTM. I have a Nit comment.

Thank you @kiranchandramohan

Feb 14 2021, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Patch updated and rebased after addressing the review comments.

Feb 14 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 14 2021, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for the review comments. @kiranchandramohan . The patch is updated after addressing the review comments.

Feb 14 2021, 1:02 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2021

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 13 2021, 10:01 PM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2021

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Based on Reviewer's comments , this patch is now updated with DoWhile , Cycles and other checks. Threadprivate related checks are removed.

Feb 10 2021, 9:55 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2021

yhegde added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Thanks @yhegde for the changes. I believe this threadprivate check needs some more design and work. I don' t think we can clear the threadprivate symbols in module subprograms because it will fail to catch the error in test1 below. I think the threadprivate information should be captured in a symbol so that it is available in places where the module is used like in test2.

Feb 9 2021, 6:55 PM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2021

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Addressed the review comments and rebased .

Feb 8 2021, 11:00 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 6 2021, 12:09 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 3 2021, 9:55 PM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

This patch address the review comments.
The cycle related checks are in OmpCycleChecker class.
The test cases omp-do08.f90 and then omp-do12.f90 to omp-do17.f90 are the test cases for cycle checks.

Feb 3 2021, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 3 2021, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

I think you are doing three patches worth of work in a single one. Ideally, we could have had, One patch for the cycle restrictions, One patch for threadprivate, and One patch for the rest.

Feb 3 2021, 7:39 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 2 2021, 9:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 1 2021, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 1 2021, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch has the following changes.

  1. The functions CheckIntentInPointer and CheckDefinableObjects are combined and renamed as 'CheckIntentInPointerAndDefinable'.
  2. Removed CheckDependArraySection function.
  3. cleaned up unwanted code around multimap which was required earlier to reuse some part of the code.
  4. Added few test cases in omp-reduction02.f90 and omp-reduction07.f90 to address the review comments.
  5. Removed some unnecessary code in CheckIsVarPartOfAnotherVar
Feb 1 2021, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Feb 1 2021, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 30 2021, 7:01 AM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2021

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

The patch is updated with Cycle checks in IfConstruct and CaseConstruct with omp-do15.f90 ,omp-do16.f90 and omp-do17.f90 . The parser::Walk is out of the loop now and called only once. Cycles are mostly a concern when appear in do loops with collapse clause. Hence most of the test cases are with collapse.

Jan 29 2021, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 29 2021, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 27 2021, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2021

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Code that are related to ordered clause and cycle stmts are modified to address the review comments.

Jan 26 2021, 11:21 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 26 2021, 11:17 AM · Restricted Project, Restricted Project, Restricted Project

Jan 21 2021

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Addressed review comments.

Jan 21 2021, 7:08 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 21 2021, 6:17 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2021

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Jan 14 2021, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2021

yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Addressed the review comments related to loopIV.

Jan 13 2021, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 13 2021, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Rebased with the latest changes.

Jan 13 2021, 3:53 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 13 2021, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Updated the patch with few more test cases.

Jan 13 2021, 2:30 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2021

yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 12 2021, 11:44 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 12 2021, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 12 2021, 6:20 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2021

yhegde added a comment to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 11 2021, 10:25 PM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Addressed the review comments.

Jan 11 2021, 10:24 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Jan 11 2021, 11:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2021

yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Rebased again.

Jan 9 2021, 3:16 AM · Restricted Project, Restricted Project, Restricted Project

Jan 8 2021

yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Rebased with some code changes.

Jan 8 2021, 5:57 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2021

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

With updated Reduction Clause.

Jan 5 2021, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

With updated Reduction Clause (OmpObjectList).

Jan 5 2021, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Dec 30 2020

yhegde added a reviewer for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause: praveen.
Dec 30 2020, 6:10 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Addressed review issues. Code with similar checks are reused. There are minor changes in depend clause related checks because same function is called from reduction clause related checks.

Dec 30 2020, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

Dec 24 2020

yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 24 2020, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 24 2020, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Dec 22 2020

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Dec 22 2020, 2:29 AM · Restricted Project, Restricted Project, Restricted Project

Dec 21 2020

yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 21 2020, 10:43 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Why are you changing the tests while removing XFAIL? eg. omp-do05.f90 was supposed to check chunk_size.

Dec 21 2020, 10:36 PM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

This patch is updated with corrections to positive test cases and indentations.

Dec 21 2020, 9:55 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 21 2020, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

The following are not implemented. They also don't seem to be in the list of items to do. Do you know why they were not added?

Dec 21 2020, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

This patch is updated with corrections to positive cases and indentations.

Dec 21 2020, 4:00 AM · Restricted Project, Restricted Project, Restricted Project

Dec 20 2020

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch is updated with corrections to positive test cases and indentations.

Dec 20 2020, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Dec 19 2020

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Dec 19 2020, 3:43 AM · Restricted Project, Restricted Project, Restricted Project

Dec 18 2020

yhegde added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Dec 18 2020, 9:59 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 9:51 PM · Restricted Project, Restricted Project
yhegde added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 18 2020, 9:36 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

@yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Dec 18 2020, 8:36 PM · Restricted Project, Restricted Project
yhegde added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

@yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Dec 18 2020, 5:24 AM · Restricted Project, Restricted Project

Dec 14 2020

yhegde requested review of D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 14 2020, 4:24 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2020

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Rebased. Requesting the review comments.

Dec 13 2020, 11:22 PM · Restricted Project, Restricted Project, Restricted Project

Dec 10 2020

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Implementation includes a check to "the ordered clause must be present on the loop construct if any ordered region ever binds to a loop region arising from the loop construct" - along with the previous Do loop iteration variable check , Do while loop check , Do loop threadprivate check, Do loop cycle restrictions.

Dec 10 2020, 8:23 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2020

yhegde updated the diff for D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Test cases added for named do loops. Global variables removed.

Dec 8 2020, 6:36 AM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2020

yhegde requested review of D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Dec 6 2020, 10:33 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2020

yhegde abandoned D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

As reviewers feel this semantic check is not needed, I am closing this review.

Dec 1 2020, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

Yes was referring to the 2), second one actually. So probably what check introduced in this patch is applicable as a semantic check. And I suppose the one which you were suggesting can be done at runtime. Also kindly suggest how I can go ahead with this patch.

I was saying that the check that you have introduced in this patch is a direction to the OpenMP runtime on how to assign iterations to threads. Having different chunk sizes on different loops in a parallel region is OK, it is just that the iteration to threads mapping will be different.

My recommendation is to drop this check unless you have a strong reason to not to.

Dec 1 2020, 6:46 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

I only saw the following one which puts some conditions for using the same assignment of logical iteration numbers to threads for two loops. If these conditions are not met it is just that the implementation can use a different assignment. Are you referring to something else?

"A compliant implementation of the static schedule must ensure that the same assignment of logical iteration numbers to threads will be used in two loop regions if the following conditions are satisfied: 1) both loop regions have the same number of loop iterations, 2) both loop regions have the same value of chunk_size specified, or both loop regions have no chunk_size specified, 3) both loop regions bind to the same parallel region,

and 4) neither loop is associated with a SIMD construct. A data dependence between the same logical iterations in two such loops is guaranteed to be satisfied allowing safe use of the nowait clause."

Dec 1 2020, 4:12 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added inline comments to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.
Dec 1 2020, 12:34 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2020

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch resolves the name symbol for the procedure, called in Reduction clause.
A new test case is added -
omp-reduction10.f90.

Nov 25 2020, 10:13 PM · Restricted Project, Restricted Project, Restricted Project

Nov 24 2020

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Nov 24 2020, 11:11 PM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2020

yhegde closed D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

Committed. https://reviews.llvm.org/rG3fa20baf009d

Nov 22 2020, 5:20 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2020

yhegde added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Shall I assume there are no issues with this patch. ?

Nov 21 2020, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Nov 21 2020, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

Thank you very much for the inputs @kiranchandramohan . If my understanding is correct, this test case requires a run time check and probably it is not possible to do a semantic check.

Nov 21 2020, 2:11 AM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2020

yhegde requested review of D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.
Nov 20 2020, 9:58 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2020

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for review comments.
The code changes with this patch includes ResolvingNames for max, min, iand, ior, and ieor , assuming that the reduction clause can take user defined procedures.

Nov 17 2020, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 13 2020

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thank you both @kiranchandramohan and @clementval for your review comments and inputs.

Nov 13 2020, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

yhegde updated the diff for D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

Thanks for reviewing.
Function name PrivatizeAssociatedLoopIndex is changed to PrivatizeAssociatedLoopIndexAndCheckLoopLevel.

Nov 12 2020, 9:53 PM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Thanks a lot for the review comments.
Requesting a quick review of this accepted patch. I had to revert the code part related to Shared and Private clause from the review https://reviews.llvm.org/D90324.

Nov 12 2020, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for this patch.

Can you check what is happening with this test?

      subroutine sb(q,nx)
      integer :: q(100)
      integer :: t1, t8
!$OMP PARALLEL DO PRIVATE(k,t1) REDUCTION(max:t8)
      do k=1,nx
        t1=q(k)
        t8=max(t8,t1)
      enddo
      end
Nov 12 2020, 6:50 AM · Restricted Project, Restricted Project, Restricted Project

Nov 7 2020

yhegde updated the diff for D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.
  1. Clause names are changed to uppercase in test cases.
  2. An optional StringRef paramName is introduced. Non optional paramName would break the previous test cases.
Nov 7 2020, 9:04 PM · Restricted Project, Restricted Project, Restricted Project