Page MenuHomePhabricator
Feed Advanced Search

Today

grimar requested review of D92318: [llvm-readobj, libSupport] - Refine the implementation of the code that dumps build attributes..
Mon, Nov 30, 6:16 AM · Restricted Project
grimar requested review of D92316: [llvm-readobj][test] - Merge 2 test cases together..
Mon, Nov 30, 6:12 AM · Restricted Project
grimar added inline comments to D92301: [LLD][ELF] - Don't keep empty output sections that are explicitly assigned to segment..
Mon, Nov 30, 4:11 AM
grimar updated the diff for D92301: [LLD][ELF] - Don't keep empty output sections that are explicitly assigned to segment..
  • Addressed review comments.
Mon, Nov 30, 4:11 AM
grimar updated the diff for D91249: [obj2yaml] - Teach tool to emit the "SectionHeaderTable" key and sort sections by file offset..
  • Updated implementation. Now this patch also emits the "SectionHeaderTable" key in according to the description.
Mon, Nov 30, 3:24 AM · Restricted Project
grimar requested review of D92301: [LLD][ELF] - Don't keep empty output sections that are explicitly assigned to segment..
Mon, Nov 30, 1:23 AM
grimar accepted D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.

LGTM too.

Mon, Nov 30, 12:31 AM · Restricted Project
grimar accepted D92294: [X86] Support modifier @PLTOFF for R_X86_64_PLTOFF64.

LGTM

Mon, Nov 30, 12:28 AM · Restricted Project
grimar added inline comments to D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.
Mon, Nov 30, 12:19 AM · Restricted Project
grimar added a comment to D92260: [ELF] Error for undefined foo@v1.

Sounds reasonable.

Mon, Nov 30, 12:05 AM · Restricted Project

Fri, Nov 27

grimar requested review of D92224: [llvm-readelf] - Switch to using from `reportWarning` to `reportUniqueWarning` in `DynRegionInfo`..
Fri, Nov 27, 5:54 AM · Restricted Project
grimar committed rGee9ffc73452a: [obj2yaml] - Dump the `EShNum` key in some cases. (authored by grimar).
[obj2yaml] - Dump the `EShNum` key in some cases.
Fri, Nov 27, 5:03 AM
grimar closed D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Fri, Nov 27, 5:03 AM · Restricted Project
grimar committed rGc2090ff59422: [obj2yaml] - Don't assert when trying to calculate the expected section offset. (authored by grimar).
[obj2yaml] - Don't assert when trying to calculate the expected section offset.
Fri, Nov 27, 4:45 AM
grimar closed D92163: [obj2yaml] - Don't assert when trying to calculate the expected section offset..
Fri, Nov 27, 4:45 AM · Restricted Project
grimar requested review of D92218: [llvm-readelf/obj] - Move unique warning handling logic to the `ObjDumper`..
Fri, Nov 27, 2:51 AM · Restricted Project

Thu, Nov 26

grimar committed rG3d811c57aa1a: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`. (authored by grimar).
[llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`.
Thu, Nov 26, 11:43 PM
grimar closed D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..
Thu, Nov 26, 11:43 PM · Restricted Project
grimar requested review of D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 5:30 AM · Restricted Project
grimar updated the diff for D92098: [obj2yaml] - Dump the `EShNum` key in some cases..

I am experimenting with the patch which preserves the EShNum key when e_shnum == 0. It is usefull for the normal scenario when
the number of sections is greater than or equal to the SHN_LORESERVE .

I'll rebase this patch later. I think that after we start emitting the EShNum = 0, this patch will produce an equivalent output for the input given.

Thu, Nov 26, 5:30 AM · Restricted Project
grimar planned changes to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..

I am experimenting with the patch which preserves the EShNum key when e_shnum == 0. It is usefull for the normal scenario when
the number of sections is greater than or equal to the SHN_LORESERVE .

Thu, Nov 26, 4:18 AM · Restricted Project
grimar requested review of D92163: [obj2yaml] - Don't assert when trying to calculate the expected section offset..
Thu, Nov 26, 2:47 AM · Restricted Project
grimar committed rG54ec9bb5510d: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic… (authored by grimar).
[llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic…
Thu, Nov 26, 2:17 AM
grimar closed D92087: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic tag is invalid..
Thu, Nov 26, 2:16 AM · Restricted Project
grimar accepted D92151: [MC] Set the unique id of .stack_sizes to the associated .text section's.

LGTM

Thu, Nov 26, 2:01 AM · Restricted Project
grimar added inline comments to D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..
Thu, Nov 26, 1:57 AM · Restricted Project
grimar updated the diff for D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..
  • Addressed review comments.
Thu, Nov 26, 1:57 AM · Restricted Project
grimar added inline comments to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 1:29 AM · Restricted Project
grimar added inline comments to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 12:56 AM · Restricted Project
grimar added inline comments to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 12:51 AM · Restricted Project
grimar added inline comments to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 12:47 AM · Restricted Project
grimar updated the diff for D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
  • Addressed review comments.
Thu, Nov 26, 12:47 AM · Restricted Project
grimar added a comment to D92151: [MC] Set the unique id of .stack_sizes to the associated .text section's.

I've added @jhenderson. who might be interested in .stack_sizes related changes too I guess.

Thu, Nov 26, 12:17 AM · Restricted Project
grimar updated subscribers of D92151: [MC] Set the unique id of .stack_sizes to the associated .text section's.
Thu, Nov 26, 12:16 AM · Restricted Project
grimar added inline comments to D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Thu, Nov 26, 12:12 AM · Restricted Project
grimar added a comment to D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.

Note, R_X86_64_GOTPCRELX already does not guarantee ensured relaxation, e.g. when the symbol is preemptible the linker cannot relax the instruction, when the instruction is not one of call,jmp,adc,add,and,cmp,or,sbb,sub,test,xor, etc.

Thu, Nov 26, 12:04 AM · Restricted Project

Wed, Nov 25

grimar added a comment to D92114: [X86] Don't emit R_X86_64_[REX_]GOTPCRELX for a GOT load with an offset.

I think this makes sense. When we know that a relocation can't be relaxed, we should not emit a potentially relaxable relocation.
This just adds an excessive job to linker and not useful.

Wed, Nov 25, 11:51 PM · Restricted Project
grimar committed rGc3673ea65df5: [llvm-readobj] - Fix a warning. (authored by grimar).
[llvm-readobj] - Fix a warning.
Wed, Nov 25, 11:25 PM
grimar added inline comments to D92018: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI..
Wed, Nov 25, 11:25 PM · Restricted Project
grimar requested review of D92098: [obj2yaml] - Dump the `EShNum` key in some cases..
Wed, Nov 25, 6:19 AM · Restricted Project
grimar committed rGce322fb0b897: [llvm-readelf/obj] - Stop using `reportError` when dumping notes. (authored by grimar).
[llvm-readelf/obj] - Stop using `reportError` when dumping notes.
Wed, Nov 25, 4:32 AM
grimar closed D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
Wed, Nov 25, 4:31 AM · Restricted Project
grimar requested review of D92090: [llvm-readelf/obj] - Stop calling `reportError` in `printArchSpecificInfo()`..
Wed, Nov 25, 4:19 AM · Restricted Project
grimar requested review of D92087: [llvm-readelf/obj] - Report a warning when the value of the DT_PLTREL dynamic tag is invalid..
Wed, Nov 25, 3:09 AM · Restricted Project
grimar updated the diff for D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
  • Rebased.
Wed, Nov 25, 2:20 AM · Restricted Project
grimar committed rGfee910e522c9: [libObject,llvm-readelf] - Stop describing a section/segment in `notes_begin()`. (authored by grimar).
[libObject,llvm-readelf] - Stop describing a section/segment in `notes_begin()`.
Wed, Nov 25, 1:59 AM
grimar closed D92081: [libObject,llvm-readelf] - Stop describing a section/segment in `notes_begin()`..
Wed, Nov 25, 1:58 AM · Restricted Project
grimar committed rG5edb90c92713: [obj2yaml] - Dump section offsets in some cases. (authored by grimar).
[obj2yaml] - Dump section offsets in some cases.
Wed, Nov 25, 1:49 AM
grimar closed D91152: [obj2yaml] - Dump section offsets in some cases..
Wed, Nov 25, 1:49 AM · Restricted Project
grimar added a comment to D92081: [libObject,llvm-readelf] - Stop describing a section/segment in `notes_begin()`..

Just to rephrase your initial description to make sure I understand, the reason we can't rely on the notes_begin method to report the context itself is because not all errors that notes_begin could ultimately report have the information needed to provide this context, right? And because of this, we need the context to be added at a higher level, right?

Wed, Nov 25, 1:27 AM · Restricted Project
grimar added inline comments to D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
Wed, Nov 25, 1:08 AM · Restricted Project
grimar requested review of D92081: [libObject,llvm-readelf] - Stop describing a section/segment in `notes_begin()`..
Wed, Nov 25, 1:07 AM · Restricted Project
grimar accepted D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.

LGTM.

Wed, Nov 25, 12:47 AM · Restricted Project
grimar committed rGae7ac2d6654a: [llvm-readobj] - An attempt to fix BB after D92018. (authored by grimar).
[llvm-readobj] - An attempt to fix BB after D92018.
Wed, Nov 25, 12:39 AM
grimar added a comment to D91152: [obj2yaml] - Dump section offsets in some cases..

Ping @MaskRay?

Wed, Nov 25, 12:16 AM · Restricted Project
grimar committed rGec0b927e4aa8: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI. (authored by grimar).
[llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI.
Wed, Nov 25, 12:14 AM
grimar closed D92018: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI..
Wed, Nov 25, 12:14 AM · Restricted Project

Tue, Nov 24

grimar added a comment to D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.

My understanding is that R_X86_64_*RELX relocation should never be emitted when a relaxation is not possible.
ABI doesn't say anything about addends I think ("B.2 Optimize GOTPCRELX Relocations", p151, https://raw.githubusercontent.com/wiki/hjl-tools/x86-psABI/x86-64-psABI-1.0.pdf).
So, why should this be handled on linker side and not on the compiler side?

There are two questions:

  • Whether movl x@GOTPCREL+4(%rip), %eax is valid?
  • Whether the expression should assemble to R_X86_64_GOTPCRELX?

For the first, I tend to think it is valid - this allows the compiler generates an instruction to load the half part of the GOT entry.
For the second, my understanding is that R_X86_64_GOTPCREL can be entirely replaced by R_X86_64_[REX_]GOTPCRELX. If so, it is certainly reasonable to assemble to R_X86_64_GOTPCRELX. I can send a clarification on binutils, though.

Asked on binutils and HJ Lu said movl x@GOTPCREL+4(%rip), %eax is valid (https://sourceware.org/pipermail/binutils/2020-November/114264.html) and R_X86_64_GOTPCRELX is correct.
So I think we should proceed with this patch. I also created a gold bug report: https://sourceware.org/bugzilla/show_bug.cgi?id=26939

Tue, Nov 24, 11:38 PM · Restricted Project
grimar added inline comments to D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
Tue, Nov 24, 7:32 AM · Restricted Project
grimar updated the diff for D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
  • Updated forgotten test.
Tue, Nov 24, 4:08 AM · Restricted Project
grimar planned changes to D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
Tue, Nov 24, 4:04 AM · Restricted Project
grimar requested review of D92021: [llvm-readelf/obj] - Stop using `reportError` when dumping notes..
Tue, Nov 24, 4:03 AM · Restricted Project
grimar requested review of D92018: [llvm-readelf/obj] - Deduplicate the logic that prints notes. NFCI..
Tue, Nov 24, 3:08 AM · Restricted Project
grimar committed rG6b74eabfddbc: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog` (authored by grimar).
[llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`
Tue, Nov 24, 1:08 AM
grimar closed D91964: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`.
Tue, Nov 24, 1:08 AM · Restricted Project
grimar added inline comments to D91964: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`.
Tue, Nov 24, 12:57 AM · Restricted Project
grimar updated the diff for D91964: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`.
  • Addressed review comments.
Tue, Nov 24, 12:57 AM · Restricted Project
grimar committed rG245052ac3080: [llvm-readelf/obj] - Improve the error reporting in printStackSize(). (authored by grimar).
[llvm-readelf/obj] - Improve the error reporting in printStackSize().
Tue, Nov 24, 12:49 AM
grimar closed D91624: [llvm-readelf/obj] - Improve the error reporting in printStackSize()..
Tue, Nov 24, 12:49 AM · Restricted Project
grimar committed rGc3914bf28e39: [[lvm-readelf/obj] - Remove `tryGetSectionName` helper. (authored by grimar).
[[lvm-readelf/obj] - Remove `tryGetSectionName` helper.
Tue, Nov 24, 12:41 AM
grimar closed D91954: [llvm-readelf/obj] - Remove `tryGetSectionName` helper..
Tue, Nov 24, 12:41 AM · Restricted Project
grimar added a comment to D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.

My understanding is that R_X86_64_*RELX relocation should never be emitted when a relaxation is not possible.
ABI doesn't say anything about addends I think.
So, why should this be handled on linker side and not on the compiler side?

Tue, Nov 24, 12:07 AM · Restricted Project

Mon, Nov 23

grimar requested review of D91964: [llvm-readelf/obj] - Refine the implementation of `printGNUVersionSectionProlog`.
Mon, Nov 23, 6:58 AM · Restricted Project
grimar committed rG2745d9c586d1: [llvm-readobj][test] - Simplify the gnu-notes.test (authored by grimar).
[llvm-readobj][test] - Simplify the gnu-notes.test
Mon, Nov 23, 5:26 AM
grimar closed D91953: [llvm-readobj][test] - Simplify the gnu-notes.test.
Mon, Nov 23, 5:26 AM · Restricted Project
grimar added a comment to D91954: [llvm-readelf/obj] - Remove `tryGetSectionName` helper..

I thought there was a function that did this already. Sorry, should have mentioned it in the previous review. LGTM.

Mon, Nov 23, 4:29 AM · Restricted Project
grimar requested review of D91954: [llvm-readelf/obj] - Remove `tryGetSectionName` helper..
Mon, Nov 23, 3:25 AM · Restricted Project
grimar requested review of D91953: [llvm-readobj][test] - Simplify the gnu-notes.test.
Mon, Nov 23, 3:12 AM · Restricted Project
grimar committed rG76a626b2061b: [llvm-readelf/obj] - Fix the possible crash when dumping group sections. (authored by grimar).
[llvm-readelf/obj] - Fix the possible crash when dumping group sections.
Mon, Nov 23, 2:06 AM
grimar closed D91943: [llvm-readelf/obj] - Fix the possible crash when dumping group sections..
Mon, Nov 23, 2:06 AM · Restricted Project
grimar updated the diff for D91943: [llvm-readelf/obj] - Fix the possible crash when dumping group sections..
  • Addressed review comments.
Mon, Nov 23, 2:02 AM · Restricted Project
grimar committed rG4dcdf0df3125: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()` (authored by grimar).
[llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`
Mon, Nov 23, 1:49 AM
grimar closed D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`.
Mon, Nov 23, 1:49 AM · Restricted Project
grimar added inline comments to D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`.
Mon, Nov 23, 1:32 AM · Restricted Project
grimar added inline comments to D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`.
Mon, Nov 23, 1:27 AM · Restricted Project
grimar updated the diff for D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`.
  • Addressed review comments.
Mon, Nov 23, 1:27 AM · Restricted Project
grimar added inline comments to D91943: [llvm-readelf/obj] - Fix the possible crash when dumping group sections..
Mon, Nov 23, 1:25 AM · Restricted Project
grimar requested review of D91943: [llvm-readelf/obj] - Fix the possible crash when dumping group sections..
Mon, Nov 23, 12:56 AM · Restricted Project

Sun, Nov 22

grimar committed rG2584e1e324c9: [llvm-readobj] - Don't crash when relocation table goes past the EOF. (authored by grimar).
[llvm-readobj] - Don't crash when relocation table goes past the EOF.
Sun, Nov 22, 11:40 PM
grimar closed D91787: [llvm-readobj] - Don't crash when relocation table goes past the EOF..
Sun, Nov 22, 11:40 PM · Restricted Project

Fri, Nov 20

grimar requested review of D91867: [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`.
Fri, Nov 20, 6:10 AM · Restricted Project
grimar added inline comments to D91787: [llvm-readobj] - Don't crash when relocation table goes past the EOF..
Fri, Nov 20, 3:39 AM · Restricted Project
grimar added a comment to D91787: [llvm-readobj] - Don't crash when relocation table goes past the EOF..

Would adding --implicit-check-not=warning: to the test cases be useful?

Fri, Nov 20, 3:03 AM · Restricted Project
grimar updated the diff for D91787: [llvm-readobj] - Don't crash when relocation table goes past the EOF..
  • Addressed review comments.
Fri, Nov 20, 3:03 AM · Restricted Project
grimar added inline comments to D91624: [llvm-readelf/obj] - Improve the error reporting in printStackSize()..
Fri, Nov 20, 2:03 AM · Restricted Project
grimar updated the diff for D91624: [llvm-readelf/obj] - Improve the error reporting in printStackSize()..
  • Addressed review comments.
Fri, Nov 20, 2:03 AM · Restricted Project
grimar committed rG343dceb8315b: [llvm-readelf/obj] - Improve error reporting when dumping group sections. (authored by grimar).
[llvm-readelf/obj] - Improve error reporting when dumping group sections.
Fri, Nov 20, 1:42 AM
grimar closed D91798: [llvm-readelf/obj] - Improve error reporting when dumping group sections..
Fri, Nov 20, 1:42 AM · Restricted Project
grimar committed rGaadbe206221c: [llvm-readobj] - Introduce `forEachRelocationDo` helper. (authored by grimar).
[llvm-readobj] - Introduce `forEachRelocationDo` helper.
Fri, Nov 20, 1:30 AM
grimar closed D91530: [llvm-readobj] - Introduce `forEachRelocationDo` helper. NFCI..
Fri, Nov 20, 1:30 AM · Restricted Project