Page MenuHomePhabricator
Feed Advanced Search

Today

grimar added a comment to D63394: [yaml2obj][ELF] Suport STT_LOOS, STT_HIOS, STT_LOPROC and STT_HIPROC..

I'm totally fine with not commit this. But it seems just a small convenience from a tooling perspective (no need for the semantics of the symbol type) when you need the value but not in an OS or processor specific way and STT_LOOS looks better than "10"?

I may have been a bit hasty rejecting this. My concern is that I have already seen instances in LLVM where people possibly not well-versed in ELF try to use these as actual types in testing and in tools consuming these values, which can lead to confusion or worse, bogus output (e.g. llvm-readelf claiming that a symbol's type is STT_LOOS). @grimar, do you have any thoughts?

Mon, Jun 17, 11:14 AM · Restricted Project
grimar added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Mon, Jun 17, 5:20 AM · Restricted Project
grimar accepted D63398: [llvm-objdump] Use %08 instead of %016 to print leading addresses for 32-bit binaries.

LGTM

Mon, Jun 17, 2:40 AM · Restricted Project

Fri, Jun 14

grimar committed rG76d575312d6b: [LLD][ELF] - Fix test case after r363401 (authored by grimar).
[LLD][ELF] - Fix test case after r363401
Fri, Jun 14, 7:24 AM
grimar committed rL363402: [LLD][ELF] - Fix test case after r363401.
[LLD][ELF] - Fix test case after r363401
Fri, Jun 14, 7:23 AM
grimar committed rG0aecabae141b: Revert "Revert r363377: [yaml2obj] - Allow setting custom section types for… (authored by grimar).
Revert "Revert r363377: [yaml2obj] - Allow setting custom section types for…
Fri, Jun 14, 7:23 AM
grimar committed rL363401: Revert "Revert r363377: [yaml2obj] - Allow setting custom section types for….
Revert "Revert r363377: [yaml2obj] - Allow setting custom section types for…
Fri, Jun 14, 7:22 AM
grimar committed rGa59bc6e5890a: Revert r363395. (authored by grimar).
Revert r363395.
Fri, Jun 14, 7:04 AM
grimar committed rL363398: Revert r363395..
Revert r363395.
Fri, Jun 14, 7:04 AM
grimar committed rGa0b0d626ab84: [ELF] - Attemp to fix BB. (authored by grimar).
[ELF] - Attemp to fix BB.
Fri, Jun 14, 6:59 AM
grimar committed rL363395: [ELF] - Attemp to fix BB..
[ELF] - Attemp to fix BB.
Fri, Jun 14, 6:59 AM
grimar committed rG3b523c0a2e0c: [yaml2obj] - Allow setting custom section types for implicit sections. (authored by grimar).
[yaml2obj] - Allow setting custom section types for implicit sections.
Fri, Jun 14, 5:15 AM
grimar committed rL363377: [yaml2obj] - Allow setting custom section types for implicit sections..
[yaml2obj] - Allow setting custom section types for implicit sections.
Fri, Jun 14, 5:15 AM
grimar closed D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
Fri, Jun 14, 5:15 AM · Restricted Project
grimar committed rGd6df7ded6e3d: [llvm-readobj] - Do not fail to dump the object which has wrong type of . (authored by grimar).
[llvm-readobj] - Do not fail to dump the object which has wrong type of .
Fri, Jun 14, 4:54 AM
grimar committed rL363371: [llvm-readobj] - Do not fail to dump the object which has wrong type of ..
[llvm-readobj] - Do not fail to dump the object which has wrong type of .
Fri, Jun 14, 4:54 AM
grimar closed D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
Fri, Jun 14, 4:54 AM · Restricted Project
grimar committed rG43f62ff17c12: [yaml2obj] - Allow setting the custom Address for .strtab (authored by grimar).
[yaml2obj] - Allow setting the custom Address for .strtab
Fri, Jun 14, 4:15 AM
grimar committed rL363368: [yaml2obj] - Allow setting the custom Address for .strtab.
[yaml2obj] - Allow setting the custom Address for .strtab
Fri, Jun 14, 4:15 AM
grimar closed D63137: [yaml2obj] - Allow setting the custom Address for .strtab.
Fri, Jun 14, 4:14 AM · Restricted Project
grimar committed rGcfa1a62a4cc4: [yaml2obj] - Allow setting cutom Flags for implicit sections. (authored by grimar).
[yaml2obj] - Allow setting cutom Flags for implicit sections.
Fri, Jun 14, 3:59 AM
grimar committed rL363367: [yaml2obj] - Allow setting cutom Flags for implicit sections..
[yaml2obj] - Allow setting cutom Flags for implicit sections.
Fri, Jun 14, 3:58 AM
grimar closed D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..
Fri, Jun 14, 3:58 AM · Restricted Project
grimar added inline comments to D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
Fri, Jun 14, 3:42 AM · Restricted Project
grimar updated the diff for D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
  • Addressed review comments.
Fri, Jun 14, 3:42 AM · Restricted Project
grimar added inline comments to D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
Fri, Jun 14, 3:09 AM · Restricted Project
grimar updated the diff for D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
  • Addressed review comments.
  • Fixed compilation with GCC.
  • Added 2 lines of code to fix the Object/no-section-header-string-table.test

(It is needed for no section string table case, it matches the existent behavior).

Fri, Jun 14, 3:09 AM · Restricted Project
grimar added a comment to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

@grimar, are you happy for me to land this patch?

Fri, Jun 14, 2:51 AM · Restricted Project
grimar added inline comments to D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol.
Fri, Jun 14, 1:19 AM · Restricted Project

Thu, Jun 13

grimar added a parent revision for D63267: [yaml2obj] - Allow setting custom section types for implicit sections.: D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
Thu, Jun 13, 7:09 AM · Restricted Project
grimar added a child revision for D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab.: D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
Thu, Jun 13, 7:09 AM · Restricted Project
grimar created D63267: [yaml2obj] - Allow setting custom section types for implicit sections..
Thu, Jun 13, 7:08 AM · Restricted Project
grimar created D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab..
Thu, Jun 13, 7:08 AM · Restricted Project
grimar updated the diff for D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..
  • Addressed review comments.
Thu, Jun 13, 3:34 AM · Restricted Project
grimar added a comment to D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..

Do we have test cases anywhere for the sections' flags when they aren't described in the YAML?

Thu, Jun 13, 3:20 AM · Restricted Project
grimar accepted D63191: [lld][ELF] Check length of subsection in .ARM.attributes.

LGTM with one nit and Rui's comments addressed.

Thu, Jun 13, 2:21 AM · Restricted Project, lld
grimar accepted D63244: Add --undefined-glob which is an --undefined with wildcard pattern match..

LGTM. Minor suggestion is inlined.

Thu, Jun 13, 2:05 AM · Restricted Project

Tue, Jun 11

grimar created D63137: [yaml2obj] - Allow setting the custom Address for .strtab.
Tue, Jun 11, 7:09 AM · Restricted Project
grimar added a child revision for D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections.: D63137: [yaml2obj] - Allow setting the custom Address for .strtab.
Tue, Jun 11, 7:09 AM · Restricted Project
grimar created D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections..
Tue, Jun 11, 7:09 AM · Restricted Project
grimar accepted D63135: [docs][llvm-nm] Fix documentation regarding llvm-nm reading stdin.

I confirm it matches the behavior I am observing.

Tue, Jun 11, 6:32 AM · Restricted Project
grimar added a comment to D63121: [ELF] Make the rule to create relative relocations in a writable section stricter.

This looks good to me, I have no more comments.

Tue, Jun 11, 3:48 AM · Restricted Project
grimar committed rGfc7b91131331: [llvm-readobj] - Do not use precompiled binary in elf-broken-dynsym-link.test (authored by grimar).
[llvm-readobj] - Do not use precompiled binary in elf-broken-dynsym-link.test
Tue, Jun 11, 3:26 AM
grimar committed rL363045: [llvm-readobj] - Do not use precompiled binary in elf-broken-dynsym-link.test.
[llvm-readobj] - Do not use precompiled binary in elf-broken-dynsym-link.test
Tue, Jun 11, 3:26 AM
grimar committed rGffb3c72a746a: [yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym (authored by grimar).
[yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym
Tue, Jun 11, 2:58 AM
grimar committed rL363042: [yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym.
[yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym
Tue, Jun 11, 2:58 AM
grimar closed D63077: [yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym.
Tue, Jun 11, 2:58 AM · Restricted Project
grimar added inline comments to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.
Tue, Jun 11, 2:41 AM · Restricted Project
grimar added a comment to D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid.

Few comments are below. James, what do you think?

Tue, Jun 11, 2:33 AM · Restricted Project
grimar added inline comments to D63121: [ELF] Make the rule to create relative relocations in a writable section stricter.
Tue, Jun 11, 2:04 AM · Restricted Project
grimar added inline comments to rL363026: ELF: Don't process the partition end marker during combineEhSections()..
Tue, Jun 11, 1:43 AM
grimar added inline comments to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.
Tue, Jun 11, 1:27 AM · Restricted Project
grimar added a comment to D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs.

I have probably no more comments except 2 nits.

Tue, Jun 11, 1:18 AM · Restricted Project
grimar accepted D63014: [docs] Add "GNU binutils Replacements" section to command guide.

LGTM

Tue, Jun 11, 12:52 AM · Restricted Project

Mon, Jun 10

grimar created D63077: [yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym.
Mon, Jun 10, 8:19 AM · Restricted Project
grimar committed rG286a47116a8b: [yaml2obj] - Remove TODOs from dynsymtab-implicit-sections-size-content.yaml. (authored by grimar).
[yaml2obj] - Remove TODOs from dynsymtab-implicit-sections-size-content.yaml.
Mon, Jun 10, 7:31 AM
grimar committed rL362940: [yaml2obj] - Remove TODOs from dynsymtab-implicit-sections-size-content.yaml..
[yaml2obj] - Remove TODOs from dynsymtab-implicit-sections-size-content.yaml.
Mon, Jun 10, 7:30 AM
grimar committed rGdd4f253c4d8f: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has… (authored by grimar).
[llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has…
Mon, Jun 10, 7:21 AM
grimar committed rL362938: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has….
[llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has…
Mon, Jun 10, 7:20 AM
grimar closed D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
Mon, Jun 10, 7:20 AM · Restricted Project
grimar added inline comments to D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
Mon, Jun 10, 6:18 AM · Restricted Project
grimar updated the diff for D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
  • Addressed review comments.
Mon, Jun 10, 6:17 AM · Restricted Project
grimar committed rG1e41007aeba0: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection… (authored by grimar).
[yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection…
Mon, Jun 10, 5:42 AM
grimar committed rL362931: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection….
[yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection…
Mon, Jun 10, 5:40 AM
grimar closed D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
Mon, Jun 10, 5:40 AM · Restricted Project
grimar updated the diff for D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
  • Addressed review comments.
Mon, Jun 10, 5:15 AM · Restricted Project
grimar added inline comments to D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
Mon, Jun 10, 5:15 AM · Restricted Project
grimar updated the diff for D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
Mon, Jun 10, 4:50 AM · Restricted Project
grimar created D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
Mon, Jun 10, 4:49 AM · Restricted Project
grimar planned changes to D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field..
Mon, Jun 10, 4:49 AM · Restricted Project
grimar committed rG379aa18a3958: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is… (authored by grimar).
[yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is…
Mon, Jun 10, 4:36 AM
grimar committed rL362929: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is….
[yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is…
Mon, Jun 10, 4:36 AM
grimar closed D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Mon, Jun 10, 4:36 AM · Restricted Project
grimar updated the diff for D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
  • Addressed review comments.
Mon, Jun 10, 3:09 AM · Restricted Project
grimar added inline comments to D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Mon, Jun 10, 3:00 AM · Restricted Project
grimar updated the diff for D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
  • Addressed review comments.
Mon, Jun 10, 3:00 AM · Restricted Project
grimar committed rGd71017bc8631: [yaml2obj] - Remove helper methods that are probably excessive. NFC. (authored by grimar).
[yaml2obj] - Remove helper methods that are probably excessive. NFC.
Mon, Jun 10, 2:57 AM
grimar committed rL362925: [yaml2obj] - Remove helper methods that are probably excessive. NFC..
[yaml2obj] - Remove helper methods that are probably excessive. NFC.
Mon, Jun 10, 2:54 AM
grimar closed D63002: [yaml2obj] - Remove helper methods that are probably excessive. NFC..
Mon, Jun 10, 2:54 AM · Restricted Project
grimar added inline comments to D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Mon, Jun 10, 1:29 AM · Restricted Project

Fri, Jun 7

grimar removed a child revision for D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present.: D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
Fri, Jun 7, 5:54 AM · Restricted Project
grimar removed a parent revision for D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional: D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Fri, Jun 7, 5:54 AM · Restricted Project
grimar updated the diff for D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
  • Addressed review comments.
Fri, Jun 7, 5:52 AM · Restricted Project
grimar added a parent revision for D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional: D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Fri, Jun 7, 5:52 AM · Restricted Project
grimar added a child revision for D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present.: D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
Fri, Jun 7, 5:52 AM · Restricted Project
grimar accepted D62350: ELF: Create synthetic sections for loadable partitions..

Yep, looks fine.

Fri, Jun 7, 5:05 AM · Restricted Project
grimar added inline comments to D63003: [ELF] Don't emit dynamic relocations with weak undef in writable sections.
Fri, Jun 7, 3:58 AM · Restricted Project
grimar added inline comments to D63002: [yaml2obj] - Remove helper methods that are probably excessive. NFC..
Fri, Jun 7, 3:16 AM · Restricted Project
grimar added a comment to D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..

It is rebased on top of D63002.

Fri, Jun 7, 3:14 AM · Restricted Project
grimar added a child revision for D63002: [yaml2obj] - Remove helper methods that are probably excessive. NFC.: D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Fri, Jun 7, 3:13 AM · Restricted Project
grimar added a parent revision for D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present.: D63002: [yaml2obj] - Remove helper methods that are probably excessive. NFC..
Fri, Jun 7, 3:13 AM · Restricted Project
grimar created D63002: [yaml2obj] - Remove helper methods that are probably excessive. NFC..
Fri, Jun 7, 3:13 AM · Restricted Project
grimar created D63001: [yaml2obj] - Do not assert when .dynsym is specified explicitly, but .dynstr is not present..
Fri, Jun 7, 3:13 AM · Restricted Project
grimar added inline comments to D62957: [yaml2obj/obj2yaml] - Make RawContentSection::Content and RawContentSection::Size optional.
Fri, Jun 7, 2:32 AM · Restricted Project
grimar committed rG33044a7ae213: [llvm-objcopy] - Emit error and don't crash if program header reaches past end… (authored by grimar).
[llvm-objcopy] - Emit error and don't crash if program header reaches past end…
Fri, Jun 7, 1:32 AM
grimar committed rL362778: [llvm-objcopy] - Emit error and don't crash if program header reaches past end….
[llvm-objcopy] - Emit error and don't crash if program header reaches past end…
Fri, Jun 7, 1:31 AM
grimar closed D62898: [llvm-objcopy] - Emit error and don't crash if program header reaches past end of file..
Fri, Jun 7, 1:31 AM · Restricted Project
grimar committed rGeb394e93d2d3: [yaml2elf] - Refactoring followup for D62809 (authored by grimar).
[yaml2elf] - Refactoring followup for D62809
Fri, Jun 7, 1:30 AM
grimar committed rL362777: [yaml2elf] - Refactoring followup for D62809.
[yaml2elf] - Refactoring followup for D62809
Fri, Jun 7, 1:30 AM
grimar closed D62912: [yaml2elf] - Refactoring followup for D62809.
Fri, Jun 7, 1:30 AM · Restricted Project