Page MenuHomePhabricator
Feed Advanced Search

Today

grimar added a comment to D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..
  1. Using large chunk of raw bytes is a bad practice. Should we care much about keeping a shorter way to describe it?

I think this is the key question to me. We shouldn't be encouraging large binary blobs, and if we get a situation where one is needed, perhaps the test needs simplifying/converting to assembly, or obj2yaml/yaml2obj needs extending. In other words, I don't think this change is particularly useful, as blobs should be kept to very short amounts (circa 32 bytes I reckon at most).

Fri, Feb 28, 5:00 AM · Restricted Project
grimar updated the diff for D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method..
  • Rebase.
Fri, Feb 28, 4:59 AM · Restricted Project
grimar added inline comments to D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar updated the summary of D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar added a child revision for D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections.: D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar added parent revisions for D75342: [obj2yaml] - Teach tool to dump program headers.: D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections., D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar added a child revision for D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method.: D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar created D75342: [obj2yaml] - Teach tool to dump program headers..
Fri, Feb 28, 4:59 AM · Restricted Project
grimar updated the diff for D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..
  • Addressed review comments.
Fri, Feb 28, 2:58 AM · Restricted Project
grimar added a comment to D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..

How about the following plan?

  1. This patch: supporting both [0,1] and "3031" (hex pairs) in yaml2obj. Support [0x00, 0x01] in obj2yaml. Only obj2yaml tests need to be updated. There are only a few.
  2. A future change: change "3031" (hex pairs) to "01" (strings) in yaml2obj. ~180 tests need to be migrated. This can probably be done mechanically with a dedicated tool.

I did not understand it I think.
Currectly we support hex pairs, like "00112233". This patch suggests "[0x00, 0x01]" instead. Not sure I understand what do you mean by "strings" in (2)? I.e. what is the difference with "pairs" we have?

I might be completely misreading this, but i think @MaskRay is suggesting to get something like the string "foo" in a string table, for example, writing literally that instead of 666f6f.

Fri, Feb 28, 2:37 AM · Restricted Project
grimar added a comment to D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..

A thought, but I think it's a pre-existing issue: let's say I have a custom SHT_STRTAB section that isn't the symbol or section header string table. This code seems to prevent that section being emitted?

Fri, Feb 28, 2:25 AM · Restricted Project
grimar updated the diff for D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..
  • Updated comments in the implicit-sections-order.yaml test case.
Fri, Feb 28, 1:21 AM · Restricted Project
grimar added a comment to D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..

How about the following plan?

  1. This patch: supporting both [0,1] and "3031" (hex pairs) in yaml2obj. Support [0x00, 0x01] in obj2yaml. Only obj2yaml tests need to be updated. There are only a few.
  2. A future change: change "3031" (hex pairs) to "01" (strings) in yaml2obj. ~180 tests need to be migrated. This can probably be done mechanically with a dedicated tool.
Fri, Feb 28, 1:04 AM · Restricted Project

Yesterday

grimar updated the diff for D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
  • Addressed review comment.
Thu, Feb 27, 4:52 AM · Restricted Project
grimar updated the diff for D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..
  • Dump only allocatable sections.
Thu, Feb 27, 4:25 AM · Restricted Project
grimar added a comment to D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method..

On its own, it increases complexity.

Thu, Feb 27, 2:36 AM · Restricted Project
grimar planned changes to D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..

Will change in according to discussion.

Thu, Feb 27, 2:07 AM · Restricted Project
grimar added a comment to D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..

Okay, you make a fair amount of sense. I don't think a switch is necessarily needed. That being said, perhaps we could limit this to the dynamic symbol table and dynamic string table? I feel like .symtab and the non-dynamic string table(s) do not need printing, since they will normally be at the end, don't have addresses, and will just cause unnecessary noise if in the YAML.

Thu, Feb 27, 2:06 AM · Restricted Project
grimar added inline comments to D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
Thu, Feb 27, 1:55 AM · Restricted Project
grimar added inline comments to D75225: [ELF] Keep orphan section names (.rodata.foo .text.foo) unchanged if !hasSectionsCommand.
Thu, Feb 27, 12:33 AM · Restricted Project
grimar added inline comments to D75216: [lld][ELF] Add some release notes.
Thu, Feb 27, 12:17 AM · Restricted Project

Wed, Feb 26

grimar added a comment to D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method..

(This helps to simplify another patch I am working on).

Wed, Feb 26, 6:14 AM · Restricted Project
grimar created D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method..
Wed, Feb 26, 6:14 AM · Restricted Project
grimar added a comment to D74687: [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression..

Would it make sense to make /DISCARD/ its own token recognised by the Lexer? I believe that is what BFD does. It would prevent it from being recognised as "/" "DISCARD" "/". Apologies if this is not appropriate, I'm not too familiar with this part of the code.

Wed, Feb 26, 3:51 AM · Restricted Project
grimar added a comment to D74687: [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression..

I prefer an alternative: limit = to accept readPrimary instead of readFill:

if (peek() == "=" || peek().startswith("=")) {
  inExpr = true;
  consume("=");
  cmd->filler = readFill();
  inExpr = false;
}
Wed, Feb 26, 3:05 AM · Restricted Project
grimar planned changes to D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..

This need an update for the rest of test cases + I'd like to wait for the result of the discussion in this thread before doing anything.

Wed, Feb 26, 2:00 AM · Restricted Project
grimar added a comment to D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..

Just wanted to flag up a concern: "feff" -> [ 0xFE, 0xFF ] can make an opaque section content longer.

## Comment 1.
0xfe, 0xfe,
## Comment 2.
0xfe, 0xfe ]

Sometimes there may be a need to describe a little-endian 32-bit value, for example. Is the proposal to use 0x01, 0x00, 0x00, 0x00 for a little-endian 1?

Wed, Feb 26, 1:59 AM · Restricted Project
grimar accepted D75151: [ELF] --orphan-handling=: don't warn/error for input SHT_REL[A] retained by --emit-relocs.

LGTM

Wed, Feb 26, 1:18 AM · Restricted Project
grimar added inline comments to D75149: [ELF] --orphan-handling=: don't warn/error for unused synthesized sections.
Wed, Feb 26, 12:51 AM · Restricted Project
grimar accepted D75118: [DebugInfo][NFC] Remove handler with ErrorPolicy from DWARFContext..

I have only one comment. LGTM with it. Please wait to see if others have any comments too.

Wed, Feb 26, 12:24 AM · debug-info, Restricted Project

Tue, Feb 25

grimar retitled D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array. from [obj2yaml,yaml2obj] - Dump Content of the RawContentSection section as array. to [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..
Tue, Feb 25, 8:44 AM · Restricted Project
grimar updated the summary of D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..
Tue, Feb 25, 8:35 AM · Restricted Project
grimar created D75123: [obj2yaml,yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array..
Tue, Feb 25, 8:35 AM · Restricted Project
grimar added a comment to D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..

I don't have a clear solution to this yet, as I agree we shouldn't throw away important information like section addresses when using obj2yaml. I'm not concerned by the section header order, as that technically has no impact on anything (as long as section indexes in other things are updated correctly).

Tue, Feb 25, 6:47 AM · Restricted Project
grimar added inline comments to D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
Tue, Feb 25, 6:18 AM · Restricted Project
grimar updated the diff for D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
  • Addressed review comments.
Tue, Feb 25, 6:18 AM · Restricted Project
grimar added a comment to D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF..
In D74308#1891014, @avl wrote:

Ok. just to make me sure: we are going to remove "enum class ErrorPolicy { Halt, Continue };" completetly ?

Tue, Feb 25, 3:31 AM · debug-info, Restricted Project
grimar added a comment to D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF..

Right, so I think I see a path forward. I agree with @grimar that we need a way to pass the errors encountered during construction of DWARFObjInMemory back to the caller of the constructor (and therefore in turn to the caller of DWARFContext::create). However, I do not see a need for the existing continue/halt distinction. It seems harmless (aside from maybe slightly less performant) to continue in all cases. This means that we can change the signature of the callback to void(Error), like the other error callbacks, which in turn means we can use WithColor::defaultErrorHandler as the default error handling method instead of objectFileErrorHandler, and indeed, allows us therefore to remove the extra argument from the signature of create (because we can just use the RecoverableErrorHandler argument).

Does that make sense?

Tue, Feb 25, 2:52 AM · debug-info, Restricted Project
grimar committed rG157b3d505f61: [yaml2obj] - Address post commit comments for D74764 (authored by grimar).
[yaml2obj] - Address post commit comments for D74764
Tue, Feb 25, 2:35 AM
grimar added a comment to D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..

Two comment-related nits from me.

Tue, Feb 25, 2:33 AM · Restricted Project
grimar added a comment to D75015: [ARM] Rewrite ARMAttributeParser.

This is a large change and converting to lower case is making really hard to discern what the functional changes are.

Tue, Feb 25, 1:56 AM · Restricted Project
grimar added a comment to D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF..
In D74308#1889316, @avl wrote:

Will wait for @grimar comments.

Tue, Feb 25, 1:37 AM · debug-info, Restricted Project
grimar accepted D75100: [ELF] Support archive:file syntax in input section descriptions.

LGTM

Tue, Feb 25, 12:51 AM · Restricted Project

Sat, Feb 22

grimar committed rGa6370d579831: [lldb][test] - Update basic-elf.yaml to fix build bot. (authored by grimar).
[lldb][test] - Update basic-elf.yaml to fix build bot.
Sat, Feb 22, 5:12 AM
grimar committed rG31f2ad9c368d: [yaml2obj] - Automatically assign sh_addr for allocatable sections. (authored by grimar).
[yaml2obj] - Automatically assign sh_addr for allocatable sections.
Sat, Feb 22, 4:41 AM
grimar closed D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
Sat, Feb 22, 4:41 AM · Restricted Project
grimar added a comment to D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..

Since rL238073, clang no longer produces .shstrtab, but rather uses a unified .strtab for both section names and symbol names. Dumping SHT_STRTAB is necessary to differentiate the two cases.

Do you mean that yaml2obj generated SHT_DYNSYM is not at the normal place (early in the section header table, somewhere before .rodata)?

Sat, Feb 22, 3:35 AM · Restricted Project
grimar accepted D74971: Add a llvm::shuffle and use it in lld.

LGTM with minor nits.

Sat, Feb 22, 2:51 AM · Restricted Project

Fri, Feb 21

grimar created D74955: [obj2yaml] - Dump allocatable SHT_STRTAB, SHT_SYMTAB and SHT_DYNSYM sections..
Fri, Feb 21, 4:35 AM · Restricted Project
grimar updated the diff for D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
  • Addressed review comments.
Fri, Feb 21, 12:41 AM · Restricted Project
grimar accepted D74887: [ELF] Shuffle .init_array/.fini_array with --shuffle-sections=.

LGTM

Fri, Feb 21, 12:23 AM · Restricted Project

Thu, Feb 20

grimar accepted D74736: [ELF] Ignore the maximum of input section alignments for two cases.

LGTM

Thu, Feb 20, 11:38 PM · Restricted Project
grimar retitled D74611: [obj2yaml] - Fix indentations in the ELF output. from [obj2yaml][WIP] - Fix indentations in the ELF output. to [obj2yaml] - Fix indentations in the ELF output..
Thu, Feb 20, 7:08 AM · Restricted Project
grimar updated the diff for D74611: [obj2yaml] - Fix indentations in the ELF output..
  • Updated the algorithm used.
  • Added a much better test cases.
  • Added comments.
Thu, Feb 20, 7:08 AM · Restricted Project
grimar retitled D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections. from [yaml2obj][WIP] - Automatically assign sh_addr for allocatable sections. to [yaml2obj] - Automatically assign sh_addr for allocatable sections..
Thu, Feb 20, 2:07 AM · Restricted Project
grimar updated the diff for D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
  • Fixed test cases.
  • Disabled auto VA assign for sections in relocatable objects.
Thu, Feb 20, 2:07 AM · Restricted Project
grimar added inline comments to D74887: [ELF] Shuffle .init_array/.fini_array with --shuffle-sections=.
Thu, Feb 20, 1:23 AM · Restricted Project
grimar added inline comments to D74736: [ELF] Ignore the maximum of input section alignments for two cases.
Thu, Feb 20, 12:57 AM · Restricted Project
grimar added inline comments to rG878159038b0c: [ELF][test] Fix --symbol-ordering-file tests of shuffle_sections.s.
Thu, Feb 20, 12:48 AM
grimar added a comment to D74791: Add a --shuffle-sections=seed option to lld.

Does that sounds like a reasonable idea?

Thu, Feb 20, 12:21 AM · Restricted Project
grimar added inline comments to D74879: [llvm-objcopy][test] Improve empty section tests.
Thu, Feb 20, 12:12 AM · Restricted Project

Wed, Feb 19

grimar accepted D74741: [ELF] Warn changed output section address.

LGTM

Wed, Feb 19, 11:27 PM · Restricted Project
grimar added a comment to D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..

Now I am going to fix all test cases that are failing and remove the [WIP] status after that update.

Wed, Feb 19, 5:24 AM · Restricted Project
grimar updated the diff for D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
  • Addressed review comments.
Wed, Feb 19, 5:23 AM · Restricted Project
grimar added inline comments to D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
Wed, Feb 19, 5:23 AM · Restricted Project
grimar committed rG3439d4ee0e4c: [yaml2obj] - Change the order of implicitly created sections. (authored by grimar).
[yaml2obj] - Change the order of implicitly created sections.
Wed, Feb 19, 4:14 AM
grimar closed D74756: [yaml2obj] - Change the order of implicitly created sections..
Wed, Feb 19, 4:14 AM · Restricted Project
grimar added inline comments to D74756: [yaml2obj] - Change the order of implicitly created sections..
Wed, Feb 19, 4:04 AM · Restricted Project
grimar updated the diff for D74756: [yaml2obj] - Change the order of implicitly created sections..
  • Now with the change at the right place.
Wed, Feb 19, 3:49 AM · Restricted Project
grimar planned changes to D74756: [yaml2obj] - Change the order of implicitly created sections..

Will reupload.

Wed, Feb 19, 3:46 AM · Restricted Project
grimar added inline comments to D74756: [yaml2obj] - Change the order of implicitly created sections..
Wed, Feb 19, 3:40 AM · Restricted Project
grimar updated the diff for D74756: [yaml2obj] - Change the order of implicitly created sections..
  • Addressed review comments.
Wed, Feb 19, 3:40 AM · Restricted Project
grimar added a comment to D74791: Add a --shuffle-sections=seed option to lld.

+1 to idea about adding a seed.
Also this needs a test case. At least you can check that the option is accepted and perhaps seed
should allow to show that a layout produced is somehow different with/without this option for example.

Wed, Feb 19, 3:09 AM · Restricted Project
grimar added inline comments to D74741: [ELF] Warn changed output section address.
Wed, Feb 19, 1:36 AM · Restricted Project
grimar added a comment to D74815: [AsmPrinter] Change alignment of .stack_sizes from 1 to PointerSize.

Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
Can you explain why it is a problem?

Wed, Feb 19, 1:08 AM · Restricted Project
grimar updated subscribers of D74815: [AsmPrinter] Change alignment of .stack_sizes from 1 to PointerSize.
Wed, Feb 19, 1:08 AM · Restricted Project
grimar added a comment to D74611: [obj2yaml] - Fix indentations in the ELF output..

Does this patch handle sequence types with has_FlowTraits (llvm/Support/YAMLTraits.h) set? It is used for auto line wrapping.

Key: [value0, value1, value2,
      value3, value4,
      value5]
Wed, Feb 19, 12:31 AM · Restricted Project
grimar retitled D74756: [yaml2obj] - Change the order of implicitly created sections. from [yaml2obj] - Change the default order if implicitly created sections. to [yaml2obj] - Change the order of implicitly created sections..
Wed, Feb 19, 12:31 AM · Restricted Project
grimar added inline comments to D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file..
Wed, Feb 19, 12:04 AM · debug-info, Restricted Project

Tue, Feb 18

grimar abandoned D73045: [obj2yaml] - Better indentations in the ELF output..

I'll continue D74611 which is alternative.

Tue, Feb 18, 6:33 AM · Restricted Project
grimar abandoned D73046: [YAML] - Move yaml::Input and yaml::Ouput classes declarations..

D73045 was abandoned. Hence this one is unnecessary now.

Tue, Feb 18, 6:33 AM · Restricted Project
grimar added a comment to D74687: [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression..

Do we have a more elegant fix:) ?

Tue, Feb 18, 6:23 AM · Restricted Project
grimar created D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections..
Tue, Feb 18, 6:14 AM · Restricted Project
grimar closed D74479: [llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met..

https://reviews.llvm.org/rGb87a0f7416f1a657d808690295b44669849e7bfc

Tue, Feb 18, 4:14 AM · Restricted Project
grimar added a comment to D74611: [obj2yaml] - Fix indentations in the ELF output..

Also, should this really be restricted to ELF?

Tue, Feb 18, 3:44 AM · Restricted Project
grimar committed rGb87a0f7416f1: [llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met. (authored by grimar).
[llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met.
Tue, Feb 18, 3:37 AM
grimar added a comment to D74479: [llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met..

LLD has the code that does: "addInt(DT_SYMENT, sizeof(Elf_Sym));" and I guess other linkers has the same logic.

Confirmed. GNU ld, gold and MCLinker emit DT_SYMENT.

Tue, Feb 18, 3:35 AM · Restricted Project
grimar updated the diff for D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
  • Addressed review comments.
Tue, Feb 18, 1:01 AM · Restricted Project
grimar added inline comments to D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
Tue, Feb 18, 1:01 AM · Restricted Project
Herald added a reviewer for D74756: [yaml2obj] - Change the order of implicitly created sections.: alexshap.
Tue, Feb 18, 12:42 AM · Restricted Project

Mon, Feb 17

grimar added inline comments to D74736: [ELF] Ignore the maximum of input section alignments for two cases.
Mon, Feb 17, 11:38 PM · Restricted Project
grimar added inline comments to D74736: [ELF] Ignore the maximum of input section alignments for two cases.
Mon, Feb 17, 11:38 PM · Restricted Project

Sun, Feb 16

grimar abandoned D74405: [llvm-readobj] - Deprecate the unwrapOrError helper..
Sun, Feb 16, 11:50 PM · Restricted Project
grimar updated the diff for D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
  • Addressed review comments.
Sun, Feb 16, 4:33 AM · Restricted Project
grimar added inline comments to D74595: [llvm-readobj] - Report warnings instead of errors for broken relocations..
Sun, Feb 16, 4:33 AM · Restricted Project
grimar committed rG22ebf08006a5: [llvm-readobj] - Refactor the code that dumps relocations. (authored by grimar).
[llvm-readobj] - Refactor the code that dumps relocations.
Sun, Feb 16, 4:06 AM
grimar closed D74545: [llvm-readobj] - Refactor the code that dumps relocations..
Sun, Feb 16, 4:06 AM · Restricted Project
grimar created D74687: [LLD][ELF] - Linker script: do not fail parsing when "/DISCARD/" follows the fill expression..
Sun, Feb 16, 3:20 AM · Restricted Project

Sat, Feb 15

grimar committed rGb7c8a8e834af: [obj2yaml] - Fix a -Wsign-compare warning gived by GCC 9.2 (authored by grimar).
[obj2yaml] - Fix a -Wsign-compare warning gived by GCC 9.2
Sat, Feb 15, 7:37 AM
grimar added a comment to D74169: [WIP][LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info..
In D74169#1863848, @avl wrote:

Creating full set of patches which could be any time applied to the upstream and to the each other is quite time consuming thing because of time for synchronization/merging/rebasing.

Sat, Feb 15, 6:28 AM · debug-info, lld, Restricted Project