Page MenuHomePhabricator
Feed Advanced Search

Today

grimar updated the diff for D66418: [llvm-objdump] - Cleanup the error reporting..

Ready for review.

Tue, Aug 20, 9:15 AM
grimar planned changes to D66418: [llvm-objdump] - Cleanup the error reporting..

I'll recheck it.

Tue, Aug 20, 8:43 AM
grimar updated the diff for D66418: [llvm-objdump] - Cleanup the error reporting..
  • Cosmetic change.
Tue, Aug 20, 8:41 AM
grimar added inline comments to D66418: [llvm-objdump] - Cleanup the error reporting..
Tue, Aug 20, 8:38 AM
grimar updated the diff for D66418: [llvm-objdump] - Cleanup the error reporting..
  • Address review comments.
Tue, Aug 20, 8:38 AM
grimar added inline comments to D66476: [llvm-objcopy][test] Add a test to show that argv[0] is included in error/warning messages.
Tue, Aug 20, 8:15 AM · Restricted Project
grimar accepted D66476: [llvm-objcopy][test] Add a test to show that argv[0] is included in error/warning messages.

LGTM.

Tue, Aug 20, 7:52 AM · Restricted Project
grimar committed rGb232d5649d31: [llvm-objdump] - Remove one of `report_error` functions and improve the error… (authored by grimar).
[llvm-objdump] - Remove one of `report_error` functions and improve the error…
Tue, Aug 20, 6:23 AM
grimar committed rL369382: [llvm-objdump] - Remove one of `report_error` functions and improve the error….
[llvm-objdump] - Remove one of `report_error` functions and improve the error…
Tue, Aug 20, 6:18 AM
grimar closed D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
Tue, Aug 20, 6:18 AM · Restricted Project
grimar added inline comments to D66418: [llvm-objdump] - Cleanup the error reporting..
Tue, Aug 20, 6:05 AM
grimar added inline comments to D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
Tue, Aug 20, 5:50 AM · Restricted Project
grimar updated the diff for D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
  • Addressed review comments.
Tue, Aug 20, 5:50 AM · Restricted Project
grimar added inline comments to D66425: [llvm-readobj] Prepend argv[0] to error messages.
Tue, Aug 20, 5:40 AM · Restricted Project
grimar added inline comments to D66425: [llvm-readobj] Prepend argv[0] to error messages.
Tue, Aug 20, 5:30 AM · Restricted Project
grimar updated the diff for D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
  • Ndx->ChildIndex in 2 more missed places.
Tue, Aug 20, 5:14 AM · Restricted Project
grimar planned changes to D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
Tue, Aug 20, 5:11 AM · Restricted Project
grimar added inline comments to D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
Tue, Aug 20, 4:48 AM · Restricted Project
grimar updated the diff for D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
  • Addressed review comments.
Tue, Aug 20, 4:48 AM · Restricted Project
grimar created D66468: [llvm-objdump] - Remove one of `report_error` functions and improve the error reporting..
Tue, Aug 20, 4:28 AM · Restricted Project
grimar added inline comments to D66063: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 5].
Tue, Aug 20, 2:18 AM · Restricted Project
grimar accepted D66425: [llvm-readobj] Prepend argv[0] to error messages.

LGTM, I can confirm it works now. A minor suggestion is inlined.

Tue, Aug 20, 2:08 AM · Restricted Project
grimar added inline comments to D66418: [llvm-objdump] - Cleanup the error reporting..
Tue, Aug 20, 1:41 AM
grimar committed rGebc8fd3c0c64: [test/Object] - Move/rewrite 2 more test cases. (authored by grimar).
[test/Object] - Move/rewrite 2 more test cases.
Tue, Aug 20, 1:24 AM
grimar committed rL369342: [test/Object] - Move/rewrite 2 more test cases..
[test/Object] - Move/rewrite 2 more test cases.
Tue, Aug 20, 1:24 AM
grimar closed D66291: [test/Object] - Move/rewrite 2 more test cases..
Tue, Aug 20, 1:24 AM · Restricted Project
grimar added inline comments to D66425: [llvm-readobj] Prepend argv[0] to error messages.
Tue, Aug 20, 1:16 AM · Restricted Project
grimar added inline comments to D66425: [llvm-readobj] Prepend argv[0] to error messages.
Tue, Aug 20, 1:15 AM · Restricted Project
grimar added inline comments to D66409: [llvm-objcopy][MachO] Implement -Obinary.
Tue, Aug 20, 1:05 AM · Restricted Project

Yesterday

grimar updated the diff for D66418: [llvm-objdump] - Cleanup the error reporting..
  • Rebased on top.
Mon, Aug 19, 7:56 AM
grimar added inline comments to D66418: [llvm-objdump] - Cleanup the error reporting..
Mon, Aug 19, 7:37 AM
grimar committed rG42336682b211: [llvm-objdump] - Restore lost comment. (authored by grimar).
[llvm-objdump] - Restore lost comment.
Mon, Aug 19, 7:35 AM
grimar committed rL369265: [llvm-objdump] - Restore lost comment..
[llvm-objdump] - Restore lost comment.
Mon, Aug 19, 7:35 AM
grimar committed rG9d5e8a476ff5: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI. (authored by grimar).
[Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI.
Mon, Aug 19, 7:35 AM
grimar committed rL369263: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI..
[Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI.
Mon, Aug 19, 7:35 AM
grimar closed D66417: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI..

rL369263, rL369265

Mon, Aug 19, 7:34 AM
grimar created D66418: [llvm-objdump] - Cleanup the error reporting..
Mon, Aug 19, 7:17 AM
grimar added inline comments to D66417: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI..
Mon, Aug 19, 6:36 AM
grimar created D66417: [Object/COFF.h] - Stop returning std::error_code in a few methods. NFCI..
Mon, Aug 19, 6:21 AM
grimar added a comment to D66414: [llvm-objdump] Delete argv[0] from error messages.

I think it is fine. Lets see what others think.

Mon, Aug 19, 5:44 AM · Restricted Project

Sat, Aug 17

grimar committed rGe3fb2d549b68: Recommit r369190 "[llvm-readobj/llvm-readelf] - Improve/cleanup the error… (authored by grimar).
Recommit r369190 "[llvm-readobj/llvm-readelf] - Improve/cleanup the error…
Sat, Aug 17, 9:11 AM
grimar committed rL369194: Recommit r369190 "[llvm-readobj/llvm-readelf] - Improve/cleanup the error….
Recommit r369190 "[llvm-readobj/llvm-readelf] - Improve/cleanup the error…
Sat, Aug 17, 9:07 AM
grimar committed rGc35d4c900d20: Revert r369190, r369192 ([llvm-readobj/llvm-readelf] - Improve/cleanup the… (authored by grimar).
Revert r369190, r369192 ([llvm-readobj/llvm-readelf] - Improve/cleanup the…
Sat, Aug 17, 8:37 AM
grimar committed rL369193: Revert r369190, r369192 ([llvm-readobj/llvm-readelf] - Improve/cleanup the….
Revert r369190, r369192 ([llvm-readobj/llvm-readelf] - Improve/cleanup the…
Sat, Aug 17, 8:37 AM
grimar committed rGe9f28133a9fb: [llvm-readobj] - An attemp to fix BB after r369191. (authored by grimar).
[llvm-readobj] - An attemp to fix BB after r369191.
Sat, Aug 17, 8:25 AM
grimar committed rL369192: [llvm-readobj] - An attemp to fix BB after r369191..
[llvm-readobj] - An attemp to fix BB after r369191.
Sat, Aug 17, 8:25 AM
grimar committed rGbb56755f153a: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API. (authored by grimar).
[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.
Sat, Aug 17, 7:39 AM
grimar committed rL369190: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
[llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API.
Sat, Aug 17, 7:35 AM
grimar closed D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Sat, Aug 17, 7:35 AM · Restricted Project
grimar committed rG50166f81072c: [test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects. (authored by grimar).
[test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects.
Sat, Aug 17, 7:24 AM
grimar committed rL369189: [test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects..
[test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects.
Sat, Aug 17, 7:24 AM
grimar closed D66342: [test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects..
Sat, Aug 17, 7:24 AM · Restricted Project
grimar added a comment to D66346: [LLD][ELF][ARM] Add a test that maxes out the thunk convergence limit.

Looks good. 2 questions are inline.

Sat, Aug 17, 2:25 AM · Restricted Project

Fri, Aug 16

grimar updated the diff for D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
  • Addressed review comment.
Fri, Aug 16, 5:22 AM · Restricted Project
grimar created D66342: [test] - Remove precomiled openbsd-phdrs.elf-x86-64 objects..
Fri, Aug 16, 5:20 AM · Restricted Project
grimar added inline comments to D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Fri, Aug 16, 3:28 AM · Restricted Project
grimar updated the diff for D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
  • Addressed review comments.
Fri, Aug 16, 3:28 AM · Restricted Project
grimar updated the diff for D66291: [test/Object] - Move/rewrite 2 more test cases..
  • Addressed review comments.
Fri, Aug 16, 1:53 AM · Restricted Project
grimar added inline comments to D66291: [test/Object] - Move/rewrite 2 more test cases..
Fri, Aug 16, 1:53 AM · Restricted Project

Thu, Aug 15

grimar committed rG4b91e3f9aa2f: [lib/Object] - Remove objdump-file-header.test (authored by grimar).
[lib/Object] - Remove objdump-file-header.test
Thu, Aug 15, 6:40 AM
grimar committed rL369004: [lib/Object] - Remove objdump-file-header.test.
[lib/Object] - Remove objdump-file-header.test
Thu, Aug 15, 6:40 AM
grimar closed D66288: [lib/Object] - Remove objdump-file-header.test.
Thu, Aug 15, 6:40 AM · Restricted Project
grimar created D66291: [test/Object] - Move/rewrite 2 more test cases..
Thu, Aug 15, 6:28 AM · Restricted Project
grimar created D66288: [lib/Object] - Remove objdump-file-header.test.
Thu, Aug 15, 5:04 AM · Restricted Project
grimar created D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Thu, Aug 15, 4:14 AM · Restricted Project
grimar accepted D66277: [ELF][AArch64] Improve error message for unknown relocations.

LGTM. 2 nits are below.

Thu, Aug 15, 2:52 AM · Restricted Project
grimar added a comment to D66277: [ELF][AArch64] Improve error message for unknown relocations.

How about adding a test case? See test\ELF\invalid\invalid-relocation-x64.test for example.

Thu, Aug 15, 1:14 AM · Restricted Project

Wed, Aug 14

grimar committed rGbcc00e1afbdc: Recommit r368812 "[llvm/Object] - Convert SectionRef::getName() to return… (authored by grimar).
Recommit r368812 "[llvm/Object] - Convert SectionRef::getName() to return…
Wed, Aug 14, 4:11 AM
grimar committed rGa11d302fa00b: [clang] - An update after LLVM change. (authored by grimar).
[clang] - An update after LLVM change.
Wed, Aug 14, 4:10 AM
grimar committed rL368826: Recommit r368812 "[llvm/Object] - Convert SectionRef::getName() to return….
Recommit r368812 "[llvm/Object] - Convert SectionRef::getName() to return…
Wed, Aug 14, 4:09 AM
grimar committed rL368825: [clang] - An update after LLVM change..
[clang] - An update after LLVM change.
Wed, Aug 14, 4:09 AM
grimar added a comment to D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.

Sorry, but this patch broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16455), I reverted it. Please run check-all before re-committing.

Wed, Aug 14, 2:09 AM · Restricted Project
grimar committed rG468919e18231: Revert r368812 "[llvm/Object] - Convert SectionRef::getName() to return… (authored by grimar).
Revert r368812 "[llvm/Object] - Convert SectionRef::getName() to return…
Wed, Aug 14, 2:01 AM
grimar committed rL368813: Revert r368812 "[llvm/Object] - Convert SectionRef::getName() to return….
Revert r368812 "[llvm/Object] - Convert SectionRef::getName() to return…
Wed, Aug 14, 1:56 AM
grimar committed rGa0c6a3571422: [llvm/Object] - Convert SectionRef::getName() to return Expected<> (authored by grimar).
[llvm/Object] - Convert SectionRef::getName() to return Expected<>
Wed, Aug 14, 1:47 AM
grimar committed rL368812: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
[llvm/Object] - Convert SectionRef::getName() to return Expected<>
Wed, Aug 14, 1:46 AM
grimar closed D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
Wed, Aug 14, 1:46 AM · Restricted Project
grimar committed rGd4a99d87a20d: [llvm-objdump] - Add a relocation-xindex-symbol.test test case. (authored by grimar).
[llvm-objdump] - Add a relocation-xindex-symbol.test test case.
Wed, Aug 14, 1:34 AM
grimar committed rL368811: [llvm-objdump] - Add a relocation-xindex-symbol.test test case..
[llvm-objdump] - Add a relocation-xindex-symbol.test test case.
Wed, Aug 14, 1:33 AM
grimar closed D66140: [llvm-objdump] - Add a relocation-xindex-symbol.test test case..
Wed, Aug 14, 1:33 AM · Restricted Project
grimar accepted D66134: [llvm-size][test] Improve llvm-size testing.

This LGTM.

Wed, Aug 14, 12:38 AM · Restricted Project

Tue, Aug 13

grimar created D66140: [llvm-objdump] - Add a relocation-xindex-symbol.test test case..
Tue, Aug 13, 6:10 AM · Restricted Project
grimar added inline comments to D66134: [llvm-size][test] Improve llvm-size testing.
Tue, Aug 13, 5:53 AM · Restricted Project
grimar committed rG36f23182bc31: [llvm-readobj] - Remove 'error(Error EC)' helper. (authored by grimar).
[llvm-readobj] - Remove 'error(Error EC)' helper.
Tue, Aug 13, 5:09 AM
grimar committed rL368677: [llvm-readobj] - Remove 'error(Error EC)' helper..
[llvm-readobj] - Remove 'error(Error EC)' helper.
Tue, Aug 13, 5:09 AM
grimar closed D66011: [llvm-readobj] - Remove 'error(Error EC)' helper..
Tue, Aug 13, 5:08 AM · Restricted Project
grimar added inline comments to D66134: [llvm-size][test] Improve llvm-size testing.
Tue, Aug 13, 4:37 AM · Restricted Project
grimar added inline comments to D66011: [llvm-readobj] - Remove 'error(Error EC)' helper..
Tue, Aug 13, 4:06 AM · Restricted Project
grimar added inline comments to D66011: [llvm-readobj] - Remove 'error(Error EC)' helper..
Tue, Aug 13, 4:06 AM · Restricted Project
grimar added inline comments to D66011: [llvm-readobj] - Remove 'error(Error EC)' helper..
Tue, Aug 13, 3:42 AM · Restricted Project
grimar updated the diff for D66011: [llvm-readobj] - Remove 'error(Error EC)' helper..
  • Updated in according to the discussion.
Tue, Aug 13, 3:42 AM · Restricted Project
grimar accepted D66130: [ELF] Initialize 2 fields of Symbol in SymbolTable::insert.

LGTM. Please wait for other reviewer(s) opinion about comments (I'd remove them).

Tue, Aug 13, 2:41 AM · Restricted Project
grimar accepted D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.

LGTM. Please wait for other opinion(s) too.

Tue, Aug 13, 2:13 AM · Restricted Project
grimar added inline comments to D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
Tue, Aug 13, 1:45 AM · Restricted Project
grimar updated the diff for D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
  • Addressed review comments.
Tue, Aug 13, 1:45 AM · Restricted Project

Mon, Aug 12

grimar created D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
Mon, Aug 12, 7:10 AM · Restricted Project
grimar accepted D66015: [llvm-strings] Improve testing of llvm-strings.

LGTM.

Mon, Aug 12, 3:49 AM · Restricted Project
grimar added inline comments to D66015: [llvm-strings] Improve testing of llvm-strings.
Mon, Aug 12, 3:22 AM · Restricted Project
grimar accepted D66036: [llvm-readobj] Downgrade 'PT_DYNAMIC segment offset + size exceeds the size of the file' from an error to a warning.

LGTM.

Mon, Aug 12, 1:03 AM · Restricted Project

Sat, Aug 10

grimar added inline comments to D66015: [llvm-strings] Improve testing of llvm-strings.
Sat, Aug 10, 5:44 AM · Restricted Project