Page MenuHomePhabricator
Feed Advanced Search

Mar 24 2021

stefanp committed rG0e4f5f3ea6e1: [PowerPC] Change option to mrop-protect (authored by stefanp).
[PowerPC] Change option to mrop-protect
Mar 24 2021, 3:52 AM
stefanp closed D99185: [PowerPC] Change option to mrop-protect.
Mar 24 2021, 3:52 AM · Restricted Project, Restricted Project

Mar 23 2021

stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Ping.
I would like to restart the discussion on this patch.
I understand that the design of this fix is not ideal however I'm not sure of a better solution to this.
Adding the GOT to all linked binaries seems like too much. However, using hasGotOffRel isn't going to cover all of the test cases as it will not be set in all of the cases. The code needs to add a first symbol to the GOT in all cases where we use a GOT but we don't want to add a GOT if nothing else goes into it.

Mar 23 2021, 1:31 PM · Restricted Project
stefanp added reviewers for D99193: [PowerPC] Add mprivileged option: amyk, Restricted Project.
Mar 23 2021, 10:54 AM · Restricted Project, Restricted Project
stefanp requested review of D99193: [PowerPC] Add mprivileged option.
Mar 23 2021, 8:44 AM · Restricted Project, Restricted Project
stefanp added reviewers for D99185: [PowerPC] Change option to mrop-protect: lei, amyk, Restricted Project.
Mar 23 2021, 6:44 AM · Restricted Project, Restricted Project
stefanp requested review of D99185: [PowerPC] Change option to mrop-protect.
Mar 23 2021, 6:41 AM · Restricted Project, Restricted Project

Mar 22 2021

stefanp committed rGf21704e080a0: [LLD][PowerPC] Fix bug in PC-Relative initial exec (authored by stefanp).
[LLD][PowerPC] Fix bug in PC-Relative initial exec
Mar 22 2021, 11:16 AM
stefanp closed D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Mar 22 2021, 11:16 AM · Restricted Project
stefanp updated the diff for D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.

Thank you for the review!

Mar 22 2021, 11:07 AM · Restricted Project
stefanp committed rGb8f3c6d0110f: [PowerPC][NFC] Do not enter prefix selection if it cannot do better. (authored by stefanp).
[PowerPC][NFC] Do not enter prefix selection if it cannot do better.
Mar 22 2021, 7:18 AM
stefanp closed D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better..
Mar 22 2021, 7:18 AM · Restricted Project
stefanp added inline comments to D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better..
Mar 22 2021, 7:15 AM · Restricted Project
stefanp updated the diff for D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better..

Updated comment.

Mar 22 2021, 7:13 AM · Restricted Project

Mar 17 2021

stefanp added reviewers for D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better.: lei, Restricted Project.
Mar 17 2021, 9:41 AM · Restricted Project
stefanp requested review of D98791: [PowerPC][NFC] Do not enter prefix selection if it cannot do better..
Mar 17 2021, 9:40 AM · Restricted Project

Mar 16 2021

stefanp added a comment to D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.

I think I may have misunderstood your initial comment.
I don't think that the ABI has an issue with the code pattern:

pld 3, <Immediate Value>(0), 1
add 4, 3, 13

The ABI does not explicitly state that those registers must be equal. It also does not say explicitly that they can differ so I don't think there is a clear direction from that perspective. Logically it would make sense for those registers to be able to differ if they are used in multiple places or if they must be used across function calls (as in the example I added).
Linking the object files generated by LLVM with ld produces the correct result with the mr and not the nop. Therefore it seems that ld expects to have to handle this kind of code. While this situation will not arise very often I believe that this is something LLD should be able to handle.

Mar 16 2021, 12:03 PM · Restricted Project
stefanp updated the diff for D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.

Added full test case that was compiled from C source to show the issue.

Mar 16 2021, 11:51 AM · Restricted Project

Mar 15 2021

stefanp committed rG86f2a3d17878: [PowerPC] Add __PCREL__ when PC Relative is enabled. (authored by stefanp).
[PowerPC] Add __PCREL__ when PC Relative is enabled.
Mar 15 2021, 1:13 PM
stefanp closed D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled..
Mar 15 2021, 1:13 PM · Restricted Project

Mar 12 2021

stefanp updated the summary of D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled..
Mar 12 2021, 12:07 PM · Restricted Project
stefanp requested review of D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled..
Mar 12 2021, 12:04 PM · Restricted Project
stefanp accepted D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.

Thank you for adding this!
Other than one minor nit I think this LGTM.

Mar 12 2021, 4:24 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

stefanp committed rGe021de0aab22: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization (authored by stefanp).
[PowerPC] Exploit paddi instruction on Power 10 for constant materialization
Mar 11 2021, 6:38 AM
stefanp closed D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.
Mar 11 2021, 6:38 AM · Restricted Project
stefanp updated the diff for D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Rebased patch to prepare for commit.

Mar 11 2021, 3:47 AM · Restricted Project

Mar 1 2021

stefanp accepted D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.

LGTM.

Mar 1 2021, 12:10 PM · Restricted Project
stefanp added a comment to D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.

Comments relate to just cleaning up the patch a little.

Mar 1 2021, 7:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2021

stefanp updated the summary of D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Feb 22 2021, 5:00 AM · Restricted Project
stefanp updated the summary of D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Feb 22 2021, 4:57 AM · Restricted Project
stefanp added a comment to D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.

I'm sorry, I should have added the full test case.

Feb 22 2021, 4:55 AM · Restricted Project

Feb 18 2021

stefanp updated the diff for D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Fixed spelling mistake.

Feb 18 2021, 11:51 AM · Restricted Project
stefanp committed rGb80357d46e22: [PowerPC] Add option for ROP Protection (authored by stefanp).
[PowerPC] Add option for ROP Protection
Feb 18 2021, 4:22 AM
stefanp closed D96512: [PowerPC] Add option for ROP Protection.
Feb 18 2021, 4:21 AM · Restricted Project, Restricted Project

Feb 17 2021

stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?

Feb 17 2021, 1:42 PM · Restricted Project
stefanp updated the diff for D96512: [PowerPC] Add option for ROP Protection.

Added missing FeatureROPProtection to P8AdditionalFeatures.

Feb 17 2021, 1:15 PM · Restricted Project, Restricted Project
stefanp accepted D94454: [PowerPC] Exploit the vinsw, vinsd, and vins[wd][lr]x instructions on P10.

I gave this patch a try and I can't see any concerns with it.
LGTM.

Feb 17 2021, 8:37 AM · Restricted Project, Restricted Project

Feb 16 2021

stefanp requested changes to D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars.
Feb 16 2021, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
stefanp added a comment to D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.

Gentle ping.

Feb 16 2021, 4:47 AM · Restricted Project
stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Gentle ping.

Feb 16 2021, 4:46 AM · Restricted Project
stefanp added a comment to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Gentle ping.

Feb 16 2021, 4:46 AM · Restricted Project
stefanp accepted D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

I just have one final nit otherwise LGTM. Feel free to fix that on commit.
Please wait a couple of days and see if @MaskRay has any further comments.

Feb 16 2021, 3:52 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2021

stefanp added reviewers for D96512: [PowerPC] Add option for ROP Protection: NeHuang, bsaleil, amyk, saghir, Restricted Project.
Feb 11 2021, 7:50 AM · Restricted Project, Restricted Project
stefanp requested review of D96512: [PowerPC] Add option for ROP Protection.
Feb 11 2021, 7:49 AM · Restricted Project, Restricted Project

Feb 4 2021

stefanp added a comment to D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

Just nits this time around.

Feb 4 2021, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Sorry, I missed your early comments.

Which test can demonstrate the bug? My idea is that instead of creating setupPPCDelayedInit, we should let in.got->hasGotOffRel to convey that .got is needed.
See Relocations.cpp:1397

Feb 4 2021, 4:41 AM · Restricted Project

Feb 3 2021

stefanp updated the diff for D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.

Rebased the patch to the top of main.

Feb 3 2021, 12:17 PM · Restricted Project
stefanp added inline comments to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.
Feb 3 2021, 12:05 PM · Restricted Project
stefanp added inline comments to D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.
Feb 3 2021, 4:30 AM · Restricted Project
stefanp abandoned D39860: [PowerPC] Simplify a Swap if it feeds a Splat.

This feature has already been covered by https://reviews.llvm.org/D77448
I am going to abandon this review.

Feb 3 2021, 3:55 AM

Feb 2 2021

stefanp committed rG288f762b6ff2: [PowerPC] Materialize 34 bit constants with pli on Power 10. (authored by stefanp).
[PowerPC] Materialize 34 bit constants with pli on Power 10.
Feb 2 2021, 7:50 AM
stefanp closed D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..
Feb 2 2021, 7:50 AM · Restricted Project
stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Adjusted test cast that I forgot to fix on rebase.

Feb 2 2021, 5:19 AM · Restricted Project
stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Rebased to top of main branch.

Feb 2 2021, 4:05 AM · Restricted Project

Feb 1 2021

stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

I'm sorry @MaskRay I don't want to keep bugging you but I really don't understand what you meant by your comment with respect to GotPltSection::hasGotPltOffset.

Feb 1 2021, 12:39 PM · Restricted Project
stefanp updated the diff for D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Updated incorrect comment in test case.

Feb 1 2021, 12:37 PM · Restricted Project
stefanp added inline comments to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..
Feb 1 2021, 12:31 PM · Restricted Project
stefanp added inline comments to D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Feb 1 2021, 12:13 PM · Restricted Project
stefanp added a comment to D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

There is one more thing that does not look quite right. It may be an encoding problem for one of the instructions. I found it in the test but you will have to trace it back to the place where it is generated in order to fix it.

Feb 1 2021, 10:08 AM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2021

stefanp added a comment to D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs.

I have a few comments. Most of them are nits but there is a functional issue as well.

Jan 27 2021, 4:37 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2021

stefanp added inline comments to D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Jan 25 2021, 4:44 AM · Restricted Project

Jan 22 2021

stefanp requested review of D95262: [LLD][PowerPC] Fix bug in PC-Relative initial exec.
Jan 22 2021, 12:56 PM · Restricted Project

Jan 7 2021

stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Fixed spelling mistake in comment.

Jan 7 2021, 4:06 AM · Restricted Project

Jan 6 2021

stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Updated some of the test cases for the 32 bit compilation.

Jan 6 2021, 11:49 AM · Restricted Project
stefanp committed rGcb0c034edc98: [PowerPC] Fix issue where vsrq is given incorrect shift vector (authored by stefanp).
[PowerPC] Fix issue where vsrq is given incorrect shift vector
Jan 6 2021, 3:56 AM
stefanp closed D94113: [PowerPC] Fix issue where vsrq is given incorrect shift vector.
Jan 6 2021, 3:56 AM · Restricted Project
stefanp updated the diff for D94113: [PowerPC] Fix issue where vsrq is given incorrect shift vector.

Added the todo comment in the TD file.

Jan 6 2021, 3:28 AM · Restricted Project

Jan 5 2021

stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Added comment for function.
Fixed variable name.
Added test case for 32 bit target.

Jan 5 2021, 1:47 PM · Restricted Project
stefanp abandoned D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.

Since D92959 is now in I am going to abandon this patch.

Jan 5 2021, 1:05 PM · Restricted Project
stefanp updated the diff for D94113: [PowerPC] Fix issue where vsrq is given incorrect shift vector.

Forgot to delete the old lines in the TD file.

Jan 5 2021, 1:00 PM · Restricted Project
stefanp added a reviewer for D94113: [PowerPC] Fix issue where vsrq is given incorrect shift vector: Restricted Project.
Jan 5 2021, 12:58 PM · Restricted Project
stefanp requested review of D94113: [PowerPC] Fix issue where vsrq is given incorrect shift vector.
Jan 5 2021, 12:55 PM · Restricted Project

Dec 17 2020

stefanp accepted D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

I do not have any more questions.
Thank you for refactoring this. It looks a lot cleaner.
LGTM.

Dec 17 2020, 9:59 AM · Restricted Project
stefanp added a comment to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..

I just had some minor comments. I think it makes sense overall.

Dec 17 2020, 8:03 AM · Restricted Project, Restricted Project
stefanp accepted D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.

Tested this on some actual legacy compiled code and it does what we want.
Only one minor question. Otherwise, LGTM.

Dec 17 2020, 3:47 AM · Restricted Project

Dec 15 2020

stefanp added reviewers for D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization: NeHuang, Restricted Project.
Dec 15 2020, 7:36 AM · Restricted Project
stefanp requested review of D93300: [PowerPC] Exploit paddi instruction on Power 10 for constant materialization.
Dec 15 2020, 7:33 AM · Restricted Project

Dec 14 2020

stefanp added a comment to D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.

Missing R_PPC64_TLSGD/R_PPC64_TLSGD for one function and correct for another in the same translation unit - does this only happen with relocatable links? I'd hope we simply consider this too niche to fix and don't add more logic on this...

Dec 14 2020, 1:53 PM · Restricted Project

Dec 11 2020

stefanp added a comment to D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.

Thank you for your help!

It make sense what you have written but I would still prefer to explicitly check for calls to __tls_get_addr and look at the relocations on the call.

How would you like to proceed from here? Do you want me to take the patch over and make changes?

This patch is essentially a rewrite.
If this patch looks fine, I'd like if we take this route instead....

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=727fc41e077139570ea8b8ddfd6c546b2a55627c introduced the R_PPC64_TLSGD/R_PPC64_TLSLD behavior in 2009 so assumably the problem existed before 2009. It made feel pretty uneasy that you are needing the pre-2009 workaround....

I am not sure checking "__tls_get_addr" is useful. R_PPC64_TLSGD/R_PPC64_TLSLD is only used by "__tls_get_addr". GD/LD GOT relocations are not used otherwise, are they?
So a simple check like this patch should work. We don't necessarily bring all the complexity from GNU ld.

I don't want to implement a complete fix of this. I am completely happy with just detecting the issue and disabling the relaxation if we find it.
However, if we have a scenario like this one:

Right:
  addis 3, 2, x@got@tlsgd@ha
  addi 3, 3, x@got@tlsgd@l
  bl __tls_get_addr(x@tlsgd)
  nop
  blr

Wrong:
  addis 3, 2, x@got@tlsgd@ha
  addi 3, 3, x@got@tlsgd@l
  bl __tls_get_addr
  nop
  blr

the function Wrong won't be caught by the code that you posted. We basically have two functions, one was compiled correctly and the other was not.

In the code that you have what if you just look for R_PPC64_REL24 and check those relocations for __tls_get_addr? I know that this adds more overhead but it helps with the backwards compatibility and I feel that is important. Also, if it adds too much overhead we can keep the option and that way we only do this extra check if the user asks for it.

Dec 11 2020, 1:39 PM · Restricted Project
stefanp added a comment to D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.

Thank you for your help!

It make sense what you have written but I would still prefer to explicitly check for calls to __tls_get_addr and look at the relocations on the call.

How would you like to proceed from here? Do you want me to take the patch over and make changes?

This patch is essentially a rewrite.
If this patch looks fine, I'd like if we take this route instead....

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=727fc41e077139570ea8b8ddfd6c546b2a55627c introduced the R_PPC64_TLSGD/R_PPC64_TLSLD behavior in 2009 so assumably the problem existed before 2009. It made feel pretty uneasy that you are needing the pre-2009 workaround....

I am not sure checking "__tls_get_addr" is useful. R_PPC64_TLSGD/R_PPC64_TLSLD is only used by "__tls_get_addr". GD/LD GOT relocations are not used otherwise, are they?
So a simple check like this patch should work. We don't necessarily bring all the complexity from GNU ld.

Dec 11 2020, 1:04 PM · Restricted Project
stefanp added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 11 2020, 7:56 AM · Restricted Project

Dec 10 2020

stefanp added a comment to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

Thank you for the explanations!
I'm fine with keeping the if conditions looking similar and avoiding too many test changes.

Dec 10 2020, 1:42 PM · Restricted Project
stefanp added a comment to D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation.

Thank you for your help!

Dec 10 2020, 1:33 PM · Restricted Project
stefanp added a comment to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.

I think the code should be extracted to scanRelocs: check whether there are R_TLSGD_GOT relocations without R_PPC64_TLSGD/R_PPC64_TLSLD. This may be an entire rewrite. I'm working on it.

I think I understand what you are looking for. It's my patch so I should probably be doing the rewrite myself.
I don't want you to spend more time than you have to on this...

... but do you think D92959 is complete now?

Dec 10 2020, 1:16 PM · Restricted Project
stefanp added a comment to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.

I think the code should be extracted to scanRelocs: check whether there are R_TLSGD_GOT relocations without R_PPC64_TLSGD/R_PPC64_TLSLD. This may be an entire rewrite. I'm working on it.

Dec 10 2020, 9:36 AM · Restricted Project
stefanp updated the diff for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..

Rebased on top of D92089

Dec 10 2020, 4:00 AM · Restricted Project

Dec 9 2020

stefanp added a comment to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..

Thank you for pointing me to this patch.

Dec 9 2020, 7:23 PM · Restricted Project
stefanp added a comment to D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..
Dec 9 2020, 7:40 AM · Restricted Project
stefanp updated the diff for D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.

Merged if statement and did a bit of cleanup according to comments.
Merged two test cases.

Dec 9 2020, 7:13 AM · Restricted Project

Dec 8 2020

stefanp added a reviewer for D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10.: Restricted Project.
Dec 8 2020, 12:51 PM · Restricted Project
stefanp requested review of D92879: [PowerPC] Materialize 34 bit constants with pli on Power 10..
Dec 8 2020, 12:50 PM · Restricted Project
stefanp committed rG2812c1515627: [PowerPC] Fix missing nop after call to weak callee. (authored by stefanp).
[PowerPC] Fix missing nop after call to weak callee.
Dec 8 2020, 7:39 AM
stefanp closed D91983: [PowerPC] Fix missing nop after call to weak callee..
Dec 8 2020, 7:39 AM · Restricted Project
stefanp added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

@MaskRay
I'm sorry to bug you but I still don't understand what you are looking for.

Dec 8 2020, 6:54 AM · Restricted Project
stefanp added a comment to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.

Gentle Ping

Dec 8 2020, 6:49 AM · Restricted Project

Dec 7 2020

stefanp updated the diff for D91983: [PowerPC] Fix missing nop after call to weak callee..

Added CHECK-NEXT that was missed.

Dec 7 2020, 11:36 AM · Restricted Project
stefanp committed rG49921d1c3cee: [PowerPC] Exploitation of xxeval instruction for AND and NAND (authored by stefanp).
[PowerPC] Exploitation of xxeval instruction for AND and NAND
Dec 7 2020, 10:37 AM
stefanp closed D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.
Dec 7 2020, 10:37 AM · Restricted Project
stefanp added inline comments to D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.
Dec 7 2020, 6:42 AM · Restricted Project

Dec 4 2020

stefanp updated the diff for D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.

Changed the multiclass into class.

Dec 4 2020, 1:41 PM · Restricted Project