Page MenuHomePhabricator
Feed Advanced Search

Thu, May 21

lhames committed rG2e40cf06df0c: [JITLink] Initial implementation of ELF / x86-64 support for JITLink. (authored by lhames).
[JITLink] Initial implementation of ELF / x86-64 support for JITLink.
Thu, May 21, 10:11 PM
lhames closed D79832: Initial commit for the elf x86 implementation for jitlink .
Thu, May 21, 10:11 PM · Restricted Project

Sat, May 16

lhames accepted D79832: Initial commit for the elf x86 implementation for jitlink .

Ok. This looks good to me!

Sat, May 16, 9:12 PM · Restricted Project

Thu, May 14

lhames added a comment to D79832: Initial commit for the elf x86 implementation for jitlink .

Just got a chance to look at the build messages for this. There are a few warnings (noted inline). I also noticed that this patch is against 2e42cc7a50e which is from late January. I don't think the JITLink APIs have changed too much: if you're happy to rebase against top of tree then go for it, otherwise I'm happy to do that before committing.

Thu, May 14, 8:39 PM · Restricted Project

Wed, May 13

lhames added a comment to D79832: Initial commit for the elf x86 implementation for jitlink .

This is great stuff -- thanks Jared!

Wed, May 13, 9:47 PM · Restricted Project

Tue, May 12

lhames updated the diff for D79312: [ORC] Preliminary support for removable code..

Update for changes in 41379f1ec46.

Tue, May 12, 4:09 PM · Restricted Project

Sun, May 10

lhames committed rG689486dc2a8a: [examples] Fix the SpeculativeJIT and ThinLtoJIT examples for 41379f1ec46. (authored by lhames).
[examples] Fix the SpeculativeJIT and ThinLtoJIT examples for 41379f1ec46.
Sun, May 10, 5:37 PM
lhames committed rG41379f1ec465: [ORC] Share ownership of JITDylibs between ExecutionSession and… (authored by lhames).
[ORC] Share ownership of JITDylibs between ExecutionSession and…
Sun, May 10, 5:01 PM

Sat, May 9

lhames created D79685: [Support] Use unique_function for ThreadPool..
Sat, May 9, 10:20 PM · Restricted Project

Mon, May 4

lhames committed rGc66f89005f6d: [ORC] Rename SearchOrder operations on JITDylib to LinkOrder. (authored by lhames).
[ORC] Rename SearchOrder operations on JITDylib to LinkOrder.
Mon, May 4, 5:14 PM
lhames committed rG990eb9446755: [JITLink] Fix missing ADDITIONAL_HEADER_DIRS for the LLVMJITLink component. (authored by lhames).
[JITLink] Fix missing ADDITIONAL_HEADER_DIRS for the LLVMJITLink component.
Mon, May 4, 1:27 PM
lhames committed rG7ac0c3b47516: [JITLink] Fix a typo in a comment. (authored by lhames).
[JITLink] Fix a typo in a comment.
Mon, May 4, 1:27 PM
lhames created D79312: [ORC] Preliminary support for removable code..
Mon, May 4, 12:29 AM · Restricted Project

Fri, May 1

lhames committed rGdbc601e25b6d: [examples] Fix an incomplete comment. (authored by lhames).
[examples] Fix an incomplete comment.
Fri, May 1, 5:26 PM
lhames committed rG30b28766d62d: [examples] Call setProcessAllSections to ensure debug sections aren't droppped. (authored by lhames).
[examples] Call setProcessAllSections to ensure debug sections aren't droppped.
Fri, May 1, 5:25 PM

Tue, Apr 28

lhames accepted D78813: [AIX] Skip unsupported ORC JIT RemoteObjectLayerTest on AIX.

LGTM. RemoteObjectLayer is deprecated and will be removed soon, so anything that makes the builders happy is fine by me.

Tue, Apr 28, 10:11 AM · Restricted Project

Mon, Apr 27

lhames committed rG7113a9a65445: [JITLink] Fix endianness bug fedd32e2fa36. (authored by lhames).
[JITLink] Fix endianness bug fedd32e2fa36.
Mon, Apr 27, 10:45 AM
lhames added a comment to rGfedd32e2fa36: [JITLink] Read MachO Header CPU field only in jitLink_MachO..

Hi Anirudh,

Mon, Apr 27, 10:44 AM

Apr 22 2020

lhames committed rG3ceea67c091d: [JITLink] Fix edge removal iterator invalidation. (authored by lhames).
[JITLink] Fix edge removal iterator invalidation.
Apr 22 2020, 2:42 PM
lhames committed rGfedd32e2fa36: [JITLink] Read MachO Header CPU field only in jitLink_MachO. (authored by lhames).
[JITLink] Read MachO Header CPU field only in jitLink_MachO.
Apr 22 2020, 2:42 PM

Apr 21 2020

lhames accepted D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries.

This looks good to me. Unless anyone else has any other feedback I think this should go in, minus the whole-file reformatting.

Apr 21 2020, 12:26 PM · Restricted Project

Apr 20 2020

lhames added a comment to D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries.

I would prefer to keep this change in the tool for now (as this patch does).

Apr 20 2020, 3:12 PM · Restricted Project

Apr 18 2020

lhames committed rGa7a03d647f19: [ORC] Add example showing how to initialize/deinitialize a JITDylib with LLJIT. (authored by lhames).
[ORC] Add example showing how to initialize/deinitialize a JITDylib with LLJIT.
Apr 18 2020, 3:38 PM
lhames committed rGc6ade39ba083: [ORC] Replace LLJIT::defineAbsolute with an LLJIT::define convenience method. (authored by lhames).
[ORC] Replace LLJIT::defineAbsolute with an LLJIT::define convenience method.
Apr 18 2020, 3:38 PM
lhames committed rG702b3f01ddb8: [ORC] Add a convenience method to create a JITEvaluatedSymbol from a pointer. (authored by lhames).
[ORC] Add a convenience method to create a JITEvaluatedSymbol from a pointer.
Apr 18 2020, 3:38 PM

Apr 16 2020

lhames committed rGa6f19762c6d9: [llvm-objcopy][MachO] Correctly identify object file endianness. (authored by lhames).
[llvm-objcopy][MachO] Correctly identify object file endianness.
Apr 16 2020, 10:10 PM
lhames committed rGcc0ec3fdb9d1: [llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5. (authored by lhames).
[llvm-objcopy][MachO] Fix MachO::relocation_info use after 386f1c114d5.
Apr 16 2020, 6:57 PM
lhames committed rG386f1c114d59: [Object] Remove conditional layout of bitfields in MachO::relocation_info. (authored by lhames).
[Object] Remove conditional layout of bitfields in MachO::relocation_info.
Apr 16 2020, 4:44 PM
lhames added inline comments to D77844: [ObjectYAML][MachO] Add support for relocations.
Apr 16 2020, 4:43 PM · Restricted Project
lhames added inline comments to D77844: [ObjectYAML][MachO] Add support for relocations.
Apr 16 2020, 11:08 AM · Restricted Project

Apr 15 2020

lhames committed rGa9ade27a5721: [docs] Fix an RST error introduced in e823068306e. (authored by lhames).
[docs] Fix an RST error introduced in e823068306e.
Apr 15 2020, 2:56 PM

Apr 13 2020

lhames added inline comments to D39111: Extensible LLVM RTTI.
Apr 13 2020, 2:07 PM · Restricted Project
lhames committed rG255cc202ea61: [Support] Add missing files from e823068306e. (authored by lhames).
[Support] Add missing files from e823068306e.
Apr 13 2020, 1:38 PM
lhames committed rG840a23b0b5c7: [ORC] Update ORCv2 docs to reflect removal of ExecutionSession::getMainJITDylib. (authored by lhames).
[ORC] Update ORCv2 docs to reflect removal of ExecutionSession::getMainJITDylib.
Apr 13 2020, 1:02 PM
lhames committed rGe823068306e9: [Support] Add support RTTI support for open class hierarchies. (authored by lhames).
[Support] Add support RTTI support for open class hierarchies.
Apr 13 2020, 1:02 PM
lhames closed D39111: Extensible LLVM RTTI.
Apr 13 2020, 1:01 PM · Restricted Project

Apr 10 2020

lhames accepted D76259: Use more LLVM_ENABLE_ABI_BREAKING_CHECKS in Error.h.

LGTM. Thanks Aaron!

Apr 10 2020, 4:41 PM · Restricted Project
lhames committed rG59ed45b4835f: [ORC] Add an OrcV2 C API function for configuring TargetMachines. (authored by lhames).
[ORC] Add an OrcV2 C API function for configuring TargetMachines.
Apr 10 2020, 4:10 PM
lhames committed rG92210cb26fb7: [ORC] Use CodeGenOpt::Default as the default level in JITTargetMachineBuilder. (authored by lhames).
[ORC] Use CodeGenOpt::Default as the default level in JITTargetMachineBuilder.
Apr 10 2020, 1:59 PM

Apr 9 2020

lhames committed rG37bcf2df01cf: [ORC] Require JITDylib to be specified when adding IR and objects in the C API. (authored by lhames).
[ORC] Require JITDylib to be specified when adding IR and objects in the C API.
Apr 9 2020, 6:12 PM
lhames committed rG0d5f15f70009: [ORC] Add C API support for adding object files to an LLJIT instance. (authored by lhames).
[ORC] Add C API support for adding object files to an LLJIT instance.
Apr 9 2020, 4:54 PM
lhames committed rG1cd8493e69ba: [ORC] Expand the OrcV2 C API bindings. (authored by lhames).
[ORC] Expand the OrcV2 C API bindings.
Apr 9 2020, 4:54 PM

Apr 8 2020

lhames committed rG5877d6f5f46c: [ORC] Make mangling convenience methods part of the public API of LLJIT. (authored by lhames).
[ORC] Make mangling convenience methods part of the public API of LLJIT.
Apr 8 2020, 8:30 PM
lhames added a comment to D39111: Extensible LLVM RTTI.

Cool. I'll get this tidied up and clarify the rules about the ID member.

Apr 8 2020, 5:56 PM · Restricted Project

Apr 5 2020

lhames committed rG1b39c6f62c7c: [ORC] Add MachO universal binary support to StaticLibraryDefinitionGenerator. (authored by lhames).
[ORC] Add MachO universal binary support to StaticLibraryDefinitionGenerator.
Apr 5 2020, 8:49 PM

Apr 3 2020

lhames committed rG29a2b14be261: [ORC] Improve documention of memory ownership in the new Orc C bindings. (authored by lhames).
[ORC] Improve documention of memory ownership in the new Orc C bindings.
Apr 3 2020, 12:58 PM

Apr 2 2020

lhames committed rG05598441dee3: Re-apply 0071eaaf089, "[ORC] Export __cxa_atexit ...", with fixes. (authored by lhames).
Re-apply 0071eaaf089, "[ORC] Export __cxa_atexit ...", with fixes.
Apr 2 2020, 4:50 PM

Apr 1 2020

lhames committed rG0071eaaf0892: [ORC] Export __cxa_atexit from the main JITDylib in LLJIT. (authored by lhames).
[ORC] Export __cxa_atexit from the main JITDylib in LLJIT.
Apr 1 2020, 7:37 PM
lhames committed rG8e5a8f620cc2: [ORC] Don't require a null-terminator on MemoryBuffers for objects in archives. (authored by lhames).
[ORC] Don't require a null-terminator on MemoryBuffers for objects in archives.
Apr 1 2020, 12:24 PM
lhames committed rG53e238088107: [ORC] Add JITDylib name to debugging output when defining symbols. (authored by lhames).
[ORC] Add JITDylib name to debugging output when defining symbols.
Apr 1 2020, 12:23 PM

Mar 27 2020

lhames committed rGcb84e4827e43: [ORC] Introduce JITSymbolFlags::HasMaterializeSideEffectsOnly flag. (authored by lhames).
[ORC] Introduce JITSymbolFlags::HasMaterializeSideEffectsOnly flag.
Mar 27 2020, 11:29 AM
lhames committed rGd38d06e6493f: [ORC] Don't create MaterializingInfo entries unnecessarily. (authored by lhames).
[ORC] Don't create MaterializingInfo entries unnecessarily.
Mar 27 2020, 11:29 AM

Mar 21 2020

lhames committed rG38a8760b99b7: [ORC] Move ostream operators for debugging output out of Core.h. (authored by lhames).
[ORC] Move ostream operators for debugging output out of Core.h.
Mar 21 2020, 7:15 PM

Mar 19 2020

lhames committed rG39253a50f0f3: [ORC] Re-apply 98f2bb44610, enable JITEventListeners in OrcV2, with fixes. (authored by lhames).
[ORC] Re-apply 98f2bb44610, enable JITEventListeners in OrcV2, with fixes.
Mar 19 2020, 5:01 PM
lhames added a comment to D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..

Re-enabled in 39253a50f0f with fixes for the use-after-free bug.

Mar 19 2020, 5:00 PM · Restricted Project
lhames committed rG54aec178dac9: [ORC] Don't use a platform mutex for LLJIT's GenericLLVMIRPlatformSupport class. (authored by lhames).
[ORC] Don't use a platform mutex for LLJIT's GenericLLVMIRPlatformSupport class.
Mar 19 2020, 11:29 AM
lhames committed rGad2da631bf32: [ORC] Fix indentation in debugging output. (authored by lhames).
[ORC] Fix indentation in debugging output.
Mar 19 2020, 11:29 AM
lhames committed rGeb918d8daf1a: [ORC] Use finer-grained and session locking in MachOPlatform to avoid deadlock. (authored by lhames).
[ORC] Use finer-grained and session locking in MachOPlatform to avoid deadlock.
Mar 19 2020, 11:28 AM
lhames committed rGcd34c0570b5e: [ORC] Bail out early if a replacement MaterializationUnit is empty. (authored by lhames).
[ORC] Bail out early if a replacement MaterializationUnit is empty.
Mar 19 2020, 11:28 AM
lhames committed rGa7b8393ffea9: [ORC] Don't waste time building empty replacement MaterializationUnits. (authored by lhames).
[ORC] Don't waste time building empty replacement MaterializationUnits.
Mar 19 2020, 11:28 AM

Mar 18 2020

lhames added a comment to D39111: Extensible LLVM RTTI.

I think this bit amounts to "reservations because of Windows":

"Sadly, [using a CRTP base to provide the ID] will (I suspect) run into the non-conforming implementation of static data members of class templates on MSVC between DLLs. Specifically, the address of ID will be different between two DLLs. =["

Mar 18 2020, 2:40 PM · Restricted Project
lhames added a comment to D39111: Extensible LLVM RTTI.

@dblaikie, @chandlerc -- Any further thoughts on this one?

I'd like Chandler to come back around on this, given the reservations he expressed, but not sure he'll get to it - so might have to just figure it out ourselves. I share some of those reservations (that'd be easy to misuse this & have code that doesn't work on Windows - people won't read the documentation & might write the broken template situation), but maybe less concerned than Chandler was.

Mar 18 2020, 10:20 AM · Restricted Project

Mar 16 2020

lhames added a comment to D39111: Extensible LLVM RTTI.

@dblaikie, @chandlerc -- Any further thoughts on this one?

Mar 16 2020, 6:03 PM · Restricted Project

Mar 15 2020

lhames added a comment to D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..

This broke tests in exactly the way the precommit test predicted (http://45.33.8.238/linux/12615/step_12.txt). Please fix or revert. (And please look at precommit test results going forward.)

Mar 15 2020, 9:42 PM · Restricted Project
lhames committed rG9c5771710e69: Revert "[ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer." (authored by lhames).
Revert "[ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer."
Mar 15 2020, 4:06 PM
lhames added a reverting change for rG98f2bb446107: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer.: rG9c5771710e69: Revert "[ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer.".
Mar 15 2020, 4:05 PM
lhames committed rG98f2bb446107: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer. (authored by lhames).
[ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer.
Mar 15 2020, 3:33 PM
lhames closed D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..
Mar 15 2020, 3:33 PM · Restricted Project
lhames added inline comments to D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..
Mar 15 2020, 3:32 PM · Restricted Project
lhames accepted D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..

I am going to fix the issue Wenju identified and commit this: further development can happen in-tree.

Mar 15 2020, 3:32 PM · Restricted Project

Mar 14 2020

lhames committed rG049bb95c5c41: [ORC] Remove an undefined static method from LLJIT. (authored by lhames).
[ORC] Remove an undefined static method from LLJIT.
Mar 14 2020, 7:22 PM
lhames committed rG1e66710d3923: [JITLink][AArch64] Fix incorrect capitalization in a testcase name. (authored by lhames).
[JITLink][AArch64] Fix incorrect capitalization in a testcase name.
Mar 14 2020, 7:22 PM
lhames committed rG981f017c5c45: [ORC] Print symbol flags and materializer name in ExecutionSession::dump. (authored by lhames).
[ORC] Print symbol flags and materializer name in ExecutionSession::dump.
Mar 14 2020, 7:22 PM
lhames committed rG9c9eb60b4b1a: [JITLink][MachO] Re-apply b64afadf306, MachO linker-private support, with fixes. (authored by lhames).
[JITLink][MachO] Re-apply b64afadf306, MachO linker-private support, with fixes.
Mar 14 2020, 6:49 PM
lhames committed rGa7d187d9c05a: Revert "[JITLink][MachO] Treat linker private symbols as hidden rather than… (authored by lhames).
Revert "[JITLink][MachO] Treat linker private symbols as hidden rather than…
Mar 14 2020, 5:11 PM
lhames added a reverting change for rGb64afadf306f: [JITLink][MachO] Treat linker private symbols as hidden rather than private.: rGa7d187d9c05a: Revert "[JITLink][MachO] Treat linker private symbols as hidden rather than….
Mar 14 2020, 5:11 PM
lhames committed rGb64afadf306f: [JITLink][MachO] Treat linker private symbols as hidden rather than private. (authored by lhames).
[JITLink][MachO] Treat linker private symbols as hidden rather than private.
Mar 14 2020, 4:39 PM
lhames committed rGf75e04bc93fb: [llvm-jitlink] Add -show-init-es option to dump initial ExecutionSession state. (authored by lhames).
[llvm-jitlink] Add -show-init-es option to dump initial ExecutionSession state.
Mar 14 2020, 4:39 PM
lhames committed rG2ddfac060703: [Orc][examples] Actually return MainResult from main (authored by lhames).
[Orc][examples] Actually return MainResult from main
Mar 14 2020, 3:34 PM
lhames committed rG633ea07200ea: [Orc] Add basic OrcV2 C bindings and example. (authored by lhames).
[Orc] Add basic OrcV2 C bindings and example.
Mar 14 2020, 3:02 PM

Mar 13 2020

lhames committed rG906a91aa4d52: [MCJIT] Check for RuntimeDyld errors in MCJIT::finalizeLoadedModules. (authored by lhames).
[MCJIT] Check for RuntimeDyld errors in MCJIT::finalizeLoadedModules.
Mar 13 2020, 2:03 PM
lhames closed D75912: Missing Dyld error handling.
Mar 13 2020, 2:03 PM · Restricted Project
lhames accepted D75912: Missing Dyld error handling.

Thanks Keder!

Mar 13 2020, 9:39 AM · Restricted Project

Mar 12 2020

lhames committed rG7266a8bfeb85: [ORC] Enable exception handling in JIT'd code when using LLJIT on Darwin. (authored by lhames).
[ORC] Enable exception handling in JIT'd code when using LLJIT on Darwin.
Mar 12 2020, 3:46 PM
lhames committed rG214a9f0dd481: [ORC] Add a mutex to guard EHFrameRegistrationPlugin data structures. (authored by lhames).
[ORC] Add a mutex to guard EHFrameRegistrationPlugin data structures.
Mar 12 2020, 3:46 PM

Mar 11 2020

lhames committed rGc700e0317c25: [JITLink] Read symbol linkage from the correct field. (authored by lhames).
[JITLink] Read symbol linkage from the correct field.
Mar 11 2020, 8:23 PM
lhames committed rGb19801640bf6: [ORC] Fix an overly aggressive assert. (authored by lhames).
[ORC] Fix an overly aggressive assert.
Mar 11 2020, 8:23 PM
lhames committed rG0caed13fe4a8: [llvm-jitlink] Fix DEBUG_TYPE string. (authored by lhames).
[llvm-jitlink] Fix DEBUG_TYPE string.
Mar 11 2020, 8:23 PM
lhames committed rG4b87f9230bd2: [ORC] Add some extra debugging output. (authored by lhames).
[ORC] Add some extra debugging output.
Mar 11 2020, 8:23 PM

Mar 10 2020

lhames committed rG337e131ca7de: [RuntimeDyld][COFF] Build stubs for COFF dllimport symbols. (authored by lhames).
[RuntimeDyld][COFF] Build stubs for COFF dllimport symbols.
Mar 10 2020, 4:27 PM
lhames committed rGaed571252203: [RuntimeDyld] Allow multi-line rtdyld-check and jitlink-check expressions. (authored by lhames).
[RuntimeDyld] Allow multi-line rtdyld-check and jitlink-check expressions.
Mar 10 2020, 4:27 PM
lhames closed D75884: [RuntimeDyld][COFF] Build stubs for COFF dllimport symbols..
Mar 10 2020, 4:26 PM · Restricted Project

Mar 9 2020

lhames committed rG3f981cdde90f: [MC] Allow Stackmap sections after DWARF in MachO. (authored by lhames).
[MC] Allow Stackmap sections after DWARF in MachO.
Mar 9 2020, 6:54 PM
lhames closed D75836: [MC] Allow Stackmap sections after DWARF in MachO..
Mar 9 2020, 6:54 PM · Restricted Project
lhames added a comment to D75836: [MC] Allow Stackmap sections after DWARF in MachO..

Ok. I'm going to land this to unblock people who are hitting this assertion.

Mar 9 2020, 5:50 PM · Restricted Project
lhames created D75884: [RuntimeDyld][COFF] Build stubs for COFF dllimport symbols..
Mar 9 2020, 5:50 PM · Restricted Project

Mar 8 2020

lhames created D75838: [ORC] Enable JITEventListeners in the RTDyldObjectLinkingLayer..
Mar 8 2020, 11:25 PM · Restricted Project
lhames created D75836: [MC] Allow Stackmap sections after DWARF in MachO..
Mar 8 2020, 10:23 PM · Restricted Project

Mar 4 2020

lhames committed rG4b15decb609a: [ORC] Remove hard dependency on libobjc when using MachOPlatform with LLJIT. (authored by lhames).
[ORC] Remove hard dependency on libobjc when using MachOPlatform with LLJIT.
Mar 4 2020, 10:18 PM
lhames committed rG8363ff04afad: [ORC] Add some debugging output for initializers. (authored by lhames).
[ORC] Add some debugging output for initializers.
Mar 4 2020, 12:58 PM