Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Nov 5 2020

jsmolens added inline comments to D90411: TOSA MLIR Dialect.
Nov 5 2020, 4:33 PM · Restricted Project
jsmolens added inline comments to D90411: TOSA MLIR Dialect.
Nov 5 2020, 2:26 PM · Restricted Project

Oct 30 2020

jsmolens added a comment to D90411: TOSA MLIR Dialect.
In D90411#2364856, @mehdi_amini wrote:

Mostly this page right now I believe: https://mlir.llvm.org/getting_started/TestingGuide/

Oct 30 2020, 9:30 AM · Restricted Project
jsmolens added a comment to D90411: TOSA MLIR Dialect.
In D90411#2363576, @sjarus wrote:
In D90411#2363567, @mehdi_amini wrote:

I'm happy to review the code right now, but I'd also like the tests to get in with the code and not as a follow-up. In general we don't land patches without tests as far as I know.

Sounds good - we'll work on adding unit tests under mlir/test/Dialect/Tosa and will submit another patch when ready.

Oct 30 2020, 8:48 AM · Restricted Project