Tue, May 25
Mon, May 24
Apologies for the missing test, here it is! :)
Wed, May 19
re-uploaded new diff with more context
Tue, May 18
Addressed feedback and fixed a test failure in the clang-opt-bisect tool test.
May 5 2021
Apr 28 2021
No longer required as of D98699
Apr 23 2021
Apr 19 2021
Mar 31 2021
Mar 23 2021
Hey Orlando! thanks for this. A really nice, solid reimplementation and improvement of the original work. Great code comments too.
Feb 10 2021
Feb 2 2021
this patch (probably) broke the build bot at:
Jan 28 2021
Looks good to me.
Jan 26 2021
Added more context to diff
Jan 20 2021
Jan 5 2021
The "go" method of Debugger classes in Dexter used to be called once, to launch the process. However with the new DebuggerController classes it's now used to set the target process free running until we hit a relevant source line. Alas, I'd baked the former assumption into the DbgEng driver and had the "go" method do nothing. This can lead to an infinite loop where the DebuggerController repeatedly calls "go".
Nov 6 2020
LGTM. thanks for spotting this... <hangs head in shame>
Nov 5 2020
@MaskRay duly noted, thanks for the info.
Nov 4 2020
Nov 3 2020
I'll get this committed for you shortly.
Hey Nabeel, thanks for this.
Oct 29 2020
fix for any builds that don't have lldb available:
Oct 28 2020
Oct 21 2020
Oct 20 2020
Oct 19 2020
Jun 11 2020
First off, thanks for the feedback!
I also wondered where the best place would be for this path mapping. However, I still think DebuggerBase is a good spot as the debuggers currently rely on knowing context.source_files. So whichever tool wants to use the debuggers will also have to fill context.source_files, and therefore also run in the problem of needing to remap paths to the ones used in the compilation unit. Moving this mapping into the test tool would prevent other tools from reusing it.
Also, moving this mapping into the test tool would require to make the source_files be relative paths (to the source_root_dir) before calling the debuggers.
This leads to a future me now needing to remember what kind of path is used where: An absolute file system path (test tool), a path relative to source_root_dir (DebuggerController), or a debug info path (Debugger).
Jun 10 2020
Hey and thanks for this!
Jun 5 2020
Jun 3 2020
Hi Adrian (@aprantl)
seems I've made a more mundane error of committing a diff file as part of my patch. this has been reverted for now.
@aprantl I'll take a look, thanks for pointing them out.
Jun 2 2020
Landed in commit rG81e836a5a675f6a3d9d35560fddbbb87fdf66201
Landed in commit rGbf1cdc2c6c0460b7121ac653c796ef4995b1dfa9
removed and replaced LoadDebuggerException with DebuggerException in LLDB.
May 18 2020
Updated diff to correct revision for easing future historical searches
May 15 2020
@echristo thanks for your interest. do you need any further clarification on what dexter does or how this patch fits in with the existing behaviour?
May 13 2020
missing note, dbgeng does not support the new DexLimitSteps commands as of right now.
May 12 2020
Apr 27 2020
I prefer the current approach for readabilities sake as well as separating the two method calls out.
no, this would cause file path comparisons that are case sensitive to potentially fail on drive letter for windows.
Apr 22 2020
removed accidental new line deletion
in ./debuginfo-tests/CMakeLists.txt we have the following on line 27:
@jmorse I believe there's already a test in the cmake/config that checks the python version when generating the build.
thanks for this, LGTM.
Apr 21 2020
fix for failing test reported at D76926
fix for reported test failure at:
thanks for reporting. this issue should now be fixed.
Apr 20 2020
Apr 1 2020
The cdb tests taking longer may be a result of the dexter regression suite running along side them. SFAIK that's not intended behaviour.
Mar 31 2020
I've also added an internal ticket to add darwin support to the dexter regression suite... I don't think there'll be much appetite in-house for it but if there's a clear need to add it in the future then of course we'll consider putting in the work.
I've actually mailed these via the mailing list by accident, here's a copy of what I mailed:
Mar 27 2020
@Pierre-vh and not a problem buddy, I wish you all the best in your future endeavours, don't worry about feedback on the controller patch if it's not related to your current work! :) you get on with what you need to.
The debugger controller patch is now live and awaiting review at
I hope you're keeping safe in these unprecedented times!