Page MenuHomePhabricator
Feed Advanced Search

Thu, Mar 26

marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

No, this is just a little old. Currently, calling registerAllDialects() and registerAllPasses() is required if you want any of the standard stuff. The .cpp code was just a copy of what's in tools/mlir-opt. The critical part of this is the CMakeLists.txt, which was intended as a test for linking against libMLIR.so. If you actually want to build an external project see: https://reviews.llvm.org/D76047

Thu, Mar 26, 11:22 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@marbre It looks like there no commit information in the revision. How do you want to be acknowledged? In the future, if you use arc to upload your commit, then this happens automatically.

Thu, Mar 26, 10:50 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.
Thu, Mar 26, 8:06 AM · Restricted Project
marbre added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

Out of curiosity, no need to call define and registerTestPasses()? Further, calling registerAllDialects() and registerAllPasses() can be skipped? Is that due linking against libMLIR.so?

Thu, Mar 26, 8:06 AM · Restricted Project
marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

Thu, Mar 26, 7:33 AM · Restricted Project

Thu, Mar 19

marbre added a comment to D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.

@rriddle I would appreciate if you or someone else could commit on my behalf.

Thu, Mar 19, 4:27 PM · Restricted Project
marbre added reviewers for D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant: rsuderman, rriddle.
Thu, Mar 19, 10:52 AM · Restricted Project
marbre created D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Thu, Mar 19, 10:52 AM · Restricted Project
marbre updated the summary of D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Thu, Mar 19, 10:52 AM · Restricted Project

Tue, Mar 17

marbre accepted D76047: [MLIR] Add support for out of tree external projects using MLIR.
Tue, Mar 17, 2:02 PM · Restricted Project
marbre added inline comments to D76047: [MLIR] Add support for out of tree external projects using MLIR.
Tue, Mar 17, 2:02 PM · Restricted Project

Feb 12 2020

marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Thanks!

Feb 12 2020, 2:06 AM · Restricted Project
marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Gentle ping. I would be happy if someone could commit the patch on my behalf.

Feb 12 2020, 12:06 AM · Restricted Project

Feb 6 2020

marbre updated the diff for D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Rebased onto 6bfc45cf6. The patch should apply now.

Feb 6 2020, 12:21 AM · Restricted Project

Feb 4 2020

marbre added a comment to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

Thanks for the review. I would appreciate if someone could commit the patch on my behalf.

Feb 4 2020, 11:46 PM · Restricted Project
marbre updated the diff for D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

I went for the second option to get close to TensorFlow's Bazel configuration.

Feb 4 2020, 8:13 AM · Restricted Project

Feb 3 2020

marbre added a comment to D73770: [mlir] Fix link to 'Getting started with MLIR'.

Thanks for the fast review. I would appreciate if someone could commit this on my behalf.

Feb 3 2020, 3:04 AM · Restricted Project

Feb 1 2020

marbre planned changes to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.
Feb 1 2020, 4:33 AM · Restricted Project

Jan 31 2020

marbre created D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.
Jan 31 2020, 5:11 AM · Restricted Project
marbre created D73770: [mlir] Fix link to 'Getting started with MLIR'.
Jan 31 2020, 1:56 AM · Restricted Project