Page MenuHomePhabricator
Feed Advanced Search

Mon, Sep 28

benshi001 added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

I think this patch is OK to be committed.

Mon, Sep 28, 8:36 PM · Restricted Project
benshi001 updated the diff for D88410: [clang][AVR] Improve avr-ld command line options.
Mon, Sep 28, 8:02 PM · Restricted Project
benshi001 updated the diff for D88410: [clang][AVR] Improve avr-ld command line options.
Mon, Sep 28, 6:23 PM · Restricted Project
benshi001 added a comment to D88410: [clang][AVR] Improve avr-ld command line options.

For some devices, the library sub path "-L" and family name "-m" are not always equal.
-L/usr/lib/avr/lib/XXX" "-L/usr/lib/gcc/avr/5.4.0/XXX" "-mYYY"

Mon, Sep 28, 5:45 AM · Restricted Project
benshi001 requested review of D88410: [clang][AVR] Improve avr-ld command line options.
Mon, Sep 28, 5:36 AM · Restricted Project

Sat, Sep 26

benshi001 updated the diff for D88352: [clang][AVR] Add more devices.
Sat, Sep 26, 1:25 AM · Restricted Project

Fri, Sep 25

benshi001 requested review of D88352: [clang][AVR] Add more devices.
Fri, Sep 25, 9:25 PM · Restricted Project
benshi001 updated the diff for D87968: [AVR] Improve device list.
Fri, Sep 25, 9:17 PM · Restricted Project
benshi001 updated the diff for D87968: [AVR] Improve device list.
Fri, Sep 25, 8:10 PM · Restricted Project

Wed, Sep 23

benshi001 updated the diff for D87968: [AVR] Improve device list.
Wed, Sep 23, 8:27 AM · Restricted Project

Sat, Sep 19

benshi001 requested review of D87968: [AVR] Improve device list.
Sat, Sep 19, 9:37 AM · Restricted Project

Thu, Sep 3

benshi001 committed rGc5716447c14f: [NFC][RISCV] Simplify pass arg of RISCVMergeBaseOffsetOpt (authored by benshi001).
[NFC][RISCV] Simplify pass arg of RISCVMergeBaseOffsetOpt
Thu, Sep 3, 5:02 AM
benshi001 closed D87069: [NFC][RISCV] Simplify pass arg of RISCVMergeBaseOffsetOpt.
Thu, Sep 3, 5:01 AM · Restricted Project

Wed, Sep 2

benshi001 requested review of D87069: [NFC][RISCV] Simplify pass arg of RISCVMergeBaseOffsetOpt.
Wed, Sep 2, 8:19 PM · Restricted Project

Aug 14 2020

benshi001 committed rG05047f0b36e2: [ARM][test] Add more tests of two-part immediates (authored by benshi001).
[ARM][test] Add more tests of two-part immediates
Aug 14 2020, 8:11 AM
benshi001 closed D84100: [ARM][test] Add more tests of two-part immediates.
Aug 14 2020, 8:11 AM · Restricted Project

Aug 13 2020

benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

More tests are added for testing future patches.

Aug 13 2020, 9:33 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 13 2020, 9:32 PM · Restricted Project

Aug 12 2020

benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

I think the fact that you're having to make some Thumb2 changes to get around how the code is organised, suggests that the code should be reorganised instead. I'd suggest:

  • Pre-commit the two-part-imm.ll test.
  • Split the arm and thumb paths in an NFC patch, refactoring common code.
  • Then make your arm changes.
Aug 12 2020, 6:16 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 12 2020, 6:13 PM · Restricted Project

Aug 11 2020

benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

I have uploaded a new patch, in which more tests for orr and eor are added.

Aug 11 2020, 8:01 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 11 2020, 7:56 PM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

If the logic isn't needed, then yes, I'd recommend removing. Currently I'm seeing logic added for Thumb2 opcodes so I would expect some changes and testing and if that isn't case, then I guess the changes aren't needed. Looks like the ORR and EOR paths also need to be tested?

Aug 11 2020, 5:02 AM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 11 2020, 4:58 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

If the logic isn't needed, then yes, I'd recommend removing. Currently I'm seeing logic added for Thumb2 opcodes so I would expect some changes and testing and if that isn't case, then I guess the changes aren't needed. Looks like the ORR and EOR paths also need to be tested?

Aug 11 2020, 3:59 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

If the logic isn't needed, then yes, I'd recommend removing. Currently I'm seeing logic added for Thumb2 opcodes so I would expect some changes and testing and if that isn't case, then I guess the changes aren't needed. Looks like the ORR and EOR paths also need to be tested?

Aug 11 2020, 3:52 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

If the logic isn't needed, then yes, I'd recommend removing. Currently I'm seeing logic added for Thumb2 opcodes so I would expect some changes and testing and if that isn't case, then I guess the changes aren't needed. Looks like the ORR and EOR paths also need to be tested?

Aug 11 2020, 3:51 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

Thanks for the test changes.

I have added tests for thumb2, however current patch does not apply to thumb2.

I'm a bit confused then why there are Thumb2 changes in FoldImmediate?

Aug 11 2020, 2:51 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

Also, two edge-case negative tests to exercise isSOImmTwoPartValSub are added.

Aug 11 2020, 12:04 AM · Restricted Project

Aug 10 2020

benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 10 2020, 11:59 PM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

I have added tests for thumb2, however current patch does not apply to thumb2.

Aug 10 2020, 10:51 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 10 2020, 10:48 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 10 2020, 10:31 PM · Restricted Project
benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 10 2020, 8:42 PM · Restricted Project

Aug 9 2020

benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Aug 9 2020, 7:44 AM · Restricted Project

Jul 28 2020

benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

I understood from your message to the llvm dev list that generating numbers isn't entirely straightforward for you.
I will take this patch, and generate some numbers, will see if I can do that today/tomorrow, and will let you know.

Jul 28 2020, 5:49 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

I understood from your message to the llvm dev list that generating numbers isn't entirely straightforward for you.
I will take this patch, and generate some numbers, will see if I can do that today/tomorrow, and will let you know.

Jul 28 2020, 5:45 AM · Restricted Project

Jul 27 2020

benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

Eye balling the one test that was changed this indeed makes sense. But I would prefer to see some performance numbers first just to check we haven't missed anything.

Jul 27 2020, 7:42 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

Eye balling the one test that was changed this indeed makes sense. But I would prefer to see some performance numbers first just to check we haven't missed anything.

Jul 27 2020, 7:38 AM · Restricted Project
benshi001 added a comment to D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm.

Although I don't mind at all new tests being added, in this case I am really wondering if the code paths are not exercised by existing tests. And also reading the description:

This case will show furture optimization of add-imm & sub-imm.

I am wondering what these future optimizations are and if these tests should simply go in with that then?

Jul 27 2020, 7:19 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

ping

Jul 27 2020, 6:05 AM · Restricted Project
benshi001 added a comment to D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm.

ping

Jul 27 2020, 6:05 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

ping

Jul 27 2020, 6:05 AM · Restricted Project

Jul 23 2020

benshi001 abandoned D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 23 2020, 6:16 PM · Restricted Project

Jul 22 2020

benshi001 added inline comments to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 22 2020, 7:30 PM · Restricted Project
benshi001 added inline comments to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 22 2020, 7:18 PM · Restricted Project

Jul 19 2020

benshi001 updated the diff for D84100: [ARM][test] Add more tests of two-part immediates.
Jul 19 2020, 5:59 AM · Restricted Project
benshi001 updated the diff for D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 19 2020, 5:40 AM · Restricted Project
benshi001 updated the diff for D83745: [ARM] Optimize immediate selection.
Jul 19 2020, 5:13 AM · Restricted Project
benshi001 updated the diff for D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm.
Jul 19 2020, 5:07 AM · Restricted Project

Jul 18 2020

benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

The patch depends on https://reviews.llvm.org/D83928, it will show improvements based on it.

Jul 18 2020, 7:34 AM · Restricted Project
benshi001 added a comment to D84100: [ARM][test] Add more tests of two-part immediates.

This patch does two optimization:

Jul 18 2020, 7:30 AM · Restricted Project
Herald added a project to D84100: [ARM][test] Add more tests of two-part immediates: Restricted Project.
Jul 18 2020, 7:24 AM · Restricted Project

Jul 17 2020

benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

ping

Jul 17 2020, 4:18 AM · Restricted Project

Jul 16 2020

benshi001 added reviewers for D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm: greened, anhtuyen, dmgreen.
Jul 16 2020, 10:21 PM · Restricted Project
benshi001 added a reviewer for D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm: efriedma.
Jul 16 2020, 10:19 PM · Restricted Project
benshi001 updated the diff for D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm.
Jul 16 2020, 4:22 PM · Restricted Project

Jul 15 2020

benshi001 updated the diff for D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm.
Jul 15 2020, 11:36 PM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

Okay, I had only a quick first look, perhaps multiple uses isn't a problem.
If it's not too much trouble, confirming this with the llvm test-suite would be good.

Jul 15 2020, 9:16 PM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.
Jul 15 2020, 9:14 PM · Restricted Project
Herald added a project to D83928: [ARM][TEST] Add a new test case of add-imm & sub-imm: Restricted Project.
Jul 15 2020, 9:12 PM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.

for C code

unsigned int f0(unsigned int a)
{
        return a-0x2323;
}
unsigned int f1(unsigned int a) 
{
        return a+0x2323;
}
Jul 15 2020, 8:01 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.
  1. Is there a benchmark test suite I can try?
Jul 15 2020, 7:23 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.
Jul 15 2020, 7:13 AM · Restricted Project
benshi001 added a comment to D83745: [ARM] Optimize immediate selection.
Jul 15 2020, 7:04 AM · Restricted Project

Jul 14 2020

benshi001 updated the diff for D83745: [ARM] Optimize immediate selection.
Jul 14 2020, 12:14 AM · Restricted Project
benshi001 updated the diff for D83745: [ARM] Optimize immediate selection.
Jul 14 2020, 12:04 AM · Restricted Project

Jul 13 2020

Herald added a project to D83745: [ARM] Optimize immediate selection: Restricted Project.
Jul 13 2020, 10:34 PM · Restricted Project

Jul 11 2020

benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
  1. RISCV got improved
Jul 11 2020, 8:59 AM · Restricted Project
benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

Change list according to all your comments.

Jul 11 2020, 8:56 AM · Restricted Project
benshi001 updated the diff for D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 11 2020, 8:49 AM · Restricted Project

Jul 10 2020

benshi001 updated the diff for D83159: [RISCV][test] Add a new codegen test of add-mul transform.
Jul 10 2020, 5:38 PM · Restricted Project
benshi001 updated the diff for D83159: [RISCV][test] Add a new codegen test of add-mul transform.
Jul 10 2020, 4:24 AM · Restricted Project

Jul 7 2020

benshi001 updated the diff for D82660: [RISCV] Optimize multiplication by constant.
Jul 7 2020, 6:27 PM · Restricted Project
benshi001 updated the diff for D82262: [RISCV] optimize addition with a pair of (addi imm).
Jul 7 2020, 6:10 PM · Restricted Project
benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

Change list according to all your comments.

Jul 7 2020, 5:53 AM · Restricted Project
benshi001 updated the diff for D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 7 2020, 5:48 AM · Restricted Project

Jul 6 2020

benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

Chnage list according to all your comments.

Jul 6 2020, 2:38 AM · Restricted Project
benshi001 updated the diff for D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

One more change:

Jul 6 2020, 2:28 AM · Restricted Project
benshi001 added inline comments to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 6 2020, 1:15 AM · Restricted Project

Jul 5 2020

benshi001 updated the diff for D82262: [RISCV] optimize addition with a pair of (addi imm).

Thanks. I have improved the function names according to your suggestion!

Jul 5 2020, 5:51 AM · Restricted Project
benshi001 updated the diff for D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

Thanks for all of your suggestions. I have uploaded a new patch edition.

Jul 5 2020, 5:19 AM · Restricted Project

Jul 4 2020

benshi001 added inline comments to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 4 2020, 9:40 AM · Restricted Project
benshi001 added a comment to D83159: [RISCV][test] Add a new codegen test of add-mul transform.

This patch will show the optimization by my previous patch https://reviews.llvm.org/D83153

Jul 4 2020, 9:40 AM · Restricted Project
benshi001 created D83159: [RISCV][test] Add a new codegen test of add-mul transform.
Jul 4 2020, 9:40 AM · Restricted Project
benshi001 added inline comments to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 4 2020, 9:40 AM · Restricted Project
benshi001 updated the summary of D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 4 2020, 1:33 AM · Restricted Project
benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

The build failure does not related to my changes, today's llvm master branch also has them after running "make check-all"

Jul 4 2020, 1:33 AM · Restricted Project

Jul 3 2020

benshi001 added a comment to D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.

My patch at least generates better code x86, aarch64 and riscv.

Jul 3 2020, 9:41 PM · Restricted Project
benshi001 created D83153: [DAGCombiner] Prevent regression in isMulAddWithConstProfitable.
Jul 3 2020, 9:37 PM · Restricted Project

Jul 2 2020

benshi001 added a comment to D82660: [RISCV] Optimize multiplication by constant.

I'm happy with this optimisation where this patch removes multiply libcalls.

Where the target has a the m extension, and especially for 64-bit multiplies on rv32im, I'm not sure this is an optimisation.

I think that, for the moment, we should add a guard to the hook to avoid this transformation where we do have mul instructions:

if (Subtarget.hasStdExtM())
  return false;

What do you think?

Jul 2 2020, 9:10 AM · Restricted Project
benshi001 updated the diff for D82660: [RISCV] Optimize multiplication by constant.
Jul 2 2020, 9:10 AM · Restricted Project
benshi001 updated the diff for D82660: [RISCV] Optimize multiplication by constant.
Jul 2 2020, 8:37 AM · Restricted Project

Jul 1 2020

benshi001 added inline comments to D82660: [RISCV] Optimize multiplication by constant.
Jul 1 2020, 8:31 PM · Restricted Project
benshi001 updated the diff for D82660: [RISCV] Optimize multiplication by constant.
Jul 1 2020, 8:31 PM · Restricted Project

Jun 30 2020

benshi001 added a comment to D82262: [RISCV] optimize addition with a pair of (addi imm).

ping ...

Jun 30 2020, 11:15 PM · Restricted Project
benshi001 added a comment to D82262: [RISCV] optimize addition with a pair of (addi imm).

Could you please help me review it? I have not got any suggestion for one week :)

Jun 30 2020, 10:43 PM · Restricted Project

Jun 27 2020

benshi001 added a comment to D82660: [RISCV] Optimize multiplication by constant.

Thanks. I have uploaded a new version according to your suggestion!

Jun 27 2020, 1:53 AM · Restricted Project
benshi001 updated the diff for D82660: [RISCV] Optimize multiplication by constant.
Jun 27 2020, 1:49 AM · Restricted Project

Jun 26 2020

benshi001 updated the summary of D82660: [RISCV] Optimize multiplication by constant.
Jun 26 2020, 8:44 AM · Restricted Project