Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 24

awarzynski updated the summary of D92025: PROOF-OF-CONCEPT: Add new diagnostics classes for clangDriver.
Tue, Nov 24, 7:41 AM · Restricted Project
awarzynski requested review of D92025: PROOF-OF-CONCEPT: Add new diagnostics classes for clangDriver.
Tue, Nov 24, 6:28 AM · Restricted Project

Fri, Nov 20

awarzynski committed rG1b749c0cb5c0: [flang][driver] Remove unnecessary CMake dependencies (nfc) (authored by awarzynski).
[flang][driver] Remove unnecessary CMake dependencies (nfc)
Fri, Nov 20, 8:45 AM
awarzynski accepted D91843: Add flang dylib/shared libs buildbots.

Thank you for working on this @rovka ! These are much needed configurations and Flang will benefit from these greatly :) LGTM

Fri, Nov 20, 6:29 AM

Wed, Nov 18

awarzynski added a comment to D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests.

Hi @yrouban, thank you for working on this! Unfortunately this breaks shared library builds (i.e. with BUILD_SHARED_LIBS set to ON). This is causing one of our buildbots to fail:

Admittedly, it's been failing in the past 24hrs for other reasons too :)

Wed, Nov 18, 2:13 AM · Restricted Project
awarzynski committed rGccf500ce00c5: [NFC] Add missing dependency in the IR unittests (authored by awarzynski).
[NFC] Add missing dependency in the IR unittests
Wed, Nov 18, 2:11 AM

Tue, Nov 17

awarzynski committed rGe8356a79ffd3: [flang][nfc] Add missing dependency in CMake (authored by awarzynski).
[flang][nfc] Add missing dependency in CMake
Tue, Nov 17, 6:42 AM

Mon, Nov 16

awarzynski committed rG6c02835d6c92: [flang][f18] Remove "-fdebug-resolve-names" (authored by awarzynski).
[flang][f18] Remove "-fdebug-resolve-names"
Mon, Nov 16, 7:52 AM
awarzynski closed D91537: [flang][f18] Remove "-fdebug-resolve-names".
Mon, Nov 16, 7:52 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D91537: [flang][f18] Remove "-fdebug-resolve-names": sameeranjoshi, SouraVX.
Mon, Nov 16, 5:49 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D91537: [flang][f18] Remove "-fdebug-resolve-names": kiranchandramohan, sscalpone, tskeith.
Mon, Nov 16, 5:48 AM · Restricted Project, Restricted Project
awarzynski requested review of D91537: [flang][f18] Remove "-fdebug-resolve-names".
Mon, Nov 16, 5:47 AM · Restricted Project, Restricted Project

Wed, Nov 11

awarzynski accepted D91286: [flang] Fix CheckSpecificationExpr handling of associated names.

Thank you for resubmitting this. I tested with BUILD_SHARED_LIBS=On and it builds fine.

Wed, Nov 11, 12:21 PM · Restricted Project, Restricted Project
awarzynski added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

I think that the root cause of the build failure is the circular dependency: FortranSemantics <-> FortranEvaluate <-> FortranSemantics. Adding inline to IsModule and IsSubmodule fixes this particular build issue, but not the circular dependency.

Wed, Nov 11, 9:36 AM · Restricted Project, Restricted Project
awarzynski committed rGfdbc7e505c0c: [flang][driver] Make sure that `-###` is marked as supported (NFC) (authored by awarzynski).
[flang][driver] Make sure that `-###` is marked as supported (NFC)
Wed, Nov 11, 5:14 AM
awarzynski added a reverting change for rGb670189975f5: [flang] Fix CheckSpecificationExpr handling of associated names: rGeae2d6357110: Revert "[flang] Fix CheckSpecificationExpr handling of associated names".
Wed, Nov 11, 3:35 AM
awarzynski committed rGeae2d6357110: Revert "[flang] Fix CheckSpecificationExpr handling of associated names" (authored by awarzynski).
Revert "[flang] Fix CheckSpecificationExpr handling of associated names"
Wed, Nov 11, 3:35 AM
awarzynski added a reverting change for D91209: [flang] Fix CheckSpecificationExpr handling of associated names: rGeae2d6357110: Revert "[flang] Fix CheckSpecificationExpr handling of associated names".
Wed, Nov 11, 3:35 AM · Restricted Project, Restricted Project
awarzynski added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

Hi @klausler , thank you for working on this!

Wed, Nov 11, 3:34 AM · Restricted Project, Restricted Project

Nov 5 2020

awarzynski committed rG93c94139e614: [flang][f18] Remove unimplemented options (NFC) (authored by awarzynski).
[flang][f18] Remove unimplemented options (NFC)
Nov 5 2020, 10:38 AM
awarzynski committed rGa7bcb3b9eb76: [Flang][f18] Remove unimplemented options from `flang -help` (NFC) (authored by awarzynski).
[Flang][f18] Remove unimplemented options from `flang -help` (NFC)
Nov 5 2020, 4:48 AM

Nov 4 2020

awarzynski added a comment to D90667: Add a basic C API for the MLIR PassManager as well as a basic TableGen backend for creating passes.

The reasons why this is working in static library is that linking is delayed to the final binary: as long as the missing dependency is also present in the final binary link it'll be fine.
With the shared library build, for each library we link it in isolation and resolve the dependencies at this point.

Nov 4 2020, 12:15 PM · Restricted Project
awarzynski added a comment to D90667: Add a basic C API for the MLIR PassManager as well as a basic TableGen backend for creating passes.

Hi @mehdi_amini , thank you for working on this!

Nov 4 2020, 2:45 AM · Restricted Project
awarzynski committed rGd007bbd986d9: [mlir] Fix failing shared libraries build (authored by awarzynski).
[mlir] Fix failing shared libraries build
Nov 4 2020, 2:36 AM

Nov 2 2020

awarzynski added a comment to D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic.

I may not have been clear. I'm not saying SourceLocation is a meaningful concept in the driver.

Nov 2 2020, 7:40 AM · Restricted Project
awarzynski added a comment to D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

I would wait for a couple of more days for someone to review from community may be from Nvidia's side if someone would verify the initial design.

Nov 2 2020, 6:08 AM · Restricted Project, Restricted Project
awarzynski committed rGd28de0d7f257: [Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`) (authored by CarolineConcatto).
[Flang][Driver] Add PrintPreprocessedInput FrontendAction (`flang-new -E`)
Nov 2 2020, 6:04 AM
awarzynski closed D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Nov 2 2020, 6:03 AM · Restricted Project, Restricted Project
awarzynski committed rG9ffb5b0469ae: [flang][driver] Rename the accessors/mutators (NFC) (authored by awarzynski).
[flang][driver] Rename the accessors/mutators (NFC)
Nov 2 2020, 3:29 AM
awarzynski closed D90300: [flang][driver] Rename the accessors (NFC).
Nov 2 2020, 3:29 AM · Restricted Project
awarzynski committed rG1ed2ca68191f: [flang][driver] Use --match-full-lines in tests for `-test-io` (authored by awarzynski).
[flang][driver] Use --match-full-lines in tests for `-test-io`
Nov 2 2020, 2:01 AM
awarzynski closed D90306: [flang][driver] Use --match-full-lines in tests for `-test-io`.
Nov 2 2020, 2:01 AM · Restricted Project

Oct 30 2020

awarzynski committed rGe5699b8ff1b6: [clang][driver] Rename DriverOption as NoXarchOption (NFC) (authored by awarzynski).
[clang][driver] Rename DriverOption as NoXarchOption (NFC)
Oct 30 2020, 10:02 AM
awarzynski closed D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).
Oct 30 2020, 10:01 AM · Restricted Project
awarzynski added a comment to D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic.

Hi @rjmccall , thank you for your quick reply!

Oct 30 2020, 8:48 AM · Restricted Project
awarzynski added a comment to D88655: [Flang][OpenMP][OpenACC] Fix exit out of a region in OpenMP parallel construct..

I've also noticed other patches causing build failures. Fixing this one felt rather straightforward so I took the liberty of submitting a fix: https://github.com/llvm/llvm-project/commit/b7d1271a01b72a079ea016a9d4e31a73091d5f0e. I hope that that's fine.

Oct 30 2020, 4:54 AM · Restricted Project, Restricted Project
awarzynski committed rGb7d1271a01b7: [Flang] Fix build failures (NFC) (authored by awarzynski).
[Flang] Fix build failures (NFC)
Oct 30 2020, 4:51 AM
awarzynski added a comment to D88655: [Flang][OpenMP][OpenACC] Fix exit out of a region in OpenMP parallel construct..

Sadly this patch is causing build failures on our Flang buildbots: http://lab.llvm.org:8011/#/builders/33/builds/386

Oct 30 2020, 4:15 AM · Restricted Project, Restricted Project

Oct 29 2020

awarzynski added a comment to D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic.

Hi All,

Oct 29 2020, 7:14 AM · Restricted Project
awarzynski added a comment to D90300: [flang][driver] Rename the accessors (NFC).

Thank you for reviewing @CarolineConcatto! I missed a few cases - thanks for catching those! That's been updated in the 2nd patch (uploaded just now)

Oct 29 2020, 3:17 AM · Restricted Project
awarzynski updated the diff for D90300: [flang][driver] Rename the accessors (NFC).

Update the remaining accessors/mutators

Oct 29 2020, 3:13 AM · Restricted Project
awarzynski committed rZORG32826aace596: [flang] Switch from check-all to check-flang (authored by awarzynski).
[flang] Switch from check-all to check-flang
Oct 29 2020, 1:48 AM
awarzynski closed D90308: [flang] Switch from check-all to check-flang.
Oct 29 2020, 1:48 AM

Oct 28 2020

awarzynski updated the diff for D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).

Remove the diagnostic

Oct 28 2020, 1:36 PM · Restricted Project
awarzynski added a comment to D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).

Ping

Oct 28 2020, 10:30 AM · Restricted Project
awarzynski added reviewers for D90308: [flang] Switch from check-all to check-flang: CarolineConcatto, kiranchandramohan.
Oct 28 2020, 7:14 AM
awarzynski requested review of D90308: [flang] Switch from check-all to check-flang.
Oct 28 2020, 7:12 AM
awarzynski added reviewers for D90306: [flang][driver] Use --match-full-lines in tests for `-test-io`: CarolineConcatto, sameeranjoshi, SouraVX.
Oct 28 2020, 6:59 AM · Restricted Project
awarzynski requested review of D90306: [flang][driver] Use --match-full-lines in tests for `-test-io`.
Oct 28 2020, 6:44 AM · Restricted Project
awarzynski added reviewers for D90300: [flang][driver] Rename the accessors (NFC): CarolineConcatto, sameeranjoshi, kiranchandramohan.
Oct 28 2020, 5:00 AM · Restricted Project
awarzynski updated the diff for D90300: [flang][driver] Rename the accessors (NFC).

Restore changes made outside the driver

Oct 28 2020, 4:58 AM · Restricted Project
awarzynski requested review of D90300: [flang][driver] Rename the accessors (NFC).
Oct 28 2020, 4:50 AM · Restricted Project

Oct 27 2020

awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Rebase on top of master + rename accessor method

Oct 27 2020, 11:28 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Oct 27 2020, 9:59 AM · Restricted Project, Restricted Project

Oct 24 2020

awarzynski committed rGcbb7f1420b74: [flang][tests] Fix Python bug in the lit config (authored by awarzynski).
[flang][tests] Fix Python bug in the lit config
Oct 24 2020, 9:06 AM
awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Thank you all for your input! Before merging I took the liberty to rename NoClangOption as FlangOnlyOption. The new name reflects better what the flag is introduced for. Also, based on responses to [1], it is unlikely that it will be used beyond flang-only options. If that changes we can always rename it.

Oct 24 2020, 7:02 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O (authored by CarolineConcatto).
[Flang][Driver] Add infrastructure for basic frontend actions and file I/O
Oct 24 2020, 6:59 AM
awarzynski closed D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Oct 24 2020, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Oct 23 2020

awarzynski added inline comments to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:26 AM · Restricted Project, Restricted Project

Oct 22 2020

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Ping

Oct 22 2020, 4:04 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: richard.barton.arm.
Oct 22 2020, 4:04 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2020

awarzynski added a comment to D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).

Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here.

Oct 21 2020, 9:46 AM · Restricted Project

Oct 20 2020

awarzynski added a comment to D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points:

  • Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples attention. More importantly, should we add another tool to clang-tools-extra?
  • Tthis is a rather large patch - could you split it into separate chunks? Otherwise it's quite tricky to review.
Oct 20 2020, 1:17 PM · Restricted Project, Restricted Project
awarzynski edited reviewers for D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC), added: MaskRay, tra, rnk, hans; removed: jdoerfert.
Oct 20 2020, 12:51 PM · Restricted Project
awarzynski requested review of D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).
Oct 20 2020, 8:43 AM · Restricted Project

Oct 19 2020

awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Apply fix to unit test that got lost in the previous patch, simplify C input file

Oct 19 2020, 10:34 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Oct 19 2020, 10:24 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Address PR comments, make clearer separation between option types, simplify/fix tests

Oct 19 2020, 10:16 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Simplify the API for creating output files

Oct 19 2020, 6:14 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2020

awarzynski retitled D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction from [Flang][Driver]Add PrintPreprocessedInput action `-E` to [Flang][Driver] Add PrintPreprocessed FrontendAction.
Oct 16 2020, 7:57 AM · Restricted Project, Restricted Project
awarzynski commandeered D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments. Thank you for all the effort @CarolineConcatto !

Oct 16 2020, 7:53 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Rebase + refector the unit test

Oct 16 2020, 7:51 AM · Restricted Project, Restricted Project

Oct 15 2020

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

I've added more reviewers for the Clang side of this patch. I choose people who most recently changed the functions/files that this patch modifies. Any input much appreciated! For more context regarding Clang changes: http://lists.llvm.org/pipermail/cfe-dev/2020-October/066953.html

Oct 15 2020, 10:16 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added reviewers for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: rnk, hans, bkramer, yamaguchi.
Oct 15 2020, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Address PR comments, clang-format, rebase

Oct 15 2020, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski commandeered D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Thank you for reviewing @SouraVX! I'm just about to submit an updated patch with the requested changes.

Oct 15 2020, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski accepted D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.

Thanks for testing so extensively! LGTM!

Oct 15 2020, 3:57 AM · Restricted Project
awarzynski accepted D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.
Oct 15 2020, 2:34 AM · Restricted Project
awarzynski added a comment to D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.

Thank you for fixing this so quickly @serge-sans-paille , that's much appreciated!

Oct 15 2020, 2:34 AM · Restricted Project

Oct 14 2020

awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

The CMake error for flang-new is now fixed, but I'm no longer able to build Flang with BUILD_SHARED_LIBS=On. @serge-sans-paille , have you tested that configuration? I'm struggling to find a fix.

Oct 14 2020, 2:56 PM · Restricted Project
awarzynski committed rG42e89ab2a668: [flang] Fix CMake bug in the definition of flang-new (authored by awarzynski).
[flang] Fix CMake bug in the definition of flang-new
Oct 14 2020, 11:25 AM
awarzynski closed D89403: [flang] Fix CMake bug in the definition of flang-new.
Oct 14 2020, 11:25 AM · Restricted Project
awarzynski updated the diff for D89403: [flang] Fix CMake bug in the definition of flang-new.

Revert accidental and unnecessary change

Oct 14 2020, 9:50 AM · Restricted Project
awarzynski added reviewers for D89403: [flang] Fix CMake bug in the definition of flang-new: serge-sans-paille, DavidTruby.
Oct 14 2020, 9:49 AM · Restricted Project
awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

@serge-sans-paille Thank you for working on this! Sadly the Flang buildbot is unhappy again:http://lab.llvm.org:8014/#/builders/109/builds/35. I'm guessing that you didn't test with -DFLANG_BUILD_NEW_DRIVER=ON?

IIUC, the add_flang_tool macro needs fixing/updating. I'll take a look and submit something. Perhaps I'll need to revert the changes in flang/tools/flang-driver/CMakeLists.txt. in the interim.

Oct 14 2020, 9:49 AM · Restricted Project
awarzynski requested review of D89403: [flang] Fix CMake bug in the definition of flang-new.
Oct 14 2020, 9:48 AM · Restricted Project
awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

@serge-sans-paille Thank you for working on this! Sadly the Flang buildbot is unhappy again:http://lab.llvm.org:8014/#/builders/109/builds/35. I'm guessing that you didn't test with -DFLANG_BUILD_NEW_DRIVER=ON?

Oct 14 2020, 7:22 AM · Restricted Project

Oct 12 2020

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@reviewers A note regarding the changes in Clang.

Oct 12 2020, 2:26 AM · Restricted Project, Restricted Project, Restricted Project

Oct 9 2020

awarzynski committed rGdcd9be43e5c7: [mlir] Fix shared libs build (authored by awarzynski).
[mlir] Fix shared libs build
Oct 9 2020, 8:40 AM
awarzynski closed D89111: [mlir] Fix shared libs build.
Oct 9 2020, 8:39 AM · Restricted Project
awarzynski added a comment to D89111: [mlir] Fix shared libs build.

Sorry for breaking the bot :-/

Oct 9 2020, 8:05 AM · Restricted Project
awarzynski added reviewers for D89111: [mlir] Fix shared libs build: serge-sans-paille, mehdi_amini.
Oct 9 2020, 3:01 AM · Restricted Project
awarzynski added a comment to D88846: [mlir] Improve LLVM shlib support.

Hi @serge-sans-paille, thanks for working on this!

Oct 9 2020, 3:01 AM · Restricted Project
awarzynski requested review of D89111: [mlir] Fix shared libs build.
Oct 9 2020, 2:58 AM · Restricted Project
awarzynski committed rZORG6414deadea40: flang-aarch64: Refine the number of parallel jobs (authored by awarzynski).
flang-aarch64: Refine the number of parallel jobs
Oct 9 2020, 12:29 AM
awarzynski closed D89030: flang-aarch64: Refine the number of parallel jobs.
Oct 9 2020, 12:29 AM

Oct 8 2020

awarzynski added a comment to D88767: Show register names in DWARF unwind info..

@clayborg Our Flang-AArch64 buildbots have been failing due to this: http://lab.llvm.org:8011/#/builders/34/builds/13. Please, could this be either reverted or the other patch merged? Thanks!

I didn't see any failures on the llvm buildbots that email me when they fail. The other patch will be merged as soon as accepted. Should be tomorrow morning.

Thanks! I think that the buildbot master was restarted recently and hence our worker wasn't able to generate an accurate blamelist. Otherwise everything seems fine.

Fixed with https://reviews.llvm.org/D88940. Let me know if this fixes things on your end!

Oct 8 2020, 1:38 AM · Restricted Project
awarzynski added a reviewer for D89030: flang-aarch64: Refine the number of parallel jobs: CarolineConcatto.
Oct 8 2020, 1:35 AM
awarzynski requested review of D89030: flang-aarch64: Refine the number of parallel jobs.
Oct 8 2020, 1:34 AM

Oct 7 2020

awarzynski added a comment to D88767: Show register names in DWARF unwind info..

@clayborg Our Flang-AArch64 buildbots have been failing due to this: http://lab.llvm.org:8011/#/builders/34/builds/13. Please, could this be either reverted or the other patch merged? Thanks!

I didn't see any failures on the llvm buildbots that email me when they fail. The other patch will be merged as soon as accepted. Should be tomorrow morning.

Oct 7 2020, 1:30 AM · Restricted Project