Page MenuHomePhabricator
Feed Advanced Search

Today

dp accepted D143574: AMDGPU/MC: Fix decoders for VSrc_v2b32 and VSrc_v2f32 RegisterOperands.

LGTM.

Wed, Feb 8, 8:16 AM · Restricted Project, Restricted Project
dp accepted D143573: AMDGPU/MC: Add assembler tests for v2f32 and v2b32 with imm operand.
Wed, Feb 8, 8:15 AM · Restricted Project, Restricted Project
dp accepted D142194: [AMDGPU][AsmParser] Fix matching immediate literals..

LGTM, but I suggest moving the test to some other place. *_unsupported.s are used solely to test identification of unsupported opcodes. gfx7_err_pos.s may be a better place for this test.

Wed, Feb 8, 8:06 AM · Restricted Project, Restricted Project
dp added a comment to D142194: [AMDGPU][AsmParser] Fix matching immediate literals..

Is there a ticket to be mentioned in the commit message?

There is no ticket. I found this bug while analyzing your patch and trying to break the parser.

Wed, Feb 8, 8:00 AM · Restricted Project, Restricted Project
dp added inline comments to D143573: AMDGPU/MC: Add assembler tests for v2f32 and v2b32 with imm operand.
Wed, Feb 8, 7:49 AM · Restricted Project, Restricted Project

Tue, Jan 24

dp added a comment to D142194: [AMDGPU][AsmParser] Fix matching immediate literals..

Does your patch fix this bug?

Tue, Jan 24, 3:04 AM · Restricted Project, Restricted Project
dp added a comment to D142231: [AMDGPU][AsmParser] Forbid optional SMRD offsets on GFX6/GFX7..

I think that worked for CI only

Tue, Jan 24, 3:04 AM · Restricted Project, Restricted Project
dp added a comment to D142231: [AMDGPU][AsmParser] Forbid optional SMRD offsets on GFX6/GFX7..

The patch itself looks fine, but it breaks backward compatibility with existing code.
I think if you make offset mandatory for GFX6 and GFX7, the same should be done for other GPUs. But IMO preserving compatibility with existing code is more important.
BTW, have you noticed that SP3 does not allow 32-bit offsets with SMRD? LLVM assembler accepts these, but I do not know if HW can handle it.

Tue, Jan 24, 2:40 AM · Restricted Project, Restricted Project

Fri, Jan 13

dp accepted D141301: [AMDGPU][AsmParser][NFC] Refine defining single-bit custom operands..

LGTM.

Fri, Jan 13, 2:50 AM · Restricted Project, Restricted Project

Thu, Jan 12

dp accepted D140799: [AMDGPU][AsmParser][NFC] Refine defining i8- and i16-typed custom operands..

LGTM.

Thu, Jan 12, 10:42 AM · Restricted Project, Restricted Project
dp added inline comments to D140799: [AMDGPU][AsmParser][NFC] Refine defining i8- and i16-typed custom operands..
Thu, Jan 12, 5:48 AM · Restricted Project, Restricted Project

Tue, Jan 10

dp added inline comments to D141301: [AMDGPU][AsmParser][NFC] Refine defining single-bit custom operands..
Tue, Jan 10, 4:27 AM · Restricted Project, Restricted Project
dp added a comment to D140799: [AMDGPU][AsmParser][NFC] Refine defining i8- and i16-typed custom operands..

In general, I like your idea and I see that further improvements are possible. Your second patch seems to better justify this approach.

Tue, Jan 10, 4:24 AM · Restricted Project, Restricted Project

Jan 9 2023

dp accepted D141069: [AMDGPU][NFC] Rename GFX10A16 operands..

LGTM

Jan 9 2023, 2:58 AM · Restricted Project, Restricted Project

Dec 30 2022

dp committed rGe7a306310b0b: [AMDGPU][GFX11] Correct tied src2 of v_fmac_f16_e64 (authored by dp).
[AMDGPU][GFX11] Correct tied src2 of v_fmac_f16_e64
Dec 30 2022, 5:43 AM · Restricted Project, Restricted Project
dp closed D140299: [AMDGPU][GFX11] Correct tied src2 of v_fmac_f16_e64.
Dec 30 2022, 5:42 AM · Restricted Project, Restricted Project
dp committed rG9f40d9ffd186: [AMDGPU][MC][GFX11] Correct encoding of neg modifier for v_dot2_f32_bf16 (authored by dp).
[AMDGPU][MC][GFX11] Correct encoding of neg modifier for v_dot2_f32_bf16
Dec 30 2022, 5:26 AM · Restricted Project, Restricted Project
dp closed D140470: [AMDGPU][MC][GFX11] Correct encoding of neg modifier for v_dot2_f32_bf16.
Dec 30 2022, 5:25 AM · Restricted Project, Restricted Project

Dec 21 2022

dp requested review of D140470: [AMDGPU][MC][GFX11] Correct encoding of neg modifier for v_dot2_f32_bf16.
Dec 21 2022, 3:14 AM · Restricted Project, Restricted Project
dp committed rGb8e1071a2903: [AMDGPU][GFX11][DOC][NFC] Add GFX11 assembler syntax description (authored by dp).
[AMDGPU][GFX11][DOC][NFC] Add GFX11 assembler syntax description
Dec 21 2022, 1:56 AM · Restricted Project, Restricted Project

Dec 20 2022

dp committed rGd9daee5a6698: [AMDGPU][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][DOC][NFC] Update assembler syntax description
Dec 20 2022, 3:04 AM · Restricted Project, Restricted Project

Dec 19 2022

dp requested review of D140299: [AMDGPU][GFX11] Correct tied src2 of v_fmac_f16_e64.
Dec 19 2022, 6:06 AM · Restricted Project, Restricted Project

Dec 16 2022

dp accepted D140108: [AMDGPU][AsmParser] Refine parsing cache policy modifiers..

LGTM, thanks!

Dec 16 2022, 3:33 AM · Restricted Project, Restricted Project
dp added inline comments to D140108: [AMDGPU][AsmParser] Refine parsing cache policy modifiers..
Dec 16 2022, 3:07 AM · Restricted Project, Restricted Project

Dec 15 2022

dp accepted D140108: [AMDGPU][AsmParser] Refine parsing cache policy modifiers..

Very nice refactoring!

Dec 15 2022, 10:44 AM · Restricted Project, Restricted Project

Dec 13 2022

dp committed rGc27eded938f7: [AMDGPU][GFX1030][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX1030][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:51 AM · Restricted Project, Restricted Project
dp committed rGa1bd85cfc3b2: [AMDGPU][GFX1013][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX1013][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:46 AM · Restricted Project, Restricted Project
dp committed rG37e6f8402621: [AMDGPU][GFX10][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX10][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:39 AM · Restricted Project, Restricted Project
dp committed rGb19c26747f4e: [AMDGPU][GFX940][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX940][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:29 AM · Restricted Project, Restricted Project
dp committed rG0d0018e709ec: [AMDGPU][GFX90A][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX90A][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:22 AM · Restricted Project, Restricted Project
dp committed rG190eb50c8bb4: [AMDGPU][GFX908][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX908][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:15 AM · Restricted Project, Restricted Project
dp committed rGd8ac03f15e81: [AMDGPU][GFX9][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX9][DOC][NFC] Update assembler syntax description
Dec 13 2022, 3:06 AM · Restricted Project, Restricted Project
dp committed rG564d47db9eb0: [AMDGPU][GFX8][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX8][DOC][NFC] Update assembler syntax description
Dec 13 2022, 2:59 AM · Restricted Project, Restricted Project
dp committed rGcc426402bed6: [AMDGPU][GFX7][DOC][NFC] Update assembler syntax description (authored by dp).
[AMDGPU][GFX7][DOC][NFC] Update assembler syntax description
Dec 13 2022, 2:51 AM · Restricted Project, Restricted Project

Dec 9 2022

dp accepted D139646: AMDGPU: Check if operand RC contains register used when printing.

LGTM with a nit.

Dec 9 2022, 7:35 AM · Restricted Project, Restricted Project
dp added a comment to D139646: AMDGPU: Check if operand RC contains register used when printing.

Overall looks good.

Dec 9 2022, 5:30 AM · Restricted Project, Restricted Project

Dec 7 2022

dp added a comment to D139442: AMDGPU/MC: Make VReg and VISrc decoders more strict.

In most cases if instruction can't use some bits in encoding of an operand, those bits are set to default value in td file.

AFAIK, we use ? as a default value to allow disassembler ignore these bits.

Dec 7 2022, 6:07 AM · Restricted Project, Restricted Project
dp accepted D139527: [AMDGPU] Use SOP_Pseudo more consistently. NFC..

LGTM.

Dec 7 2022, 4:11 AM · Restricted Project, Restricted Project
dp added a comment to D139442: AMDGPU/MC: Make VReg and VISrc decoders more strict.

By design, disassembler should be able to decode invalid code when possible. It is much more helpful for the user to see something like this:

Dec 7 2022, 1:55 AM · Restricted Project, Restricted Project
dp added reviewers for D139442: AMDGPU/MC: Make VReg and VISrc decoders more strict: foad, Joe_Nash.
Dec 7 2022, 1:36 AM · Restricted Project, Restricted Project

Dec 6 2022

dp accepted D139412: [AMDGPU] Change handling of s_endpgm's optional operand. NFC..

LGTM.

Dec 6 2022, 9:22 AM · Restricted Project, Restricted Project
dp added inline comments to D139412: [AMDGPU] Change handling of s_endpgm's optional operand. NFC..
Dec 6 2022, 6:30 AM · Restricted Project, Restricted Project

Dec 5 2022

dp committed rG453eb9eb4281: [AMDGPU][MC] Correct handling of mandatory literals (authored by dp).
[AMDGPU][MC] Correct handling of mandatory literals
Dec 5 2022, 5:24 AM · Restricted Project, Restricted Project
dp closed D138661: [AMDGPU][MC] Correct handling of mandatory literals.
Dec 5 2022, 5:24 AM · Restricted Project, Restricted Project

Dec 2 2022

dp accepted D139194: AMDGPU/MC: Simplify AsmParser for VOP3P.

Nice refactoring!

Dec 2 2022, 5:59 AM · Restricted Project, Restricted Project

Dec 1 2022

dp updated the diff for D138661: [AMDGPU][MC] Correct handling of mandatory literals.

Update comment describing isSISrcOperand.

Dec 1 2022, 7:46 AM · Restricted Project, Restricted Project
dp abandoned D139101: [AMDGPU][NFC] Isolate KImm operands.
Dec 1 2022, 7:19 AM · Restricted Project, Restricted Project
dp added inline comments to D138661: [AMDGPU][MC] Correct handling of mandatory literals.
Dec 1 2022, 4:50 AM · Restricted Project, Restricted Project
dp requested review of D139101: [AMDGPU][NFC] Isolate KImm operands.
Dec 1 2022, 4:45 AM · Restricted Project, Restricted Project
dp updated the diff for D138661: [AMDGPU][MC] Correct handling of mandatory literals.

Rebase; update tests to add error line numbers.

Dec 1 2022, 3:45 AM · Restricted Project, Restricted Project

Nov 30 2022

dp committed rGf2d589ea46d8: [AMDGPU][MC][GFX11] Disable non-VGPR src operands for VOP3_DPP variants of fmac… (authored by dp).
[AMDGPU][MC][GFX11] Disable non-VGPR src operands for VOP3_DPP variants of fmac…
Nov 30 2022, 3:55 AM · Restricted Project, Restricted Project
dp closed D138710: [AMDGPU][MC][GFX11] Disable non-VGPR src operands for v_fmac_f16_e64_dpp and v_fmac_f32_e64_dpp instructions.
Nov 30 2022, 3:55 AM · Restricted Project, Restricted Project

Nov 29 2022

dp added inline comments to D138661: [AMDGPU][MC] Correct handling of mandatory literals.
Nov 29 2022, 11:19 AM · Restricted Project, Restricted Project
dp added inline comments to D138661: [AMDGPU][MC] Correct handling of mandatory literals.
Nov 29 2022, 10:00 AM · Restricted Project, Restricted Project
dp added inline comments to D138710: [AMDGPU][MC][GFX11] Disable non-VGPR src operands for v_fmac_f16_e64_dpp and v_fmac_f32_e64_dpp instructions.
Nov 29 2022, 9:04 AM · Restricted Project, Restricted Project
dp updated the diff for D138710: [AMDGPU][MC][GFX11] Disable non-VGPR src operands for v_fmac_f16_e64_dpp and v_fmac_f32_e64_dpp instructions.

Retitle and correct as suggested by Joe.

Nov 29 2022, 9:04 AM · Restricted Project, Restricted Project
dp committed rG9b8eb5fa8ef0: [AMDGPU][MC][GFX11] Correct op_sel handling for permlane*16 (authored by dp).
[AMDGPU][MC][GFX11] Correct op_sel handling for permlane*16
Nov 29 2022, 7:45 AM · Restricted Project, Restricted Project
dp closed D137969: [AMDGPU][MC][GFX11] Correct op_sel handling for permlane*16.
Nov 29 2022, 7:45 AM · Restricted Project, Restricted Project
dp committed rG869fc7eabd2a: [AMDGPU][MC][MI100+] Enable VOP3 variants of dot2c/dot4c/dot8c opcodes (authored by dp).
[AMDGPU][MC][MI100+] Enable VOP3 variants of dot2c/dot4c/dot8c opcodes
Nov 29 2022, 6:38 AM · Restricted Project, Restricted Project
dp closed D138494: [AMDGPU][MC][MI100+] Enable VOP3 variants of dot2c/dot4c/dot8c opcodes.
Nov 29 2022, 6:38 AM · Restricted Project, Restricted Project

Nov 25 2022

dp committed rGa0a0dc6f8baf: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values (authored by dp).
[AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values
Nov 25 2022, 7:02 AM · Restricted Project, Restricted Project
dp closed D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values.
Nov 25 2022, 7:02 AM · Restricted Project, Restricted Project
dp requested review of D138710: [AMDGPU][MC][GFX11] Disable non-VGPR src operands for v_fmac_f16_e64_dpp and v_fmac_f32_e64_dpp instructions.
Nov 25 2022, 6:30 AM · Restricted Project, Restricted Project
dp added a comment to D137969: [AMDGPU][MC][GFX11] Correct op_sel handling for permlane*16.

Ping.

Nov 25 2022, 1:30 AM · Restricted Project, Restricted Project

Nov 24 2022

dp requested review of D138661: [AMDGPU][MC] Correct handling of mandatory literals.
Nov 24 2022, 5:00 AM · Restricted Project, Restricted Project
dp updated the diff for D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values.

Correct as suggested by Jay.

Nov 24 2022, 1:45 AM · Restricted Project, Restricted Project
dp added inline comments to D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values.
Nov 24 2022, 1:44 AM · Restricted Project, Restricted Project

Nov 23 2022

dp updated the diff for D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values.

Corrected as suggested by Joe.
Joe, thanks for your valuable comments!

Nov 23 2022, 12:16 PM · Restricted Project, Restricted Project
dp requested review of D138594: [AMDGPU][MC] Refactor MC Code Emitter to avoid using magic values.
Nov 23 2022, 11:00 AM · Restricted Project, Restricted Project
dp accepted D138492: [AMDGPU][AsmParser] Refine parsing instruction operands..

LGTM. Nice improvements!

Nov 23 2022, 6:51 AM · Restricted Project, Restricted Project

Nov 22 2022

dp requested review of D138494: [AMDGPU][MC][MI100+] Enable VOP3 variants of dot2c/dot4c/dot8c opcodes.
Nov 22 2022, 6:25 AM · Restricted Project, Restricted Project

Nov 18 2022

dp committed rG96155bf44b59: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2) (authored by dp).
[AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2)
Nov 18 2022, 3:15 AM · Restricted Project, Restricted Project
dp closed D138133: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2).
Nov 18 2022, 3:15 AM · Restricted Project, Restricted Project

Nov 17 2022

dp updated the diff for D138133: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2).

Updated as suggested by Joe:

Nov 17 2022, 3:25 AM · Restricted Project, Restricted Project
dp added inline comments to D138133: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2).
Nov 17 2022, 3:24 AM · Restricted Project, Restricted Project

Nov 16 2022

dp added a comment to D138133: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2).

! In D137952, @Joe_Nash wrote:
Now I see that it does not iterate over MCInst operands. So clearly it is confusing :).
SrcIdx is an index into parsed src operands which is a subset of parsed operands.
So maybe these renames are most accurate:

getParsedSrcIndex -> getParsedOpIdxFromSrcIdx
SrcIdx -> CombinedSrcIdx
getParsedDstIndex -> getParsedOpIdxOfDst

In getRegIndicies
I think SrcIdx is acutally ComponentSrcIdx
Renames:
SrcIdx -> ComponentSrcIdx
getSrcIndex -> getCombinedMCSrcIdxFromComponentSrcIdx

obviously this is getting really verbose, but that's probably better than confusingly named.

Nov 16 2022, 6:53 AM · Restricted Project, Restricted Project
dp requested review of D138133: [AMDGPU][GFX11][NFC] Refactor VOPD operands handling (part 2).
Nov 16 2022, 6:51 AM · Restricted Project, Restricted Project
dp committed rGe468b1b740e5: [AMDGPU][GFX11] Refactor VOPD operands handling (authored by dp).
[AMDGPU][GFX11] Refactor VOPD operands handling
Nov 16 2022, 5:30 AM · Restricted Project, Restricted Project
dp closed D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.
Nov 16 2022, 5:29 AM · Restricted Project, Restricted Project

Nov 15 2022

dp updated the diff for D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.

Rebase.

Nov 15 2022, 5:00 AM · Restricted Project, Restricted Project
dp added a comment to D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.

I suggest doing renaming in a separate patch because it is a separate problem introduced before this change.

Nov 15 2022, 3:09 AM · Restricted Project, Restricted Project
dp updated the diff for D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.

Add a comment describing InstInfo::getRegIndices.

Nov 15 2022, 3:06 AM · Restricted Project, Restricted Project

Nov 14 2022

dp requested review of D137969: [AMDGPU][MC][GFX11] Correct op_sel handling for permlane*16.
Nov 14 2022, 11:04 AM · Restricted Project, Restricted Project
dp added a comment to D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.

Why does it change the error position?

Nov 14 2022, 10:41 AM · Restricted Project, Restricted Project
dp accepted D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores..

Still LGTM.

Nov 14 2022, 8:12 AM · Restricted Project, Restricted Project
dp accepted D137950: [AMDGPU][MC][NFC] Rename VOP3 VOPC test files.

LGTM.

Nov 14 2022, 7:36 AM · Restricted Project, Restricted Project
dp requested review of D137952: [AMDGPU][GFX11] Refactor VOPD operands handling.
Nov 14 2022, 7:30 AM · Restricted Project, Restricted Project
dp committed rGef6f3c76f7f4: [AMDGPU][MC][GFX11] Improve diagnostic messages for invalid VOPD syntax (authored by dp).
[AMDGPU][MC][GFX11] Improve diagnostic messages for invalid VOPD syntax
Nov 14 2022, 5:22 AM · Restricted Project, Restricted Project
dp closed D137842: [AMDGPU][MC][GFX11] Improve diagnostic messages for invalid VOPD syntax.
Nov 14 2022, 5:22 AM · Restricted Project, Restricted Project

Nov 11 2022

dp added inline comments to D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores..
Nov 11 2022, 1:24 PM · Restricted Project, Restricted Project
dp accepted D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores..

LGTM, thanks!

Nov 11 2022, 11:53 AM · Restricted Project, Restricted Project
dp accepted D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores..

LGTM.

Nov 11 2022, 11:51 AM · Restricted Project, Restricted Project
dp added inline comments to D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores..
Nov 11 2022, 8:44 AM · Restricted Project, Restricted Project
dp added inline comments to D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores..
Nov 11 2022, 8:35 AM · Restricted Project, Restricted Project
dp added a comment to D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores..

The currently reported position is the beginning of the first operand and in the current design there seems to be no way to do better

Nov 11 2022, 7:39 AM · Restricted Project, Restricted Project
dp requested review of D137842: [AMDGPU][MC][GFX11] Improve diagnostic messages for invalid VOPD syntax.
Nov 11 2022, 7:11 AM · Restricted Project, Restricted Project
dp added a comment to D137832: [AMDGPU][AsmParser] Forbid TFE modifiers for MBUF stores..

Could you add a test to check the reported error position? Unfortunately, AsmMatcher often fails to report the location of offending operand. Moving the check to validator may improve diagnostic by using getImmLoc.

Nov 11 2022, 6:27 AM · Restricted Project, Restricted Project
dp added inline comments to D137783: [AMDGPU][MC] Support TFE modifiers in MUBUF loads and stores..
Nov 11 2022, 3:24 AM · Restricted Project, Restricted Project
dp committed rG05baf681a3c2: [AMDGPU][MC] Disable SGPRs as src operands of VOP3 VINTRP instructions (authored by dp).
[AMDGPU][MC] Disable SGPRs as src operands of VOP3 VINTRP instructions
Nov 11 2022, 2:21 AM · Restricted Project, Restricted Project
dp closed D137575: [AMDGPU][MC] Disable SGPRs as src operands of VOP3 VINTRP instructions.
Nov 11 2022, 2:21 AM · Restricted Project, Restricted Project