Page MenuHomePhabricator
Feed Advanced Search

May 17 2018

waltl committed rL332681: [sanitizer] Trivial portion of the port to Myriad RTEMS.
[sanitizer] Trivial portion of the port to Myriad RTEMS
May 17 2018, 5:48 PM
waltl committed rCRT332681: [sanitizer] Trivial portion of the port to Myriad RTEMS.
[sanitizer] Trivial portion of the port to Myriad RTEMS
May 17 2018, 5:47 PM
waltl closed D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 17 2018, 5:47 PM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Address CR comments

May 17 2018, 5:12 PM
waltl added inline comments to D46451: [asan] Add instrumentation support for Myriad.
May 17 2018, 4:23 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 17 2018, 2:37 PM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Address CR comments

May 17 2018, 2:29 PM
waltl abandoned D46466: [asan] Add AsanThread::Restart() to support thread restart.
May 17 2018, 12:29 PM
waltl added a comment to D46466: [asan] Add AsanThread::Restart() to support thread restart.

Ah, right, it is private. Use stack_top() and stack_bottom() then, they are public.

May 17 2018, 12:28 PM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Completely move thread restart support to asan_rtems.cc.

May 17 2018, 12:26 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 17 2018, 12:01 PM
waltl added inline comments to D46468: [asan] Add target-specific files for Myriad RTEMS port.
May 17 2018, 11:48 AM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Fix kHighMemEnd init and removed a stale comment

May 17 2018, 11:47 AM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Fixes to support changing the shadow scale.

May 17 2018, 11:17 AM
waltl updated the diff for D46451: [asan] Add instrumentation support for Myriad.

Fixes to support changing the shadow scale

May 17 2018, 11:16 AM
waltl committed rL332635: [sanitizer] Don't add --export-dynamic for Myriad.
[sanitizer] Don't add --export-dynamic for Myriad
May 17 2018, 11:08 AM
waltl committed rC332635: [sanitizer] Don't add --export-dynamic for Myriad.
[sanitizer] Don't add --export-dynamic for Myriad
May 17 2018, 11:08 AM
waltl closed D46452: [sanitizer] Don't add --export-dynamic for Myriad.
May 17 2018, 11:08 AM
waltl updated the diff for D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.

Update #endif markers

May 17 2018, 4:56 AM

May 16 2018

waltl updated the diff for D46452: [sanitizer] Don't add --export-dynamic for Myriad.

Address CR comments

May 16 2018, 9:01 PM
waltl added inline comments to D46466: [asan] Add AsanThread::Restart() to support thread restart.
May 16 2018, 8:14 PM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Sync with CR comments from other patches

May 16 2018, 8:11 PM
waltl updated the diff for D46466: [asan] Add AsanThread::Restart() to support thread restart.

Address CR comments

May 16 2018, 8:11 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 16 2018, 7:32 PM
waltl updated the summary of D46456: [asan] Add support for Myriad RTEMS memory map.
May 16 2018, 7:29 PM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Address CR comments

May 16 2018, 7:28 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 16 2018, 6:45 PM
waltl added inline comments to D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 16 2018, 5:54 PM
waltl updated the diff for D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.

Address CR comments

May 16 2018, 5:50 PM
waltl committed rL332557: [asan] Add a magic shadow value for shadw gap.
[asan] Add a magic shadow value for shadw gap
May 16 2018, 4:39 PM
waltl committed rCRT332557: [asan] Add a magic shadow value for shadw gap.
[asan] Add a magic shadow value for shadw gap
May 16 2018, 4:39 PM
waltl closed D46457: [asan] Add a magic shadow value for shadw gap.
May 16 2018, 4:39 PM
waltl committed rL332553: [asan] Restore check removed by r332033.
[asan] Restore check removed by r332033
May 16 2018, 4:27 PM
waltl committed rCRT332553: [asan] Restore check removed by r332033.
[asan] Restore check removed by r332033
May 16 2018, 4:27 PM
waltl closed D46981: [asan] Restore check removed by r332033.
May 16 2018, 4:27 PM
waltl created D46981: [asan] Restore check removed by r332033.
May 16 2018, 3:25 PM
waltl added inline comments to D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 16 2018, 8:24 AM

May 11 2018

waltl committed rL332157: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.
[sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS
May 11 2018, 4:56 PM
waltl committed rCRT332157: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.
[sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS
May 11 2018, 4:56 PM
waltl closed D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.
May 11 2018, 4:56 PM
waltl closed D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.
May 11 2018, 4:56 PM
waltl added a comment to D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.

LGTM assuming the Fuchsia build still works (I don't see any problems in the source off hand).
@jakehehrlich will verify the Fuchsia Build.

May 11 2018, 4:46 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 4:43 PM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Initialize kHighMemEnd in InitializeShadowMemory.

May 11 2018, 4:40 PM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Address CR comments

May 11 2018, 4:40 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 12:54 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 12:12 PM
waltl added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 8:52 AM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Rebase.

May 11 2018, 8:32 AM

May 10 2018

waltl committed rL332047: [asan] Enable memtrinsics interception for RTEMS.
[asan] Enable memtrinsics interception for RTEMS
May 10 2018, 2:49 PM
waltl committed rCRT332047: [asan] Enable memtrinsics interception for RTEMS.
[asan] Enable memtrinsics interception for RTEMS
May 10 2018, 2:48 PM
waltl closed D46625: [asan] Enable memtrinsics interception for RTEMS.
May 10 2018, 2:48 PM
waltl committed rL332046: [sanitizer] Port fast stack unwinder to sparcv8.
[sanitizer] Port fast stack unwinder to sparcv8
May 10 2018, 2:44 PM
waltl committed rCRT332046: [sanitizer] Port fast stack unwinder to sparcv8.
[sanitizer] Port fast stack unwinder to sparcv8
May 10 2018, 2:44 PM
waltl closed D46469: [sanitizer] Port fast stack unwinder to sparcv8.
May 10 2018, 2:44 PM
waltl added a comment to D46466: [asan] Add AsanThread::Restart() to support thread restart.

It's called by __sanitizer_thread_start_hook() defined in asan_rtems.cc (See https://reviews.llvm.org/D46468), which in turn will be call by RTEMS, in the code that starts/restarts a thread.

May 10 2018, 2:41 PM
waltl committed rCRT332033: [asan] Initialize fake stack during thread init.
[asan] Initialize fake stack during thread init
May 10 2018, 1:13 PM
waltl committed rL332033: [asan] Initialize fake stack during thread init.
[asan] Initialize fake stack during thread init
May 10 2018, 1:12 PM
waltl closed D46626: [asan] Initialize fake stack during thread init.
May 10 2018, 1:12 PM
waltl abandoned D46467: [asan] Add argument to allow fake stack to be initialized during thread init.

Obsolete.

May 10 2018, 11:14 AM

May 9 2018

waltl added inline comments to D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 9 2018, 2:03 PM
waltl updated the summary of D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 9 2018, 2:02 PM
waltl updated the diff for D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.

Disable preinit array -- we don't need it.

May 9 2018, 2:02 PM

May 8 2018

waltl added a comment to D46467: [asan] Add argument to allow fake stack to be initialized during thread init.
In D46467#1088573, @kcc wrote:

What if we try to just always call AsyncSignalSafeLazyInitFakeStack here?
There used to be a reason why this was done lazily, but I don't remember if we still have that reason.

That would be great. I can prepare a commit for that.

May 8 2018, 9:13 PM
waltl updated the summary of D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.
May 8 2018, 9:12 PM
waltl updated the summary of D46451: [asan] Add instrumentation support for Myriad.
May 8 2018, 9:08 PM
waltl created D46626: [asan] Initialize fake stack during thread init.
May 8 2018, 8:48 PM
waltl created D46625: [asan] Enable memtrinsics interception for RTEMS.
May 8 2018, 8:48 PM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Update call to AsanThread::Init() to reflect reverted change.

May 8 2018, 8:43 PM
waltl updated the summary of D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 8 2018, 8:06 PM
waltl added inline comments to D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 8 2018, 8:05 PM
waltl updated the diff for D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.

Remove asan_interceptors_memintrinsics.cc change (with the
controversial header). Will propose something else in a separate
patch.

May 8 2018, 8:03 PM
waltl added a comment to D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.

I'd prefer to keep all the markup string constants together. Moving them all to a header would be fine, but I think it should be a separate sanitizer_symbolizer_fuchsia.h so that non-Fuchsia builds aren't using symbolizer_fuchsia.h, which is about OS-specific stuff distinct from the symbolizer markup format. But nothing in this patch actually needs the constant to be visible outside sanitizer_symbolizer_fuchsia.cc, so I'd like to see some explanation of the need for that.

I'd be very glad to see a more thorough refactoring to make the symbolizer markup an option independent of OS. I think renaming symbolizer_fuchsia* to symbolizer_markup* probably makes sense. Ideally we'd nicely support both the Fuchsia/RTEMS configs where we want to support only markup and not have OS dependencies for things like files and subprocesses the other symbolizer code has; and also make markup a runtime selectable option for symbolizer style for the other OS builds that today have several runtime selectable choices.

May 8 2018, 3:48 PM
waltl updated the diff for D46462: [sanitizer] Allow Fuchsia symbolizer to be reused by Myriad RTEMS.

Address CR comments

May 8 2018, 3:41 PM
waltl updated the diff for D46469: [sanitizer] Port fast stack unwinder to sparcv8.

Move sparc support for fast stack unwinding into separate file

May 8 2018, 2:24 PM
waltl updated the diff for D46456: [asan] Add support for Myriad RTEMS memory map.

Move Myriad memory mapping definitions to its own file.

May 8 2018, 1:29 PM
waltl added inline comments to D46451: [asan] Add instrumentation support for Myriad.
May 8 2018, 1:23 PM
waltl updated the diff for D46451: [asan] Add instrumentation support for Myriad.

Revert Myraid special case code for whether report error function
can recover, and minor cleanups.

May 8 2018, 1:22 PM
waltl added a comment to D46571: [asan] Fix bug introduced by r331647.

Commited as r331737.

May 8 2018, 10:34 AM
waltl closed D46571: [asan] Fix bug introduced by r331647.
May 8 2018, 10:32 AM

May 7 2018

waltl committed rL331737: [asan] Fix bug introduced by r331647.
[asan] Fix bug introduced by r331647
May 7 2018, 11:02 PM
waltl committed rCRT331737: [asan] Fix bug introduced by r331647.
[asan] Fix bug introduced by r331647
May 7 2018, 11:02 PM
waltl created D46571: [asan] Fix bug introduced by r331647.
May 7 2018, 10:55 PM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Add __sanitizer_early_init() to initialize shadow memory; small
cleanups.

May 7 2018, 8:25 PM
waltl updated the diff for D46459: [asan] Make GetCurrentThread RTEMS-friendly.

Rely on early init of shadow memory, so now we can remove most checks.
2 are left.

May 7 2018, 8:21 PM
waltl added a comment to D46467: [asan] Add argument to allow fake stack to be initialized during thread init.
In D46467#1088573, @kcc wrote:

What if we try to just always call AsyncSignalSafeLazyInitFakeStack here?
There used to be a reason why this was done lazily, but I don't remember if we still have that reason.

May 7 2018, 3:45 PM
waltl committed rL331649: [asan] Port asan_malloc_linux.cc to RTEMS.
[asan] Port asan_malloc_linux.cc to RTEMS
May 7 2018, 9:42 AM
waltl committed rCRT331649: [asan] Port asan_malloc_linux.cc to RTEMS.
[asan] Port asan_malloc_linux.cc to RTEMS
May 7 2018, 9:42 AM
waltl closed D46465: [asan] Port asan_malloc_linux.cc to RTEMS.
May 7 2018, 9:42 AM
waltl committed rCRT331648: [sanitizer] On RTEMS, avoid recursion when reporting Mmap failure.
[sanitizer] On RTEMS, avoid recursion when reporting Mmap failure
May 7 2018, 9:42 AM
waltl committed rL331648: [sanitizer] On RTEMS, avoid recursion when reporting Mmap failure.
[sanitizer] On RTEMS, avoid recursion when reporting Mmap failure
May 7 2018, 9:42 AM
waltl closed D46463: [sanitizer] On RTEMS, avoid recursion when reporting Mmap failure.
May 7 2018, 9:42 AM
waltl committed rCRT331647: [asan] Set flags appropriately for RTEMS.
[asan] Set flags appropriately for RTEMS
May 7 2018, 9:42 AM
waltl committed rL331647: [asan] Set flags appropriately for RTEMS.
[asan] Set flags appropriately for RTEMS
May 7 2018, 9:42 AM
waltl closed D46461: [asan] Set flags appropriately for RTEMS.
May 7 2018, 9:41 AM
waltl committed rL331646: [sanitizer] Add definitions for Myriad RTEMS platform.
[sanitizer] Add definitions for Myriad RTEMS platform
May 7 2018, 9:41 AM
waltl committed rCRT331646: [sanitizer] Add definitions for Myriad RTEMS platform.
[sanitizer] Add definitions for Myriad RTEMS platform
May 7 2018, 9:41 AM
waltl closed D46453: [sanitizer] Add definitions for Myriad RTEMS platform.
May 7 2018, 9:41 AM
waltl updated the diff for D46468: [asan] Add target-specific files for Myriad RTEMS port.

Address CR comments from other patches

May 7 2018, 8:57 AM
waltl updated the diff for D46466: [asan] Add AsanThread::Restart() to support thread restart.

Address CR comments.

May 7 2018, 8:55 AM