Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Leporacanthicus added a reviewer for D129196: [flang]Fix incorrect array type transformation: clementval.
Wed, Jul 6, 6:04 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D129196: [flang]Fix incorrect array type transformation: jeanPerier, kiranchandramohan, awarzynski.
Wed, Jul 6, 6:02 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D129196: [flang]Fix incorrect array type transformation.
Wed, Jul 6, 5:54 AM · Restricted Project, Restricted Project

Thu, Jun 23

Leporacanthicus added inline comments to D125407: Prepare for inlining of SUM intrinsic.
Thu, Jun 23, 9:41 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D125407: Prepare for inlining of SUM intrinsic.

Updates in this revision:

  • Implement shape detection (so only work on 1D arrays)
  • Fix off-by-one error in loop (found when testing on SNAP)
  • Fix some review comments
  • Rebase to llvm/main instead of fir-dev
Thu, Jun 23, 9:20 AM · Restricted Project, Restricted Project

Fri, Jun 17

Leporacanthicus accepted D128017: [Flang] Fixes for XArrayCoorOp.

LGTM.
Tested locally, works for me!

Fri, Jun 17, 10:06 AM · Restricted Project, Restricted Project

Mon, Jun 13

Leporacanthicus accepted D127249: [Flang][OpenMP] Avoid double privatisation of loop variables.
Mon, Jun 13, 9:23 AM · Restricted Project, Restricted Project

Fri, Jun 10

Leporacanthicus updated the summary of D127240: [flang]Add support for do concurrent.
Fri, Jun 10, 9:58 AM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D127240: [flang]Add support for do concurrent.
Fri, Jun 10, 9:42 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D127240: [flang]Add support for do concurrent.

Updated commit message.

Fri, Jun 10, 9:41 AM · Restricted Project, Restricted Project

Wed, Jun 8

Leporacanthicus updated the diff for D127240: [flang]Add support for do concurrent.

Fix broken test

Wed, Jun 8, 11:30 AM · Restricted Project, Restricted Project

Tue, Jun 7

Leporacanthicus added reviewers for D127240: [flang]Add support for do concurrent: kiranchandramohan, vdonaldson, clementval.
Tue, Jun 7, 11:35 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D127240: [flang]Add support for do concurrent.
Tue, Jun 7, 11:34 AM · Restricted Project, Restricted Project

May 31 2022

Leporacanthicus updated the diff for D126711: [flang][OpenMP]Make omp.wsloop arguments appear in memory (#1277).

Removed references to fir-dev issue numbers.

May 31 2022, 10:54 AM · Restricted Project, Restricted Project
Leporacanthicus added reviewers for D126711: [flang][OpenMP]Make omp.wsloop arguments appear in memory (#1277): schweitz, kiranchandramohan, peixin, arnamoy10, shraiysh.
May 31 2022, 10:51 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D126711: [flang][OpenMP]Make omp.wsloop arguments appear in memory (#1277).
May 31 2022, 10:49 AM · Restricted Project, Restricted Project

May 30 2022

Leporacanthicus updated the diff for D126383: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree.

Removed some unnecessary test-lines [testing for variables used nowhere else
and constants used to set up the I/O, where the call itself is not tested]

May 30 2022, 3:40 AM · Restricted Project, Restricted Project

May 26 2022

Leporacanthicus updated the diff for D126383: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree.

Update test to MLIR

May 26 2022, 4:02 AM · Restricted Project, Restricted Project

May 25 2022

Leporacanthicus added reviewers for D126383: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree: kiranchandramohan, peixin, shraiysh.
May 25 2022, 8:02 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D126383: [OpenMP] Pass chunk-size to MLIR while lowering from parse-tree.
May 25 2022, 7:59 AM · Restricted Project, Restricted Project

May 18 2022

Leporacanthicus added inline comments to D125302: [flang][OpenMP] Support for Collapse.
May 18 2022, 10:02 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D125302: [flang][OpenMP] Support for Collapse.

Add assert for bounds back in, remove if-statment. This puts the code in
the new loop back to how the code was before the loop.

May 18 2022, 9:57 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D125302: [flang][OpenMP] Support for Collapse.

Replace if with assert, as it was in earlier code (before the loop was added)

May 18 2022, 9:54 AM · Restricted Project, Restricted Project

May 13 2022

Leporacanthicus added a comment to D125302: [flang][OpenMP] Support for Collapse.

LGTM with comments addressed. Thanks!

May 13 2022, 12:11 PM · Restricted Project, Restricted Project

May 12 2022

Leporacanthicus added inline comments to D125302: [flang][OpenMP] Support for Collapse.
May 12 2022, 11:13 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D125302: [flang][OpenMP] Support for Collapse.

Update for review comments

May 12 2022, 11:08 AM · Restricted Project, Restricted Project

May 11 2022

Leporacanthicus added a comment to D125407: Prepare for inlining of SUM intrinsic.

Just some quick skimming through, I had a few comments, hope this helps! :)

May 11 2022, 2:24 PM · Restricted Project, Restricted Project
Leporacanthicus requested review of D125407: Prepare for inlining of SUM intrinsic.
May 11 2022, 11:48 AM · Restricted Project, Restricted Project

May 10 2022

Leporacanthicus added reviewers for D125302: [flang][OpenMP] Support for Collapse: kiranchandramohan, shraiysh, peixin.
May 10 2022, 3:59 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D125302: [flang][OpenMP] Support for Collapse.
May 10 2022, 3:45 AM · Restricted Project, Restricted Project

Apr 14 2022

Leporacanthicus retitled D123788: [flang][RFC][WIP} Inline sum - not ready to use from [flang][RFC] Inline sum - not ready to use to [flang][RFC][WIP} Inline sum - not ready to use.
Apr 14 2022, 5:58 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D123788: [flang][RFC][WIP} Inline sum - not ready to use.
Apr 14 2022, 5:54 AM · Restricted Project, Restricted Project

Apr 8 2022

Leporacanthicus updated subscribers of D123416: [flang][runtime] Prefer process time over thread time in CPU_TIME.
Apr 8 2022, 11:52 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D123416: [flang][runtime] Prefer process time over thread time in CPU_TIME.
Apr 8 2022, 11:30 AM · Restricted Project, Restricted Project

Apr 1 2022

Leporacanthicus added inline comments to D120999: [flang] Update the plugin API.
Apr 1 2022, 3:38 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus accepted D122008: [flang][driver] Add support for generating executables.

LGTM

Apr 1 2022, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

Leporacanthicus added a comment to D122441: [flang] Add & use a better visit().

I have left my machine to compile that file over night, to see if it's a genuine hang or just "takes a very long time" - if it's not finished by tomorrow morning, I'm definitely calling it a hang. I will report back tomorrow on the result of that.

Mar 30 2022, 4:34 AM · Restricted Project, Restricted Project

Mar 29 2022

Leporacanthicus added a comment to D122441: [flang] Add & use a better visit().

We did some more digging and it looks like a Clang 13 issue. On AArch64, both Clang 12 and Clang 14 are fine. I believe that @Leporacanthicus was also able to reproduce this with Clang 13 on X86.

Mar 29 2022, 11:53 AM · Restricted Project, Restricted Project

Jan 27 2022

Leporacanthicus accepted D118381: [flang][driver][nfc] Fix capitalisation.

LGTM

Jan 27 2022, 9:22 AM · Restricted Project, Restricted Project

Dec 8 2021

Leporacanthicus accepted D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder..

LGTM. Just one nit-pick, there's a few new tests that test some pretty specific things. Would be nice to have a line or three about what they actually test - e.g "Tests that destructor is not called until after OpenMP section has completed".

Dec 8 2021, 2:58 AM · Restricted Project

Nov 26 2021

Leporacanthicus added inline comments to D111051: [mlir][OpenMP] Add support for SIMD modifier.
Nov 26 2021, 6:49 AM · Restricted Project, Restricted Project

Nov 23 2021

Leporacanthicus added inline comments to D114331: [OMPIRBuilder] Fix static schedule in worksharing-loop directive.
Nov 23 2021, 9:53 AM · Restricted Project, Restricted Project

Nov 22 2021

Leporacanthicus added a comment to D114331: [OMPIRBuilder] Fix static schedule in worksharing-loop directive.

Generally looks good to me. Just one nit-pick and one "I don't really understand how this actually produces the correct result" (may be that I'm just missing something!)

Nov 22 2021, 6:10 AM · Restricted Project, Restricted Project

Nov 17 2021

Leporacanthicus added inline comments to D111051: [mlir][OpenMP] Add support for SIMD modifier.
Nov 17 2021, 9:46 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D111051: [mlir][OpenMP] Add support for SIMD modifier.

Make simd_modifier a unit-attribute and fix formatting

Nov 17 2021, 9:42 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D111051: [mlir][OpenMP] Add support for SIMD modifier.

Fix review comments

Nov 17 2021, 8:04 AM · Restricted Project, Restricted Project

Nov 3 2021

Leporacanthicus abandoned D112526: [mlir][OpenMP]Improve OpenMP schedule modifier error checking and tests.

As this is now squashed into D111051, this review is no longer required.

Nov 3 2021, 5:30 AM · Restricted Project
Leporacanthicus updated the diff for D111051: [mlir][OpenMP] Add support for SIMD modifier.

Squashed the "fixes" commit and the original commit

Nov 3 2021, 5:15 AM · Restricted Project, Restricted Project

Nov 1 2021

Leporacanthicus added a comment to D111051: [mlir][OpenMP] Add support for SIMD modifier.

BUMP.

Nov 1 2021, 10:39 AM · Restricted Project, Restricted Project

Oct 26 2021

Leporacanthicus added inline comments to D111051: [mlir][OpenMP] Add support for SIMD modifier.
Oct 26 2021, 4:33 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D111051: [mlir][OpenMP] Add support for SIMD modifier.

Update to match changes in dependent commit (+ rebase)

Oct 26 2021, 4:29 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D112526: [mlir][OpenMP]Improve OpenMP schedule modifier error checking and tests.
Oct 26 2021, 4:28 AM · Restricted Project

Oct 21 2021

Leporacanthicus updated the diff for D111053: [mlir][OpenMP]Support for modifiers in workshare loops.

Rebase to latest llvm/main

Oct 21 2021, 9:19 AM · Restricted Project

Oct 18 2021

Leporacanthicus accepted D111980: [Flang][flang-omp-report] Switch from std::string to StringRef (where possible).

LGTM

Oct 18 2021, 4:15 AM · Restricted Project, Restricted Project

Oct 14 2021

Leporacanthicus accepted D111796: [fir] Add IfBuilder and utility functions.

Looks OK to me, but please don't merge until someone else also approves.

Oct 14 2021, 6:52 AM · Restricted Project, Restricted Project

Oct 13 2021

Leporacanthicus accepted D111709: [Flang] flang-omp-report replace std::vector's with llvm::SmallVector.

LGTM.

Oct 13 2021, 7:04 AM · Restricted Project, Restricted Project
Leporacanthicus added inline comments to D111053: [mlir][OpenMP]Support for modifiers in workshare loops.
Oct 13 2021, 3:12 AM · Restricted Project

Oct 12 2021

Leporacanthicus added inline comments to D111053: [mlir][OpenMP]Support for modifiers in workshare loops.
Oct 12 2021, 10:31 AM · Restricted Project
Leporacanthicus updated the diff for D111053: [mlir][OpenMP]Support for modifiers in workshare loops.

Updating according to review comments

Oct 12 2021, 10:31 AM · Restricted Project
Leporacanthicus added inline comments to D111573: [Flang][driver] Update docs.
Oct 12 2021, 3:18 AM · Restricted Project, Restricted Project

Oct 11 2021

Leporacanthicus accepted D111308: [flang][driver] Add actions that execute despite semantic errors.

LGTM

Oct 11 2021, 2:35 AM · Restricted Project, Restricted Project

Oct 4 2021

Leporacanthicus requested review of D111053: [mlir][OpenMP]Support for modifiers in workshare loops.
Oct 4 2021, 6:11 AM · Restricted Project
Leporacanthicus updated the diff for D111051: [mlir][OpenMP] Add support for SIMD modifier.

Trying to get two commits in one arcanist command - may not work

Oct 4 2021, 5:51 AM · Restricted Project, Restricted Project
Leporacanthicus requested review of D111051: [mlir][OpenMP] Add support for SIMD modifier.
Oct 4 2021, 5:48 AM · Restricted Project, Restricted Project

Sep 2 2021

Leporacanthicus accepted D109108: [flang] Use CMake to determine endianness..

Ah, this definitely would make "random" values for floating point values - in weird ways that are hard to understand!

Sep 2 2021, 6:59 AM · Restricted Project, Restricted Project

Aug 24 2021

Leporacanthicus added a comment to D108622: [flang] Implement Posix version of DATE_AND_TIME runtime.

Looks like it's doing what's needed. Is there a follow-on patch to fix the fact that values isn't being passed to the DATE_AND_TIME subroutine?

Do you mean a patch in lowering ?

If so, yes, once this is up streamed, lowering will be updated.

Aug 24 2021, 7:48 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D108622: [flang] Implement Posix version of DATE_AND_TIME runtime.

Looks like it's doing what's needed. Is there a follow-on patch to fix the fact that values isn't being passed to the DATE_AND_TIME subroutine?

Aug 24 2021, 5:00 AM · Restricted Project, Restricted Project

Aug 17 2021

Leporacanthicus accepted D108051: [flang] Add missing call to BeginReadingRecord().

(Sorry, I thought I'd approved it yesterday, but clearly didn't click the submit button!)

Aug 17 2021, 7:34 AM · Restricted Project, Restricted Project

Aug 13 2021

Leporacanthicus added a comment to D106538: [flang][OpenMP] Add semantic check for cancellation nesting.

It would seem that your patch may have broken some builds:
https://lab.llvm.org/buildbot/#/builders/175/builds/2077

Aug 13 2021, 9:44 AM · Restricted Project

Aug 5 2021

Leporacanthicus added a comment to D107575: [Flang] Ported test_errors.sh to Python.

There seems to be a problem in how import common not finding common.py in a sibling directory.

vsnprintf is named _vsnprintf by Microsoft. According to their docs, it should also be available as vsnprintf with

#include <stdio.h>
#include <stdarg.h>

but even Google test uses

#if GTEST_OS_WINDOWS
# define vsnprintf _vsnprintf
#endif  // GTEST_OS_WINDOWS
Aug 5 2021, 11:22 AM · Restricted Project

Jul 29 2021

Leporacanthicus added a comment to D105706: [mlir] support collapsed loops in OpenMP-to-LLVM translation.

Thanks for the updated patch, this seems to work for my simple use-case.

Jul 29 2021, 7:20 AM · Restricted Project

Jul 27 2021

Leporacanthicus added a comment to D105706: [mlir] support collapsed loops in OpenMP-to-LLVM translation.

Calling collapseLoops in convertOmpWsLoop sets the AfterIP to the wrong place - this causes incorrect LLVM-IR to be generated - an empty block and one with two unconditional branches in a row, like this:

Where does AfterIP point to and where do you think it should point to after collapseLoops? Should the result of collapseLoops be changed or is it an issue of how convertOmpWsLoop uses CanonicalLoopInfo?

Jul 27 2021, 4:06 AM · Restricted Project

Jul 26 2021

Leporacanthicus added a comment to D105706: [mlir] support collapsed loops in OpenMP-to-LLVM translation.

Sorry for the rather lengthy comment. I am not sure if I'm expecting the wrong thing, I'm doing something wrong, or this patch is incorrect, so I'll try to put as much information into this comment as I can.
Any suggestions, hints or similar would be welcome. I fully expect some of my workarounds and fixes to be called out as wrong - and I don't mean my global variable, which is clearly just a workaround for not understanding how to get the correct value out of where it is known.

Jul 26 2021, 9:57 AM · Restricted Project

Jul 21 2021

Leporacanthicus accepted D106428: [flang][driver] Make `flang` ignore `-Mfree/-Mfixed`.

LGTM

Jul 21 2021, 2:45 AM · Restricted Project, Restricted Project

Jul 16 2021

Leporacanthicus added inline comments to D105706: [mlir] support collapsed loops in OpenMP-to-LLVM translation.
Jul 16 2021, 12:00 PM · Restricted Project
Leporacanthicus added inline comments to D105706: [mlir] support collapsed loops in OpenMP-to-LLVM translation.
Jul 16 2021, 6:15 AM · Restricted Project

Jul 13 2021

Leporacanthicus added inline comments to D105885: Enable Flang by default in the test-release.sh script.
Jul 13 2021, 4:40 AM · Restricted Project

Jul 9 2021

Leporacanthicus accepted D105546: [flang][driver] Fix how output filename is generated.
Jul 9 2021, 7:34 AM · Restricted Project, Restricted Project

Jun 17 2021

Leporacanthicus accepted D103177: [flang][driver] Extend the `flang` bash script to act as a driver.

Some minor nit-picks, but nothing wrong - I tested this with some of my fortran code that I've been using for other testing, and it seems to work.

Jun 17 2021, 4:26 AM · Restricted Project, Restricted Project

Jun 2 2021

Leporacanthicus added a comment to D103177: [flang][driver] Extend the `flang` bash script to act as a driver.

I still don't understand why you have to mess with f18.cpp. What would break if you left it alone?

Jun 2 2021, 8:36 AM · Restricted Project, Restricted Project

May 26 2021

Leporacanthicus added inline comments to D102008: [OpenMP]Add support for workshare loop modifier in lowering.
May 26 2021, 3:07 AM · Restricted Project
Leporacanthicus updated the diff for D102008: [OpenMP]Add support for workshare loop modifier in lowering.

Removed wrong comment endings.

May 26 2021, 3:00 AM · Restricted Project

May 21 2021

Leporacanthicus added a comment to D102008: [OpenMP]Add support for workshare loop modifier in lowering.

@Meinersbur Is there anything else I need to do here?

May 21 2021, 6:43 AM · Restricted Project

May 14 2021

Leporacanthicus added inline comments to D102008: [OpenMP]Add support for workshare loop modifier in lowering.
May 14 2021, 5:45 AM · Restricted Project
Leporacanthicus updated the diff for D102008: [OpenMP]Add support for workshare loop modifier in lowering.

Remove the code that add in modifiers to the scheduling type,
as per review comments.

May 14 2021, 5:40 AM · Restricted Project

May 12 2021

Leporacanthicus updated the diff for D102008: [OpenMP]Add support for workshare loop modifier in lowering.

Rebase and fixed comment style.

May 12 2021, 3:55 AM · Restricted Project

May 7 2021

Leporacanthicus added a comment to D102008: [OpenMP]Add support for workshare loop modifier in lowering.

Patch doesn't apply because it is relying on my previous patch. Doh!

May 7 2021, 3:42 AM · Restricted Project

May 6 2021

Leporacanthicus requested review of D102008: [OpenMP]Add support for workshare loop modifier in lowering.
May 6 2021, 10:24 AM · Restricted Project
Leporacanthicus accepted D101281: [flang] Remove `%f18` from LIT configuration files.

LGTM

May 6 2021, 1:40 AM · Restricted Project, Restricted Project

May 5 2021

Leporacanthicus added inline comments to D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.
May 5 2021, 5:58 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Adding MLIR to LLVM-IR tests. The tests are very basic, just checking that
the correct runtime functions are called.

May 5 2021, 4:27 AM · Restricted Project, Restricted Project

Apr 29 2021

Leporacanthicus updated the diff for D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Updates based on review comments:

  • Fix style using PascalCase rather than camelCase.
  • Add Doxygen comment for parameter.
  • Change comment style for constants.
  • Remove useless error output - there was no way to get to that error.
  • Use llvm_unreachable instead of assert(0).
Apr 29 2021, 8:24 AM · Restricted Project, Restricted Project

Apr 28 2021

Leporacanthicus added a comment to D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Will do some minor fixes tomorrow, thanks for the feedback!

Apr 28 2021, 12:53 PM · Restricted Project, Restricted Project
Leporacanthicus requested review of D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.
Apr 28 2021, 2:35 AM · Restricted Project, Restricted Project

Apr 20 2021

Leporacanthicus accepted D100558: [flang][driver] Add support for `-fget-definition`.

LGTM

Apr 20 2021, 3:45 AM · Restricted Project, Restricted Project
Leporacanthicus accepted D100655: [flang][nfc] Port 2 tests to use the new driver when enabled.

LGTM

Apr 20 2021, 3:10 AM · Restricted Project, Restricted Project

Apr 13 2021

Leporacanthicus accepted D100309: [flang] Update the remaining tests to use the new driver when enabled.

LGTM.

Apr 13 2021, 9:10 AM · Restricted Project, Restricted Project

Apr 8 2021

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Could you add the following to the unittest?

Builder.restoreIP(EndIP);
Builder.CreateRetVoid();
OMPBuilder.finalize();
EXPECT_FALSE(verifyModule(*M, &errs()));

I checks whether the IR is internally consistent.

Apr 8 2021, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updates as per review comments:

Apr 8 2021, 3:04 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2021

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Apr 1 2021, 11:07 AM · Restricted Project, Restricted Project, Restricted Project