Page MenuHomePhabricator
Feed Advanced Search

Fri, May 7

Leporacanthicus added a comment to D102008: [OpenMP]Add support for workshare loop modifier in lowering.

Patch doesn't apply because it is relying on my previous patch. Doh!

Fri, May 7, 3:42 AM · Restricted Project

Thu, May 6

Leporacanthicus requested review of D102008: [OpenMP]Add support for workshare loop modifier in lowering.
Thu, May 6, 10:24 AM · Restricted Project
Leporacanthicus accepted D101281: [flang] Remove `%f18` from LIT configuration files.

LGTM

Thu, May 6, 1:40 AM · Restricted Project, Restricted Project

Wed, May 5

Leporacanthicus added inline comments to D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.
Wed, May 5, 5:58 AM · Restricted Project, Restricted Project
Leporacanthicus updated the diff for D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Adding MLIR to LLVM-IR tests. The tests are very basic, just checking that
the correct runtime functions are called.

Wed, May 5, 4:27 AM · Restricted Project, Restricted Project

Thu, Apr 29

Leporacanthicus updated the diff for D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Updates based on review comments:

  • Fix style using PascalCase rather than camelCase.
  • Add Doxygen comment for parameter.
  • Change comment style for constants.
  • Remove useless error output - there was no way to get to that error.
  • Use llvm_unreachable instead of assert(0).
Thu, Apr 29, 8:24 AM · Restricted Project, Restricted Project

Wed, Apr 28

Leporacanthicus added a comment to D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.

Will do some minor fixes tomorrow, thanks for the feedback!

Wed, Apr 28, 12:53 PM · Restricted Project, Restricted Project
Leporacanthicus requested review of D101435: [OpenMP][MLIR]Add support for guided, auto and runtime scheduling.
Wed, Apr 28, 2:35 AM · Restricted Project, Restricted Project

Tue, Apr 20

Leporacanthicus accepted D100558: [flang][driver] Add support for `-fget-definition`.

LGTM

Tue, Apr 20, 3:45 AM · Restricted Project, Restricted Project
Leporacanthicus accepted D100655: [flang][nfc] Port 2 tests to use the new driver when enabled.

LGTM

Tue, Apr 20, 3:10 AM · Restricted Project, Restricted Project

Tue, Apr 13

Leporacanthicus accepted D100309: [flang] Update the remaining tests to use the new driver when enabled.

LGTM.

Tue, Apr 13, 9:10 AM · Restricted Project, Restricted Project

Apr 8 2021

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Could you add the following to the unittest?

Builder.restoreIP(EndIP);
Builder.CreateRetVoid();
OMPBuilder.finalize();
EXPECT_FALSE(verifyModule(*M, &errs()));

I checks whether the IR is internally consistent.

Apr 8 2021, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updates as per review comments:

Apr 8 2021, 3:04 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2021

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Apr 1 2021, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updates requested in review:

  • Avoid making temporary string
  • Avoid British English in comment
  • Be consistent and not mixing auto/named type in new tests
Apr 1 2021, 9:36 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2021

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Add testing for chunk size in dynamic work sharing loop test.

Mar 30 2021, 3:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2021

Leporacanthicus accepted D99198: [flang] Fix output buffering bug.

LGTM

Mar 24 2021, 1:55 AM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

Nice test, thanks for adding that!

Mar 24 2021, 12:13 AM · Restricted Project, Restricted Project

Mar 23 2021

Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

It gets exercised pretty thoroughly by the I/O tests in the FCVS Fortran '77 suite, especially by codes doing direct and sequential I/O, and the flang/unittests/Runtime/external-io.cpp test really shook it out on the read path (and still passes with this change now that it's used on the write path). But it would be nice to be able to make the code work harder by e.g. using an artificially small buffer size. I've done that in the past during development (but obviously not for console output, sorry) but I'm not sure how it could be made part of a unit testing framework.

Mar 23 2021, 12:16 PM · Restricted Project, Restricted Project
Leporacanthicus added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

Mar 23 2021, 10:40 AM · Restricted Project, Restricted Project

Mar 22 2021

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Mar 22 2021, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Fixes as per review comments

Mar 22 2021, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2021

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Fixed various review comments.

Mar 16 2021, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2021

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

I'm going to upload the fixes once they compile, but it's getting late, so probably not until tomorrow morning.

Mar 15 2021, 1:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2021

Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Please note that this is not intended as the final commit, but rather a basis for asking some advice on how to move forward.

The main stumbling point, which may be my lack of understanding of what it's supposed to do: the CanonicalLoopInfo assumes that the the cond block has a CmpInst as the first instruction. In the dynamic, the corresponding block [in my understanding] starts with a call instruction to fetch the "next" set of data to process. This causes the assertOK to fail, hence it is commented out on line 1300 in the patch.

Mar 12 2021, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

Leporacanthicus updated the diff for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Updated files based on selected review commets.
Fixed a few issues with the code-generation.
Added a basic test (similar to static workshare loop.

Mar 11 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2021

Leporacanthicus added inline comments to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Please note that this is not intended as the final commit, but rather a basis for asking some advice on how to move forward.

Feb 24 2021, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
Leporacanthicus requested review of D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 8:18 AM · Restricted Project, Restricted Project, Restricted Project

Dec 23 2016

Leporacanthicus added inline comments to D28080: [Docs][OpenCL] Added OpenCL feature description to user manual..
Dec 23 2016, 1:47 PM

Feb 5 2016

Leporacanthicus added inline comments to D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0.
Feb 5 2016, 9:48 AM