Page MenuHomePhabricator
Feed Advanced Search

Today

GMNGeoffrey committed rGf0dd6faaecc8: Update Bazel build for 744146f60b (authored by GMNGeoffrey).
Update Bazel build for 744146f60b
Thu, Jun 24, 4:38 PM
GMNGeoffrey closed D104885: Update Bazel build for 744146f60b.
Thu, Jun 24, 4:38 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

Just saw this was still outstanding. @rriddle could you take another look? I still think this is an improvement

Thu, Jun 24, 4:34 PM · Restricted Project
GMNGeoffrey updated the summary of D104885: Update Bazel build for 744146f60b.
Thu, Jun 24, 4:34 PM · Restricted Project
GMNGeoffrey requested review of D104885: Update Bazel build for 744146f60b.
Thu, Jun 24, 4:33 PM · Restricted Project
GMNGeoffrey committed rG1ca4cf9b242b: Update Bazel build for 929189a499 (authored by GMNGeoffrey).
Update Bazel build for 929189a499
Thu, Jun 24, 9:44 AM
GMNGeoffrey closed D104864: Update Bazel build for 929189a499.
Thu, Jun 24, 9:44 AM · Restricted Project
GMNGeoffrey added a comment to D104864: Update Bazel build for 929189a499.

Landing and requesting post-commit review

Thu, Jun 24, 9:43 AM · Restricted Project
GMNGeoffrey added a reviewer for D104864: Update Bazel build for 929189a499: ftynse.
Thu, Jun 24, 9:42 AM · Restricted Project
GMNGeoffrey requested review of D104864: Update Bazel build for 929189a499.
Thu, Jun 24, 9:42 AM · Restricted Project

Yesterday

GMNGeoffrey committed rGb58dfd87da5c: Update Bazel BUILD files up to be9a87fe9b (authored by GMNGeoffrey).
Update Bazel BUILD files up to be9a87fe9b
Wed, Jun 23, 9:27 AM
GMNGeoffrey closed D104791: Update Bazel BUILD files up to be9a87fe9b.
Wed, Jun 23, 9:27 AM · Restricted Project
GMNGeoffrey added a comment to D104791: Update Bazel BUILD files up to be9a87fe9b.

Going to land this and ask for post-commit review

Wed, Jun 23, 9:27 AM · Restricted Project
GMNGeoffrey added a reviewer for D104791: Update Bazel BUILD files up to be9a87fe9b: rupprecht.
Wed, Jun 23, 9:26 AM · Restricted Project
GMNGeoffrey requested review of D104791: Update Bazel BUILD files up to be9a87fe9b.
Wed, Jun 23, 9:25 AM · Restricted Project

Tue, Jun 22

GMNGeoffrey committed rG4aeb2e60df98: Introduce a Bazel build configuration (authored by GMNGeoffrey).
Introduce a Bazel build configuration
Tue, Jun 22, 12:48 PM
GMNGeoffrey closed D90352: Introduce a Bazel build configuration.
Tue, Jun 22, 12:48 PM · Restricted Project
GMNGeoffrey added a comment to D90352: Introduce a Bazel build configuration.

Ok I'm going to go ahead and land this

Tue, Jun 22, 12:47 PM · Restricted Project
GMNGeoffrey updated the diff for D90352: Introduce a Bazel build configuration.

Pull in changes from llvm-bazel up to llvm commit b3634d3e88b7

Tue, Jun 22, 12:46 PM · Restricted Project

Fri, Jun 18

GMNGeoffrey added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

For a while we only had repros using Blaze or Bazel. This is a pretty thorny bug to pin down. I managed to get it to hang using an OSS build of IREE with CMake though. Here's the backtrace for all threads: https://gist.github.com/GMNGeoffrey/0bdf40644efcda68db0c0ace734273b3

Fri, Jun 18, 10:28 AM · Restricted Project

Thu, Jun 17

GMNGeoffrey updated the diff for D90352: Introduce a Bazel build configuration.

Pull in latest changes from llvm-bazel

Thu, Jun 17, 11:27 AM · Restricted Project
GMNGeoffrey added a comment to D90352: Introduce a Bazel build configuration.

Might make sense to have someone from the committee that approved the proposal sign off on these files being checked into this location (with no review of the content/quality of the files) - and perhaps to commit at that point (regardless of the content/quality of the files) - then do the actual semantic review separately.

Or if there's some part of this review that could be extracted (is there sort of a "null" implementation - maybe literally just the top level utils/bazel directory, empty, or with a README, etc) and committed with that approval, and then invested bazel-using folks could use this review thread for further discussion on the design of the bazel build files?

Thu, Jun 17, 11:02 AM · Restricted Project

Wed, Jun 16

GMNGeoffrey added inline comments to D90352: Introduce a Bazel build configuration.
Wed, Jun 16, 2:42 PM · Restricted Project
GMNGeoffrey added inline comments to D90352: Introduce a Bazel build configuration.
Wed, Jun 16, 2:03 PM · Restricted Project
GMNGeoffrey added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

This is just using llvm::parallelForEachN (not doing anything particularly fancy) so I can't imagine how it would be different than other similar things using it. It is possible this is exposing a lower level problem in LLVM threading.

In any case, let me know how I can help. I'd prefer not to revert this though, as it is a significant speedup.

Wed, Jun 16, 1:20 PM · Restricted Project
GMNGeoffrey added a comment to D104411: Fix verifier crashing on some invalid IR.

Thanks!

Wed, Jun 16, 12:38 PM · Restricted Project
GMNGeoffrey added inline comments to D90352: Introduce a Bazel build configuration.
Wed, Jun 16, 12:34 PM · Restricted Project
GMNGeoffrey added inline comments to D104411: Fix verifier crashing on some invalid IR.
Wed, Jun 16, 12:28 PM · Restricted Project
GMNGeoffrey resigned from D99470: Support cross compiling standalone MLIR.
Wed, Jun 16, 10:47 AM · Restricted Project
GMNGeoffrey added a comment to D104207: [Verifier] Parallelize verification and dom checking. NFC..

FYI we are once again seeing hangs triggered by this change. It appears to have something to do with LLVM thread pool cleanup. We've hit it in IREE's OSS python tests, google's internal runs of MLIR's cuda integration tests, and IREE's iree-run-mlir tests (https://source.cloud.google.com/results/invocations/7ed7a557-2db6-4f7a-84e9-9e2dec6b1405/). So far we haven't been able to get a reproduction upstream, so it seems to have using MLIR in some certain environment

Wed, Jun 16, 9:25 AM · Restricted Project

Fri, Jun 11

GMNGeoffrey added a comment to D90352: Introduce a Bazel build configuration.

Reviewers, could you please take a look at this patch?

Fri, Jun 11, 2:45 PM · Restricted Project
GMNGeoffrey updated the diff for D90352: Introduce a Bazel build configuration.
  • Copy the Bazel build from llvm-bazel
  • Updates for new repository location
Fri, Jun 11, 2:44 PM · Restricted Project

Thu, Jun 10

GMNGeoffrey committed rG4f6ec382c8b7: [MLIR] Document that Dialect Conversion traverses in preorder (authored by GMNGeoffrey).
[MLIR] Document that Dialect Conversion traverses in preorder
Thu, Jun 10, 3:09 PM
GMNGeoffrey closed D102525: [MLIR] Document that Dialect Conversion traverses in preorder.
Thu, Jun 10, 3:09 PM · Restricted Project

Wed, Jun 9

GMNGeoffrey added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

Update: we suspect this is something in our python logic for piping subprocesses together, so likely this change is just a bystander :-)

Wed, Jun 9, 11:12 AM · Restricted Project
GMNGeoffrey added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

Oh and I also get a build failure because of a missing include of atomic:

Wed, Jun 9, 10:39 AM · Restricted Project
GMNGeoffrey added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

(notably the python tests are just shelling out to IREE binaries, so "bindings" is a strong word here 😁)

Wed, Jun 9, 10:22 AM · Restricted Project
GMNGeoffrey added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

We are seeing a mysterious hang in IREE's python tests after this change that happens about 90% of the time (making the test flakey). Entirely possible that it's something broken in our python bindings, especially given that I haven't yet seen it in anything that doesn't go through the bindings. But given that it was apparently landed accidentally, perhaps you'd consider a revert :-)

Wed, Jun 9, 10:19 AM · Restricted Project

Thu, May 27

GMNGeoffrey added a comment to D103226: [mlir] Support dialect-wide canonicalization pattern registration.

So one thought that comes up for me with this patch is that while we have general ideas about what a canonicalization for an op should limit itself to (should be conceptually related to the op), I'm not sure there's restrictions in the code or clear documentation. I think this could lead to a weird scenario where just having registered a dialect will change the behavior of the canonicalize pass, even if that dialect is completely unused. This can already happen today with op canonicalizations if the canonicalization doesn't require the presence of the op it is registered on. I think that such a canonicalization is kind of obviously a bad idea (but we should maybe document that in https://mlir.llvm.org/docs/Canonicalization/). With the addition of dialect canonicalization patterns though, it seems like this scenario is more likely, especially with the stated use case of a canonicalization that operates on an interface. Since interfaces are not tied to dialects, this means someone could declare a canonicalization pattern that operates on CastOpInterface, which would make sense because it's something their dialect uses, but this could affect the behavior of other dialects. In some ways this is a powerful mechanism for declaring canonicalizations on other ops you don't own, but if we want to support that I think it should probably be more specific. I'm not sure there's much we can do in the code to enforce this, but maybe a dialect canonicalization pattern should ensure that it only matches when ops from that dialect are present (and we should document this and a similar restriction on op canonicalization patterns). Thoughts?

Thu, May 27, 9:49 AM · Restricted Project

May 21 2021

GMNGeoffrey accepted D102952: [mlir-opt] Don't enable `printOpOnDiagnostic` if it was explicitly disabled..
May 21 2021, 4:14 PM · Restricted Project
GMNGeoffrey added a comment to D90352: Introduce a Bazel build configuration.

In case it wasn't clear from my recent updates, I believe this is now ready for review. PTAL

May 21 2021, 11:33 AM · Restricted Project

May 20 2021

GMNGeoffrey added inline comments to D90352: Introduce a Bazel build configuration.
May 20 2021, 4:25 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

Ping on this?

May 20 2021, 10:35 AM · Restricted Project

May 18 2021

GMNGeoffrey added a comment to D102734: [mlir] Speed up Lexer::getEncodedSourceLocation.

Driveby review :-) This is a fantastic speedup, but I'm a bit worried about "all MLIR files are simple ascii". I don't think that's documented in the langref. What about string literals? I believe those are just defined as "not weird whitespace" (https://mlir.llvm.org/docs/LangRef/#common-syntax).

May 18 2021, 5:14 PM · Restricted Project
GMNGeoffrey updated the summary of D90352: Introduce a Bazel build configuration.
May 18 2021, 3:58 PM · Restricted Project
GMNGeoffrey edited reviewers for D90352: Introduce a Bazel build configuration, added: tstellar, chandlerc, echristo, beanz; removed: aartbik.
May 18 2021, 3:55 PM · Restricted Project
GMNGeoffrey added inline comments to D90352: Introduce a Bazel build configuration.
May 18 2021, 3:55 PM · Restricted Project
GMNGeoffrey updated the diff for D90352: Introduce a Bazel build configuration.

Pull in new updates from github.com/google/llvm-bazel

May 18 2021, 3:50 PM · Restricted Project
GMNGeoffrey added a comment to D101854: [mlir] Refactor the implementation of pass crash reproducers.

What's the status on landing this? I am eagerly awaiting the ability to effectively debug dynamic pipelines.

May 18 2021, 12:56 PM · Restricted Project
GMNGeoffrey updated the summary of D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.
May 18 2021, 12:54 PM · Restricted Project

May 14 2021

GMNGeoffrey added a reviewer for D102525: [MLIR] Document that Dialect Conversion traverses in preorder: rriddle.
May 14 2021, 12:46 PM · Restricted Project
GMNGeoffrey updated the diff for D102525: [MLIR] Document that Dialect Conversion traverses in preorder.
  • Fix spacing
May 14 2021, 12:46 PM · Restricted Project
GMNGeoffrey requested review of D102525: [MLIR] Document that Dialect Conversion traverses in preorder.
May 14 2021, 12:45 PM · Restricted Project

May 13 2021

GMNGeoffrey added a comment to D102458: [MLIR] Fix build failures due to unused variables in non-debug builds..

LGTM

May 13 2021, 6:45 PM · Restricted Project

May 4 2021

GMNGeoffrey updated the summary of D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.
May 4 2021, 12:08 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

So I think the issue here is that verification is failing, but then it's printing an (unrelated?) constant as part of that and crashing. Probably that constant would fail verification later, but hasn't been verified yet. So I'm a proponent of still making this change, since less crashing is good and getInt() is deprecated. My understanding is that the pretty printer/parsers were supposed to be allowed to assume the op was verified and the verifier was supposed to print generic IR, but I guess that custom asm names are a special case. That would probably be good to investigate and fix more holistically as well

May 4 2021, 12:05 PM · Restricted Project

May 3 2021

GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

Here's my stack trace (helpfully not symbolized):

May 3 2021, 9:33 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

https://github.com/llvm/llvm-project/blob/959eec1fddc83c90c208789f20cb6573b2a20642/mlir/lib/Dialect/StandardOps/IR/Ops.cpp#L1063

May 3 2021, 9:25 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

Oh wait. The verifier *does* check this. This must be as part of printing out the IR for some other reason that I'm hitting this assert?

May 3 2021, 9:24 PM · Restricted Project
GMNGeoffrey added a comment to D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.

When does unsigned ever happen? You can't have an unsigned constant.

May 3 2021, 9:22 PM · Restricted Project
GMNGeoffrey updated the summary of D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.
May 3 2021, 8:49 PM · Restricted Project
GMNGeoffrey requested review of D101810: [MLIR] Use getValue instead of getInt for std.constant custom asm.
May 3 2021, 8:42 PM · Restricted Project

Apr 12 2021

GMNGeoffrey committed rGae33eef5055e: [MLIR] Add a switch operation to the standard dialect (authored by GMNGeoffrey).
[MLIR] Add a switch operation to the standard dialect
Apr 12 2021, 6:46 PM
GMNGeoffrey closed D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 12 2021, 6:46 PM · Restricted Project
GMNGeoffrey retitled D99925: [MLIR] Add a switch operation to the standard dialect from Add a switch operation to the standard dialect to [MLIR] Add a switch operation to the standard dialect.
Apr 12 2021, 6:45 PM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 12 2021, 5:03 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.

Address review comments

Apr 12 2021, 5:01 PM · Restricted Project

Apr 7 2021

GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 7 2021, 6:51 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.
  • Add unknown op predecessor to tests to block other canonicalizations
  • Fix passthrough canonicalization
  • Clean up test cases
Apr 7 2021, 6:50 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.

Fix function naming

Apr 7 2021, 9:36 AM · Restricted Project

Apr 6 2021

GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 8:49 PM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 8:49 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.

Respond to review comments

Apr 6 2021, 8:48 PM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 12:45 PM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 11:49 AM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 10:29 AM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 10:19 AM · Restricted Project
GMNGeoffrey added a comment to D99925: [MLIR] Add a switch operation to the standard dialect.

Are these clang-tidy naming errors legit? I think the names match the ones used

MLIR uses (lower) camelBack for function names.

Apr 6 2021, 9:57 AM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 9:41 AM · Restricted Project
GMNGeoffrey added a comment to D99925: [MLIR] Add a switch operation to the standard dialect.

Are these clang-tidy naming errors legit? I think the names match the ones used

Apr 6 2021, 9:37 AM · Restricted Project
GMNGeoffrey added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 6 2021, 9:30 AM · Restricted Project

Apr 5 2021

GMNGeoffrey added a reviewer for D99925: [MLIR] Add a switch operation to the standard dialect: rriddle.
Apr 5 2021, 10:41 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.
  • Remove extraneous include
Apr 5 2021, 10:41 PM · Restricted Project
GMNGeoffrey updated the diff for D99925: [MLIR] Add a switch operation to the standard dialect.

Remove leftover debugging stuff

Apr 5 2021, 10:39 PM · Restricted Project
GMNGeoffrey requested review of D99925: [MLIR] Add a switch operation to the standard dialect.
Apr 5 2021, 10:34 PM · Restricted Project
GMNGeoffrey committed rG22411d807238: [MLIR][docs] Fixes to operation syntax in Lang Ref (authored by GMNGeoffrey).
[MLIR][docs] Fixes to operation syntax in Lang Ref
Apr 5 2021, 10:29 PM
GMNGeoffrey closed D99922: [MLIR][docs] Fixes to operation syntax in Lang Ref.
Apr 5 2021, 10:29 PM · Restricted Project
GMNGeoffrey added a reviewer for D99922: [MLIR][docs] Fixes to operation syntax in Lang Ref: rriddle.
Apr 5 2021, 9:33 PM · Restricted Project
GMNGeoffrey requested review of D99922: [MLIR][docs] Fixes to operation syntax in Lang Ref.
Apr 5 2021, 9:32 PM · Restricted Project

Mar 15 2021

GMNGeoffrey committed rW8c509e6b770e: Mark Bazel proposal as accepted (authored by GMNGeoffrey).
Mark Bazel proposal as accepted
Mar 15 2021, 11:59 AM
GMNGeoffrey closed D98639: Mark Bazel proposal as accepted.
Mar 15 2021, 11:59 AM
GMNGeoffrey added reviewers for D98639: Mark Bazel proposal as accepted: beanz, lattner.
Mar 15 2021, 10:46 AM
GMNGeoffrey requested review of D98639: Mark Bazel proposal as accepted.
Mar 15 2021, 10:46 AM

Mar 2 2021

GMNGeoffrey committed rW8e1739580a7d: Update Bazel proposal status (authored by GMNGeoffrey).
Update Bazel proposal status
Mar 2 2021, 2:11 PM
GMNGeoffrey closed D97807: Update Bazel proposal status.
Mar 2 2021, 2:11 PM
GMNGeoffrey requested review of D97807: Update Bazel proposal status.
Mar 2 2021, 2:09 PM

Feb 26 2021

GMNGeoffrey committed rG21bb63893e85: [MLIR][linalg] Make integer matmul ops cast before multiplying (authored by GMNGeoffrey).
[MLIR][linalg] Make integer matmul ops cast before multiplying
Feb 26 2021, 8:36 AM
GMNGeoffrey closed D97505: [MLIR][linalg] Make integer matmul ops cast before multiplying.
Feb 26 2021, 8:36 AM · Restricted Project
GMNGeoffrey updated the summary of D97505: [MLIR][linalg] Make integer matmul ops cast before multiplying.
Feb 26 2021, 8:34 AM · Restricted Project

Feb 25 2021

GMNGeoffrey added a comment to D97505: [MLIR][linalg] Make integer matmul ops cast before multiplying.

@nicolasvasilache given that I've now changed the test, waiting for your review as well. Mahesh is skeptical of the vectorization pattern itself

Feb 25 2021, 5:47 PM · Restricted Project