Page MenuHomePhabricator
Feed Advanced Search

Mon, Jun 28

feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I have a few outstanding questions

Mon, Jun 28, 5:35 PM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Addresses some review comments

Mon, Jun 28, 5:34 PM · Restricted Project

Jun 21 2021

feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I'd just wanted to follow up and see if, minimally, my changes addressed the concerns raised or if you think there is further work here?

Jun 21 2021, 9:42 AM · Restricted Project

Jun 15 2021

feg208 abandoned D104242: Alters a lit test to simplify and avoid a buildbot error.
Jun 15 2021, 5:04 PM · Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Another +1 for it failing intermittently on the bot I watch over, llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the test or to remove it would be appreciated!

Jun 15 2021, 12:38 PM · Restricted Project, Restricted Project
feg208 updated subscribers of D104295: removes redundant test.
Jun 15 2021, 12:34 PM · Restricted Project
feg208 added a comment to D104295: removes redundant test.

If I could get someone to land this commit on my behalf I'd be obliged. I am working on the getting commit rights since that seems to be a pretty significant impediment to developing in llvm land but as of now I can't land this myself.

Jun 15 2021, 8:40 AM · Restricted Project
feg208 added a comment to D104242: Alters a lit test to simplify and avoid a buildbot error.

I put up a separate commit that just removes the test. I think this would resolve the builder issues but I don't think its worth even trying. We should abandon this (I think)

Jun 15 2021, 6:44 AM · Restricted Project
feg208 updated subscribers of D104242: Alters a lit test to simplify and avoid a buildbot error.
Jun 15 2021, 6:43 AM · Restricted Project
feg208 requested review of D104295: removes redundant test.
Jun 15 2021, 6:39 AM · Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I think, at this point, the sensible thing to do is to pull the test. As @MyDeveloperDay points out it isn't really adding any value above and beyond the unit tests. If it were non-determinism in the change itself the unit tests would catch it. They test the same formatting and test for non-determinism explicitly. Yet they've never failed. And there are quite a few of them.

Jun 15 2021, 6:34 AM · Restricted Project, Restricted Project

Jun 14 2021

feg208 added a comment to D104242: Alters a lit test to simplify and avoid a buildbot error.

I don’t have commit rights currently. Could I get someone to land this on my behalf?

Jun 14 2021, 10:52 PM · Restricted Project
feg208 added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Jun 14 2021, 8:34 PM · Restricted Project, Restricted Project
feg208 added a reviewer for D104242: Alters a lit test to simplify and avoid a buildbot error: vitalybuka.
Jun 14 2021, 8:33 PM · Restricted Project
feg208 retitled D104242: Alters a lit test to simplify and avoid a buildbot error from Removes an unused variable and alters a lit test to simplify and avoid a buildbot error to Alters a lit test to simplify and avoid a buildbot error.
Jun 14 2021, 1:30 PM · Restricted Project
feg208 updated the diff for D104242: Alters a lit test to simplify and avoid a buildbot error.

Looks like the dead code is removed in main

Jun 14 2021, 1:27 PM · Restricted Project
feg208 added a comment to D104242: Alters a lit test to simplify and avoid a buildbot error.

Could you split this into two diffs? Or are those two changes in any way related?

Jun 14 2021, 1:15 PM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Forgot the clang-tidy checks

Jun 14 2021, 11:40 AM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Clang-tidy checks cleaned up and test fixes

Jun 14 2021, 10:46 AM · Restricted Project
feg208 requested review of D104242: Alters a lit test to simplify and avoid a buildbot error.
Jun 14 2021, 10:18 AM · Restricted Project
feg208 added a comment to rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs.

Ok. I am going to see if I can replicate the issue locally. Otherwise the easiest path (imho) is to pull the lit test that is failing. It isn't telling us anything we don't already know from the unit tests in any case. But maybe its something odd like the spacing or the single '-' in the option flags on FileCheck

Jun 14 2021, 6:37 AM

Jun 13 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Added command line print

Jun 13 2021, 3:03 PM · Restricted Project
feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

This is not yet complete. I missed step 4a. "4a. If we crash, we generate the reproducer and print the dsymutil invocation to replay the reproducer." It currently doesn't print the command line

Jun 13 2021, 2:57 PM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Fixes the broken tests

Jun 13 2021, 2:34 PM · Restricted Project

Jun 12 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Rolled up review comments

Jun 12 2021, 9:28 AM · Restricted Project
feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I think this covers the comments

Jun 12 2021, 9:28 AM · Restricted Project

Jun 10 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

If I can get someone to submit this on my behalf I think we can call it a day.

Please post the name and email for the commit. And if no one else commits, I will do it on the weekend.

Jun 10 2021, 12:58 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

If I can get someone to submit this on my behalf I think we can call it a day.

Jun 10 2021, 7:00 AM · Restricted Project, Restricted Project

Jun 9 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

All the review comments are addressed

Jun 9 2021, 1:09 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Rolls up the remaining review comments

Jun 9 2021, 1:05 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

LGTM. That's a great piece work @feg208. Thank you!

Jun 9 2021, 12:52 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

addressed the remaining review comment

Jun 9 2021, 12:29 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Regenerated the mangled ClangFormatStyle.rst file

Jun 9 2021, 12:28 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Ick. Missed a semi colon in the test

Jun 9 2021, 9:25 AM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Fixes the busted test

Jun 9 2021, 9:17 AM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Got some changes. The failing test is an open issue

Jun 9 2021, 8:44 AM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Gets some of the formatting issues. Still chasing a test issue.

Jun 9 2021, 8:44 AM · Restricted Project, Restricted Project

Jun 8 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Fixes from clang-tidy checks

Jun 8 2021, 8:32 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This alters the array alignment to allow for left alignment

Jun 8 2021, 5:21 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Better still how about having

ArraryMemberAligmentEnum AlignArrayOfStructures

of "None, Left and Right"

I find boolean options don't stay boolean for long!

Jun 8 2021, 6:35 AM · Restricted Project, Restricted Project

Jun 7 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Ok. Given @HazardyKnusperkeks comment I'll make the default be left alignment and update the tests accordingly

Jun 7 2021, 12:58 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Gets some review comments

Jun 7 2021, 12:54 PM · Restricted Project
feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I rolled up all the comments save one where I just have an outstanding question and then I'll roll that up as well

Jun 7 2021, 12:54 PM · Restricted Project

Jun 3 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Had some invalid code in the lit test

Jun 3 2021, 4:35 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Rebased against main

Jun 3 2021, 4:31 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Got both of these

Jun 3 2021, 9:39 AM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Grabs up some review comments and adds lit test

Jun 3 2021, 9:38 AM · Restricted Project, Restricted Project

Jun 2 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Adds a simple lit test for some sanity checks

Jun 2 2021, 5:41 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

one remaining

Jun 2 2021, 2:07 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Missed a request

Jun 2 2021, 2:06 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Captured review comments

Jun 2 2021, 2:04 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I rolled up the suggested changes.

Jun 2 2021, 2:04 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

oops left some debugging messages in

Jun 2 2021, 10:35 AM · Restricted Project, Restricted Project
feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I am wondering if I could get someone to look at this? I think I have addressed the review comments but I'd be happy to fix anything I missed

Jun 2 2021, 9:33 AM · Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I am of the view that this is complete. Or at a minimum all the tests that have
been requested pass and I would be surprised if there were gross errors or other
major things I have missed

Jun 2 2021, 9:22 AM · Restricted Project, Restricted Project

May 27 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Rolls up review comments

May 27 2021, 11:51 AM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I picked up most of these. One of the tests is already covered (I think) maybe I am misunderstanding

May 27 2021, 11:51 AM · Restricted Project, Restricted Project

May 26 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Still need to fix and add the tests I said I would but the comment tests are added

May 26 2021, 10:52 AM · Restricted Project, Restricted Project

May 25 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Addresses review comments

May 25 2021, 9:37 AM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

The tests still need to be added

May 25 2021, 9:37 AM · Restricted Project, Restricted Project

May 24 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Broke a regression test

May 24 2021, 7:56 PM · Restricted Project
feg208 added a comment to D101340: Allows for dsymutil crashes to generate reproduceable information.

I think I addressed all the comments? If so I can't push the changes into the repo. Could you? Assuming there aren't outstanding concerns of course.

May 24 2021, 5:59 PM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Addresses some review comments

May 24 2021, 5:58 PM · Restricted Project
feg208 added reviewers for D101340: Allows for dsymutil crashes to generate reproduceable information: void, ruiu, bkramer.
May 24 2021, 1:08 PM · Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

clang-tidy and clang-format changes

May 24 2021, 9:13 AM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This reworks substantially this commit. I recognize there are lacking/broken
tests but I just would like to ensure that the general direction doesn't
seem likely to end in tears

I'm not deep enough in clang-format and currently have not enough time to check that in depth. But why are you right aligning?

May 24 2021, 9:03 AM · Restricted Project, Restricted Project

May 23 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Fixes/adds a test that yielded a seg fault and quiets some clang-tidy checks

May 23 2021, 9:06 AM · Restricted Project, Restricted Project

May 22 2021

feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Adds some tests and fixes a broken test

May 22 2021, 12:35 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Forgot to alter the documentation to reflect right justified column alignment

May 22 2021, 11:09 AM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This reworks substantially this commit. I recognize there are lacking/broken
tests but I just would like to ensure that the general direction doesn't
seem likely to end in tears

May 22 2021, 11:06 AM · Restricted Project, Restricted Project

May 21 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This looks like a good start..

May 21 2021, 10:25 AM · Restricted Project, Restricted Project

May 8 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Something which just came to my mind. Since you wrote your own LineFormatter, you have to add test cases for all kinds of indention and wrapping. It seems that the string wrapping does not happen, how about comments? Are classes, namespaces, functions, etc. correctly indented with various configurations?

Given my expectations I think the alignment has to happen differently, but I'm happy to be proven wrong.

May 8 2021, 10:00 AM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I still need to handle the 20 character case appropriately

May 8 2021, 8:59 AM · Restricted Project, Restricted Project

May 7 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Missed a request in the release notes

May 7 2021, 1:15 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Oops missed a request

May 7 2021, 1:15 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Added more tests and addressed review comments

May 7 2021, 1:12 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I think I have all the tests and requested review comments rolled up

May 7 2021, 1:12 PM · Restricted Project, Restricted Project

May 6 2021

feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I have a few outstanding questions about additional testing

May 6 2021, 4:45 PM · Restricted Project, Restricted Project
feg208 added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

To answer the question of why I think this is different then other alignment options....It seems to me that each alignment option emphasizes a specific thing, be it macros, bitfields, or (maybe closer in spirit) more simple declarations and assignments. I think this case is unique and not currently addressed by any of the existing alignment mechanisms.

May 6 2021, 4:36 PM · Restricted Project, Restricted Project
feg208 updated the diff for D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This addresses most of the review comments. There remain a few tests to add

May 6 2021, 4:36 PM · Restricted Project, Restricted Project

May 4 2021

feg208 requested review of D101868: [clang-format] Adds a formatter for aligning arrays of structs.
May 4 2021, 4:08 PM · Restricted Project, Restricted Project

May 1 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

clang-format misses

May 1 2021, 10:38 AM · Restricted Project

Apr 29 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Cleans up clang-tidy/format issues and some minor branch pecadillos

Apr 29 2021, 2:10 PM · Restricted Project

Apr 28 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Forgot to remove raise(SIGSEGV)

Apr 28 2021, 8:57 PM · Restricted Project
feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

This alters the prior commit by incorporating the Reproducer for the purpose of persisting the files on crash

Apr 28 2021, 8:54 PM · Restricted Project

Apr 27 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Missing more clang-tidy checks

Apr 27 2021, 8:58 AM · Restricted Project

Apr 26 2021

feg208 updated the diff for D101340: Allows for dsymutil crashes to generate reproduceable information.

Fixed clang-tidy warnings

Apr 26 2021, 9:21 PM · Restricted Project
feg208 requested review of D101340: Allows for dsymutil crashes to generate reproduceable information.
Apr 26 2021, 8:14 PM · Restricted Project