Thu, May 13
Wed, May 12
This is the mirror of https://reviews.llvm.org/D101026
Fri, Apr 30
Hey Inho, the bot still could not apply the patch. The diff details show that it's failed. And I can't patch it locally either.
Tue, Apr 27
There are conflicts, could you rebase and fix it?
Uh, I think I found a case that this solution can't check, which does not have its maximum and minimum indices with the start and end indices. For example, if the affine_map is <(d0, d1) -> (d1 - d0)> and the ranges of d0 and d1 are 0 and 1, then this expression has
0 when d0 is 0 and d1 is 0,
1 when d0 is 0 and d1 is 1,
-1 when d0 is 1 and d1 is 0,
0 when d0 is 1 and d1 is 1.
I wanted to share this case.. And I think we should substitude
the maximum values for negative dims, and the minimum values for positive dims in order to get the real minimum indices. For the maximum indices, we need the minimum values for negative dims, and the maximum values for positive dims..
Mon, Apr 26
Sun, Apr 25
Fri, Apr 23
I think you accidentally delete some invalid tests, could you add them back?
Thu, Apr 22
Thanks for adding this!
Tue, Apr 20
Mon, Apr 19
Apr 14 2021
Apr 13 2021
I think we should have a cleanup someday... many ops are no longer Standard ops...
Apr 12 2021
Apr 11 2021
Apr 8 2021
do we still need this?
Also added the implementation of SPIRVTypeConverter::getOptions().
Fixed, and enhanced the test that loads i1. (now it will return i1 to make sure there is no such issue again.)
fix i1 issues
Apr 7 2021
Haven't prototyped based on the patch, but overall it looks good to me.
Apr 6 2021
@antiagainst is going to add some support to SPIR-V, and I will rebase on it and rework a bit.
Apr 4 2021
Sorry for the late review...
Apr 1 2021
I hit a really weird thing... and I can only repro with this PR...
use build-in function
fix debug build
Mar 30 2021
Mar 29 2021
Mar 25 2021
It looks like there is a failure in tile-and-fuse-tensors.mlir. Could you check the file/test, so we can make bots happy?
Mar 23 2021
Mar 18 2021
Mar 16 2021
Inho and I had an offline discussion today, and we found that this doesn't work in some cases. E.g., if there is an affine_map is affine_map<(i) -> (10 - i)>. I will wait for Inho's fix and review it later.
Mar 12 2021
It seems like I should fix bunch of tests...
@inho9606, please add invalid ops to test/Dialect/Linalg/invalid.mlir
Mar 11 2021
Probably need a test that fails as well and verify the error message. You can use -verify-diagnostics on the command line, and match the error using // expected-error . See other tests that have this.
@aartbik could you help check if the change in sparse_nd.mlir is correct?
Mar 10 2021
Mar 9 2021
Mar 8 2021
Please provide a rationale for making this change in the commit description. Why is it necessary? Is there any op that will customize the behavior and why can't it do so by overloading the functions instead?
Mar 4 2021
Mar 3 2021
LGTM for depthwise op_def. the ods changes aren't needed for this change, right ? if yes feel free to split and submit the op_def part.
split patches because scalar attribute is not needed in the same patch