Page MenuHomePhabricator
Feed Advanced Search

Thu, May 13

hanchung added inline comments to D102305: The final update of static checker for linalg operations with the maximum and minimum indices.
Thu, May 13, 9:09 PM · Restricted Project

Wed, May 12

hanchung closed D101026: Update static bound checker for Linalg to cover decreasing cases.
Wed, May 12, 11:15 AM · Restricted Project
hanchung committed rG5480ea6c8463: Update static bound checker for Linalg to cover decreasing cases (authored by inho9606).
Update static bound checker for Linalg to cover decreasing cases
Wed, May 12, 10:30 AM
hanchung closed D102302: Update the static checker for linalg operations.
Wed, May 12, 10:30 AM · Restricted Project
hanchung accepted D102302: Update the static checker for linalg operations.

This is the mirror of https://reviews.llvm.org/D101026

Wed, May 12, 10:28 AM · Restricted Project

Fri, Apr 30

hanchung added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

Hey Inho, the bot still could not apply the patch. The diff details show that it's failed. And I can't patch it locally either.

Fri, Apr 30, 3:30 AM · Restricted Project

Tue, Apr 27

hanchung added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

There are conflicts, could you rebase and fix it?

Ah, I can't see the conflicts in my repository.. Rebase was successfully done. Could you tell me what files have conflicts?
Thanks

Tue, Apr 27, 9:19 PM · Restricted Project
hanchung added a comment to D101026: Update static bound checker for Linalg to cover decreasing cases.

There are conflicts, could you rebase and fix it?

Tue, Apr 27, 9:54 AM · Restricted Project
hanchung accepted D101026: Update static bound checker for Linalg to cover decreasing cases.

Uh, I think I found a case that this solution can't check, which does not have its maximum and minimum indices with the start and end indices. For example, if the affine_map is <(d0, d1) -> (d1 - d0)> and the ranges of d0 and d1 are 0 and 1, then this expression has
0 when d0 is 0 and d1 is 0,
1 when d0 is 0 and d1 is 1,
-1 when d0 is 1 and d1 is 0,
0 when d0 is 1 and d1 is 1.
I wanted to share this case.. And I think we should substitude
the maximum values for negative dims, and the minimum values for positive dims in order to get the real minimum indices. For the maximum indices, we need the minimum values for negative dims, and the maximum values for positive dims..

Tue, Apr 27, 6:16 AM · Restricted Project
hanchung accepted D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..
Tue, Apr 27, 6:12 AM · Restricted Project
hanchung added inline comments to D101343: [mlir][Linalg] Add a utility method to get reassociations maps for reshape..
Tue, Apr 27, 6:12 AM · Restricted Project

Mon, Apr 26

hanchung accepted D101225: [mlir][tosa] Add tosa.negate lowerings for quantized cases.
Mon, Apr 26, 12:56 AM · Restricted Project
hanchung accepted D101258: [mlir][Linalg] Use rank-reduced versions of subtensor/subtensor_insert to drop unit-dims..
Mon, Apr 26, 12:01 AM · Restricted Project

Sun, Apr 25

hanchung accepted D101026: Update static bound checker for Linalg to cover decreasing cases.
Sun, Apr 25, 11:13 PM · Restricted Project

Fri, Apr 23

hanchung requested changes to D101026: Update static bound checker for Linalg to cover decreasing cases.

I think you accidentally delete some invalid tests, could you add them back?

Fri, Apr 23, 12:11 AM · Restricted Project

Thu, Apr 22

hanchung requested changes to D101026: Update static bound checker for Linalg to cover decreasing cases.

Thanks for adding this!

Thu, Apr 22, 2:46 AM · Restricted Project

Tue, Apr 20

hanchung committed rG7b7df8e85eec: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V
Tue, Apr 20, 7:36 AM
hanchung closed D100817: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V.
Tue, Apr 20, 7:35 AM · Restricted Project

Mon, Apr 19

hanchung requested review of D100817: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V.
Mon, Apr 19, 11:10 PM · Restricted Project

Apr 14 2021

hanchung committed rG7c4de2e9b9b4: [mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V
Apr 14 2021, 7:24 AM
hanchung closed D100452: [mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V.
Apr 14 2021, 7:24 AM · Restricted Project
hanchung updated the diff for D100452: [mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V.

update comments

Apr 14 2021, 3:25 AM · Restricted Project
hanchung requested review of D100452: [mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V.
Apr 14 2021, 12:47 AM · Restricted Project

Apr 13 2021

hanchung committed rGd9b03ef2e899: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V. (authored by hanchung).
[mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V.
Apr 13 2021, 10:37 PM
hanchung closed D100403: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V..
Apr 13 2021, 10:37 PM · Restricted Project
hanchung added a comment to D100403: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V..

I think we should have a cleanup someday... many ops are no longer Standard ops...

Apr 13 2021, 11:38 AM · Restricted Project
hanchung requested review of D100403: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V..
Apr 13 2021, 11:36 AM · Restricted Project
hanchung added inline comments to D100061: [mlir][tosa] Add conv2d lowering to linalg.conv2d operator for FP.
Apr 13 2021, 9:39 AM · Restricted Project
hanchung accepted D100386: [mlir][spirv] Only attach struct offset for required storage classes.
Apr 13 2021, 8:23 AM · Restricted Project

Apr 12 2021

hanchung abandoned D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Apr 12 2021, 11:53 PM · Restricted Project
hanchung accepted D100325: [mlir][spirv] Put debug-only variable in LLVM_DEBUG.
Apr 12 2021, 11:46 AM · Restricted Project

Apr 11 2021

hanchung accepted D100272: [mlir][Linalg] Disable const -> linalg.generic when fused op is illegal..
Apr 11 2021, 10:42 PM · Restricted Project

Apr 8 2021

Herald added a reviewer for D97720: Fix tile-and-pad when padding doesn't span all dimension: mravishankar.

do we still need this?

Apr 8 2021, 9:31 PM · Restricted Project
hanchung accepted D100145: [mlir][Linalg] Drop unit-trip loops of reductions only if other reduction loops exists..
Apr 8 2021, 9:30 PM · Restricted Project
hanchung committed rGc3614358452e: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op (authored by hanchung).
[mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op
Apr 8 2021, 12:16 PM
hanchung closed D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Apr 8 2021, 12:15 PM · Restricted Project
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Apr 8 2021, 11:45 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Apr 8 2021, 11:45 AM · Restricted Project
hanchung updated the summary of D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Apr 8 2021, 10:43 AM · Restricted Project
hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Also added the implementation of SPIRVTypeConverter::getOptions().

Apr 8 2021, 10:43 AM · Restricted Project
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Apr 8 2021, 10:42 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Apr 8 2021, 10:42 AM · Restricted Project
hanchung abandoned D100111: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Apr 8 2021, 7:40 AM · Restricted Project
hanchung abandoned D100110: [mlir][spirv] Timely fail type conversion.
Apr 8 2021, 7:39 AM · Restricted Project
hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Fixed, and enhanced the test that loads i1. (now it will return i1 to make sure there is no such issue again.)

Apr 8 2021, 7:37 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

fix i1 issues

Apr 8 2021, 7:35 AM · Restricted Project
hanchung requested review of D100111: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Apr 8 2021, 7:34 AM · Restricted Project
hanchung requested review of D100110: [mlir][spirv] Timely fail type conversion.
Apr 8 2021, 7:34 AM · Restricted Project

Apr 7 2021

hanchung accepted D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation.

Haven't prototyped based on the patch, but overall it looks good to me.

Apr 7 2021, 11:24 PM · Restricted Project
hanchung accepted D100058: [mlir][spirv] Timely fail type conversion.
Apr 7 2021, 11:14 PM · Restricted Project

Apr 6 2021

hanchung planned changes to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

@antiagainst is going to add some support to SPIR-V, and I will rebase on it and rework a bit.

Apr 6 2021, 9:54 AM · Restricted Project
hanchung accepted D99756: [mlir][tosa] Add tosa.table lowering to linalg.generic.
Apr 6 2021, 1:12 AM · Restricted Project

Apr 4 2021

hanchung accepted D99820: [mlir][Linalg] Add callbacks to fusion of elementwise operations to control fusion..
Apr 4 2021, 11:51 PM · Restricted Project
hanchung accepted D99819: [mlir][Linalg] NFC: Move populatePatterns* method into linalg namespace..
Apr 4 2021, 10:56 PM · Restricted Project
hanchung requested changes to D99756: [mlir][tosa] Add tosa.table lowering to linalg.generic.

Sorry for the late review...

Apr 4 2021, 9:11 AM · Restricted Project

Apr 1 2021

hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

I hit a really weird thing... and I can only repro with this PR...

Apr 1 2021, 8:57 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

use build-in function

Apr 1 2021, 8:38 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

fix debug build

Apr 1 2021, 8:34 AM · Restricted Project
hanchung requested review of D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Apr 1 2021, 6:47 AM · Restricted Project

Mar 30 2021

hanchung committed rGf58463345415: Added static verification for Linalg Ops. (authored by inho9606).
Added static verification for Linalg Ops.
Mar 30 2021, 7:11 AM
hanchung closed D98390: Added static verification for Linalg Ops..
Mar 30 2021, 7:11 AM · Restricted Project

Mar 29 2021

hanchung accepted D99485: [mlir][Linalg] Drop spurious error message.

nice cleanup!

Mar 29 2021, 8:04 AM · Restricted Project
hanchung accepted D98390: Added static verification for Linalg Ops..

Thanks!

Mar 29 2021, 5:01 AM · Restricted Project

Mar 25 2021

hanchung added a comment to D98390: Added static verification for Linalg Ops..

It looks like there is a failure in tile-and-fuse-tensors.mlir. Could you check the file/test, so we can make bots happy?

Mar 25 2021, 6:05 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 25 2021, 12:06 AM · Restricted Project

Mar 23 2021

hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 23 2021, 11:12 AM · Restricted Project

Mar 18 2021

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Mar 18 2021, 11:05 PM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 18 2021, 11:01 PM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 18 2021, 9:58 AM · Restricted Project

Mar 16 2021

hanchung requested changes to D98390: Added static verification for Linalg Ops..

Inho and I had an offline discussion today, and we found that this doesn't work in some cases. E.g., if there is an affine_map is affine_map<(i) -> (10 - i)>. I will wait for Inho's fix and review it later.

Mar 16 2021, 5:39 AM · Restricted Project

Mar 12 2021

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Mar 12 2021, 10:59 AM · Restricted Project
hanchung planned changes to D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mar 12 2021, 5:35 AM · Restricted Project
hanchung added a comment to D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..

It seems like I should fix bunch of tests...

Mar 12 2021, 5:30 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..

@inho9606, please add invalid ops to test/Dialect/Linalg/invalid.mlir

Mar 12 2021, 4:50 AM · Restricted Project
hanchung requested review of D98492: [mlir] Make dispatchIndexOpFoldResult handle constant ops..
Mar 12 2021, 4:23 AM · Restricted Project

Mar 11 2021

hanchung added inline comments to D98390: Added static verification for Linalg Ops..
Mar 11 2021, 11:29 PM · Restricted Project
hanchung added a comment to D98390: Added static verification for Linalg Ops..

Probably need a test that fails as well and verify the error message. You can use -verify-diagnostics on the command line, and match the error using // expected-error . See other tests that have this.

Mar 11 2021, 12:20 PM · Restricted Project
hanchung added a comment to D98390: Added static verification for Linalg Ops..

@aartbik could you help check if the change in sparse_nd.mlir is correct?

Mar 11 2021, 11:26 AM · Restricted Project
hanchung requested changes to D98390: Added static verification for Linalg Ops..
Mar 11 2021, 2:49 AM · Restricted Project

Mar 10 2021

hanchung committed rG2ce4caf4143b: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to… (authored by inho9606).
Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to…
Mar 10 2021, 4:06 AM
hanchung closed D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 4:06 AM · Restricted Project
hanchung accepted D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 3:52 AM · Restricted Project
hanchung committed rGd5d4fb635ee0: [mlir][linalg] Add support for using scalar attributes in TC ops. (authored by hanchung).
[mlir][linalg] Add support for using scalar attributes in TC ops.
Mar 10 2021, 1:52 AM
hanchung closed D97876: [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 10 2021, 1:51 AM · Restricted Project
hanchung retitled D97876: [mlir][linalg] Add support for using scalar attributes in TC ops. from [mlir][linalg] Fix issues in scalar attributes. to [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 10 2021, 1:49 AM · Restricted Project
hanchung added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 10 2021, 1:19 AM · Restricted Project

Mar 9 2021

hanchung added inline comments to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 9 2021, 4:17 AM · Restricted Project

Mar 8 2021

hanchung requested changes to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.
Mar 8 2021, 11:35 PM · Restricted Project
hanchung requested changes to D98163: Moved getStaticLoopRanges and getStaticShape methods to LinalgInterfaces.td to add static shape verification.

Please provide a rationale for making this change in the commit description. Why is it necessary? Is there any op that will customize the behavior and why can't it do so by overloading the functions instead?

Mar 8 2021, 4:23 AM · Restricted Project

Mar 4 2021

hanchung committed rGb47c6c686c86: [mlir][linalg] Add suffix "Op" to pooling TC ops. (authored by hanchung).
[mlir][linalg] Add suffix "Op" to pooling TC ops.
Mar 4 2021, 7:09 AM
hanchung closed D97946: [mlir][linalg] Add suffix "Op" to pooling TC ops..
Mar 4 2021, 7:09 AM · Restricted Project
hanchung requested review of D97946: [mlir][linalg] Add suffix "Op" to pooling TC ops..
Mar 4 2021, 6:32 AM · Restricted Project

Mar 3 2021

hanchung committed rG83c56aa4ee82: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops. (authored by hanchung).
[mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops.
Mar 3 2021, 11:47 AM
hanchung closed D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 11:47 AM · Restricted Project
hanchung requested review of D97876: [mlir][linalg] Add support for using scalar attributes in TC ops..
Mar 3 2021, 11:25 AM · Restricted Project
hanchung updated the summary of D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 11:25 AM · Restricted Project
hanchung added a comment to D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

LGTM for depthwise op_def. the ods changes aren't needed for this change, right ? if yes feel free to split and submit the op_def part.

Mar 3 2021, 11:25 AM · Restricted Project
hanchung updated the diff for D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

split patches because scalar attribute is not needed in the same patch

Mar 3 2021, 11:23 AM · Restricted Project
hanchung updated the diff for D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

Fix tests

Mar 3 2021, 11:03 AM · Restricted Project
hanchung updated the summary of D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..
Mar 3 2021, 10:44 AM · Restricted Project