Page MenuHomePhabricator
Feed Advanced Search

Yesterday

smeenai added a comment to D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

Is there anything holding this up?

Sun, Feb 23, 10:14 PM · Restricted Project, Restricted Project
smeenai added a comment to D74169: [WIP][LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info..

lld already supports gdb_index & there's plans to add debug_names support in the near future (~6 months).

Does it support adding the GDB index after the fact on an already linked binary, or just at normal link time? I want to add a GSYM option to LLD at some point too. Can replace -gline-tables-only in many cases.

I don't think there's been any effort to add it as a post-processing step, no. I believe it can be built either from parsed DWARF or from debug_gnu_pubnames - in either case, at link time. I mean, it'd be probably quite practical to extend it to be able to be done as a standalone/post-processing step.

Sun, Feb 23, 7:07 PM · debug-info, lld, Restricted Project

Fri, Feb 21

smeenai accepted D74176: [CMake] Link against ZLIB::ZLIB.

If this is picked to 10.0, D74106 will need to be picked as well, right?

Fri, Feb 21, 10:52 PM · Restricted Project
smeenai added a comment to D74990: [arcconfig] Default base to previous revision.

When patching in a Differential, I usually do:

arc patch D74990
git rebase origin/master

Does this change mean I can delete git rebase origin/master from my workflow? If yes, strong +1 from me.

Fri, Feb 21, 4:11 PM · Restricted Project
smeenai created D74996: [arcconfig] Delete subproject arcconfigs.
Fri, Feb 21, 3:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
smeenai created D74992: [private][DO NOT SUBMIT] Test.
Fri, Feb 21, 3:34 PM
smeenai added a comment to D73743: Inline basic_string::erase for fastpath where __n == npos.

Is there a way I can easily tell phabricator that this is baselined against https://reviews.llvm.org/D74870 ?

I admit I don't understand phabricator well, or the mysterious ways it works.

On my local repo I rebased my branch, which works like a charm as that is ..... basic git.
Unfortunately arc diff then updates the wrong review, so I had to fix up both this one and D74870,

I also figured setting 'parent revision' would establish this (not so much).

Should I RTFM? :)

Try arc diff HEAD^.

We should just adjust the .arcconfig for LLVM to do this automatically ... I'll put up a patch.

Fri, Feb 21, 3:25 PM · Restricted Project
smeenai abandoned D74983: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 3:25 PM
smeenai abandoned D74981: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 3:25 PM
smeenai created D74990: [arcconfig] Default base to previous revision.
Fri, Feb 21, 3:25 PM · Restricted Project
smeenai created D74983: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 12:04 PM
smeenai abandoned D74982: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 12:04 PM
smeenai created D74982: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 12:04 PM
smeenai created D74981: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 11:58 AM
smeenai abandoned D74980: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 11:58 AM
smeenai created D74980: [private][DO NOT SUBMIT] Test commit 2.
Fri, Feb 21, 11:58 AM
smeenai created D74979: [private][DO NOT SUBMIT] Test commit 1.
Fri, Feb 21, 11:58 AM

Thu, Feb 20

smeenai updated subscribers of D74169: [WIP][LLD][ELF][DebugInfo] Skeleton implementation of removing obsolete debug info..
Thu, Feb 20, 5:10 PM · debug-info, lld, Restricted Project

Wed, Feb 19

smeenai added reviewers for D74516: Extend TimeTrace to LLVM's new pass manager: chandlerc, philip.pfaffe, fedor.sergeev.
Wed, Feb 19, 7:47 PM · Restricted Project
smeenai added a comment to D73743: Inline basic_string::erase for fastpath where __n == npos.

Is there a way I can easily tell phabricator that this is baselined against https://reviews.llvm.org/D74870 ?

I admit I don't understand phabricator well, or the mysterious ways it works.

On my local repo I rebased my branch, which works like a charm as that is ..... basic git.
Unfortunately arc diff then updates the wrong review, so I had to fix up both this one and D74870,

I also figured setting 'parent revision' would establish this (not so much).

Should I RTFM? :)

Wed, Feb 19, 3:15 PM · Restricted Project
smeenai added a comment to D74176: [CMake] Link against ZLIB::ZLIB.

So with this, llvm-config --system-libs will print out -lz instead of the full path to the zlib library that was found. That's potentially not accurate in case you've set up your LLVM's CMake to find a different zlib than what -lz would find by default. On the other hand, it does mean you can use the llvm-config --system-libs output across systems, which is probably a more useful property.

Wed, Feb 19, 10:10 AM · Restricted Project
smeenai added inline comments to D74176: [CMake] Link against ZLIB::ZLIB.
Wed, Feb 19, 10:10 AM · Restricted Project

Tue, Feb 18

smeenai added a comment to D68648: [CMake] Only detect the linker once in AddLLVM.cmake.

Works for me!

Tue, Feb 18, 2:44 PM · Restricted Project
smeenai added a comment to D68648: [CMake] Only detect the linker once in AddLLVM.cmake.

(my previous accept still stands)

Tue, Feb 18, 2:44 PM · Restricted Project
smeenai updated subscribers of D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V.

CC @hans for 10.0

Tue, Feb 18, 9:58 AM · Restricted Project

Thu, Feb 13

smeenai added a comment to D69950: Reapply "Fix crash on switch conditions of non-integer types in templates".

Similar to the case @mstorsjo mentioned, this also causes the following code to fail now:

Thu, Feb 13, 12:32 AM · Restricted Project

Wed, Feb 12

smeenai added a comment to D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode.

https://gcc.godbolt.org/z/cY9-HQ

gcc's behavior for your testcase makes no sense. We have to emit the definition of a static function: it can't be defined in any other translation unit because it's impossible to name in any other translation unit. Note the "_ZL" prefix. (Given the way ELF works, I guess you could get around that limitation if the function is extern "C", but still...)

Wed, Feb 12, 6:20 PM · Restricted Project, Restricted Project
smeenai added a comment to D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode.

It looks like our behavior still differs from gcc in the case of a static inline __attribute__((gnu_inline)) function: https://gcc.godbolt.org/z/cY9-HQ. We emit it and gcc doesn't. I don't think that combination makes a lot of sense, but I ran into it in some internal code while testing LLVM 10.

Wed, Feb 12, 4:58 PM · Restricted Project, Restricted Project
smeenai added a comment to D72242: Fix crash on value dependent bitfields in if conditions in templates.

I'm not sure why Phabricator is still showing Needs Review, but @rnk's approval should make this count as accepted.

Wed, Feb 12, 1:19 PM · Restricted Project
smeenai updated subscribers of D72242: Fix crash on value dependent bitfields in if conditions in templates.

CC @hans for the 10.0 branch.

Wed, Feb 12, 11:20 AM · Restricted Project
smeenai added a comment to D72242: Fix crash on value dependent bitfields in if conditions in templates.

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44886

Wed, Feb 12, 11:01 AM · Restricted Project
smeenai committed rG26edb21c29cb: [runtimes] Add umbrella targets for runtimes (authored by smeenai).
[runtimes] Add umbrella targets for runtimes
Wed, Feb 12, 9:47 AM
smeenai closed D74458: [runtimes] Add umbrella targets for runtimes.
Wed, Feb 12, 9:47 AM · Restricted Project

Tue, Feb 11

smeenai added a comment to D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols..

My impression is that it's an easy enough bug to make with hand-written assembly. I don't know what the probability of a false positive is vs. actual issues being caught.

Tue, Feb 11, 8:04 PM · Restricted Project
smeenai created D74458: [runtimes] Add umbrella targets for runtimes.
Tue, Feb 11, 6:26 PM · Restricted Project
smeenai added a comment to D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh.

I'm assuming this needs to be picked to 10.0?

Yes! Is it up to the authors to integrate their patches to the release branch? I'm seeing @hans is merging a lot of the patches.

Tue, Feb 11, 4:11 PM · Restricted Project, Restricted Project
smeenai added a comment to D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh.

I'm assuming this needs to be picked to 10.0?

Tue, Feb 11, 3:44 PM · Restricted Project, Restricted Project
smeenai committed rG14f870366a93: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs (authored by ianlevesque).
[xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs
Tue, Feb 11, 2:04 PM
smeenai closed D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.
Tue, Feb 11, 2:04 PM · Restricted Project
smeenai accepted D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

LGTM. I'll commit this for you.

Tue, Feb 11, 1:55 PM · Restricted Project
smeenai added a comment to D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

Is it worth adding a test that a function with an explicit xray-instrument attribute also has these other attributes applied?

Tue, Feb 11, 8:54 AM · Restricted Project

Mon, Feb 10

smeenai accepted D74358: Marking internal_dlinfo as unsupported for Android sanitizers to fix runtimes builds..

LGTM, since it's the same as what was done for other unsupported platforms in D73990. There might be some equivalent to RTLD_DI_LINKMAP in Android, but I think it's fine to look into that as a potential follow-up, and to commit this for now to unbreak Android runtimes builds.

Mon, Feb 10, 2:33 PM · Restricted Project, Restricted Project
smeenai added inline comments to D74176: [CMake] Link against ZLIB::ZLIB.
Mon, Feb 10, 9:19 AM · Restricted Project

Fri, Feb 7

smeenai updated subscribers of D73970: [ARM] Fix non-determenistic behaviour.

Do you think it's worth cherry-picking this to 10.0? CC @hans

Fri, Feb 7, 3:01 PM · Restricted Project

Thu, Feb 6

smeenai added a comment to D74176: [CMake] Link against ZLIB::ZLIB.

What does the llvm-config --system-libs output look like with this?

Thu, Feb 6, 4:14 PM · Restricted Project
smeenai added a comment to D74107: [CMake] Use llvm-ar etal for external project build on Darwin.

LGTM

Thu, Feb 6, 3:47 PM · Restricted Project
smeenai accepted D74106: [CMake] Use PUBLIC link mode for static libraries.

Ah, right, I forgot that "linking" includes header dependencies and so on. This makes sense.

Thu, Feb 6, 2:52 PM · Restricted Project
smeenai added a comment to D74106: [CMake] Use PUBLIC link mode for static libraries.

I don't quite understand what's going on here. Are you saying that if you have a static library which depends on an imported library as INTERFACE, targets that link against the static library won't link against the imported library, but if the static library depends on the imported library as PUBLIC, targets that link against the static library will link against the imported library?

Thu, Feb 6, 1:01 PM · Restricted Project
smeenai added a comment to D74107: [CMake] Use llvm-ar etal for external project build on Darwin.

I've never really understood this block, since the APPLE and WIN32/MSVC conditionals here will reflect the host you're building on and not your actual runtimes target, but this change itself looks fine.

They're affected by CMAKE_SYSTEM_NAME which is usually set for the runtimes build so it's not necessarily the host. I'm still not sure whether this condition is desirable though since most of these tools either support APPLE or WIN32 platforms, or CMake will just ignore them and use the appropriate tool for the given platform. This code predates runtimes build and my changes so I don't know what the motivation behind that condition was.

Thu, Feb 6, 12:06 PM · Restricted Project
smeenai accepted D74107: [CMake] Use llvm-ar etal for external project build on Darwin.

I've never really understood this block, since the APPLE and WIN32/MSVC conditionals here will reflect the host you're building on and not your actual runtimes target, but this change itself looks fine.

Thu, Feb 6, 10:49 AM · Restricted Project
smeenai added a comment to D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.

I can commit this for you, but is it possible to write a test case?

Thu, Feb 6, 10:29 AM · Restricted Project

Wed, Feb 5

smeenai added a comment to D74102: [CMake] Link against ZLIB::ZLIB.

Can you check the output of llvm-config --system-libs after this? There's been some issues reported for that after the original change (https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945), such as https://bugs.llvm.org/show_bug.cgi?id=44780.

Wed, Feb 5, 6:44 PM · Restricted Project

Tue, Feb 4

smeenai added a comment to D73442: [CMake] Support symlinking runtimes under a different name.

There's also libraries which are installed outside the resource directory, right? E.g. libc++ and libc++abi.

Tue, Feb 4, 11:11 PM · Restricted Project
smeenai added a comment to D73442: [CMake] Support symlinking runtimes under a different name.

This could be useful for us!

Tue, Feb 4, 11:02 PM · Restricted Project
smeenai added a comment to D72947: [CMake] llvm/runtimes: Do not override LLVM_* variables with just-built LLVM configurations.

Seems reasonable to me.

Tue, Feb 4, 10:43 PM · Restricted Project
smeenai accepted D73840: [CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS.

LGTM

Tue, Feb 4, 10:43 PM · Restricted Project
smeenai accepted D70744: [compiler-rt] Split the builtins CMake build to a separate file.

LGTM

Tue, Feb 4, 5:35 PM · Restricted Project, Restricted Project
smeenai added a comment to D73524: [CMake][DFSan] Don't use cat as it's not available on Windows.

If the input files change, is this gonna automatically trigger a CMake reconfigure? (If not, you'd potentially end up with stale output.)

Tue, Feb 4, 5:35 PM · Restricted Project, Restricted Project
smeenai accepted D73523: [CMake][compiler-rt] Replace Windows backslashes with CMake ones.

At some point we should change this to use the LLVM CMake package instead of llvm-config, but that's way out of scope here, of course.

Tue, Feb 4, 5:26 PM · Restricted Project, Restricted Project
smeenai accepted D73811: [CMake] Passthrough CMAKE_SYSTEM_NAME to default builtin and runtimes target.

This seems like strange behavior on CMake's part, but the change is fine.

Tue, Feb 4, 5:26 PM · Restricted Project

Mon, Feb 3

smeenai accepted D73812: [CMake] Filter libc++abi and libunwind from runtimes build in MSVC.

In that case, looks good with the condition changed to MSVC.

Mon, Feb 3, 2:33 PM · Restricted Project
smeenai added a comment to D73812: [CMake] Filter libc++abi and libunwind from runtimes build in MSVC.

We added support for overriding LLVM_ENABLE_RUNTIMES on a per-target basis for this exact reason in D67195. Does that work for you?

Mon, Feb 3, 12:55 PM · Restricted Project

Wed, Jan 29

smeenai committed rG0423ddfb817a: [build] Fix LLVM_ENABLE_RUNTIMES override condition (authored by smeenai).
[build] Fix LLVM_ENABLE_RUNTIMES override condition
Wed, Jan 29, 1:50 PM
smeenai committed rGfa44d72b9e43: [build] Fix runtimes build after 2e745ba6b0ba (authored by smeenai).
[build] Fix runtimes build after 2e745ba6b0ba
Wed, Jan 29, 12:26 PM

Tue, Jan 28

smeenai added inline comments to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Tue, Jan 28, 6:23 PM · Restricted Project, Restricted Project
smeenai added a reviewer for D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn: compnerd.
Tue, Jan 28, 4:25 PM · Restricted Project
smeenai committed rG076da521f31a: [libcxx] Link against android_support when needed (authored by smeenai).
[libcxx] Link against android_support when needed
Tue, Jan 28, 2:44 PM
smeenai committed rGd8f6950828df: [asan] Fix test compilation on Android API <= 17 (authored by smeenai).
[asan] Fix test compilation on Android API <= 17
Tue, Jan 28, 2:44 PM
smeenai committed rG2e745ba6b0ba: [runtimes] Fix passing lists to runtimes configures (authored by smeenai).
[runtimes] Fix passing lists to runtimes configures
Tue, Jan 28, 2:44 PM
smeenai closed D73512: [runtimes] Fix passing lists to runtimes configures.
Tue, Jan 28, 2:44 PM · Restricted Project
smeenai closed D73516: [libcxx] Link against android_support when needed.
Tue, Jan 28, 2:44 PM · Restricted Project
smeenai closed D73515: [asan] Fix test compilation on Android API <= 17.
Tue, Jan 28, 2:44 PM · Restricted Project, Restricted Project
smeenai added inline comments to D73516: [libcxx] Link against android_support when needed.
Tue, Jan 28, 11:34 AM · Restricted Project
smeenai added a comment to D73516: [libcxx] Link against android_support when needed.

We don't build the NDK's libc++ with CMake. What's the motivation for this?

Tue, Jan 28, 9:51 AM · Restricted Project
smeenai added a reviewer for D73516: [libcxx] Link against android_support when needed: compnerd.
Tue, Jan 28, 9:21 AM · Restricted Project

Mon, Jan 27

Herald added a reviewer for D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows: mclow.lists.
Mon, Jan 27, 7:48 PM · Restricted Project
smeenai added inline comments to D73523: [CMake][compiler-rt] Replace Windows backslashes with CMake ones.
Mon, Jan 27, 7:35 PM · Restricted Project, Restricted Project
smeenai accepted D73524: [CMake][DFSan] Don't use cat as it's not available on Windows.

At some point it would be nice to deduplicate these sorts of utility scripts across all LLVM projects, now that we're on the monorepo.

Mon, Jan 27, 7:35 PM · Restricted Project, Restricted Project
smeenai accepted D73522: [CMake] Set ASM compiler for external projects.

I don't think it's conventional on Windows to use cl for assembly (you'd use ml or ml64 instead), but apparently CMake has a separate ASM_MASM mode for that, and clang-cl works fine for assembly, so LGTM.

Mon, Jan 27, 7:31 PM · Restricted Project
smeenai created D73516: [libcxx] Link against android_support when needed.
Mon, Jan 27, 5:41 PM · Restricted Project
smeenai created D73515: [asan] Fix test compilation on Android API <= 17.
Mon, Jan 27, 5:27 PM · Restricted Project, Restricted Project
smeenai created D73512: [runtimes] Fix passing lists to runtimes configures.
Mon, Jan 27, 5:11 PM · Restricted Project
smeenai committed rG3a5acdc96363: [llvm] Fix file ignoring inside directories (authored by smeenai).
[llvm] Fix file ignoring inside directories
Mon, Jan 27, 5:02 PM
smeenai closed D73253: [llvm] Fix file ignoring inside directories.
Mon, Jan 27, 5:01 PM · Restricted Project
smeenai committed rGa308b98ecbb0: [runtimes] Support install-*-stripped targets (authored by smeenai).
[runtimes] Support install-*-stripped targets
Mon, Jan 27, 5:01 PM
smeenai closed D73252: [runtimes] Support install-*-stripped targets.
Mon, Jan 27, 5:01 PM · Restricted Project
smeenai committed rGb1da8eba60f6: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS (authored by smeenai).
[runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS
Mon, Jan 27, 5:01 PM
smeenai closed D73251: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS.
Mon, Jan 27, 5:01 PM · Restricted Project
smeenai added a comment to D73253: [llvm] Fix file ignoring inside directories.

I'll go ahead and land this as-is, given that the nested layout still has value, and we still need the duplication between the top-level .gitignore and llvm/.gitignore to correctly ignore files in the nested layout.

Mon, Jan 27, 5:00 PM · Restricted Project
smeenai committed rGc72a6ac4b630: Revert "[clang-tidy] readability-identifier-naming disregards parameters… (authored by smeenai).
Revert "[clang-tidy] readability-identifier-naming disregards parameters…
Mon, Jan 27, 11:56 AM
smeenai added a reverting change for rG27e3671ff49b: [clang-tidy] readability-identifier-naming disregards parameters restrictions…: rGc72a6ac4b630: Revert "[clang-tidy] readability-identifier-naming disregards parameters….
Mon, Jan 27, 11:55 AM

Sun, Jan 26

smeenai accepted D73436: [libunwind] Treat assembly files as C on mingw.

LGTM

Sun, Jan 26, 4:06 PM · Restricted Project

Jan 24 2020

smeenai updated subscribers of D72831: [llvm-mc] - Produce R_X86_64_PLT32 relocation for branches with JCC opcodes too..

CC @hans ... there was discussion in https://bugs.llvm.org/show_bug.cgi?id=44397 about whether this is worth picking to 10.0.

Jan 24 2020, 11:10 AM · Restricted Project

Jan 23 2020

smeenai added a comment to D73253: [llvm] Fix file ignoring inside directories.

I think we should instead remove the entire "tracked independently" parts, because that's no longer the recommended directory layout. And also remove these "global" ignores which you moved, because they're already in /.gitignore, and thus don't need to be in /llvm/.gitignore

Jan 23 2020, 2:21 PM · Restricted Project

Jan 22 2020

smeenai added a comment to D72960: Include phabricator.uri in .arcconfig.

I'm assuming git-phab is https://pypi.org/project/git-phab/

Jan 22 2020, 10:43 PM · Restricted Project
smeenai created D73253: [llvm] Fix file ignoring inside directories.
Jan 22 2020, 10:43 PM · Restricted Project
smeenai created D73251: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS.
Jan 22 2020, 10:43 PM · Restricted Project
smeenai created D73252: [runtimes] Support install-*-stripped targets.
Jan 22 2020, 10:43 PM · Restricted Project
smeenai updated the diff for D69195: [libcxx] Fix .gitignore to not exclude test directories.

Comments

Jan 22 2020, 7:04 PM · Restricted Project
smeenai added a comment to D73236: [clang-tidy] Add clang-tidy headers to clang distribution.

This LGTM, but I'll give the clang-tidy developers some time to weigh in.

Jan 22 2020, 5:50 PM · Restricted Project, Restricted Project