Page MenuHomePhabricator
Feed Advanced Search

Yesterday

atanasyan committed rG5f7d6ac7bf3b: [mips] Reduce number of instructions used for loading a global symbol's value (authored by atanasyan).
[mips] Reduce number of instructions used for loading a global symbol's value
Fri, Aug 23, 6:39 AM
atanasyan committed rG58492b1895e2: [mips] Do not include offset into `%got` expression for global symbols (authored by atanasyan).
[mips] Do not include offset into `%got` expression for global symbols
Fri, Aug 23, 6:38 AM
atanasyan committed rL369756: [mips] Reduce number of instructions used for loading a global symbol's value.
[mips] Reduce number of instructions used for loading a global symbol's value
Fri, Aug 23, 6:38 AM
atanasyan committed rL369755: [mips] Do not include offset into `%got` expression for global symbols.
[mips] Do not include offset into `%got` expression for global symbols
Fri, Aug 23, 6:38 AM
atanasyan closed D66552: [mips] Do not include offset into `%got` expression for global symbols.
Fri, Aug 23, 6:38 AM · Restricted Project
atanasyan closed D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Fri, Aug 23, 6:38 AM · Restricted Project

Wed, Aug 21

atanasyan added a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66552: [mips] Do not include offset into `%got` expression for global symbols.
Wed, Aug 21, 1:49 PM · Restricted Project
atanasyan added a child revision for D66552: [mips] Do not include offset into `%got` expression for global symbols: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Wed, Aug 21, 1:49 PM · Restricted Project
atanasyan removed a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Wed, Aug 21, 1:44 PM · Restricted Project
atanasyan removed a child revision for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Wed, Aug 21, 1:44 PM · Restricted Project
atanasyan added a reviewer for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: Petar.Avramovic.
Wed, Aug 21, 1:42 PM · Restricted Project
atanasyan added a reviewer for D66552: [mips] Do not include offset into `%got` expression for global symbols: Petar.Avramovic.
Wed, Aug 21, 1:42 PM · Restricted Project
atanasyan added a parent revision for D66553: [mips] Reduce number of instructions used for loading a global symbol's value: D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Wed, Aug 21, 1:41 PM · Restricted Project
atanasyan created D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Wed, Aug 21, 1:41 PM · Restricted Project
atanasyan updated the summary of D66552: [mips] Do not include offset into `%got` expression for global symbols.
Wed, Aug 21, 1:41 PM · Restricted Project
atanasyan added a child revision for D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result: D66553: [mips] Reduce number of instructions used for loading a global symbol's value.
Wed, Aug 21, 1:41 PM · Restricted Project
atanasyan created D66552: [mips] Do not include offset into `%got` expression for global symbols.
Wed, Aug 21, 1:41 PM · Restricted Project
atanasyan committed rG159f621c5c84: [mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC (authored by atanasyan).
[mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC
Wed, Aug 21, 11:59 AM
atanasyan committed rGbb2f85724722: [mips] Remove duplicated case from the `StringSwitch`. NFC (authored by atanasyan).
[mips] Remove duplicated case from the `StringSwitch`. NFC
Wed, Aug 21, 11:58 AM
atanasyan committed rL369563: [mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC.
[mips] Replace call `expandLoadAddress` by `loadAndAddSymbolAddress`. NFC
Wed, Aug 21, 11:58 AM
atanasyan committed rL369562: [mips] Remove duplicated case from the `StringSwitch`. NFC.
[mips] Remove duplicated case from the `StringSwitch`. NFC
Wed, Aug 21, 11:58 AM
atanasyan committed rL369526: Add 9.0 release bug to merge request script.
Add 9.0 release bug to merge request script
Wed, Aug 21, 6:47 AM
atanasyan committed rG4d668a1f077d: Add 9.0 release bug to merge request script (authored by atanasyan).
Add 9.0 release bug to merge request script
Wed, Aug 21, 6:46 AM

Mon, Aug 19

atanasyan added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

Thanks for review. Could you clarify some points in your comments?

Mon, Aug 19, 1:40 PM · Restricted Project

Fri, Aug 16

atanasyan added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

@sdardis What is the difference between MipsHi and MipsLo SD nodes? Some of their patterns are the same, e.g. :

Fri, Aug 16, 3:48 AM · Restricted Project

Thu, Aug 15

atanasyan added inline comments to D63284: [libc++] Keep __regex_word in sync with ctype_base.
Thu, Aug 15, 10:13 PM · Restricted Project, Restricted Project

Wed, Aug 14

atanasyan created D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.
Wed, Aug 14, 9:36 AM · Restricted Project
atanasyan committed rGdc8dcb615832: [mips] Remove redundant case in the test. NFC (authored by atanasyan).
[mips] Remove redundant case in the test. NFC
Wed, Aug 14, 9:28 AM
atanasyan committed rG25e021ad5fc5: [mips] Split long lines in the test case file. NFC (authored by atanasyan).
[mips] Split long lines in the test case file. NFC
Wed, Aug 14, 9:28 AM
atanasyan committed rL368870: [mips] Remove redundant case in the test. NFC.
[mips] Remove redundant case in the test. NFC
Wed, Aug 14, 9:28 AM
atanasyan committed rL368869: [mips] Split long lines in the test case file. NFC.
[mips] Split long lines in the test case file. NFC
Wed, Aug 14, 9:27 AM
atanasyan accepted D66205: [MIPS GlobalISel] NarrowScalar G_ZEXTLOAD and G_SEXTLOAD.

LGTM

Wed, Aug 14, 9:24 AM · Restricted Project
atanasyan accepted D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT.

LGTM

Wed, Aug 14, 9:24 AM · Restricted Project
atanasyan accepted D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882.

LGTM

Wed, Aug 14, 9:01 AM · Restricted Project
atanasyan accepted D66202: [MIPS GlobalISel] NarrowScalar G_TRUNC .

LGTM

Wed, Aug 14, 9:01 AM · Restricted Project

Mon, Aug 12

atanasyan accepted D66127: [ELF] Fix odd variable names "New" after r365730. NFC.

LGTM

Mon, Aug 12, 11:01 PM · Restricted Project

Fri, Aug 9

atanasyan committed rG242c5a70d488: [Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers (authored by atanasyan).
[Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers
Fri, Aug 9, 5:05 AM
atanasyan committed rL368433: [Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers.
[Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers
Fri, Aug 9, 5:02 AM
atanasyan closed D65886: [Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers.
Fri, Aug 9, 5:02 AM · Restricted Project
atanasyan accepted D65886: [Mips][Codegen] Fix fast-isel mixing of FGR64 and AFGR64 registers.

LGTM

Fri, Aug 9, 4:46 AM · Restricted Project
atanasyan added a comment to D65830: [docs][mips] 9.0 Release notes.

Thanks!

Fri, Aug 9, 3:03 AM · Restricted Project

Wed, Aug 7

atanasyan added a comment to D65830: [docs][mips] 9.0 Release notes.

Thanks for review. Hans, could you please commit this patch? I'm not sure that I know how to commit to the not-master branch in the monorepo repository.

Wed, Aug 7, 1:24 PM · Restricted Project
atanasyan accepted D65861: [MIPS GlobalISel] Select jump_table and brjt.

LGTM

Wed, Aug 7, 7:18 AM · Restricted Project
atanasyan updated the diff for D65830: [docs][mips] 9.0 Release notes.
  • Fix grammar errors.
  • Add details for the MIPS GlobalISel note.
Wed, Aug 7, 6:19 AM · Restricted Project
atanasyan committed rGe5fa049efaf3: [mips] Make a couple of class methods plain static functions. NFC (authored by atanasyan).
[mips] Make a couple of class methods plain static functions. NFC
Wed, Aug 7, 5:22 AM
atanasyan committed rG8a7c0e7c0a56: [mips] Use isMicroMips() function to check enabled feature flag. NFC (authored by atanasyan).
[mips] Use isMicroMips() function to check enabled feature flag. NFC
Wed, Aug 7, 5:22 AM
atanasyan committed rG9f2e076f2730: [Mips] Instruction `sc` now accepts symbol as an argument (authored by atanasyan).
[Mips] Instruction `sc` now accepts symbol as an argument
Wed, Aug 7, 5:22 AM
atanasyan committed rL368162: [mips] Make a couple of class methods plain static functions. NFC.
[mips] Make a couple of class methods plain static functions. NFC
Wed, Aug 7, 5:22 AM
atanasyan committed rL368161: [mips] Use isMicroMips() function to check enabled feature flag. NFC.
[mips] Use isMicroMips() function to check enabled feature flag. NFC
Wed, Aug 7, 5:22 AM
atanasyan committed rL368160: [Mips] Instruction `sc` now accepts symbol as an argument.
[Mips] Instruction `sc` now accepts symbol as an argument
Wed, Aug 7, 5:21 AM
atanasyan closed D64252: [Mips] Instruction `sc` now accepts symbol as an argument.
Wed, Aug 7, 5:21 AM · Restricted Project
atanasyan accepted D64252: [Mips] Instruction `sc` now accepts symbol as an argument.

LGTM with a few nits. I will fix them by myself before committing the patch.

Wed, Aug 7, 4:08 AM · Restricted Project

Tue, Aug 6

atanasyan created D65830: [docs][mips] 9.0 Release notes.
Tue, Aug 6, 2:10 PM · Restricted Project
atanasyan accepted D65807: [obj2yaml] - MIPS: move and improve testing of the e_flags.

LGTM. Nice

Tue, Aug 6, 8:11 AM · Restricted Project
atanasyan added a comment to D65807: [obj2yaml] - MIPS: move and improve testing of the e_flags.

I like the idea. But please note that I deleted yaml2obj-elf-file-headers-with-e_flags.yaml at rL368023 because the same functionality is checked by the Mips/elf-flags.yaml. When this patch is applied or as a part of the applying, we can delete Mips/elf-flags.yaml as well.

Tue, Aug 6, 7:29 AM · Restricted Project
atanasyan committed rG2fbf58c6e6cf: [llvm/test/Object] Remove redundant test case. NFC (authored by atanasyan).
[llvm/test/Object] Remove redundant test case. NFC
Tue, Aug 6, 5:42 AM
atanasyan committed rL368023: [llvm/test/Object] Remove redundant test case. NFC.
[llvm/test/Object] Remove redundant test case. NFC
Tue, Aug 6, 5:41 AM

Thu, Aug 1

atanasyan committed rG0620cf11ec2d: [mips] Fix lowering load/store instruction in PIC case (authored by atanasyan).
[mips] Fix lowering load/store instruction in PIC case
Thu, Aug 1, 9:07 AM
atanasyan committed rL367580: [mips] Fix lowering load/store instruction in PIC case.
[mips] Fix lowering load/store instruction in PIC case
Thu, Aug 1, 9:04 AM
atanasyan closed D65524: [mips] Fix lowering load/store instruction in PIC case.
Thu, Aug 1, 9:03 AM · Restricted Project
atanasyan added a comment to D65524: [mips] Fix lowering load/store instruction in PIC case.

Thanks.

Thu, Aug 1, 9:03 AM · Restricted Project

Wed, Jul 31

atanasyan created D65524: [mips] Fix lowering load/store instruction in PIC case.
Wed, Jul 31, 10:14 AM · Restricted Project
atanasyan accepted D65507: [MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT.

LGTM with a few nits.

Wed, Jul 31, 10:09 AM · Restricted Project

Sat, Jul 27

atanasyan committed rG6faac434ed67: [mips] Add (dis)assembler tests for beqzl and bnezl instructions. NFC (authored by atanasyan).
[mips] Add (dis)assembler tests for beqzl and bnezl instructions. NFC
Sat, Jul 27, 1:15 AM
atanasyan committed rL367168: [mips] Add (dis)assembler tests for beqzl and bnezl instructions. NFC.
[mips] Add (dis)assembler tests for beqzl and bnezl instructions. NFC
Sat, Jul 27, 1:15 AM
atanasyan added a comment to D6016: [mips] MIPS BEQZL and BNEZL instructions.

Should we also add the (dis)assembler tests or are these case covered in other tests?

Sat, Jul 27, 1:15 AM

Fri, Jul 26

atanasyan accepted D65217: [MIPS GlobalISel] Select inttoptr and ptrtoint .

LGTM

Fri, Jul 26, 5:03 AM · Restricted Project

Jul 25 2019

atanasyan added inline comments to D64252: [Mips] Instruction `sc` now accepts symbol as an argument.
Jul 25 2019, 6:18 AM · Restricted Project

Jul 24 2019

atanasyan committed rG5adbfdda2db9: [mips] Assign R_TLS type to the R_MIPS_TLS_TPREL_XXX relocations. NFC (authored by atanasyan).
[mips] Assign R_TLS type to the R_MIPS_TLS_TPREL_XXX relocations. NFC
Jul 24 2019, 4:41 AM
atanasyan committed rL366888: [mips] Assign R_TLS type to the R_MIPS_TLS_TPREL_XXX relocations. NFC.
[mips] Assign R_TLS type to the R_MIPS_TLS_TPREL_XXX relocations. NFC
Jul 24 2019, 4:37 AM
atanasyan abandoned D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

Fixed at D9114.

Jul 24 2019, 2:49 AM
atanasyan commandeered D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..
Jul 24 2019, 2:49 AM

Jul 22 2019

atanasyan edited reviewers for D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking., added: atanasyan; removed: dsanders.
Jul 22 2019, 2:28 PM

Jul 17 2019

atanasyan added inline comments to D58232: GlobalISel: Don't materialize immarg arguments to intrinsics.
Jul 17 2019, 11:01 AM
atanasyan accepted D64856: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.

LGTM

Jul 17 2019, 4:51 AM · Restricted Project
atanasyan accepted D64778: Mips: Remove immarg from copy and insert intrinsics.

LGTM

Jul 17 2019, 2:43 AM
atanasyan committed rG1292464125fd: [mips] Remove redundant test case. NFC (authored by atanasyan).
[mips] Remove redundant test case. NFC
Jul 17 2019, 1:14 AM
atanasyan committed rG6d4b1c046b82: [mips] Name inline asm constraint test cases in a uniform manner. NFC (authored by atanasyan).
[mips] Name inline asm constraint test cases in a uniform manner. NFC
Jul 17 2019, 1:14 AM
atanasyan committed rG7f308af5eeea: [mips] Support the "o" inline asm constraint (authored by atanasyan).
[mips] Support the "o" inline asm constraint
Jul 17 2019, 1:14 AM
atanasyan committed rG4c1e4408927e: [mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64 (authored by atanasyan).
[mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64
Jul 17 2019, 1:14 AM
atanasyan committed rGa884afb6f8ea: [mips] Implement .cplocal directive (authored by atanasyan).
[mips] Implement .cplocal directive
Jul 17 2019, 1:14 AM
atanasyan committed rL366302: [mips] Name inline asm constraint test cases in a uniform manner. NFC.
[mips] Name inline asm constraint test cases in a uniform manner. NFC
Jul 17 2019, 1:14 AM
atanasyan committed rL366303: [mips] Remove redundant test case. NFC.
[mips] Remove redundant test case. NFC
Jul 17 2019, 1:14 AM
atanasyan committed rL366300: [mips] Implement .cplocal directive.
[mips] Implement .cplocal directive
Jul 17 2019, 1:14 AM
atanasyan committed rL366301: [mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64.
[mips] Use mult/mflo pattern on 64-bit targets prior to MIPS64
Jul 17 2019, 1:14 AM
atanasyan closed D64743: [mips] Implement .cplocal directive.
Jul 17 2019, 1:14 AM · Restricted Project
atanasyan committed rL366299: [mips] Support the "o" inline asm constraint.
[mips] Support the "o" inline asm constraint
Jul 17 2019, 1:13 AM
atanasyan closed D64792: [mips] Support the "o" inline asm constraint.
Jul 17 2019, 1:13 AM · Restricted Project

Jul 16 2019

atanasyan created D64792: [mips] Support the "o" inline asm constraint.
Jul 16 2019, 5:32 AM · Restricted Project

Jul 15 2019

atanasyan added a comment to D6016: [mips] MIPS BEQZL and BNEZL instructions.

Maybe we should add the tests that this patch had since they were not added in rL234401.
rL234401 also disabled printing of the alias instruction while it's enabled in here. Not sure which one is preferable.

Jul 15 2019, 2:53 PM
atanasyan committed rGbecae2b2324f: [mips] Print BEQZL and BNEZL pseudo instructions (authored by atanasyan).
[mips] Print BEQZL and BNEZL pseudo instructions
Jul 15 2019, 2:47 PM
atanasyan committed rL366133: [mips] Print BEQZL and BNEZL pseudo instructions.
[mips] Print BEQZL and BNEZL pseudo instructions
Jul 15 2019, 2:47 PM
atanasyan created D64743: [mips] Implement .cplocal directive.
Jul 15 2019, 7:39 AM · Restricted Project
atanasyan committed rG83ae0b5eb4f8: [mips] Remove "else-after-return". NFC (authored by atanasyan).
[mips] Remove "else-after-return". NFC
Jul 15 2019, 6:13 AM
atanasyan committed rL366064: [mips] Remove "else-after-return". NFC.
[mips] Remove "else-after-return". NFC
Jul 15 2019, 6:12 AM

Jul 12 2019

atanasyan abandoned D10119: [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.

Implemented at the rL246999.

Jul 12 2019, 10:55 PM
atanasyan commandeered D10119: [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.
Jul 12 2019, 10:55 PM
atanasyan abandoned D8823: [mips][microMIPSr6] Implement LL and SC instructions.

Implemented at the rL332820.

Jul 12 2019, 10:48 PM
atanasyan commandeered D8823: [mips][microMIPSr6] Implement LL and SC instructions.
Jul 12 2019, 10:47 PM
atanasyan abandoned D6016: [mips] MIPS BEQZL and BNEZL instructions.

Implemented at the rL234401.

Jul 12 2019, 10:43 PM