Page MenuHomePhabricator
Feed Advanced Search

Today

atanasyan accepted D63541: [MIPS GlobalISel] Select floating point to integer conversions.

LGTM with a couple nits.

Wed, Jun 19, 7:51 AM · Restricted Project
atanasyan accepted D63542: [MIPS GlobalISel] Select integer to floating point conversions.

LGTM

Wed, Jun 19, 7:51 AM · Restricted Project

Yesterday

atanasyan committed rG796e7f872411: [mips] Add more strict predicates to the RSQRT_S_MM and TAILCALL_MM (authored by atanasyan).
[mips] Add more strict predicates to the RSQRT_S_MM and TAILCALL_MM
Tue, Jun 18, 9:58 AM
atanasyan committed rG60a9d0c248b1: [mips] Add PTR_64 and GPR_64 predicates to some MIPS 64-bit instructions (authored by atanasyan).
[mips] Add PTR_64 and GPR_64 predicates to some MIPS 64-bit instructions
Tue, Jun 18, 9:57 AM
atanasyan committed rG9086ba8763a9: [mips] Set the hasNoSchedulingInfo flag for the `MipsAsmPseudoInst` (authored by atanasyan).
[mips] Set the hasNoSchedulingInfo flag for the `MipsAsmPseudoInst`
Tue, Jun 18, 9:57 AM
atanasyan committed rL363703: [mips] Add more strict predicates to the RSQRT_S_MM and TAILCALL_MM.
[mips] Add more strict predicates to the RSQRT_S_MM and TAILCALL_MM
Tue, Jun 18, 9:57 AM
atanasyan committed rL363702: [mips] Add PTR_64 and GPR_64 predicates to some MIPS 64-bit instructions.
[mips] Add PTR_64 and GPR_64 predicates to some MIPS 64-bit instructions
Tue, Jun 18, 9:57 AM
atanasyan committed rL363701: [mips] Set the hasNoSchedulingInfo flag for the `MipsAsmPseudoInst`.
[mips] Set the hasNoSchedulingInfo flag for the `MipsAsmPseudoInst`
Tue, Jun 18, 9:57 AM
atanasyan closed D63237: [mips] Add PTR64 and GPR_64 predicates to some MIPS 64-bit instructions.
Tue, Jun 18, 9:57 AM · Restricted Project
atanasyan closed D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`.
Tue, Jun 18, 9:57 AM · Restricted Project

Mon, Jun 17

atanasyan added a comment to D63383: [ELF][ARM][AARCH64][MIPS][PPC] Simplify the logic to create R_*_RELATIVE for absolute relocation types in writable sections.

The MIPS part of changes looks good.

Mon, Jun 17, 12:24 PM · Restricted Project

Sun, Jun 16

atanasyan updated the diff for D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`.
  • Use hasNoSchedulingInfo flag
Sun, Jun 16, 2:29 PM · Restricted Project
atanasyan added inline comments to D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`.
Sun, Jun 16, 2:29 PM · Restricted Project

Wed, Jun 12

atanasyan created D63237: [mips] Add PTR64 and GPR_64 predicates to some MIPS 64-bit instructions.
Wed, Jun 12, 5:08 PM · Restricted Project
atanasyan created D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`.
Wed, Jun 12, 5:03 PM · Restricted Project
atanasyan committed rGefc0d1a29801: [Mips] Add s.d instruction alias for Mips1 (authored by atanasyan).
[Mips] Add s.d instruction alias for Mips1
Wed, Jun 12, 10:52 AM
atanasyan committed rL363184: [Mips] Add s.d instruction alias for Mips1.
[Mips] Add s.d instruction alias for Mips1
Wed, Jun 12, 10:51 AM
atanasyan closed D63199: [Mips] Add s.d instruction alias for Mips1.
Wed, Jun 12, 10:51 AM · Restricted Project
atanasyan accepted D63199: [Mips] Add s.d instruction alias for Mips1.

LGTM

Wed, Jun 12, 10:41 AM · Restricted Project

Wed, Jun 5

atanasyan accepted D62905: [MIPS GlobalISel] Select sqrt.

LGTM

Wed, Jun 5, 1:15 PM · Restricted Project
atanasyan accepted D62903: [MIPS GlobalISel] Select fabs.

LGTM

Wed, Jun 5, 1:12 PM · Restricted Project
atanasyan accepted D62902: [MIPS GlobalISel] Select fpext and fptrunc.

LGTM

Wed, Jun 5, 1:12 PM · Restricted Project
atanasyan accepted D62901: [MIPS GlobalISel] Select floor and ceil.

LGTM with a nit.

Wed, Jun 5, 1:10 PM · Restricted Project

Mon, Jun 3

atanasyan added reviewers for D62653: [Mips][DSP] Fix physregs incorrectly marked as dead.: efriedma, RKSimon.
Mon, Jun 3, 12:28 PM
atanasyan added a comment to D62653: [Mips][DSP] Fix physregs incorrectly marked as dead..

Is it possible to add tests to check the changes?

Mon, Jun 3, 10:26 AM
atanasyan accepted D62721: [MIPS GlobalISel] Select fcmp.

LGTM wit a nit.

Mon, Jun 3, 2:16 AM · Restricted Project

Sat, Jun 1

atanasyan committed rG25694e008444: [mips] Extend range of register indexes accepted by cfcmsa/ctcmsa (authored by atanasyan).
[mips] Extend range of register indexes accepted by cfcmsa/ctcmsa
Sat, Jun 1, 6:54 AM
atanasyan committed rL362299: [mips] Extend range of register indexes accepted by cfcmsa/ctcmsa.
[mips] Extend range of register indexes accepted by cfcmsa/ctcmsa
Sat, Jun 1, 6:54 AM
atanasyan closed D62597: [mips] Extend range of register indexes accepted by cfcmsa/ctcmsa.
Sat, Jun 1, 6:54 AM · Restricted Project

Fri, May 31

atanasyan accepted D62590: [MIPS GlobalISel] Add detailed tests for lower call .

LGTM

Fri, May 31, 12:13 AM · Restricted Project
atanasyan accepted D62589: [MIPS GlobalISel] Handle position independent code .

LGTM with a nit.

Fri, May 31, 12:01 AM · Restricted Project

Thu, May 30

atanasyan accepted D62585: [MIPS GlobalISel] Lower call for callee that is register.

LGTM

Thu, May 30, 11:41 PM · Restricted Project
atanasyan accepted D62586: [mips] Move initGlobalBaseReg to MipsFunctionInfo. NFC.

LGTM

Thu, May 30, 11:25 PM · Restricted Project

Wed, May 29

atanasyan created D62597: [mips] Extend range of register indexes accepted by cfcmsa/ctcmsa.
Wed, May 29, 8:10 AM · Restricted Project
atanasyan committed rGc7f0b33fa5b0: [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa (authored by atanasyan).
[mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa
Wed, May 29, 8:01 AM
atanasyan committed rG909c8c2b0d93: [mips] Use reg-exp in tests to tolerate register indexes changing. NFC (authored by atanasyan).
[mips] Use reg-exp in tests to tolerate register indexes changing. NFC
Wed, May 29, 8:01 AM
atanasyan committed rG188162118f17: [mips] Iterate over MSACtrlRegClass to reserve all MSA control registers. NFC (authored by atanasyan).
[mips] Iterate over MSACtrlRegClass to reserve all MSA control registers. NFC
Wed, May 29, 8:00 AM
atanasyan committed rGaf7bf2f68733: [mips] Use range-based for loops. NFC (authored by atanasyan).
[mips] Use range-based for loops. NFC
Wed, May 29, 8:00 AM
atanasyan committed rL361967: [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa.
[mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa
Wed, May 29, 8:00 AM
atanasyan committed rC361967: [mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa.
[mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa
Wed, May 29, 8:00 AM
atanasyan committed rL361966: [mips] Use reg-exp in tests to tolerate register indexes changing. NFC.
[mips] Use reg-exp in tests to tolerate register indexes changing. NFC
Wed, May 29, 8:00 AM
atanasyan committed rL361965: [mips] Iterate over MSACtrlRegClass to reserve all MSA control registers. NFC.
[mips] Iterate over MSACtrlRegClass to reserve all MSA control registers. NFC
Wed, May 29, 8:00 AM
atanasyan committed rL361964: [mips] Use range-based for loops. NFC.
[mips] Use range-based for loops. NFC
Wed, May 29, 7:55 AM

Fri, May 24

atanasyan added a comment to D62256: [llvm-readobj] Implement GNU-style output for dynamic table.

Thanks for review.

Fri, May 24, 5:55 AM · Restricted Project
atanasyan committed rG8362cbe13b32: [llvm-readobj] Implement GNU-style output for dynamic table (authored by atanasyan).
[llvm-readobj] Implement GNU-style output for dynamic table
Fri, May 24, 5:22 AM
atanasyan committed rL361633: [llvm-readobj] Implement GNU-style output for dynamic table.
[llvm-readobj] Implement GNU-style output for dynamic table
Fri, May 24, 5:22 AM
atanasyan committed rLLD361633: [llvm-readobj] Implement GNU-style output for dynamic table.
[llvm-readobj] Implement GNU-style output for dynamic table
Fri, May 24, 5:22 AM
atanasyan closed D62256: [llvm-readobj] Implement GNU-style output for dynamic table.
Fri, May 24, 5:22 AM · Restricted Project
atanasyan added a comment to D62341: [DAGCombine][X86][AArch64][AMDGPU][MIPS][PPC] (sub x, c) -> (add x, -c) vector edition..

I do not think it's good for MIPS because this patch replace one subvi instruction by pair of ldi and addv. Are you going to fix such regressions?

Fri, May 24, 4:28 AM · Restricted Project
atanasyan committed rGe4f01ec50c46: [llvm-readobj][mips] Align GOT columns headers properly in 64-bit case (authored by atanasyan).
[llvm-readobj][mips] Align GOT columns headers properly in 64-bit case
Fri, May 24, 3:25 AM
atanasyan committed rL361626: [llvm-readobj][mips] Align GOT columns headers properly in 64-bit case.
[llvm-readobj][mips] Align GOT columns headers properly in 64-bit case
Fri, May 24, 3:24 AM
atanasyan committed rGc1b482f2a5d0: [mips] Always check that `shift and add` optimization is efficient. (authored by atanasyan).
[mips] Always check that `shift and add` optimization is efficient.
Fri, May 24, 1:40 AM
atanasyan added a comment to D62166: [mips] Always check that `shift and add` optimization is efficient.

Thanks for review.

Fri, May 24, 1:39 AM · Restricted Project
atanasyan committed rL361606: [mips] Always check that `shift and add` optimization is efficient..
[mips] Always check that `shift and add` optimization is efficient.
Fri, May 24, 1:37 AM
atanasyan closed D62166: [mips] Always check that `shift and add` optimization is efficient.
Fri, May 24, 1:37 AM · Restricted Project

Thu, May 23

atanasyan added a comment to D62166: [mips] Always check that `shift and add` optimization is efficient.

I've raised some points inline, I think (a) is most relevant to this patch but shouldn't stop it going forward but should be addressed quickly, (b) and (c) could be noted as TODO:s.

Thu, May 23, 6:04 AM · Restricted Project
atanasyan updated the diff for D62166: [mips] Always check that `shift and add` optimization is efficient.
  • Add TODO comment
Thu, May 23, 6:03 AM · Restricted Project
atanasyan updated the diff for D62256: [llvm-readobj] Implement GNU-style output for dynamic table.
  • Move code cuts dynamic table after the first DT_NULL entry into the dynamic_table() method.
  • Print dynamic table header as a single string without multiple << operators.
Thu, May 23, 5:08 AM · Restricted Project

Wed, May 22

atanasyan updated the diff for D62256: [llvm-readobj] Implement GNU-style output for dynamic table.
  • Add tests with the strict-whitespace flag to check headers alignment.
  • Replace for by while.
  • Add space between too long dynamic table tag name and it's value.
Wed, May 22, 10:05 AM · Restricted Project
atanasyan added a comment to D62256: [llvm-readobj] Implement GNU-style output for dynamic table.

I think the header row is apparently misaligned. Not sure we want to misalign ourselves...

Wed, May 22, 9:05 AM · Restricted Project
atanasyan created D62256: [llvm-readobj] Implement GNU-style output for dynamic table.
Wed, May 22, 8:10 AM · Restricted Project
atanasyan committed rG74b791b4f721: [mips] Use GNU-style output to make tests smaller. NFC (authored by atanasyan).
[mips] Use GNU-style output to make tests smaller. NFC
Wed, May 22, 8:02 AM
atanasyan committed rG84f929d00ce7: [mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC (authored by atanasyan).
[mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC
Wed, May 22, 8:02 AM
atanasyan committed rL361394: [mips] Use GNU-style output to make tests smaller. NFC.
[mips] Use GNU-style output to make tests smaller. NFC
Wed, May 22, 8:02 AM
atanasyan committed rLLD361394: [mips] Use GNU-style output to make tests smaller. NFC.
[mips] Use GNU-style output to make tests smaller. NFC
Wed, May 22, 8:02 AM
atanasyan committed rL361393: [mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC.
[mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC
Wed, May 22, 8:01 AM
atanasyan committed rLLD361393: [mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC.
[mips] Replace multiple `-check-prefix` by single `-check-prefixes`. NFC
Wed, May 22, 8:01 AM
atanasyan accepted D61787: [GlobalISel Legalizer] Improve artifact combiner.

LGTM, but as I said early please wait another approval.

Wed, May 22, 12:29 AM · Restricted Project

Tue, May 21

atanasyan updated the diff for D62166: [mips] Always check that `shift and add` optimization is efficient.
  • Simplify the loop condition
Tue, May 21, 7:39 AM · Restricted Project

Mon, May 20

atanasyan updated the diff for D62166: [mips] Always check that `shift and add` optimization is efficient.
  • Make the code more compact
  • Remove magical constant from the loop condition
Mon, May 20, 11:10 PM · Restricted Project
atanasyan created D62166: [mips] Always check that `shift and add` optimization is efficient.
Mon, May 20, 3:43 PM · Restricted Project

May 15 2019

atanasyan committed rCRT360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
May 15 2019, 3:28 PM
atanasyan added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I hope the rL360825 fixes the problem so this patch can be switch to the abandoned state.

May 15 2019, 3:28 PM · Restricted Project, Restricted Project
atanasyan committed rG7684d05d95b9: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit (authored by atanasyan).
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
May 15 2019, 3:28 PM
atanasyan committed rL360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.
[mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit
May 15 2019, 3:25 PM
atanasyan committed rG0b0cc23fb610: [mips] Use range-based `for` loops. NFC (authored by atanasyan).
[mips] Use range-based `for` loops. NFC
May 15 2019, 2:27 PM
atanasyan committed rL360817: [mips] Use range-based `for` loops. NFC.
[mips] Use range-based `for` loops. NFC
May 15 2019, 2:27 PM
atanasyan added inline comments to D61787: [GlobalISel Legalizer] Improve artifact combiner.
May 15 2019, 6:39 AM · Restricted Project
atanasyan committed rG4c68c5ae7194: [mips] LLVM and GAS now use same instructions for CFA Definition. NFCI (authored by atanasyan).
[mips] LLVM and GAS now use same instructions for CFA Definition. NFCI
May 15 2019, 5:04 AM
atanasyan committed rL360765: [mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.
[mips] LLVM and GAS now use same instructions for CFA Definition. NFCI
May 15 2019, 5:04 AM
atanasyan closed D61899: [Mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.
May 15 2019, 5:04 AM · Restricted Project
atanasyan added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

LGTM with a few nits. But I'm not an expert in GlobalISel so get reply from other reviewers.

May 15 2019, 3:55 AM · Restricted Project
atanasyan accepted D61899: [Mips] LLVM and GAS now use same instructions for CFA Definition. NFCI.

LGTM

May 15 2019, 2:50 AM · Restricted Project
atanasyan added a comment to D61563: [ELF] Error on relocations to local undefined symbols.

I do not remember a reason of adding the .reloc 0, R_MIPS_GOT_PAGE, 0 statement to the test. I think now we can change mips-abs-got.s like that:

--- a/lld/test/ELF/mips-abs-got.s
+++ b/lld/test/ELF/mips-abs-got.s
@@ -4,7 +4,7 @@
May 15 2019, 1:54 AM · Restricted Project

May 7 2019

atanasyan committed rG3bdb81c26da6: [mips] Fix ld instruction in PLT entries on MIPS64 (authored by atanasyan).
[mips] Fix ld instruction in PLT entries on MIPS64
May 7 2019, 1:26 PM
atanasyan committed rG494b763cfc6a: [mips] Rename test case. NFC (authored by atanasyan).
[mips] Rename test case. NFC
May 7 2019, 1:26 PM
atanasyan committed rL360187: [mips] Fix ld instruction in PLT entries on MIPS64.
[mips] Fix ld instruction in PLT entries on MIPS64
May 7 2019, 1:25 PM
atanasyan committed rLLD360187: [mips] Fix ld instruction in PLT entries on MIPS64.
[mips] Fix ld instruction in PLT entries on MIPS64
May 7 2019, 1:25 PM
atanasyan closed D61586: [mips] fix segment fault for plt on mips64..
May 7 2019, 1:25 PM · lld, Restricted Project
atanasyan committed rLLD360186: [mips] Rename test case. NFC.
[mips] Rename test case. NFC
May 7 2019, 1:25 PM
atanasyan committed rL360186: [mips] Rename test case. NFC.
[mips] Rename test case. NFC
May 7 2019, 1:25 PM

May 6 2019

atanasyan added a comment to D61586: [mips] fix segment fault for plt on mips64..

Good catch, thanks. BTW on what OS do you get this problem? PLT records on MIPS 64-bit code are not widely used.

May 6 2019, 3:45 AM · lld, Restricted Project

May 5 2019

atanasyan abandoned D21292: [mips] Correct ELF format for N32..

Now LLVM/Clang generates correct relocations for N32 ABI:

$ clang -target mips64 -mabi=n32 -mcpu=mips4 -fpic -fPIC -mabicalls -integrated-as -c main.c -o -| llvm-readobj -r -                
May 5 2019, 12:32 AM
atanasyan commandeered D21292: [mips] Correct ELF format for N32..
May 5 2019, 12:32 AM

Apr 27 2019

atanasyan committed rGb82144b6e4b5: [cmake] Disable a GCC optimization when building LLVM for MIPS (authored by atanasyan).
[cmake] Disable a GCC optimization when building LLVM for MIPS
Apr 27 2019, 2:28 AM
atanasyan committed rL359376: [cmake] Disable a GCC optimization when building LLVM for MIPS.
[cmake] Disable a GCC optimization when building LLVM for MIPS
Apr 27 2019, 2:28 AM
atanasyan closed D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.
Apr 27 2019, 2:28 AM · Restricted Project

Apr 25 2019

atanasyan committed rGa0291110da68: [MIPS] Use custom bitcast lowering to avoid excessive instructions (authored by atanasyan).
[MIPS] Use custom bitcast lowering to avoid excessive instructions
Apr 25 2019, 12:46 AM
atanasyan committed rL359171: [MIPS] Use custom bitcast lowering to avoid excessive instructions.
[MIPS] Use custom bitcast lowering to avoid excessive instructions
Apr 25 2019, 12:45 AM
atanasyan closed D61069: [MIPS] Use custom bitcast lowering to avoid excessive instructions.
Apr 25 2019, 12:45 AM · Restricted Project