Page MenuHomePhabricator
Feed Advanced Search

Apr 18 2019

metzman committed rL358703: Summary:.
Summary:
Apr 18 2019, 11:48 AM
metzman committed rCRT358703: Summary:.
Summary:
Apr 18 2019, 11:48 AM
metzman closed D60334: Summary: Add close_fd_mask functionality to AFL driver..
Apr 18 2019, 11:48 AM · Restricted Project, Restricted Project

Apr 10 2019

metzman committed rCXX358147: Remove repeated words from BuildingLibcxx.rst.
Remove repeated words from BuildingLibcxx.rst
Apr 10 2019, 4:45 PM
metzman committed rGff79ee144cd6: Remove repeated words from BuildingLibcxx.rst (authored by metzman).
Remove repeated words from BuildingLibcxx.rst
Apr 10 2019, 4:44 PM
metzman committed rL358147: Remove repeated words from BuildingLibcxx.rst.
Remove repeated words from BuildingLibcxx.rst
Apr 10 2019, 4:43 PM
metzman closed D60530: Remove repeated words from BuildingLibcxx.rst.
Apr 10 2019, 4:43 PM · Restricted Project
metzman added a reviewer for D60530: Remove repeated words from BuildingLibcxx.rst: phosek.

Please take a look.
I noticed this typo when reading https://libcxx.llvm.org/docs/BuildingLibcxx.html

Apr 10 2019, 12:28 PM · Restricted Project
metzman updated the diff for D60530: Remove repeated words from BuildingLibcxx.rst.

Include context.

Apr 10 2019, 12:28 PM · Restricted Project
metzman created D60530: Remove repeated words from BuildingLibcxx.rst.
Apr 10 2019, 12:24 PM · Restricted Project

Apr 8 2019

metzman added inline comments to D60334: Summary: Add close_fd_mask functionality to AFL driver..
Apr 8 2019, 10:49 AM · Restricted Project, Restricted Project
metzman updated the diff for D60334: Summary: Add close_fd_mask functionality to AFL driver..
  • improve comment
Apr 8 2019, 10:49 AM · Restricted Project, Restricted Project
metzman updated the diff for D60334: Summary: Add close_fd_mask functionality to AFL driver..
  • improve tests
Apr 8 2019, 10:35 AM · Restricted Project, Restricted Project
metzman updated the diff for D60334: Summary: Add close_fd_mask functionality to AFL driver..
  • first round of fixes
  • some combining
  • improve tests
  • undo accidenal change
  • more reuse
  • fmt
  • fmt
Apr 8 2019, 10:13 AM · Restricted Project, Restricted Project

Apr 5 2019

metzman added a comment to D60334: Summary: Add close_fd_mask functionality to AFL driver..

Please take a look.
This should help with some really badly behaved fuzzers in OSS-Fuzz that log so much that the disk fills up (because ClusterFuzz uses AFL_DRIVER_DUPLICATE_STDERR_FILENAME).

Apr 5 2019, 12:39 PM · Restricted Project, Restricted Project
metzman updated the diff for D60334: Summary: Add close_fd_mask functionality to AFL driver..
  • organize and improve comments
Apr 5 2019, 12:38 PM · Restricted Project, Restricted Project
metzman created D60334: Summary: Add close_fd_mask functionality to AFL driver..
Apr 5 2019, 12:34 PM · Restricted Project, Restricted Project

Feb 27 2019

metzman committed rG518514e81d46: [libFuzzer][Windows] Port fork mode to Windows (authored by metzman).
[libFuzzer][Windows] Port fork mode to Windows
Feb 27 2019, 11:27 AM
metzman committed rCRT355019: [libFuzzer][Windows] Port fork mode to Windows.
[libFuzzer][Windows] Port fork mode to Windows
Feb 27 2019, 11:27 AM
metzman committed rL355019: [libFuzzer][Windows] Port fork mode to Windows.
[libFuzzer][Windows] Port fork mode to Windows
Feb 27 2019, 11:27 AM
metzman closed D58513: [libFuzzer][Windows] Port fork mode to Windows.
Feb 27 2019, 11:27 AM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

@kcc
I tried Ctrl-Cing out of fork mode on Linux with this patch.
The temp directories seemed to get cleaned up anyway.

Feb 27 2019, 11:26 AM · Restricted Project, Restricted Project

Feb 26 2019

metzman committed rG7821f892bfd6: [libFuzzer] Remove extra semicolons (authored by metzman).
[libFuzzer] Remove extra semicolons
Feb 26 2019, 9:48 AM
metzman committed rCRT354902: [libFuzzer] Remove extra semicolons.
[libFuzzer] Remove extra semicolons
Feb 26 2019, 9:48 AM
metzman committed rL354902: [libFuzzer] Remove extra semicolons.
[libFuzzer] Remove extra semicolons
Feb 26 2019, 9:48 AM
metzman closed D58674: [libFuzzer] Remove extra semicolons.
Feb 26 2019, 9:47 AM · Restricted Project, Restricted Project
metzman added a comment to D58676: Add note on libFuzzer for Windows to release notes.

lgtm

I don't think committing to the branch works from the monorepo, so either check out the branch with svn (svn co https://llvm.org/svn/llvm-project/llvm/branches/release_80/docs/), or let me know and I'll commit for you.

Feb 26 2019, 8:09 AM · Restricted Project
metzman added a reviewer for D58676: Add note on libFuzzer for Windows to release notes: hans.

Please take a look @hans
Please let me know if I'm mistakenly adding this to master.
Thanks!

Feb 26 2019, 7:53 AM · Restricted Project
metzman updated the diff for D58676: Add note on libFuzzer for Windows to release notes.
  • be more specific
Feb 26 2019, 7:49 AM · Restricted Project
metzman retitled D58676: Add note on libFuzzer for Windows to release notes from Mention libFuzzer on Windows in release notes to Add note on libFuzzer for Windows to release notes.
Feb 26 2019, 7:49 AM · Restricted Project
metzman created D58676: Add note on libFuzzer for Windows to release notes.
Feb 26 2019, 7:45 AM · Restricted Project
metzman updated the summary of D58513: [libFuzzer][Windows] Port fork mode to Windows.
Feb 26 2019, 7:33 AM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.

Run clang-format-diff

Feb 26 2019, 7:33 AM · Restricted Project, Restricted Project
metzman added a comment to D58674: [libFuzzer] Remove extra semicolons.

Please take a look.
It might be worth adding -Wextra-semi to libFuzzer's cflags,.

Feb 26 2019, 7:28 AM · Restricted Project, Restricted Project
metzman created D58674: [libFuzzer] Remove extra semicolons.
Feb 26 2019, 7:25 AM · Restricted Project, Restricted Project

Feb 22 2019

metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

Since Ctrl-C doesn't quite work in fork mode on Linux, I don't think this should block Windows.

Feb 22 2019, 9:14 AM · Restricted Project, Restricted Project

Feb 21 2019

metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • Fix race so that max_total_time works with fork mode and improve error messages.
Feb 21 2019, 5:26 PM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

I'm not sure this should be landed yet since IterateDirRecursive treats edge-case as a file.
I suspect that is harmless, but ideally it wouldn't do this.

Feb 21 2019, 3:00 PM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • fail gracefully
Feb 21 2019, 2:32 PM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

Can you try mountvol <PATH>\mount C:\ and see what you print in this case?

This seems to break:

File: <PATH>\test-dir\dir\file-symlink2
File: <PATH>\test-dir\dir\y.txt
Dir: <PATH>\test-dir\dir
File: <PATH>\test-dir\dir-junction\file-symlink2
File: <PATH>\test-dir\dir-junction\y.txt
Dir: <PATH>\test-dir\dir-junction
File: <PATH>\test-dir\dir-Shortcut.lnk
File: <PATH>\test-dir\dir-symlink\file-symlink2
File: <PATH>\test-dir\dir-symlink\y.txt
Dir: <PATH>\test-dir\dir-symlink
File: <PATH>\test-dir\edge-case
File: <PATH>\test-dir\file-hardlink1
File: <PATH>\test-dir\file-hardlink2
File: <PATH>\test-dir\file-symlink
File: <PATH>\test-dir\file.txt
FindFirstFileA failed with error 5 for directory: <PATH>\ss64\$Recycle.Bin\blah; exiting

I'm not sure what the correct behavior in this case is though.

Actually just use a different directory then. Like mount D: instead of C:. Recycle bin is protected, so you probably won't be able to get directly into it without special permissions.

What I'm really wondering about is whether a volume mounted with mountvol will fall into your directory branch or your file branch. It should go into your directory branch.

Feb 21 2019, 2:32 PM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

Can you try mountvol <PATH>\mount C:\ and see what you print in this case?

Feb 21 2019, 1:57 PM · Restricted Project, Restricted Project
metzman planned changes to D58513: [libFuzzer][Windows] Port fork mode to Windows.

I'm not sure this should be landed yet since IterateDirRecursive treats edge-case as a file.
I suspect that is harmless, but ideally it wouldn't do this.

Feb 21 2019, 1:50 PM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • undo accidental linespace changes
Feb 21 2019, 1:46 PM · Restricted Project, Restricted Project
metzman added inline comments to D58513: [libFuzzer][Windows] Port fork mode to Windows.
Feb 21 2019, 1:42 PM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • fix
  • remove comment
  • remove comment and simplify
Feb 21 2019, 1:40 PM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • format
Feb 21 2019, 1:34 PM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • fix
  • Format and fix issue with /dev/null
  • fix
Feb 21 2019, 1:32 PM · Restricted Project, Restricted Project
metzman added inline comments to D58513: [libFuzzer][Windows] Port fork mode to Windows.
Feb 21 2019, 11:43 AM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

For the record, I'm also fixing an issue with /dev/null being used on Win even though it doesn't work.

Feb 21 2019, 10:17 AM · Restricted Project, Restricted Project
metzman added a comment to D58513: [libFuzzer][Windows] Port fork mode to Windows.

This patch wasn't quite ready for review but it looks like the comments were very useful. Thanks everyone!
Zach: I'll try to address your comments about links soon.

Feb 21 2019, 10:13 AM · Restricted Project, Restricted Project
metzman retitled D58513: [libFuzzer][Windows] Port fork mode to Windows from initial to [libFuzzer][Windows] Port fork mode to Windows.
Feb 21 2019, 8:42 AM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • more consistency
Feb 21 2019, 8:39 AM · Restricted Project, Restricted Project
metzman updated the diff for D58513: [libFuzzer][Windows] Port fork mode to Windows.
  • Better comments
Feb 21 2019, 8:37 AM · Restricted Project, Restricted Project
metzman created D58513: [libFuzzer][Windows] Port fork mode to Windows.
Feb 21 2019, 8:28 AM · Restricted Project, Restricted Project

Feb 12 2019

metzman added a comment to D57597: Document libFuzzer on Windows..

You may need to use double backticks to put something into monospaced font, see https://reviews.llvm.org/rL352890. Maybe that's why the docs are still not updated.

Added that in r353809.

Merged this to the release_80 branch in r353811.

Feb 12 2019, 10:05 AM · Restricted Project
metzman added a comment to D57597: Document libFuzzer on Windows..

You may need to use double backticks to put something into monospaced font, see https://reviews.llvm.org/rL352890. Maybe that's why the docs are still not updated.

Feb 12 2019, 9:57 AM · Restricted Project

Feb 8 2019

metzman committed rGb98fea9c115b: Document libFuzzer on Windows. (authored by metzman).
Document libFuzzer on Windows.
Feb 8 2019, 11:36 AM
metzman committed rL353551: Document libFuzzer on Windows..
Document libFuzzer on Windows.
Feb 8 2019, 11:36 AM
metzman closed D57597: Document libFuzzer on Windows..
Feb 8 2019, 11:36 AM · Restricted Project

Feb 5 2019

metzman updated the diff for D57597: Document libFuzzer on Windows..
  • make it clearer that we wont support incremental linking
Feb 5 2019, 5:33 PM · Restricted Project
metzman accepted D57597: Document libFuzzer on Windows..

Kostya asked me offline to change the sentence about clang 8 to say what revision support was added in before landing.

Feb 5 2019, 5:19 PM · Restricted Project
metzman updated the diff for D57597: Document libFuzzer on Windows..
  • mention /INCREMENTAL can't be used.
Feb 5 2019, 5:18 PM · Restricted Project
metzman updated the diff for D57597: Document libFuzzer on Windows..
  • Make Kostya's suggested change
Feb 5 2019, 5:13 PM · Restricted Project
metzman added inline comments to D57597: Document libFuzzer on Windows..
Feb 5 2019, 4:58 PM · Restricted Project

Feb 4 2019

metzman committed rG7c907bac6fd5: [libFuzzer][Windows] Clean up RawPrint (authored by metzman).
[libFuzzer][Windows] Clean up RawPrint
Feb 4 2019, 3:02 PM
metzman committed rCRT353108: [libFuzzer][Windows] Clean up RawPrint.
[libFuzzer][Windows] Clean up RawPrint
Feb 4 2019, 3:02 PM
metzman committed rL353108: [libFuzzer][Windows] Clean up RawPrint.
[libFuzzer][Windows] Clean up RawPrint
Feb 4 2019, 3:02 PM
metzman closed D57589: [libFuzzer][Windows] Clean up RawPrint.
Feb 4 2019, 3:02 PM · Restricted Project

Feb 3 2019

metzman committed rCRT353000: [libFuzzer][Windows] Reenable passing tests.
[libFuzzer][Windows] Reenable passing tests
Feb 3 2019, 8:56 AM
metzman committed rGe2469b11a588: [libFuzzer][Windows] Reenable passing tests (authored by metzman).
[libFuzzer][Windows] Reenable passing tests
Feb 3 2019, 8:55 AM
metzman committed rL353000: [libFuzzer][Windows] Reenable passing tests.
[libFuzzer][Windows] Reenable passing tests
Feb 3 2019, 8:55 AM
metzman closed D57563: [libFuzzer][Windows] Reenable passing tests.
Feb 3 2019, 8:55 AM · Restricted Project
metzman added a comment to D57597: Document libFuzzer on Windows..
In D57597#1381683, @rnk wrote:
In D57597#1381590, @rnk wrote:
In D57597#1381064, @kcc wrote:

any reliable bot will do.
This one, ... hm, doesn't seem reliable.
Last build passed two days ago :(
A separate bot would be nice if you expect a high rate of changes (and breakages) on windows

I am taking steps to add it to sanitizer-windows here, which is super fast and reliable (for a sanitizer bot =P):
http://lab.llvm.org:8011/builders/sanitizer-windows

To follow-up, check-fuzzer passed on sanitizer-windows:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/41419

[99/102] Running Fuzzer unit tests
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:32: note: lsan feature unavailable
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:39: note: msan feature unavailable
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:57: note: linux feature unavailable
-- Testing: 36 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.92s
  Expected Passes    : 36

Do we need more targets?

check-fuzzer is the only target but it seems like only the unittests are running.

Feb 3 2019, 8:51 AM · Restricted Project

Feb 1 2019

metzman added a comment to D57597: Document libFuzzer on Windows..
In D57597#1381683, @rnk wrote:
In D57597#1381590, @rnk wrote:
In D57597#1381064, @kcc wrote:

any reliable bot will do.
This one, ... hm, doesn't seem reliable.
Last build passed two days ago :(
A separate bot would be nice if you expect a high rate of changes (and breakages) on windows

I am taking steps to add it to sanitizer-windows here, which is super fast and reliable (for a sanitizer bot =P):
http://lab.llvm.org:8011/builders/sanitizer-windows

To follow-up, check-fuzzer passed on sanitizer-windows:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/41419

[99/102] Running Fuzzer unit tests
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:32: note: lsan feature unavailable
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:39: note: msan feature unavailable
llvm-lit.py: C:/b/slave/sanitizer-windows/build/llvm.src/projects/compiler-rt/test/fuzzer/lit.cfg:57: note: linux feature unavailable
-- Testing: 36 tests, 16 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.92s
  Expected Passes    : 36

Do we need more targets?

Feb 1 2019, 3:19 PM · Restricted Project
metzman added a comment to D57597: Document libFuzzer on Windows..
In D57597#1381039, @kcc wrote:

do we have the bot?

Feb 1 2019, 10:24 AM · Restricted Project
metzman added inline comments to D57597: Document libFuzzer on Windows..
Feb 1 2019, 10:02 AM · Restricted Project
metzman added inline comments to D57597: Document libFuzzer on Windows..
Feb 1 2019, 10:00 AM · Restricted Project
metzman added a reviewer for D57597: Document libFuzzer on Windows.: kcc.

I think libFuzzer on Windows is solid enough now to make public.
What do you think?

Feb 1 2019, 9:54 AM · Restricted Project
metzman updated the diff for D57597: Document libFuzzer on Windows..
  • mention support may be added
Feb 1 2019, 9:53 AM · Restricted Project
metzman created D57597: Document libFuzzer on Windows..
Feb 1 2019, 9:47 AM · Restricted Project
metzman retitled D57589: [libFuzzer][Windows] Clean up RawPrint from [libFuzzer][Windows] Use _write instead of write to [libFuzzer][Windows] Clean up RawPrint.
Feb 1 2019, 7:40 AM · Restricted Project
metzman retitled D57589: [libFuzzer][Windows] Clean up RawPrint from [libFuzzer][Win] Use _write instead of write to [libFuzzer][Windows] Use _write instead of write.
Feb 1 2019, 7:40 AM · Restricted Project
metzman added a reviewer for D57589: [libFuzzer][Windows] Clean up RawPrint: vitalybuka.

@vitalybuka
Please take a look at this trivial change.

Feb 1 2019, 7:39 AM · Restricted Project
metzman created D57589: [libFuzzer][Windows] Clean up RawPrint.
Feb 1 2019, 7:28 AM · Restricted Project
metzman added a reviewer for D57563: [libFuzzer][Windows] Reenable passing tests: morehouse.
Feb 1 2019, 7:06 AM · Restricted Project
metzman updated subscribers of D57563: [libFuzzer][Windows] Reenable passing tests.

@morehouse
Please take a look when you get a chance.
All of these tests pass on Win without takinn long.
I'd like to reenable them.

Feb 1 2019, 7:06 AM · Restricted Project

Jan 31 2019

metzman created D57563: [libFuzzer][Windows] Reenable passing tests.
Jan 31 2019, 8:40 PM · Restricted Project
metzman committed rL352815: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
[libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
Jan 31 2019, 3:35 PM
metzman committed rCRT352815: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
[libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
Jan 31 2019, 3:34 PM
metzman closed D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
Jan 31 2019, 3:34 PM · Restricted Project, Restricted Project
metzman added reviewers for D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win: morehouse, vitalybuka.

Please take a look.

Jan 31 2019, 3:18 PM · Restricted Project, Restricted Project
metzman updated the diff for D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
  • add comment
Jan 31 2019, 3:17 PM · Restricted Project, Restricted Project
metzman updated the diff for D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
  • add comment
Jan 31 2019, 3:16 PM · Restricted Project, Restricted Project
metzman created D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.
Jan 31 2019, 3:15 PM · Restricted Project, Restricted Project
metzman committed rL352789: [fuzzer] Use RawPrint instead of Printf for instrumentation warning.
[fuzzer] Use RawPrint instead of Printf for instrumentation warning
Jan 31 2019, 12:32 PM
metzman committed rCRT352789: [fuzzer] Use RawPrint instead of Printf for instrumentation warning.
[fuzzer] Use RawPrint instead of Printf for instrumentation warning
Jan 31 2019, 12:32 PM
metzman closed D57531: [fuzzer] Use RawPrint instead of Printf for instrumentation warning.
Jan 31 2019, 12:32 PM
metzman updated the diff for D57531: [fuzzer] Use RawPrint instead of Printf for instrumentation warning.

commit message

Jan 31 2019, 12:31 PM
metzman updated the diff for D57531: [fuzzer] Use RawPrint instead of Printf for instrumentation warning.
  • fmt
Jan 31 2019, 12:29 PM
metzman added a reviewer for D57531: [fuzzer] Use RawPrint instead of Printf for instrumentation warning: kcc.

Please take a look.
This fixes the deprecated-instrumentation.test which is currently failing on Windows because the message doesn't print.
It doesn't print because OutputFile in FuzzerIO.cpp is not yet initialized when WarnAboutDeprecatedInstrumentation is called.
An alternative to this fix is just disabling the test on Windows, I don't worry much about the message not being printed because I don't think anyone has ever used trace-pc on Win with libFuzzer.

Jan 31 2019, 11:36 AM