Feed Advanced Search

Today

labath committed rL335163: Remove some instances of manual UUID pretty-printing.
Remove some instances of manual UUID pretty-printing
Wed, Jun 20, 1:17 PM
labath committed rL335149: Make test sources compatible with android+libcxx+modules.
Make test sources compatible with android+libcxx+modules
Wed, Jun 20, 10:37 AM
labath committed rL335132: Make sure TestNumThreads works with libc++.
Make sure TestNumThreads works with libc++
Wed, Jun 20, 8:00 AM
labath committed rL335114: IRInterpreter: fix sign extension of small types (pr37840).
IRInterpreter: fix sign extension of small types (pr37840)
Wed, Jun 20, 3:51 AM
labath committed rL335112: Fix compilation with mingw-w64 (pr37873).
Fix compilation with mingw-w64 (pr37873)
Wed, Jun 20, 2:58 AM
labath committed rL335106: Fix windows build broken by r335104.
Fix windows build broken by r335104
Wed, Jun 20, 2:05 AM
labath created D48351: Move dumping code out of RegisterValue class.
Wed, Jun 20, 1:56 AM
labath committed rL335104: Remove dependency from Host to python.
Remove dependency from Host to python
Wed, Jun 20, 1:40 AM
labath closed D48215: Remove dependency from Host to python.
Wed, Jun 20, 1:40 AM
labath committed rL335102: BreakpointIDList: Use llvm::ArrayRef instead of pointer+length pair.
BreakpointIDList: Use llvm::ArrayRef instead of pointer+length pair
Wed, Jun 20, 1:17 AM

Yesterday

labath added a comment to D48337: Refactor OnExit utility class in ClangUserExpression.

How is this class different from lldb_private::CleanUp? Shouldn't we just delete it and replace all uses with the pre-existing class?

Tue, Jun 19, 2:42 PM
labath committed rL335060: Scalar: Use llvm integer conversion functions.
Scalar: Use llvm integer conversion functions
Tue, Jun 19, 10:28 AM
labath updated the diff for D48215: Remove dependency from Host to python.

Rebase this patch on trunk. Now this patch is simply about moving GetPythonDir
from Host module to ScriptInterpreterPython.

Tue, Jun 19, 8:27 AM
labath committed rL335052: Replace HostInfo::GetLLDBPath with specific functions.
Replace HostInfo::GetLLDBPath with specific functions
Tue, Jun 19, 8:16 AM
labath closed D48272: Replace HostInfo::GetLLDBPath with specific functions.
Tue, Jun 19, 8:16 AM
labath committed rL335051: Make TestCommandScript.py NO_DEBUG_INFO_TESTCASE.
Make TestCommandScript.py NO_DEBUG_INFO_TESTCASE
Tue, Jun 19, 8:11 AM
labath added a comment to D48272: Replace HostInfo::GetLLDBPath with specific functions.

Looks good. My only question is do we not require people to only fill in the directory portion of the FileSpec anymore for these functions? I am fine with way since hopefully FileSpec::AppendPathComponent handles things correctly.

Tue, Jun 19, 8:10 AM
labath committed rL335047: Attempt to fix windows build broken by r334968.
Attempt to fix windows build broken by r334968
Tue, Jun 19, 7:28 AM
labath added inline comments to D48306: Make TaskQueue support tasks that return values.
Tue, Jun 19, 1:34 AM

Mon, Jun 18

labath committed rL334955: Fix macosx build broken by the VersionTuple refactor.
Fix macosx build broken by the VersionTuple refactor
Mon, Jun 18, 9:14 AM
labath committed rL334953: Fix netbsd build broken by r334950.
Fix netbsd build broken by r334950
Mon, Jun 18, 8:49 AM
labath committed rL334952: Attempt to fix windows&freebsd builds broken by r334950.
Attempt to fix windows&freebsd builds broken by r334950
Mon, Jun 18, 8:34 AM
labath committed rL334950: Use llvm::VersionTuple instead of manual version marshalling.
Use llvm::VersionTuple instead of manual version marshalling
Mon, Jun 18, 8:11 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Jun 18, 8:10 AM
labath created D48272: Replace HostInfo::GetLLDBPath with specific functions.
Mon, Jun 18, 3:57 AM
labath added a comment to D48241: [DebugInfo] Emit ObjC methods as part of interface..

I also don't want to get involved too much, but here are my 2c: :)

Mon, Jun 18, 2:04 AM
labath added a comment to D48240: Try again to implement a FIFO task queue.

Another example might be if you were writing a debugger which was debugging N processes simultaneously, and due to various OS restrictions, each of these N processes was being debugged by a separate thread.

Mon, Jun 18, 1:35 AM
labath accepted D48060: Introduce lldb-framework CMake target and centralize its logic.

Looks good. I'm really happy with how this turned out. Thank you for your patience.

Mon, Jun 18, 12:39 AM

Fri, Jun 15

labath added a comment to D48060: Introduce lldb-framework CMake target and centralize its logic.

This is looking very good, I just have one more quick question. I am wondering whether we couldn't simplify this dependency management a tad bit more. Would the thing I'm proposing below work for you?

Fri, Jun 15, 1:32 PM
labath planned changes to D48215: Remove dependency from Host to python.

Ok, I'll start with the other patch first.

Fri, Jun 15, 9:14 AM
labath added a comment to D48215: Remove dependency from Host to python.

(pressed return too soon)

Fri, Jun 15, 9:07 AM
labath added a comment to D48215: Remove dependency from Host to python.

Actually, my plan was to follow this up with a patch which removes usages of that enumeration from the internal api altogether (basically do a s/GetLLDBPath(ePathTypeXXX/GetXXXPath). That should make the internal api nicer, and provide a clean separation between the internal and public api (thereby taking pressure off of adding new enums to the public api just because we have a new kind of an internal path).

Fri, Jun 15, 9:06 AM
labath created D48215: Remove dependency from Host to python.
Fri, Jun 15, 4:57 AM
labath updated the diff for D47889: Use llvm::VersionTuple instead of manual version marshalling.

Fix a typo in netbsd code.

Fri, Jun 15, 3:41 AM
labath added a comment to D48177: Suppress SIGSEGV on Android when the program will recover.

Thank you for implementing this. We've had code like this in android studio for a long time, but it's definitely better doing it in lldb instead.

Fri, Jun 15, 2:35 AM

Thu, Jun 14

labath committed rL334717: DebugNamesDWARFIndex: fix handling of compressed sections.
DebugNamesDWARFIndex: fix handling of compressed sections
Thu, Jun 14, 7:46 AM
labath committed rL334702: Fix PathMappingListTest on windows.
Fix PathMappingListTest on windows
Thu, Jun 14, 3:35 AM
labath committed rL334697: Fix includes in PlatformAppleSimulator.h.
Fix includes in PlatformAppleSimulator.h
Thu, Jun 14, 2:13 AM

Wed, Jun 13

labath committed rL334580: Fix "Optional" is ambiguous error on some bots.
Fix "Optional" is ambiguous error on some bots
Wed, Jun 13, 1:33 AM
labath committed rL334578: [DWARF/AccelTable] Remove getDIESectionOffset for DWARF v5 entries.
[DWARF/AccelTable] Remove getDIESectionOffset for DWARF v5 entries
Wed, Jun 13, 1:19 AM
labath closed D48009: [DWARF/AccelTable] Remove getDIESectionOffset for DWARF v5 entries.
Wed, Jun 13, 1:18 AM
labath added inline comments to D48084: [FileSpec] Delegate common operations to llvm::sys::path.
Wed, Jun 13, 12:37 AM
labath accepted D48115: Make ThreadPool support running tasks that return values.

looks good

Wed, Jun 13, 12:31 AM
labath added inline comments to D48060: Introduce lldb-framework CMake target and centralize its logic.
Wed, Jun 13, 12:11 AM

Tue, Jun 12

labath accepted D48084: [FileSpec] Delegate common operations to llvm::sys::path.
Tue, Jun 12, 1:05 PM
labath added inline comments to D48084: [FileSpec] Delegate common operations to llvm::sys::path.
Tue, Jun 12, 12:19 PM
labath added inline comments to D48060: Introduce lldb-framework CMake target and centralize its logic.
Tue, Jun 12, 12:08 PM
labath committed rL334516: DebugNamesDWARFIndex: Implement DWARFDeclContext variant of GetTypes method.
DebugNamesDWARFIndex: Implement DWARFDeclContext variant of GetTypes method
Tue, Jun 12, 9:54 AM
labath committed rL334501: Fix build error introduced in r334498.
Fix build error introduced in r334498
Tue, Jun 12, 6:31 AM
labath committed rL334500: DWARFDebugNames: Implement last GetGlobalVariables overload.
DWARFDebugNames: Implement last GetGlobalVariables overload
Tue, Jun 12, 6:15 AM
labath committed rL334498: lldb-test symbols: Add -file argument and the ability to dump global variables….
lldb-test symbols: Add -file argument and the ability to dump global variables…
Tue, Jun 12, 6:02 AM
labath committed rL334496: lit/SymbolFile/DWARF: Simplify test RUN lines.
lit/SymbolFile/DWARF: Simplify test RUN lines
Tue, Jun 12, 5:48 AM
labath added a comment to D48060: Introduce lldb-framework CMake target and centralize its logic.

I like the idea of centralizing the framework code as much as possible. However, I am not sure how the dependency management fits into this. More details in inline comments.

Tue, Jun 12, 2:43 AM
labath accepted D48050: [lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on Windows.

The change looks good. The only potentially risky thing is the maxLaunchCount change, but the fact that it is overridable by an env var should mitigate that. It looks like a very weird hack that seems to have been here since 2010. I hope we can remove it altogether at some point, and the requirement for configurations (if any) which require it to explicitly request that behavior seems like good step towards that.

Tue, Jun 12, 2:18 AM

Mon, Jun 11

labath added a comment to D47991: Improve SBThread's stepping API using SBError parameter..

Hmm.. it looks like most C++ API calls don't have any documentation.

http://lldb.llvm.org/cpp_reference/html/classlldb_1_1SBThread.html#a42755a170e127881a5dd65162217f68b

It does look like the python API has more documentation.. where does that come from?

Mon, Jun 11, 10:05 AM
labath added a comment to D47932: Fix tuple getter in std unique pointer pretty-printer.

Committed as r334411. I also squeezed in a quick test.

Mon, Jun 11, 7:57 AM
labath committed rL334411: Fix tuple getter in std unique pointer pretty-printer.
Fix tuple getter in std unique pointer pretty-printer
Mon, Jun 11, 7:57 AM
labath closed D47932: Fix tuple getter in std unique pointer pretty-printer.
Mon, Jun 11, 7:57 AM
labath committed rL334403: Fix build errors on some configurations.
Fix build errors on some configurations
Mon, Jun 11, 6:36 AM
labath committed rL334402: DWARFDebugNames: Fix lookup in dwo files.
DWARFDebugNames: Fix lookup in dwo files
Mon, Jun 11, 6:27 AM
labath closed D47886: Move VersionTuple from clang/Basic to llvm/Support, clang part.

Committed as a part of D47887 via monorepo.

Mon, Jun 11, 4:37 AM
labath created D48009: [DWARF/AccelTable] Remove getDIESectionOffset for DWARF v5 entries.
Mon, Jun 11, 4:36 AM
labath committed rC334399: Move VersionTuple from clang/Basic to llvm/Support.
Move VersionTuple from clang/Basic to llvm/Support
Mon, Jun 11, 3:33 AM
labath committed rL334399: Move VersionTuple from clang/Basic to llvm/Support.
Move VersionTuple from clang/Basic to llvm/Support
Mon, Jun 11, 3:33 AM
labath closed D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part.
Mon, Jun 11, 3:33 AM
labath committed rL334397: Editline: make #include <codecvt> conditional.
Editline: make #include <codecvt> conditional
Mon, Jun 11, 2:37 AM
labath added inline comments to D47625: [cmake] Detect presence of wide-char libedit at build time.
Mon, Jun 11, 2:19 AM
labath committed rL334393: [cmake] Detect presence of wide-char libedit at build time.
[cmake] Detect presence of wide-char libedit at build time
Mon, Jun 11, 2:18 AM
labath closed D47625: [cmake] Detect presence of wide-char libedit at build time.
Mon, Jun 11, 2:18 AM
labath added a comment to D47879: Implement vAttachWait in lldb-server.

This is a good start, We probably need a test. Pavel: can you outline what Ryan would need to do to add a test for this?

Mon, Jun 11, 1:29 AM
labath added a comment to D47939: Retrieve a function PDB symbol correctly from nested blocks.

Looks great. Thanks.

Mon, Jun 11, 12:41 AM

Fri, Jun 8

labath added a comment to D47939: Retrieve a function PDB symbol correctly from nested blocks.

Yea, relying on addresses inside compiler-generated binaries would be extremely brittle. However, line numbers should be fairly stable. Maybe we could have lldb-test take an file+line argument, resolve that into an address, and then look up the relevant symbol context? As a bonus we also get to test line number resolution :P.

Fri, Jun 8, 8:37 AM
labath committed rL334279: Fix TestMiExec.py.
Fix TestMiExec.py
Fri, Jun 8, 3:44 AM
labath committed rL334277: DebugNamesDWARFIndex: Implement regex version of the GetFunctions method.
DebugNamesDWARFIndex: Implement regex version of the GetFunctions method
Fri, Jun 8, 3:36 AM
labath added inline comments to D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Fri, Jun 8, 2:35 AM
labath committed rL334273: DebugNamesDWARFIndex: Implement GetFunctions method.
DebugNamesDWARFIndex: Implement GetFunctions method
Fri, Jun 8, 2:14 AM
labath closed D47881: DebugNamesDWARFIndex: Implement GetFunctions method.
Fri, Jun 8, 2:14 AM
labath accepted D47932: Fix tuple getter in std unique pointer pretty-printer.

Aha I see.

Fri, Jun 8, 1:57 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

Thank you for your patience. I am very happy with the final result here.

Fri, Jun 8, 1:27 AM
labath added inline comments to D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command..
Fri, Jun 8, 1:19 AM
labath added a comment to D47932: Fix tuple getter in std unique pointer pretty-printer.

Did you investigate when does this happen? I take it it can happen if a user has a custom std::unique_ptr definition that kinda looks like the libstdc++ one, but not really, but I am wondering if we're not missing something else here..

Fri, Jun 8, 1:08 AM

Thu, Jun 7

labath created D47889: Use llvm::VersionTuple instead of manual version marshalling.
Thu, Jun 7, 8:44 AM
labath added a comment to D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part.

Yea, one day I'll have to try that out. I'm just putting it off cause it would nuke all my branches and build folders :/

Thu, Jun 7, 8:40 AM
labath created D47887: Move VersionTuple from clang/Basic to llvm/Support, llvm part.
Thu, Jun 7, 8:29 AM
labath created D47886: Move VersionTuple from clang/Basic to llvm/Support, clang part.
Thu, Jun 7, 8:29 AM
labath added a comment to D47879: Implement vAttachWait in lldb-server.

Thanks for the patch. I have a bunch of comments, but none of them are really serious. Now we just need to figure out the testing...

Thu, Jun 7, 7:57 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

As a general rule, lld-link is command line compatible with MSVC and
clang-cl is command line compatible with cl. So, the /order option should
work exactly the same with lld-link as it does with link.

It seeems that it is not implemented:

>lld-link /debug /nodefaultlib /entry:main /order:@test-pdb-function-level-linking.ord test-pdb-function-level-linking.obj
C:\LLVM\bin\lld-link.EXE: error: could not open /order:@test-pdb-function-level-linking.ord: no such file or directory

lld-link /? also don't list such option.

Thu, Jun 7, 7:34 AM
labath accepted D47797: [lldb-mi] Re-implement MI -exec-next command..

looks good to me

Thu, Jun 7, 7:30 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

Thank you for implementing the lldb-test extension. Now that we have that, and the /order, we should be able to get rid of the binaries for the function-level-linking test. You should be able to rewrite it into something like this:

Thu, Jun 7, 7:27 AM
labath created D47881: DebugNamesDWARFIndex: Implement GetFunctions method.
Thu, Jun 7, 7:12 AM
labath committed rL334198: DIERef: move trivial constructors into the header.
DIERef: move trivial constructors into the header
Thu, Jun 7, 7:07 AM
labath committed rL334190: DebugNamesDWARFIndex: Add type lookup suport.
DebugNamesDWARFIndex: Add type lookup suport
Thu, Jun 7, 5:30 AM
labath committed rL334186: DebugNamesDWARFIndex: add namespace lookup support.
DebugNamesDWARFIndex: add namespace lookup support
Thu, Jun 7, 4:00 AM
labath committed rL334185: DebugNamesDWARFIndex: Add support for partial indexes.
DebugNamesDWARFIndex: Add support for partial indexes
Thu, Jun 7, 3:39 AM
labath closed D47832: DebugNamesDWARFIndex: Add support for partial indexes.
Thu, Jun 7, 3:39 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

Btw, would it be possible to use the /order directive to achive what you want? (/order:function_from_first_file,function_from_second_file,another_function_from_first_file)

Thu, Jun 7, 3:37 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

I don't think that's necessary. The actual fix is really simple and this whole discussion is just about figuring out what to do with tests.

Thu, Jun 7, 3:31 AM
labath added a comment to D47708: PDB support of function-level linking and splitted functions.

I think these kinds of checks would be a nice fit for a lldb-test symbols --verify option.

Can you explain this in detail, please?

Thu, Jun 7, 3:20 AM
labath committed rL334181: DebugNamesDWARFIndex: Add ability to lookup variables.
DebugNamesDWARFIndex: Add ability to lookup variables
Thu, Jun 7, 3:09 AM
labath closed D47781: DebugNamesDWARFIndex: Add ability to lookup variables.
Thu, Jun 7, 3:09 AM