Page MenuHomePhabricator
Feed Advanced Search

Thu, Apr 18

labath committed rGeba97426d4e9: Clean up docstrings in swig interface files (authored by labath).
Clean up docstrings in swig interface files
Thu, Apr 18, 9:22 AM
labath committed rLLDB358683: Clean up docstrings in swig interface files.
Clean up docstrings in swig interface files
Thu, Apr 18, 9:22 AM
labath committed rL358683: Clean up docstrings in swig interface files.
Clean up docstrings in swig interface files
Thu, Apr 18, 9:22 AM
labath closed D60498: Clean up docstrings in swig interface files.
Thu, Apr 18, 9:21 AM · Restricted Project
labath added inline comments to D60405: MinidumpYAML: Add support for ModuleList stream.
Thu, Apr 18, 8:00 AM · Restricted Project
labath committed rG7429d86f36e8: MinidumpYAML: Add support for ModuleList stream (authored by labath).
MinidumpYAML: Add support for ModuleList stream
Thu, Apr 18, 7:59 AM
labath committed rL358672: MinidumpYAML: Add support for ModuleList stream.
MinidumpYAML: Add support for ModuleList stream
Thu, Apr 18, 7:59 AM
labath closed D60405: MinidumpYAML: Add support for ModuleList stream.
Thu, Apr 18, 7:59 AM · Restricted Project
labath added a reviewer for D60817: [NativePDB] Add anonymous namespaces support: amccarth.

Don't know much about PDBs, but the change seems pretty straight-forward to me. Zach would be the best person to review this, but he's probably busy with other things now. Maybe Adrian could take a look?

Thu, Apr 18, 7:58 AM · Restricted Project
labath added a comment to D60829: FuncUnwinders: remove "current_offset" from function arguments.

Sure, that's no problem. Thanks for letting me know.

Thu, Apr 18, 7:44 AM

Wed, Apr 17

labath created D60829: FuncUnwinders: remove "current_offset" from function arguments.
Wed, Apr 17, 9:24 AM
labath added inline comments to D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Wed, Apr 17, 7:56 AM · Restricted Project
labath added a comment to D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Thanks for adding the test.

Wed, Apr 17, 12:40 AM · Restricted Project
labath added a comment to D60153: Re-enable most lldb-vscode tests on Linux..

Thanks! Please let me know if it happens again and I'll try my best to debug it.

Wed, Apr 17, 12:30 AM · Restricted Project, Restricted Project
labath added a comment to D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().

Thanks. I have a couple of small comments, but I think this is basically done.

Wed, Apr 17, 12:27 AM · Restricted Project

Tue, Apr 16

labath added a comment to D60780: [tools] Only build lldb-instr and lldb-vscode if asked..

LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In fact, if we started using the llvm cmake macros like add_llvm_subdirectory, it would handle this automatically, including creating the cache variable.

Tue, Apr 16, 10:46 AM · Restricted Project
labath committed rG9e31584e7875: Fix symtab-macho.test broken by r358500 (authored by labath).
Fix symtab-macho.test broken by r358500
Tue, Apr 16, 9:57 AM
labath committed rL358508: Fix symtab-macho.test broken by r358500.
Fix symtab-macho.test broken by r358500
Tue, Apr 16, 9:57 AM
labath committed rLLDB358508: Fix symtab-macho.test broken by r358500.
Fix symtab-macho.test broken by r358500
Tue, Apr 16, 9:57 AM
labath added inline comments to D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Tue, Apr 16, 8:26 AM · Restricted Project
labath committed rG025b9d0f2e6a: Breakpad: Match the new UUID algorithm in minidumps (authored by labath).
Breakpad: Match the new UUID algorithm in minidumps
Tue, Apr 16, 7:54 AM
labath committed rGfea82638b50e: test/PECOFF: Remove REQUIRES: system-windows (authored by labath).
test/PECOFF: Remove REQUIRES: system-windows
Tue, Apr 16, 7:54 AM
labath committed rLLDB358500: Breakpad: Match the new UUID algorithm in minidumps.
Breakpad: Match the new UUID algorithm in minidumps
Tue, Apr 16, 7:53 AM
labath committed rL358500: Breakpad: Match the new UUID algorithm in minidumps.
Breakpad: Match the new UUID algorithm in minidumps
Tue, Apr 16, 7:53 AM
labath committed rL358499: test/PECOFF: Remove REQUIRES: system-windows.
test/PECOFF: Remove REQUIRES: system-windows
Tue, Apr 16, 7:53 AM
labath committed rLLDB358499: test/PECOFF: Remove REQUIRES: system-windows.
test/PECOFF: Remove REQUIRES: system-windows
Tue, Apr 16, 7:53 AM
labath added inline comments to D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID().
Tue, Apr 16, 5:06 AM · Restricted Project
labath edited reviewers for D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID(), added: amccarth, labath; removed: zturner, llvm-commits.

s/@zturner/@amccarth, as Zach probably won't have time to review this

Tue, Apr 16, 12:20 AM · Restricted Project

Mon, Apr 15

labath added a comment to D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

A test case?

Mon, Apr 15, 11:09 PM · Restricted Project

Sat, Apr 13

labath accepted D60648: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test.
Sat, Apr 13, 2:42 AM · Restricted Project

Fri, Apr 12

labath committed rGce0a88a5e1b2: Fix compiler warning introduced by r358261 (authored by labath).
Fix compiler warning introduced by r358261
Fri, Apr 12, 6:49 AM
labath committed rLLDB358284: Fix compiler warning introduced by r358261.
Fix compiler warning introduced by r358261
Fri, Apr 12, 6:49 AM
labath committed rL358284: Fix compiler warning introduced by r358261.
Fix compiler warning introduced by r358261
Fri, Apr 12, 6:49 AM
labath added a comment to D60410: PDBFPO: Improvements to the AST visitor.

I believe this revision introduced a warning when compiling with Clang:

 98% [4004/4047] Building CXX object tool....dir/PdbFPOProgramToDWARFExpression.cpp.o
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7: warning: '(anonymous namespace)::FPOProgramASTVisitor<void>' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitor {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:51: note: in instantiation of template class '(anonymous namespace)::FPOProgramASTVisitor<void>' requested here
class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
                                                  ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:7: warning: '(anonymous namespace)::FPOProgramASTVisitorMergeDependent' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7: warning: '(anonymous namespace)::FPOProgramASTVisitor<bool>' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitor {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:232:14: note: in instantiation of template class '(anonymous namespace)::FPOProgramASTVisitor<bool>' requested here
    : public FPOProgramASTVisitor<bool> {
             ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:231:7: warning: '(anonymous namespace)::FPOProgramASTVisitorResolveRegisterRefs' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorResolveRegisterRefs
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:310:7: warning: '(anonymous namespace)::FPOProgramASTVisitorDWARFCodegen' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorDWARFCodegen : public FPOProgramASTVisitor<> {
      ^
5 warnings generated.
Fri, Apr 12, 6:37 AM · Restricted Project
labath created D60608: Make TestVSCode_step pass reliably.
Fri, Apr 12, 4:59 AM
labath created D60599: Move postfix expression code out of the NativePDB plugin.
Fri, Apr 12, 1:47 AM
labath committed rG539b7e65b450: Make TestPrintStackTraces deterministic (authored by labath).
Make TestPrintStackTraces deterministic
Fri, Apr 12, 1:02 AM
labath committed rLLDB358266: Make TestPrintStackTraces deterministic.
Make TestPrintStackTraces deterministic
Fri, Apr 12, 1:02 AM
labath committed rL358266: Make TestPrintStackTraces deterministic.
Make TestPrintStackTraces deterministic
Fri, Apr 12, 1:02 AM
labath committed rG85ce053d7e26: PDBFPO: Improvements to the AST visitor (authored by labath).
PDBFPO: Improvements to the AST visitor
Fri, Apr 12, 12:20 AM
labath committed rL358261: PDBFPO: Improvements to the AST visitor.
PDBFPO: Improvements to the AST visitor
Fri, Apr 12, 12:17 AM
labath committed rLLDB358261: PDBFPO: Improvements to the AST visitor.
PDBFPO: Improvements to the AST visitor
Fri, Apr 12, 12:17 AM
labath closed D60410: PDBFPO: Improvements to the AST visitor.
Fri, Apr 12, 12:17 AM · Restricted Project

Thu, Apr 11

labath accepted D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.

The ifdefs for the getpid() code and stuff are unfortunate, but I am not sure if using llvm libraries for that is a good idea. Right now we have the ability to compile the tests for a different architecture than the one lldb is built for. If we started using non-standard facilities in the tests, this would become a lot more complicated.

Thu, Apr 11, 11:24 PM · Restricted Project
labath updated the diff for D60410: PDBFPO: Improvements to the AST visitor.

After trying to use this in new code, I realized that the CRTP is not really
needed for what I am trying to achieve here. The same can be achieved through
more standard virtual functions.

Thu, Apr 11, 9:05 AM · Restricted Project
labath committed rGd7e12574c61c: YAMLIO: Fix serialization of strings with embedded nuls (authored by labath).
YAMLIO: Fix serialization of strings with embedded nuls
Thu, Apr 11, 7:58 AM
labath committed rL358176: YAMLIO: Fix serialization of strings with embedded nuls.
YAMLIO: Fix serialization of strings with embedded nuls
Thu, Apr 11, 7:57 AM
labath closed D60505: YAMLIO: Fix serialization of strings with embedded nuls.
Thu, Apr 11, 7:57 AM · Restricted Project
labath accepted D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
Thu, Apr 11, 7:57 AM · Restricted Project
labath accepted D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.

The new version looks really great. Thank you.

Thu, Apr 11, 7:49 AM · Restricted Project
labath accepted D60474: [llvm] [lit] Add target-x86* features.
Thu, Apr 11, 7:47 AM · Restricted Project
labath added inline comments to D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit.
Thu, Apr 11, 7:43 AM · Restricted Project
labath committed rG71b88b91f7e7: Minidump: extend UUID byte-swapping to windows platform (authored by labath).
Minidump: extend UUID byte-swapping to windows platform
Thu, Apr 11, 7:13 AM
labath committed rL358169: Minidump: extend UUID byte-swapping to windows platform.
Minidump: extend UUID byte-swapping to windows platform
Thu, Apr 11, 7:13 AM
labath committed rLLDB358169: Minidump: extend UUID byte-swapping to windows platform.
Minidump: extend UUID byte-swapping to windows platform
Thu, Apr 11, 7:13 AM
labath closed D60501: Minidump: extend UUID byte-swapping to windows platform.
Thu, Apr 11, 7:13 AM · Restricted Project

Wed, Apr 10

labath added a comment to D60498: Clean up docstrings in swig interface files.

This is purely a guess on my part, but I think this is an artefact of the process which was used to produce the swig interface files initially, though I don't know what that process actually was.

Wed, Apr 10, 9:59 AM · Restricted Project
labath added a comment to D60508: [NFC] Remove ASCII lines from comments.

Let's ship it. :)

Wed, Apr 10, 6:47 AM · Restricted Project
labath created D60505: YAMLIO: Fix serialization of strings with embedded nuls.
Wed, Apr 10, 4:55 AM · Restricted Project
labath committed rG139e9f247ab3: Minidump: Use llvm parser for reading the ModuleList stream (authored by labath).
Minidump: Use llvm parser for reading the ModuleList stream
Wed, Apr 10, 4:06 AM
labath committed rLLDB358070: Minidump: Use llvm parser for reading the ModuleList stream.
Minidump: Use llvm parser for reading the ModuleList stream
Wed, Apr 10, 4:06 AM
labath committed rL358070: Minidump: Use llvm parser for reading the ModuleList stream.
Minidump: Use llvm parser for reading the ModuleList stream
Wed, Apr 10, 4:06 AM
labath created D60501: Minidump: extend UUID byte-swapping to windows platform.
Wed, Apr 10, 2:21 AM · Restricted Project
labath created D60498: Clean up docstrings in swig interface files.
Wed, Apr 10, 1:26 AM · Restricted Project
labath committed rGf5f45f21d84b: Docstringify some comments in the swig interface files (authored by labath).
Docstringify some comments in the swig interface files
Wed, Apr 10, 12:54 AM
labath committed rLLDB358055: Docstringify some comments in the swig interface files.
Docstringify some comments in the swig interface files
Wed, Apr 10, 12:53 AM
labath committed rL358055: Docstringify some comments in the swig interface files.
Docstringify some comments in the swig interface files
Wed, Apr 10, 12:53 AM
labath committed rL358054: [zorg] Add lldb-x86_64-debian builder.
[zorg] Add lldb-x86_64-debian builder
Wed, Apr 10, 12:47 AM
labath closed D60458: [zorg] Add lldb-x86_64-debian builder.
Wed, Apr 10, 12:47 AM · Restricted Project
Herald added a project to D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID(): Restricted Project.

Well, I guess I would ask what you want to do with the GUID? If you want to match it to a debug information file, then the Debug Directory is the correct way to do that, and using a hash of the file path will not even be helpful.

Another option would be to check for a debug directory of type IMAGE_DEBUG_TYPE_REPRO, and if that exists, then it means that the COFF timestamp is a hash of the binary, so it should be stable.

If neither of these is present, then I think we should simply return false from this function and not mislead the caller. The caller might wish to use special logic if the function returns false that says "if I couldn't get a UUID from the file, then try hashing the path and doing some kind of lookup based on that", but I don't think that should be part of this function.

Wed, Apr 10, 12:41 AM · Restricted Project
labath added inline comments to D56233: [lldb-server] Add initial support for lldb-server on Windows.
Wed, Apr 10, 12:10 AM
labath added a comment to D60468: Lock accesses to OptionValueFileSpecList objects.

No opinion on the patch, but what is the reason for having settings that are shared between multiple Debugger instances? My expectation was that the debugger objects are completely independent, and I would be surprised if the value of some setting changed from under me because of something that happened in another debug session.

As Jim said, there are parts of the debugger that simply do not have access to a debugger by design. I'm honestly not sure this is the correct design in hindsight. I tried to make the global state per-debugger, but I stopped when I needed to change the Plugin registration to take a debugger (because SymbolVendor plugins would need a debugger to access search paths for example). This approach also has other challenges and breaks command completion in non-trivial ways.

Wed, Apr 10, 12:05 AM

Tue, Apr 9

labath added a comment to D60474: [llvm] [lit] Add target-x86* features.

When I requested this, I expected you would go and add something to the lldb lit config files. However, the way you've chosen to implement that seems to complement nicely the existing features in the llvm files, so I think it may go in here as well. But, I'd like for someone from the llvm side to sign off on this as well.

Tue, Apr 9, 11:31 PM · Restricted Project
labath accepted D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms.

LGTM, with some inline comments about additional c++11 goodies we can use to clean up this file further. (Also, it might be good to mention in the patch title that this is about modifying the test code, because my first though was that you are adding some locking to the actual lldb-server code.)

Tue, Apr 9, 11:02 PM · Restricted Project
labath added a comment to D60468: Lock accesses to OptionValueFileSpecList objects.

No opinion on the patch, but what is the reason for having settings that are shared between multiple Debugger instances? My expectation was that the debugger objects are completely independent, and I would be surprised if the value of some setting changed from under me because of something that happened in another debug session.

Tue, Apr 9, 9:55 AM
labath created D60458: [zorg] Add lldb-x86_64-debian builder.
Tue, Apr 9, 5:52 AM · Restricted Project
labath committed rG26ca5a57bc4c: Remove unneeded #ifdef SWIGs (authored by labath).
Remove unneeded #ifdef SWIGs
Tue, Apr 9, 2:03 AM
labath committed rL357984: Remove unneeded #ifdef SWIGs.
Remove unneeded #ifdef SWIGs
Tue, Apr 9, 2:03 AM
labath committed rLLDB357984: Remove unneeded #ifdef SWIGs.
Remove unneeded #ifdef SWIGs
Tue, Apr 9, 2:03 AM
labath closed D60400: Remove unneeded #ifdef SWIGs.
Tue, Apr 9, 2:03 AM · Restricted Project
labath committed rGff12913b638e: Minidump: use string parsing functionality from llvm (authored by labath).
Minidump: use string parsing functionality from llvm
Tue, Apr 9, 1:28 AM
labath committed rL357977: Minidump: use string parsing functionality from llvm.
Minidump: use string parsing functionality from llvm
Tue, Apr 9, 1:28 AM
labath committed rLLDB357977: Minidump: use string parsing functionality from llvm.
Minidump: use string parsing functionality from llvm
Tue, Apr 9, 1:28 AM
labath committed rG9837f54843df: Breakpad: Parse Stack CFI records (authored by labath).
Breakpad: Parse Stack CFI records
Tue, Apr 9, 1:04 AM
labath committed rLLDB357975: Breakpad: Parse Stack CFI records.
Breakpad: Parse Stack CFI records
Tue, Apr 9, 1:04 AM
labath committed rL357975: Breakpad: Parse Stack CFI records.
Breakpad: Parse Stack CFI records
Tue, Apr 9, 1:04 AM
labath closed D60268: Breakpad: Parse Stack CFI records.
Tue, Apr 9, 1:03 AM · Restricted Project
labath added inline comments to D60405: MinidumpYAML: Add support for ModuleList stream.
Tue, Apr 9, 12:57 AM · Restricted Project
labath updated subscribers of D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Tue, Apr 9, 12:48 AM · Restricted Project
labath accepted D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup.

Thank you for doing this. We probably should have done something like this a long time ago. I have a couple of inline comments, but they're all very trivial. Feel free to commit, if you agree with them.

Tue, Apr 9, 12:15 AM · Restricted Project

Mon, Apr 8

labath updated the diff for D60410: PDBFPO: Improvements to the AST visitor.

Fix a bug which meant we weren't replacing the root node correctly (I somehow
forgot to run tests before uploading).

Mon, Apr 8, 9:04 AM · Restricted Project
labath added a comment to D60410: PDBFPO: Improvements to the AST visitor.

I find this version easier to follow than the old one, but that could be simply because I didn't write it. :P
So if you believe the old one is better, I am happy to just drop this and carry on with the old one.

Mon, Apr 8, 8:52 AM · Restricted Project
labath created D60410: PDBFPO: Improvements to the AST visitor.
Mon, Apr 8, 8:48 AM · Restricted Project
labath created D60405: MinidumpYAML: Add support for ModuleList stream.
Mon, Apr 8, 6:15 AM · Restricted Project
labath committed rGaaff480c68ca: Object/Minidump: Add support for reading the ModuleList stream (authored by labath).
Object/Minidump: Add support for reading the ModuleList stream
Mon, Apr 8, 2:58 AM
labath committed rL357897: Object/Minidump: Add support for reading the ModuleList stream.
Object/Minidump: Add support for reading the ModuleList stream
Mon, Apr 8, 2:56 AM
labath closed D60121: Object/Minidump: Add support for reading the ModuleList stream.
Mon, Apr 8, 2:55 AM · Restricted Project
labath committed rG7b30751acb9c: MinidumpParser: parse SystemInfo stream via llvm (authored by labath).
MinidumpParser: parse SystemInfo stream via llvm
Mon, Apr 8, 2:55 AM
labath committed rG1beeda682baf: PDBFPO: add dyn_cast support (authored by labath).
PDBFPO: add dyn_cast support
Mon, Apr 8, 2:55 AM
labath committed rLLDB357896: MinidumpParser: parse SystemInfo stream via llvm.
MinidumpParser: parse SystemInfo stream via llvm
Mon, Apr 8, 2:55 AM