Thank you for reviewing.

• Added more tests

Thanks to all for their time and reviewing the patch.

Thanks! Landed in r252695.

Hi Kuba,

I've go fork tests working by disabling interceptors for it. It's fused with another commit in my history, so I can't be precise. But...

Thanks!

LGTM.

• Don't try to calculate field offset for Objective-C instance variables
• Added test for Objective-C instance variables
• Added a non-null pointer in test

Ping!

Thanks for reviewing.

Addressed comments.

Sorry, that's a typo. It is 24170.

Ping!

Ping!

Ping!

Thank you for reviewing!

• Added a new test file instead of adding '-analyzer-viz-egraph-ubigraph' to an existing test.

I don't have ubigraph installed either. The purpose of the test isn't to check as to whether we can generate a conforming/sensible ubigraph output, but to ensure that this tiny patch works and clang doesn't crash. So, I'd keep it. But if you are worried about other/unknown problems in ubigraph generator that the test might surface, then we can proceed without the test, and a ubigraph expert can write an output validation test.

Ping!

Ping! It seems like this patch was forgotten. This fixes PR24730, which is reported recently.

Thank you for the feedback! I have added the test in a C file, so we can get the first part of the patch in -- between lines 778-780.

• Rolled back to the first version of patch, where only parameter Out is renamed to OutStream
• Use a different test that doesn't trigger the self-loop assertion.

Ping!

OK, that makes sense. Thanks!

• Change parameter name to OutStream.

• Renamed Out parameter to Stm.
• Removed assertion that checks whether an ExplodedNode has an edge to itself.
• Added '-analyzer-viz-egraph-ubigraph' to an analyzer invocation in a test.

• Removed preprocessor directives guarding pthread.

In D10425#194696, @dblaikie wrote:

A few thoughts - but probably having some review by rtreiu would be good. He's more involved in the diagnostic development than I am.

Have you run this over any substantial existing codebase to see what the stats are like (true/false positives, etc)?

No, I haven't, but I heard Google has a large C++11 codebase :) I saw this bug in clang's source code (I didn't submit patch for it yet, can do it in a few days).

Removed PTHREAD_CREATE_JOINABLE definition.

Allow only Mac OS X implementation of internal_start_thread and internal_join_thread

Ping.

Return from analyzeInClassInitializer, if in-class initializer is null.

Thank you for reviewing!

Thank you both for your time!

• Sort includes alphabetically
• Remove newline in GetRSS

Addressed comments.

Hi Alexander,