Hi @labath, Thank you so much for your comment and correction. The initial version of the test was the following, with array of ValueCheck objects:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 6 2021
Dec 3 2021
Nov 26 2021
Nov 25 2021
As we discussed offline, I add the print tests, since SBValue.GetValue() doesn't work for complex structures
Nov 24 2021
Unified tests added
Nov 23 2021
Deleted duplicated tests from both platforms
List tests unification for libcxx and libstdcpp
Done!
Nov 22 2021
Nov 21 2021
Hi Walter :)
Nov 19 2021
Nov 17 2021
Done!
All the above-mentioned is changed. Thank you!
Nov 16 2021
When I mocked the num_children to return 4, formatter works for any structure with size <= 4. here is the example:
Nov 14 2021
Some naming corrections
Nov 13 2021
Cosmetic change
Hi Walter,
All the changes are done and tests pass
Nov 12 2021
Hi Walter :) This is the Draft PR for the unordered_map/set data formatter. Currently it works well in case both key and values are of the same primitive data types (except string).
Small cosmetic change
Nov 9 2021
Right size is returned and tests are unified! :)
All the requested changes are done :)
Nov 8 2021
All of the requested changes are done. Please, let me know if any other corrections are needed
Nov 7 2021
Hi Walter:) Please, could you advise what can I change/do more? As a next step, I will unify the tests across the libcxx and libstdcpp formatters.
Oct 30 2021
refactoring
rebased
I thought that you misprinted the name and wanted to call the formatter MapLikeSynth provider. Please, correct me if I am wrong and I will change names accordingly
All the above specified parts are changed. Thank you!
Oct 29 2021
Oct 28 2021
Oct 27 2021
Last thing corrected :)
Refactoring
Small formatting
Thank you for the comments, I have done everything specified!
Oct 26 2021
Refactoring
Refactoring
With this changes I substitute the verbose long printed check with ValueCheck approach
Fixing
Deleted libcxx tests
Set synthetic child
Set synthetic children
Minor corrections
Oct 25 2021
I have corrected everything according to the previous comments. Wallace will kindly help me to format the code, since I have the following formatter error Stack dump:
0. Program arguments: clang-format -lines=1:149 -lines=0:0 lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
/lib/x86_64-linux-gnu/libLLVM-10.so.1(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x1f)[0x7fa7b5d204ff]
/lib/x86_64-linux-gnu/libLLVM-10.so.1(_ZN4llvm3sys17RunSignalHandlersEv+0x50)[0x7fa7b5d1e7b0]
/lib/x86_64-linux-gnu/libLLVM-10.so.1(+0x981ac5)[0x7fa7b5d20ac5]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0)[0x7fa7bc4f03c0]
/lib/x86_64-linux-gnu/libclang-cpp.so.10(_ZNK5clang13SourceManager16translateLineColENS_6FileIDEjj+0xcf)[0x7fa7ba1cc83f]
clang-format[0x407e10]
clang-format[0x406b64]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3)[0x7fa7b4e4e0b3]
clang-format[0x40652e]
error: clang-format -lines=1:149 -lines=0:0 lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp failed