Page MenuHomePhabricator
Feed Advanced Search

Sat, Apr 10

whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

Rebase over D98635. Highlighting only the parameter's name, not the entire range of the parameter.

Sat, Apr 10, 11:43 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.
  • Fixed a few nits.
  • Rebased, and added highlighting (under-squiggly) the parameter/return type of conversion operators for extra emphasis.
Sat, Apr 10, 11:29 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Made sure that the parameter's name is highlighted promptly in the "first|last parameter of the range is..." note.

Sat, Apr 10, 11:26 AM · Restricted Project, Restricted Project
whisperity updated the diff for D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable.

[NFC] Rebase.

Sat, Apr 10, 10:33 AM · Restricted Project, Restricted Project
whisperity updated the diff for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.

[NFC] Rebase.

Sat, Apr 10, 10:32 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Rebased over D98635, allowing us to properly highlight the found "mixable adjacent parameter range" (assuming it's on the same line, of course):

Sat, Apr 10, 10:30 AM · Restricted Project, Restricted Project
whisperity committed rG8fa39752477b: [libtooling][clang-tidy] Fix off-by-one rendering issue with SourceRanges (authored by whisperity).
[libtooling][clang-tidy] Fix off-by-one rendering issue with SourceRanges
Sat, Apr 10, 9:53 AM
whisperity committed rG3b677b81cec7: [libtooling][clang-tidy] Fix diagnostics not highlighting fed SourceRanges (authored by whisperity).
[libtooling][clang-tidy] Fix diagnostics not highlighting fed SourceRanges
Sat, Apr 10, 7:44 AM
whisperity closed D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.
Sat, Apr 10, 7:44 AM · Restricted Project, Restricted Project
whisperity removed 1 blocking reviewer(s) for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges: alexfh.
Sat, Apr 10, 7:44 AM · Restricted Project, Restricted Project

Fri, Apr 9

whisperity added a comment to D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

Ping!

Fri, Apr 9, 3:55 AM · Restricted Project, Restricted Project

Wed, Mar 24

whisperity updated subscribers of D98876: [clang][ASTImporter] Add import support for SourceLocExpr..
Wed, Mar 24, 2:01 AM · Restricted Project
whisperity updated subscribers of D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType..
Wed, Mar 24, 2:01 AM · Restricted Project

Mon, Mar 22

whisperity added a comment to D98477: [ADT] Add IntrusiveVariant.

I'm glad there is interest from others in the new type, I was worried at first it may be too niche of a use.

Mon, Mar 22, 3:48 AM · Restricted Project

Fri, Mar 19

whisperity added inline comments to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Fri, Mar 19, 7:03 AM · Restricted Project, Restricted Project

Thu, Mar 18

whisperity updated the summary of D98876: [clang][ASTImporter] Add import support for SourceLocExpr..
Thu, Mar 18, 10:09 AM · Restricted Project
whisperity added a comment to D98477: [ADT] Add IntrusiveVariant.

I'm not qualified with template magic and I am definitely not a person of authority on this library, so all my comments come from a generally strictly "user's perspective". I would love to have a variant type (it's surprising there never has been one in the code for so long), and I am happy I found this patch instead of trying to get into writing a similar thing myself...

Thu, Mar 18, 10:06 AM · Restricted Project
whisperity added a reviewer for D98477: [ADT] Add IntrusiveVariant: chandlerc.
Thu, Mar 18, 9:56 AM · Restricted Project
whisperity added inline comments to D98477: [ADT] Add IntrusiveVariant.
Thu, Mar 18, 9:54 AM · Restricted Project
whisperity added inline comments to D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.
Thu, Mar 18, 9:17 AM · Restricted Project, Restricted Project
whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Thu, Mar 18, 7:55 AM · Restricted Project, Restricted Project
whisperity updated the diff for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.

NFC Turned some Optional<T> into just T.

Thu, Mar 18, 7:55 AM · Restricted Project, Restricted Project
whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
  • NFC Fixed some nits
  • Added a new check option, MinimumIdentifierNameLength instead of a hardcoded 3 value. Defaults to 3.
  • Fixed an issue with heuristics matching only in one direction but not in the other direction silenced a warning that clearly should have been there.
Thu, Mar 18, 7:34 AM · Restricted Project, Restricted Project
whisperity added inline comments to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Thu, Mar 18, 6:32 AM · Restricted Project, Restricted Project
whisperity added inline comments to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Thu, Mar 18, 6:00 AM · Restricted Project, Restricted Project
whisperity added inline comments to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Thu, Mar 18, 5:38 AM · Restricted Project, Restricted Project
whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

NFC Made the code more legible, updated and clarified some comments, fixed grammar issues.

Thu, Mar 18, 5:37 AM · Restricted Project, Restricted Project
whisperity added inline comments to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Thu, Mar 18, 2:45 AM · Restricted Project, Restricted Project

Wed, Mar 17

whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Wed, Mar 17, 7:10 AM · Restricted Project, Restricted Project
whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Wed, Mar 17, 7:02 AM · Restricted Project, Restricted Project
whisperity updated the diff for D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
  • Made a precondition check explicit, and added an early return to not evaluate a case where it would return false anyways...
Wed, Mar 17, 5:34 AM · Restricted Project, Restricted Project
whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Wed, Mar 17, 5:33 AM · Restricted Project, Restricted Project
whisperity updated the diff for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
  • Added some test cases to ensure edge cases won't crash.
Wed, Mar 17, 5:32 AM · Restricted Project, Restricted Project
whisperity updated the diff for D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable.
Wed, Mar 17, 5:32 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Wed, Mar 17, 5:31 AM · Restricted Project, Restricted Project
whisperity updated the diff for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.
  • Made the diagnostic message about "binding power" easier to understand.
Wed, Mar 17, 5:30 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
  • Add const reverse iterator to the default-ignored typename list.
Wed, Mar 17, 5:29 AM · Restricted Project, Restricted Project
whisperity updated the diff for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

[NFC] Fixed nits and code formatting.

Wed, Mar 17, 2:45 AM · Restricted Project, Restricted Project

Tue, Mar 16

whisperity added inline comments to D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.
Tue, Mar 16, 12:18 PM · Restricted Project, Restricted Project
whisperity added a comment to D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

@aaron.ballman Could you please help me understand this pre-merge buildbot? It says that Debian failed, with the following message:

Tue, Mar 16, 12:00 PM · Restricted Project, Restricted Project
whisperity changed 2 blocking reviewer(s) for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges, added 1: alexfh; removed 1: klimek.
Tue, Mar 16, 11:52 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters': njames93.
Tue, Mar 16, 11:50 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions: JonasToth.
Tue, Mar 16, 11:50 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics: JonasToth.
Tue, Mar 16, 11:50 AM · Restricted Project, Restricted Project
whisperity added a reviewer for D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable: JonasToth.
Tue, Mar 16, 11:50 AM · Restricted Project, Restricted Project
whisperity edited reviewers for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check, added: njames93; removed: Szelethus.
Tue, Mar 16, 11:50 AM · Restricted Project, Restricted Project
whisperity added inline comments to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Tue, Mar 16, 11:22 AM · Restricted Project, Restricted Project
whisperity added inline comments to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Tue, Mar 16, 11:07 AM · Restricted Project, Restricted Project
whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Tue, Mar 16, 10:59 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

[...] so please hold off on landing it for a bit in case any of the other reviewers want to weigh in.

Tue, Mar 16, 10:44 AM · Restricted Project, Restricted Project
whisperity added inline comments to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Tue, Mar 16, 10:39 AM · Restricted Project, Restricted Project
whisperity added inline comments to D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable.
Tue, Mar 16, 10:36 AM · Restricted Project, Restricted Project
whisperity added inline comments to D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.
Tue, Mar 16, 10:29 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Tue, Mar 16, 10:25 AM · Restricted Project, Restricted Project
whisperity added inline comments to D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
Tue, Mar 16, 10:25 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Tue, Mar 16, 10:21 AM · Restricted Project, Restricted Project

Mon, Mar 15

whisperity updated the diff for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

Fixed a test file that I originally missed to align with the changes.

Mon, Mar 15, 11:13 AM · Restricted Project, Restricted Project
whisperity added a comment to D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

Strange because I specifically ran both check-clang and check-clang-tools locally, but will look into this.

Mon, Mar 15, 9:54 AM · Restricted Project, Restricted Project
whisperity added a comment to D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.
Mon, Mar 15, 9:46 AM · Restricted Project, Restricted Project
whisperity retitled D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges from [libtooling][clang-tidy] Fix diagnostics not respecting and highlight fed SourceRanges to [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.
Mon, Mar 15, 9:25 AM · Restricted Project, Restricted Project
whisperity retitled D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges from [libtooling][clang-tidy] Fix diagnostics not handlings SourceRange highlights to [libtooling][clang-tidy] Fix diagnostics not respecting and highlight fed SourceRanges.
Mon, Mar 15, 9:24 AM · Restricted Project, Restricted Project
whisperity added reviewers for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges: klimek, alexfh.
Mon, Mar 15, 9:20 AM · Restricted Project, Restricted Project
whisperity updated the diff for D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

NFC I originally wrote a Release Notes entry about this, which I forgot to commit before I generated the patch file I uploaded, this is fixed now.

Mon, Mar 15, 9:16 AM · Restricted Project, Restricted Project
whisperity requested review of D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.
Mon, Mar 15, 9:13 AM · Restricted Project, Restricted Project

Mar 10 2021

whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
  • Massively refactored and modernised the implementation
  • Removed spaghetti code related to the check options and made their storage and defaults clearer
  • Fixed modelling issues that caused false positives around lambdas, overloaded call operators, recursive calls, enumconstant arguments
  • Made the abbreviation dictionary for the Abbreviations heuristic a check-option
  • Made the check message much more legible
  • Fixed a severe modelling issue about not respecting or handling record types passed by copy (CXXConstructExpr)
  • Wrote the documentation for real, including all heuristics, default values, options, etc. The original documentation was basically empty. For the docs, I used @varjujan's thesis (which subject was this check), which is unfortunately only available in Hungarian, but it helped me understand what some of the enums and the Bound doing on the inside.
  • Thanks to having written a proper documentation, I also renamed a few symbols and check options to better tell what they are about.
Mar 10 2021, 7:57 AM · Restricted Project, Restricted Project

Mar 3 2021

whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

@aaron.ballman I've reworked and uploaded the final addition to this line, the crown jewel, the very reason this checker was developed (D75041). So, AFAIK, the "let's rewrite the whole thing with better code quality" work can be considered done, and we may move on with the review.

Mar 3 2021, 5:55 AM · Restricted Project, Restricted Project
whisperity retitled D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters' from [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters' to [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Mar 3 2021, 5:53 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.

After reading through the diff as rendered by Phabricateur, I realised I left in a few crappy debug prints and commented-out values that are not needed in the end. This is fixed now.

Mar 3 2021, 5:53 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.
  • Rebased over updated, rewritten, newer base patch version, vastly increased the quality of the code.
  • Tidied the tests and made them more self-explanatory.
  • Implemented handling function pointer conversion (implicit losing of noexcept). This was missing from the previous uploaded patch.
  • Ensured that implicit conversion sequences are diagnosed properly, even when typedefs are involved. This means that if the conversion takes 4-5-6 logical steps (e.g. instead of SomeFancyIntTypedef -> DoubleBoxingType, emit SomeFancyIntTypedef -> int -> double -> const double -> DoubleBoxingType (user defined ctor)) it's all explained properly.
  • Respect the user's decision about the mixability of T and const T (the previous patch D96355) even in the context of implicit conversions (i.e. if the user did not allow that, do not consider a user-defined type which constructor takes a const mixable with a non-const other parameter).
  • Put a diagnostic note to the location of the FuntionDecl of the conversion method involved in the mixability.
Mar 3 2021, 5:31 AM · Restricted Project, Restricted Project

Feb 25 2021

whisperity updated the diff for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
  • [NFC] Reformat the documentation so option values are in single backticks.
Feb 25 2021, 10:48 AM · Restricted Project, Restricted Project
whisperity updated the diff for D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
  • [NFC] Reformat the documentation so option values are in single backticks.
Feb 25 2021, 10:48 AM · Restricted Project, Restricted Project
whisperity updated the diff for D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable.
  • [NFC] Reformat the documentation so option values are in single backticks.
Feb 25 2021, 10:47 AM · Restricted Project, Restricted Project
whisperity updated the diff for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.
  • [NFC] Reformat the documentation so option values are in single backticks.
Feb 25 2021, 10:46 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
  • [NFC] Reformat the documentation so option values are in single backticks.
Feb 25 2021, 10:46 AM · Restricted Project, Restricted Project

Feb 24 2021

whisperity added a comment to D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.

Please mention new option in Release Notes.

Feb 24 2021, 12:07 AM · Restricted Project, Restricted Project

Feb 23 2021

whisperity updated the diff for D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
  • [NFC] Realised I forgot to add the new option to the check's documentation. This is fixed now.
Feb 23 2021, 8:04 AM · Restricted Project, Restricted Project
whisperity requested review of D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'.
Feb 23 2021, 7:47 AM · Restricted Project, Restricted Project
whisperity updated the diff for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
  • Fixed an issue of the "same function" heuristic that blew up if functions are forward declared.
  • [NFC] Optimised "relatedness" is to be checked first (as it's a trivial double hashmap lookup) before the recursive descent of type checking.
Feb 23 2021, 1:10 AM · Restricted Project, Restricted Project

Feb 19 2021

whisperity updated the diff for D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'.
  • Rebased over updated, rewritten, newer base patch version.
  • Added the heuristic for "same member access" to the patch (which was so far only on my development branch).
Feb 19 2021, 11:03 AM · Restricted Project, Restricted Project

Feb 13 2021

whisperity added a comment to D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'..

I don't see the use case you suggest as a strong enough motivation for this, clang-format does this job very well and we shouldn't be reinventing the wheel here.

Feb 13 2021, 4:28 AM · Restricted Project, Restricted Project

Feb 12 2021

whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Make sure that overloadable binary operators are ignored properly.

Feb 12 2021, 6:03 AM · Restricted Project, Restricted Project

Feb 9 2021

whisperity requested review of D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable.
Feb 9 2021, 10:24 AM · Restricted Project, Restricted Project
whisperity updated the diff for D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.
  • NFC Code style, formatting, wording, etc. changes as per review comments.
  • NFC Removed a stale FIXME
Feb 9 2021, 10:10 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

NFC (With all the restructuring and trying to figure out how to implement the latest change, I managed to upload the wrong, unclean diff...)

Feb 9 2021, 5:58 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 9 2021, 5:52 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Made detection of macros as "parameter type names" more robust.

Feb 9 2021, 5:51 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 9 2021, 4:16 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
  • Added a C test file with some C-specific language constructs that we may or may not match.
  • Explained limitations with regards to variadics, templates, etc. better in the docs, and added test cases for these too.
  • When comparing the type names against the ignored type name list, do not consider PrintingPolicy, but take exactly what's in the source code. This mostly concerns bool and _Bool at face value, so this is tested in the C file too.
Feb 9 2021, 4:04 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

Why "easily" instead of "suspicious", "spuriously" or any of the other words that are already used?

Feb 9 2021, 1:18 AM · Restricted Project, Restricted Project

Feb 8 2021

whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 8 2021, 7:57 AM · Restricted Project, Restricted Project

Feb 5 2021

whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 5 2021, 10:47 AM · Restricted Project, Restricted Project

Feb 2 2021

whisperity added inline comments to D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics.
Feb 2 2021, 8:57 AM · Restricted Project, Restricted Project
whisperity added a comment to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

(Typing this in here so it is not forgotten.) @aaron.ballman suggested in http://reviews.llvm.org/D69560#inline-893813 that a case of argument and parameter swaps could be discovered between forward declarations and the definitions, i.e.

Feb 2 2021, 8:37 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 8:02 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 7:50 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 7:23 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 7:22 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.

I haven't read through all the comments, but the word 'easily' implies 'desirable'. This check seems to be for finding params which are undesirably swappable, right?

Feb 2 2021, 7:19 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 7:13 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check.
Feb 2 2021, 6:55 AM · Restricted Project, Restricted Project