Page MenuHomePhabricator
Feed Advanced Search

Thu, May 28

whisperity resigned from D75665: [analyzer] On-demand parsing capability for CTU.
Thu, May 28, 1:02 AM · Restricted Project

Fri, May 15

whisperity added a comment to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..

I was looking at CERT ARR32-C "Ensure size arguments for variable length arrays are in a valid range". The VLA should not have a size that is larger than std::numeric_limits<size_t>::max(), in other words "fit into a size_t value", or not?

Yes creating the too large VLA in itself is not a bug, only when sizeof is called on it because it can not return the correct size. A non-fatal error is a better option, or delay the check until the sizeof call. But probably the create of such a big array in itself is sign of code smell. The array actually does not need to be created to make the problem happen, only a sizeof call on a typedef-ed and too large VLA. (What does mean that "result of sizeof is implementation-defined"? Probably it can return not the size in bytes or "chars" but something other? In such a case the checker would be not correct.)

Fri, May 15, 3:02 AM · Restricted Project
whisperity added inline comments to D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow..
Fri, May 15, 2:19 AM · Restricted Project

Tue, May 12

whisperity requested changes to D75665: [analyzer] On-demand parsing capability for CTU.

(Maybe this will make Phab not show "✅ Accepted"...)

Tue, May 12, 4:47 AM · Restricted Project
whisperity added a comment to D75665: [analyzer] On-demand parsing capability for CTU.

Please check the summary of the patch, it seems to contain old information as well.

Tue, May 12, 4:47 AM · Restricted Project

Wed, May 6

whisperity retitled D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic from [analyzer][MalloChecker] When modeling realloc-like functions, don't early return if the argument is symbolic to [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic.
Wed, May 6, 5:20 AM · Restricted Project

Apr 24 2020

whisperity added inline comments to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.
Apr 24 2020, 3:13 AM · Restricted Project
whisperity added a comment to D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug.

@steakhal You might want to update the patch summary before committing this to the upstream (it still mentions "not needing a visitor" 😄)

Apr 24 2020, 2:40 AM · Restricted Project

Apr 23 2020

whisperity planned changes to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the summary of D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.
Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity updated the diff for D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

First things first, we were 50 thousand (!) patches behind reality. Rebased to master. Fixed it to compile, too. Otherwise, NFC so far.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
whisperity commandeered D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

Assuming direct control. Previous colleagues and university mates departed for snowier pastures, time to try to do something with this check.

Apr 23 2020, 3:45 AM · Restricted Project, Restricted Project
Herald added a reviewer for D78648: [CMake] Bump CMake minimum version to 3.13.4: ftynse.
Apr 23 2020, 3:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 23 2020, 3:13 AM · Restricted Project

Apr 22 2020

whisperity added inline comments to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity added inline comments to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity retitled D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' from [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check to [clang-tidy] Approximate implicit conversion issues for the 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity updated the diff for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
  • Re-organised code, removed debug prints, rebased, the usual tidy-up.
  • Bug fixes on certain crashes like incomplete types, conversion operator templates, etc.
  • Even more bug fixes against crashes, hopefully... sorry I lost the individual commits in a squash I think
Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
whisperity added a parent revision for D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type': D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity added a child revision for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check: D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity created D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Better organisation of code, cleanup of debug prints, fix nomenclature of functions
  • Explicitly mention the first and last param of the range for clarity
  • Downlift the logic of joining and breaking ranges to main patch (this isn't terribly useful at this point, but both subsequent improvements to the check depend on this change)
    • Basically no longer assume that if param N can be swapped with param 1, then it can also be swapped with 2, 3, etc. without checking.
  • Made the list of ignored parameter and type names configurable as a checker option
  • Changed the default value of MinimumLength to 2, as prescribed in the guideline's text.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project
whisperity updated the summary of D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Apr 22 2020, 9:46 AM · Restricted Project, Restricted Project

Apr 21 2020

whisperity added inline comments to D77745: [analyzer] ASTMatchers: Extend with Static Analyzer data types.
Apr 21 2020, 8:37 AM · Restricted Project
whisperity added inline comments to D75665: [analyzer] On-demand parsing capability for CTU.
Apr 21 2020, 8:04 AM · Restricted Project

Apr 14 2020

whisperity added a reviewer for D78009: [analyzer][NFC] Remove SummaryManager.h: martong.

Adding @martong, he might have knowledge about the whole summary thing as he's tinkering the(?) STL checker.

Apr 14 2020, 8:32 AM · Restricted Project

Mar 23 2020

whisperity planned changes to D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 23 2020, 12:00 PM · Restricted Project, Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

@aaron.ballman @njames93 Should I write up a pitch mail to cfe-dev about this?

Mar 23 2020, 3:48 AM · Restricted Project, Restricted Project
whisperity committed rGdf5fa4873976: [clang-tidy][NFC] Add missing check group docs and order entries (authored by whisperity).
[clang-tidy][NFC] Add missing check group docs and order entries
Mar 23 2020, 3:16 AM
whisperity closed D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
Herald updated subscribers of D70411: [analyzer] CERT STR rule checkers: STR31-C.
Mar 23 2020, 3:15 AM · Restricted Project
whisperity added a comment to D76545: [clang-tidy] Add a new check group 'experimental-'.

I think we want to keep the experimental checks grouped to their parent module rather than being in a module of their own.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project
whisperity added a comment to D76541: [clang-tidy][NFC] Add missing check group docs and order entries.

Forgive me if I'm wrong, but these kinds of changes typically don't require a review.

Mar 23 2020, 3:15 AM · Restricted Project, Restricted Project

Mar 21 2020

whisperity added a parent revision for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check: D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity added a child revision for D76545: [clang-tidy] Add a new check group 'experimental-': D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Renamed check to experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type.
  • s/argument/parameter/g in the code and output where appropriate.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity added a parent revision for D76545: [clang-tidy] Add a new check group 'experimental-': D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity added a child revision for D76541: [clang-tidy][NFC] Add missing check group docs and order entries: D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity created D76545: [clang-tidy] Add a new check group 'experimental-'.
Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity updated the diff for D76541: [clang-tidy][NFC] Add missing check group docs and order entries.

ClangTidyForceLinker.h also contained the entries without alphabetic order.

Mar 21 2020, 5:53 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

@aaron.ballman I've gone over LLVM (and a few other projects). Some general observations:

Mar 21 2020, 5:20 AM · Restricted Project, Restricted Project
whisperity created D76541: [clang-tidy][NFC] Add missing check group docs and order entries.
Mar 21 2020, 3:43 AM · Restricted Project, Restricted Project

Mar 17 2020

whisperity added inline comments to D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator.
Mar 17 2020, 10:43 AM · Restricted Project

Feb 26 2020

whisperity added a comment to D75171: [Analyzer] Fix for incorrect use of container and iterator checkers.

Also, errors should conceptually break the operation at hand, so this thing should be a warning instead?

Feb 26 2020, 8:04 AM · Restricted Project
whisperity added a comment to D75171: [Analyzer] Fix for incorrect use of container and iterator checkers.

Do you have access to the Driver somehow? Instead of a cerr (-ish) output, something that is formatted like a "true" error diagnostic (or warning), such as "no such file or directory" would be much better, I fear this [ERROR] will simply be flooded away with the usual diagnostic output on screen, especially if multiple files are concerned.

Feb 26 2020, 7:55 AM · Restricted Project

Feb 25 2020

whisperity added a reviewer for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type': aaron.ballman.

WIP because there's a lot of debug stuff that should be cleared out from here. This is a crude patch. It works fancy, but the code is crude.

Feb 25 2020, 5:59 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

Btw, we should update the terminology in the patch to use parameter instead of argument (parameters are what the function declares, arguments are what are passed in at the call site and they bind to parameters -- the issue this check is trying to solve is on the declaration side, not the caller side).

Feb 25 2020, 5:59 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

@aaron.ballman @vingeldal I'll go over the findings (as I've run this on LLVM and various other projects, a few examples are uploaded in my first comment as HTML renders of the bug report!) soon, but I want to wait until a research paper I have based on this topic gets a final decision. (It should happen soon.) I also plan to refurbish D20689 and have it upstreamed as a "co-checker" of this (one for the interface rule, one for the call sites, they kinda want to solve different aspects of the same issue, let it be up for the project how much they wish to enforce).

Feb 25 2020, 5:49 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I think this value very well may strike a good balance in that compromise but I still think it is a clear deviation from the guideline as specified.
IMO all deviations from the guideline should be explicitly requested by the user, not set by default, no matter how useful that deviation is.

Feb 25 2020, 1:10 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

Doesn't clang-tidy exclude warnings from system headers by default though?

Third-party SDKs are not always brought in as system headers, unfortunately. Even ignoring system and third-party headers, having two parameters of the same type is a natural occurrence for some data types (like bool) where it is going to be extremely hard to tell whether they're related or unrelated parameters.

Feb 25 2020, 1:01 AM · Restricted Project, Restricted Project

Feb 24 2020

whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I am also concerned about the false positives from this check because I don't think there's going to be an easy heuristic for determining whether two identifiers are "related" to one another.

Feb 24 2020, 8:49 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

I'd rather not call them false positive because the definition of false positive is ugly and mushy with regards to this check. This check attempts to enforce an interface rule, whether you(r project) wants to adhere the rule is a concise decision. A type equivalence (or convertibility in case of the follow-up patch D75041 that considers implicit conversions) should be a "true positive" in every case, as an indicator of potentially bad design.

Feb 24 2020, 8:49 AM · Restricted Project, Restricted Project
whisperity added a parent revision for D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type': D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project
whisperity planned changes to D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project
whisperity created D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project
whisperity added a child revision for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check: D75041: [clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'.
Feb 24 2020, 5:01 AM · Restricted Project, Restricted Project

Jan 1 2020

whisperity planned changes to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

There are a few really minor bug fixes, test additions, documentation update, etc. coming along soon, but I've some more pressing matters. However, please feel free to review the patch as-is!

Jan 1 2020, 12:40 PM · Restricted Project, Restricted Project

Dec 31 2019

whisperity added a comment to D71963: clang-tidy doc: Add the severities description.

@vingeldal Apologies, in that case. However, I would still claim that style (as a potential severity) has its purpose for Tidy checkers, not just for clang-format.

Dec 31 2019, 4:04 AM · Restricted Project

Dec 30 2019

whisperity added a comment to D71963: clang-tidy doc: Add the severities description.
  • Style: things that are handled by clang-format rather than clang-tidy.
Dec 30 2019, 5:35 AM · Restricted Project

Dec 24 2019

whisperity added a comment to D70876: [clang-tidy] Add spuriously-wake-up-functions check.

The checks.rst has recently been updated to show "normal" (main entry) checks and "aliases" in different tables in D36051. Please register the alias-ness accordingly.

Dec 24 2019, 3:56 AM · Restricted Project, Restricted Project
whisperity committed rG002e07208a67: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const (authored by whisperity).
[clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const
Dec 24 2019, 2:16 AM
whisperity closed D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 24 2019, 2:16 AM · Restricted Project

Dec 22 2019

whisperity updated subscribers of D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 22 2019, 5:07 AM · Restricted Project
whisperity created D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const.
Dec 22 2019, 5:05 AM · Restricted Project

Dec 20 2019

whisperity added a comment to D36051: Move from a long list of checkers to tables.

I am a little bit conflicted about the Severity column. While I know our people put a great deal of effort into keeping this classification sane, what was put into CodeChecker is, at the end of the day, a pretty arbitrary classification.

Dec 20 2019, 8:29 AM · Restricted Project
whisperity added a comment to D36051: Move from a long list of checkers to tables.


here is the result

Dec 20 2019, 5:12 AM · Restricted Project

Dec 17 2019

whisperity added a comment to D71612: [analyzer] Add PlacementNewChecker.

Are buffers otherwise modelled by the Analyser, such as results of the malloc family and alloca intentionally not matched, or are there some tests missing regarding this?

Dec 17 2019, 8:57 AM · Restricted Project

Dec 12 2019

whisperity added a comment to D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check.

I have developed a related check in D69560. That one considers types, but is an interface rule checker, and does not consider (any) potential call sites. Moreover, it does not consider "swaps" that happen across a function call, only, as the name implies, adjacent similar-type ranges.

Dec 12 2019, 2:53 AM · Restricted Project, Restricted Project

Dec 9 2019

whisperity added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Dec 9 2019, 5:45 AM · Restricted Project, Restricted Project
whisperity added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

Can you refresh my memory on whether a rule for "if init expr is constant, initialise in class body instead" exists for init list members? If so, this will be a funny "two pass needed to fix" kind of check.

Dec 9 2019, 5:45 AM · Restricted Project, Restricted Project
whisperity added inline comments to D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc.
Dec 9 2019, 2:05 AM · Restricted Project, Restricted Project

Dec 5 2019

whisperity added a comment to D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc.

While I can't pitch in with actual findings of this check, @MyDeveloperDay, you're right in many aspects, including those specific examples not firing. But an example that actually fires this check indicates a very specific undefined behaviour case. So if such bogus code (that would trigger on this check) did not cause run-time issues so far, it's because they never free() their memory allocations (really bad?), or their platform is particular enough that it allows calling free into the buffer, not only for the start of the buffer.

Dec 5 2019, 7:59 AM · Restricted Project, Restricted Project

Nov 18 2019

whisperity retitled D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers from [Analyzer] Iterator Checkers - Separate iterator modelling and the actual checkers to [Analyzer] [NFC] Iterator Checkers - Separate iterator modelling and the actual checkers.
Nov 18 2019, 2:20 AM · Restricted Project

Oct 31 2019

whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Removed This check from the documentation comment of the check's class too.
Oct 31 2019, 3:07 AM · Restricted Project, Restricted Project
whisperity updated the summary of D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Oct 31 2019, 3:07 AM · Restricted Project, Restricted Project
whisperity updated the diff for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
  • Fix some comments, formatting and documentation
  • Organised test files to be in the same directory as others on the Monorepo structure
  • Helper functions moved from namespace (anonymous) to static.
  • Added test for C and enabled check for C code.
Oct 31 2019, 3:07 AM · Restricted Project, Restricted Project
whisperity added inline comments to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Oct 31 2019, 3:07 AM · Restricted Project, Restricted Project

Oct 29 2019

whisperity updated subscribers of D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Oct 29 2019, 8:07 AM · Restricted Project, Restricted Project
whisperity added reviewers for D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check: Szelethus, baloghadamsoftware.

@Szelethus and @baloghadamsoftware are colleagues to me whom are far more knowledgeable about check development and I want them to see that I want a review from them. I specifically didn't do an "internal with colleagues" downstream review with regards to this code.

Oct 29 2019, 8:07 AM · Restricted Project, Restricted Project
whisperity added a comment to D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.

A few interesting "true positive" findings:

Oct 29 2019, 6:17 AM · Restricted Project, Restricted Project
whisperity created D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check.
Oct 29 2019, 6:16 AM · Restricted Project, Restricted Project

Aug 30 2019

whisperity accepted D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.

@Szelethus Nope.

Aug 30 2019, 4:47 AM · Restricted Project, Restricted Project

Aug 16 2019

whisperity added inline comments to D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.
Aug 16 2019, 5:22 AM · Restricted Project, Restricted Project

Apr 29 2019

whisperity added inline comments to D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures).
Apr 29 2019, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
whisperity added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

@dcoughlin How would removing the USAGE part of the dump and keeping only the list of options and their formatted help sound? That way, this option will not invite the user to directly call the analyzer.

Apr 29 2019, 6:03 AM · Restricted Project, Restricted Project
whisperity added a comment to D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.

I think this is good. Patch still marked as Needs review for some reason. 😦 Can we look up this blocking review thing? Perhaps this could be marked ready to roll once the dependency patch is ironed out.

Apr 29 2019, 5:45 AM · Restricted Project, Restricted Project
whisperity added a comment to D59465: [analyzer] Add a test plugin for checker option handling.

@Szelethus I know the dependent patch D59464 will move examples/analyzer-plugin to test/Analysis/plugins/..., but this patch still seems to affect examples/. Are you sure this is the right diff? Because you are adding brand new files and brand new "folders", I don't think that'll apply cleanly.

Apr 29 2019, 5:31 AM · Restricted Project, Restricted Project

Apr 26 2019

whisperity updated the summary of D61136: [Analyzer] Refactor begin and end symbol creation.
Apr 26 2019, 3:11 AM · Restricted Project, Restricted Project

Mar 12 2019

whisperity added inline comments to D57860: [analyzer] Validate checker option names and values.
Mar 12 2019, 6:21 AM · Restricted Project, Restricted Project
whisperity added a comment to D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

In case no bug reports against the checker are reported on the mailing list or Bugzilla, I wholeheartedly agree with kicking the ball here.

Mar 12 2019, 3:47 AM · Restricted Project
whisperity added inline comments to D57860: [analyzer] Validate checker option names and values.
Mar 12 2019, 3:35 AM · Restricted Project, Restricted Project
whisperity added inline comments to D58065: [analyzer] Document the frontend library.
Mar 12 2019, 3:25 AM · Restricted Project
whisperity added inline comments to D57855: [analyzer][NFC] Reimplement checker options.
Mar 12 2019, 3:10 AM · Restricted Project

Feb 18 2019

whisperity added a comment to D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements.

Yeah, it seems upstream has moved away due to @Szelethus' implementation of a much more manageable "checker dependency" system. You most likely will have to rebase your patch first, then check what you missed which got added to other merged, existing checkers.

Feb 18 2019, 12:07 AM · Restricted Project, Restricted Project

Jan 23 2019

whisperity updated the summary of D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.
Jan 23 2019, 10:07 AM · Restricted Project
whisperity updated the summary of D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check.
Jan 23 2019, 10:07 AM · Restricted Project

Jan 18 2019

whisperity added a comment to D35068: [analyzer] Detect usages of unsafe I/O functions.

Edit: it doesn't, but CMake is mostly a C project and it does!

Jan 18 2019, 2:42 AM · Restricted Project

Dec 14 2018

whisperity updated the summary of D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer.
Dec 14 2018, 5:30 AM · Restricted Project

Dec 3 2018

whisperity retitled D53812: [Analyzer] Iterator Checker - Forbid decrements past the begin() and increments past the end() of containers from [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers to [Analyzer] Iterator Checker - Forbid decrements past the begin() and increments past the end() of containers.
Dec 3 2018, 4:26 AM · Restricted Project

Nov 21 2018

whisperity added a comment to D54757: [clang-tidy] new check: bugprone-branch-clone.

Bar the previous comments, I really like this. The test suite is massive and well-constructed. Do we know of any real-world findings, maybe even from LLVM?

GCC 7 introduced -Wduplicated-branches, so will be good idea to run this check on associated regression(s).

Nov 21 2018, 7:12 AM · Restricted Project, Restricted Project