Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 16

Petar.Avramovic added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

In getAddrNonPICSym64 Relocation looks to come from another SDValue (Hi bellow)
MipsISD::Hi doesn't seem to be connected with any of the target flags (like MipsII::MO_ABS_HI)

SDValue Shift = DAG.getNode(ISD::SHL ...
Fri, Aug 16, 4:25 AM · Restricted Project
Petar.Avramovic added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

@sdardis What is the difference between MipsHi and MipsLo SD nodes? Some of their patterns are the same, e.g. :

def : MipsPat<(add GPR64:$hi, (MipsHi (i64 tglobaladdr:$lo))),
              (DADDiu GPR64:$hi, tglobaladdr:$lo)>, ISA_MIPS3, GPR_64, SYM_64;
Fri, Aug 16, 3:23 AM · Restricted Project

Thu, Aug 15

Petar.Avramovic added a comment to D66228: [mips] Fix 64-bit address loading in case of applying 32-bit mask to the result.

I am not really sure if this is correct way to fix PR42736. I looked in td files and found a few inconsistencies, again I might have misinterpreted something.

Thu, Aug 15, 6:26 AM · Restricted Project

Wed, Aug 14

Petar.Avramovic added a child revision for D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT: D66205: [MIPS GlobalISel] NarrowScalar G_ZEXTLOAD and G_SEXTLOAD.
Wed, Aug 14, 2:00 AM · Restricted Project
Petar.Avramovic added a parent revision for D66205: [MIPS GlobalISel] NarrowScalar G_ZEXTLOAD and G_SEXTLOAD: D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT.
Wed, Aug 14, 2:00 AM · Restricted Project
Petar.Avramovic created D66205: [MIPS GlobalISel] NarrowScalar G_ZEXTLOAD and G_SEXTLOAD.
Wed, Aug 14, 1:56 AM · Restricted Project
Petar.Avramovic added parent revisions for D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT: D66181: [AArch64][GlobalISel] Add support for narrowScalar of G_ZEXT, D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882.
Wed, Aug 14, 1:55 AM · Restricted Project
Petar.Avramovic added a child revision for D66181: [AArch64][GlobalISel] Add support for narrowScalar of G_ZEXT: D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT.
Wed, Aug 14, 1:55 AM · Restricted Project
Petar.Avramovic added a child revision for D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882: D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT.
Wed, Aug 14, 1:55 AM · Restricted Project
Petar.Avramovic created D66204: [MIPS GlobalISel] NarrowScalar G_ZEXT and G_SEXT.
Wed, Aug 14, 1:54 AM · Restricted Project
Petar.Avramovic added a parent revision for D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882: D66202: [MIPS GlobalISel] NarrowScalar G_TRUNC .
Wed, Aug 14, 1:52 AM · Restricted Project
Petar.Avramovic added a child revision for D66202: [MIPS GlobalISel] NarrowScalar G_TRUNC : D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882.
Wed, Aug 14, 1:52 AM · Restricted Project
Petar.Avramovic created D66203: [MIPS GlobalISel] Consider type1 when legalizing shifts after r351882.
Wed, Aug 14, 1:52 AM · Restricted Project
Petar.Avramovic created D66202: [MIPS GlobalISel] NarrowScalar G_TRUNC .
Wed, Aug 14, 1:49 AM · Restricted Project

Fri, Aug 9

Petar.Avramovic added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

I don't think that matters as long as you process the rest of the instructions before aborting. That's what D65894 does, it keeps processing the instructions in InstList, then tries to combine the illegal artifacts if there is anything new. Do you have a test case that requires more complicated logic?

Yes, D65894 works perfectly fine for non legal artifacts, but it can't deal with legal artifacts that could be combined.
File withD61787.txt in D65199
line 920 in second file, Inspecting Artifact : %10:_(s32), %11:_(s32) = G_UNMERGE_VALUES %6:_(s64)

Fri, Aug 9, 3:40 PM · Restricted Project
Petar.Avramovic added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

In this case, moving %1 to AuxiliaryArtifactList doesn't make any difference because combining %9 will remove it anyway, even if it was in InstList. Since you already check the source registers before legalizing the artifacts, this shouldn't be a problem. What do you think?

Well in this example it is not a problem, but in more complicated case:
moving %1 to AuxiliaryArtifactList means that %1 will be legalized first if %9 failed to combine it away, %9 might be able to combine away the artifact that was produced during legalization of %1.
In general, this patch only combines Artfact from ArtifactList with some auxiliary artifact from AuxiliaryArtifactList, if something gets legalized to legal it will not dispersal from MF during some combine. It's a bit confusing to see instruction said to be legal during legalization but it is not in the final MF.

Fri, Aug 9, 8:52 AM · Restricted Project

Thu, Aug 8

Petar.Avramovic updated subscribers of D65199: [GlobalISel Legalizer][RFC] Legalization artifact combiner.
Thu, Aug 8, 5:48 AM
Petar.Avramovic added a reviewer for D61787: [GlobalISel Legalizer] Improve artifact combiner: paquette.

@volkan Regarding D65894.
Here, artifacts that failed to combine are moved to RetryList and we retry to combine them. Once all of the MachineInstrs that define use operands of our artifact are processed (are not in any of the Observer Lists) we turn artifact into an instruction. This way we have more opportunities for combines. e.g. in /test/AMDGPU/GlobalISel/legalize-unmerge-values.mir , this patch catches G_MERGE/G_UNMERGE combine that D65894 cannot catch because those two are declared legal.
As for the other test changes in D65894, all of them are essentially here.
I also tried test/CodeGen/AArch64/GlobalISel/retry-artifact-combine.mir and got similar output, but with one less copy instr.
there are differences in test/CodeGen/AMDGPU/GlobalISel/legalize-{xor|and|or}.mir
D65894 managed to combine few more G_TRUNC + G_ANYEXT but in the end both patches crash on %0:_(<4 x s8>) = G_TRUNC %29:_(<4 x s32>), because order of combine attempts is different this patch crashed before attempting to combine mentioned G_TRUNC + G_ANYEXT.
Please check if I missed something the this patch does not cover compared to D65894.

Thu, Aug 8, 5:47 AM · Restricted Project
Petar.Avramovic updated the diff for D61787: [GlobalISel Legalizer] Improve artifact combiner.

Refresh test changes. Ping.

Thu, Aug 8, 5:22 AM · Restricted Project
Petar.Avramovic committed rGcaef93069956: [MIPS GlobalISel] Select jump_table and brjt (authored by Petar.Avramovic).
[MIPS GlobalISel] Select jump_table and brjt
Thu, Aug 8, 3:23 AM
Petar.Avramovic committed rL368274: [MIPS GlobalISel] Select jump_table and brjt.
[MIPS GlobalISel] Select jump_table and brjt
Thu, Aug 8, 3:20 AM
Petar.Avramovic closed D65861: [MIPS GlobalISel] Select jump_table and brjt.
Thu, Aug 8, 3:20 AM · Restricted Project
Petar.Avramovic accepted D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.

LGTM.

Thu, Aug 8, 3:17 AM · Restricted Project
Petar.Avramovic added inline comments to D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules.
Thu, Aug 8, 3:17 AM · Restricted Project

Wed, Aug 7

Petar.Avramovic accepted D65830: [docs][mips] 9.0 Release notes.

LGTM.

Wed, Aug 7, 8:17 AM · Restricted Project
Petar.Avramovic created D65861: [MIPS GlobalISel] Select jump_table and brjt.
Wed, Aug 7, 4:59 AM · Restricted Project

Thu, Aug 1

Petar.Avramovic accepted D65524: [mips] Fix lowering load/store instruction in PIC case.

LGTM.

Thu, Aug 1, 6:38 AM · Restricted Project
Petar.Avramovic committed rG8a40cedfe695: [MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT (authored by Petar.Avramovic).
[MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT
Thu, Aug 1, 2:44 AM
Petar.Avramovic committed rL367535: [MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT.
[MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT
Thu, Aug 1, 2:43 AM
Petar.Avramovic closed D65507: [MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT.
Thu, Aug 1, 2:43 AM · Restricted Project

Wed, Jul 31

Petar.Avramovic created D65507: [MIPS GlobalISel] Fold load/store + G_GEP + G_CONSTANT.
Wed, Jul 31, 5:07 AM · Restricted Project

Fri, Jul 26

Petar.Avramovic committed rGcf2179456661: [MIPS GlobalISel] Fix check for void return during lowerCall (authored by Petar.Avramovic).
[MIPS GlobalISel] Fix check for void return during lowerCall
Fri, Jul 26, 6:22 AM
Petar.Avramovic committed rL367107: [MIPS GlobalISel] Fix check for void return during lowerCall.
[MIPS GlobalISel] Fix check for void return during lowerCall
Fri, Jul 26, 6:19 AM
Petar.Avramovic closed D65321: [MIPS GlobalISel] Fix check for void return during lowerCall.
Fri, Jul 26, 6:19 AM · Restricted Project
Petar.Avramovic added a comment to D65321: [MIPS GlobalISel] Fix check for void return during lowerCall.

Thanks for review.

Fri, Jul 26, 6:14 AM · Restricted Project
Petar.Avramovic committed rGb1fc6f613016: [MIPS GlobalISel] Select inttoptr and ptrtoint (authored by Petar.Avramovic).
[MIPS GlobalISel] Select inttoptr and ptrtoint
Fri, Jul 26, 6:10 AM
Petar.Avramovic committed rL367104: [MIPS GlobalISel] Select inttoptr and ptrtoint.
[MIPS GlobalISel] Select inttoptr and ptrtoint
Fri, Jul 26, 6:10 AM
Petar.Avramovic closed D65217: [MIPS GlobalISel] Select inttoptr and ptrtoint .
Fri, Jul 26, 6:09 AM · Restricted Project
Petar.Avramovic added a comment to D65219: [RISCV GlobalISel] Adding initial GlobalISel infrastructure.

Since there are no generic instructions in test function you can run all globalisel passes for it, not just irtranslator.
I got two compiler/tablegen warnings. Other then that look good.

Fri, Jul 26, 2:22 AM · Restricted Project
Petar.Avramovic created D65321: [MIPS GlobalISel] Fix check for void return during lowerCall.
Fri, Jul 26, 1:05 AM · Restricted Project
Petar.Avramovic abandoned D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP.

r367060

Fri, Jul 26, 12:41 AM · Restricted Project

Thu, Jul 25

Petar.Avramovic updated subscribers of D65199: [GlobalISel Legalizer][RFC] Legalization artifact combiner.
Thu, Jul 25, 4:36 AM
Petar.Avramovic added a comment to D61787: [GlobalISel Legalizer] Improve artifact combiner.

I understand that doing this may allow more artifacts to be combined away, but it shouldn't change the legality of anything coming out of the legalizer, if properly specified, right?

Absolutely. When some artifact is legal it can leave legalizer. It also needs few other instructions that are legal for same types so that it can connect them. e.g. for AArch64 G_PHI is legal for s8 and G_ADD is legal for s32 you expect s32 = G_ZEXT s8 to be legal and could leave legalizer since we could have sequence like this:

%10:_(s8) = G_PHI ....
%11:_(s32) = G_ZEXT %10:(s8)
%12:_(s32) = G_ADD %11:(s32), %8:(s32)

This patch does not affect legal artifacts in any way (it might be able to perform few combines more then what we have atm because it checks if uncombined artifact is chained to some unprocessed instr and might try to combine again later).
It won't ask artifact is it legal as long there is a instr in some of the lists that could create other half necessary for combine (here I named other half auxiliary artifact).

Thu, Jul 25, 4:36 AM · Restricted Project
Petar.Avramovic added a comment to rL366943: [AArch64][GlobalISel] Fix a crash during s128 G_ICMP legalization due to….

I thought about this but G_SELECT for aarch64 is only legal for s1 type1 (the condition).
That is why I used s1 for condition in G_SELECT since it is default type and backends can deal with it. maxScalar(1, s1) or D65079 could fix this.

Thu, Jul 25, 3:19 AM

Wed, Jul 24

Petar.Avramovic created D65217: [MIPS GlobalISel] Select inttoptr and ptrtoint .
Wed, Jul 24, 8:41 AM · Restricted Project
Petar.Avramovic updated the diff for D61787: [GlobalISel Legalizer] Improve artifact combiner.

Updated regression tests.

Wed, Jul 24, 6:34 AM · Restricted Project
Petar.Avramovic added a comment to D65199: [GlobalISel Legalizer][RFC] Legalization artifact combiner.

Here are two files with -debug outputs from fame input test. One was generated with D61787 other without it. Test file contains:

define void @trunc(i32* %i32_ptr_a, i32* %i32_ptr_b) {
entry:
  %0 = load i32, i32* %i32_ptr_a, align 4
  %tobool = trunc i32 %0 to i1
  %frombool2 = sext i1 %tobool to i8
  %fromchar3 = zext i8 %frombool2 to i32
  store i32 %fromchar3, i32* %i32_ptr_b, align 4
  ret void
}
Wed, Jul 24, 4:55 AM
Petar.Avramovic updated subscribers of D65199: [GlobalISel Legalizer][RFC] Legalization artifact combiner.

About 2. we are missing necessary combine
We have some recursive combine attempts with G_TRUNC jumping to its use and attempting the combine from there.
This way both parts, G_TRUNC on one side G_ZEXT, G_SEXT or G_ANYEXT on the other, can perform combine.
But then all of them have to be ALWAYS legal, despite the fact they are not selectable, for artifact combiner to be able to perform combine.
If this is the right way to go, we are missing recursive combines for G_MERGE_VALUES, G_CONCAT_VECTORS, G_BUILD_VECTOR similar to G_TRUNC but then all artifacts have to be legal always.
@dsanders Did you have other combines in mind?

Wed, Jul 24, 4:30 AM
Petar.Avramovic created D65199: [GlobalISel Legalizer][RFC] Legalization artifact combiner.
Wed, Jul 24, 4:28 AM

Mon, Jul 22

Petar.Avramovic added a comment to D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP.

@brzycki
I don't have necessary toolchain for full build, but from error report it is most likely __int128 compare. I made small test that triggers same assert. Does it work now?

Mon, Jul 22, 6:02 AM · Restricted Project
Petar.Avramovic created D65079: [GlobalISel][AArch64] Fix narrowScalar for G_ICMP.
Mon, Jul 22, 5:59 AM · Restricted Project

Fri, Jul 19

Petar.Avramovic added a comment to D64856: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.

Hello @brzycki, I will take a closer look on Monday.
Quick guess is that swapping lines 310,311 in AArch64LegalizerInfo.cpp (rules for G_ICMP) could fix the problem:
i.e. to change

.clampScalar(0, s32, s32)
.clampScalar(1, s32, s64)

into this:

.clampScalar(1, s32, s64)
.clampScalar(0, s32, s32)

I assumed that G_ICMP gets narrowScalared in default form with s1 as a result, but it looks like that is not always the case.
I will try to fix this in narrow scalar so that there is no need for specific ordering of legalization rules for some generic opcodes.

Fri, Jul 19, 1:56 PM · Restricted Project

Jul 17 2019

Petar.Avramovic committed rG1e62635d0551: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP (authored by Petar.Avramovic).
[MIPS GlobalISel] ClampScalar and select pointer G_ICMP
Jul 17 2019, 5:09 AM
Petar.Avramovic committed rL366317: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.
[MIPS GlobalISel] ClampScalar and select pointer G_ICMP
Jul 17 2019, 5:09 AM
Petar.Avramovic closed D64856: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.
Jul 17 2019, 5:09 AM · Restricted Project
Petar.Avramovic created D64856: [MIPS GlobalISel] ClampScalar and select pointer G_ICMP.
Jul 17 2019, 2:35 AM · Restricted Project

Jul 16 2019

Petar.Avramovic accepted D64792: [mips] Support the "o" inline asm constraint.

LGTM.

Jul 16 2019, 6:50 AM · Restricted Project
Petar.Avramovic accepted D64743: [mips] Implement .cplocal directive.

LGTM.

Jul 16 2019, 4:23 AM · Restricted Project

Jul 11 2019

Petar.Avramovic accepted D64552: [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6.

LGTM.

Jul 11 2019, 6:46 AM · Restricted Project
Petar.Avramovic committed rG962524070a0d: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses (authored by Petar.Avramovic).
[MIPS GlobalISel] Skip copies in addUseDef and addDefUses
Jul 11 2019, 2:31 AM
Petar.Avramovic committed rL365744: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses.
[MIPS GlobalISel] Skip copies in addUseDef and addDefUses
Jul 11 2019, 2:28 AM
Petar.Avramovic closed D64486: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses.
Jul 11 2019, 2:28 AM · Restricted Project
Petar.Avramovic committed rGe3bb0a72b6ad: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions (authored by Petar.Avramovic).
[MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions
Jul 11 2019, 2:25 AM
Petar.Avramovic committed rL365743: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.
[MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions
Jul 11 2019, 2:22 AM
Petar.Avramovic closed D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.
Jul 11 2019, 2:22 AM · Restricted Project
Petar.Avramovic updated the diff for D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.

Addressed review comments.

Jul 11 2019, 1:38 AM · Restricted Project

Jul 10 2019

Petar.Avramovic added a child revision for D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions: D64486: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses.
Jul 10 2019, 6:51 AM · Restricted Project
Petar.Avramovic added a parent revision for D64486: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses: D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.
Jul 10 2019, 6:51 AM · Restricted Project
Petar.Avramovic created D64485: [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions.
Jul 10 2019, 6:49 AM · Restricted Project
Petar.Avramovic created D64486: [MIPS GlobalISel] Skip copies in addUseDef and addDefUses.
Jul 10 2019, 6:49 AM · Restricted Project
Petar.Avramovic committed rG7d0778ea6bce: [MIPS GlobalISel] Select float and double phi (authored by Petar.Avramovic).
[MIPS GlobalISel] Select float and double phi
Jul 10 2019, 6:19 AM
Petar.Avramovic committed rL365627: [MIPS GlobalISel] Select float and double phi.
[MIPS GlobalISel] Select float and double phi
Jul 10 2019, 6:19 AM
Petar.Avramovic closed D64420: [MIPS GlobalISel] Select float and double phi.
Jul 10 2019, 6:19 AM · Restricted Project
Petar.Avramovic updated the diff for D64420: [MIPS GlobalISel] Select float and double phi.

Addressed review comments.

Jul 10 2019, 6:12 AM · Restricted Project
Petar.Avramovic committed rG7b31491ae23a: [MIPS GlobalISel] Select float and double load and store (authored by Petar.Avramovic).
[MIPS GlobalISel] Select float and double load and store
Jul 10 2019, 5:56 AM
Petar.Avramovic committed rL365626: [MIPS GlobalISel] Select float and double load and store.
[MIPS GlobalISel] Select float and double load and store
Jul 10 2019, 5:56 AM
Petar.Avramovic closed D64419: [MIPS GlobalISel] Select float and double load and store.
Jul 10 2019, 5:56 AM · Restricted Project
Petar.Avramovic updated the diff for D64419: [MIPS GlobalISel] Select float and double load and store.

Addressed review comments.

Jul 10 2019, 5:26 AM · Restricted Project

Jul 9 2019

Petar.Avramovic created D64420: [MIPS GlobalISel] Select float and double phi.
Jul 9 2019, 8:13 AM · Restricted Project
Petar.Avramovic created D64419: [MIPS GlobalISel] Select float and double load and store.
Jul 9 2019, 8:12 AM · Restricted Project
Petar.Avramovic committed rGbe20e36107c5: [MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi (authored by Petar.Avramovic).
[MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi
Jul 9 2019, 7:37 AM
Petar.Avramovic committed rL365494: [MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi.
[MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi
Jul 9 2019, 7:36 AM
Petar.Avramovic closed D64351: [MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi.
Jul 9 2019, 7:36 AM · Restricted Project
Petar.Avramovic committed rGdbb6d01d340f: [MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select (authored by Petar.Avramovic).
[MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select
Jul 9 2019, 7:34 AM
Petar.Avramovic committed rL365492: [MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select.
[MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select
Jul 9 2019, 7:33 AM
Petar.Avramovic closed D64350: [MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select.
Jul 9 2019, 7:33 AM · Restricted Project

Jul 8 2019

Petar.Avramovic created D64351: [MIPS GlobalISel] Register bank select for G_PHI. Select i64 phi.
Jul 8 2019, 8:53 AM · Restricted Project
Petar.Avramovic created D64350: [MIPS GlobalISel] Regbanks for G_SELECT. Select i64, f32 and f64 select.
Jul 8 2019, 8:53 AM · Restricted Project
Petar.Avramovic committed rGaa699b20a002: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load (authored by Petar.Avramovic).
[MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load
Jul 8 2019, 7:49 AM
Petar.Avramovic committed rL365323: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load.
[MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load
Jul 8 2019, 7:49 AM
Petar.Avramovic closed D64269: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load.
Jul 8 2019, 7:49 AM · Restricted Project
Petar.Avramovic committed rGec575f6e3e57: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store (authored by Petar.Avramovic).
[MIPS GlobalISel] Register bank select for G_STORE. Select i64 store
Jul 8 2019, 7:40 AM
Petar.Avramovic committed rL365322: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store.
[MIPS GlobalISel] Register bank select for G_STORE. Select i64 store
Jul 8 2019, 7:36 AM
Petar.Avramovic closed D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store.
Jul 8 2019, 7:36 AM · Restricted Project
Petar.Avramovic updated the diff for D64269: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load.

Addressed review comments.

Jul 8 2019, 7:20 AM · Restricted Project
Petar.Avramovic updated the diff for D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store.

Addressed review comments.

Jul 8 2019, 7:03 AM · Restricted Project
Petar.Avramovic accepted D64314: [mips] Implement sge/sgeu pseudo instructions.

LGTM.

Jul 8 2019, 6:42 AM · Restricted Project
Petar.Avramovic accepted D64313: [mips] Implement sgt/sgtu pseudo instructions with immediate operand.

LGTM.

Jul 8 2019, 6:37 AM · Restricted Project

Jul 5 2019

Petar.Avramovic added a parent revision for D64269: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load: D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store.
Jul 5 2019, 2:28 PM · Restricted Project
Petar.Avramovic added a child revision for D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store: D64269: [MIPS GlobalISel] Register bank select for G_LOAD. Select i64 load.
Jul 5 2019, 2:28 PM · Restricted Project