Page MenuHomePhabricator
Feed Advanced Search

Feb 26 2020

rsmith committed rG98ed0c5475df: PR44978: Accept as an extension some cases where destructor name lookup is… (authored by rsmith).
PR44978: Accept as an extension some cases where destructor name lookup is…
Feb 26 2020, 2:57 PM

Feb 25 2020

rsmith accepted D73020: [Sema] Perform call checking when building CXXNewExpr.

Looks good if you change the error to a warning.

I'm going to treat that as an implicit accept since the error got changed into a warning.

Feb 25 2020, 2:08 PM · Restricted Project
rsmith added a comment to D74684: [Sema][C++] Adopt DR2171 relaxed triviality requirements.

This change should be guarded by -fclang-abi-compat= so that users can opt to using the old ABI.

Feb 25 2020, 10:56 AM · Restricted Project
rsmith accepted D74418: [clang] fix error detection in consteval calls.

Given the comment at the start of lib/AST/ExprConstant.cpp, this seems reasonable to me. I do wonder if it'd be better to return an enum constant/not-constant-but-foldable/not-foldable from the evaluator, rather than just a bool. But not as part of this patch :)

Feb 25 2020, 10:48 AM · Restricted Project
rsmith added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Feb 25 2020, 9:51 AM · Restricted Project

Feb 23 2020

rsmith added inline comments to D74643: [Parse] Fix `TryParsePtrOperatorSeq`..
Feb 23 2020, 11:13 AM · Restricted Project

Feb 22 2020

rsmith accepted D74643: [Parse] Fix `TryParsePtrOperatorSeq`..
Feb 22 2020, 7:02 PM · Restricted Project

Feb 20 2020

rsmith committed rG6d34a87bae6e: [cxx_status] Update -std= instructions for C++20. (authored by rsmith).
[cxx_status] Update -std= instructions for C++20.
Feb 20 2020, 11:43 AM
rsmith added a comment to D71920: [AST] Refactor propagation of dependency bits. NFC.

If you'd like to have concept::Requirement use a similar bitfield, I'd just like to confirm my understanding of the current code before refactoring it:

  • there's just one Dependent bit (along with UnexpandedPack) - instantiation-dependence isn't relevant?
Feb 20 2020, 9:52 AM · Restricted Project
rsmith added a comment to D71920: [AST] Refactor propagation of dependency bits. NFC.

@rsmith Friendly ping. Do you want to review this/other patches in this sequence, or should we be a bit bolder and pull you in when we're uncertain in principle what to do?

Feb 20 2020, 9:43 AM · Restricted Project

Feb 19 2020

rsmith added a comment to D73245: Avoid using std::max_align_t in pre-C++11 mode.

On the assumption that we will never get a ::max_align_t in C++98 mode anyway (which will be the case if the <stdlib.h> is conforming), this looks like the best we can do to me.

Feb 19 2020, 1:59 PM · Restricted Project
rsmith committed rG5175565cf154: Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang user… (authored by rsmith).
Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang user…
Feb 19 2020, 1:40 PM

Feb 18 2020

rsmith committed rG061f3a50dd82: P0593R6: Pseudo-destructor expressions end object lifetimes. (authored by rsmith).
P0593R6: Pseudo-destructor expressions end object lifetimes.
Feb 18 2020, 6:48 PM
rsmith committed rG24ad12158245: Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang user… (authored by rsmith).
Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang user…
Feb 18 2020, 4:22 PM
rsmith committed rGe28d9bae4b3b: PR44958: Allow member calls and typeid / dynamic_cast on mutable objects and… (authored by rsmith).
PR44958: Allow member calls and typeid / dynamic_cast on mutable objects and…
Feb 18 2020, 3:02 PM

Feb 15 2020

rsmith committed rG34bd51f4b1d9: PR44890: Inherit explicitly-specified template arguments into base class… (authored by rsmith).
PR44890: Inherit explicitly-specified template arguments into base class…
Feb 15 2020, 2:53 AM
rsmith committed rGb74a381296ee: [cxx_status] New papers from Prague 2020 WG21 meeting. (authored by rsmith).
[cxx_status] New papers from Prague 2020 WG21 meeting.
Feb 15 2020, 2:53 AM

Feb 14 2020

rsmith added a comment to D74051: Move update_cc_test_checks.py tests to clang.

@rsmith Does clang/test/utils/ (a new directory) look appropriate to you?

Feb 14 2020, 2:21 AM · Restricted Project, Restricted Project
rsmith accepted D74051: Move update_cc_test_checks.py tests to clang.
Feb 14 2020, 2:21 AM · Restricted Project, Restricted Project

Feb 13 2020

rsmith committed rGc1394afb8df6: Don't call memcpy(p, 0, 0). (authored by rsmith).
Don't call memcpy(p, 0, 0).
Feb 13 2020, 1:00 AM
rsmith added a comment to D73637: Fix handling of OO_Spaceship in DecodeOperatorCall.

An equivalent patch was landed as llvmorg-11-init-2132-gb96c6b65b93 to fix PR44786. Thanks!

Feb 13 2020, 12:59 AM · Restricted Project

Feb 11 2020

rsmith added a comment to D71241: [OpenMP][WIP] Use overload centric declare variants.

Most probably, we can use this solution without adding a new expression. DeclRefExpr class can contain 2 decls: FoundDecl and the Decl being used. You can use FoundDecl to point to the original function and used decl to point to the function being called in this context. But at first, we need to be sure that we can handle all corner cases correctly.

What new expression are you talking about?

To be clear, I believe he's talking about the new expression that I proposed we add in order to represent this kind of call. If that's not needed, and we can use the FoundDecl/Decl pair for that purpose, that should also be considered.

This solution already does point to both declarations, as shown here: https://reviews.llvm.org/D71241#1782504

Exactly. We need to check if the MemberRefExpr can do this too to handle member functions correctly.
And need to wait for opinion from Richard Smith about the design. We need to be sure that it won't break compatibility with C/C++ in some corner cases. Design bugs are very hard to solve and I want to be sure that we don't miss anything. And we provide full compatibility with both C and C++.

Feb 11 2020, 11:10 AM · Restricted Project
rsmith committed rG9ce6dc9872be: CWG1423: don't permit implicit conversion of nullptr_t to bool. (authored by rsmith).
CWG1423: don't permit implicit conversion of nullptr_t to bool.
Feb 11 2020, 6:56 AM
rsmith committed rG7ef45f45f672: P1957R2: conversion from a pointer to bool is considered narrowing. (authored by rsmith).
P1957R2: conversion from a pointer to bool is considered narrowing.
Feb 11 2020, 6:56 AM

Feb 10 2020

rsmith committed rGfcea7fbdba1b: CWG2445: For function template partial ordering, take reversal of function… (authored by rsmith).
CWG2445: For function template partial ordering, take reversal of function…
Feb 10 2020, 6:12 AM
rsmith committed rG76f888d0a532: Fix handling of destructor names that name typedefs. (authored by rsmith).
Fix handling of destructor names that name typedefs.
Feb 10 2020, 2:22 AM

Feb 7 2020

rsmith committed rG0e3a48778408: PR12350: Handle remaining cases permitted by CWG DR 244. (authored by rsmith).
PR12350: Handle remaining cases permitted by CWG DR 244.
Feb 7 2020, 6:47 PM
rsmith requested changes to D69272: Enable '#pragma STDC FENV_ACCESS' in frontend.

I don't see any changes to the constant evaluator here. You need to properly handle constant evaluation within FENV_ACCESS ON contexts, somehow, or you'll miscompile floating-point operations with constant operands. Probably the easiest thing would be to treat all rounded FP operations as non-constant in an FENV_ACCESS ON region, though in C++ constexpr evaluations we could permit rounded FP operations if the evaluation began in an FENV_ACCESS OFF region (that way we know the computations should be done in the default FP environment because feset* are not constexpr functions).

Feb 7 2020, 5:08 PM · Restricted Project
rsmith committed rG42efd35ba04d: [cxx_status] Fix status of P1766R to not bleed into adjacent cells. (authored by rsmith).
[cxx_status] Fix status of P1766R to not bleed into adjacent cells.
Feb 7 2020, 11:58 AM
rsmith committed rG7ae1b4a0ce9c: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for… (authored by rsmith).
Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for…
Feb 7 2020, 11:49 AM
rsmith closed D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..
Feb 7 2020, 11:49 AM · Restricted Project

Feb 6 2020

rsmith added a comment to D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..

Ugh, you mentioned template argument lists and made me realize we can still reach problem cases that way. And with array bounds. :(

Feb 6 2020, 5:11 PM · Restricted Project
rsmith updated the diff for D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..

Add back a diagnostic for remaining cases that the new langauge rule doesn't handle.

Feb 6 2020, 5:09 PM · Restricted Project
rsmith committed rG96c899449b61: C++ DR2026: static storage duration variables are not zeroed before constant… (authored by rsmith).
C++ DR2026: static storage duration variables are not zeroed before constant…
Feb 6 2020, 4:42 PM
rsmith updated the diff for D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..

Extend assert comment to suggest likely remediations.

Feb 6 2020, 4:42 PM · Restricted Project
rsmith added inline comments to D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..
Feb 6 2020, 3:02 PM · Restricted Project
rsmith updated the diff for D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..

Add test coverage for the 'friend' case.

Feb 6 2020, 3:02 PM · Restricted Project
rsmith updated the diff for D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..

Updates based on review comments from @rjmccall.

Feb 6 2020, 3:02 PM · Restricted Project
rsmith committed rGda3dc0011e06: PR44684: Look through parens and similar constructs when determining whether a… (authored by rsmith).
PR44684: Look through parens and similar constructs when determining whether a…
Feb 6 2020, 12:24 PM
rsmith added a reverting change for rGaaae6b1b6173: Revert "PR44684: Look through parens and similar constructs when determining": rGda3dc0011e06: PR44684: Look through parens and similar constructs when determining whether a….
Feb 6 2020, 12:24 PM
rsmith added a comment to D73967: Implement _ExtInt as an extended int type specifier..

Extended-vector types don't really make sense for non-powers-of-two (plus have some odd gotchas when it comes to vectors of i1 for example), so I've added a test that shows that this is rejected.

Feb 6 2020, 11:37 AM · Restricted Project

Feb 5 2020

rsmith created D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes..
Feb 5 2020, 6:57 PM · Restricted Project
rsmith added a comment to D73967: Implement _ExtInt as an extended int type specifier..

Have you considered how this would interact with our other language extensions? Can we form a vector of _ExtInt(N)? A _Complex _ExtInt(N)? I expect for some of that to just fall out of the implementation, but we should have documentation and test coverage either way.

Feb 5 2020, 6:30 PM · Restricted Project
rsmith added a comment to D68896: PR43080: Do not build context-sensitive expressions during name classification..

Hi, I am still seeing problems with this assertion. Could we please get a fix? I've posted the reduced test case and reproducible command on this Phabricator patch.

Are you still seeing problems?

Feb 5 2020, 5:34 PM · Restricted Project
rsmith added a comment to D68896: PR43080: Do not build context-sensitive expressions during name classification..

Hi, I am still seeing problems with this assertion. Could we please get a fix? I've posted the reduced test case and reproducible command on this Phabricator patch.

Feb 5 2020, 5:32 PM · Restricted Project

Feb 4 2020

rsmith accepted D73701: [clang] fix linkage of nested lambda.
Feb 4 2020, 6:49 PM · Restricted Project
rsmith added inline comments to D74007: [clang] Add support for consteval constructors.
Feb 4 2020, 6:40 PM · Restricted Project
rsmith committed rGb833e0c5f119: PR44786: Don't assert when profiling <=> expressions. (authored by rsmith).
PR44786: Don't assert when profiling <=> expressions.
Feb 4 2020, 6:31 PM
rsmith committed rGb96c6b65b93f: PR44786: Don't assert when profiling <=> expressions. (authored by rsmith).
PR44786: Don't assert when profiling <=> expressions.
Feb 4 2020, 6:31 PM
rsmith added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Feb 4 2020, 6:21 PM · Restricted Project
rsmith added a comment to D74009: [clang] Improve diagnostic note for implicit conversions that are disallowed because they involve more than one user-defined conversion..

This is an interesting idea. Have you looked into whether you can defer the check for conversion via multiple user-defined conversions until we come to call CompleteNonViableCandidate after finding no viable functions? That'd give me a lot more confidence that this won't introduce a noticeable performance regression for pathological cases (eg, considering a quadratic -- or worse -- number of combinations of constructors and conversion functions).

Feb 4 2020, 5:44 PM · Restricted Project
rsmith committed rG7a94fc09d17b: PR44721: Don't consider overloaded operators for built-in comparisons when… (authored by rsmith).
PR44721: Don't consider overloaded operators for built-in comparisons when…
Feb 4 2020, 12:42 PM
rsmith added a comment to D73020: [Sema] Perform call checking when building CXXNewExpr.

Looks good if you change the error to a warning.

Feb 4 2020, 12:42 PM · Restricted Project
rsmith committed rG300cbdc59da0: PR44761: Fix fallback to later tiebreakers if two non-template functions are… (authored by rsmith).
PR44761: Fix fallback to later tiebreakers if two non-template functions are…
Feb 4 2020, 12:23 PM
rsmith committed rGcfacf9ae20b8: PR44761: Fix fallback to later tiebreakers if two non-template functions are… (authored by rsmith).
PR44761: Fix fallback to later tiebreakers if two non-template functions are…
Feb 4 2020, 12:23 PM
rsmith committed rGc99fa0b80cc9: Additional testcase for 0130b6cb5a8. (authored by rsmith).
Additional testcase for 0130b6cb5a8.
Feb 4 2020, 12:23 PM
rsmith accepted D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

Looks fine.

Feb 4 2020, 12:12 PM · Restricted Project

Feb 3 2020

rsmith added a comment to D73020: [Sema] Perform call checking when building CXXNewExpr.

It would be really useful to provide these extra parameters to FindAllocationFunctions too. For example, we could support direct dispatch to a size-class-specific allocation function:

Feb 3 2020, 6:41 PM · Restricted Project
rsmith accepted D73380: [clang] Annotating C++'s `operator new` with more attributes.
Feb 3 2020, 6:31 PM · Restricted Project, Restricted Project
rsmith added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

If there's no timeline to update the macOS SDK, then perhaps we could add a hack to Clang to allow these conversions only in limited contexts (the specific parts of the macOS SDK that are relying on them). Do you know how many such places there might be? If it's just a few functions, we could match against the function names, or depending on what SIMD_CFUNC expands to, perhaps we could match that. Failing that, we could set a platform-specific default or similar.

A hack like this sounds pragmatic to me. An initial look suggests it's a small number of frameworks; I suspect many functions, but we could potentially match on partial file path or SIMD_CFUNC. We need a deeper audit across our internal stack to be sure, though. I don't think we'll have bandwidth for that until ~late February.

Feb 3 2020, 6:22 PM · Restricted Project
rsmith accepted D63960: [C++20] Add consteval-specific semantic for functions.

Some nits and very minor things, but I think this is generally good to go with those fixed. Sorry for the long review delay, and thanks for working on it!

Feb 3 2020, 6:22 PM · Restricted Project

Jan 31 2020

rsmith committed rG0130b6cb5a8d: Don't assume a reference refers to at least sizeof(T) bytes. (authored by rsmith).
Don't assume a reference refers to at least sizeof(T) bytes.
Jan 31 2020, 7:09 PM
rsmith committed rGf85d63a55836: Fix wrong devirtualization when the final overrider in one base class overrides… (authored by rsmith).
Fix wrong devirtualization when the final overrider in one base class overrides…
Jan 31 2020, 5:12 PM
rsmith committed rGaade5fbbfef3: Fix wrong devirtualization when the final overrider in one base class overrides… (authored by rsmith).
Fix wrong devirtualization when the final overrider in one base class overrides…
Jan 31 2020, 5:12 PM
rsmith committed rGde876adab0cb: [diagtree] Use a different color for unimplemented GCC diagnostic flags instead… (authored by rsmith).
[diagtree] Use a different color for unimplemented GCC diagnostic flags instead…
Jan 31 2020, 1:41 PM
rsmith committed rGfdedf39c46f5: PR44723: Trigger return type deduction for operator<=>s whose return types are… (authored by rsmith).
PR44723: Trigger return type deduction for operator<=>s whose return types are…
Jan 31 2020, 1:12 PM
rsmith committed rG42d4a55f227a: PR44723: Trigger return type deduction for operator<=>s whose return types are… (authored by rsmith).
PR44723: Trigger return type deduction for operator<=>s whose return types are…
Jan 31 2020, 1:12 PM
rsmith accepted D68923: Don't warn about missing declarations for partial template specializations.

Sorry I missed this before now.

Jan 31 2020, 10:26 AM · Restricted Project

Jan 30 2020

rsmith committed rG904d146c5f55: PR44627: Consider reversing == and <=> candidates found by ADL. (authored by rsmith).
PR44627: Consider reversing == and <=> candidates found by ADL.
Jan 30 2020, 6:50 PM
rsmith committed rG1db66e705f4d: PR44627: Consider reversing == and <=> candidates found by ADL. (authored by rsmith).
PR44627: Consider reversing == and <=> candidates found by ADL.
Jan 30 2020, 6:42 PM
rsmith added a comment to D73701: [clang] fix linkage of nested lambda.

This is effectively reverting https://reviews.llvm.org/D1783. If we don't need that any more for whatever reason, can we also get rid of the check for whether the outermost lambda has a mangling number a few lines above? (Please also check if we can remove getOutermostEnclosingLambda, which was added for this purpose.)

Jan 30 2020, 6:32 PM · Restricted Project
rsmith committed rG5ae6554a1dcd: PR41991: Accept attributes on defaulted and deleted friends. (authored by rsmith).
PR41991: Accept attributes on defaulted and deleted friends.
Jan 30 2020, 5:47 PM
rsmith committed rG0ce7ea7c6e0e: PR41991: Accept attributes on defaulted and deleted friends. (authored by rsmith).
PR41991: Accept attributes on defaulted and deleted friends.
Jan 30 2020, 5:47 PM
rsmith added a comment to D73245: Avoid using std::max_align_t in pre-C++11 mode.

libc++ intentionally provides all the C++11 library functionality that it can, even when used from C++03 mode. So on the face of it, providing this name in C++03 mode seems appropriate.

Jan 30 2020, 5:46 PM · Restricted Project
rsmith committed rG1f3f8c369a50: PR44721: Don't consider overloaded operators for built-in comparisons when… (authored by rsmith).
PR44721: Don't consider overloaded operators for built-in comparisons when…
Jan 30 2020, 5:19 PM
rsmith committed rGd28763cad06e: Replace 'AllowExplicit' bool with an enum. No functionality change. (authored by rsmith).
Replace 'AllowExplicit' bool with an enum. No functionality change.
Jan 30 2020, 5:19 PM

Jan 27 2020

rsmith committed rGaf80b8ccc577: PR44684: Look through parens and similar constructs when determining whether a… (authored by rsmith).
PR44684: Look through parens and similar constructs when determining whether a…
Jan 27 2020, 6:21 PM
rsmith added a comment to D71920: [AST] Refactor propagation of dependency bits. NFC.

I don't like the name getDependencies, because the function is not getting a list of dependencies, it's getting flags that indicate whether certain properties of the construct are dependent. Maybe getDependence or getDependenceFlags would be a better name? Likewise, instead of addDependencies, perhaps addDependence?

Jan 27 2020, 5:09 PM · Restricted Project

Jan 26 2020

rsmith added inline comments to D73380: [clang] Annotating C++'s `operator new` with more attributes.
Jan 26 2020, 12:04 PM · Restricted Project, Restricted Project

Jan 24 2020

rsmith added inline comments to D73380: [clang] Annotating C++'s `operator new` with more attributes.
Jan 24 2020, 7:09 PM · Restricted Project, Restricted Project
rsmith committed rG04f131da0b19: DR1753: Don't permit x.NS::~T() as a pseudo-destructor name. (authored by rsmith).
DR1753: Don't permit x.NS::~T() as a pseudo-destructor name.
Jan 24 2020, 7:01 PM
rsmith accepted D73388: NFC: Implement AST node skipping in ParentMapContext.

This seems reasonable to me.

Jan 24 2020, 7:00 PM · Restricted Project
rsmith accepted D73385: [Sema] Split availability processing into SemaAvailability.cpp.
Jan 24 2020, 3:32 PM · Restricted Project
rsmith added a comment to D73028: Extract ExprTraversal class from Expr.

The follow-up is here: https://reviews.llvm.org/D73029 .

I have the need to change the ascending traversal implemented in ASTContext.cpp with a map (populated while descending) to make it skip nodes too during parent traversal.

I didn't want to have descending traversal in Expr.cpp and ascending traversal in ASTContext.cpp as they would be likely to go out of sync, so moving this implementation here allows extending the purpose in the follow-up.

Jan 24 2020, 1:13 PM · Restricted Project
rsmith added a comment to D73029: Extend ExprTraversal class with acending traversal.

We're working on moving the parent map out of ASTContext and into something specific to tooling; please don't add more dependencies onto it in the AST library.

Jan 24 2020, 1:13 PM · Restricted Project
rsmith added a comment to D73028: Extract ExprTraversal class from Expr.

An addition to the API will be concerned with ascending through the AST in different traversal modes.

Jan 24 2020, 11:50 AM · Restricted Project

Jan 23 2020

rsmith requested changes to D72242: Fix crash on value dependent bitfields in if conditions in templates.

This is not an appropriate fix; the code is locally correct. The right way to handle this is exactly what Clang currently does: if the expression is not type-dependent, then contextually convert to bool, and if it's not value-dependent, then make sure it's a constant expression.

Jan 23 2020, 6:58 PM · Restricted Project
rsmith created D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..
Jan 23 2020, 4:40 PM · Restricted Project
rsmith committed rGfa2fc81d3464: Re-add documentation for -flax-vector-conversions= removed in… (authored by rsmith).
Re-add documentation for -flax-vector-conversions= removed in…
Jan 23 2020, 12:37 PM
rsmith committed rGed63454d984f: Update documentation and release notes to match the state of -flax-vector… (authored by rsmith).
Update documentation and release notes to match the state of -flax-vector…
Jan 23 2020, 12:28 PM
rsmith added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

@rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option?

Do you have a timeline for how long it would take to fix the MacOS SDK? Is this something we could realistically aim to do in Clang 11 instead? I would really prefer for us to not have different defaults for Darwin versus everywhere else, so if waiting one release cycle is enough, that seems fine.

I am also not sure if we have rules about SDK compatibility for releases and I can't say macOS SDK can definitely be fixed before clang 11 release. @dexonsmith @arphaman might have more info.

We can't comment on future releases.

That said, if this is urgent, let @arphaman know and we can try to qualify internally sometime in the next few months and we can report back what issues we find.

Jan 23 2020, 12:16 PM · Restricted Project
rsmith added inline comments to D73150: [Concepts] Remove -fconcepts-ts, enable concepts support under -std=c++2a.
Jan 23 2020, 11:56 AM · Restricted Project
rsmith accepted D73155: [Concepts] Implement P1616R1 - Using unconstrained template template parameters with constrained templates.
Jan 23 2020, 11:55 AM · Restricted Project
rsmith accepted D73153: [Concepts] Update ReleaseNotes with Concepts support.
Jan 23 2020, 11:51 AM · Restricted Project

Jan 22 2020

rsmith added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

I'll split out the new flag at least and re-land for Clang 10, while we figure out how to set the default.

Jan 22 2020, 6:17 PM · Restricted Project
rsmith added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

@rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option?

Jan 22 2020, 3:07 PM · Restricted Project
rsmith committed rGb32013baec1d: [www] Update cxx_status page to list changes on the Clang 10 branch as "Clang… (authored by rsmith).
[www] Update cxx_status page to list changes on the Clang 10 branch as "Clang…
Jan 22 2020, 2:50 PM

Jan 21 2020

rsmith added a comment to D72897: List implicit operator== after implicit destructors in a vtable..

Hi Richard,

http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test).
Sorry, but I'm going to revert these changes.

Jan 21 2020, 3:55 PM · Restricted Project
rsmith committed rG6e73fee78083: List implicit operator== after implicit destructors in a vtable. (authored by rsmith).
List implicit operator== after implicit destructors in a vtable.
Jan 21 2020, 3:55 PM
rsmith accepted D72552: [Concepts] Constraint Satisfaction Caching.

Mechanically, this looks fine.

Jan 21 2020, 1:10 PM · Restricted Project