Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 29

fweimer added a comment to D40319: [libcxx] Support getentropy as a source of randomness for std::random_device.

getentropy comes from OpenBSD (among others), and it's in <unistd.h> there:

Mon, Nov 29, 12:06 PM

Jun 29 2021

fweimer added inline comments to D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64.
Jun 29 2021, 11:02 AM · Restricted Project

Feb 26 2019

fweimer added a comment to D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD.

I don't think you added a new command line option. My suggestion was this:

  1. Add a new command line option, say, --intel-cet (that's perhaps not the final name of the option, I chose it tentatively to move things forward.)
  2. If --intel-cet is given, verify that each input file contains a .note section with an appropriate bit, and discard .note section after reading it (so we don't merge them or copy them to the output file). If there's a file that doesn't contain a proper .note, report an error and stop.
  3. When creating an input file, create a .note section with appropriate contents when --intel-cet was given.

Specifically, I don't think you should add a new member X86Feature1AND to Config because with the above scheme you are no longer merging .note section so you don't need to collect bits. mergeAggregateMetadata should also be deleted from the patch.

What do you think?

Feb 26 2019, 10:32 PM · Restricted Project, lld