Page MenuHomePhabricator
Feed Advanced Search

Wed, Dec 23

abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • Added a test case for OMP loop for merging
Wed, Dec 23, 6:43 PM · Restricted Project, Restricted Project

Dec 9 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Added a test for OpenMP for loop fusion. Is the sample test acceptable? I can add more in the same format.

Dec 9 2020, 8:48 AM · Restricted Project, Restricted Project

Dec 5 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

added a test. Would like to have feedback to add more.

Dec 5 2020, 6:43 PM · Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • added test case for parallel openmp for loop merging
Dec 5 2020, 6:42 PM · Restricted Project, Restricted Project

Nov 23 2020

abidmalikwaterloo added inline comments to D90103: Add OpenMP for optimization.
Nov 23 2020, 2:59 AM · Restricted Project, Restricted Project

Nov 22 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

The tests should be in llvm-project/llvm/test/Transforms/OpenMP.

Nov 22 2020, 2:54 PM · Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.
Nov 22 2020, 9:05 AM · Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • make changes in OpenMPOpt
Nov 22 2020, 7:27 AM · Restricted Project, Restricted Project

Nov 19 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

See the new patch

Nov 19 2020, 2:43 PM · Restricted Project
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Adding test cases

There are still no test cases.

Yes. I have tests. I will add it to the LIT and will update the patch.

Nov 19 2020, 2:35 PM · Restricted Project, Restricted Project

Oct 25 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Adding test cases

There are still no test cases.

Oct 25 2020, 9:59 AM · Restricted Project, Restricted Project

Oct 24 2020

abidmalikwaterloo requested review of D90103: Add OpenMP for optimization.
Oct 24 2020, 12:44 PM · Restricted Project, Restricted Project

Oct 14 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

I tried almost everything. Let me try again.

Oct 14 2020, 3:24 AM · Restricted Project

Oct 9 2020

abidmalikwaterloo requested review of D89132: OpenMP parallel for call elimination .
Oct 9 2020, 7:28 AM · Restricted Project

Oct 7 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

I have been trying to update my patch by following the steps on:

Oct 7 2020, 11:10 AM · Restricted Project

Oct 5 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

Yes, I am trying to figure it out why it is not loading my tests and changes

Oct 5 2020, 5:50 PM · Restricted Project
abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Oct 5 2020, 5:40 PM · Restricted Project
abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.

The patch now handles conditional blocks containing parallel for loops.

Oct 5 2020, 5:19 PM · Restricted Project

Jul 27 2020

abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Jul 27 2020, 1:42 PM · Restricted Project

Apr 7 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

This doesn't seem to use dominance at all. How do you handle

if (a) {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
} else {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
}

if the value of a is known at the time of compilation, we will only have one "for loop". Therefore, for this specific case, the implemented technique will see only one "for loop" at the IR level. This case should be a problem.

Apr 7 2020, 9:44 AM · Restricted Project
abidmalikwaterloo updated subscribers of D75384: OpenMP for loop fusion.
Apr 7 2020, 9:44 AM · Restricted Project

Apr 1 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

This doesn't seem to use dominance at all. How do you handle

if (a) {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
} else {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
}
Apr 1 2020, 4:20 PM · Restricted Project

Mar 12 2020

abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Mar 12 2020, 6:20 PM · Restricted Project

Feb 28 2020

abidmalikwaterloo created D75384: OpenMP for loop fusion.
Feb 28 2020, 1:42 PM · Restricted Project