Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 4 2023

GleasonK added a comment to D140994: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic.

Thanks for review - will need someone with commit access land this change.

Jan 4 2023, 8:19 AM · Restricted Project, Restricted Project
GleasonK requested review of D140994: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic.
Jan 4 2023, 8:05 AM · Restricted Project, Restricted Project

Dec 1 2022

GleasonK added a comment to D138235: Use consistent spacing before custom directives for op and attr/type assemblyFormat..

Relatively new to the LLVM community, and unsure of review conventions. I see this is marked as" accepted and ready to land", unsure if I am still waiting on feedback from remaining reviewers.

Dec 1 2022, 8:18 AM · Restricted Project, Restricted Project

Nov 17 2022

GleasonK requested review of D138235: Use consistent spacing before custom directives for op and attr/type assemblyFormat..
Nov 17 2022, 1:18 PM · Restricted Project, Restricted Project

Sep 30 2022

GleasonK added a comment to D134847: [mlir] Making verification after parsing optional.

Just noticed this config existed - will be very useful! Thanks!

Sep 30 2022, 9:11 AM · Restricted Project, Restricted Project

Sep 20 2022

GleasonK added a comment to D134206: Fix -fuse-ld to be linker flag in feature detection check.

Yes, thanks. I just tried and got 403 from the remote.

Sep 20 2022, 7:24 AM · Restricted Project, Restricted Project

Sep 19 2022

GleasonK added a comment to D134206: Fix -fuse-ld to be linker flag in feature detection check.
In D134206#3800765, @tschuett wrote:

I have similar issues, but I use -DLLVM_ENABLE_WERROR=ON.

Sep 19 2022, 1:37 PM · Restricted Project, Restricted Project
GleasonK requested review of D134206: Fix -fuse-ld to be linker flag in feature detection check.
Sep 19 2022, 12:11 PM · Restricted Project, Restricted Project